[PATCH] ARM: at91/dt: Fix sama5d3x typos.

2014-10-23 Thread Peter Rosin
From c23d712fe924b929c2eb39eba644fe74bcccfd37 Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@axentia.se Date: Thu, 23 Oct 2014 13:52:03 +0200 Subject: [PATCH] ARM: at91/dt: Fix sama5d3x typos. The DT compatible strings also need binding documentation, but that is for someone else to write

RE: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
Hi Peter, Thanks for your patch. And thanks for the Ack! Btw, do you use git send-email command to send the patch? No, I didn't, git format-patch and paste into the mail body. Was there some whitespace issues with the patch? Cheers, Peter -- To unsubscribe from this list: send the

Re: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
Ok, I'm trying with git send-email, sorry for the inconvenience. Cheers, Peter -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[PATCH] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-24 Thread Peter Rosin
) { perror(SNDCTL_DSP_SPEED); return 1; } return 0; } Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/atmel/atmel_ssc_dai.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel

[PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-20 Thread Peter Rosin
From 1e5621d7b9887c648d1a66238dc82d715c1e2cad Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@axentia.se Date: Mon, 20 Oct 2014 14:38:04 +0200 Subject: [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately. The CMR divider register is shared by playback and capture

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi! (and thank you for the pointer to the example with the ssc-dai in master mode) Hi Peter, On 10/20/2014 09:45 PM, Peter Rosin wrote: From 1e5621d7b9887c648d1a66238dc82d715c1e2cad Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@axentia.se Date: Mon, 20 Oct 2014 14:38:04 +0200

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi again! Hi Peter, On 10/21/2014 03:55 PM, Peter Rosin wrote: Hi! (and thank you for the pointer to the example with the ssc-dai in master mode) Hi Peter, On 10/20/2014 09:45 PM, Peter Rosin wrote: From 1e5621d7b9887c648d1a66238dc82d715c1e2cad Mon Sep 17 00:00:00 2001

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi again, -Original Message- From: Peter Rosin Sent: Tuesday, October 21, 2014 13:05 To: 'Bo Shen' Cc: Liam Girdwood; Mark Brown; Jaroslav Kysela; Takashi Iwai; 'alsa- de...@alsa-project.org'; linux-kernel@vger.kernel.org Subject: RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-21 Thread Peter Rosin
Hi! Hi Peter, On 10/21/2014 09:05 PM, Peter Rosin wrote: I did some further tests, and the following program fails without the patch: With the patch, it is OK? Yes. #include sys/ioctl.h #include unistd.h #include fcntl.h #include sys/soundcard.h int main(void

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-22 Thread Peter Rosin
Hi! With the patch, it is OK? Yes. #include sys/ioctl.h #include unistd.h #include fcntl.h #include sys/soundcard.h int main(void) { int fd; int format; int channels; if ((fd = open(/dev/dsp, O_WRONLY, 0)) == -1) { perror(open);

RE: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: Track playback and capture CMR dividers separately.

2014-10-22 Thread Peter Rosin
Bo Chen wrote: with this piece of code, I reproduce your issue. Now, I know the reason of this issue, work in oss mode, it will set the default clock to 8KHz, and then if change to other sample rate, for example 48KHz, the div is different, then it reports -EBUSY. Indeed. So, I think we

[PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex.

2014-10-22 Thread Peter Rosin
From 86be84c4de4e7b21cfda9656a02a902c543210af Mon Sep 17 00:00:00 2001 From: Peter Rosin p...@axentia.se Date: Wed, 22 Oct 2014 16:45:29 +0200 Subject: [PATCH v2] ASoC: atmel_ssc_dai: Match the CMR divider only in full duplex. The CMR divider register is shared by playback and capture. The SSC

RE: [PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
Thanks for the review! I'm answering here, but would like to thank Lars-Peter for the review as well. Mark Brown wrote: On Thu, Nov 06, 2014 at 01:54:00PM +0100, Peter Rosin wrote: +#define TFA9879_REG(codec, reg, field, value) \ + snd_soc_update_bits(codec, TFA9879_ ## reg

[PATCH v2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 323 sound/soc/codecs/tfa9879

[v2] NXP Semiconductors TFA9879 Amplifier Driver

2014-11-06 Thread Peter Rosin
On 2014-11-06 17:02, Mark Brown wrote: On Thu, Nov 06, 2014 at 02:37:31PM +, Peter Rosin wrote: Mark Brown wrote: +if (tfa9879-lsb_justified) +TFA9879_REG(codec, SERIAL_INTERFACE_1, I2S_SET, i2s_set); Why does this need to be reset every time, shouldn't we

NXP Semiconductors TFA9879 Amplifier Driver

2014-11-08 Thread Peter Rosin
Mark Brown wrote: On Thu, Nov 06, 2014 at 05:39:45PM +0100, Peter Rosin wrote: + { TFA9879_MISC_STATUS, 0x }, /* 0x15, read-only */ The fix here is the wrong way round - if the device is reporting status here there should be no default and there should be a volatile

[PATCH v3] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-08 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 328 sound/soc/codecs/tfa9879

[PATCH] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories

2014-12-22 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The DDRSDR controller (on the ATSAMA5D31) fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2 self-refresh spec is equivalent to LPDDR1, and is correctly

NXP Semiconductors TFA9879 Amplifier Driver

2014-11-06 Thread Peter Rosin
Hi! Sorry for not sending this from my axentia.se account, but I tend to get high spam-scores from there when I use git send-email. This is a new driver, and it's pretty minimalistic with support for only a few basic controls. However, it is usable and I'd be happy to see it included. I don't

[PATCH 1/2] ASoC: tfa9879: New driver for NXP Semiconductors TFA9879 amplifier.

2014-11-06 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- MAINTAINERS|6 + sound/soc/codecs/Kconfig |5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/tfa9879.c | 334 sound/soc/codecs/tfa9879

[PATCH 2/2] ASoC: tfa9879: Add bass and treble gain/freq controls.

2014-11-06 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/tfa9879.c | 16 1 file changed, 16 insertions(+) diff --git a/sound/soc/codecs/tfa9879.c b/sound/soc/codecs/tfa9879.c index 90cc28f7e6ed..0d62962542e2 100644 --- a/sound/soc

[PATCH] ASoC: Augment existing card DAPM routes in snd_soc_of_parse_audio_routing

2014-11-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se If a snd_soc_card has any DAPM routes when it calls snd_soc_of_parse_audio_routing, those are clobbered without this change. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/soc-core.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions

RE: [PATCH] ASoC: Augment existing card DAPM routes in snd_soc_of_parse_audio_routing

2014-11-28 Thread Peter Rosin
Mark Brown wrote: On Thu, Nov 27, 2014 at 10:02:42PM +0100, Peter Rosin wrote: - routes = devm_kzalloc(card-dev, num_routes * sizeof(*routes), + old_routes = card-num_dapm_routes; + routes = devm_kzalloc(card-dev, + (old_routes + num_routes) * sizeof

[PATCH] ASoC: pcm512x: Trigger auto-increment of register addresses on i2c

2014-12-08 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When the codec is connected using i2c, it will only auto-increment register addresses if msb (0x80) of the register address byte is set. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x-i2c.c |7 ++- 1 file changed, 6 insertions

[PATCH] ASoC: pcm512x: Also support PCM514x devices

2014-12-09 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- Documentation/devicetree/bindings/sound/pcm512x.txt |3 ++- sound/soc/codecs/pcm512x-i2c.c |4 sound/soc/codecs/pcm512x-spi.c |4 3 files changed, 10

RE: [PATCH v2 02/12] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

2015-01-26 Thread Peter Rosin
Sylvain Rochet wrote: Hello Nicolas, On Mon, Jan 26, 2015 at 02:34:38PM +0100, Nicolas Ferre wrote: Le 26/01/2015 11:36, Sylvain Rochet a écrit : I think we should explain we are dealing with an errata here, this is not obvious at first sight, the patch summary may find its place

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-07 Thread Peter Rosin
Mark Brown wrote: On Wed, Feb 04, 2015 at 12:52:25PM +0100, Peter Rosin wrote: One thing remains a bit unclear, and that is the 500ppm deduction. Is that really warranted? The number was just pulled out of my hat... I don't really get what this is supposed to be protecting against

[PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-04 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When the SSC acts as BCK master, use a ratnum rule to limit the rate instead of only doing the standard rates. When the SSC acts as BCK slave, allow any BCK frequency up to within 500ppm of the SSC master clock, possibly divided by 2, 3 or 6. Put a cap at 384kHz

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-08 Thread Peter Rosin
Bo Shen wrote: Hi Peter, Hi! On 02/07/2015 06:51 PM, Peter Rosin wrote: Mark Brown wrote: On Wed, Feb 04, 2015 at 12:52:25PM +0100, Peter Rosin wrote: One thing remains a bit unclear, and that is the 500ppm deduction. Is that really warranted? The number was just pulled out of my hat

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
Bo Shen wrote: Hi Peter, On 02/09/2015 04:09 PM, Peter Rosin wrote: [Snip] /*-*\ * DAI functions @@ -200,6 +290,7 @@ static int atmel_ssc_startup(struct snd_pcm_substream *substream

RE: [PATCH RESEND] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories

2015-01-14 Thread Peter Rosin
Nicolas Ferre wrote: Le 14/01/2015 14:20, Peter Rosin a écrit : From: Peter Rosin p...@axentia.se The DDRSDR controller (on the ATSAMA5D31) fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period

Re: [PATCH 2/2] ASoC: atmel_ssc_dai: remove clock pin comments

2015-01-19 Thread Peter Rosin
As the clock can be get from TK/RK pin, so remove the comments. Signed-off-by: Bo Shen voice.s...@atmel.com --- sound/soc/atmel/atmel_ssc_dai.c | 4 1 file changed, 4 deletions(-) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index e691aab..198661b

[PATCH 0/2] ASoC: pcm512x: Add knobs to allow and control overclocking

2015-02-16 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Hi! I wasn't sure if I should add Documentation/* for these sysfs knobs or not? A lot of knobs do not seem to have docs (no specific example, just a gut feeling). And I'm not sure how I should name the doc-file since the pcm512x driver handles devices connected

[PATCH 1/2] ASoC: pcm512x: Rearrange to not repeat dacsrc_rate / dac_div

2015-02-16 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 884784fb1566..f13ff7578c78 100644

[PATCH 2/2] ASoC: pcm512x: Allow independently overclocking PLL, DAC and DSP

2015-02-16 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When using non-standard rates, a relatively small amount of overclocking can make a big difference to a number of cases. - Not all rates are possible to achieve with the PLL, due to divider restrictions. - The higher oversampling rates that can be used

[PATCH 0/2] ASoC: pcm512x: Add knobs to allow and control overclocking

2015-02-16 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Hi! I wasn't sure if I should add Documentation/* for these sysfs knobs or not? A lot of knobs do not have docs... And I'm not sure how I should name the doc-file since the pcm512x driver handles devices connected with both i2c and spi. So, this isn't perfect

[PATCH 1/7 RESEND] ALSA: pcm: Add snd_interval_ranges() and snd_pcm_hw_constraint_ranges()

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Add helper functions to allow drivers to specify several disjoint ranges for a variable. In particular, there is a codec (PCM512x) that has a hole in its supported range of rates, due to PLL and divider restrictions. This is like snd_pcm_hw_constraint_list

[PATCH 2/7 RESEND] ASoC: pcm512x: Fix spelling of register field names.

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- sound/soc/codecs/pcm512x.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index

[PATCH 0/7 RESEND] ASoC: pcm512x: Clock master modes

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Hi! [ Note that the dt change is in patch 5/7, for those only interested in that particular bit. ] This series implements BCLK master modes for the pcm512x driver. It has only been tested with the pcm5142 chip, but they are from the same family and should

[PATCH 4/7 RESEND] ASoC: pcm512x: Support mastering BCLK/LRCLK without using the PLL

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Use register field names from the seemingly compatible PCM5242 datasheet, as the PCM512x and PCM514x datasheets are severly lacking. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 452

[PATCH 5/7 RESEND] ASoC: pcm512x: Support mastering BCLK/LRCLK using the PLL

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Using the PLL in master mode requires using an external connection between one of the GPIO pins (configured as PLL/4 output) and the SCK pin. It also requires the external clock to be fed to some other GPIO pin instead of the SCK pin. This is described

[PATCH 7/7 RESEND] ASoC: pcm512x: Support SND_SOC_DAIFMT_CBM_CFS

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 7f45cc468fa1..33aa18c8c88e 100644

[PATCH 6/7 RESEND] ASoC: pcm512x: Avoid the PLL for the DAC clock, if possible

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The PLL introduces jitter, which in turn introduces noice if used to clock the DAC. Thus, avoid the PLL output, and use the PLL input to drive the DAC clock, if possible. This is described for the PCM5142/PCM5242 chips in the answers to the forum post PCM5142

[PATCH 3/7 RESEND] ASoC: pcm512x: Change register default to match actual content after reset

2015-01-27 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 874723c36d65..4c65eb9ab59b 100644 --- a/sound/soc

RE: [PATCH v3 03/13] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

2015-01-27 Thread Peter Rosin
I wrote: Sergei Shtylyov wrote: On 1/27/2015 8:53 AM, Wenyou Yang wrote: From: Peter Rosin p...@axentia.se The DDRSDR controller fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2

RE: [PATCH v3 03/13] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

2015-01-27 Thread Peter Rosin
Sergei Shtylyov wrote: Hello. Hi! On 1/27/2015 8:53 AM, Wenyou Yang wrote: From: Peter Rosin p...@axentia.se The DDRSDR controller fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2

RE: [PATCH v2 3/7] ASoC: pcm512x: Change register default to match actual content after reset

2015-01-28 Thread Peter Rosin
Hi Mark, First of all, thanks for taking the rest of the series! Mark Brown wrote: On Wed, Jan 28, 2015 at 03:16:08PM +0100, Peter Rosin wrote: @@ -78,7 +78,7 @@ static const struct reg_default pcm512x_reg_defaults[] = { { PCM512x_DIGITAL_VOLUME_2, 0x30

[PATCH v2 0/7] ASoC: pcm512x: Clock master modes

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Hi! [ Note that the dt change is in patch 5/7, for those only interested in that particular bit. ] This series implements BCLK master modes for the pcm512x driver. It has only been tested with the pcm5142 chip, but they are from the same family and should

[PATCH v2 1/7] ALSA: pcm: Add snd_interval_ranges() and snd_pcm_hw_constraint_ranges()

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Add helper functions to allow drivers to specify several disjoint ranges for a variable. In particular, there is a codec (PCM512x) that has a hole in its supported range of rates, due to PLL and divider restrictions. This is like snd_pcm_hw_constraint_list

[PATCH v2 6/7] ASoC: pcm512x: Avoid the PLL for the DAC clock, if possible

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The PLL introduces jitter, which in turn introduces noice if used to clock the DAC. Thus, avoid the PLL output, and use the PLL input to drive the DAC clock, if possible. This is described for the PCM5142/PCM5242 chips in the answers to the forum post PCM5142

[PATCH v2 3/7] ASoC: pcm512x: Change register default to match actual content after reset

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 874723c36d65..4c65eb9ab59b 100644 --- a/sound/soc

[PATCH v2 5/7] ASoC: pcm512x: Support mastering BCLK/LRCLK using the PLL

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Using the PLL in master mode requires using an external connection between one of the GPIO pins (configured as PLL/4 output) and the SCK pin. It also requires the external clock to be fed to some other GPIO pin instead of the SCK pin. This is described

[PATCH v2 7/7] ASoC: pcm512x: Support SND_SOC_DAIFMT_CBM_CFS

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index d46d6cdb6b87..64be85fb2748 100644

[PATCH v2 2/7] ASoC: pcm512x: Fix spelling of register field names.

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- sound/soc/codecs/pcm512x.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index

[PATCH v2 4/7] ASoC: pcm512x: Support mastering BCLK/LRCLK without using the PLL

2015-01-28 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Use register field names from the seemingly compatible PCM5242 datasheet, as the PCM512x and PCM514x datasheets are severly lacking. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 441

[PATCH] ASoC: atmel_ssc_dai: Support SND_SOC_DAIFMT_CBM_CFS on I2S

2015-01-29 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/atmel/atmel_ssc_dai.c | 48 +++ 1 file changed, 48 insertions(+) diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c index 3cd70597d109

[PATCH 1/2] ASoC: pcm512x: Fixup warning splat

2015-01-29 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index

[PATCH 2/2] ASoC: pcm512x: Use the correct range constraints for S24_LE

2015-01-29 Thread Peter Rosin
From: Peter Rosin p...@axentia.se This was overlooked in the late change to remove the I2S padding bits from S24_LE mode. The patch also limits S32_LE mode to 384kHz, the maximum according to the datasheets. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 39

[PATCH 0/2] ASoC: pcm512x: Fixups for the Clock master modes series

2015-01-29 Thread Peter Rosin
From: Peter Rosin p...@axentia.se These fixups can either be squashed in with 5/7 from the Clock master mode series, or they can be added on top of the current topic/pcm512x. Sorry for the trouble. I can squash them, and resend the Clock master modes series if that helps. Let me know how you'd

[PATCH] ASoC: pcm512x: Fix DSP program selection

2015-01-08 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The DSP programs are listed out of order. Signed-off-by: Peter Rosin p...@axentia.se Cc: sta...@vger.kernel.org --- sound/soc/codecs/pcm512x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs

[PATCH RESEND] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The DDRSDR controller (on the ATSAMA5D31) fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2 self-refresh spec is equivalent to LPDDR1, and is correctly

[PATCH 1/7] ALSA: pcm: Add snd_interval_ranges() and snd_pcm_hw_constraint_ranges()

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Add helper functions to allow drivers to specify several disjoint ranges for a variable. In particular, there is a codec (PCM512x) that has a hole in its supported range of rates, due to PLL and divider restrictions. Signed-off-by: Peter Rosin p...@axentia.se

[PATCH 2/7] ASoC: pcm512x: Fix spelling of register field names.

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- sound/soc/codecs/pcm512x.h |6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index

[PATCH 4/7] ASoC: pcm512x: Support mastering BCLK/LRCLK without using the PLL

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Use register field names from the seemingly compatible PCM5242 datasheet, as the PCM512x and PCM514x datasheets are severly lacking. Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 452

[PATCH 5/7] ASoC: pcm512x: Support mastering BCLK/LRCLK using the PLL

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Using the PLL in master mode requires using an external connection between one of the GPIO pins (configured as PLL/4 output) and the SCK pin. It also requires the external clock to be fed to some other GPIO pin instead of the SCK pin. This is described

[PATCH 7/7] ASoC: pcm512x: Support SND_SOC_DAIFMT_CBM_CFS

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 2a50c58a2fb1..511d98b3afa4 100644

[PATCH 0/7] ASoC: pcm512x: Clock master modes

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Hi! This series implements BCLK master modes for the pcm512x driver. It has only been tested with the pcm5142 chip, but they are from the same family and should be compatible. I have mainly used the spec for the newer pcm5242 chip (also from the same family

[PATCH 6/7] ASoC: pcm512x: Avoid the PLL for the DAC clock, if possible

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se The PLL introduces jitter, which in turn introduces noice if used to clock the DAC. Thus, avoid the PLL output, and use the PLL input to drive the DAC clock, if possible. This is described for the PCM5142/PCM5242 chips in the answers to the forum post PCM5142

[PATCH 3/7] ASoC: pcm512x: Change register default to match actual content after reset

2015-01-14 Thread Peter Rosin
From: Peter Rosin p...@axentia.se Signed-off-by: Peter Rosin p...@axentia.se --- sound/soc/codecs/pcm512x.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index 355a8543c8b1..78dc3306d2f2 100644 --- a/sound/soc

[PATCH v3] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When the SSC acts as BCK master, use a ratnum rule to limit the rate instead of only doing the standard rates. When the SSC acts as BCK slave, allow any BCK frequency up to the SSC master clock, divided by either of 2, 3 or 6. Put a cap at 384kHz. Who's /ever

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
Bo Shen wrote: Hi Peter, Hi! On 02/04/2015 07:52 PM, Peter Rosin wrote: From: Peter Rosin p...@axentia.se When the SSC acts as BCK master, use a ratnum rule to limit the rate instead of only doing the standard rates. When the SSC acts as BCK slave, allow any BCK frequency up

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
Bo Shen wrote: Hi Peter, On 02/09/2015 03:35 PM, Peter Rosin wrote: Bo Shen wrote: Hi Peter, Hi! On 02/07/2015 06:51 PM, Peter Rosin wrote: Mark Brown wrote: On Wed, Feb 04, 2015 at 12:52:25PM +0100, Peter Rosin wrote: One thing remains a bit unclear, and that is the 500ppm

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
Bo Shen wrote: Hi Peter, Hi! On 02/09/2015 05:07 PM, Peter Rosin wrote: Bo Shen wrote: Hi Peter, On 02/09/2015 04:09 PM, Peter Rosin wrote: [Snip] /*-*\ * DAI functions @@ -200,6 +290,7

RE: [PATCH v2] ASoC: atmel_ssc_dai: Allow more rates

2015-02-09 Thread Peter Rosin
Bo Shen write: Hi Peter, Hi! [Snip] /*-*\ * DAI functions @@ -200,6 +290,7 @@ static int atmel_ssc_startup(struct snd_pcm_substream *substream, struct atmel_ssc_info *ssc_p =

RE: [PATCH] ASoC:pcm512x: Fix divide by zero issue.

2015-03-22 Thread Peter Rosin
broken and never actually ran, we have been using 16MHz pllin_rate, and I apparently never hit this code path. Signed-off-by: Howard Mitchell h...@hmbedded.co.uk Acked-by: Peter Rosin p...@axentia.se Cheers, Peter --- sound/soc/codecs/pcm512x.c |4 ++-- 1 file changed, 2 insertions(+), 2

RE: [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device tree.

2015-03-22 Thread Peter Rosin
Howard Mitchell wrote: Currently the PLL Lock output signal is hardcoded to GPIO4. This makes it seletable in the same way as pll-in and pll-out. Oops, I never intended the plllock code the hit upstream. I thought I had removed that testing code and was very surprised to see it, that was an odd

RE: [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device tree.

2015-03-23 Thread Peter Rosin
Howard Mitchell wrote: On 22/03/15 16:24, Mark Brown wrote: On Fri, Mar 20, 2015 at 09:22:43PM +, Howard Mitchell wrote: + if (pcm512x-pll_lock) { +if (of_property_read_u32(np, pll-lock, val) = 0) { +if (val 6) { +

[PATCH v2] ASoC: pcm512x: Allow independently overclocking PLL, DAC and DSP

2015-02-23 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When using non-standard rates, a relatively small amount of overclocking can make a big difference to a number of cases. - Not all rates are possible to achieve with the PLL, due to divider restrictions. - The higher oversampling rates that can be used

Re: [PATCH 2/2] ASoC: pcm512x: Allow independently overclocking PLL, DAC and DSP

2015-02-23 Thread Peter Rosin
From: Peter Rosin p...@axentia.se On 2015-02-23 15:31, Mark Brown wrote: On Sun, Feb 22, 2015 at 12:24:12AM +, Peter Rosin wrote: ...but I'm not sure everybody agrees that overclocking games should be allowed by any and all users? I don't see why not, ASoC controls are already way

RE: [PATCH 2/2] ASoC: pcm512x: Allow independently overclocking PLL, DAC and DSP

2015-02-21 Thread Peter Rosin
Mark Brown wrote: On Mon, Feb 16, 2015 at 10:02:48PM +0100, Peter Rosin wrote: From: Peter Rosin p...@axentia.se When using non-standard rates, a relatively small amount of overclocking can make a big difference to a number of cases. This is all basically fine but I'm wondering why

RE: [PATCH] ASoC: pcm512x: Remove hardcoding of pll-lock to GPIO4

2015-03-24 Thread Peter Rosin
Howard Mitchell wrote: Currently GPIO4 is hardcoded to output the pll-lock signal. Unfortunately this is after the pll-out GPIO is configured which is selectable in the device tree. Therefore it is not possible to use GPIO4 for pll-out. Therefore this patch removes the configuration of GPIO4.

[RFC PATCH] ASoC: atmel_ssc_dai: Allow more rates

2015-01-29 Thread Peter Rosin
From: Peter Rosin p...@axentia.se When the SSC acts as BCK master, use a ratnum rule to limit the rate instead of only doing the standard rates. When the SSC acts as BCK slave, allow any BCK frequency up to within 500ppm of the SSC master clock, possibly divided by 2, 3 or 6. Put a cap at 384kHz

Re: [PATCH] adm8211: fix checkpatch errors for indentation and new line around switch-case

2015-05-05 Thread Peter Rosin
diff --git a/drivers/net/wireless/adm8211.c b/drivers/net/wireless/adm8211.c index f07a618..058fb4b 100644 --- a/drivers/net/wireless/adm8211.c +++ b/drivers/net/wireless/adm8211.c @@ -1098,14 +1098,18 @@ static void adm8211_hw_init(struct ieee80211_hw *dev)

RE: [PATCH] ASoC: tfa9879: Fix return value check in tfa9879_i2c_probe()

2015-04-16 Thread Peter Rosin
Wei Yongjun wrote: In case of error, the function devm_kzalloc() returns NULL not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Acked-by: Peter Rosin p...@axentia.se Thanks, Peter -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-19 Thread Peter Rosin
On 2015-10-19 10:51, Ludovic Desroches wrote: > Hi Peter, > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: >> On 2015-10-16 01:47, Peter Rosin wrote: >>> On 2015-10-14 07:43, Ludovic Desroches wrote: >>>> On Tue, Oct 13, 2015 at 08:01:34PM +02

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-15 Thread Peter Rosin
On 2015-10-14 07:43, Ludovic Desroches wrote: > On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: >> On 2015-10-13 18:47, Cyrille Pitchen wrote: >>> Le 13/10/2015 17:19, Peter Rosin a écrit : >>>> On 2015-10-13 16:21, Ludovic Desroches wrote: >>>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-16 Thread Peter Rosin
On 2015-10-16 01:47, Peter Rosin wrote: > On 2015-10-14 07:43, Ludovic Desroches wrote: >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: >>> On 2015-10-13 18:47, Cyrille Pitchen wrote: >>>> Le 13/10/2015 17:19, Peter Rosin a écrit : >>>>>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Peter Rosin
On 2015-10-20 15:27, Ludovic Desroches wrote: > On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: >> On 2015-10-19 10:51, Ludovic Desroches wrote: >>> Hi Peter, >>> >>> On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: >>

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Peter Rosin
On 2015-10-21 09:21, Peter Rosin wrote: > On 2015-10-20 15:27, Ludovic Desroches wrote: >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: >>> On 2015-10-19 10:51, Ludovic Desroches wrote: >>>> Hi Peter, >>>> >>>> On Fr

Re: Regression: at24 eeprom writing

2015-10-12 Thread Peter Rosin
On 2015-10-05 17:09, Peter Rosin wrote: > But what trouble does the i2c bus driver see? Admittedly I only > have a simple logic level bus viewer, and not a full-blown > oscilloscope, so there might be something analogue going on? > I don't think so though, those signals looked fine

Re: Regression: at24 eeprom writing

2015-10-13 Thread Peter Rosin
On 2015-10-12 18:13, Cyrille Pitchen wrote: > Le 12/10/2015 17:13, Peter Rosin a écrit : >> On 2015-10-05 17:09, Peter Rosin wrote: >>> But what trouble does the i2c bus driver see? Admittedly I only >>> have a simple logic level bus viewer, and not a full-blown >&

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Peter Rosin
91 > kernel image. Adapted to linux-next. > > Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> > Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA > controller") > Reported-by: Peter Rosin <p...@lysator.liu.se> > Signed-o

Re: Regression: at24 eeprom writing

2015-10-13 Thread Peter Rosin
On 2015-10-13 14:57, Nicolas Ferre wrote: > Le 13/10/2015 12:38, Peter Rosin a écrit : >> On 2015-10-12 18:13, Cyrille Pitchen wrote: >>> Le 12/10/2015 17:13, Peter Rosin a écrit : >>>> On 2015-10-05 17:09, Peter Rosin wrote: >>>>> But what trouble d

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Peter Rosin
On 2015-10-13 18:47, Cyrille Pitchen wrote: > Le 13/10/2015 17:19, Peter Rosin a écrit : >> On 2015-10-13 16:21, Ludovic Desroches wrote: >>> From: Cyrille Pitchen <cyrille.pitc...@atmel.com> >>> >>> In some cases a NACK interrupt may be pending i

Re: Regression: at24 eeprom writing

2015-10-04 Thread Peter Rosin
On 2015-10-03 01:05, Peter Rosin wrote: > I looked around and found that if I revert > a839ce663b3183209fdf7b1fc4796bfe2a4679c3 > "eeprom: at24: extend driver to allow writing via i2c_smbus_write_byte_data" > eeprom writing starts working again. > > AFAICT, t

Re: Regression: at24 eeprom writing

2015-10-05 Thread Peter Rosin
On 2015-10-03 01:05, Peter Rosin wrote: > Hi! > > I recently upgraded from the atmel linux-3.18-at91 kernel to vanilla 4.2 > and everything seemed fine. Until I tried to write to the little eeprom > chip. I then tried the linux-4.1-at91 kernel and that suffers too. &g

Regression: at24 eeprom writing

2015-10-02 Thread Peter Rosin
Hi! I recently upgraded from the atmel linux-3.18-at91 kernel to vanilla 4.2 and everything seemed fine. Until I tried to write to the little eeprom chip. I then tried the linux-4.1-at91 kernel and that suffers too. The symptoms are that it seems like writes get interrupted, and restarted again

Re: [PATCH v6 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

2015-09-28 Thread Peter Rosin
On 2015-09-27 17:50, Jonathan Cameron wrote: > On 23/09/15 15:26, Peter Rosin wrote: >> From: Peter Rosin <p...@axentia.se> >> >> Add support for Microchip digital potentiometers and rheostats >> MCP4531, MCP4532, MCP4551, MCP4552 >> MCP4631,

[PATCH v5 2/2] iio: mcp4531: Driver for Microchip digital potentiometers

2015-09-23 Thread Peter Rosin
From: Peter Rosin <p...@axentia.se> Add support for Microchip digital potentiometers and rheostats MCP4531, MCP4532, MCP4551, MCP4552 MCP4631, MCP4632, MCP4651, MCP4652 DEVICE Wipers Steps Resistor Opts (kOhm) i2c address MCP4531 1 1295, 10, 50, 1000

[PATCH v5 0/2] Driver for Microchip digital potentiometers

2015-09-23 Thread Peter Rosin
From: Peter Rosin <p...@axentia.se> This is the fifth attempt for a driver for these chips. Thanks for review comments from Greg Kroah-Hartman, Crt Mori, Daniel Baluta, Lars-Peter Clauson, Andreas Dannenberg, Peter Meerwald and Jonathan Cameron. I think and hope I got it all sorted. C

  1   2   3   4   5   6   7   8   9   10   >