omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
that it was paused (or
whether the data in the FIFO read from memory is simply
discarded.)
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
sound/soc/omap/Kconfig| 3 +-
sound/soc/omap/omap-pcm.c | 279
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/dma/omap-dma.c | 5 -
1 file changed, 4 insertions
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
On 09/12/2012 03:00 PM, Russell King - ARM Linux wrote:
On Wed, Sep 12, 2012 at 02:47:07PM +0300, Peter Ujfalusi wrote:
2. Pause/Resume
OMAP DMA engine backend does not support pausing and resuming
an in-progress transfer. It is unclear from the specs what
effect clearing the enable
On 09/12/2012 03:53 PM, Peter Ujfalusi wrote:
I need to look at this, but at first look we do wait for the drain in
omap_stop_dma(). We used to use omap_stop_dma/omap_start_dma for pause/resume
operations.
But sDMA also have a bit: CDPi: PAUSE_LINK_LIST which should do what we are
looking
On 09/13/2012 09:52 AM, Linus Walleij wrote:
On Wed, Sep 12, 2012 at 10:27 PM, Tony Lindgren t...@atomide.com wrote:
* Peter Ujfalusi peter.ujfal...@ti.com [120911 01:54]:
With pinctrl-single,bits it is possible to update just part of the register
within the pinctrl-single,function-mask area
On 09/13/2012 11:11 AM, Mark Brown wrote:
On Wed, Sep 12, 2012 at 02:46:56PM +0300, Peter Ujfalusi wrote:
Hello,
This series will switch the OMAP audio to use dmaengine.
The final patch which does the switch was based on Russell King's earlier
patch.
I'm fine with this from the ASoC side
The patches has been generated against:
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7
Janusz: Can you retest this series on OMAP1 to be sure I have not broken it?
Ricardo: Can you test the omap-hmdi if it is still working?
Regards,
Peter
---
Peter Ujfalusi (15):
dmaengine
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap
The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA.
This method has been used for years on OMAP based products.
We only allow pause/resume when the DMA has been configured in cyclic mode
which is used by the audio stack.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation to disable all audio
related interrupts.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Nicolas Ferre
When McBSP is configured in threshold mode we can use sDMA packet mode in
all cases.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcbsp.c | 47 -
1 file changed, 17 insertions(+), 30 deletions(-)
diff --git a/sound/soc
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
Original author: Russell King rmk+ker...@arm.linux.org.uk
Switch the omap-pcm to use dmaengine.
Certain features are not supported by after dmaengine conversion:
1. No period wakeup mode
DMA engine has no way to communicate this information through
standard channels.
Signed-off-by: Peter
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
The omap-pcm platform driver no longer needs this parameter to select
between ELEMENT and PACKET mode. The selection is based on the configured
packet_size.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 1 -
sound/soc/omap/omap-hdmi.c | 1 -
sound/soc
Since we only have element or packet synchronization we can use the
dma_data-packet_size to select the desired mode:
if packet_size is 0 we use ELEMENT mode
if packet_size is not 0 we use PACKET mode for sDMA synchronization.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap
omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 27 +++
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc
When requested disable all DMA interrupts for the channel. In this mode
user space does not expect periodic reports from kernel about the progress
of the audio stream - PulseAudio for example support this type of mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker
patch will change
the device_prep_dma_cyclic() callback parameters to pass this information
towards the dma drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Lars-Peter Clausen l...@metafoo.de
---
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 3 ++-
2 files
On 09/14/2012 06:24 AM, Vinod Koul wrote:
On Thu, 2012-09-13 at 16:37 +0300, Peter Ujfalusi wrote:
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation to disable
Hi,
On 09/13/2012 06:27 PM, Lars-Peter Clausen wrote:
On 09/13/2012 03:37 PM, Peter Ujfalusi wrote:
The dmaengine_prep_dma_cyclic() function primarily used by audio for cyclic
transfer required by ALSA.
With this new parameter it is going to be possible to enable
On 09/13/2012 06:38 PM, Russell King - ARM Linux wrote:
On Thu, Sep 13, 2012 at 05:27:09PM +0200, Lars-Peter Clausen wrote:
Hm... Do you think it would work as well if we implement this by setting the
callback for the descriptor to NULL? If the callback is NULL there is
nothing to at the end
On 09/14/2012 06:26 AM, Vinod Koul wrote:
On Thu, 2012-09-13 at 17:27 +0200, Lars-Peter Clausen wrote:
Hi,
Hm... Do you think it would work as well if we implement this by
setting the
callback for the descriptor to NULL? If the callback is NULL there is
nothing to at the end of a
Hi,
On 09/14/2012 11:50 AM, Vinod Koul wrote:
Well, the idea was that the driver would disable interrupts if there is no
callback to call, since there would be nothing to do in the interrupt
handler anyway. But I guess the flags approach should work fine as well.
Yes we _could_ do that, but
The audio stack used omap_stop_dma/omap_start_dma to pause/resume the DMA.
This method has been used for years on OMAP based products.
We only allow pause/resume when the DMA has been configured in cyclic mode
which is used by the audio stack.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
(if DMA_PREP_INTERRUPT is cleared) when it is supported
on the platform.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Lars-Peter Clausen l...@metafoo.de
---
include/linux/dmaengine.h | 3 ++-
sound/soc/soc-dmaengine-pcm.c | 6 +-
2 files changed, 7 insertions(+), 2 deletions(-)
diff
Since we only have element or packet synchronization we can use the
dma_data-packet_size to select the desired mode:
if packet_size is 0 we use ELEMENT mode
if packet_size is not 0 we use PACKET mode for sDMA synchronization.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap
To help the driver to get the correct memory range to access McPDM
registers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/omap_hwmod_44xx_data.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_hwmod_44xx_data.c
b/arch/arm/mach-omap2
omap-pcm can figure out the correct dma_type based on the stream's format.
In this way we can get rid of the plat/dma.h include from these drivers.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 2 --
sound/soc/omap/omap-mcbsp.c | 3 ---
sound/soc/omap/omap
Original author: Russell King rmk+ker...@arm.linux.org.uk
Switch the omap-pcm to use dmaengine.
Certain features are not supported by after dmaengine conversion:
1. No period wakeup mode
DMA engine has no way to communicate this information through
standard channels.
Signed-off-by: Peter
Set the dma_data for the stream (snd_soc_dai_set_dma_data) at dai_startup
time so omap-pcm will have access to the needed information regarding to
the DMA channel earlier.
This is needed for the clean dmaengine support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap
to be
configured for 32bit word type regardless of the audio format used.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-hdmi.c | 3 +--
sound/soc/omap/omap-pcm.c | 3 ++-
sound/soc/omap/omap-pcm.h | 3 ++-
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git
Get the needed resources in a correct way and avoid using defines for them.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcpdm.c | 27 +++
1 file changed, 23 insertions(+), 4 deletions(-)
diff --git a/sound/soc/omap/omap-mcpdm.c b/sound/soc
if the stream format is S16_LE.
The check if (dma_data-data_type) is safe at the moment since omap-pcm
does not support 8bit samples (OMAP_DMA_DATA_TYPE_S8 == 0x00).
The next step is to redefine the meaning of dma_data-data_type to unblock
this limitation.
Signed-off-by: Peter Ujfalusi peter.ujfal
not broken it?
Ricardo: Can you test the omap-hmdi if it is still working?
Regards,
Peter
---
Peter Ujfalusi (15):
dmaengine: omap: Support for element mode in cyclic DMA
dmaengine: omap: Add support for pause/resume in cyclic dma mode
dmaengine: Add flags parameter
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the flags coming from clients.
This feature can be used during audio operation to disable all audio
related interrupts when the DMA_PREP_INTERRUPT is cleared from the flags.
Signed-off-by: Peter Ujfalusi
When McBSP is configured in threshold mode we can use sDMA packet mode in
all cases.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-mcbsp.c | 47 -
1 file changed, 17 insertions(+), 30 deletions(-)
diff --git a/sound/soc
The omap-pcm platform driver no longer needs this parameter to select
between ELEMENT and PACKET mode. The selection is based on the configured
packet_size.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/omap/omap-dmic.c | 1 -
sound/soc/omap/omap-hdmi.c | 1 -
sound/soc
When requested (DMA_PREP_INTERRUPT is cleared in flags) disable all DMA
interrupts for the channel. In this mode user space does not expect
periodic reports from kernel about the progress of the audio stream.
PulseAudio for example support this type of mode.
Signed-off-by: Peter Ujfalusi
When src_maxburst/dst_maxburst is set to 0 by the users of cyclic DMA
(mostly audio) indicates that we should configure the omap DMA to element
sync mode instead of packet mode.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
CC: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/omap
-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hello Mike,
This driver is going to be used by the OMAP McPDM driver when we moved to common
clock framework.
To avoid merge conflicts I'm going to send the patch needed for the twl6040 MFD
core driver to register the platform device for the clk driver
On 09/17/2012 09:34 AM, Shawn Guo wrote:
On Thu, Sep 13, 2012 at 04:37:54PM +0300, Peter Ujfalusi wrote:
Change the parameter list of device_prep_dma_cyclic() so the DMA drivers
can receive the no_wakeup request coming from client drivers.
This feature can be used during audio operation
Hello Linus,
On 07/28/2012 01:50 AM, Linus Walleij wrote:
On Wed, Jul 18, 2012 at 11:20 AM, Peter Ujfalusi peter.ujfal...@ti.com
wrote:
I think you need to CC DT bindings to devicetree-discuss.
diff --git a/Documentation/devicetree/bindings/mfd/twl6040.txt
b/Documentation/devicetree
Hello Linus,
On 07/28/2012 01:45 AM, Linus Walleij wrote:
On Wed, Jul 18, 2012 at 11:20 AM, Peter Ujfalusi peter.ujfal...@ti.com
wrote:
#define TWL6040_GPO1 0x01
#define TWL6040_GPO2 0x02
-#define TWL6040_GPO3 0x03
+#define
Hi Tero,
On 08/28/2012 12:50 PM, Tero Kristo wrote:
On Tue, 2012-08-14 at 17:22 +0300, Peter Ujfalusi wrote:
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
I think this one could use a short commit message, also about why
kfree():s are dropped (handled internally by devm_* etc.)
I
Hi,
On 09/02/2012 01:40 PM, Thierry Reding wrote:
Hi,
This mini series replaces the twl_has_*() macros by the equivalent
standard IS_ENABLED() macro and moves the PWM driver to the PWM
framework.
I'll take the second patch through the PWM tree but would like to have
some Acked-bys from
On 09/02/2012 01:40 PM, Thierry Reding wrote:
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 5fbb2a6..1b1a789 100644
--- a/drivers/mfd/twl-core.c
+++ b/drivers/mfd/twl-core.c
@@ -638,6 +638,13 @@ add_children(struct twl4030_platform_data *pdata,
unsigned irq_base,
the previous pinctrl-since,pins
implementation because it was not using the mask on the value which could result
changed bits outside of the mask.
Regards,
Peter
---
Peter Ujfalusi (2):
pinctrl: pinctrl-single: Make sure we do not change bits outside of
mask
pinctrl: pinctrl-single: Add
0x6e 0x10f
0x70 0x23f
0x72 0xa5f
;
};
};
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/pinctrl/pinctrl-single.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl
With pinctrl-single,bits it is possible to update just part of the register
within the pinctrl-single,function-mask area.
This is useful when one register configures mmore than one pin's mux.
pinctrl-single,bits takes three parameters:
reg offset, value, sub-mask
Signed-off-by: Peter Ujfalusi
/omap-twl4030 DT boot), OMAP4
(McPDM, DMIC DT), and on OMAP5 (McPDM, DMIC DT).
I have sent the patches needed for the dtsi files to probe the audio related
IPs with this patch.
Tested-by: Peter Ujfalusi peter.ujfal...@ti.com
Why RFC?
Still we have function duplication omap_device_fill_resources
support for BeagleBoard).
Regards,
Peter
---
Peter Ujfalusi (14):
MFD: twl4030-audio: Clean up MODULE_* and platform_driver part
MFD: twl4030-audio: Convert to use devm_kzalloc
MFD: twl4030-audio: Rearange and clean-up the probe function
MFD: twl-core: Add API to query the HFCLK rate
MFD
Place the MODULE_* lines in the same block and add MODULE_DESCRIPTION.
Rearange the platform_driver structure at the same time.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
index ac04b4f..efa2d42 100644
--- a/drivers/mfd/twl4030-audio.c
-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl-core.c | 32
include/linux/i2c/twl.h |1 +
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c
index 1c32afe..f162b68 100644
Remove the use of set_hs_extmute callback and let the codec driver to
handle the extmute GPIO.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c |9 ++---
arch/arm/mach-omap2/include/mach/board-zoom.h |2 --
sound/soc/omap/zoom2.c
We no longer have users for the set_hs_extmute callback which has been
replaced by hs_extmute_gpio so the codec driver can handle the external
mute if it is needed by the board.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h|2 --
sound/soc/codecs/twl4030
When the kernel has been booted with DT blob the platform data is NULL for
the driver.
We need to construct the pdata based on the DT information for runtime use.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 57
Access the pdata via a pointer within the twl4030_priv structure.
In preparation for DeviceTree support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs
Support for loading the twl4030 audio module via devicetree.
Sub devices for codec and vibra will be created as mfd devices once the
core MFD driver is loaded when the kernel is booted with a DT blob.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
.../devicetree/bindings/mfd/twl4030
Add support when the kernel has been booted with DT blob. In this case the
pdata is NULL, we need to reach up to the core node and check if the codec
part has been enabled to determine if we need to coexist with the codec or
not.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers
Allocate the private data with devm_kzalloc.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 27ccea4..413e698 100644
The external mute (if it is in use) is handled by a GPIO line. Prepare to
remove the set_hs_extmute callback and replace it with:
hs_extmute_gpio: the GPIO number to use for external mute
When the users of set_hs_extmute has been converted the callback can be removed.
Signed-off-by: Peter
This commit adds an empty of_find_node_by_name() function for !CONFIG_OF
builds.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/of.h |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/include/linux/of.h b/include/linux/of.h
index 5919ee3..c90e59a
twl-core has API to get the boot time configured HFCLK rate which has the
same rate as the audio MCLK.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/twl4030-audio.c b
To facilitate the device tree support the probe function need to be rearanged.
Small cleanup in the APLL frequency selection part as well.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 34 --
1 files changed, 16 insertions
Convert the probe to use devm_*. At the same time reorder the calls
so we will register the input device as the last step when the driver
is loaded.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/input/misc/twl6040-vibra.c | 99 ---
1 files
Support for loading the twl4030 audio module via devicetree.
Sub devices for codec and vibra will be created as mfd devices once the
core MFD driver is loaded when the kernel is booted with a DT blob.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
.../devicetree/bindings/mfd/twl4030
Allocate the private data with devm_kzalloc.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 1247c4a..6a00c01 100644
When the kernel has been booted with DT blob the platform data is NULL for
the driver.
We need to construct the pdata based on the DT information for runtime use.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 67
Access the pdata via a pointer within the twl4030_priv structure.
In preparation for DeviceTree support.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
sound/soc/codecs/twl4030.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/sound/soc/codecs
is
not enabled.
The codec driver can handle the external mute functionality based on these
parameters and when the users of set_hs_extmute has been converted the
callback can be removed.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h|6 +-
sound/soc/codecs/twl4030
, and with
the upcoming DT audio support for BeagleBoard).
Regards,
Peter
---
Peter Ujfalusi (11):
MFD: twl4030-audio: Clean up MODULE_* and platform_driver part
MFD: twl4030-audio: Convert to use devm_kzalloc
MFD: twl4030-audio: Rearange and clean-up the probe function
MFD: twl4030-audio: Add DT
To facilitate the device tree support the probe function need to be rearanged.
Small cleanup in the APLL frequency selection part as well.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 34 --
1 files changed, 16 insertions
We no longer have users for the set_hs_extmute callback which has been
replaced by hs_extmute_gpio/hs_extmute_disable_level parameters so the
codec driver can handle the external mute if it is needed by the board.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
include/linux/i2c/twl.h
Remove the use of set_hs_extmute callback and let the codec driver to
handle the extmute GPIO.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
arch/arm/mach-omap2/board-zoom-peripherals.c |9 ++---
arch/arm/mach-omap2/include/mach/board-zoom.h |2 --
sound/soc/omap/zoom2.c
Add support when the kernel has been booted with DT blob. In this case the
pdata is NULL, we need to reach up to the core node and check if the codec
part has been enabled to determine if we need to coexist with the codec or
not.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers
Place the MODULE_* lines in the same block and add MODULE_DESCRIPTION.
Rearange the platform_driver structure at the same time.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/mfd/twl4030-audio.c | 15 ++-
1 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c
index ac04b4f..efa2d42 100644
--- a/drivers/mfd/twl4030-audio.c
Hi Benoit,
On 08/08/2012 02:50 PM, Benoit Cousson wrote:
+Required properties:
+- compatible : must be ti,twl4030-audio
+- ti,audio_mclk: Master clock frequency used on the board. Supported
+ frequencies: 1920, 2600 and 3840
Since you care about the frequency only
On 08/08/2012 04:13 PM, Mark Brown wrote:
On Wed, Aug 08, 2012 at 12:41:20PM +0300, Peter Ujfalusi wrote:
+Required properties:
+- compatible : must be ti,twl4030-audio
So, as I mentioned before I find this sort of direct mapping of the
Linux device representation into the device tree
On 08/08/2012 04:52 PM, Mark Brown wrote:
The hs_extmute is used for reducing pop noise on the headset. The sequence is
described in the TRM and it need to be done within the codec driver since it
is within the sequence.
Is the point it's at in the sequence the end?
On both ends :o
On HS
On 08/08/2012 05:18 PM, Mark Brown wrote:
I'm struggling to see any reason not to just hold the external mute on
for the entire time the headset is powered off?
I think because it would mean in most cases that we keep a GPIO line enabled
during the time the HS is not in use, which burns power.
On 08/08/2012 03:52 PM, Mark Brown wrote:
On Wed, Aug 08, 2012 at 01:50:53PM +0200, Benoit Cousson wrote:
That being said, since we do have the clock binding now, maybe we should
create a clock provider at board level for the sys_clk and thus you will
just have to create a phandle to it in
On 08/08/2012 05:49 PM, Mark Brown wrote:
That makes sense if the GPIO is actively driven, open drain should be
better here, but it's still a generic thing which it'd be nice to
extract.
Yes, the idea in it's core is generic, but right now I can not think of a
generic implementation which
On 08/09/2012 02:55 PM, Mark Brown wrote:
On Mon, Jul 30, 2012 at 05:13:17PM +0300, Peter Ujfalusi wrote:
If the board needs the gpo driver, but in the driver(s) I need to check for
the existence of the ti,twl6040-gpo node and check if the status is okay.
I think it is easier to just get
On 08/09/2012 01:36 PM, Mark Brown wrote:
On Thu, Aug 09, 2012 at 01:18:50PM +0300, Peter Ujfalusi wrote:
On 08/08/2012 05:49 PM, Mark Brown wrote:
That makes sense if the GPIO is actively driven, open drain should be
better here, but it's still a generic thing which it'd be nice to
extract
Safety check for the validity of the resource name before calling strcmp().
If the resource name is NULL do not compare it, just skip it.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
Hi Greg,
I have experienced with a kernel crash because the r-name was NULL when booting
OMAP4
Hello,
On 06/08/2012 04:01 PM, Peter Ujfalusi wrote:
Hello,
The following series enable the audio functionality on OMAP4 based devices
using
twl6040 as audio codec.
The series adds the needed bindings in the dts for the OMAP IPs, twl6040 MFD
device and for the audio connection
On 07/11/2012 04:06 AM, Axel Lin wrote:
Current code has been converted to use regmap APIs, the io_mutex is not
needed.
Thus remove the io_mutex.
Signed-off-by: Axel Lin axel@gmail.com
Thanks for cleanup,
Acked-by: Peter Ujfalusi peter.ujfal...@ti.com
--
To unsubscribe from
it is needed.
Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com
---
drivers/gpio/gpio-twl4030.c | 99 ++---
1 file changed, 66 insertions(+), 33 deletions(-)
diff --git a/drivers/gpio/gpio-twl4030.c b/drivers/gpio/gpio-twl4030.c
index c092739..a38e6e9c 100644
201 - 300 of 4568 matches
Mail list logo
