Re: [PATCH] staging: speakup: fix wraparound in uaccess length check

2018-07-07 Thread Samuel Thibault
chars_sent + 2 > count) > + break; > if (copy_to_user(cp, s, sizeof(s))) > return -EFAULT; Err, but then we have lost 'ch' that was consumed by the synth_buffer_getc() call, so the fix seems wrong to me. Nacked-by: Samuel Thibault Samuel

[PATCH] staging: speakup: Add unicode support to the speakup_dummy driver

2018-03-10 Thread Samuel Thibault
of spk_do_catch_up. Signed-off-by: Samuel Thibault <samuel.thiba...@ens-lyon.org> Index: linux-4.15/drivers/staging/speakup/spk_types.h === --- linux-4.15.orig/drivers/staging/speakup/spk_types.h +++ linux-4.15/drivers/staging/s

Re: [PATCH] kbd: complete dead keys definitions

2018-06-28 Thread Samuel Thibault
Hello, Ping? Samuel Samuel Thibault, le dim. 03 juin 2018 20:18:58 +0200, a ecrit: > This completes dead keys definitions for internationalization > completeness on the console. The representatives have been chosen > coherently with libx11 compose sequences, which avoid symetry

staging/speakup_soft: Fix alternate speech with other synths

2018-10-23 Thread Samuel Thibault
alive, otherwise the switch would let it remain silent. Signed-off-by: Samuel Thibault --- drivers/staging/speakup/speakup_soft.c | 16 +++- drivers/staging/speakup/spk_priv.h |1 + drivers/staging/speakup/synth.c|6 ++ 3 files changed, 18 insertions(+), 5

Re: [PATCH] staging: speakup: clean up few indentation issues

2018-10-30 Thread Samuel Thibault
Colin King, le mar. 30 oct. 2018 11:09:59 +, a ecrit: > From: Colin Ian King > > Trivial fix to clean up indentation issues across the driver > > Signed-off-by: Colin Ian King Reviewed-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 2 +- >

Re: Update Linux 2.4 Status/TODO list

2000-09-23 Thread Samuel Thibault
--- Andre Hedrick <[EMAIL PROTECTED]> a écrit : > > Ted and LT, > > I think this are the two things you wanted that were located in: > > /src/tar-files/testing/direct_add/ht6560b.c > /src/tar-files/testing/direct_add/qd65xx.c > /src/tar-files/testing/direct_add/qd65xx.h > > First Petr and

idle task's task_t allocation on NUMA machines

2005-08-18 Thread Samuel Thibault
Hi, Currently, the task_t structure of the idle task is always allocated on CPU0, hence on node 0: while booting, for each CPU, CPU 0 calls fork_idle(), hence copy_process(), hence dup_task_struct(), hence alloc_task_struct(), hence kmem_cache_alloc(), which picks up memory from the allocation

Re: idle task's task_t allocation on NUMA machines

2005-08-18 Thread Samuel Thibault
Eric Dumazet, le Thu 18 Aug 2005 17:18:55 +0200, a écrit : > An idle task should block itself, hence not touching its task_t structure > very much. Indeed, but I guess there are a lot of such little optimizations here and there that could be relatively easily fixed, for a not-so little benefit.

Re: idle task's task_t allocation on NUMA machines

2005-08-18 Thread Samuel Thibault
Eric Dumazet, le Thu 18 Aug 2005 17:18:55 +0200, a écrit : > I believe IRQ stacks are also allocated on node 0, that seems more serious. For the i386 architecture at least, yes: they are statically defined in arch/i386/kernel/irq.c, while they could be per_cpu. Regards, Samuel - To unsubscribe

Re: idle task's task_t allocation on NUMA machines

2005-08-18 Thread Samuel Thibault
Samuel Thibault, le Thu 18 Aug 2005 21:49:41 +0200, a écrit : > Eric Dumazet, le Thu 18 Aug 2005 17:18:55 +0200, a écrit : > > I believe IRQ stacks are also allocated on node 0, that seems more serious. > > For the i386 architecture at least, yes: they are statically defined in >

[PATCH] vga text console and stty cols/rows

2005-09-03 Thread Samuel Thibault
, which can be great for some people (see http://dept-info.labri.fr/~thibault/ls.jpg ). Regards, Samuel Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> --- linux-2.6.13/drivers/video/console/vgacon.c 2005-09-02 18:18:38.0 +0200 +++ linux/drivers/video/console/vgacon.c2005

Re: Experimental driver for Ricoh Bay1Controller SD Card readers

2007-01-09 Thread Samuel Thibault
Hi, Sascha Sommer, le Sun 07 Jan 2007 00:32:26 +0100, a écrit : > Attached is a very experimental driver for a Ricoh SD Card reader that can be > found in some notebooks like the Samsung P35. Yehaaaw! That reader can be found on DELL X300 too. It works almost fine for me, see attached dmesg.

SAK and screen readers

2006-12-05 Thread Samuel Thibault
Hi, BrlTTY is a screen reader: it is a deamon run as root on machines used by blind users for getting the content of the screen via braille or speech. BrlTTY, like other screen readers (susebl, yasr, ...) needs to open /dev/tty0 for performing various actions, namely: - VT_ACTIVATE -

Linux should define ENOTSUP

2006-12-06 Thread Samuel Thibault
Hi, ENOTSUP is not used at all by linux (though it is defined for parisc), while as susv3 specifies, ENOTSUP shall be different than EOPNOTSUPP. Is there a reason for doing so? (except history) Currently, code like switch(errno) { ENOTSUP: foo(); break;

Re: Linux should define ENOTSUP

2006-12-06 Thread Samuel Thibault
Hi, Arjan van de Ven, le Wed 06 Dec 2006 15:25:14 +0100, a écrit : > > > Is there any way to fix this? Glibc people don't seem to want to fix it > > on their part, see > > http://sources.redhat.com/bugzilla/show_bug.cgi?id=2363 > > Ulrich asked you to go to us once your time travel machine was

Re: Linux should define ENOTSUP

2006-12-06 Thread Samuel Thibault
H. Peter Anvin, le Wed 06 Dec 2006 07:16:39 -0800, a écrit : > Arjan van de Ven wrote: > >>Is there any way to fix this? Glibc people don't seem to want to fix it > >>on their part, see > >>http://sources.redhat.com/bugzilla/show_bug.cgi?id=2363 > > > >Hi, > > > >Ulrich asked you to go to us once

Re: Linux should define ENOTSUP

2006-12-06 Thread Samuel Thibault
H. Peter Anvin, le Wed 06 Dec 2006 07:26:44 -0800, a écrit : > Samuel Thibault wrote: > >H. Peter Anvin, le Wed 06 Dec 2006 07:16:39 -0800, a écrit : > >>Arjan van de Ven wrote: > >>>>Is there any way to fix this? Glibc people don't seem to want to fix it &g

Re: Linux should define ENOTSUP

2006-12-06 Thread Samuel Thibault
H. Peter Anvin, le Wed 06 Dec 2006 07:35:49 -0800, a écrit : > Samuel Thibault wrote: > >>The two can't be done at the same time. In fact, the two probably can't > >>be done without a period of quite a few *years* between them. > > > >Not a reason for not

Re: Tulip dmfe carrier detection

2006-11-25 Thread Samuel Thibault
Hi, Samuel Thibault, le Fri 10 Nov 2006 15:49:19 +0100, a écrit : > The dmfe module lacks netif stuff for carrier detection, while the board > does report carrier status. Here is a patch. Just an additional fixup: the default state should be carrier off. This fixes boot carrier det

Re: differences between MADV_FREE and MADV_DONTNEED

2007-03-01 Thread Samuel Thibault
Hi, Eric wrote: > > We should implement a real MADV_DONTNEED and rename the current one > > to MADV_FREE, but that's 2.6.17 material. > > We definitely need to check this. I am fairly certain I have seen > this conversation before. Yes, it was back in 2005:

mbind and alignment

2007-04-03 Thread Samuel Thibault
Hi, mbind(start, len, ...) currently requires that "start" be page-aligned, but not "len" (which automatically gets page-rounded up). This is a bit odd: - the userland type of start is void*, which people would expect to be a pointer to some variable. - start needing to be page-aligned but

Re: mbind and alignment

2007-04-04 Thread Samuel Thibault
Hi, Andi Kleen, le Wed 04 Apr 2007 13:52:04 +0200, a écrit : > > So one of those should probably be done to free people from headaches: > > > > - document "start" requirement in the manual page > > - require len to be aligned too, and document the requirements in the > > manual page > > - drop

Add a norecovery option to ext3/4?

2007-04-08 Thread Samuel Thibault
Hi, Distribution installers usually try to probe OSes for building a suited grub menu. Unfortunately, mounting an ext3 partition, even in read-only mode, does perform some operations on the filesystem (log recovery). This is not a good idea since it may silently garbage data. XFS has a

Re: Add a norecovery option to ext3/4?

2007-04-08 Thread Samuel Thibault
Eric Sandeen, le Sun 08 Apr 2007 22:24:50 -0500, a écrit : > Samuel Thibault wrote: > >Distribution installers usually try to probe OSes for building a suited > >grub menu. Unfortunately, mounting an ext3 partition, even in read-only > >mode, does perform some operations o

Re: [PATCH] [NETDEV] [000] dmfe : fix bugs and add features

2007-02-10 Thread Samuel Thibault
Hi, Jeff Garzik, le Fri 09 Feb 2007 16:15:26 -0500, a écrit : > Levitsky Maxim wrote: > >Before some time I decided to fix suspend/resume on my Davicom > >network card. During development I also fixed couple of bugs and > >added support for link detection and WOL Note : 2.6.20 already has >

Re: Experimental driver for Ricoh Bay1Controller SD Card readers

2007-02-13 Thread Samuel Thibault
Pierre Ossman, le Tue 13 Feb 2007 06:47:41 +0100, a écrit : > Sascha Sommer wrote: > > I still consider this driver experimental, but without documentation this > > is > > probably not going to change anytime soon. > > The question is now what I should do with the driver? > > Is it worth to be

Re: [ANN] Userspace M-on-N threading model implementation. Alpha release.

2007-01-29 Thread Samuel Thibault
Hi, Evgenity, le Mon 29 Jan 2007 16:47:36 +0100, a écrit : > Userspace M-on-N threading model is based on the idea, that when signal > is delivered, kernel saves all information related to previous context > in stack, so it is possible to find it and replace. You may want to have a look at some

Re: [ANN] Userspace M-on-N threading model implementation. Alpha release.

2007-01-30 Thread Samuel Thibault
Evgeniy Polyakov, le Tue 30 Jan 2007 12:53:16 +0300, a écrit : > > You may want to have a look at some existing implementations: > > I saw most of them. > As far as I recall, only PTL (is not shown here) has preemptible > scheduler. NTL has it too, but is based on different approach. Marcel has

[PATCH] Oddity in mxcsr_feature_mask_init()

2007-06-08 Thread Samuel Thibault
onsidering the code around, it doesn't do much difference, but it makes more sense (i.e. we just fill fxsave). Samuel Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> --- linux-2.6.21-orig/arch/i386/kernel/i387.c.orig 2007-06-08 18:18:10.0 +0800 +++ linux-2.6.21-orig/arch/i386/

[PATCH] Fix pata_qdi.c probe code

2007-05-03 Thread Samuel Thibault
Hi, There is a small typo in the probe code of pata_qdi.c, here is a patch. Samuel diff --git a/drivers/ata/pata_qdi.c b/drivers/ata/pata_qdi.c index 27685ce..fb8c9e1 100644 --- a/drivers/ata/pata_qdi.c +++ b/drivers/ata/pata_qdi.c @@ -375,7 +375,7 @@ static __init int qdi_init(void)

Re: [PATCH] Use tty_schedule in VT code.

2007-07-17 Thread Samuel Thibault
James Simmons, le Tue 17 Jul 2007 19:37:57 +0100, a écrit : > - schedule_delayed_work(>buf.work, 0); It was schedule_delayed_work(>buf.work, 1); in con_schedule_flip() ; could that matter? Samuel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

[PATCH] 10-dots braille keyboards

2007-08-20 Thread Samuel Thibault
Hi, Some braille keyboards have 10 dots, so extend the Input braille keys definitions. Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> diff --git a/include/linux/input.h b/include/linux/input.h index e02c6a6..17df5a7 100644 --- a/include/linux/input.h +++ b/include/linux/input.h @@

[PATCH] Console keyboard events and accessibility

2007-08-20 Thread Samuel Thibault
.) This also provides access to k_handler so as to permit simulation of keypresses. Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> --- Hi, Some blind people use a kernel engine called Speakup which uses hardware synthesis to speak what gets displayed on the screen. They use the PC ke

Re: [PATCH] Console keyboard events and accessibility

2007-08-21 Thread Samuel Thibault
Hi, Andrew Morton, le Tue 21 Aug 2007 13:02:33 -0700, a écrit : > On Tue, 21 Aug 2007 02:57:18 +0200 > Samuel Thibault <[EMAIL PROTECTED]> wrote: > > > Some external modules like Speakup need to use the PC keyboard to control > > them and also need to get keyboard feed

Re: [PATCH] Console keyboard events and accessibility

2007-08-21 Thread Samuel Thibault
Hi, Jan Engelhardt, le Tue 21 Aug 2007 22:42:24 +0200, a écrit : > >- keycodes: even before translation into keysym. > > They can use the raw xlation for that. For userland, yes. This is for kernel modules. Samuel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH] Console events and accessibility

2007-08-21 Thread Samuel Thibault
Some external modules like Speakup need to monitor console output. This adds a VT notifier that such modules can use to get console output events: allocation, deallocation, writes, other updates (cursor position, switch, etc.) Signed-off-by: Samuel Thibault <[EMAIL PROTEC

Re: [PATCH] Console events and accessibility

2007-08-22 Thread Samuel Thibault
Greg KH, le Tue 21 Aug 2007 22:48:55 -0700, a écrit : > On Tue, Aug 21, 2007 at 11:29:39PM +0200, Samuel Thibault wrote: > > Some external modules like Speakup need to monitor console output. > > > > This adds a VT notifier that such modules can use to get conso

Re: [PATCH] Console events and accessibility

2007-08-22 Thread Samuel Thibault
Samuel Thibault, le Wed 22 Aug 2007 10:53:55 +0200, a écrit : > Greg KH, le Tue 21 Aug 2007 22:48:55 -0700, a écrit : > > On Tue, Aug 21, 2007 at 11:29:39PM +0200, Samuel Thibault wrote: > > > Some external modules like Speakup need to monitor console output. > > > &g

Re: [PATCH] Console events and accessibility

2007-08-23 Thread Samuel Thibault
Greg KH, le Thu 23 Aug 2007 03:04:02 -0700, a écrit : > > I mean: yes, with these three patches, speakup will work fine. > > 3 patches? I only saw 2. Or do you mean the modifications of the 3 > files? Maybe you missed the keyboard notification patch which is already in -mm. > The patches look

Re: [PATCH] Console events and accessibility

2007-08-23 Thread Samuel Thibault
Hi, Greg KH, le Thu 23 Aug 2007 09:33:18 -0700, a écrit : > Yes I did, sorry. Do you have a pointer for it, all I see is these > patches in -mm: > console-keyboard-events-and-accessibility.patch Here is the patch > console-keyboard-events-and-accessibility-fix.patch >

Re: [PATCH] Console events and accessibility

2007-08-23 Thread Samuel Thibault
Samuel Thibault, le Thu 23 Aug 2007 19:08:45 +0200, a écrit : > > If you need help in this area, I can see about doing a bit as I did a > > lot of cleanup of this codebase a few years ago. I also know of a few > > users who are willing to help test this stuff out. > >

Re: [PATCH] Console keyboard events and accessibility

2007-08-27 Thread Samuel Thibault
Hi, Adrian Bunk, le Sat 25 Aug 2007 03:07:04 +0200, a écrit : > > If they > > remain in -mm for some time and people don't complain, well that's good > > too: at least we know how speakup may hook into the kernel when it gets > > merged. > >... > > Without any users it's dead code noone uses,

Re: [PATCH] Console keyboard events and accessibility

2007-09-01 Thread Samuel Thibault
Pavel Machek, le Thu 12 Jul 2007 19:19:32 +, a écrit : > On Tue 2007-08-21 22:49:51, Samuel Thibault wrote: > > Hi, > > > > Jan Engelhardt, le Tue 21 Aug 2007 22:42:24 +0200, a écrit : > > > >- keycodes: even before translation into keysym. > >

Re: [PATCH] Console keyboard events and accessibility

2007-09-01 Thread Samuel Thibault
Hi, Pavel Machek, le Sat 01 Sep 2007 12:32:58 +, a écrit : > > > > > They can use the raw xlation for that. > > > > > > > > For userland, yes. This is for kernel modules. > > > > > > And should speakup be a kernel module? Why? > > > > Because userland only begins quite late in the boot

Re: [PATCH] Console keyboard events and accessibility

2007-09-01 Thread Samuel Thibault
Hi, Pavel Machek, le Sat 01 Sep 2007 17:23:02 +, a écrit : > Hi! > > > > > Because userland only begins quite late in the boot process, and > > > > userland may hang. > > > > > > Initrd means userland is started very early on most machines these > > > days, and kernel may hang, too. > > >

Re: [PATCH] Console keyboard events and accessibility

2007-09-01 Thread Samuel Thibault
Pavel Machek, le Sat 01 Sep 2007 18:18:45 +, a écrit : > > > > Very early is not so early, and loading initrd itself may actually fail. > > > > The kernel may indeed hang, but there are more chances to get some > > > > messages before the hang. Don't _you_ have a VGA screen for getting > > >

Re: console UTF-8 fixes

2007-07-24 Thread Samuel Thibault
Hi, Egmont got some UTF-8 fixes in mainline, Andrew Morton suggested it might be a good time to remember about bug 7746 Support for unicode dead keys: http://bugzilla.kernel.org/show_bug.cgi?id=7746 : « Quoting a mail from Vojtech Pavlik: "Several languages (polish, czech, slovak, ...) use dead

Re: [PATCH] unicode diacritics support

2007-08-09 Thread Samuel Thibault
Hi, Andrew Morton, le Thu 09 Aug 2007 12:46:42 -0700, a écrit : > > Turn the kernel accent_table into unicode, and extend ioctls KDGKBDIACR > > and KDSKBDIACR into their equivalents KDGKBDIACRUC and KDSKBDIACR. > > > > New function int conv_uni_to_8bit(u32 uni) for converting unicode into 8bit >

Re: 2.6.23-rc2-mm2: drivers/s390/char/keyboard.c compile error

2007-08-10 Thread Samuel Thibault
BDIACR. New function int conv_uni_to_8bit(u32 uni) for converting unicode into 8bit _input_. No, we don't want to store the translation, as it is potentially sparse and large. Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> diff --git a/drivers/acorn/char/defkeymap-l7200.c b/drivers/ac

Keyboard CapsShift Lock

2007-08-14 Thread Samuel Thibault
Hi, There exists a CapsShift lock called KG_CAPSSHIFT, but no associated lock/slock, here is a patch. Samuel Add CapsShift lock and slock. Signed-off-by: Samuel Thibault <[EMAIL PROTECTED]> diff --git a/include/linux/keyboard.h b/include/linux/keyboard.h index d97066f..61f12d4

[PATCH] unicode diacritics support

2007-08-08 Thread Samuel Thibault
, and extend ioctls KDGKBDIACR and KDSKBDIACR into their equivalents KDGKBDIACRUC and KDSKBDIACR. New function int conv_uni_to_8bit(u32 uni) for converting unicode into 8bit _input_. No, we don't want to store the translation, as it is potentially sparse and large. Signed-off-by: Samuel Thibault

Re: [bisected][mismerge?] Re: [microcode] 2.6.23.git pulled this morning oopses loading P4 microcode

2007-10-19 Thread Samuel Thibault
Just to make sure, could you check in System.map that accent_table is correctly 256*3*4=3072 bytes long? Samuel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [bisected][mismerge?] Re: [microcode] 2.6.23.git pulled this morning oopses loading P4 microcode

2007-10-18 Thread Samuel Thibault
Hi, Mike Galbraith, le Thu 18 Oct 2007 19:56:38 +0200, a écrit : > The winner of a very long git bisect session: > > unicode diacritics support Uh, I fail to see how that could have an impact, I've again checked the boundaries, it looks fine, please people have a look. Could you try

Hardware locality (hwloc) v1.7 released

2013-04-08 Thread Samuel Thibault
The Hardware Locality (hwloc) team is pleased to announce the release of v1.7: http://www.open-mpi.org/projects/hwloc/ v1.7 is a major new release series. The v1.6 series focused on the core rework to ease the addition of new discovery components. As expected, v1.7 now adds many new

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2013-07-13 Thread Samuel Thibault
Pavel Machek, le Sat 13 Jul 2013 01:33:01 +0200, a écrit : > > > > This permits to reassign keyboard LEDs to something else than keyboard > > > > "leds" > > > > state, by adding keyboard led and modifier triggers connected to a > > > > series > > > > of VT input LEDs, themselves connected to VT

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2013-07-15 Thread Samuel Thibault
Hello, David Herrmann, le Mon 15 Jul 2013 17:03:08 +0200, a écrit : > > @@ -13,6 +13,10 @@ > > bool "Virtual terminal" if EXPERT > > depends on !S390 && !UML > > select INPUT > > + select NEW_LEDS > > + select LEDS_CLASS > > + select LEDS_TRIGGERS > > +

[PATCHv2] Route kbd LEDs through the generic LEDs layer

2013-07-17 Thread Samuel Thibault
ge the LED behavior of (a priori) all input devices, or of particular input devices. This also permits to fix #7063 from userland by using a modifier to implement proper CapsLock behavior and have the keyboard caps lock led show that modifier state. Signed-off-by: Samuel Thibault [ebro...@mo

[PATCH] Fix build without CONFIG_INPUT_LEDS [Was: mmotm 2013-10-29-16-22 uploaded (input)]

2013-10-30 Thread Samuel Thibault
eds-layer.patch or perhaps rather fold into it? Samuel Really mark inlines as static inlines, so they are not defined multiple times. Signed-off-by: Samuel Thibault --- include/linux/input.h.orig 2013-10-30 12:42:41.169038670 +0100 +++ include/linux/input.h 2013-10-30 12:42:42.908987157 +0

Re: linux-next: Tree for Oct 31 (input & leds)

2013-10-31 Thread Samuel Thibault
IG_INPUT_LEDS=m > > ERROR: "input_led_disconnect" [drivers/input/input-core.ko] undefined! > ERROR: "input_led_connect" [drivers/input/input-core.ko] undefined! > > > Full randconfig file is attached. Ah, right, in that config an export is needed, here is a p

Re: [next:master 23/358] undefined reference to `i2c_add_adapter'

2013-11-03 Thread Samuel Thibault
Fengguang Wu, le Sun 03 Nov 2013 20:08:53 +0800, a écrit : > It's a bug fix that unveils the link errors. > >drivers/built-in.o: In function `__input_unregister_device': >input.c:(.text+0xf0e55): undefined reference to `input_led_disconnect' Ok, so the "something like this" in the patch

Re: [next:master 23/358] undefined reference to `input_led_disconnect'

2013-11-03 Thread Samuel Thibault
Samuel Thibault, le Sun 03 Nov 2013 13:36:21 +0100, a écrit : > So in the end it would probably be simpler to just stuff leds.c along > input.c in input.ko or built-in. CONFIG_INPUT_LEDS will thus become a > bool. I'm working on that now. Here it is. This replaces both input-route

Hardware locality (hwloc) v1.8 released

2013-11-19 Thread Samuel Thibault
The Hardware Locality (hwloc) team is pleased to announce the release of v1.8: http://www.open-mpi.org/projects/hwloc/ v1.8 is a major new release series. It adds PCI discovery on Linux without dependencies on external libs, a new API to manipulate differences between very similar topologies,

Re: [PATCH] Staging: speakup: synth.c: removed a space

2013-12-03 Thread Samuel Thibault
Aldo Iljazi, le Tue 03 Dec 2013 22:08:03 +0200, a écrit : > Line 468: Removed a space before a semicolon. Err, I'd rather make it really visible that the for loop doesn't have its first statement? Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [ANNOUNCE] util-linux v2.23-rc1

2013-03-22 Thread Samuel Thibault
Hello, Karel Zak, le Fri 22 Mar 2013 13:56:21 +0100, a écrit : > The util-linux release v2.23-rc1 is available at > >ftp://ftp.kernel.org/pub/linux/utils/util-linux/v2.23 > > Feedback and bug reports, as always, are welcomed. Here is a couple of obvious fixes for non-linux systems.

Re: Caps lock XOR on multiple keyboards?

2013-03-24 Thread Samuel Thibault
Hello, I can confirm that things go fine on the Linux console. There is just one state, which is shown on all keyboards. This is really a bug in Xorg, please report the issue there. Pavel Machek, le Sun 24 Mar 2013 11:30:18 +0100, a écrit : > There is patch to drive keyboard LEDs through LED

Re: [PATCH] Route kbd LEDs through the generic LEDs layer

2014-03-16 Thread Samuel Thibault
Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit : > Hello, what happened with this patch? Is there any problem with accepting it? Dmitry finding time to review it, I guess. Samuel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCHv2] Route kbd LEDs through the generic LEDs layer

2013-10-13 Thread Samuel Thibault
Hello, Andrew Morton, le Tue 08 Oct 2013 16:01:52 -0700, a écrit : > Do you believe that the earlier controversies are now addressed and if > so, how? Yes. Dmitry thought more about how to integrate that nicely on 12th Jan 2011, which I did. The patch was rebased on 3.x, and I submitted a

Re: [PATCH] staging: speakup: kobjects.c: Use correct values when changing voice.

2013-09-11 Thread Samuel Thibault
w user input that was used to select the voice. > Note that using the raw input can also lead to an invalid memory read > in the case of invalid or malicious user input. > > Signed-off-by: Christopher Brannon Acked-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c

Re: [PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-09-11 Thread Samuel Thibault
fies the code > and allows code reusing. > > Signed-off-by: Raphael S.Carvalho Acked-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 71 > > 1 files changed, 39 insertions(+), 32 deletions(-) > > diff --git a/drivers

[PATCHv2] Route kbd LEDs through the generic LEDs layer

2013-09-04 Thread Samuel Thibault
ge the LED behavior of (a priori) all input devices, or of particular input devices. This also permits to fix #7063 from userland by using a modifier to implement proper CapsLock behavior and have the keyboard caps lock led show that modifier state. Signed-off-by: Samuel Thibault [ebro...@mo

Re: [v3.11-rc1 PATCH 3/5] printk: Move braille console support into separate braille.[ch] files

2013-07-20 Thread Samuel Thibault
> link: > http://lkml.kernel.org/r/1350999678-17441-1-git-send-email-ming....@canonical.com > cc: Samuel Thibault Reviewed-By: Samuel Thibault Thanks, Samuel > cc: Ming Lei > Signed-off-by: Joe Perches > --- > drivers/accessibility/braille/braille_console

Re: [PATCH 1/1] staging/speakup/kobjects.c: Code improvement.

2013-06-30 Thread Samuel Thibault
fies the code > and allows code reusing. > > Signed-off-by: Raphael S. Carvalho Acked-by: Samuel Thibault > --- > drivers/staging/speakup/kobjects.c | 73 +++ > 1 files changed, 40 insertions(+), 33 deletions(-) > > diff --git a/drivers/st

Re: [PATCH] staging: speakup: fix warnings by adding __user annotations

2013-05-22 Thread Samuel Thibault
rgument 2 > (different address spaces)) > drivers/staging/speakup/devsynth.c:63:18: > expected long ( *write )( ... ) > drivers/staging/speakup/devsynth.c:63:18: > got long ( static [toplevel] * )( ... ) > > Signed-off-by: Emil Goode Acked-by: Samuel T

Re: [PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-04-07 Thread Samuel Thibault
Dmitry Torokhov, le Sun 06 Apr 2014 19:10:15 -0700, a écrit : > On Mon, Mar 31, 2014 at 02:23:23PM +0200, Samuel Thibault wrote: > > This permits to reassign keyboard LEDs to something else than keyboard > > "leds" > > state, by adding keyboard led and modifier

Hardware locality (hwloc) v1.9 released

2014-03-26 Thread Samuel Thibault
The Hardware Locality (hwloc) team is pleased to announce the release of v1.9: http://www.open-mpi.org/projects/hwloc/ v1.9 is a major new release series. It adds a couple enhanced API functions, many object attributes for better representing CPU and I/O device characteristics, and more. *

Re: 8 months to review a patch (was Re: [PATCH] Route kbd LEDs through the generic LEDs layer)

2014-03-28 Thread Samuel Thibault
Pavel Machek, le Fri 28 Mar 2014 08:01:36 +0100, a écrit : > On Thu 2014-03-27 02:08:17, Pali Rohár wrote: > > 2014-03-16 11:19 GMT+01:00 Samuel Thibault : > > > Pali Rohár, le Sun 16 Mar 2014 11:16:25 +0100, a écrit : > > >> Hello, what happened with th

[PATCH] Route keyboard LEDs through the generic LEDs layer.

2014-03-31 Thread Samuel Thibault
cleaned up some includes, and fixed some constants] [blo...@openwrt.org: CONFIG_INPUT_LEDS stubs should be static inline] [a...@linux-foundation.org: remove unneeded `extern', fix comment layout] Signed-off-by: Samuel Thibault Signed-off-by: Evan Broder Reviewed-by: David Herrmann Tested-by: Pa

Re: [PATCH] Staging: speakup: don't die if accessing sysfs without synth

2014-05-28 Thread Samuel Thibault
Sasha Levin, le Tue 27 May 2014 19:08:36 -0400, a écrit : > Setting a 'silent' parameter without a synth would crash the kernel. > > Signed-off-by: Sasha Levin Acked-by: Samuel Thibault > --- > drivers/staging/speakup/synth.c |3 +++ > 1 file changed, 3 insertions(

[PATCH,TRIVIAL] Update speakup mailing list address

2014-07-17 Thread Samuel Thibault
The speakup mailing list only works on the linux-speakup.org domain now. Signed-off-by: Samuel Thibault diff --git a/MAINTAINERS b/MAINTAINERS index 61a8f48..bcf5efd 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8646,7 +8646,7 @@ M:William Hubbs M: Chris Brannon M: Kirk

[PATCH] staging: speakup: Add unicode support to the speakup_dummy driver

2018-03-10 Thread Samuel Thibault
of spk_do_catch_up. Signed-off-by: Samuel Thibault Index: linux-4.15/drivers/staging/speakup/spk_types.h === --- linux-4.15.orig/drivers/staging/speakup/spk_types.h +++ linux-4.15/drivers/staging/speakup/spk_types.h @@ -151,6 +151,7

[PATCH] staging: speakup: use true/false instead of 1/0

2018-05-14 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- drivers/staging/speakup/buffers.c |2 +- drivers/staging/speakup/main.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/drivers/staging/speakup/buffers.c +++ b/drivers/staging/speakup/buffers.c @@ -80,7 +80,7 @@ void synth_buffer_add

[PATCHv2] staging: speakup: Add pause command used on switching to graphical mode

2018-05-07 Thread Samuel Thibault
For software speech syntheses to be able to manage concurrent audio card access, they need to know when speakup stops emitting text to be spoken because the console has switched to graphical mode. This introduces a PAUSE command to do so. Signed-off-by: Samuel Thibault --- Difference from v1

[PATCH] staging: speakup: Fix coding style

2018-05-13 Thread Samuel Thibault
Signed-off-by: Samuel Thibault --- drivers/staging/speakup/buffers.c |3 ++- drivers/staging/speakup/main.c|5 ++--- 2 files changed, 4 insertions(+), 4 deletions(-) --- a/drivers/staging/speakup/buffers.c +++ b/drivers/staging/speakup/buffers.c @@ -78,7 +78,8 @@ void

Re: [PATCH] staging: speakup: Add pause command used on switching to graphical mode

2018-05-01 Thread Samuel Thibault
For software speech syntheses to be able to manage concurrent audio card access, they need to know when speakup stops emitting text to be spoken because the console has switched to graphical mode. This introduces a PAUSE command to do so. Signed-off-by: Samuel Thibault Index: linux-4.15

[PATCH] staging: speakup: Add pause command used on switching to graphical mode

2018-05-01 Thread Samuel Thibault
For software speech syntheses to be able to manage concurrent audio card access, they need to know when speakup stops emitting text to be spoken because the console has switched to graphical mode. This introduces a PAUSE command to do so. Signed-off-by: Samuel Thibault Index: linux-4.15

Re: [PATCHv2] staging: speakup: Add pause command used on switching to graphical mode

2018-05-08 Thread Samuel Thibault
Greg KH, le mar. 08 mai 2018 13:31:31 +0200, a ecrit: > On Mon, May 07, 2018 at 10:14:27PM +0200, Samuel Thibault wrote: > > For software speech syntheses to be able to manage concurrent audio card > > access, they need to know when speakup stops emitting text to be spoken > >

tty: Fix comment for value returned by tty_ldisc_receive_buf

2018-01-03 Thread Samuel Thibault
tty_ldisc_receive_buf actually returns the number of bytes processed by receive_buf or receive_buf2. Signed-off-by: Samuel Thibault --- drivers/tty/tty_buffer.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/tty/tty_buffer.c +++ b/drivers/tty/tty_buffer.c @@ -420,7

Re: [PATCH 0/2] input - leds: fix bugs found by fuzzing

2017-12-14 Thread Samuel Thibault
Hello, Benjamin Tissoires, on jeu. 14 déc. 2017 14:25:20 +0100, wrote: > I marked them as stable as I believe eventhough not many > people discovered those and reported them, they should > still be fixed in current kernels. Well, the quoted source lines are not in any stable tree, I don't even

Re: [PATCH 2/2] input - leds: fix input_led_disconnect path

2017-12-14 Thread Samuel Thibault
. > > Found with https://github.com/whot/fuzzydevice > Link: https://bugzilla.kernel.org/show_bug.cgi?id=197679 > > Cc: sta...@vger.kernel.org > Signed-off-by: Benjamin Tissoires input_close_device does run synchronize_rcu() which we seem to have to process before freeing the rest i

Re: [PATCH] staging: speakup: selection: replace _manual_ swap with swap macro

2017-11-10 Thread Samuel Thibault
e. > > Signed-off-by: Gustavo A. R. Silva Acked-by: Samuel Thibault > --- > drivers/staging/speakup/selection.c | 9 ++--- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/speakup/selection.c > b/drivers/staging/speakup/s

Re: [PATCH] staging: speakup: make function ser_to_dev static

2017-06-28 Thread Samuel Thibault
walter harms, on mer. 28 juin 2017 16:49:03 +0200, wrote: > Am 28.06.2017 15:13, schrieb Colin King: > > diff --git a/drivers/staging/speakup/spk_ttyio.c > > b/drivers/staging/speakup/spk_ttyio.c > > index 442f191a017e..ed8e96b06ead 100644 > > --- a/drivers/staging/speakup/spk_ttyio.c > > +++

Re: [PATCH] Staging: speakup: speakup_keypc.c: usleep_range is preferred over udelay

2017-07-12 Thread Samuel Thibault
Jaya Durga, on mer. 12 juil. 2017 16:53:53 +0530, wrote: > Fix checkpatch issue: CHECK: usleep_range is preferred over udelay; IIRC synth_immediate is meant to be usable in atomic contexts too, so usleep can't be used. Samuel

[PATCH 2/2] speakup: only build serialio when ISA is enabled

2020-08-04 Thread Samuel Thibault
Drivers using serialio are already made available in Kconfig only under the ISA condition. This solves warnings in inb/outb macros on platform that do not have support for ISA. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/Makefile

[PATCH 1/2] speakup: Fix wait_for_xmitr for ttyio case

2020-08-04 Thread Samuel Thibault
yes. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/serialio.c === --- linux-2.6.orig/drivers/accessibility/speakup/serialio.c +++ linux-2.6/drivers/accessibility/speakup/serialio.c @@ -32,6 +32,7

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

2020-08-04 Thread Samuel Thibault
Greg KH, le mar. 04 août 2020 13:34:13 +0200, a ecrit: > On Tue, Aug 04, 2020 at 01:13:32PM +0200, Samuel Thibault wrote: > > Drivers using serialio are already made available in Kconfig only under > > the ISA condition. > > > > This solves warnings in inb/outb macros o

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

2020-08-04 Thread Samuel Thibault
Greg KH, le mar. 04 août 2020 13:58:17 +0200, a ecrit: > ERROR: modpost: "spk_serial_io_ops" > [drivers/accessibility/speakup/speakup_keypc.ko] undefined! > ERROR: modpost: "spk_stop_serial_interrupt" > [drivers/accessibility/speakup/speakup_keypc.ko] undefined! Oh, indeed, these

[PATCHv2 1/2] speakup: Fix wait_for_xmitr for ttyio case

2020-08-04 Thread Samuel Thibault
yes. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/serialio.c === --- linux-2.6.orig/drivers/accessibility/speakup/serialio.c +++ linux-2.6/drivers/accessibility/speakup/serialio.c @@ -32,6 +32,7

[PATCHv2 2/2] speakup: only build serialio when ISA is enabled

2020-08-04 Thread Samuel Thibault
Drivers using serialio were already made available in Kconfig only under the ISA condition. Signed-off-by: Samuel Thibault Index: linux-2.6/drivers/accessibility/speakup/Makefile === --- linux-2.6.orig/drivers/accessibility/speakup

Re: [PATCH 2/2] speakup: only build serialio when ISA is enabled

2020-08-04 Thread Samuel Thibault
Greg KH, le mar. 04 août 2020 17:49:52 +0200, a ecrit: > > #define inb(c) ({ u8 __v; __io_pbr(); __v = > > readb_cpu((void*)(PCI_IOBASE + (c))); __io_par(__v); __v; }) > > > > and thus yes it's arithmetic over a (void*) pointer, the caller cannot > > do anything about it. > > And

[PATCH] speakup: Fix var_id_t values and thus keymap

2020-10-12 Thread Samuel Thibault
ly the volume control shortcut (speakup-1 or 2) was actually changing the inflection. This moves the INFLECTION value at the end of the var_id_t enum to fix back the enum values. This also adds a warning about it. Cc: sta...@vger.kernel.org Reported-by: Kirk Reiser Reported-by: Gregory Nowak

<    1   2   3   4   5   6   7   8   >