Re: [PATCH v2 13/14] power: reset: Add Intel PIIX4 poweroff driver

Hi, On Mon, Sep 19, 2016 at 10:21:30PM +0100, Paul Burton wrote: > Add a driver which allows powering off the system via an Intel PIIX4 > southbridge, by entering the PIIX4 SOff state. This is useful on the > MIPS Malta development board, where it will power down the FPGA based > board until its

Re: [PATCH] power: ab8500: cleanup with list_first_entry_or_null()

Hi, On Tue, Sep 13, 2016 at 03:23:21AM +0900, Masahiro Yamada wrote: > The combo of list_empty() check and return list_first_entry() > can be replaced with list_first_entry_or_null(). > > Signed-off-by: Masahiro Yamada Thanks, queued. -- Sebastian

Re: [RFC PATCH 0/3] UART slave device bus

Hi, On Mon, Aug 22, 2016 at 11:46:10PM +0100, One Thousand Gnomes wrote: > > It's not enough to automatically set a ldisc. There is also need for > > additional resouces. For example the Nokia bluetooth driver needs > > some extra GPIOs. The same is true for the in-tree hci_bcm, which > > misuses

Re: [PATCH v7 5/7] power: act8945a_charger: Add capacity level property

Hi, On Mon, Aug 22, 2016 at 02:49:15PM +0800, Wenyou Yang wrote: > [...] > > + charger->lbo_gpio = gpiod_get(dev->parent, "active-semi,lbo", GPIOD_IN); > + if (PTR_ERR(charger->lbo_gpio) == -EPROBE_DEFER) { > + dev_info(dev, "probe retry requested for gpio \"lbo\"\n"); > +

Re: [PATCH v7 7/7] doc: bindings: act8945a-charger: Update properties

Hi, On Mon, Aug 22, 2016 at 02:49:17PM +0800, Wenyou Yang wrote: > Due the driver improvements, update the properties, > - Remove "active-semi,check-battery-temperature" property. > - Add the properties, "active-semi,irq_gpio" >and "active-semi,lbo-gpios". > > Signed-off-by: Wenyou Yang

Re: [PATCH v7 6/7] power: act8945a_charger: Add max current property

Hi, On Mon, Aug 22, 2016 at 02:49:16PM +0800, Wenyou Yang wrote: > [...] > > - chglev_pin = of_get_named_gpio_flags(np, > - "active-semi,chglev-gpios", 0, ); > - > - if (gpio_is_valid(chglev_pin)) { > - gpio_set_value(chglev_pin, > -

Re: [PATCH 2/2] power: bq24735-charger: Assume not charging when charger is missing

Hi, On Sun, Aug 28, 2016 at 07:34:46PM +0200, Paul Kocialkowski wrote: > When the charger is missing (disconnected), it is safe to assume that > the charger chip is no charging. > > This is especially relevant when a status GPIO is present and the > charger is getting disconnected.

Re: [PATCH 1/2] power: bq24735-charger: Request status GPIO with initial input setup

Hi, On Sun, Aug 28, 2016 at 07:34:45PM +0200, Paul Kocialkowski wrote: > This requests the status GPIO with initial input setup. it is required > to read the GPIO status at probe time and thus correctly avoid sending > i2c messages when AC is not plugged. > > When requesting the GPIO without

Re: [PATCH v05 06/72] include/uapi/linux/hsi/cs-protocol.h: include linux/time.h

Hi, On Mon, Aug 22, 2016 at 08:32:23PM +0200, Mikko Rapeli wrote: > Fixes userspace compilation errors due to missing timespec definition. > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/hsi/cs-protocol.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: [PATCH v05 05/72] hsi_char.h: use __u32 from linux/types.h

Hi, On Mon, Aug 22, 2016 at 08:32:22PM +0200, Mikko Rapeli wrote: > Fixes userspace compiler errors like: > > linux/hsi/hsi_char.h:51:2: error: unknown type name ‘uint32_t’ > > Signed-off-by: Mikko Rapeli > --- > include/uapi/linux/hsi/hsi_char.h | 17 + >

Re: [PATCH v3 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation

Hi, On Sat, Sep 24, 2016 at 07:55:27AM +0200, H. Nikolaus Schaller wrote: > > So ti,max-[xy] is basically the same as touchscreen-size-[xy], > > No it is not the same and should be kept separate. > > > except, that the generic bindings don't support min-[xy] != 0. > > What would be the purpose

Re: [RFC PATCH 0/6] UART slave devices using serio

for the bluetooth parts * Dmitry for the serio parts Maybe you can try to find some minutes at the Kernel Summit to talk about this? Anyways, for the series: Tested-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [RFC PATCH 0/6] UART slave devices using serio

Hi, On Tue, Oct 25, 2016 at 05:02:23PM -0500, Rob Herring wrote: > On Tue, Oct 25, 2016 at 4:55 PM, Sebastian Reichel wrote: > > On Wed, Aug 24, 2016 at 06:24:30PM -0500, Rob Herring wrote: > >> [...] > > I had a more detailed look at the series during the last two weeks.

Re: [PATCH 0/4] power: reset: Fix module autoload for some platform drivers

Hi Javier, On Mon, Oct 17, 2016 at 03:36:11PM -0300, Javier Martinez Canillas wrote: > I noticed that module autoload won't be working in a some of the reset > platform drivers This patch series contains the fixes for these. > > Best regards, > Javier > > > Javier Martinez Canillas (4): >

Re: [PATCH 0/2] power: supply: Fix module autoload for some platform drivers

Hi Javier, On Mon, Oct 17, 2016 at 04:13:34PM -0300, Javier Martinez Canillas wrote: > Hello Sebastian, > > I noticed that module autoload won't be working for some of the power > supply platform drivers. This patch series contains fixes for these. > > Best regards, > Javier > > > Javier

Re: [patch] power: supply: lp8788: remove an unneeded NULL check

Hi Dan, On Fri, Oct 14, 2016 at 10:33:28AM +0300, Dan Carpenter wrote: > We checked that "pdata->chg_params" is non-NULL earlier in this function > so when we add "i" to it, it's still non-NULL. > > Signed-off-by: Dan Carpenter > > diff --git

Re: [PATCH 1/2] power: reset: Add qcom reboot mode driver

Hi, On Fri, Oct 14, 2016 at 11:06:14AM +0800, xiaog...@codeaurora.org wrote: > 在 2016-10-14 10:41，Andy Yan 写道： > > On 2016年10月14日 10:02, Xiaogang Cui wrote: > > > This is a initial version so it's very similar with syscon > > > reboot mode driver. We will add more functionalities in the > > >

Re: [PATCH net-next v2 7/9] net: use core MTU range checking in misc drivers

Hi, On Thu, Oct 20, 2016 at 01:55:22PM -0400, Jarod Wilson wrote: > hsi/clients/ssi_protocol: > - use core MTU range checking > - remove now redundant ssip_pn_set_mtu Acked-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] power: max17040: Change register transaction length from 8 bits to 16 bits

Hi, On Wed, Sep 21, 2016 at 10:17:34PM +0800, Liu Xiang wrote: > According to the datasheet, MAX17040 has six 16-bit registers. > Register reads and writes are only valid if all 16 bits are transferred. > Any write command that is terminated early is ignored. > So it's better to change register

Re: [PATCH 08/15] power: improve function-level documentation

Hi Julia, On Sat, Oct 01, 2016 at 09:46:25PM +0200, Julia Lawall wrote: > In drivers/power/supply/ab8500_fg.c, fix two typos and adjust the function > name in two cases to correspond to the names of the defined functions. > > In drivers/power/supply/power_supply_core.c, change two variable names

Re: [PATCH] power: bq27xxx_battery: don't update poll_interval param if same

Hi, On Fri, Sep 30, 2016 at 09:45:30PM -0700, Matt Ranostay wrote: > To avoid canceling the delayed workqueue needlessly, and scheduling an > immediate polling. Check if the new poll_interval value is different > than the previous setting. > > Cc: Tony Lindgren <t...@atomide.co

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi Sakari, On Mon, Nov 14, 2016 at 11:58:28PM +0200, Sakari Ailus wrote: > [...] > > On Fri, Nov 04, 2016 at 01:05:25AM +0100, Sebastian Reichel wrote: > > I'm not sure what part relevant for video-bus-switch is currently > > not supported? > > > > video-b

Re: [PATCH] power: supply: bq27xxx_battery: Fix register map for BQ27510 and BQ27520

Hi, On Fri, Nov 04, 2016 at 01:33:13PM -0500, Andrew F. Davis wrote: > The BQ27510 and BQ27520 use a slightly different register map than the > BQ27500, add a new type enum and add these gauges to it. > > Fixes: d74534c27775 ("power: bq27xxx_battery: Add support for additional > bq27xxx family

Re: [PATCH 6/9] power_supply: wm97xx_battery: use power_supply_get_drvdata

Hi Robert, On Wed, Oct 26, 2016 at 09:41:44PM +0200, Robert Jarzmik wrote: > As the power supply framework provides a way to store and retrieve > private supply data, use it. > > In the process, change the platform data for wm97xx_battery from a > container of a single struct wm97xx_batt_pdata

Re: [PATCH 03/15] wm8350_power: use permission-specific DEVICE_ATTR variants

Hi Julia, On Sat, Oct 29, 2016 at 09:36:57PM +0200, Julia Lawall wrote: > Use DEVICE_ATTR_RO for read only attributes. This simplifies the source > code, improves readbility, and reduces the chance of inconsistencies. > > The semantic patch that makes this change is as follows: >

Re: [PATCH 1/2] power: supply: add sbs-charger driver

Hi, On Wed, Nov 23, 2016 at 12:20:43PM +0100, Nicolas Saenz Julienne wrote: > This adds support for sbs-charger compilant chips as defined here: > http://sbs-forum.org/specs/sbc110.pdf > > This was tested on a arm board connected to an LTC41000 battery charger > chip. > > Signed-off-by: Nicolas

Re: [PATCH 2/2] dt-bindings: power: add bindings for sbs-charger

Hi, On Wed, Nov 23, 2016 at 12:20:44PM +0100, Nicolas Saenz Julienne wrote: > Adds device tree documentation for SBS charger compilant devices as defined > here: http://sbs-forum.org/specs/sbc110.pdf > > Signed-off-by: Nicolas Saenz Julienne > --- >

Re: [PATCH] power: ab8500_btemp: use builtin_platform_driver

Hi, On Wed, Nov 23, 2016 at 10:56:52PM +0800, Geliang Tang wrote: > Use builtin_platform_driver() helper to simplify the code. > > Signed-off-by: Geliang Tang > > [...] > > +builtin_platform_driver(ab8500_btemp_driver); > module_exit(ab8500_btemp_exit); builtin_XYZ()

Re: [PATCH 1/2] power: supply: sbs-battery: use fixed device name

Hi, On Mon, Nov 21, 2016 at 07:04:50PM +0100, Nicola Saenz Julienne wrote: > The current device name for sbs-battery is derived from it's i2c address. > This is not acceptable if we want to be able to trigger the > "external_power_changed()" routine from a charger driver. > > Signed-off-by:

Re: [PATCH 2/2] power: supply: add sbs-charger driver

Hi Nicola, I have a couple of comments. On Mon, Nov 21, 2016 at 07:04:51PM +0100, Nicola Saenz Julienne wrote: > This adds support for sbs-charger compilant chips as defined here: > http://sbs-forum.org/specs/sbc110.pdf Please add that link in the header of the driver. > > This was tested on

Re: [PATCH 1/2] power: supply: sbs-battery: use fixed device name

Hi, On Tue, Nov 22, 2016 at 04:31:51PM +0100, Nicolas Saenz Julienne wrote: > > NAK. This is not ok for systems using multiple sbs-batteries. > > Also please read: > > sorry I wasn't aware of that feature, I'll have a look at the > whole thing and rework the patch. no problem. I also reviewed

Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation into single function

Hi, On Tue, Nov 15, 2016 at 10:18:51PM +0900, Milo Kim wrote: > TPS65217 charger driver handles the charger interrupt through the IRQ or > polling. Both cases can be requested in single function. > > Cc: Enric Balletbo i Serra > Signed-off-by: Milo Kim

Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation into single function

Hi, On Tue, Nov 22, 2016 at 05:49:11PM +0100, Sebastian Reichel wrote: > On Tue, Nov 15, 2016 at 10:18:51PM +0900, Milo Kim wrote: > > TPS65217 charger driver handles the charger interrupt through the IRQ or > > polling. Both cases can be requested in single function. > > &

Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data

Hi, [it's me again after reading Patch 3] On Tue, Nov 22, 2016 at 05:51:07PM +0100, Sebastian Reichel wrote: > On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote: > > IRQ number is only used on requesting the interrupt, so no need to keep > > it inside the driver data. Ple

Re: [PATCH 2/5] power: supply: tps65217: Remove IRQ data from driver data

Hi, On Tue, Nov 15, 2016 at 10:18:52PM +0900, Milo Kim wrote: > IRQ number is only used on requesting the interrupt, so no need to keep > it inside the driver data. > In case of polling, poll_task is valid only when polling thread is > activated. > > Cc: Enric Balletbo i Serra

Re: wl1251 & mac address & calibration data

Hi, On Thu, Nov 24, 2016 at 09:33:29AM +0100, Pali Rohár wrote: > On Thursday 24 November 2016 08:51:04 Pavel Machek wrote: > > Hi! > > > > > > "ifconfig hw ether XX" normally sets the address. I guess that's > > > > ioctl? > > > > > > This sets temporary address and it is ioctl. IIRC same as

Re: wl1251 & mac address & calibration data

Hi, On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > On Thursday 24 November 2016 16:13:17 Sebastian Reichel wrote: > > On Thu, Nov 24, 2016 at 09:33:29AM +0100, Pali Rohár wrote: > > > On Thursday 24 November 2016 08:51:04 Pavel Machek wrote: > > >

Re: wl1251 & mac address & calibration data

Hi, On Thu, Nov 24, 2016 at 05:49:33PM +0100, Pali Rohár wrote: > On Thursday 24 November 2016 17:08:30 Sebastian Reichel wrote: > > On Thu, Nov 24, 2016 at 04:20:45PM +0100, Pali Rohár wrote: > > > On Thursday 24 November 2016 16:13:17 Sebastian Reichel wrote: > > > &

Re: Lenovo Dock + Thinkpad X260 -> no HDMI audio output

Hi Norbert, On Wed, Nov 16, 2016 at 11:38:21AM +0900, Norbert Preining wrote: > I am trying to get HDMI audio output via a Lenovo Dock Ultra in > combination with a Lenovo Thinkpad X260. > > [...] Lenovo Dock Ultra contains a DP-MST Hub to provide all those HDMI/DVI/DP ports. Audio over DP-MST

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi, On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote: > > > Thanks, this answered half of my questions already. ;-) > > :-). > > > > I'll have to go through the patches, et8ek8 driver is probably not > > enough to get useful video. platform/video-bus-switch.c is needed for > > camera

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi, On Fri, Nov 04, 2016 at 01:05:01AM +0200, Sakari Ailus wrote: > On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote: > > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote: > > > > > Thanks, this answered half

Re: latest version of bluetooth for n950?

Hi, On Tue, Oct 11, 2016 at 09:47:04AM +0200, Pavel Machek wrote: > Hi, Sebastian! > > I got some free cycles to play with n900 and bluetooth. There's still > some unrelated config option that breaks even the old vesion of > patches, but I'm ready for more debugging now. > > Could I have the

Re: latest version of bluetooth for n950?

Hi, On Tue, Oct 11, 2016 at 04:51:40PM +0200, Sebastian Reichel wrote: > On Tue, Oct 11, 2016 at 09:47:04AM +0200, Pavel Machek wrote: > > I got some free cycles to play with n900 and bluetooth. There's still > > some unrelated config option that breaks even the old vesion of >

Re: partial bluetooth success on n900 [was Re: bluetooth/uart timeout handling]

Hi Pali & Pavel, On Wed, Dec 14, 2016 at 01:53:23PM +0100, Pavel Machek wrote: > > > [ 220.248596] tty ttyO1: Radio packet sent > > > [ 220.249328] Bluetooth: hci0: Frame reassembly failed (-84) > > > [ 220.272949] tty ttyO1: wakeup received: 1 -> 0 > > > [ 221.283477] tty ttyO1: radio packet

[GIT PULL] power-supply changes for 4.10

Hi Linus, Not much this time around, since I was quite busy this merge window. I still have quite a few unreviewed patches, so expect a bigger pull request for v4.11 (and probably a second one for v4.10 with fixes that I missed so far). Here is the usual output of request-pull, that looks fine to

Re: [PATCH 12/23] drm: omapdrm: plane: update fifo size on atomic update

Hi, On Wed, Dec 14, 2016 at 11:14:32AM +0200, Tomi Valkeinen wrote: > On 14/12/16 11:10, Laurent Pinchart wrote: > > Hi Tomi, > > > > On Wednesday 14 Dec 2016 10:43:18 Tomi Valkeinen wrote: > >> On 13/12/16 19:35, Laurent Pinchart wrote: > >>> On Tues

Re: [PATCH v2 3/3] power: supply: bq24735-charger: allow chargers to share the ac-detect gpio

Hi, On Wed, Dec 14, 2016 at 12:56:45AM +0100, Peter Rosin wrote: > If several parallel bq24735 chargers have their ac-detect gpios wired > together (or if only one of the parallel bq24735 chargers have its > ac-detect pin wired to a gpio, and the others are assumed to react the > same), then all

Re: [PATCH v2 3/3] power: supply: bq24735-charger: allow chargers to share the ac-detect gpio

[of course I forgot to actually add gpio people, let's try again] On Wed, Dec 14, 2016 at 05:59:21PM +0100, Sebastian Reichel wrote: > Hi, > > On Wed, Dec 14, 2016 at 12:56:45AM +0100, Peter Rosin wrote: > > If several parallel bq24735 chargers have their ac-detect gpios wir

Re: partial bluetooth success on n900 [was Re: bluetooth/uart timeout handling]

Hi Tony, On Wed, Dec 14, 2016 at 07:10:56AM -0800, Tony Lindgren wrote: > * Sebastian Reichel <s...@kernel.org> [161214 05:32]: > > Hi Pali & Pavel, > > > > On Wed, Dec 14, 2016 at 01:53:23PM +0100, Pavel Machek wrote: > > > > > [ 220.248596] tty tt

Re: [PATCH 00/16] FSI device driver introduction

Hi. On Tue, Dec 06, 2016 at 06:14:21PM -0600, Chris Bostic wrote: > [...] > > Introduction of the IBM 'Flexible Support Interface' (FSI) bus device > driver. FSI is a high fan out serial bus consisting of a clock and a serial > data line capable of running at speeds up to 166 MHz. > > [...] I

Re: [PATCH] n900 device tree: cleanup

Hi Tony, It looks like this fell through the cracks. Apart from inconsistent patch subject: Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian On Tue, Oct 11, 2016 at 10:12:43AM +0200, Pavel Machek wrote: > Fix GPIO comment to be consistent with rest of file and add com

Re: [PATCH 03/12] power_supply: axp288_charger: Replace the extcon API

Hi Chanwoo, On Tue, Dec 06, 2016 at 09:26:14AM +0900, Chanwoo Choi wrote: > Could you please review and pick the patch3/4 for power-supply driver? Patches look fine. As I expect the merge window to open next week I would rather not queue this for 4.10 and instead do it once 4.10-rc1 has been

Re: [PATCH v2 1/3] power: supply: bq24735-charger: simplify register update to stop charging

Hi, On Wed, Dec 14, 2016 at 12:56:43AM +0100, Peter Rosin wrote: > Providing value bits outside of the mask is pointless. > > Signed-off-by: Peter Rosin > --- > drivers/power/supply/bq24735-charger.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git

Re: [PATCH v2 2/3] power: supply: bq24735-charger: optionally poll the ac-detect gpio

Hi, On Wed, Dec 14, 2016 at 12:56:44AM +0100, Peter Rosin wrote: > If the ac-detect gpio does not support interrupts, provide a fallback > to poll the gpio at a configurable interval. > > Signed-off-by: Peter Rosin > --- > > [...] > > + } else if (charger->status_gpio) { >

Re: wl1251 NVS calibration data format

Hi, On Fri, Dec 16, 2016 at 12:01:48PM +0100, Pali Rohár wrote: > Hi! Do you know format of wl1251 NVS calibration data file? > > I found that there is tool for changing NVS file for wl1271 and newer > chips (so not for wl1251!) at: https://github.com/gxk/ti-utils > > And wl1271 has in NVS

Re: wl1251 NVS calibration data format

Hi, On Sat, Dec 17, 2016 at 12:14:50PM +0100, Pali Rohár wrote: > On Saturday 17 December 2016 10:37:05 Sebastian Reichel wrote: > > On Fri, Dec 16, 2016 at 12:01:48PM +0100, Pali Rohár wrote: > > > Hi! Do you know format of wl1251 NVS calibration data file? &g

Re: [PATCH v3 2/2] dt-bindings: power: add bindings for sbs-charger

Hi, On Thu, Nov 24, 2016 at 01:33:43PM +0100, Nicolas Saenz Julienne wrote: > Adds device tree documentation for SBS charger compilant devices as defined > here: http://sbs-forum.org/specs/sbc110.pdf > > Signed-off-by: Nicolas Saenz Julienne > --- > v2 -> v3: > - add

Re: [PATCH v4] dt-bindings: power: supply: bq24735: reverse the polarity of ac-detect

Hi, On Fri, Dec 16, 2016 at 10:44:00AM +0100, Peter Rosin wrote: > The ACOK pin on the bq24735 is active-high, of course meaning that when > AC is OK the pin is high. However, all Tegra dts files have incorrectly > specified active-high even though the signal is inverted on the Tegra > boards.

Re: [PATCH v3] power: supply: bq24735-charger: optionally poll the ac-detect gpio

Hi, On Thu, Dec 15, 2016 at 10:28:46AM +0100, Peter Rosin wrote: > If the ac-detect gpio does not support interrupts, provide a fallback > to poll the gpio at a configurable interval. > > Signed-off-by: Peter Rosin Thanks for your patch. We are currently in the merge window

Re: [PATCH v2 00/11] add support for VBUS max current and min voltage limits AXP20X and AXP22X PMICs

Hi Quentin, On Fri, Dec 09, 2016 at 12:04:08PM +0100, Quentin Schulz wrote: > The X-Powers AXP209 and AXP20X PMICs are able to set a limit for the > VBUS power supply for both max current and min voltage supplied. This > series of patch adds the possibility to set these limits from sysfs. > >

Re: [PATCH v3 0/2] power: supply: add sbs-charger driver

Hi, On Tue, Dec 13, 2016 at 11:41:01AM +0100, Nicolas Saenz Julienne wrote: > On 24/11/16 13:33, Nicolas Saenz Julienne wrote: > > Hi, > > > > This series adds support for all SBS compatible battery chargers, as defined > > here: http://sbs-forum.org/specs/sbc110.pdf. > > > > The first patch

Re: [PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

Hi, On Fri, Dec 09, 2016 at 04:48:58PM +0900, Milo Kim wrote: > TPS65217 device supports two charger inputs - AC and USB. > Currently, only AC charger is supported. This patch-set adds USB charger > feature. Tested on Beaglebone black. > > Patch 1: Main patch > Patch 2, 3: Clean up for charger

Re: [PATCH] power: supply: axp20x_usb_power: fix 64-bit build warning

Hi Arnd, On Wed, Jan 11, 2017 at 03:51:55PM +0100, Arnd Bergmann wrote: > Casting a pointer to 'int' is not always valid: > > drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe': > drivers/power/supply/axp20x_usb_power.c:297:21: error: cast from pointer to > integer of

Re: [PATCH v5 00/11] power: supply: bq27xxx: implement individual chip revision support

Hi, On Wed, Jan 11, 2017 at 12:44:37PM +1100, Chris Lapa wrote: > This patch series correctly renames the patch subject prefix to > 'power: supply: bq27xxx'. > > It also fixes up the deprecation of the BQ27500 and BQ27510 definitions. > > Otherwise the patch content is the same functionally as

Re: [PATCH 3/4] dt-bindings: power/supply: Update TPS65217 properties

Hi Milo, On Fri, Dec 09, 2016 at 03:28:32PM +0900, Milo Kim wrote: > Add interrupt specifiers for USB and AC charger input. Interrupt numbers > are from the datasheet. > Fix wrong property for compatible string. > > Signed-off-by: Milo Kim > --- >

Re: [PATCH] power: supply: axp20x_usb_power: fix warning on 64bit

Hi Michal, On Tue, Jan 10, 2017 at 06:48:12PM +0100, Michal Suchanek wrote: > Casting of_device_get_match_data return value to int causes warning on 64bit > architectures. > > ../drivers/power/supply/axp20x_usb_power.c: In function > 'axp20x_usb_power_probe': >

Re: [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow for deprecation in future.

Hi, On Wed, Jan 11, 2017 at 09:25:01AM +1100, Chris Lapa wrote: > On 10/1/17 7:58 pm, Pali Rohár wrote: > > On Tuesday 10 January 2017 16:25:29 Chris Lapa wrote: > > > From: Chris Lapa > > > > > > The BQ275XX definition exists only to satisfy backwards compatibility. > > > >

Re: [PATCH v3 00/11] power: supply: bq275xx: implement individual chip revision support

Hi Chris, On Mon, Jan 09, 2017 at 11:47:34AM +1100, Chris Lapa wrote: > This patch series separates out support for each revision chip in > the bq27500, bq27510 and bq27520 family. Each revision has enough > register address changes to justify individual register mappings. > > The series also

Re: [PATCH] power: reset: Add MAX77620 support

Hi Thierry, I have a few comments inline. On Thu, Jan 12, 2017 at 05:15:07PM +0100, Thierry Reding wrote: > The Maxim MAX77620 PMIC has the ability to power off and restart the > system. Add a driver that supports power off (via pm_power_off()) and > restart (via arm_pm_restart() on 32-bit and

Re: [PATCH] power: supply: axp20x_usb_power: fix 64-bit build warning

On Thu, Jan 12, 2017 at 09:32:26AM +0100, Arnd Bergmann wrote: > On Thursday, January 12, 2017 3:58:24 AM CET Sebastian Reichel wrote: > > On Wed, Jan 11, 2017 at 03:51:55PM +0100, Arnd Bergmann wrote: > > > Casting a pointer to 'int' is not always valid: > > >

Re: [PATCH v2 01/11] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future.

Hi, On Fri, Jan 06, 2017 at 11:29:19AM +1100, Chris Lapa wrote: > On 6/1/17 10:59 am, Sebastian Reichel wrote: > > Hi Chris, > > > > On Fri, Dec 23, 2016 at 11:04:57AM +1100, Chris Lapa wrote: > > > From: Chris Lapa <ch...@lapa.com.au> > > > > &

Re: [PATCH v2 01/11] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future.

Hi Chris, On Fri, Dec 23, 2016 at 11:04:57AM +1100, Chris Lapa wrote: > From: Chris Lapa > > The BQ275XX definition exists only to satisfy backwards compatibility. > > tested: yes > > Signed-off-by: Chris Lapa > > [...] > > static bool

Re: [PATCH 2/2] iio: misc: add support for GPIO power switches

Hi Linux, On Wed, Dec 28, 2016 at 01:50:17PM +0100, Linus Walleij wrote: > On Sun, Dec 11, 2016 at 11:21 PM, Bartosz Golaszewski > wrote: > > > Some power-measuring ADCs work together with power load switches which > > allow to power-cycle measured devices. > > > > An

Re: [PATCH] power: fix spelling mistake: supply: "Celcius" -> "Celsius"

Hi Colin, On Wed, Dec 28, 2016 at 09:59:26PM +, Colin King wrote: > From: Colin Ian King > > trivial fix to spelling mistake in comments in the headers > > Signed-off-by: Colin Ian King Thanks for your patch. I have queued it into

Re: [PATCH] power_supply: wm97xx_battery: remove redundant 2nd null check on pdata

Hi Colin, On Thu, Dec 29, 2016 at 03:23:12PM +, Colin King wrote: > From: Colin Ian King > > pdata is being null checked twice, the 2nd check is redundant code > and can be removed. > > Fixes CoverityScan CID 1392340 "Logically dead code" > > Signed-off-by: Colin

Re: [PATCH RESEND] power: gpio_charger: switch to using GPIO descriptors

Hi Linus, On Mon, Dec 26, 2016 at 09:18:55PM +0100, Linus Walleij wrote: > The GPIO charger is using a mix of the legacy GPIO interface > and which is not the modern way to use GPIOs. > > Refactor like this: > > - Use a GPIO descriptor for the GPIO line used to monitor the > charger. > -

Re: [PATCH 1/9] tty: move the non-file related parts of tty_release to new tty_release_struct

Hi, On Fri, Jan 06, 2017 at 10:26:27AM -0600, Rob Herring wrote: > For in-kernel tty users, we need to be able to create and destroy > 'struct tty' that are not associated with a file. The creation side is > fine, but tty_release() needs to be split into the file handle portion > and the struct

Re: [PATCH 7/9] serdev: Introduce new bus for serial attached devices

Hi, On Fri, Jan 06, 2017 at 10:26:33AM -0600, Rob Herring wrote: > [...] > > +static int serdev_device_match(struct device *dev, struct device_driver *drv) > +{ > + return of_driver_match_device(dev, drv); > +} Maybe add a TODO note here for ACPI/platform support? > [...] > > +int

Re: [PATCH 0/9] Serial slave device bus

ve BT working on the HiKey board which has TI BT. > With the serdev bus support, it eliminates the need for the TI userspace > UIM daemon. > > This series and the mentioned drivers can be found here[1]. > > Rob After adding kernel docs in patch 1, the DT binding change and mine and Andy's com

Re: linux-next: build warning after merge of the battery tree

Hi Quentin, On Thu, Jan 05, 2017 at 12:53:42PM +1100, Stephen Rothwell wrote: > After merging the battery tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > drivers/power/supply/axp20x_usb_power.c: In function 'axp20x_usb_power_probe': >

Re: [PATCH v2 11/11] power: supplies: bq275xx: adds device tree binding documentation.

Hi, On Fri, Dec 23, 2016 at 11:05:07AM +1100, Chris Lapa wrote: > From: Chris Lapa > > The bq275xx binding is a standard i2c style binding, however the > deprecated compatible fields and different revisions warrant its own > documentation. Please add the other supported i2c

Re: [PATCH 17/22] power: supply: add battery driver for AXP20X and AXP22X PMICs

Hi, On Thu, Jan 05, 2017 at 02:34:48PM -0300, Ezequiel Garcia wrote: > > +static int axp20x_power_probe(struct platform_device *pdev) > > +{ > > + struct axp20x_dev *axp20x = dev_get_drvdata(pdev->dev.parent); > > + struct axp20x_batt_ps *axp20x_batt; > > + struct

Re: BQ27xxx registers

Hi, On Wed, Dec 21, 2016 at 01:46:17PM +0100, Pali Rohár wrote: > On Wednesday 21 December 2016 03:49:10 Chris Lapa wrote: > > On 20/12/16 10:34 pm, Pali Rohár wrote: > > > On Tuesday 20 December 2016 07:00:41 Chris Lapa wrote: > > >> I can generate a patch to fix this issue, however the bigger >

Re: [PATCH v3 0/7] power: supply: tps65217: Support USB charger feature

Hi, On Sun, Dec 18, 2016 at 11:54:25AM +0900, Milo Kim wrote: > TPS65217 device supports two charger inputs - AC and USB. > Currently, only AC charger is supported. This patch-set > adds USB charger feature. Tested on Beaglebone black. Thanks for your patchset. We are currently in the merge

Re: [PATCH v2 00/12] power: supply: axp288_charger: Various fixes

Hi, On Wed, Dec 21, 2016 at 03:36:45PM +0100, Hans de Goede wrote: > Here is v2 of my axp288_charger series, which fixup the axp288_charger > code to actually work. > > This implements the suggestion by Chanwoo Choi on how we can use the > existing extcon_get_extcon_dev instead of introducing a

Re: [PATCH 0/2] power: supply: bq24735: poll register if no ac-detect gpio

Hi, On Wed, Dec 21, 2016 at 10:29:51PM +0100, Peter Rosin wrote: > My patch [1] "power: supply: bq24735-charger: allow chargers to share the > ac-detect gpio" is perhaps a bit hard to digest. And while I still think > some way of sharing the ac-detect gpio is worthwhile, I thought of another >

Re: [PATCH] mark myself as mainainer for camera on N900

r/supply/bq27xxx_battery_i2c.c F: drivers/power/supply/isp1704_charger.c F: drivers/power/supply/rx51_battery.c TI BQ27XXX POWER SUPPLY DRIVER R: Andrew F. Davis <a...@ti.com> F: include/linux/power/bq27xxx_battery.h F: drivers/power/supply/bq27xxx_battery.c F:

Re: [PATCH v4 0/2] power: supply: add sbs-charger driver

Hi, On Tue, Dec 20, 2016 at 04:31:12PM +0100, Nicolas Saenz Julienne wrote: > This series adds support for all SBS compatible battery chargers, as defined > here: http://sbs-forum.org/specs/sbc110.pdf. > > [...] > > Nicolas Saenz Julienne (2): > power: supply: add sbs-charger driver >

Re: [PATCH 0/3] power: supply: bq24735: handle AC adapter absence

Hi, On Tue, Dec 20, 2016 at 12:32:59PM +0100, Peter Rosin wrote: > There is provision in the driver for handling the case where the > chargers are not responding to i2c requests when the AC adapter > is absent. I think this has been used by some Tegra boards that > leave the charger handling to

Re: [RFC/PATCH] media: Add video bus switch

Hi, On Thu, Dec 22, 2016 at 09:53:17PM +0100, Pavel Machek wrote: > > 1. Settings must be applied before the streaming starts instead of > > at probe time, since the settings may change (based one the selected > > camera). That should be fairly easy to implement by just moving the > > code to the

Re: [RFC/PATCH] media: Add video bus switch

Hi, On Thu, Dec 22, 2016 at 11:42:26PM +0100, Pavel Machek wrote: > On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote: > > Hi Pavel, > > > > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > > > N900 contains front and back camera, with a switch be

Re: [RFC/PATCH] media: Add video bus switch

Hi Pavel, On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > N900 contains front and back camera, with a switch between the > two. This adds support for the swich component. > > Signed-off-by: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Ivaylo Dim

Re: [RESEND PATCH v4 2/9] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs

Hi, On Wed, Mar 22, 2017 at 12:34:45PM +0800, Chen-Yu Tsai wrote: > P.S. I'm thinking about having MFD_AXP20X imply its various sub-drivers. > Not sure if that was the intended usage of the new imply syntax though. I think adding "default MFD_AXP20X" to the sub-drivers is cleaner, as you will

Re: [PATCHv2 09/11] Bluetooth: add nokia driver

Hi, On Thu, Mar 23, 2017 at 08:50:42AM +0100, Frédéric Danis wrote: > Le 21/03/2017 à 23:32, Sebastian Reichel a écrit : > > This adds a driver for the Nokia H4+ protocol, which is used > > at least on the Nokia N9, N900 & N950. > > > > Signed-off-by: Seb

[PATCHv3 1/2] mfd: cpcap: Add missing include dependencies

This fixes compilation for files, that try to include the cpcap header in alphabetically sorted #include lists. Acked-by: Pavel Machek <pa...@ucw.cz> Acked-by: Tony Lindgren <t...@atomide.com> Signed-off-by: Sebastian Reichel <s...@kernel.org> --- Changes since PATCHv2: - Add

[PATCHv4] mfd: cpcap: implement irq sense helper

CPCAP can sense if IRQ is currently set or not. This functionality is required for a few subdevices, such as the power button and usb phy modules. Acked-by: Tony Lindgren <t...@atomide.com> Signed-off-by: Sebastian Reichel <s...@kernel.org> --- Hi Lee, I hope this is fine with

[PATCHv3 2/2] leds: cpcap: new driver

LED controllers. I did not add support for them, since I cannot verify that they work with my modifications. Acked-by: Pavel Machek <pa...@ucw.cz> Signed-off-by: Sebastian Reichel <s...@kernel.org> --- Changes since PATCHv1: - binding: reference common led binding for label - drop

Re: [PATCHv4] mfd: cpcap: implement irq sense helper

Hi Lee, On Tue, Mar 28, 2017 at 11:27:16AM +0100, Lee Jones wrote: > > +int cpcap_sense_virq(struct regmap *regmap, int virq) > > +{ > > + struct regmap_irq_chip_data *d = irq_get_chip_data(virq); > > + int base = regmap_irq_chip_get_base(d); > > What base is this? This function takes an

[PATCHv3 05/10] Bluetooth: hci_uart: add support for word alignment

This will be used by Nokia's H4+ protocol, which uses 2-byte aligned packets. Acked-by: Pavel Machek <pa...@ucw.cz> Signed-off-by: Sebastian Reichel <s...@kernel.org> --- Changes since PATCHv1: * use u8 instead of uint8_t --- drivers/bluetooth/hci_h4.c| 17 ++

[PATCHv3 07/10] Bluetooth: hci_serdev: do not open device in hci open

The device driver may need to communicate with the UART device while the Bluetooth device is closed (e.g. due to interrupts). Acked-by: Pavel Machek <pa...@ucw.cz> Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/bluetooth/hci_serdev.c | 12 +++- 1 fil

<    9   10   11   12   13   14   15   16   17   18   >