Re: [PATCH v3 0/5] power/reset: at91: cleanups and slow clock

Hi, On Tue, Aug 11, 2015 at 11:12:45AM +0200, Alexandre Belloni wrote: > As discussed this series is now removing non DT initialization, allowing to > compile the drivers as modules and finally adding slow clock support to the > drivers. > > [...] > > power/reset: at91-reset: remove useless

Re: [PATCH v2] power_supply: max8998: Use devm_power_supply_register

Hi, On Thu, Aug 13, 2015 at 10:24:41AM +0530, Vaishali Thakkar wrote: > Use managed resource function devm_power_supply_register instead > of power_supply_register to simplify the error path by allowing > unregister to happen automatically on error. To be compatible with > the change, replace

Re: [PATCH] power: max17042_battery: Convert to using managed resources

Hi, On Thu, Sep 17, 2015 at 06:27:52PM +0530, Vaishali Thakkar wrote: > Use managed resource functions devm_request_threaded_irq and > devm_power_supply_register to simplify error handling. > > Also, remove max17042_remove as it is now redundant. Thanks, queued for 4.4. -- Sebastian

Re: [PATCH] max8903_charger: Convert to using managed resources

Hi, On Thu, Sep 17, 2015 at 06:55:00PM +0530, Vaishali Thakkar wrote: > Use managed resource functions devm_request_threaded_irq and > devm_power_supply_register to simplify error handling. > > To be compatible with the change, various gotos are replaced > with direct returns and unneeded labels

Re: [PATCHv2 3/4] power: Add Qualcomm SMBB driver

Hi, On Tue, Sep 15, 2015 at 06:33:00AM -0700, Bjorn Andersson wrote: > On Tue 15 Sep 05:43 PDT 2015, Sebastian Reichel wrote: > > > Hi, > > > > On Thu, Jul 30, 2015 at 10:53:56AM -0700, Bjorn Andersson wrote: > > > From: Courtney Cavin <courtney.ca

Re: [PATCH v2] power: Remove unnecessary MODULE_ALIAS() for I2C drivers

Hi, On Mon, Aug 31, 2015 at 10:52:00AM +0200, Javier Martinez Canillas wrote: > These drivers already have an I2C device id table that is used to create > module aliases and the used MODULE_ALIAS() was either already in the I2C > table so it was redundant or wasn't a valid I2C id so it was never

Re: [PATCH 1/2] power:lp8727_charger: use the private data instead of updating I2C device platform data

Hi, On Tue, Aug 25, 2015 at 03:07:07PM +0900, Milo Kim wrote: > Currently, lp8727 charger driver parses the DT and copies values into the > 'cl->dev.platform_data' if 'of_node' exists. > This may have architectural issue. Platform data is configurable through > the DT or I2C board info inside the

Re: [PATCH] 88pm860x_battery: Convert to using managed resources

Hi, On Thu, Sep 17, 2015 at 06:03:40PM +0530, Vaishali Thakkar wrote: > Use managed resource functions devm_request_threaded_irq and > devm_power_supply_register to simplify error handling. > > To be compatible with the change, various gotos are replaced > with direct returns and unneeded labels

Re: [PATCH 3/3] power: reset: at91-shdwc: add new shutdown controller driver

Hi, On Thu, Sep 10, 2015 at 12:39:18PM +0200, Nicolas Ferre wrote: > Sama5d2 SoC has a completely new shutdown controller with new > features and register layout. It thus makes sense to add a new > driver for this new peripheral. > > This driver is Device Tree only and handles events from the >

Re: [PATCH] tps65090-charger: Fix module autoload for OF platform driver

Hi, On Fri, Sep 18, 2015 at 06:54:07PM +0200, Luis de Bethencourt wrote: > This platform driver has a OF device ID table but the OF module > alias information is not created so module autoloading won't work. Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH v4 1/7] power: bq27x00_battery: Remove unneeded i2c MODULE_ALIAS

Hi, On Mon, Sep 14, 2015 at 04:26:07PM -0500, Andrew F. Davis wrote: > The MODULE_DEVICE_TABLE macro automatically adds all needed > i2c MODULE_ALIASes so remove the extra MODULE_ALIAS. Thanks, queued. -- Sebastian signature.asc Description: Digital signature

Re: [PATCH] power: charger-manager: comment spelling fixes

Hi, On Sun, Sep 20, 2015 at 12:13:37AM +0200, Marcel Ziswiler wrote: > By accident I stumbled over a few misspelled words in the > charger-manager header file which this patch fixes. Namely: > - Extcon rather than Exton > - constraint rather than constratint > - existence rather than existance >

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi, On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > On 11.09.2015 01:42, Andrew F. Davis wrote: > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > +- ti,enable-user-write: boolean, if present driver will allow the > > user space > > +to control the

Re: [PATCH v5 0/6] Add support for additional bq27xxx devices

[updated receiver list] Hi, On Wed, Sep 23, 2015 at 01:41:01PM -0500, Andrew F. Davis wrote: > On 09/23/2015 11:42 AM, Sebastian Reichel wrote: > >On Tue, Sep 22, 2015 at 02:35:05PM -0500, Andrew F. Davis wrote: > >>This series adds support for several additional bq27xxx dev

Re: [PATCH v2] power: Fix unmet dependency on POWER_SUPPLY by POWER_RESET by uncoupling them

Hi, On Mon, Dec 07, 2015 at 12:45:12PM +0900, Krzysztof Kozlowski wrote: > Currently the reset/power off handlers (POWER_RESET) and Adaptive Voltage > Scaling class (POWER_AVS) are not built when POWER_SUPPLY is disabled. > The POWER_RESET is also not visible in drivers main section of config. >

Re: [PATCH 0/2] power: Add support for TI BQ24261 charger

Hi Ramakrishna, On Thu, Oct 29, 2015 at 10:07:03PM +0530, Ramakrishna Pallala wrote: > This patch series adds the support for TI BQ24261 charger driver. > > TI BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging

Re: [PATCH] power: qcom_smbb: Add otg regulator for control of vbus

Hi Tim, On Thu, Oct 22, 2015 at 02:12:17PM -0700, Tim Bird wrote: > Add a regulator to control the OTG chargepath switch. The OTG > switch gets its power from pm8941_5vs1, and that should be expressed > as an usb_otg_in-supply property in the DT node for the charger driver. > The regulator name

Re: [PATCH v6 1/4] gadget: Introduce the usb charger framework

Hi, On Mon, Nov 16, 2015 at 02:33:31PM +0800, Baolin Wang wrote: > +static ssize_t cur_limit_show(struct device *dev, > + struct device_attribute *attr, > + char *buf) > +{ > + struct usb_charger *uchger = dev_to_uchger(dev); > + > +

Re: [PATCH V2] goldfish: add goldfish match node for dt driver probe

Hi, On Fri, Nov 06, 2015 at 03:12:40PM +0800, yalin wang wrote: > qemu use device tree to bootup linux kernel, > we need add device node match table to plaftorm driver, > so that can probe the goldfish driver correctly. > test by this qemu: > git clone

Re: [PATCH v2 0/3] Fixes for twl4030 charger

Hi Nikolaus, On Mon, Nov 02, 2015 at 12:27:33PM +0100, H. Nikolaus Schaller wrote: > Changes V2: > * worked in comments by Nishanth Menon > * added another patch which solves a probing/boot stall problem (irq > allocation vs. -EPROBE_DEFER) > > V1: > 4.3-rc1 introduced a new

Re: [PATCH] drivers: power: set IRQF_ONESHOT if no primary handler is specified

Hi, On Thu, Nov 19, 2015 at 12:42:59PM +0530, Saurabh Sengar wrote: > If no primary handler is specified for threaded_irq then a > default one is assigned which always returns IRQ_WAKE_THREAD. > This handler requires the IRQF_ONESHOT, because the source of > interrupt is not disabled. Thanks,

Re: [PATCH 4/4] power/reset: at91-reset: add missing of_node_put

Hi, On Wed, Nov 18, 2015 at 11:04:14PM +0100, Julia Lawall wrote: > for_each_matching_node performs an of_node_get on each iteration, so > a break out of the loop requires an of_node_put. > > A simplified version of the semantic patch that fixes this problem is as > follows

Re: [PATCH] power: bq27xxx_battery: Reorganize I2C into a module

Hi Andrew, On Mon, Nov 23, 2015 at 10:53:51AM -0600, Andrew F. Davis wrote: > Separate out I2C functionality into a module. This fixes several small > issues and simplifies the driver initialization. Thanks, queued. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] ds2782_battery: constify ds278x_battery_ops structure

Hi, On Fri, Nov 13, 2015 at 07:41:34PM +0100, Julia Lawall wrote: > The ds278x_battery_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Thanks, queued. -- Sebastian signature.asc

Re: [PATCH 1/2] power: Fix unmet dependency on POWER_SUPPLY by POWER_RESET by uncoupling them

Hi, On Wed, Dec 02, 2015 at 02:59:06PM +0900, Krzysztof Kozlowski wrote: > Actually reset/power off handlers do not really depend on power supply. > Move the power reset out of power supply block so it will appear in main > drivers section. This fixes following build warning (encountered on ARM >

Re: [PATCH v2 1/3] dt-binding: power: Add otg regulator binding

Hi, On Wed, Dec 09, 2015 at 09:42:09AM -0800, Tim Bird wrote: > Or maybe our power maintainers will chime in with some wisdom. I > can't be the first person to be adding a charge pathway switch to > mainline, so I'm open to doing it the "right way". :-) I don't think there is a standard way for

Re: Build regressions/improvements in v4.4-rc5

Hi, On Mon, Dec 14, 2015 at 10:56:17AM +0100, Geert Uytterhoeven wrote: > On Mon, Dec 14, 2015 at 10:54 AM, Geert Uytterhoeven > wrote: > > JFYI, when comparing v4.4-rc5[1] to v4.4-rc4[3], the summaries are: > > - build errors: +8/-7 > > + error: bq27xxx_battery.c:

Re: [PATCH linux-next 1/2] power: Add brcm,bcm6358-power-controller device tree binding

Hi, On Wed, Dec 09, 2015 at 10:29:35PM +, Simon Arlott wrote: > The BCM6358 contains power domains controlled with a register. Power > domains are indexed by bits in the register. Power domain bits can be > interleaved with other status bits and clocks in the same register. > > Newer SoCs

Re: [PATCH v4 1/3] dt-binding: power: Add otg regulator binding

Hi, On Tue, Dec 15, 2015 at 11:52:10AM -0800, Tim Bird wrote: > Add a binding for the regulator which controls the OTG chargepath switch. > The OTG switch gets its power from pm8941_5vs1, and that should be > expressed as a usb_otg_in-supply property in the DT node for the > charger driver. The

Re: [PATCH v3 2/4] ARM: bcm2835: add rpi power domain driver

Hi, On Tue, Dec 15, 2015 at 04:53:31PM -0800, Eric Anholt wrote: > >>> What motivated the location of this power domain driver in > >>> arch/arm/mach-bcm? Should not we have this in drivers/power/ or > >>> somewhere in drivers/ at the very least? > >> > >> ls stronly suggests that power contains

Re: [PATCH] MAINTAINERS: Add myself as a reviewer for the bq27xxx driver.

include/linux/power/bq27xxx_battery.h F: include/linux/power/isp1704_charger.h F: drivers/power/bq2415x_charger.c F: drivers/power/bq27xxx_battery.c F: drivers/power/isp1704_charger.c F: drivers/power/rx51_battery.c +TI BQ27XXX POWER SUPPLY DRIVER +R: Andrew F. Davis &

Re: [PATCH 0/2] two fixes for new bq27000/10 and bq27500 driver

Hi Andrew, On Thu, Dec 17, 2015 at 11:12:52AM +0100, H. Nikolaus Schaller wrote: > H. Nikolaus Schaller (2): > power:bq27xxx: fix reading for bq27000 and bq27010 > power:bq27xxx: fix register numbers of bq27500 > > drivers/power/bq27xxx_battery.c | 18 -- > 1 file changed,

Re: [PATCH] HSI: Remove struct hsi_client private fields from kernel-doc

Hi, On Thu, Oct 08, 2015 at 09:11:48AM +0200, Javier Martinez Canillas wrote: > The kernel-doc how to says that structure fields that are inside a > "private:" area shouldn't be listed in the generated documentation > but the private fields for struct hsi_client private are listed. > > This also

Re: [PATCH v2 1/6] power: Introduce Broadcom kona reset driver

f-by: Chris Brand <chris.br...@broadcom.com> > Sebastian, Dmitry, I know we are in the merge window, let me know if you > would want me to take this patch and the 5 others in the next arm-soc > pull request, or if you prefer to take this one in your own tree. Feel free to queue it via

Re: [RESEND v2] power: reset: keystone: Enable COMPILE_TEST

Hi, On Mon, May 23, 2016 at 08:12:31AM +0200, Krzysztof Kozlowski wrote: > On Fri, Apr 15, 2016 at 4:27 PM, Sebastian Reichel <s...@kernel.org> wrote: > > Hi, > > > > On Wed, Mar 30, 2016 at 09:49:48AM +0900, Krzysztof Kozlowski wrote: > >> Enable the COMPIL

Re: [PATCH] ARM: OMAP2: Enable Errata 430973 for OMAP3

Hi, On Thu, Jun 09, 2016 at 12:15:13AM -0700, Tony Lindgren wrote: > * Nishanth Menon [160519 16:23]: > > Enable Erratum 430973 similar to commit 5c86c5339c56 ("ARM: > > omap2plus_defconfig: Enable ARM erratum 430973 for omap3") - Since > > multiple defconfigs can exist from various

Re: [PATCH v2 1/6] power: Introduce Broadcom kona reset driver

Hi, On Mon, Jun 06, 2016 at 09:42:03AM -0700, Chris Brand wrote: > On Thu, Jun 2, 2016 at 7:38 PM, Sebastian Reichel <s...@kernel.org> wrote: > > Feel free to queue it via arm-soc with > > > > Acked-By: Sebastian Reichel <s...@kernel.org> > > >

Re: [PATCH v2 1/6] power: Introduce Broadcom kona reset driver

Hi, On Tue, Jun 07, 2016 at 12:40:41PM -0700, Chris Brand wrote: > On Mon, Jun 6, 2016 at 6:50 PM, Sebastian Reichel <s...@kernel.org> wrote: > > Hi, > > > > On Mon, Jun 06, 2016 at 09:42:03AM -0700, Chris Brand wrote: > >> On Thu, Jun 2, 2016 at 7:38 PM, Sebas

Re: [PATCH v3] power_supply: power_supply_read_temp only if use_cnt > 0

Hi, On Thu, Jun 09, 2016 at 11:31:37AM -0400, Rhyland Klein wrote: > On 6/9/2016 6:05 AM, Krzysztof Kozlowski wrote: > > On 06/08/2016 05:26 PM, Rhyland Klein wrote: > >> On 6/8/2016 2:35 AM, Krzysztof Kozlowski wrote: > >>> On 06/07/2016 10:26 PM, Rhyland Klein wrote: > Change

Re: [PATCH 3/3] power_supply: bq27xxx_battery: Group register mappings into one table

Hi, On Tue, May 31, 2016 at 01:45:00PM -0500, Andrew F. Davis wrote: > Currently for each device with a unique register map we have a named > array that we then merge into a multidimensional array. Skip this > middle step and apply the register arrays directly to the multi-array. I applied the

Re: [PATCH v3 1/2] power: axp288_charger: Replace deprecatd API of extcon

; Signed-off-by: Chanwoo Choi <cw00.c...@samsung.com> > --- > drivers/power/axp288_charger.c | 77 > +++++++++- > 1 file changed, 53 insertions(+), 24 deletions(-) Acked-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] power_supply: power_supply_read_temp only if use_cnt > 0

Hi Rhyland, Thanks for the patch. On Fri, Jun 03, 2016 at 04:30:50PM -0400, Rhyland Klein wrote: > Add check to power_supply_read_temp() to only use the power_supply > get_property() callback if the use_cnt is > 0. The use_cnt will > be incremented at the end of __power_supply_register, so this

Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

Hi Andrew, On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote: > If the HSI core is built as a module hsi_boardinfo may still > be built-in as its Kconfig type is bool, which can cause build > issues. Fix this by building this code into the HSI core when > enabled. > > Reported-by:

Re: [PATCH] hsi: use kmemdup

Hi, On Thu, May 19, 2016 at 04:39:28PM +0530, Muhammad Falak R Wani wrote: > Use kmemdup when some other buffer is immediately copied into allocated > region. It replaces call to allocation followed by memcpy, by a single > call to kmemdup. Thanks, queued for 4.8:

Re: [PATCH] HSI: cmt_speech: use vma_pages().

Hi, On Sat, May 21, 2016 at 06:49:21PM +0530, Muhammad Falak R Wani wrote: > Replace explicit computation of vma page count by a call to > vma_pages() > > Signed-off-by: Muhammad Falak R Wani > --- > drivers/hsi/clients/cmt_speech.c | 2 +- > 1 file changed, 1

Re: [PATCH v2] power_supply: fix return value of get_property

Hi, On Tue, Jun 21, 2016 at 02:08:05PM -0400, Rhyland Klein wrote: > On 6/16/2016 11:40 AM, Rhyland Klein wrote: > > On 6/16/2016 4:43 AM, Krzysztof Kozlowski wrote: > >> On 06/16/2016 12:13 AM, Rhyland Klein wrote: > >>> power_supply_get_property() should ideally return -EAGAIN if it is > >>>

Re: [PATCH v4] power_supply: power_supply_read_temp only if use_cnt > 0

Hi Rhyland, On Tue, Jun 21, 2016 at 02:06:55PM -0400, Rhyland Klein wrote: > Sebastian, might this be accepted soon? We can't enable the bq27xxx > driver for Tegra210 Smaug without running into the crash this prevents. Yes, I have already queued this in my fixes branch some days ago, but did not

[PATCH 0/2] Move power supply subsystem to drivers/power/supply

for the power supply subsystem. -- Sebastian Sebastian Reichel (2): power: move power supply drivers to power/supply power/supply: unify DT documentation .../{power_supply => power/reset}/axxia-reset.txt | 0 .../reset}/imx-snvs-poweroff.txt | 0 .../{power_sup

[PATCH 2/2] power/supply: unify DT documentation

for the drivers itself). Signed-off-by: Sebastian Reichel <s...@kernel.org> --- .../devicetree/bindings/{power_supply => power/reset}/axxia-reset.txt | 0 .../bindings/{power_supply => power/reset}/imx-snvs-poweroff.txt | 0 .../devicetree/bindings/{power_supply => p

[PATCH 1/2] power: move power supply drivers to power/supply

This moves all power supply drivers from drivers/power/ to drivers/power/supply/. The intention is a cleaner source tree, since drivers/power/ also contains frameworks unrelated to power supply, like adaptive voltage scaling. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- Documen

Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

Hi, On Sat, Jun 18, 2016 at 12:40:38PM +0200, Sebastian Reichel wrote: > On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote: > > The current tpa6130a2 driver supports only a single instance. > > This patch series add support for multiple instances by removing > >

Re: [PATCH 3/4] ASoC: tpa6130a2: Use snd soc volsw functions

co.uk> [On N900] Tested-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 2/4] ASoC: tap6130a2: Use regmap

co.uk> [On N900] Tested-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 1/4] ASoC: tpa6130a2: Register component

> return -EINVAL; > } > - > - /* TODO: tpa6130a2a driver supports only a single instance, so > - * this driver ignores the headphone-amplifier node for now. > - * It's already mandatory in the DT binding to be future proof. > - */ > + rx51_aux_dev[1].codec_name = NULL; > + rx51_aux_dev[1].codec_of_node = dai_node; > + rx51_codec_conf[1].dev_name = NULL; > + rx51_codec_conf[1].of_node = dai_node; > } > > pdata = devm_kzalloc(>dev, sizeof(*pdata), GFP_KERNEL); If you fix the double prefix the patch is Tested-By: Sebastian Reichel <s...@kernel.org> Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

Hi, On Sat, Jun 18, 2016 at 12:26:31AM -0300, Helen Koike wrote: > Add DAPM support and updated rx51 accordingly. > As a consequence: > - the exported function tpa6130a2_stereo_enable is not needed anymore > - the mutex is dealt in the DAPM > - the power state is tracked by the DAPM This breaks

Re: [PATCH 4/4] ASoC: tpa6130a2: Add DAPM support

Hi, On Sun, Jun 19, 2016 at 11:39:15AM +0200, Lars-Peter Clausen wrote: > On 06/19/2016 01:21 AM, Sebastian Reichel wrote: > > On Sat, Jun 18, 2016 at 12:26:31AM -0300, Helen Koike wrote: > >> Add DAPM support and updated rx51 accordingly. > >> As a consequence: &

Re: [PATCH v2 3/3] power_supply: bq27xxx_battery: Group register mappings into one table

Hi, On Fri, Jun 17, 2016 at 05:02:35PM -0500, Andrew F. Davis wrote: > Currently for each device with a unique register map we have a named > array that we then merge into a multidimensional array. Skip this > middle step and apply the register arrays directly to the multi-array. Thanks, queued.

Re: [PATCH 0/4] ASoC: tpa6130a2: Add support for multiple instances

Hi, On Sat, Jun 18, 2016 at 12:26:27AM -0300, Helen Koike wrote: > The current tpa6130a2 driver supports only a single instance. > This patch series add support for multiple instances by removing > the global variable that holds the instance. This is performed by > using the component API,

Re: [PATCH v2 5/5] ASoC: tpa6130a2: Remove goto err_gpio

Hi, On Mon, Jun 20, 2016 at 02:12:33PM -0300, Helen Koike wrote: > Replace goto err_gpio by return ret > > Signed-off-by: Helen Koike <helen.ko...@collabora.co.uk> Tested-By: Sebastian Reichel <s...@kernel.org> Reviewed-By: Sebastian Reichel <s...@kernel.org> -

Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

Hi Helen, On Mon, Jun 20, 2016 at 04:06:10PM -0300, Helen Koike wrote: > I added these changes above and kept your tested-by and reviewed-by, could > you please confirm that I can keep them? As I changed more things then you > suggested. The changes look fine to me, the new patchset works on

Re: [PATCH v2 3/5] ASoC: tpa6130a2: Use snd soc volsw functions

labora.co.uk> > [On N900] > Tested-By: Sebastian Reichel <s...@kernel.org> Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 2/5] ASoC: tap6130a2: Use regmap

uk> > [On N900] > Tested-By: Sebastian Reichel <s...@kernel.org> Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v8 2/4] power: reset: add reboot mode driver

Hi, On Mon, Apr 25, 2016 at 02:55:36PM +0800, Andy Yan wrote: > This driver parses the reboot commands like "reboot bootloader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode in some place like special register or

[RFC 03/19] HSI: ssi_protocol: avoid ssi_waketest call with held spinlock

This avoids calling ssi_waketest(), while a spinlock is being hold, since ssi_waketest may sleep once irq_safe runtime pm is disabled. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/clients/ssi_protocol.c | 41 +++--- 1 file chang

[RFC 04/19] HSI: ssi_protocol: replace spin_lock with spin_lock_bh

To avoid setting irq_safe runtime pm flag in omap-ssi, multiple calls will be moved to process context. This also affects ssi-protocol, so use the safer spin_lock_bh instead of a simple spin_lock. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/clients/ssi_protocol.

[RFC 00/19] Runtime PM fixes for omap-ssi

nfig phonet0 up" will result in blocking ssi module until modem setup has finished (data communication via phonet0 device), since it enables ssi wakelines. [0] https://git.kernel.org/cgit/linux/kernel/git/sre/linux-hsi.git/log/?h=runtime-pm-fixes -- Sebastian Sebastian Reichel (19):

[RFC 02/19] HSI: omap_ssi: do not reset module

module reset and power management rule setup is already done by hwmod. Remove this cruft, which predates hwmod. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi.h | 2 -- drivers/hsi/controllers/omap_ssi_core.c | 19 +-- 2

[RFC 05/19] HSI: ssi_protocol: fix ssip_xmit invocation

ssip_xmit should be called from process context, since it calls hsi_async_write. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/clients/ssi_protocol.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/hsi/clients/ssi_protoco

[RFC 06/19] HSI: omap_ssi: convert cawake irq handler to thread

Convert cawake interrupt handler from tasklet to threaded interrupt handler in preparation of blocking runtime_pm calls. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi.h | 2 -- drivers/hsi/controllers/omap_ssi_core.c | 4 ++-- drive

[RFC 01/19] HSI: omap_ssi_port: remove useless newline

Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c index 6b8f7739768a..38388442e310

[RFC 16/19] HSI: omap_ssi_port: ensure clocks are kept enabled during transfer

ensure, that clocks remain enabled, when a transfer is started. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_

[RFC 09/19] HSI: omap_ssi_port: prepare start_tx/stop_tx for blocking pm_runtime calls

ssi_start_tx and ssi_stop_tx may be called from atomic context. Once pm_runtime_irq_safe() is removed for omap-ssi, this will fail, due to blocking pm_runtime_*_sync() calls. This fixes ssi_stop_tx by using non-sync API and ssi_start_tx by using a worker thread. Signed-off-by: Sebastian Reichel

[RFC 17/19] HSI: omap_ssi: call msg->complete() from process context

msg->complete() should always be called from process context once irq_safe runtime pm flag is no longer set for omap-ssi. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi.h | 4 drivers/hsi/controllers/omap_ssi_core.c | 4 +++- dr

[RFC 18/19] HSI: omap_ssi_port: use rpm autosuspend API

Instead of immediately sending the SSI module to sleep, wait some time in case of new incoming or outgoing traffic. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 68 + 1 file changed, 44 insertions(

[RFC 19/19] HSI: omap_ssi: drop pm_runtime_irq_safe

pm_runtime_irq_safe increases the parents runtime usage counter effectively keeping the OMAP SoC from idling. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_core.c | 1 - drivers/hsi/controllers/omap_ssi_port.c | 2 -- 2 files changed, 3 del

[RFC 12/19] HSI: omap_ssi_port: switch to threaded pio irq

Move pio interrupt handler from tasklet into thread to allow runtime_pm_get_sync calls without irq_safe being set. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi.h | 2 -- drivers/hsi/controllers/omap_ssi_port.

[RFC 07/19] HSI: omap_ssi_port: replace wkin_cken with atomic bitmap operations

This simplifies the code and avoids holding a spin_lock when runtime pm calls are made. Once the irq_safe flag is removed for omap_ssi's runtime pm, pm_runtime_get/put_sync can sleep, which is a no-go while holding a spin_lock. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drive

[RFC 15/19] HSI: omap_ssi_port: replace pm_runtime_put_sync with non-sync variant

There is no need to wait for hardware to really reach idle states, so just release runtime PM asynchronously. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

[RFC 08/19] HSI: core: switch port event notifier from atomic to blocking

port events should be sent from process context after irq_safe runtime pm flag is removed in omap-ssi. --- drivers/hsi/hsi_core.c | 8 include/linux/hsi/hsi.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hsi/hsi_core.c b/drivers/hsi/hsi_core.c index

[RFC 14/19] HSI: omap_ssi_port: avoid calling runtime_pm_*_sync inside spinlock

runtime_pm_*_sync can block when irq_safe flag is removed from omap-ssi driver, so it may not be called while a spinlock is held. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[RFC 11/19] HSI: omap_ssi_core: remove pm_runtime_get_sync call from tasklet

We may not call pm_runtime_get_sync() from tasklet, since it can block once pm_runtime_irq_safe is removed for omap-ssi. Since irq can should only be created for a running device, we assume, that the device is already running and use non- synchronous API instead. Signed-off-by: Sebastian Reichel

[RFC 13/19] HSI: omap_ssi_port: avoid pm_runtime_get_sync in ssi_start_dma and ssi_start_pio

These functions may be called from atomic context, so avoid synchronous runtime pm calls. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_port.c | 30 -- 1 file changed, 24 insertions(+), 6 deletions(-) diff --git a/drive

[RFC 10/19] HSI: omap_ssi_core: use pm_runtime_put instead of pm_runtime_put_sync

There is no need to disable the device synchronously, so don't do it. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi_core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/d

Re: [RFC 00/19] Runtime PM fixes for omap-ssi

Hi, On Sat, Jun 18, 2016 at 08:54:38PM +0200, Pavel Machek wrote: > > This series fixes runtime PM for omap-ssi, so that > > the OMAP SoC can idle correctly. After applying the > > series, the SSI module correctly goes into idle if > > phonet0 interface is not configured or if it's > > used by

Re: [PATCH 02/23] ARM: dts: n950: add display support

Hi Tony, On Tue, Jun 21, 2016 at 04:01:03AM -0700, Tony Lindgren wrote: > * Tony Lindgren <t...@atomide.com> [160412 13:53]: > > * Sebastian Reichel <s...@kernel.org> [160324 17:16]: > > > On Thu, Mar 24, 2016 at 05:11:15PM +0200, Jani Nikula wrote: > > > &

[PATCH] ARM: OMAP3: hwmod data: Add sysc information for DSI

Add missing sysconfig/sysstatus information to OMAP3 hwmod. The information has been checked against OMAP34xx and OMAP36xx TRM. Without this change DSI block is not reset during boot, which is required for working Nokia N950 display. Signed-off-by: Sebastian Reichel <s...@kernel.org>

Re: [RFC 00/19] Runtime PM fixes for omap-ssi

Hi, On Sat, Jun 18, 2016 at 06:26:50PM +0200, Sebastian Reichel wrote: > This series fixes runtime PM for omap-ssi, so that > the OMAP SoC can idle correctly. After applying the > series, the SSI module correctly goes into idle if > phonet0 interface is not configured or if it's >

[GIT PULL] power supply changes for 4.7-rc

Hi Linus, The following changes since commit 1a695a905c18548062509178b98bc91e67510864: Linux 4.7-rc1 (2016-05-29 09:29:24 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git tags/for-v4.7-rc for you to fetch changes up

Re: [PATCH 4/5] HSI: ssi-protocol: Use handshake logic from n950

Hi, On Sun, Jan 17, 2016 at 04:49:08PM +0100, Sebastian Reichel wrote: > When using the ssi-protocol driver with the Nokia N950, the > following error is thrown during modem powered up sequence. > > [13852.274993] port0: SSI error: 0x01 > [13852.279205] ssi-protocol ssi-pro

Re: [PATCH 3/5] HSI: nokia-modem: add n950 and n9 support

Hi, On Sun, Jan 17, 2016 at 04:49:07PM +0100, Sebastian Reichel wrote: > The Nokia N950 and Nokia N9 also have a SSI connected > modem, which use the same protocols as the Nokia N900, > but with slightly other GPIO setup and increased link > speed (96000 kbps instead of 55000 kbps)

Re: [PATCH 0/5] Nokia N950 modem support

Hi, On Sun, Jan 17, 2016 at 04:49:04PM +0100, Sebastian Reichel wrote: > This patchset adds support for the N950 modem. > > [...] All of the patches are more or less mergable independent of each other, so I suggest the following merging scheme: > Sebastian Reichel (5): > ARM

Re: [PATCH] ARM: dts: omap3-n900: Allow gpio keys to be disabled

Hi, On Sun, Jan 10, 2016 at 07:46:30PM +0200, Ivaylo Dimitrov wrote: > Add linux,can-disable; to all gpios exported from gpio-keys driver, so > userspace can disable them > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov...@gmail.com> Acked-By: Sebastian Reichel <s...@kern

Re: [PATCH] ARM: dts: omap3: Include missing bandgap data for ti-soc-thermal driver

Hi, On Wed, Jan 27, 2016 at 08:09:46AM -0800, Tony Lindgren wrote: > * Pali Rohár [160127 02:05]: > > On Thursday 21 January 2016 09:15:01 Tony Lindgren wrote: > > > * Pali Rohár [160121 01:48]: > > > > On Saturday 26 December 2015 00:32:25 Pali Rohár

Re: [PATCH 2/5] HSI: nokia-modem: kernel based PM

Hi, On Sun, Jan 31, 2016 at 06:29:48PM +0100, Pavel Machek wrote: > > So far power management had to be done in uerspace using exported > > "userspace" Right, thanks. > > This patch adds kernel based power management, which will bind the > > modem's power state to the state of the phonet

Re: [PATCH 3/5] HSI: ssi-protocol: export modem info via sysfs

Hi Pavel, On Sun, Jan 31, 2016 at 06:36:05PM +0100, Pavel Machek wrote: > On Sun 2016-01-31 02:19:45, Sebastian Reichel wrote: > > Currently userspace knows about the rapuyama version by > > checking, which gpios have been exported. This does no > > longer work with kernel b

[PATCH 3/5] HSI: ssi-protocol: export modem info via sysfs

if kernel based PM is used. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/clients/nokia-modem.c | 10 -- drivers/hsi/clients/ssi_protocol.c | 33 - include/linux/hsi/ssi_protocol.h | 11 +++ 3 files changed, 47 insertions

[PATCH 1/5] HSI: nokia-modem: simplify kernel access to gpios

effect the code now checks, that all required gpios are provided. Signed-off-by: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/clients/nokia-modem.c | 115 -- 1 file changed, 85 insertions(+), 30 deletions(-) diff --git a/drivers/hsi/clients

[PATCH 0/2] omap-ssi: clk change support

Hi, During diffing the n950 with the mainline kernel I noticed, that the main difference is additional DVFS support. These patches import those differences (forward-ported to pinctrl & common clock framework) to the mainline kernel. -- Sebastian Sebastian Reichel (2): ARM: dts: OMAP3-N95

[PATCH 1/2] ARM: dts: OMAP3-N950-N9: Add ssi idle pinctrl state

This adds an idle pinctrl state, which will be used by the driver to avoid incoming data during clock rate changes or data flushing. Signed-off-By: Sebastian Reichel <s...@kernel.org> --- arch/arm/boot/dts/omap3-n950-n9.dtsi | 16 +++- 1 file changed, 15 insertions(+), 1 de

[PATCH 2/2] HSI: omap-ssi: add clk change support

This adds support for frequency changes of the SSI functional clock, which may occur due to DVFS. Signed-off-By: Sebastian Reichel <s...@kernel.org> --- drivers/hsi/controllers/omap_ssi.c | 63 + drivers/hsi/controllers/omap_ssi.h | 6 drive

<    5   6   7   8   9   10   11   12   13   14   >