Re: [PATCH v5 09/10] ARM: dts: berlin: add the Ethernet node

2014-09-26 Thread Sergei Shtylyov
Hello. On 09/26/2014 06:33 PM, Antoine Tenart wrote: This patch adds the Ethernet node, enabling the network unit on Berlin BG2Q SoCs. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com Acked-by: Arnd Bergmann a...@arndb.de --- arch/arm/boot/dts/berlin2q.dtsi | 17

Re: [PATCH v4] i2c/at91: adopt pinctrl support

2014-11-10 Thread Sergei Shtylyov
Hello. On 11/10/2014 4:55 AM, Wenyou Yang wrote: Amend the at91 i2c pin controller You're amending the hardware itself, really? :-) to optionally take a pin controlhandle I don't see the code that does this. and set the state of the pins to: - default on boot and resume. I

Re: [PATCH 8/9] net: phy: micrel: clean up led-mode setup

2014-11-11 Thread Sergei Shtylyov
Hello. On 11/11/2014 10:00 PM, Johan Hovold wrote: Clean up led-mode setup by introducing proper defines for PHY Control registers 1 and 2 and only passing the register to the setup function. Not sure that's really better that it was before (modulo naming). Signed-off-by: Johan Hovold

Re: [PATCH v5 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
-off-by: Antoine Tenart antoine.ten...@free-electrons.com [Sergei: added missing 'drivers/usb/misc/lvstest.c' file, resolved rejects caused by patch reordering, updated changelog.] Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked

[PATCH v6 0/2] Add generic PHY support to USB HCD

2014-09-24 Thread Sergei Shtylyov
Hello. This patchset is against the usb-next' branch of Greg KH's 'usb.git' repo. Here I add support for the generic PHY to the 'struct usb_hcd' (having to rename the existing 'phy' field to 'usb_phy' beforehand). This was mainly intended to be used with the PCI OHCI/EHCI drivers and also xHCI

[PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
[Sergei: added missing 'drivers/usb/misc/lvstest.c' file, resolved rejects, updated changelog.] Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Alan Stern st...@rowland.harvard.edu --- Changes in version 6: - resolved reject, refreshed the patch. Changes in version 5

[PATCH v6 2/2] usb: hcd: add generic PHY support

2014-09-24 Thread Sergei Shtylyov
Add the generic PHY support, analogous to the USB PHY support. Intended it to be used with the PCI EHCI/OHCI drivers and the xHCI platform driver. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Signed-off-by: Yoshihiro Shimoda yoshihiro.shimoda...@renesas.com --- Changes

Re: [PATCH v6 1/2] usb: rename phy to usb_phy in HCD

2014-09-24 Thread Sergei Shtylyov
. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com [Sergei: added missing 'drivers/usb/misc/lvstest.c' file, resolved rejects, updated changelog.] Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Alan Stern st...@rowland.harvard.edu Acked-by: Felipe Balbi ba

Re: [PATCH v2 1/3] clocksource: vf_pit_timer: Support shutdown mode

2014-09-25 Thread Sergei Shtylyov
Hello. On 9/24/2014 8:20 PM, Stefan Agner wrote: In order to avoid waking up the system in a low power mode, the clocksource should not generate interrupts anymore. Disable the PIT timer interrupt when changing into the CLOCK_EVT_MODE_SHUTDOWN mode. Signed-off-by: Stefan Agner

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 1:43 AM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? (3)

Re: [RFC/PATCH] extcon: otg_gpio: add driver for USB OTG port controlled by GPIO(s)

2014-12-23 Thread Sergei Shtylyov
Hello. On 12/23/2014 10:57 PM, David Cohen wrote: Some platforms have an USB OTG port fully (or partially) controlled by GPIOs: (1) USB ID is connected directly to GPIO Optionally: (2) VBUS is enabled by a GPIO (when ID is grounded) Can't the host driver still control Vbus? I

Re: [PATCH] clk-rcar-gen2: RCAN clock support

2014-12-23 Thread Sergei Shtylyov
Hello. On 07/31/2014 12:23 AM, Sergei Shtylyov wrote: Add RCAN clock support to the R-Car generation 2 CPG driver. This clock gets derived from the USB_EXTAL clock by dividing it by 6. The layout of RCANCKCR register is close to those of the clocks supported by the 'clk-div6' driver but has

[PATCH] clk-gate: fix bit # check in clk_register_gate()

2014-12-24 Thread Sergei Shtylyov
In case CLK_GATE_HIWORD_MASK flag is passed to clk_register_gate(), the bit # should be no higher than 15, however the corresponding check is obviously off- by-one. Fixes: 045779942c04 (clk: gate: add CLK_GATE_HIWORD_MASK) Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com

[PATCH v2] clk-rcar-gen2: RCAN clock support

2014-12-24 Thread Sergei Shtylyov
by that driver... Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo. Changes in version 2: - switched to using the composite clock driver with the fixed factor and gated clock component drivers

[PATCH] clk-rcar-gen2: ADSP clock support

2014-12-25 Thread Sergei Shtylyov
on the original patch by Konstantin Kozhevnikov konstantin.kozhevni...@cogentembedded.com. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support posted yesterday

Re: [PATCH v2 07/12] ARM: imx: depend MXC debug board on 3DS machines

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 2:32 AM, Stefan Agner wrote: Depend the MXC debug board on machines which actually support it. Signed-off-by: Stefan Agner ste...@agner.ch --- This configuration appeared lonely when I enabled ARCH_MULTI_V7M. Afaik, the selection of it only makes sense with one of the

Re: [PATCH v5 2/6] ASoC: dwc: Prepare clock before use

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 1:55 PM, Andrew Jackson wrote: From: Andrew Jackson andrew.jack...@arm.com Some I2S clocks may require some time to get the clock ready for operation and so need to be prepared before they are enabled. So, prepare the clock as well as enabling it, but combine the two

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

2014-12-30 Thread Sergei Shtylyov
Hello. On 12/30/2014 03:20 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for = 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong.

Re: [PATCH 0/4] ath10k: a few incorrect return handling fix-up

2014-12-30 Thread Sergei Shtylyov
On 12/30/2014 09:28 PM, Nicholas Mc Guire wrote: wait_for_completion_timeout does not return negative values so the tests for = 0 are not needed and the case differentiation in the error handling path unnecessary. I decided to verify your statement and I saw that it seems wrong.

[PATCH v2] clk-rcar-gen2: ADSP clock support

2014-12-30 Thread Sergei Shtylyov
on the original patch by Konstantin Kozhevnikov konstantin.kozhevni...@cogentembedded.com. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the 'clk-next' branch of Mike Turquette's 'linux.git' repo plus the RCAN clock support patch posted last week

Re: [PATCH 3/4] GMAC: dts: add gmac info for rk3288

2014-11-25 Thread Sergei Shtylyov
Hello. On 11/25/2014 12:08 PM, Roger Chen wrote: add gmac info in rk3288.dtsi for GMAC driver Signed-off-by: Roger Chen roger.c...@rock-chips.com --- arch/arm/boot/dts/rk3288.dtsi | 59 + 1 file changed, 59 insertions(+) diff --git

Re: [PATCH] extcon: add MAX3355 driver

2014-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2014 4:46 AM, Chanwoo Choi wrote: I reviewed this patch quickly. This driver has just two gpio without any registers for IP. Because there are no registers. I wonder whether MAX3355E is separate chip to detect external connector Yes. I thought my description has

Re: [PATCH 1/1] net/macb: fix compilation warning for print_hex_dump() called with skb-mac_header

2014-12-11 Thread Sergei Shtylyov
Hello. On 12/11/2014 1:15 PM, Cyrille Pitchen wrote: Citing the warning here would be a good idea. Signed-off-by: Cyrille Pitchen cyrille.pitc...@atmel.com WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: arm64 hitting BUG in arch_timer.h

2014-12-11 Thread Sergei Shtylyov
Hello. On 12/10/2014 11:56 PM, Mark Salter wrote: Using Linus' tree from this morning, I am hitting: [0.00] BUG: failure at ./arch/arm64/include/asm/arch_timer.h:112/arch_counter_get_cntpct! This is triggered by commit 0b46b8a718 (clocksource: arch_timer: Fix code to use

Re: [PATCH v1] libata: export ata_get_cmd_descript()

2014-12-12 Thread Sergei Shtylyov
Hello. On 12/12/2014 06:16 PM, Andy Shevchenko wrote: The driver sata_dwc_460ex is using this symbol. To build it as a module we have to have the symbol exported. This patch adds EXPORT_SYMBOL() macro for that. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com ---

[PATCH] extcon-class: kill duplicate #include

2014-12-12 Thread Sergei Shtylyov
Commit f841afb17476f485900bb6213cf93a64a7dc303f (extcon: Implement OF-based extcon lookup properly) added #include linux/of.h (I didn't even understand why), while such #include was already there. Kill the duplicate #include. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com

Re: [PATCH 1/2] MIPS: FW: Fix parsing u-boot environment

2014-11-07 Thread Sergei Shtylyov
Hello. On 11/7/2014 2:23 PM, Alban Bedel wrote: When reading u-boot's key=value pairs it should skip the '=' and not use the next argument. Signed-off-by: Alban Bedel al...@free.fr --- arch/mips/fw/lib/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 05/11] x86, mpx: add MPX to disaabled features

2014-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2014 06:18 PM, Dave Hansen wrote: From: Dave Hansen dave.han...@linux.intel.com This allows us to use cpu_feature_enabled(X86_FEATURE_MPX) as both a runtime and compile-time check. When CONFIG_X86_INTEL_MPX is disabled, cpu_feature_enabled(X86_FEATURE_MPX) will evaluate

Re: [PATCH v7 11/13] ARM: dts: Berlin: enable USB on the BG2Q DMP

2014-11-14 Thread Sergei Shtylyov
Hello. On 11/14/2014 06:26 PM, Antoine Tenart wrote: Enable the 2 available USB PHY and USB nodes on the Marvell Berlin BG2Q DMP. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- arch/arm/boot/dts/berlin2q-marvell-dmp.dts | 53 ++ 1 file

Re: [PATCH v4] of: replace Asahi Kasei Corp venter prefix

2014-11-17 Thread Sergei Shtylyov
Hello. On 11/17/2014 3:51 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto kuninori.morimoto...@renesas.com s/venter/vendor/ in the subject. Sorry for a late comment. Current vendor-prefixes.txt already has ak prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for

Re: [PATCH v7 1/2] usb: host: xhci-plat: Get PHYs for xhci's hcds

2014-11-17 Thread Sergei Shtylyov
Hello. On 11/17/2014 9:36 AM, Vivek Gautam wrote: The host controller by itself may sometimes need to handle PHY and re-initialize it to re-configure some of the PHY parameters to get full support out of the PHY controller. Therefore, facilitate getting the two possible PHYs, viz. USB 2.0 type

Re: [PATCH] usb: dwc2: resume root hub when device detect with suspend state

2014-11-17 Thread Sergei Shtylyov
Hello. On 11/17/2014 04:14 PM, Kever Yang wrote: After we implement the bus_suspend/resume, auto suspend id enabled. The root hub will be auto suspend if there is no device connected, we need to resume the root hub when a device connect detect. This patch tested on rk3288. Signed-off-by:

Re: [PATCH v8 10/13] ARM: dts: berlin: add BG2Q nodes for USB support

2014-11-17 Thread Sergei Shtylyov
Hello. On 11/17/2014 04:35 PM, Antoine Tenart wrote: Adds nodes describing the Marvell Berlin BG2Q USB PHY and USB. The BG2Q SoC has 3 USB host controller, compatible with ChipIdea. Signed-off-by: Antoine Tenart antoine.ten...@free-electrons.com --- arch/arm/boot/dts/berlin2q.dtsi | 55

Re: [PATCH] ALSA: atmel: fix building the ac97 driver for at91-multiplatform

2014-12-19 Thread Sergei Shtylyov
Hello. On 12/19/2014 2:13 AM, Alexandre Belloni wrote: From: Arnd Bergmann a...@arndb.de at91 will no longer export the mach/cpu.h and mach/hardware.h header files in the future, which would break building the atmel ac97c driver. Since the cpu_is_* check is only used to find out whether

Re: [PATCH v2 1/2] usb: serial: handle -EPROTO quietly in generic_read_bulk

2014-12-20 Thread Sergei Shtylyov
Hello. On 12/20/2014 12:11 PM, Jeremiah Mahler wrote: If a USB serial device driver, which is built using the generic serial driver, is unplugged while there is an active program using the device, Driver is unplugged? :-) it will spam the logs with -EPROTO (71) messages as it attempts

Re: [PATCH 1/2] ARM: dts: kirkwood: enable phy driver for SATA controller on 88f6192

2014-12-16 Thread Sergei Shtylyov
Hello. On 12/15/2014 11:37 PM, Evgeni Dobrev wrote: This patch enables the phy drivers for the SATA controller on Marvell's 88f6192. Without them it is not possible to use SATA drives attached to this processor. Please wrap the change log likes at 80 characters or less. Signed-off-by:

Re: [PATCH 1/4] ACPICA: take ACPI_MTX_INTERPRETER in acpi_unload_table_id

2014-12-16 Thread Sergei Shtylyov
Hello. On 12/16/2014 07:12 PM, Octavian Purdila wrote: acpi_tb_delete_namespace_by_owner expects ACPI_MTX_INTERPRETER to be taken. This fixes the following issue: ACPI Error: Mutex [0x0] is not acquired, cannot release (20141107/utmutex-322) Call Trace: [81b0bd28]

[PATCH] usb: hcd: add OTG ID signal sensing

2014-12-16 Thread Sergei Shtylyov
for MAX3355 has been written, so we only need to bind to it via device tree which I'm doing in this patch. I wasn't able to find a solution better than checking the cable type at the host driver probe time and refusing to drive a host if B-cable is connected. Signed-off-by: Sergei Shtylyov sergei.shtyl

Re: [PATCH] usb: hcd: add OTG ID signal sensing

2014-12-17 Thread Sergei Shtylyov
Hello. On 12/17/2014 5:08 AM, Peter Chen wrote: On the Renesas R8A7791 SoC based boards there's MAX3355 USB OTG chip and mini-AB USB connector corresponding to USB port 0 driven either by EHCI/OHCI or Renesas USBHS gadget controller. And we'd like the host/gadget drivers to work based on the

Re: [PATCH] extcon: add MAX3355 driver

2014-12-17 Thread Sergei Shtylyov
. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the 'extcon-next' branch of the 'extcon.git' repo. Documentation/devicetree/bindings/extcon/extcon-max3355.txt | 21 ++ drivers/extcon/Kconfig |6 drivers

Re: [PATCH v5][resend] of: replace Asahi Kasei Corp venter prefix

2014-11-28 Thread Sergei Shtylyov
Hello. On 11/28/2014 3:22 AM, Kuninori Morimoto wrote: From: Kuninori Morimoto kuninori.morimoto...@renesas.com Current vendor-prefixes.txt already has ak prefix for Asahi Kasei Corp by ae8c4209af2c(of: Add vendor prefix for Asahi Kasei Corp.) It went through the appropriate review

Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

2014-11-28 Thread Sergei Shtylyov
Hello. On 11/28/2014 04:50 PM, Ricardo Ribalda Delgado wrote: restart_dma is not used before it is declaration. Therefore we can s/it is/its/. remove this definition. You're removing the declaration, not definition. Signed-off-by: Ricardo Ribalda Delgado ricardo.riba...@gmail.com

Re: [PATCH 06/17] net2280: Remove restart_dma inline function definition

2014-11-28 Thread Sergei Shtylyov
On 11/28/2014 06:21 PM, Ricardo Ribalda Delgado wrote: Thanks for reviewing. I will fix it and resend it on the next version of the patchset to avoid spamming the ML I guess it is ok to add your Reviewed-by Yes, if you like. Thanks! Not at all. :-) [...] On 11/28/2014 04:50

Re: [PATCH v7 28/46] vhost: make features 64 bit

2014-11-30 Thread Sergei Shtylyov
Hello. On 11/30/2014 6:11 PM, Michael S. Tsirkin wrote: We need to use bit 32 for virtio 1.0 Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Jason Wang jasow...@redhat.com --- drivers/vhost/vhost.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call kfree

2014-12-01 Thread Sergei Shtylyov
Hello. On 11/30/2014 7:44 PM, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Sun, 30 Nov 2014 17:02:07 +0100 The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue

Re: [PATCH 1/3] net-PPP: Deletion of unnecessary checks before the function call kfree

2014-12-01 Thread Sergei Shtylyov
On 12/01/2014 06:00 PM, SF Markus Elfring wrote: diff --git a/drivers/net/ppp/ppp_mppe.c b/drivers/net/ppp/ppp_mppe.c index 911b216..7e44212 100644 --- a/drivers/net/ppp/ppp_mppe.c +++ b/drivers/net/ppp/ppp_mppe.c @@ -238,8 +238,7 @@ static void *mppe_alloc(unsigned char *options, int optlen)

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Sergei Shtylyov
Hello. On 12/4/2014 3:06 PM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit 1290a958d48e (usb: phy: propagate __of_usb_find_phy()'s error on failure) broke platforms that rely on deferred probing to order probing of PHY and host controller drivers. The reason is that

Re: [PATCH] usb: phy: Restore deferred probing path

2014-12-04 Thread Sergei Shtylyov
On 12/4/2014 4:22 PM, Thierry Reding wrote: From: Thierry Reding tred...@nvidia.com Commit 1290a958d48e (usb: phy: propagate __of_usb_find_phy()'s error on failure) broke platforms that rely on deferred probing to order probing of PHY and host controller drivers. The reason is that the

Re: [PATCHv3 net] i40e: Implement ndo_gso_check()

2014-12-04 Thread Sergei Shtylyov
Hello. On 12/04/2014 09:39 PM, Joe Stringer wrote: ndo_gso_check() was recently introduced to allow NICs to report the offloading support that they have on a per-skb basis. Add an implementation for this driver which checks for IPIP, GRE, UDP tunnels. Signed-off-by: Joe Stringer

Re: [RFC][PATCH 07/13] iov_iter.c: get rid of bvec_copy_page_{to,from}_iter()

2014-12-05 Thread Sergei Shtylyov
Hello. On 12/4/2014 11:23 PM, Al Viro wrote: Looks like you've erred in the subject as you seem to be getting rid of copy_page_{to|from}_iter_bvec() instead of bvec_copy_page_{to|from}_iter()... From: Al Viro v...@zeniv.linux.org.uk Just have copy_page_{to,from}_iter() fall back to

[PATCH] extcon: add MAX3355 driver

2014-12-10 Thread Sergei Shtylyov
. The Vbus status signals are also wired to GPIOs (however, we're not currently intested in them), the OFFVBUS# signal is controlled by the host controllers, there's also the SHDN# signal wired to GPIO, which should be high for normal operation. Signed-off-by: Sergei Shtylyov sergei.shtyl

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2014-12-31 Thread Sergei Shtylyov
Hello. On 12/31/2014 11:20 AM, Fu, Zhonghui wrote: From e34419970a07bfcd365f9c66bdfa552188a0cd26 Mon Sep 17 00:00:00 2001 From: Zhonghui Fu zhonghui...@linux.intel.com Date: Mon, 29 Dec 2014 21:25:31 +0800 Subject: [PATCH] brcmfmac: avoid duplicated suspend/resume operation WiFi chip has 2

Re: [PATCH] brcmfmac: avoid duplicated suspend/resume operation

2015-01-22 Thread Sergei Shtylyov
functions, and PM core will trigger twice suspend/resume operations for one WiFi chip to do the same things. This patch avoid this case. Acked-by: Arend van Spriel ar...@broadcom.com Acked-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Acked-by: Kalle Valo kv...@codeaurora.org Signed-off

Re: [PATCH 2/7] pm: at91: pm_suspend: add the WFI support for ARMv7

2015-01-26 Thread Sergei Shtylyov
Hello. On 1/26/2015 1:06 PM, Wenyou Yang wrote: Signed-off-by: Wenyou Yang wenyou.y...@atmel.com --- arch/arm/mach-at91/pm_suspend.S | 54 ++- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-at91/pm_suspend.S

Re: [PATCH v2 04/12] pm: at91: move the copying the sram function to the sram initializationi phase

2015-01-26 Thread Sergei Shtylyov
Hello. On 1/26/2015 12:40 PM, Wenyou Yang wrote: To decrease the suspend time, move the copying the sram function to the sram initialization phase, instead of every time go to suspend. Signed-off-by: Wenyou Yang wenyou.y...@atmel.com Acked-by: Alexandre Belloni

Re: [PATCH_V2 04/34] MIPS: jz4740: probe CPU interrupt controller via DT

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 06:21 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton paul.bur...@imgtec.com Use the generic irqchip_init function to probe irqchip drivers using DT, and add the appropriate node to the jz4740 devicetree in place of the call to mips_cpu_irq_init.

Re: [PATCH_V2 07/34] dt: interrupt-controller: Add ingenic,jz4740-intc binding doc

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 06:21 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton paul.bur...@imgtec.com Add binding documentation for the Ingenic jz4740 interrupt controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc: Lars-Peter Clausen l...@metafoo.de Cc:

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 08:32 PM, Wolfram Sang wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH_V2 09/34] MIPS: jz4740: probe interrupt controller via DT

2015-02-04 Thread Sergei Shtylyov
On 02/04/2015 06:21 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton paul.bur...@imgtec.com Add the appropriate DT node to probe the interrupt controller driver using the devicetree, and remove the call to jz4740_intc_init. Signed-off-by: Paul Burton paul.bur...@imgtec.com Cc:

Re: [PATCH v2] net: bluetooth: hci_sock: Use 'const void *' instead of 'void *' for 2nd parameter of hci_test_bit()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 02:59 PM, David Laight wrote: -static inline int hci_test_bit(int nr, void *addr) +static inline int hci_test_bit(int nr, const void *addr) { return *((__u32 *) addr + (nr 5)) ((__u32) 1 (nr 31)); } Is there a 'standard' function lurking that will do the

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:04 AM, Sergei Shtylyov wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/05/2015 01:01 AM, Mike Turquette wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned

2015-02-02 Thread Sergei Shtylyov
Hello. On 02/02/2015 05:02 PM, Jiri Slaby wrote: From: Tim Chen tim.c.c...@linux.intel.com Subject: [PATCH] pci-dma: Fix x86 dma_alloc_coherent to fully clear all pages returned Commit d92ef66c4f8f (x86: make dma_alloc_coherent() return zeroed memory if CMA is enabled) changed the

Re: [PATCH 1/1] ARM: dts: Use more descriptive names for Exynos5420 PDs

2015-02-06 Thread Sergei Shtylyov
Hello. On 02/06/2015 08:37 PM, Javier Martinez Canillas wrote: All the device nodes for the Exynos5420 power-domains have a quite generic power-domain name. And this is in conformance to the ePAPR standard. So in case of an error, the Exynos PD driver shows the following (not very

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 2/7/2015 3:39 PM, Robert Jarzmik wrote: Add clocks to the IPs already described in the pxa device-tree files. There are more clocks in the clock tree than IPs described in the current pxa device-tree. This patch ensures that : - the current description is correct - the clocks

Re: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors

2015-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2015 08:06 PM, Bas Peters wrote: This patch fixes the following checkpatch errors: 1. trailing statement 1. assignment of variable in if condition 1. incorrectly placed brace after function definition Signed-off-by: Bas Peters baspeter...@gmail.com

Re: [PATCH 2/6] drivers: isdn: act2000: capi.c: fix checkpatch errors

2015-02-07 Thread Sergei Shtylyov
On 02/07/2015 09:08 PM, Bas Peters wrote: Please don't top-post. I must have missed something. I fixed it on my end. Do I now resend the entire patchset or just this particular patch? The entire patch set, at least DaveM wants it this way. regards, Bas WBR, Sergei -- To

Re: [PATCH v3 2/5] ARM: dts: pxa: add clocks

2015-02-07 Thread Sergei Shtylyov
Hello. On 02/07/2015 04:16 PM, Robert Jarzmik wrote: + stuart: uart@4070 { + clocks = pxa2xx_clks CLK_STUART; + }; + The ePAPR standard tells to call such nodes serial, not uart. Good to know, but not for this patch. The naming

Re: [PATCH 2/2] drivers: isdn: icn: icn.h Clean up trivial checkpatch errors.

2015-02-07 Thread Sergei Shtylyov
Hello. Citing the checkpatch.pl errors would be helpful here. You also forgot to sign off on the patch, so it can't be applied. WBR, Sergei -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/7] drivers: isdn: act2000: capi.c: fix checkpatch errors

2015-02-07 Thread Sergei Shtylyov
On 02/07/2015 10:05 PM, Bas Peters wrote: This patch fixes the following checkpatch errors: 1. trailing statement 1. assignment of variable in if condition 1. incorrectly placed brace after function definition Signed-off-by: Bas Peters baspeter...@gmail.com ---

Re: [PATCH 7/7] drivers: isdn: act2000: capi.c: add macro \ and fix brace

2015-02-07 Thread Sergei Shtylyov
On 02/07/2015 10:05 PM, Bas Peters wrote: This patch adds the \ that was accidentally deleted in patch 2. It also adds a brace after the else statement, which is required due to the fact that the if statement has braces. This won't do, fix up the patch #2 please. And please wrap your

Re: [PATCH_V4 1/3] dt: usb: jz4740: Add DT binding document for OHCI

2015-02-03 Thread Sergei Shtylyov
Hello. On 2/3/2015 1:17 PM, Zubair Lutfullah Kakakhel wrote: From: Paul Burton paul.bur...@imgtec.com Add the binding documentation for the JZ4740 OHCI controller. Signed-off-by: Paul Burton paul.bur...@imgtec.com Signed-off-by: Zubair Lutfullah Kakakhel zubair.kakak...@imgtec.com

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-04 Thread Sergei Shtylyov
Hello. On 02/04/2015 03:27 PM, Geert Uytterhoeven wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Shouldn't this be checked and fixed up in clk_round_rate() then? Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be WBR, Sergei

Re: [PATCH] clk: shmobile: div6: Avoid division by zero in .round_rate()

2015-02-06 Thread Sergei Shtylyov
Hello. On 2/5/2015 8:19 PM, Laurent Pinchart wrote: Anyone may call clk_round_rate() with a zero rate value, so we have to protect against that. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Acked-by: Wolfram Sang wsa+rene...@sang-engineering.com I agree that this should

Re: [PATCH V5 6/8] USB: f81232: clarify f81232_ioctl()

2015-02-06 Thread Sergei Shtylyov
Hello. On 2/6/2015 12:46 PM, Peter Hung wrote: We extract TIOCGSERIAL section in f81232_ioctl() to f81232_get_serial_info() to make it clarify You're also changing 'ser.baud_rate' from 460800 to 115200. And explicitly overriding some previously initialized to 0 fields. The

Re: [PATCH] USB: image: use msecs_to_jiffies for time conversion

2015-02-06 Thread Sergei Shtylyov
On 2/6/2015 4:36 PM, Nicholas Mc Guire wrote: This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- Note that the indentation is not aligned with the correct ( here

Re: [PATCH] USB: image: use msecs_to_jiffies for time conversion

2015-02-06 Thread Sergei Shtylyov
Hello. On 2/6/2015 12:50 PM, Nicholas Mc Guire wrote: This is only an API consolidation and should make things more readable it replaces var * HZ / 1000 by msecs_to_jiffies(var). Signed-off-by: Nicholas Mc Guire hof...@osadl.org --- Note that the indentation is not aligned with the

Re: [PATCH 3/6] drivers: usb: core: hcd.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
Hello. On 2/8/2015 12:55 AM, Bas Peters wrote: This patch removes assignment of variables in if conditions, as specified in CodingStyle. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/core/hcd.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-)

Re: [PATCH 2/3] drivers: usb: storage: cypress_atacb.c: trivial checkpatch fixes

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 1:42 AM, Bas Peters wrote: Fixes errors thrown by checkpatch over a space issue and the incorrect indentation of a switch statement. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/storage/cypress_atacb.c | 17 - 1 file changed, 8 insertions(+),

Re: [PATCH 4/6] drivers: usb: core: hub.c: remove NULL initialization of static variables.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: NULL Rather 0-. initialization of static variables is unnecessary as GCC kindly does this for us. It's rather the C run-time library that does this. Signed-off-by: Bas Peters baspeter...@gmail.com [...] WBR, Sergei -- To unsubscribe from

Re: [PATCH 5/6] drivers: usb: core: hub.c: remove assignment of variables in if conditions.

2015-02-08 Thread Sergei Shtylyov
On 2/8/2015 12:55 AM, Bas Peters wrote: As specified in the CodingStyle. Signed-off-by: Bas Peters baspeter...@gmail.com --- drivers/usb/core/hub.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index

[PATCH] driver core: use *switch* statement in really_probe()

2015-01-17 Thread Sergei Shtylyov
There are series of comparisons of the 'ret' variable on the failure path of really_probe(), so the *switch* statement seems more appropriate there. Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com --- The patch is against the 'driver-core-next' branch of Greg KH's 'driver

Re: [PATCH] clk-gate: fix bit # check in clk_register_gate()

2015-01-17 Thread Sergei Shtylyov
-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Applied to clk-next. Thanks! Is this causing a visible regression for you? It is not a new bug so I'd prefer to send it though clk-next unless something is blowing up on your end. No, nothing, I don't even call this function (was using

Re: [PATCH] net: wireless: atmel: Remove open-coded and wrong strcasecmp

2015-01-16 Thread Sergei Shtylyov
Hello. On 01/16/2015 04:28 PM, Rasmus Villemoes wrote: The kernel's string library does in fact have strcasecmp, at least since ded220bd8f08. Moreover, this open-coded version is in fact Please also specify that commit's summary line in parens. wrong: If the strings only differ in their

Re: [PATCH 23/28] PCI/designware: Use pci_scan_root_bus() for simplicity

2015-01-17 Thread Sergei Shtylyov
Hello. On 1/16/2015 4:44 AM, Yijing Wang wrote: Use pci_scan_root_bus() instead of pci_create_root_bus() + pci_scan_child_bus() for simplicity. Signed-off-by: Yijing Wang wangyij...@huawei.com --- drivers/pci/host/pcie-designware.c |4 +--- 1 files changed, 1 insertions(+), 3

Re: [PATCH v2 4/4] usb: serial: remove unused function for F81232

2015-01-21 Thread Sergei Shtylyov
Hello. On 1/21/2015 1:30 PM, Peter Hung wrote: remove unused function set_line_control The source says set_control_lines(). Signed-off-by: Peter Hung hpeter+linux_ker...@gmail.com --- drivers/usb/serial/f81232.c | 7 --- 1 file changed, 7 deletions(-) diff --git

Re: [PATCH v5 4/5] can: kvaser_usb: Retry the first bulk transfer on -ETIMEDOUT

2015-01-21 Thread Sergei Shtylyov
Hello. On 1/21/2015 12:48 AM, Ahmed S. Darwish wrote: From: Ahmed S. Darwish ahmed.darw...@valeo.com On some x86 laptops, plugging a Kvaser device again after an unplug makes the firmware always ignore the very first command. For such a case, provide some room for retries instead of

Re: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

2015-02-11 Thread Sergei Shtylyov
Hello. On 2/11/2015 9:46 AM, Hayes Wang wrote: Separate USB_RX_EARLY_AGG into USB_RX_EARLY_TIMEOUT and USB_RX_EARLY_SIZE. Replace r8153_set_rx_agg() with r8153_set_rx_early_timeout() and r8153_set_rx_early_size(). Set the default timeout value according to the USB speed.

Re: -n900 (not mainline): fix compilation with 3.20-rc0

2015-02-11 Thread Sergei Shtylyov
Hello. On 02/12/2015 01:23 AM, Pavel Machek wrote: This looked like a patch in its final form, so I decided to comment on it... commit 02aa41563bd0f14268d2142ab69694880d3425a1 Author: Pavel pa...@ucw.cz Date: Wed Feb 11 23:22:51 2015 +0100 No need for this header. Fix

Re: [PATCH] libata: fixup return type of wait_for_completion_timeout

2015-02-10 Thread Sergei Shtylyov
irq_timeout to time_left (as was suggested by Sergei Shtylyov sergei.shtyl...@cogentembedded.com for a similar patch) and then it would read: if (time_left == 0) { which would nicely describe the timeout state. '!time_left' also would. if that addresses your concerns then I'll fix it up

Re: [PATCH] [media] soc-camera: Remove bogus devm_kfree() in soc_of_bind()

2015-02-18 Thread Sergei Shtylyov
Hello. On 02/18/2015 07:32 PM, Geert Uytterhoeven wrote: Unlike scan_async_group(), soc_of_bind() doesn't allocate its soc_camera_async_client structure using devm_kzalloc(), but has it embedded inside the soc_of_info structure. Hence on failure, it must not free it using devm_kfree(), as

Re: [PATCH 2/6] ASoC: max98088: Add DT bindings

2015-02-18 Thread Sergei Shtylyov
Hello. On 02/18/2015 09:25 PM, Andreas Färber wrote: maxim,max98089 will be used for the Spring Chromebook. Signed-off-by: Andreas Färber afaer...@suse.de --- sound/soc/codecs/max98088.c | 8 1 file changed, 8 insertions(+) diff --git a/sound/soc/codecs/max98088.c

Re: [PATCH net-next 1/3] r8152: separate USB_RX_EARLY_AGG

2015-02-12 Thread Sergei Shtylyov
Hello. On 2/12/2015 5:36 AM, Hayes Wang wrote: [...] + ocp_data = tp-coalesce / 8; Why not do it in the initializer? This is for patch #3. The patch #3 would use this function. The new function is already called in this patch. The unit of the relative setting from the

Re: [PATCH v2 1/3] Ethernet packet sniffer: Device tree binding and vendor prefix

2015-02-17 Thread Sergei Shtylyov
Hello. On 02/17/2015 05:03 PM, Stathis Voukelatos wrote: Signed-off-by: Stathis Voukelatos stathis.voukela...@linn.co.uk [...] diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt index d443279..891c224 100644 ---

Re: [PATCH 2/4] hw_random: bcm63xx-rng: move register definitions to driver

2015-02-17 Thread Sergei Shtylyov
Hello. On 2/17/2015 5:09 AM, Florian Fainelli wrote: arch/mips/include/asm/mach-bcm63xx/bcm63xx_regs.h contains the register definitions for this random number generator block, incorporate these register definitions directly into the bcm63xx-rng driver so we do not rely on this header to be

Re: [PATCH] x86/vdso: Remove all generated files during clean

2015-02-19 Thread Sergei Shtylyov
Hello. On 2/19/2015 5:13 AM, Magnus Damm wrote: From: Magnus Damm damm+rene...@opensource.se Make sure the following files are removed as expected during make clean: + arch/x86/vdso/vdso-image-32-int80.c + arch/x86/vdso/vdso-image-32-syscall.c + arch/x86/vdso/vdso-image-32-sysenter.c

Re: [PATCHv3 1/5] usb: gadget: bind UDC by name passed via usb_gadget_driver structure

2015-02-18 Thread Sergei Shtylyov
Hello. On 2/18/2015 12:17 AM, Ruslan Bilovol wrote: Introduce new 'udc_name' member to usb_gadget_driver structure. The 'udc_name' is a name of UDC that usb_gadget_driver should be bound to. If udc_name is NULL, it will be bound to any available UDC. Signed-off-by: Ruslan Bilovol

Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-17 Thread Sergei Shtylyov
Hello. On 2/17/2015 4:45 AM, Joseph Kogut wrote: Signed-off-by: Joseph Kogut joseph.ko...@gmail.com [...] diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index e63c02a..38cff8f 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2315,6 +2315,8 @@ #define

Re: [PATCH] usb: move definition of PCI_VENDOR_ID_SYNOPSYS to linux/pci_ids.h

2015-02-17 Thread Sergei Shtylyov
On 2/17/2015 3:20 PM, Sergei Shtylyov wrote: Signed-off-by: Joseph Kogut joseph.ko...@gmail.com [...] diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index e63c02a..38cff8f 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2315,6 +2315,8 @@ #define

Re: [PATCH v3 03/13] pm: at91: Workaround DDRSDRC self-refresh bug with LPDDR1 memories.

2015-01-27 Thread Sergei Shtylyov
Hello. On 1/27/2015 8:53 AM, Wenyou Yang wrote: From: Peter Rosin p...@axentia.se The DDRSDR controller fails miserably to put LPDDR1 memories in self-refresh. Force the controller to think it has DDR2 memories during the self-refresh period, as the DDR2 self-refresh spec is equivalent to

<    6   7   8   9   10   11   12   13   14   15   >