[PATCH 1/3] mfd: tps6586x: add version detection

2013-11-26 Thread Stefan Agner
Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x regulators use a different voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/mfd/tps6586x.c

[PATCH 3/3] ARM: tegra: set SM2 voltage correct

2013-11-26 Thread Stefan Agner
the correct voltage table for both regulator versions and those the correct voltage can be used in this device tree. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH 0/3] regulator: tps6586x: add version detection and voltage tables

2013-11-26 Thread Stefan Agner
. Since the regulator driver has correct voltage tables for both regulator versions now, we can request the correct 1.8V from the device tree. Tested on Colibri T20 V1.1 and V1.2. Stefan Agner (3): mfd: tps6586x: add version detection regulator: tps6586x: add voltage table for tps658643 ARM

[PATCH 2/3] regulator: tps6586x: add voltage table for tps658643

2013-11-26 Thread Stefan Agner
Depending on version, the voltage table might be different. Add version compatibility to the regulator information in order to select correct voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/regulator/tps6586x-regulator.c | 97 ++ 1 file

Re: [PATCH 3/3] ARM: tegra: set SM2 voltage correct

2013-11-27 Thread Stefan Agner
Hi Lucas, Am 2013-11-27 10:59, schrieb Lucas Stach: This isn't a global Tegra change, but very specific to the Colibri, so please reword your commit headline to reflect that. Agree, will do that. Also there are other issues with the regulator setup on Colibri, I sent a patch for this a good

Re: [PATCH 1/3] mfd: tps6586x: add version detection

2013-11-27 Thread Stefan Agner
Am 2013-11-27 14:09, schrieb Lee Jones: snip static int __remove_subdev(struct device *dev, void *unused) { platform_device_unregister(to_platform_device(dev)); @@ -477,6 +486,7 @@ static int tps6586x_i2c_probe(struct i2c_client *client, { struct tps6586x_platform_data *pdata

Re: [PATCH 1/3] mfd: tps6586x: add version detection

2013-11-27 Thread Stefan Agner
Am 2013-11-27 15:36, schrieb Lee Jones: snip Perhaps I should suggest to make TPS6586X_ANY a positive number then, as a negative value to me indicates more of an error than a generic parameter. I see, its especially confusing since the version is filled using the i2c_smbus_read_byte_data

Re: [PATCH 1/3] mfd: tps6586x: add version detection

2013-11-27 Thread Stefan Agner
Am 2013-11-27 16:30, schrieb Lee Jones: On Wed, 27 Nov 2013, Stefan Agner wrote: Am 2013-11-27 15:36, schrieb Lee Jones: snip Perhaps I should suggest to make TPS6586X_ANY a positive number then, as a negative value to me indicates more of an error than a generic parameter. I see, its

Re: [PATCH 1/3] mfd: tps6586x: add version detection

2013-11-27 Thread Stefan Agner
Am 2013-11-27 17:58, schrieb Stephen Warren: snip +tps6586x = devm_kzalloc(client-dev, sizeof(*tps6586x), GFP_KERNEL); +if (tps6586x == NULL) { +dev_err(client-dev, memory for tps6586x alloc failed\n); +return -ENOMEM; +} +tps6586x-version = (enum

Re: [PATCH 2/3] regulator: tps6586x: add voltage table for tps658643

2013-11-27 Thread Stefan Agner
Am 2013-11-27 18:09, schrieb Stephen Warren: On 11/26/2013 04:45 PM, Stefan Agner wrote: Depending on version, the voltage table might be different. Add version compatibility to the regulator information in order to select correct voltage table. diff --git a/drivers/regulator/tps6586x

Re: [PATCH 3/3] ARM: tegra: set SM2 voltage correct

2013-11-27 Thread Stefan Agner
Am 2013-11-27 18:13, schrieb Stephen Warren: On 11/26/2013 04:45 PM, Stefan Agner wrote: Set the requested SM2 voltage to the correct value of 1.8V. The value before used to work on TPS658623 since the driver applied a wrong voltage table too. However, the TPS658643 used on newer devices uses

Re: [PATCH 3/3] ARM: tegra: set SM2 voltage correct

2013-11-30 Thread Stefan Agner
Am 2013-11-28 10:49, schrieb Lucas Stach: Am Mittwoch, den 27.11.2013, 10:13 -0700 schrieb Stephen Warren: On 11/26/2013 04:45 PM, Stefan Agner wrote: Set the requested SM2 voltage to the correct value of 1.8V. The value before used to work on TPS658623 since the driver applied a wrong

[PATCH v2 3/3] ARM: tegra: correct Colibri T20 regulator settings

2013-12-01 Thread Stefan Agner
not in use so far. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi index

[PATCH v2 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-01 Thread Stefan Agner
another voltage table and those broke that pseudo-compatibility. The regulator driver now has the correct voltage table for both regulator versions and those the correct voltage can be used in the device tree. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi

[PATCH v2 0/3] regulator: tps6586x: add version detection and voltage tables

2013-12-01 Thread Stefan Agner
- Move version message in a sperate function - Include regulator bugfix, use correct supply voltage - Checked all voltages, fix SM0/SM1 (Core/CPU) and LDO6 voltage (VDAC/VI) in another commit - Rebased on top of v3.13-rc2 Stefan Agner (3): mfd: tps6586x: add version detection

[PATCH v2 1/3] mfd: tps6586x: add version detection

2013-12-01 Thread Stefan Agner
Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x regulators use a different voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/mfd/tps6586x.c

Re: [PATCH v2 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-02 Thread Stefan Agner
Am 2013-12-02 10:36, schrieb Thierry Reding: On Sun, Dec 01, 2013 at 04:59:14PM +0100, Stefan Agner wrote: [...] This looks pretty good generally. A few minor nits below... diff --git a/drivers/regulator/tps6586x-regulator.c b/drivers/regulator/tps6586x-regulator.c [...] +#define

[PATCH v3 1/3] mfd: tps6586x: add version detection

2013-12-03 Thread Stefan Agner
Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x regulators use a different voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- Since the struct tps6586x

[PATCH v3 0/3] regulator: tps6586x: add version detection and voltage tables

2013-12-03 Thread Stefan Agner
function - Include regulator bugfix, use correct supply voltage - Checked all voltages, fix SM0/SM1 (Core/CPU) and LDO6 voltage (VDAC/VI) in another commit - Rebased on top of v3.13-rc2 Stefan Agner (3): mfd: tps6586x: add version detection regulator: tps6586x: add and use correct

[PATCH v3 3/3] ARM: tegra: correct Colibri T20 regulator settings

2013-12-03 Thread Stefan Agner
not in use so far. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi index

[PATCH v3 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-03 Thread Stefan Agner
another voltage table and those broke that pseudo-compatibility. The regulator driver now has the correct voltage table for both regulator versions and those the correct voltage can be used in the device tree. Signed-off-by: Stefan Agner ste...@agner.ch --- Changes since v2: - Removed reg_ from

[PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-03 Thread Stefan Agner
another voltage table and those broke that pseudo-compatibility. The regulator driver now has the correct voltage table for both regulator versions and those the correct voltage can be used in the device tree. Signed-off-by: Stefan Agner ste...@agner.ch --- Changes since v3: - Check if version

[PATCH v4 1/3] mfd: tps6586x: add version detection

2013-12-03 Thread Stefan Agner
Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x regulators use a different voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- Since the struct tps6586x

[PATCH v4 3/3] ARM: tegra: correct Colibri T20 regulator settings

2013-12-03 Thread Stefan Agner
not in use so far. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi index

[PATCH v4 0/3] regulator: tps6586x: add version detection and voltage tables

2013-12-03 Thread Stefan Agner
(VDAC/VI) in another commit - Rebased on top of v3.13-rc2 Stefan Agner (3): mfd: tps6586x: add version detection regulator: tps6586x: add and use correct voltage table ARM: tegra: correct Colibri T20 regulator settings arch/arm/boot/dts/tegra20-colibri-512.dtsi | 34

Re: [PATCH v4 1/3] mfd: tps6586x: add version detection

2013-12-04 Thread Stefan Agner
Am 2013-12-04 09:10, schrieb Lee Jones: +int tps6586x_get_version(struct device *dev) +{ +struct tps6586x *tps6586x = dev_get_drvdata(dev); + +return tps6586x-version; +} +EXPORT_SYMBOL_GPL(tps6586x_get_version); I thought Mark suggested that this routine was converted to a

Re: [PATCH v4 1/3] mfd: tps6586x: add version detection

2013-12-04 Thread Stefan Agner
Am 2013-12-04 11:07, schrieb Lee Jones: On Wed, 04 Dec 2013, Stefan Agner wrote: Am 2013-12-04 09:10, schrieb Lee Jones: +int tps6586x_get_version(struct device *dev) +{ + struct tps6586x *tps6586x = dev_get_drvdata(dev); + + return tps6586x-version; +} +EXPORT_SYMBOL_GPL

Re: [PATCH v4 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-04 Thread Stefan Agner
Am 2013-12-04 13:14, schrieb Mark Brown: On Tue, Dec 03, 2013 at 11:18:47PM +0100, Stefan Agner wrote: Depending on the regulator version, the voltage table might be different. Use version specific regulator tables in order to select correct voltage table. For the following regulator versions

Re: [PATCH v4 3/3] ARM: tegra: correct Colibri T20 regulator settings

2013-12-05 Thread Stefan Agner
Am 2013-12-05 18:12, schrieb Stephen Warren: On 12/03/2013 03:18 PM, Stefan Agner wrote: Set the parent of the regulators LDO2 to LDO9 according to the schematic. Set the base voltage to 3.3V, there is only 3.3V on the module itself. Set the Core and CPU voltage to the specified voltages

Re: [PATCH v4 1/3] mfd: tps6586x: add version detection

2013-12-05 Thread Stefan Agner
Am 2013-12-05 18:06, schrieb Stephen Warren: snip @@ -493,13 +527,12 @@ static int tps6586x_i2c_probe(struct i2c_client *client, return -EIO; } -dev_info(client-dev, VERSIONCRC is %02x\n, ret); - tps6586x = devm_kzalloc(client-dev, sizeof(*tps6586x),

Re: [PATCH v4 1/3] mfd: tps6586x: add version detection

2013-12-05 Thread Stefan Agner
Am 2013-12-05 18:40, schrieb Stephen Warren: On 12/05/2013 10:43 AM, Stefan Agner wrote: Am 2013-12-05 18:06, schrieb Stephen Warren: snip @@ -493,13 +527,12 @@ static int tps6586x_i2c_probe(struct i2c_client *client, return -EIO; } - dev_info(client-dev, VERSIONCRC

[PATCH v5 1/3] mfd: tps6586x: add version detection

2013-12-06 Thread Stefan Agner
Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x regulators use a different voltage table. Signed-off-by: Stefan Agner ste...@agner.ch --- Changes since v4: - Use

[PATCH v5 3/3] ARM: tegra: correct Colibri T20 regulator settings

2013-12-06 Thread Stefan Agner
not in use so far. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/tegra20-colibri-512.dtsi | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/arch/arm/boot/dts/tegra20-colibri-512.dtsi b/arch/arm/boot/dts/tegra20-colibri-512.dtsi index

[PATCH v5 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-06 Thread Stefan Agner
another voltage table and those broke that pseudo-compatibility. The regulator driver now has the correct voltage table for both regulator versions and those the correct voltage can be used in the device tree. Signed-off-by: Stefan Agner ste...@agner.ch --- Changes since v3: - Check if version

[PATCH v5 0/3] regulator: tps6586x: add version detection and voltage tables

2013-12-06 Thread Stefan Agner
- Checked all voltages, fix SM0/SM1 (Core/CPU) and LDO6 voltage (VDAC/VI) in another commit - Rebased on top of v3.13-rc2 Stefan Agner (3): mfd: tps6586x: add version detection regulator: tps6586x: add and use correct voltage table ARM: tegra: correct Colibri T20 regulator settings

[PATCH] ARM: vf610: add UART choice for low-level debug

2014-03-03 Thread Stefan Agner
Add choice for low-level debug UART. Similar to i.MX6, there is a numeric configuration, valid choices are 0 to 3. Not that the kernel assumes that the boot loader initialized clock properly. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/Kconfig.debug | 9 + arch/arm

[PATCH v2] ARM: vf610: add UART choice for low-level debug

2014-03-05 Thread Stefan Agner
Add choice for low-level debug UART. Similar to i.MX6, there is a numeric configuration, valid choices are 0 to 3. Note that the kernel assumes that the boot loader initialized clock properly. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/Kconfig.debug | 9 + arch/arm

[PATCH] clocksource: vf_pit_timer: use complement for sched_clock reading

2014-03-05 Thread Stefan Agner
. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/clocksource/vf_pit_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clocksource/vf_pit_timer.c b/drivers/clocksource/vf_pit_timer.c index 02821b0..a918bc4 100644 --- a/drivers/clocksource/vf_pit_timer.c

[PATCH] ARM: tegra: don't timeout if CPU is powergated

2014-02-10 Thread Stefan Agner
When booting secondary CPU(s) which are not yet powergated, a wrong check lead to a timeout after 100 jiffies. With this patch, we only delay powergating if CPUs are still not powered yet. Signed-off-by: Stefan Agner ste...@agner.ch --- I happend to come accross this while working on Colibri T30

[PATCH] ARM: tegra: dalmore: fix irq trigger type

2014-02-11 Thread Stefan Agner
Trigger type needs to be IRQ_TYPE_LEVEL_HIGH since the interrupt signal gets inverted by the PMC (configured by the invert-interrupt property). Signed-off-by: Stefan Agner ste...@agner.ch --- I could not test that patch since I don't have such hardware. However, I stumbled on that error while

Re: [PATCH] ARM: tegra: dalmore: fix irq trigger type

2014-02-11 Thread Stefan Agner
Am 2014-02-11 21:47, schrieb Thierry Reding: On Tue, Feb 11, 2014 at 09:11:32PM +0100, Stefan Agner wrote: Trigger type needs to be IRQ_TYPE_LEVEL_HIGH since the interrupt signal gets inverted by the PMC (configured by the invert-interrupt property). Isn't the reason the other way around

Re: [PATCH v2 2/3] drm/panel: add support for EDT panels

2014-05-15 Thread Stefan Agner
Hi Thierry, hi Philipp, Am 2014-05-15 09:51, schrieb Thierry Reding: On Wed, May 14, 2014 at 11:45:57PM +0200, ste...@agner.ch wrote: From: Stefan Agner ste...@agner.ch This panels are sold by Toradex for Colibri T20/T30 and Apalis T30 evaluation kits. Signed-off-by: Stefan Agner ste

Re: [PATCH v2 2/3] drm/panel: add support for EDT panels

2014-05-15 Thread Stefan Agner
Am 2014-05-15 11:08, schrieb Thierry Reding: On Thu, May 15, 2014 at 10:27:29AM +0200, Philipp Zabel wrote: The ETM0700G0DH6 Datasheet lists 2 lines as the typical vsync pulse width, 525 lines as the vertical period, and 35 lines as the vsync -de time, which is vsync len + back porch. So

Re: [PATCH 2/2] ARM: tegra: initial add of Colibri T30

2014-05-14 Thread Stefan Agner
Am 2014-05-13 21:49, schrieb Stephen Warren: On 05/13/2014 11:27 AM, ste...@agner.ch wrote: +/* SPI1: Colibri SSP */ +spi@7000d400 { +status = okay; +spi-max-frequency = 2500; +can0: can@0 { +compatible = microchip,mcp2515;

Re: 3.12-rc5 and overwritten partition table - by powertop?

2014-01-20 Thread Stefan Agner
Am 2013-10-29 21:10, schrieb Jan Kara: The first ~170kb of /dev/sda got blown away with what seems to be a logging output by Powertop, when I was playing with the tuneables. (Luckily the first partition starts later :-)) So did you log the output to some file? I'm just trying to understand

Re: [PATCH v5 2/3] regulator: tps6586x: add and use correct voltage table

2013-12-06 Thread Stefan Agner
Am 2013-12-06 13:55, schrieb Mark Brown: On Fri, Dec 06, 2013 at 01:51:46PM +0100, Stefan Agner wrote: Depending on the regulator version, the voltage table might be different. Use version specific regulator tables in order to select correct voltage table. For the following regulator versions

Re: [PATCH v5 1/3] mfd: tps6586x: add version detection

2013-12-06 Thread Stefan Agner
Am 2013-12-06 15:26, schrieb Thierry Reding: On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote: Use the VERSIONCRC to determine the exact device version. According to the datasheet this register can be used as device identifier. The identification is needed since some tps6586x

[PATCH] ARM: dts: stmpe-ts: fix wrong bindings

2013-12-09 Thread Stefan Agner
Fix bindings for STMPE touchscreen device to match the documented bindings and the actual bindings used by the driver. Signed-off-by: Stefan Agner ste...@agner.ch --- I don't have any of these hardware, but the error is obvious. The device probably works anyway since the device/driver will use

Re: [RFC 2/2] mmc: use SD/MMC host ID for block device name ID

2014-04-01 Thread Stefan Agner
Am 2014-04-01 22:47, Stephen Warren wrote: That's not true. There's no guarantee that a device name/ID gets released as soon as the SD card is removed; something might still have it mounted for example. Yes. Also when booted there are other solutions to get static block device name (e.g.

Re: [PATCH] ARM: dts: stmpe-ts: fix wrong bindings

2014-04-02 Thread Stefan Agner
Am 2013-12-09 21:32, schrieb Marek Vasut: On Monday, December 09, 2013 at 09:15:11 PM, Stefan Agner wrote: Fix bindings for STMPE touchscreen device to match the documented bindings and the actual bindings used by the driver. Signed-off-by: Stefan Agner ste...@agner.ch --- I don't have any

[PATCH] can: flexcan: add vf61x support for flexcan

2014-07-11 Thread Stefan Agner
. Also extend the clock control for FlexCAN to enable the clocks in the Clock Divider (CCM_CSCDR2) register too. Signed-off-by: Stefan Agner ste...@agner.ch --- Marc, this patch requires your patch regarding clock enable for reading the ECR register: http://marc.info/?l=linux-canm=136861025221160w=2 So

Re: [PATCH] can: flexcan: add vf61x support for flexcan

2014-07-11 Thread Stefan Agner
Hi Marc, Am 2014-07-11 14:09, schrieb Marc Kleine-Budde: IMHO it should be 4 seperate patches: - dt - clocks - flexcan_get_berr_counter fixes - your flexcan enhancements Ok, will split. @@ -362,7 +374,7 @@ esdhc1: esdhc@400b2000 {

Re: [PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

2014-07-22 Thread Stefan Agner
Am 2014-07-22 04:22, schrieb Shawn Guo: On Fri, Jul 18, 2014 at 07:01:37PM +0200, Stefan Agner wrote: This adds USB PHY and USB controller nodes. Vybrid SoCs have two independent USB cores which each supports DR (dual role). However, real OTG is not supported since the OTG ID pin

Re: [PATCH] can: flexcan: add vf61x support for flexcan

2014-07-14 Thread Stefan Agner
Am 2014-07-14 08:04, schrieb Shawn Guo: On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote: @@ -362,7 +374,7 @@ esdhc1: esdhc@400b2000 { compatible = fsl,imx53-esdhc; - reg = 0x400b2000 0x4000

Re: [PATCH] can: flexcan: add vf61x support for flexcan

2014-07-14 Thread Stefan Agner
Am 2014-07-14 09:06, schrieb Stefan Agner: Am 2014-07-14 08:04, schrieb Shawn Guo: On Fri, Jul 11, 2014 at 03:58:37PM +0200, Stefan Agner wrote: @@ -362,7 +374,7 @@ esdhc1: esdhc@400b2000 { compatible = fsl,imx53-esdhc

[PATCH] ARM: dts: vf610: fix length of eshdc1 register property

2014-07-14 Thread Stefan Agner
Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 6cc314e..6a6190c 100644 --- a/arch/arm/boot/dts/vf610.dtsi +++ b/arch/arm/boot/dts

[PATCH v2 0/4] ARM: vf610: add FlexCAN support

2014-07-14 Thread Stefan Agner
related fix which enables clock in berr_counter Stefan Agner (4): ARM: dts: vf610: add FlexCAN node ARM: imx: clk-vf610: fix FlexCAN clock gating can: flexcan: switch on clocks before accessing ecr register can: flexcan: add vf610 support for FlexCAN arch/arm/boot/dts/vf610.dtsi | 23

[PATCH v2 3/4] can: flexcan: switch on clocks before accessing ecr register

2014-07-14 Thread Stefan Agner
Reported-by: Ashutosh Singh ashuleapy...@gmail.com Suggested-by: Marc Kleine-Budde m...@pengutronix.de [ste...@agner.ch: added return check for clk_enable_prepare] Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/net/can/flexcan.c | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH v2 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-14 Thread Stefan Agner
. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/net/can/flexcan.c | 73 +-- 1 file changed, 64 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 4c598c9..a0fc53e 100644 --- a/drivers/net/can

[PATCH v2 1/4] ARM: dts: vf610: add FlexCAN node

2014-07-14 Thread Stefan Agner
Add FlexCAN node for the two FlexCAN IP instances in Vybrid. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 3fb127a

[PATCH v2 2/4] ARM: imx: clk-vf610: fix FlexCAN clock gating

2014-07-14 Thread Stefan Agner
Extend the clock control for FlexCAN with the second gate which enable the clocks in the Clock Divider (CCM_CSCDR2) register too. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/mach-imx/clk-vf610.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach

Re: [PATCH v2 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-14 Thread Stefan Agner
Am 2014-07-14 10:07, schrieb Marc Kleine-Budde: snip +/* + * On Vybrid, disable memory error detection interrupts + * and freeze mode. + * This also works around errata e5295 which generates + * false positive memory errors and put the device in + * freeze mode. +

Re: [PATCH v2 2/4] ARM: imx: clk-vf610: fix FlexCAN clock gating

2014-07-14 Thread Stefan Agner
Am 2014-07-14 15:39, schrieb Shawn Guo: Copy Jingchang ... On Mon, Jul 14, 2014 at 09:48:29AM +0200, Stefan Agner wrote: Extend the clock control for FlexCAN with the second gate which enable the clocks in the Clock Divider (CCM_CSCDR2) register too. Signed-off-by: Stefan Agner ste

[PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-15 Thread Stefan Agner
. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/net/can/flexcan.c | 73 +-- 1 file changed, 64 insertions(+), 9 deletions(-) diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index 89745aa..1c31a5d 100644 --- a/drivers/net/can

[PATCH v3 3/4] can: flexcan: switch on clocks before accessing ecr register

2014-07-15 Thread Stefan Agner
Reported-by: Ashutosh Singh ashuleapy...@gmail.com Suggested-by: Marc Kleine-Budde m...@pengutronix.de [ste...@agner.ch: added return check for clk_enable_prepare] Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/net/can/flexcan.c | 18 -- 1 file changed, 16 insertions

[PATCH v3 2/4] ARM: imx: clk-vf610: fix FlexCAN clock gating

2014-07-15 Thread Stefan Agner
Extend the clock control for FlexCAN with the second gate which enable the clocks in the Clock Divider (CCM_CSCDR2) register too. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/mach-imx/clk-vf610.c | 6 -- include/dt-bindings/clock/vf610-clock.h | 4 +++- 2 files changed

[PATCH v3 0/4] ARM: vf610: add FlexCAN support

2014-07-15 Thread Stefan Agner
, clocks and driver changes) - Use spaces for hardware feature flags table - Remove drive-by change of esdhc register length - Added related fix which enables clock in berr_counter Stefan Agner (4): ARM: dts: vf610: add FlexCAN node ARM: imx: clk-vf610: fix FlexCAN clock gating can: flexcan

[PATCH v3 1/4] ARM: dts: vf610: add FlexCAN node

2014-07-15 Thread Stefan Agner
Add FlexCAN node for the two FlexCAN IP instances in Vybrid. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 23 +++ 1 file changed, 23 insertions(+) diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 3fb127a

[PATCH v2 0/7] vf610: Add USB support

2014-07-28 Thread Stefan Agner
patches to enable USB on Tower Stefan Agner (7): ARM: dts: vf610: Add USB PHY and controller ARM: imx: clk-vf610: Add USBPHY clocks usb: phy: mxs: Add VF610 USB PHY support ARM: dts: vf610: Add usbmisc for non-core registers chipidea: usbmisc_imx: Add USB support for VF610 SoCs ARM: dts

[PATCH v2 7/7] ARM: dts: vf610-twr: Add USB support

2014-07-28 Thread Stefan Agner
Add USB support for Freescale Vybrid tower. The USB hosts over-current protection signal is not connected is not connected to the PHY's over- current protection, hence we need to disable it. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610-twr.dts | 10 ++ 1 file

[PATCH v2 1/7] ARM: dts: vf610: Add USB PHY and controller

2014-07-28 Thread Stefan Agner
of the anadig registers. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 46 +--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 6a6190c..f36acb5 100644

[PATCH v2 6/7] ARM: dts: vf610-colibri: Add USB support

2014-07-28 Thread Stefan Agner
to disable the over-current functionality of the USB controller. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610-colibri.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/vf610-colibri.dts b/arch/arm/boot/dts/vf610-colibri.dts index aecc7db

[PATCH v2 5/7] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

2014-07-28 Thread Stefan Agner
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6, however, the non-core registers are spread in two different register areas. Hence we support multiple instances of the USB misc driver and add the driver instance to the imx_usbmisc_data structure. Signed-off-by: Stefan Agner

[PATCH v2 4/7] ARM: dts: vf610: Add usbmisc for non-core registers

2014-07-28 Thread Stefan Agner
Add device tree node for usbmisc which controls the non-core USB registers. This is required to use the property to disable the over- current detection. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 16 +++- 1 file changed, 15 insertions(+), 1

[PATCH v2 3/7] usb: phy: mxs: Add VF610 USB PHY support

2014-07-28 Thread Stefan Agner
] usb usb1-port1: unable to enumerate USB device Hence we also enable the MXS_PHY_NEED_IP_FIX flag. Signed-off-by: Stefan Agner ste...@agner.ch --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 + drivers/usb/phy/phy-mxs-usb.c | 6 ++ 2 files changed, 7 insertions

[PATCH v2 2/7] ARM: imx: clk-vf610: Add USBPHY clocks

2014-07-28 Thread Stefan Agner
This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Acked-by: Jingchang Lu jingchang...@freescale.com Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/mach-imx/clk-vf610.c | 12

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-28 Thread Stefan Agner
Am 2014-07-25 15:33, schrieb Marc Kleine-Budde: On 07/25/2014 12:50 PM, Stefan Agner wrote: Am 2014-07-16 08:43, schrieb Stefan Agner: Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: snip @@ -150,18 +171,20 @@ * FLEXCAN hardware feature flags * * Below is some version info we got

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-29 Thread Stefan Agner
Am 2014-07-28 18:28, schrieb Marc Kleine-Budde: On 07/28/2014 06:20 PM, Stefan Agner wrote: I'm not sure whether you really want to keep the FLEXCAN_CTRL_ERR_STATE commented out... No, please remove this change and redo the test. Ok, removed that change and did the tests again: == Wrong

[PATCH] ARM: imx: clk-vf610: introduce clks_init_on

2014-07-29 Thread Stefan Agner
clock and the DDR clock are initially enabled and are kept enabled. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/mach-imx/clk-vf610.c | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/mach-imx/clk-vf610.c b/arch/arm/mach-imx/clk-vf610.c index f60d6d5..a41ed73

Re: [PATCH] ARM: imx: clk-vf610: introduce clks_init_on

2014-07-29 Thread Stefan Agner
Am 2014-07-29 16:44, schrieb Arnd Bergmann: On Tuesday 29 July 2014 16:20:28 Stefan Agner wrote: At the end of the boot process, the clock framework might disable required main PLL's. So far, this was no issue since drivers requested clocks, which are descended of the main PLL's (e.g

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-16 Thread Stefan Agner
Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: snip @@ -150,18 +171,20 @@ * FLEXCAN hardware feature flags * * Below is some version info we got: - *SOC Version IP-Version Glitch- [TR]WRN_INT - *Filter? connected? - * MX25 FlexCAN2

[PATCH] ARM: dts: vf610-colibri: split device tree for carrier boards

2014-07-18 Thread Stefan Agner
standard. Also align the compatible naming, file splitting and file naming with the scheme which was choosen for the Tegra based modules. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/Makefile | 2 +- arch/arm/boot/dts/vf610-colibri-eval-v3.dts | 46

[PATCH 1/6] ARM: dts: vf610: add USB PHY and controller

2014-07-18 Thread Stefan Agner
of the anadig registers. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 46 +--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi index 6a6190c..f6c3f02 100644

[PATCH 2/6] ARM: imx: clk-vf610: add USBPHY clocks

2014-07-18 Thread Stefan Agner
This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Signed-off-by: Stefan Agner ste...@agner.ch --- All the main PLLs are currently turned on by boot ROM or boot loader, within the kernel we only set the fixed

[PATCH 0/6] vf610: Add USB support

2014-07-18 Thread Stefan Agner
investigating this. The second USB controller, running in USB host mode, showed no issues so far. Stefan Agner (6): ARM: dts: vf610: add USB PHY and controller ARM: imx: clk-vf610: add USBPHY clocks ARM: dts: vf610: Add usbmisc for non-core registers chipidea: usbmisc_imx: Add USB support

[PATCH 6/6] ARM: dts: vf610-colibri: add USB support

2014-07-18 Thread Stefan Agner
Add USB support for Colibri VF61 modules. Due to lack of pinmux options, the USB hosts over-current protection signal of the Colibri standard could not be connected to the PHY's over-current protection, hence we need to disable it. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot

[PATCH 3/6] ARM: dts: vf610: Add usbmisc for non-core registers

2014-07-18 Thread Stefan Agner
Add device tree node for usbmisc which controls the non-core USB registers. This is required to use the property to disable the over- current detection. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion

[PATCH 5/6] usb: phy: mxs: Add VF610 USB PHY support

2014-07-18 Thread Stefan Agner
This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. For all other flags, the presumption of innocence applies. Signed-off-by: Stefan Agner ste...@agner.ch --- drivers/usb/phy/phy-mxs-usb.c | 5 + 1 file changed, 5

[PATCH 4/6] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

2014-07-18 Thread Stefan Agner
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6, however the non-core registers are spread in two different register areas. Hence we support multiple registers which are addressed by the index of usbmisc. Signed-off-by: Stefan Agner ste...@agner.ch --- I tried first to create

Re: [PATCH v2 3/7] usb: phy: mxs: Add VF610 USB PHY support

2014-08-02 Thread Stefan Agner
Am 2014-08-02 02:36, schrieb Peter Chen: On Mon, Jul 28, 2014 at 04:57:29PM +0200, Stefan Agner wrote: This adds support for the USB PHY in Vybrid VF610. We assume that the disconnection without VBUS is also needed for Vybrid. Tests showed, without MXS_PHY_NEED_IP_FIX, enumeration of devices

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-07-25 Thread Stefan Agner
Am 2014-07-16 08:43, schrieb Stefan Agner: Am 2014-07-15 16:24, schrieb Marc Kleine-Budde: snip @@ -150,18 +171,20 @@ * FLEXCAN hardware feature flags * * Below is some version info we got: - *SOC Version IP-Version Glitch- [TR]WRN_INT

Re: [PATCH 0/6] vf610: Add USB support

2014-07-26 Thread Stefan Agner
Am 2014-07-22 02:13, schrieb Peter Chen: On Fri, Jul 18, 2014 at 07:01:36PM +0200, Stefan Agner wrote: This patchset adds USB support for Vybrid VF610 SoC. It extends the clock framework to support the USB PHY cocks, extends the device tree files and adds support for the non-core registers

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-04 Thread Stefan Agner
Am 2014-07-30 13:47, schrieb Marc Kleine-Budde: On 07/29/2014 09:29 AM, Stefan Agner wrote: Am 2014-07-28 18:28, schrieb Marc Kleine-Budde: On 07/28/2014 06:20 PM, Stefan Agner wrote: I'm not sure whether you really want to keep the FLEXCAN_CTRL_ERR_STATE commented out... No, please remove

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-04 Thread Stefan Agner
Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: On 08/04/2014 03:43 PM, Stefan Agner wrote: [...] Thanks for the test, so far looks promising :) With this setup the other CAN node repeats the CAN frame until it's ACKed. Because there is no node with a compatible bitrate, there is no ACking

Re: [PATCH v3 4/4] can: flexcan: add vf610 support for FlexCAN

2014-08-05 Thread Stefan Agner
Am 2014-08-05 11:52, schrieb Marc Kleine-Budde: On 08/04/2014 06:01 PM, Stefan Agner wrote: Am 2014-08-04 16:27, schrieb Marc Kleine-Budde: On 08/04/2014 03:43 PM, Stefan Agner wrote: [...] Thanks for the test, so far looks promising :) With this setup the other CAN node repeats the CAN

[PATCH RESEND v2 3/7] usb: phy: mxs: Add VF610 USB PHY support

2014-08-18 Thread Stefan Agner
] usb usb1-port1: unable to enumerate USB device Hence we also enable the MXS_PHY_NEED_IP_FIX flag. Acked-by: Peter Chen peter.c...@freescale.com Signed-off-by: Stefan Agner ste...@agner.ch --- Documentation/devicetree/bindings/usb/mxs-phy.txt | 1 + drivers/usb/phy/phy-mxs-usb.c

[PATCH RESEND v2 5/7] chipidea: usbmisc_imx: Add USB support for VF610 SoCs

2014-08-18 Thread Stefan Agner
This adds Vybrid VF610 SoC support. The IP is very similar to i.MX6, however, the non-core registers are spread in two different register areas. Hence we support multiple instances of the USB misc driver and add the driver instance to the imx_usbmisc_data structure. Signed-off-by: Stefan Agner

[PATCH RESEND v2 7/7] ARM: dts: vf610-twr: Add USB support

2014-08-18 Thread Stefan Agner
Add USB support for Freescale Vybrid tower. The USB hosts over-current protection signal is not connected is not connected to the PHY's over- current protection, hence we need to disable it. Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/boot/dts/vf610-twr.dts | 10 ++ 1 file

[PATCH RESEND v2 0/7] vf610: Add USB support

2014-08-18 Thread Stefan Agner
to support multiple instances - Update DT documentation and compatible strings where necessary - Add USB PHY flag MXS_PHY_NEED_IP_FIX - Added patches to enable USB on Tower Stefan Agner (7): ARM: dts: vf610: Add USB PHY and controller ARM: imx: clk-vf610: Add USBPHY clocks usb: phy: mxs: Add

[PATCH RESEND v2 2/7] ARM: imx: clk-vf610: Add USBPHY clocks

2014-08-18 Thread Stefan Agner
This commit adds PLL7 which is required for USBPHY1. It also adds the USB PHY and USB Controller clocks and the gates to enable them. Acked-by: Jingchang Lu jingchang...@freescale.com Signed-off-by: Stefan Agner ste...@agner.ch --- arch/arm/mach-imx/clk-vf610.c | 12

  1   2   3   4   5   6   7   8   9   10   >