Re: [PATCH v4] mmc: dw_mmc: add support for the other bit of sdio interrupt

2014-11-19 Thread Ulf Hansson
On 4 November 2014 15:03, Addy Ke addy...@rock-chips.com wrote: The bit of sdio interrupt is 16 in designware implementation, but it is 24 on Rockchip SoCs.This patch add sdio_id0 for the number of slot0 in the SDIO interrupt registers. Signed-off-by: Addy Ke addy...@rock-chips.com Thanks!

Re: [PATCH] mmc: dw_mmc: Add support for IMG Pistachio

2014-11-19 Thread Ulf Hansson
On 13 November 2014 19:50, Andrew Bresticker abres...@chromium.org wrote: Add support for the DW MMC host found on the Imagination Pistachio SoC. Like the DW MMC hosts found on SOCFPGA and Rockchip SoCs, the DW MMC host on Pistachio requires the use of SDMMC_CMD_USE_HOLD_REG. Signed-off-by:

Re: [PATCH v4 1/2] ARM: keystone: pm: switch to use generic pm domains

2014-11-20 Thread Ulf Hansson
On 19 November 2014 14:47, Arnd Bergmann a...@arndb.de wrote: On Wednesday 19 November 2014 13:32:45 Grygorii Strashko wrote: On 11/18/2014 09:32 PM, Arnd Bergmann wrote: On Tuesday 18 November 2014 20:54:36 Grygorii Strashko wrote: Have one pmdomain driver in the generic code that knows

Re: [PATCH v4 1/2] ARM: keystone: pm: switch to use generic pm domains

2014-11-20 Thread Ulf Hansson
On 20 November 2014 13:03, Grygorii Strashko grygorii.stras...@ti.com wrote: On 11/20/2014 01:34 PM, Ulf Hansson wrote: On 19 November 2014 14:47, Arnd Bergmann a...@arndb.de wrote: On Wednesday 19 November 2014 13:32:45 Grygorii Strashko wrote: On 11/18/2014 09:32 PM, Arnd Bergmann wrote

Re: [PATCH v3 2/3] mmc: mmci: Add sdio enable mask in variant data

2014-09-10 Thread Ulf Hansson
On 22 August 2014 06:54, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: This patch adds sdio enable mask in variant data, SOCs like ST have special bits in datactrl register to enable sdio. Unconditionally setting this bit in this driver breaks other SOCs like Qualcomm which maps

Re: [PATCH v3 3/3] mmc: mmci: rename sdio flag in vendor data to st_sdio

2014-09-10 Thread Ulf Hansson
On 22 August 2014 06:55, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: This patch renames sdio flag in vendor data to st_sdio, as this flag is only used to enable ST specific sdio setup. This will also ensure that the ST specfic setup is not done on other vendor like Qualcomm.

Re: [PATCH v3 1/3] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2014-09-10 Thread Ulf Hansson
On 22 August 2014 06:54, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant of the PL18x block, any block sizes are supported. This will make it possible to decrease data overhead for SDIO transfers. This patch is based

Re: [PATCH v3 1/3] mmc: mmci: Support any block sizes for ux500v2 and qcom variant

2014-09-10 Thread Ulf Hansson
On 10 September 2014 11:07, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: Hi Ulf, On 10/09/14 08:58, Ulf Hansson wrote: On 22 August 2014 06:54, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: From: Ulf Hansson ulf.hans...@linaro.org For the ux500v2 variant

[PATCH] [media] coda: Improve runtime PM support

2014-09-10 Thread Ulf Hansson
For several reasons it's good practice to leave devices in runtime PM active state while those have been probed. In this cases we also want to prevent the device from going inactive, until the firmware has been completely installed, especially when using a PM domain. Signed-off-by: Ulf Hansson

Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

2014-09-10 Thread Ulf Hansson
On 10 September 2014 15:24, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: On Wednesday 16 July 2014 11:53:21 Laurent Pinchart wrote: On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote: From: Xiang Wang wa...@marvell.com Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved

Re: [PATCH v4 0002/0003] mmc: Replace enhanced_area_en attribute by partition_setting_completed

2014-09-11 Thread Ulf Hansson
On 11 September 2014 08:38, Grégory Soutadé gsout...@neotion.com wrote: Replace ext_csd enhanced_area_en attribute by partition_setting_completed. It was used whether or not enhanced user area is defined and without checks of EXT_CSD_PARTITION_SETTING_COMPLETED bit. Signed-off-by: Grégory

Re: [PATCH v2] mmc:sdhci: handle busy-end interrupt during command

2014-09-02 Thread Ulf Hansson
On 30 August 2014 05:40, Chanho Min chanho@lge.com wrote: It is fully legal for a controller to start handling busy-end interrupt before it has signaled that the command has completed. So make sure we do things in the proper order, Or it results that command interrupt is ignored so it can

Re: [PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-03 Thread Ulf Hansson
On 2 September 2014 17:49, Jean-Michel Hautbois jean-michel.hautb...@vodalys.com wrote: This property is useful when we don't want to access boot partitions on eMMC Signed-off-by: Jean-Michel Hautbois jean-michel.hautb...@vodalys.com --- Documentation/devicetree/bindings/mmc/mmc.txt | 1 +

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Ulf Hansson
On 3 September 2014 01:58, Stephen Boyd sb...@codeaurora.org wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an

Re: [PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-03 Thread Ulf Hansson
On 3 September 2014 11:02, Adrian Hunter adrian.hun...@intel.com wrote: On 09/03/2014 11:30 AM, Ulf Hansson wrote: On 2 September 2014 17:49, Jean-Michel Hautbois jean-michel.hautb...@vodalys.com wrote: This property is useful when we don't want to access boot partitions on eMMC Signed-off

Re: [PATCH] mmc: sdhci-esdhc-imx: Enable boot partition access from DT

2014-09-04 Thread Ulf Hansson
Hi On 3 September 2014 15:08, Jean-Michel Hautbois jean-michel.hautb...@vodalys.com wrote: 2014-09-03 11:09 GMT+02:00 Ulf Hansson ulf.hans...@linaro.org: On 3 September 2014 11:02, Adrian Hunter adrian.hun...@intel.com wrote: On 09/03/2014 11:30 AM, Ulf Hansson wrote: On 2 September 2014 17

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Ulf Hansson
On 4 September 2014 07:06, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, Stephen. On 09/03/2014 10:57 PM, Stephen Boyd wrote: If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-21 Thread Ulf Hansson
[...] Sure If the first card is sd2.0 since startup, dw_mci_switch_voltage will not be called, That can't be right. mmc_power_up() should trigger dw_mci_switch_voltage() to be invoked. and card can be identified. But if UHS card is pulgged in first, the vqmmc will be down to 1.8v. when

Re: [PATCH 0/3] mmc: omap_hsmmc: make more use of mmc library functionality

2014-11-21 Thread Ulf Hansson
Thanks. What should I rebase against? Is 3.18-rc sufficient or is there some other tree I should work against? Thanks, NeilBrown git://git.linaro.org/people/ulf.hansson/mmc.git Kind regards Uffe -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region

2014-11-24 Thread Ulf Hansson
On 20 November 2014 at 15:45, lautriv laut...@coldplug.net wrote: From b0509e27e33326e6dccd67d8ebe67e2bdb0cfdde Mon Sep 17 00:00:00 2001 From: Helmut Stengele laut...@coldplug.net Date: Thu, 20 Nov 2014 15:27:40 +0100 Subject: [PATCH] mmc: wmt-sdmmc: fix unmatched release_mem_region Current

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-24 Thread Ulf Hansson
On 21 November 2014 at 22:04, Doug Anderson diand...@chromium.org wrote: Hi, On Fri, Nov 21, 2014 at 9:42 AM, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Nov 21, 2014 at 4:06 AM, Ulf Hansson ulf.hans...@linaro.org wrote: [...] Sure If the first card is sd2.0 since startup

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-16 Thread Ulf Hansson
On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux while card in the slot, the card power is already on, and rtsx-mmc driver have no chance to make card power off.

Re: [PATCH v5 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM

2014-09-16 Thread Ulf Hansson
On 16 September 2014 14:59, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: The AMBA bus driver defines runtime Power Management functions which disable and unprepare AMBA bus clock. This is problematic for runtime PM because unpreparing a clock might sleep so it is not interrupt safe.

Re: [PATCH v5 1/4] PM / Runtime: Add getter for quering the IRQ safe option

2014-09-16 Thread Ulf Hansson
of child driver (e.g. do not unprepare the clock if IRQ safe is not set). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Kind regards Uffe --- Documentation/power/runtime_pm.txt | 4 include/linux/pm_runtime.h | 6

Re: [PATCH/RFC v2 04/12] PM / Domains: Add genpd attach/detach callbacks

2014-09-17 Thread Ulf Hansson
); + int (*detach_dev)(struct generic_pm_domain *domain, struct device *dev); }; static inline struct generic_pm_domain *pd_to_genpd(struct dev_pm_domain *pd) -- 1.9.1 This is great stuff, exactly what I had in mind! :-) Reviewed-by: Ulf Hansson ulf.hans...@linaro.org

Re: [PATCH v5 3/4] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM

2014-09-17 Thread Ulf Hansson
On 16 September 2014 21:52, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Sep 16, 2014 at 08:25:25PM +0200, Ulf Hansson wrote: On 16 September 2014 14:59, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: The AMBA bus driver defines runtime Power Management functions which

Re: [PATCH v4 4/4] dma: pl330: add Power Management support

2014-09-17 Thread Ulf Hansson
On 16 September 2014 10:51, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: This patch adds both normal PM suspend/resume support and runtime PM support to pl330 DMA engine driver. The runtime power management for pl330 DMA driver allows gating of AMBA clock (PDMA) in FSYS clock domain,

Re: [PATCH] frv: Remove unused cpuinfo_frv and friends to fix future build error

2014-09-17 Thread Ulf Hansson
On 16 September 2014 21:54, Geert Uytterhoeven geert+rene...@glider.be wrote: Frv has a macro named cpu_data, interfering with variables and struct members with the same name: include/linux/pm_domain.h:75:24: error: expected identifier or '(' before '' token struct gpd_cpu_data *cpu_data;

Re: [PATCH] mmc: rtsx: add card power off during probe

2014-09-17 Thread Ulf Hansson
On 17 September 2014 11:11, micky micky_ch...@realsil.com.cn wrote: On 09/17/2014 02:01 AM, Ulf Hansson wrote: On 12 September 2014 03:39, micky_ch...@realsil.com.cn wrote: From: Roger Tseng rogera...@realtek.com Some platform have both UEFI driver and MFD/mmc driver, if entering linux

Re: [PATCH] mmc: don't request CD IRQ until mmc_start_host()

2014-09-17 Thread Ulf Hansson
On 12 September 2014 19:18, Stephen Warren swar...@wwwdotorg.org wrote: From: Stephen Warren swar...@nvidia.com As soon as the CD IRQ is requested, it can trigger, since it's an externally controlled event. If it does, delayed_work host-detect will be scheduled. Many host controller

Re: [PATCH v6 0001/0003] mmc: Move code that manages user area and gp partitions into functions

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé gsout...@neotion.com wrote: Move code that manages user area and general purpose partitions into functions. Signed-off-by: Grégory Soutadé gsout...@neotion.com Thanks! Applied for next. Kind regards Uffe --- drivers/mmc/core/mmc.c | 162

Re: [PATCH v6 0002/0003] mmc: Replace enhanced_area_en attribute by partition_setting_completed

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé gsout...@neotion.com wrote: Replace ext_csd enhanced_area_en attribute by partition_setting_completed. It was used whether or not enhanced user area is defined and without checks of EXT_CSD_PARTITION_SETTING_COMPLETED bit. Signed-off-by: Grégory

Re: [PATCH v6 0003/0003] mmc: Checks EXT_CSD_PARTITION_SETTING_COMPLETED before partitions computation

2014-09-17 Thread Ulf Hansson
On 15 September 2014 17:47, Grégory Soutadé gsout...@neotion.com wrote: Checks EXT_CSD_PARTITION_SETTING_COMPLETED bit before computing enhanced user area offset and size, and adding mmc general purpose partitions. The two needs EXT_CSD_PARTITION_SETTING_COMPLETED bit be set to be valid

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Ulf Hansson
2014-09-15 23:45 GMT+02:00 Stephen Boyd sb...@codeaurora.org: On 09/04/14 15:01, Stephen Boyd wrote: 8 From: Stephen Boyd sb...@codeaurora.org Subject: [PATCH] mmc: Consolidate emmc tuning blocks The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c files. Move these

Re: [PATCH v3 02/13] PM / Domains: Add DT bindings for power-on/off latencies

2014-09-26 Thread Ulf Hansson
...@glider.be Acked-by: Kevin Hilman khil...@linaro.org Reviewed-by: Ulf Hansson ulf.hans...@linaro.org --- v3: - No changes v2: - Add Acked-by Documentation/devicetree/bindings/power/power_domain.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree

Re: [PATCH v3 03/13] PM / Domains: Add DT bindings for PM QoS device latencies

2014-09-26 Thread Ulf Hansson
On 25 September 2014 18:28, Geert Uytterhoeven geert+rene...@glider.be wrote: PM QoS device start/stop and save/restore state latencies are more or less properties of the hardware. In legacy code, they're specified from platform code. On DT platforms, their values should come from DT. I am

Re: [PATCH v3 04/13] PM / Domains: Add DT bindings for the R-Mobile System Controller

2014-09-26 Thread Ulf Hansson
On 25 September 2014 18:28, Geert Uytterhoeven geert+rene...@glider.be wrote: The Renesas R-Mobile System Controller provides a.o. power management support, following the generic PM domain bindings in Documentation/devicetree/bindings/power/power_domain.txt. For now this supports the R-Mobile

Re: [PATCH v3 05/13] PM / Domains: Add helper variable np = dev-of_node

2014-09-26 Thread Ulf Hansson
On 25 September 2014 18:28, Geert Uytterhoeven geert+rene...@glider.be wrote: Why? Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Normally I think this kind of cleanup patches is a bit unnecessary, but I don't have strong opinions. Kind regards Uffe --- v3: - No changes v2:

Re: [PATCH v3 07/13] ARM: shmobile: R-Mobile: Use generic_pm_domain.attach_dev() for pm_clk setup

2014-09-26 Thread Ulf Hansson
-by: Ulf Hansson ulf.hans...@linaro.org --- v3: - Update for callback signature changes, v2: - New arch/arm/mach-shmobile/pm-rmobile.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-shmobile/pm-rmobile.c b/arch/arm/mach-shmobile/pm

Re: [PATCH v3 08/13] ARM: shmobile: R-Mobile: Store SYSC base address in rmobile_pm_domain

2014-09-26 Thread Ulf Hansson
from DT. Signed-off-by: Geert Uytterhoeven geert+rene...@glider.be Reviewed-by: Ulf Hansson ulf.hans...@linaro.org --- v3: - No changes v2: - No changes arch/arm/mach-shmobile/pm-r8a7740.c | 14 ++ arch/arm/mach-shmobile/pm-rmobile.c | 24 +--- arch

Re: [PATCH] mmc: atmel-mci: fix mismatched section on atmci_cleanup_slot

2014-09-29 Thread Ulf Hansson
On 26 September 2014 21:34, Arnd Bergmann a...@arndb.de wrote: As of 528bc7808f4e (mmc: atmel-mci: Release mmc resources on failure in probe), the atmci_probe() function calls atmci_cleanup_slot in the failure path. This causes a new warning whenever the driver is built: WARNING:

Re: [PATCH v3] mmc: add Toshiba PCI SD controller driver

2014-11-10 Thread Ulf Hansson
On 7 November 2014 22:54, Ondrej Zary li...@rainbow-software.org wrote: This patch resurrects an old never-finished driver for Toshiba PCI SD controllers found in some older Toshiba laptops (such as Portege R100): 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA

Re: [PATCH v2] mmc: atmel-mci: adopt pinctrl support

2014-11-10 Thread Ulf Hansson
On 7 November 2014 01:48, Wenyou Yang wenyou.y...@atmel.com wrote: Amend the atmel mci pin controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume and before performing an transfer. - sleep on suspend(). This should make it possible to

Re: [PATCH 2/2] mmc: core: reset sdio card properly on resume.

2014-11-10 Thread Ulf Hansson
On 8 November 2014 01:14, NeilBrown ne...@suse.de wrote: mmc_sdio_power_restore calls mmc_send_if_cond(host, host-ocr_avail); ret = mmc_send_io_op_cond(host, 0, NULL); between mmc_go_idle() and mmc_sdio_init_card(). mmc_sdio_resume needs to as well, else my libertas sdio

Re: [PATCH v10 1/5] PM / Runtime: Allow accessing irq_safe if no PM_RUNTIME

2014-11-10 Thread Ulf Hansson
On 7 November 2014 09:06, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On czw, 2014-11-06 at 23:51 +0100, Rafael J. Wysocki wrote: On Thursday, November 06, 2014 09:36:46 AM Krzysztof Kozlowski wrote: Some drivers (e.g. bus drivers) may want to check if power.irq_safe was called by

Re: [PATCH v10 1/5] PM / Runtime: Allow accessing irq_safe if no PM_RUNTIME

2014-11-10 Thread Ulf Hansson
On 7 November 2014 15:50, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 7 Nov 2014, Krzysztof Kozlowski wrote: Well, that is a good reason to introduce a wrapper around power.irq_safe in my view. And define the wrapper so that it always returns false for CONFIG_PM_RUNTIME

Re: [PATCH v10 1/5] PM / Runtime: Allow accessing irq_safe if no PM_RUNTIME

2014-11-10 Thread Ulf Hansson
On 10 November 2014 17:36, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 10 Nov 2014, Ulf Hansson wrote: To me, this sounds like a good reason to avoid using force_runtime_suspend(). In fact, it sounds like a good reason to avoid relying on the runtime PM mechanism to handle non

Re: [PATCH 2/2] mmc: core: reset sdio card properly on resume.

2014-11-11 Thread Ulf Hansson
On 11 November 2014 01:17, NeilBrown ne...@suse.de wrote: On Mon, 10 Nov 2014 14:29:19 +0100 Ulf Hansson ulf.hans...@linaro.org wrote: On 8 November 2014 01:14, NeilBrown ne...@suse.de wrote: mmc_sdio_power_restore calls mmc_send_if_cond(host, host-ocr_avail); ret

Re: [PATCH] mmc: dw_mmc: try pick the exact same voltage as vmmc for vqmmc

2014-11-11 Thread Ulf Hansson
On 11 November 2014 05:02, Addy Ke addy...@rock-chips.com wrote: SD2.0 cards need vqmmc and vmmc to be the same. No, that's not correct. If I remember the spec correctly, the bus signal threshold is 0.75 * VDD. But vqmmc call regulator_set_voltage to set min_uv(2.7v) as far as possible. I

Re: [PATCH v4] mmc: add Toshiba PCI SD controller driver

2014-11-11 Thread Ulf Hansson
On 10 November 2014 17:58, Ondrej Zary li...@rainbow-software.org wrote: This patch resurrects an old never-finished driver for Toshiba PCI SD controllers found in some older Toshiba laptops (such as Portege R100): 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA

Re: [PATCH v4] mmc: add Toshiba PCI SD controller driver

2014-11-11 Thread Ulf Hansson
On 11 November 2014 12:30, Ondrej Zary li...@rainbow-software.org wrote: On Tuesday 11 November 2014, Ulf Hansson wrote: On 10 November 2014 17:58, Ondrej Zary li...@rainbow-software.org wrote: This patch resurrects an old never-finished driver for Toshiba PCI SD controllers found in some

Re: [PATCH 0/2] mmc: core: power-on sdio card correctly.

2014-11-12 Thread Ulf Hansson
On 12 November 2014 04:55, NeilBrown ne...@suse.de wrote: These two patches replace my previous patch [PATCH 2/2] mmc: core: reset sdio card properly on resume. The only change is to use host-card-ocr instead of host-ocr_avail, as recommend by Ulf. These restore my libertas wifi device

Re: [PATCH v5] mmc: add Toshiba PCI SD controller driver

2014-11-12 Thread Ulf Hansson
On 11 November 2014 17:54, Ondrej Zary li...@rainbow-software.org wrote: This patch resurrects an old never-finished driver for Toshiba PCI SD controllers found in some older Toshiba laptops (such as Portege R100): 02:0d.0 System peripheral [0880]: Toshiba America Info Systems SD TypA

Re: [PATCH] mmc: dw_mmc: add support for ARM64

2014-11-12 Thread Ulf Hansson
On 29 August 2014 12:24, Alim Akhtar alim.akh...@samsung.com wrote: There are upcoming ARM64 SoCs with dw_mmc host controller. Signed-off-by: Alim Akhtar alim.akh...@samsung.com Thanks! Applied for next. Kind regards Uffe --- drivers/mmc/host/Kconfig |2 +- 1 file changed, 1

Re: [PATCH v11 3/6] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM

2014-11-12 Thread Ulf Hansson
-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/amba/bus.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c index a4ac490dd784..c2153a1d1981 100644 --- a/drivers/amba/bus.c +++ b/drivers/amba/bus.c @@ -95,8 +95,12

Re: [PATCH v11 5/6] dmaengine: pl330: Add PM sleep support

2014-11-12 Thread Ulf Hansson
On 12 November 2014 15:32, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add system suspend/resume capabilities to the pl330 driver so the amba bus clock could be also unprepared to conserve energy. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/dma/pl330.c | 37

Re: [PATCH v11 5/6] dmaengine: pl330: Add PM sleep support

2014-11-13 Thread Ulf Hansson
On 13 November 2014 02:37, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, November 12, 2014 03:32:27 PM Krzysztof Kozlowski wrote: Add system suspend/resume capabilities to the pl330 driver so the amba bus clock could be also unprepared to conserve energy. Signed-off-by: Krzysztof

Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled

2014-11-13 Thread Ulf Hansson
? Cc: Ulf Hansson ulf.hans...@linaro.org Cc: Geert Uytterhoeven geert+rene...@glider.be Cc: Grygorii Strashko grygorii.stras...@ti.com Signed-off-by: Kevin Hilman khil...@linaro.org --- kernel/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power

Re: [PATCH] PM / domains: Kconfig: always enable PM_RUNTIME when genpd enabled

2014-11-13 Thread Ulf Hansson
On 14 November 2014 08:26, Ulf Hansson ulf.hans...@linaro.org wrote: On 13 November 2014 23:28, Kevin Hilman khil...@kernel.org wrote: From: Kevin Hilman khil...@linaro.org It makes little sense to use generic power domains without runtime PM. Also, since the complexities of handling

Re: [PATCH] PM / Runtime: Kconfig: move ia64 dependency to arch/ia64/Kconfig

2014-11-13 Thread Ulf Hansson
since commit 1eb208aea317 (PM: Make CONFIG_PM depend on (CONFIG_PM_SLEEP || CONFIG_PM_RUNTIME)) is effectively a noop unless PM_SLEEP or PM_RUNTIME are set elsewhere. Signed-off-by: Kevin Hilman khil...@linaro.org Reviewed-by: Ulf Hansson ulf.hans...@linaro.org --- arch/ia64/Kconfig| 1

Re: [PATCH v12 5/6] dmaengine: pl330: Add PM sleep support

2014-11-14 Thread Ulf Hansson
On 14 November 2014 09:50, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add system suspend/resume capabilities to the pl330 driver so the amba bus clock could be also unprepared to conserve energy. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/dma/pl330.c | 41

Re: [PATCH v12 5/6] dmaengine: pl330: Add PM sleep support

2014-11-14 Thread Ulf Hansson
On 14 November 2014 14:47, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On pią, 2014-11-14 at 14:31 +0100, Ulf Hansson wrote: On 14 November 2014 09:50, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add system suspend/resume capabilities to the pl330 driver so the amba bus clock

Re: [PATCH v4 4/4] dma: pl330: add Power Management support

2014-09-23 Thread Ulf Hansson
On 18 September 2014 12:09, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On śro, 2014-09-17 at 20:42 +0200, Ulf Hansson wrote: On 16 September 2014 10:51, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: [...] @@ -2585,6 +2620,34 @@ static int pl330_dma_device_slave_caps(struct

Re: [PATCH] mmc: Convert pr_warning to pr_warn

2014-09-24 Thread Ulf Hansson
On 12 September 2014 23:56, Joe Perches j...@perches.com wrote: Use the much more common pr_warn instead of pr_warning. Other miscellanea: o Coalesce formats o Realign arguments o Remove extra spaces when coalescing formats Signed-off-by: Joe Perches j...@perches.com Thanks! Applied for

Re: [PATCH v2 1/2] mmc: atmel-mci: Switch to using managed resource in probe

2014-09-24 Thread Ulf Hansson
labels and remove function. Acked-by: Ludovic Desroches ludovic.desroc...@atmel.com Cc: Ludovic Desroches ludovic.desroc...@atmel.com Cc: Chris Ball ch...@printf.net Cc: Ulf Hansson ulf.hans...@linaro.org Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com

Re: [PATCH v2 2/2] mmc: atmel-mci: Release mmc resources on failure in probe

2014-09-24 Thread Ulf Hansson
...@printf.net Cc: Ulf Hansson ulf.hans...@linaro.org Cc: linux-...@vger.kernel.org Signed-off-by: Pramod Gurav pramod.gu...@smartplayin.com Thanks! Applied for next. Kind regards Uffe --- Changes since v1: None drivers/mmc/host/atmel-mci.c | 11 +-- 1 file changed, 9 insertions(+), 2

Re: [PATCH 1/2] mmc: core: Add new power_mode MMC_POWER_UNDEFINED

2014-09-24 Thread Ulf Hansson
On 24 September 2014 11:07, Roger Tseng rogera...@realtek.com wrote: Define new macro MMC_POWER_UNDEFINED for power_mode in struct mmc_ios. It will also be set as the initial value of host-ios.power_mode in mmc_start_host(). For hosts with MMC_CAP2_NO_PRESCAN_POWERUP, this makes the later

Re: [PATCH 2/2] mmc: rtsx_pci: Set power related cap2 macros

2014-09-24 Thread Ulf Hansson
On 24 September 2014 11:07, Roger Tseng rogera...@realtek.com wrote: Set MMC_CAP2_NO_PRESCAN_POWERUP and MMC_CAP2_FULL_PWR_CYCLE for rtsx_pci_sdmmc and rtsx_usb_sdmmc to reflect properties of Realtek card reader hosts. Signed-off-by: Roger Tseng rogera...@realtek.com Thanks! Applied for

Re: [PATCH v7 1/5] PM / Runtime: Add getter for quering the IRQ safe option

2014-09-25 Thread Ulf Hansson
...@samsung.com Reviewed-by: Ulf Hansson ulf.hans...@linaro.org Are you sure this is good interface? Tell me if another function works this or that way. That's certainly not traditional interface, and it seems dangerous to me. Callbacks now have different semantic requirements based

Re: [PATCH 01/27] PM: Add helper pm_runtime_last_busy_and_autosuspend()

2014-09-25 Thread Ulf Hansson
On 24 September 2014 18:14, Vinod Koul vinod.k...@intel.com wrote: From: Subhransu S. Prusty subhransu.s.pru...@intel.com pm_runtime_mark_last_busy and pm_runtime_put_autosuspend are used together in quite a lot of places. Add a helper for these. Also updated Documentation for this

Re: [PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-23 Thread Ulf Hansson
On 23 December 2014 at 09:48, NeilBrown ne...@suse.de wrote: On Mon, 22 Dec 2014 16:35:40 +0100 Ulf Hansson ulf.hans...@linaro.org wrote: On 20 December 2014 at 00:07, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non

Re: [PATCH v5 0/6] mmc: rtsx: add support for sdio card

2014-12-23 Thread Ulf Hansson
On 23 December 2014 at 02:19, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn v5: fix patch(5) building error, no code change diff v4. v4: split patch in more detailed patches. no code changes diff v3. v3: rtsx_pci_sdmmc.c: - dump_reg_range

Re: [PATCH 2/3] mmc: host: don't use devm_pinctrl_get_select_default() in probe

2014-12-23 Thread Ulf Hansson
On 22 December 2014 at 23:16, Wolfram Sang w...@the-dreams.de wrote: Since commit ab78029ecc34 (drivers/pinctrl: grab default handles from device core), we can rely on device core for setting the default pins. Signed-off-by: Wolfram Sang w...@the-dreams.de Thanks! Applied for next, with an

[GIT PULL] MMC fixes for v.3.19

2014-12-29 Thread Ulf Hansson
Hi Linus, Here is one mmc fix for 3.19. Details are as usual found in the signed tag. Please pull this in! Kind regards Ulf Hansson The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672: Linux 3.19-rc1 (2014-12-20 17:08:50 -0800) are available in the git repository

Re: [PATCH v5 0/4] Fixes for SDIO interrupts for dw_mmc

2014-12-30 Thread Ulf Hansson
On 19 December 2014 at 20:02, Doug Anderson diand...@chromium.org wrote: Ulf, On Fri, Dec 19, 2014 at 2:17 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 3 December 2014 at 00:42, Doug Anderson diand...@chromium.org wrote: Bing Zhao at Marvell found a problem with dw_mmc where interrupts

Re: [PATCH 1/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-30 Thread Ulf Hansson
On 24 December 2014 at 22:20, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non-standard functionality in the card-detect interrupt service routine. To make it possible for omap_hsmmc (and maybe others) to be converted to

Re: [PATCH RFC v2 06/12] driver: soc: exynos-pmu: Add exynos7 power domain on/off ops

2014-11-24 Thread Ulf Hansson
On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch uses the restructuring done in PD handlers and adds PD on/off/status handlers for exynos7. In this SoC, some extra settings need to be done prior to turning on/off power domains. Some of those settings

Re: [PATCH RFC v2 07/12] PM / Domains: export pm_genpd_lookup_name

2014-11-24 Thread Ulf Hansson
On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This API may be needed to set the power domain parent/child relationship in the power domain platform driver. The parent relationship is generally set after the child power domain is registered with the power

Re: [PATCH RFC v2 08/12] soc: samsung: pm_domain: Add support for parent power domain

2014-11-24 Thread Ulf Hansson
On 24 November 2014 at 14:04, Amit Daniel Kachhap amit.dan...@samsung.com wrote: This patch adds supports for parent power domain. This will ensure invoking of parent/child power domain on/off in a correct sequence. In exynos7 SOC's, power domain controllers have parent and child hierarchy.

Re: [PATCH 0/4] PM: Use CONFIG_PM instead of CONFIG_PM_RUNTIME in core code

2014-11-27 Thread Ulf Hansson
On 27 November 2014 at 01:37, Rafael J. Wysocki r...@rjwysocki.net wrote: Hi, After commit b2b49ccbdd54 PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (currently in Linux next) CONFIG_PM_RUNTIME is set whenever CONFIG_PM is set, so CONFIG_PM can be used in #ifdefs instead of

Re: [PATCH 0/4] PM: Use CONFIG_PM instead of CONFIG_PM_RUNTIME in core code

2014-11-27 Thread Ulf Hansson
On 27 November 2014 at 09:57, Ulf Hansson ulf.hans...@linaro.org wrote: On 27 November 2014 at 01:37, Rafael J. Wysocki r...@rjwysocki.net wrote: Hi, After commit b2b49ccbdd54 PM: Kconfig: Set PM_RUNTIME if PM_SLEEP is selected (currently in Linux next) CONFIG_PM_RUNTIME is set whenever

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-11 Thread Ulf Hansson
On 11 December 2014 at 09:26, Tomasz Figa tf...@chromium.org wrote: This patch modifies the rockchip-iommu driver to consider state of the power domain the IOMMU is located in. When the power domain is powered off, the IOMMU cannot be accessed and register programming must be deferred until

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-11 Thread Ulf Hansson
On 11 December 2014 at 13:42, Tomasz Figa tf...@chromium.org wrote: Hi Ulf, On Thu, Dec 11, 2014 at 8:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: On 11 December 2014 at 09:26, Tomasz Figa tf...@chromium.org wrote: This patch modifies the rockchip-iommu driver to consider state

Re: [RFC PATCH 1/2] pm: Add PM domain notifications

2014-12-11 Thread Ulf Hansson
On 11 December 2014 at 14:54, Sylwester Nawrocki s.nawro...@samsung.com wrote: On 11/12/14 12:04, Tomasz Figa wrote: ... On 11/12/14 09:26, Tomasz Figa wrote: From: Sylwester Nawrocki s.nawro...@samsung.com This patch adds notifiers to the runtime PM/genpd subsystem. It is now

Re: [RFC PATCH 2/2] iommu: rockchip: Handle system-wide and runtime PM

2014-12-11 Thread Ulf Hansson
On 11 December 2014 at 16:31, Kevin Hilman khil...@kernel.org wrote: [+ Laurent Pinchart] Tomasz Figa tf...@chromium.org writes: On Thu, Dec 11, 2014 at 8:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote: [...] @@ -988,11 +1107,28 @@ static int rk_iommu_probe(struct platform_device *pdev

Re: [Patch] Improve error handling in allocation of bounce buffers in mmc_init_queue

2014-12-02 Thread Ulf Hansson
On 1 December 2014 at 12:56, Bhuvanesh bhuvanesh_surach...@mentor.com wrote: Hi, Please find the patch inline. Apparently you didn't read /Documentation/SubmittingPatches. If you want me to review, please follow that guide. For example, I expect you to run checkpatch. Kind regards Uffe --

Re: [PATCH 1/2] mmc: core: allow a reset gpio to be configured.

2014-12-02 Thread Ulf Hansson
On 2 December 2014 at 02:55, NeilBrown ne...@suse.de wrote: On Fri, 28 Nov 2014 12:56:33 +0100 Ulf Hansson ulf.hans...@linaro.org wrote: On 8 November 2014 at 01:14, NeilBrown ne...@suse.de wrote: If the regulator supplying an SDIO device is shared with another device, the turning

Re: [Patch] Improve error handling in allocation of bounce buffers in mmc_init_queue

2014-12-03 Thread Ulf Hansson
)); + kfree(mqrq_cur-bounce_buf); + mqrq_cur-bounce_buf = NULL; + } } } -- 1.7.9.5 Thank you, Regards, Bhuvanesh On 12/02/2014 05:01 PM, Ulf Hansson

Re: [PATCH] mmc: queue:Improve error handling during allocation of bounce buffers.

2014-12-03 Thread Ulf Hansson
On 3 December 2014 at 11:36, Bhuvanesh bhuvanesh_surach...@mentor.com wrote: Hi, During our rigorous testing of inserting and removing SD card we found exception in the kernel. Please find the backtrace as below: [ 1605.392278] Backtrace: [ 1605.395466] [800117c4]

Re: [PATCH 1/4] PM: Drop the SET_PM_RUNTIME_PM_OPS() macro

2014-12-03 Thread Ulf Hansson
On 27 November 2014 at 01:38, Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com The SET_PM_RUNTIME_PM_OPS() and SET_RUNTIME_PM_OPS() macros are identical except that one of them is not empty for CONFIG_PM set, while the other one is not empty for

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-18 Thread Ulf Hansson
the tree. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com I am impressed , in this short period of time we managed to remove all *PM_RUNTIME configurations! Great work! Reviewed-by: Ulf Hansson ulf.hans...@linaro.org --- arch/arm/configs/ape6evm_defconfig |2 +- arch

Re: [PATCH v5 0/4] Fixes for SDIO interrupts for dw_mmc

2014-12-19 Thread Ulf Hansson
On 3 December 2014 at 00:42, Doug Anderson diand...@chromium.org wrote: Bing Zhao at Marvell found a problem with dw_mmc where interrupts weren't firing sometimes. He tracked it down to a read-modify-write problem with the INTMASK. These patches fix the problem. Note: I've picked up a

Re: [PATCH v4 0/6] mmc: rtsx: add support for sdio card

2014-12-19 Thread Ulf Hansson
On 5 December 2014 at 06:54, micky_ch...@realsil.com.cn wrote: From: Micky Ching micky_ch...@realsil.com.cn v4: split patch in more detailed patches. no code changes diff v3. v3: rtsx_pci_sdmmc.c: - dump_reg_range - remove unused pointer check - fix start index v2:

Re: [PATCH 2/3] mmc: omap_hsmmc: use slot-gpio library for gpio support.

2014-12-19 Thread Ulf Hansson
On 11 December 2014 at 22:43, NeilBrown ne...@suse.de wrote: Using the common code removes some code duplication, and makes it easier to switch to using mmc_of_parse() which will remove more duplication. As hsmmc has a slightly different interrupt service routine for card-detect, enhance

Re: [PATCH 1/3] mmc: omap_hsmmc: remove prepare/complete system suspend support.

2014-12-19 Thread Ulf Hansson
On 11 December 2014 at 22:43, NeilBrown ne...@suse.de wrote: The only function of these 'prepare' and 'complete' is to disable the 'card detect' irq during suspend. The commit which added this, commit a48ce884d5819d5df2cf1139ab3c43f8e9e419b3 mmc: omap_hsmmc: Introduce

Re: [PATCH] mmc: dt: Add property for broken hs200 quirk

2014-12-19 Thread Ulf Hansson
On 12 December 2014 at 20:28, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some more explanation to why this needed would be good. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Documentation/devicetree/bindings/mmc/mmc.txt | 2 ++ This file lists the generic mmc

Re: [PATCH 0/4] mmc: sunxi: General fixup (v2)

2014-12-19 Thread Ulf Hansson
On 16 December 2014 at 15:10, David Lanzendörfer david.lanzendoer...@o2s.ch wrote: Hello This patchset was inspired questions from 李想 of Allwinner and incorporates as well suggestions from Hans related to spin locks. For example have not all attributes of the shared host object been protected

Re: [PATCH] mmc: core: stop trying to switch width when only one bit is supported

2014-12-22 Thread Ulf Hansson
On 17 December 2014 at 19:32, Alexandre Belloni alexandre.bell...@free-electrons.com wrote: mmc_select_bus_width() will try to switch to MMC_BUS_WIDTH_4 even if MMC_CAP_4_BIT_DATA and MMC_CAP_8_BIT_DATA are not set in host-caps. Return as soon as possible when those flags are not set Fixes:

Re: [PATCH] mmc: dt: Add property for broken hs200 quirk

2014-12-22 Thread Ulf Hansson
On 19 December 2014 at 21:01, Bjorn Andersson bj...@kryo.se wrote: On Fri, Dec 19, 2014 at 3:38 AM, Ulf Hansson ulf.hans...@linaro.org wrote: On 12 December 2014 at 20:28, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Some more explanation to why this needed would be good. Because

Re: [PATCH 2a/3] mmc: core: Allow host driver to provide isr for card-detect interrupts.

2014-12-22 Thread Ulf Hansson
On 20 December 2014 at 00:07, NeilBrown ne...@suse.de wrote: One of the reasons omap_hsmmc doesn't use the slot-gpio library is that it has some non-standard functionality in the card-detect interrupt service routine. To make it possible for omap_hsmmc (and maybe others) to be converted to

<    1   2   3   4   5   6   7   8   9   10   >