-us.net
Acked-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux
|| hm m) t hm) ||
+(t !watchdog_active(wdd) watchdog_running(wdd));
What is the meaning of
!t !watchdog_active(wdd) watchdog_running(wdd)
? Can this happen at all? If not, drop t ?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König
of devm_gpiod_get to simplify error
handling (which also gets more strict for free).
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello,
this is needed on top of commit 0395ffc1ee05 (Bluetooth: hci_bcm: Add
PM for BCM devices) incombination with b17d1bf16cc7 (gpio: make flags
mandatory
into next?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
From: Uwe Kleine-König u...@kleine-koenig.org
When a platform driver doesn't provide a .remove callback the function
platform_drv_remove isn't called and so the call to dev_pm_domain_attach
called at probe time isn't paired by dev_pm_domain_detach at remove
time.
To fix this (and similar issues
with the additional flags parameter
it should already now work for you. So if your change goes in before the
gpio change (which only makes the flags parameter mandatory) everything
is fine. Not sure this makes it easier though.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König
this commit is in,
needs to also take this fix.
It is in Linus's tree. The Walleij one though, not Torvalds :-)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe
From: Uwe Kleine-König u.kleine-koe...@pengutronix.de
The gpiod functions include variants for managed gpiod resources. Use it
to simplify the remove function.
As the driver handles a device node without a specification of dvs gpios
just fine, additionally use the variant of gpiod_get exactly
]
if (IS_ERR(gpio) || gpiod_get_value(gpio) == 0)
^
Fixes: bad47ad2eef3 (regulator: rk808: fixed the overshoot when adjust
voltage)
Signed-off-by: Uwe Kleine-König u...@kleine-koenig.org
---
drivers/regulator/rk808-regulator.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
the driver callbacks unconditionally and make them aware that the
platform callbacks might be missing.
Signed-off-by: Uwe Kleine-König u...@kleine-koenig.org
---
Hello,
I didn't see any breakage without this patch, but it looks wrong the way
it is.
Best regards
Uwe
drivers/base/platform.c | 17
Hello Linus,
On Tue, Jul 21, 2015 at 11:25:40PM +0200, Linus Walleij wrote:
On Tue, Jul 21, 2015 at 8:47 PM, Uwe Kleine-König
u.kleine-koe...@pengutronix.de wrote:
On Tue, Jul 21, 2015 at 08:36:04PM +0200, Linus Walleij wrote:
Subject: pinctrl: imx1-core: Fix debug output
Hello,
On Tue, Jul 21, 2015 at 03:17:50PM -0700, Guenter Roeck wrote:
On 07/21/2015 02:01 PM, Uwe Kleine-König wrote:
On Tue, Jul 21, 2015 at 01:34:52PM -0700, Guenter Roeck wrote:
Commit b17d1bf16cc7 (gpio: make flags mandatory for gpiod_get functions)
makes the flags argument
://article.gmane.org/gmane.linux.kernel/2001345
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
1s/Subject: //' linus/master..
?! :-(
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
/etraxfs-uart.c:933:16: error:
too few arguments to function ‘devm_gpiod_get_optional’
Fixes: b17d1bf16cc7 (gpio: make flags mandatory for gpiod_get functions)
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Signed-off-by: Guenter Roeck li...@roeck-us.net
We discussed this driver while
.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
.
As a third benefit this patch makes the driver use the flags parameter
of gpiod_get* which will not be optional any more after 4.2 and so
prevents a build failure when the respective gpiod commit is merged.
Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de
---
Hello
On Tue, Jul 21, 2015 at 12:04:15PM +0100, Mark Brown wrote:
On Tue, Jul 21, 2015 at 11:56:49AM +0200, Linus Walleij wrote:
On Tue, Jul 21, 2015 at 8:59 AM, Uwe Kleine-König
The gpiod functions include variants for managed gpiod resources. Use it
to simplify the remove function
Hello,
On Tue, Jul 21, 2015 at 10:09:32PM +0900, Krzysztof Kozlowski wrote:
2015-07-21 15:59 GMT+09:00 Uwe Kleine-König u.kleine-koe...@pengutronix.de:
@@ -540,14 +540,19 @@ static int rk808_regulator_dt_parse_pdata(struct
device *dev,
goto dt_parse_end;
for (i
Not being affected by this change, I wonder what the technical
difference is if someone is listed as reviewer instead of maintainer.
Does get_maintainer.pl behave differently?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Li
e using
priv->devtype = (enum rcar_i2c_type)of_device_get_match_data(dev)
if good enough?
Other than that, the NULL pointer dereference should only happen if the
device was bound using the driver name. That might be worth to point out
in the commit log. So maybe make (in a separate
CC += devicet...@vger.kernel.org, gregkh
On Thu, Nov 12, 2015 at 09:36:55AM +0100, Frans Klaver wrote:
> On Thu, Nov 12, 2015 at 9:26 AM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
> > On Thu, Nov 12, 2015 at 09:03:11AM +0100, Frans Klaver wrote:
> >> H
all to match the device name on
driver name for of-created platform devices.)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line &qu
On Thu, Nov 12, 2015 at 09:57:07AM +0100, Frans Klaver wrote:
> On Thu, Nov 12, 2015 at 9:53 AM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
> > CC += devicet...@vger.kernel.org, gregkh
>
> You added linux@pengutronix instead of devicetree.
Well I s
Hello Wolfram,
On Thu, Nov 12, 2015 at 08:52:38AM +0100, Wolfram Sang wrote:
> On Thu, Nov 12, 2015 at 08:44:47AM +0100, Uwe Kleine-König wrote:
> > Other than that, the NULL pointer dereference should only happen if the
> > device was bound using the driver name. That might be wor
On Thu, Nov 12, 2015 at 09:48:37AM +0100, Wolfram Sang wrote:
> On Thu, Nov 12, 2015 at 09:09:26AM +0100, Uwe Kleine-König wrote:
> > Hello Wolfram,
> >
> > On Thu, Nov 12, 2015 at 08:52:38AM +0100, Wolfram Sang wrote:
> > > On Thu, Nov 12, 2015 at 08:44:47AM
- data->byte = simple_strtol(p + 1, NULL, 16);
> + err = kstrtou8(p + 1, 16, >byte);
> + if (err)
> + return -EPROTO;
> return 0;
This is nearly equivalent to the probably m
sensible_name(dev)
of_match_device(dev->driver->of_match_table, dev)
Best regards
Uwe
> host->devtype_data = of_id->data;
>
> return 0;
> --
> 2.4.10
>
>
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial
Hello,
On Thu, Nov 12, 2015 at 11:03:28AM +0100, LABBE Corentin wrote:
> On Thu, Nov 12, 2015 at 09:19:09AM +0100, Uwe Kleine-König wrote:
> > Hello Corentin,
> >
> > On Thu, Nov 12, 2015 at 08:46:55AM +0100, LABBE Corentin wrote:
> > > of_match_device could re
The function name in the documentation lacked an 's'. Add it.
Fixes: dbe2256ddd8e ("driver-core: platform: Provide helpers for multi-driver
modules")
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Documentation/driver-model/platform.txt | 2 +-
1 file chan
_device(dev, drv))
> return 1;
>
> return 0;
> }
That's equivalent to
if (dev->of_node)
return of_driver_match_device(dev, drv);
and was already suggested in the thread referenced from my reply to
http
for these.
Acked-by: Thierry Reding <tred...@nvidia.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Hello,
this issue popped up when it was discussed if of_match_device could
return NULL for several different drivers:
http://mid.gmane.org/2015111
gt; + if (!of_id)
> + return -ENODEV;
> sport->devdata = of_id->data;
>
> return 0;
I'd do something like:
- if (!np)
+ sport->devdata = of_device_get_match_data(>dev);
+ if (!sport->devdata)
/* no dev
l.com>
Do you see a problem? I don't claim your patch is wrong, I just wonder
why nobody else noticed it earlier (including me).
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
-
Hello,
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
for all three patches in this series.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscrib
On Mon, Nov 02, 2015 at 06:29:36AM -0800, Guenter Roeck wrote:
> On 11/01/2015 11:37 PM, Uwe Kleine-König wrote:
> >Hello,
> >
> >On Sun, Nov 01, 2015 at 06:32:56PM -0800, Guenter Roeck wrote:
> >>Since commit 7d8c70d8048c ("serial: mctrl-gpio: rename ini
e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majord
gnals").
Yes. BTW, 7b9c5162c182 looks broken, too, because the interrupt handling
is missing.
> Fixes: 7d8c70d8048c ("serial: mctrl-gpio: rename init function")
> Cc: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
> Cc: Niklas Cassel <n...@flawful.org>
> Signed
Helo Niklas,
On Mon, Nov 02, 2015 at 10:13:25PM +0100, Niklas Cassel wrote:
> On 11/02/2015 08:37 AM, Uwe Kleine-König wrote:
> >> The function call in the etraxfs-uart driver was not renamed,
> >> possibly due to interference with commit 7b9c5162c182 ("serial:
> &g
thout following all that fwnode discussion:
gpiod_get et al. should work for you here, doesn't it? It just takes a
struct device * and I'm happy with it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http:/
There are a few holes in the gpiod API. I see two solutions here:
>
> 1) extend devm_get_gpiod_from_child() to take an optional name argument
> 2) add a function to explicitly change a GPIO's name
>
> 2) seems to be the most generic solution, would that do the trick?
I would prefe
off-by: Arnd Bergmann <a...@arndb.de>
> Fixes: ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling")
Sounds and looks right. Thanks.
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
--
Pengutronix e.K. | Uwe Klein
Hello,
$Subject ~= s/warnning/warning/
and I'd rather write Fix instead of Remove.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send
On Fri, Jul 10, 2015 at 04:33:02PM -0700, Stephen Boyd wrote:
Clock provider drivers generally shouldn't include clk.h because
it's the consumer API. Remove the include here because this is a
provider driver.
Cc: Uwe Kleine-König u.kleine-koe...@pengutronix.de
Signed-off-by: Stephen Boyd sb
Hello,
On Tue, Jul 07, 2015 at 03:37:49PM +0200, Jan Lübbe wrote:
On Mi, 2014-11-26 at 19:05 +0200, Grygorii Strashko wrote:
On 11/26/2014 06:04 PM, Uwe Kleine-König wrote:
On Wed, Nov 26, 2014 at 03:59:53PM +0200, Grygorii Strashko wrote:
Having a board where the I2C bus locks up
quot; timer */
> + struct timer_list rs485_start_tx_timer; /* "rs485 start tx" timer
> */
> + struct timer_list rs485_stop_tx_timer; /* "rs485 stop tx" timer */
Do you really need two timers here? At each point in time there should
only be at most one of them
timeout || t > wdd->max_timeout));
So should this better be:
/* internal calculation is done in ms using unsigned variables */
if (t > UINT_MAX / 1000)
return 1;
/*
* compat code for drivers not being aware of framework pings to
* bridge ti
Hello Guenter,
On Tue, Sep 08, 2015 at 06:47:26AM -0700, Guenter Roeck wrote:
> On 09/08/2015 03:33 AM, Uwe Kleine-König wrote:
> >Hello,
> >
>
> >>[...]
> >>+static long watchdog_next_keepalive(struct watchdog_device *wdd)
> >>+{
> >&g
On Wed, Sep 09, 2015 at 07:41:25AM +0200, Uwe Kleine-König wrote:
> On Tue, Sep 08, 2015 at 11:19:13PM +0100, Russell King - ARM Linux wrote:
> > On Tue, Sep 08, 2015 at 10:38:04PM +0200, Maxime Coquelin wrote:
> > > This patch makes FORCE_MAX_ZONEORDER configurable in def
re. But not sure this makes any
sense. I will try with the default value later today and report back.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe fro
Hello Guenter,
On Tue, Sep 08, 2015 at 02:07:30PM -0700, Guenter Roeck wrote:
> On Tue, Sep 08, 2015 at 10:03:32PM +0200, Uwe Kleine-König wrote:
> > On Tue, Sep 08, 2015 at 06:47:26AM -0700, Guenter Roeck wrote:
> > > On 09/08/2015 03:33 AM, Uwe Kleine-König wrote:
> >
Hello,
On Wed, Sep 16, 2015 at 10:28:28AM +0200, Javier Martinez Canillas wrote:
> It's not needed an is just creating a null statement, so remove it.
>
> Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com>
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutron
On Fri, Sep 18, 2015 at 12:13:28AM +0200, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com>
Acked-by
arcnet.h
> +
What about
Documentation/networking/arcnet-hardware.txt
Documentation/networking/arcnet.txt
?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To
> Ensure that it is not smaller than min_timeout, even if max_timeout
> is not set.
>
> Signed-off-by: Guenter Roeck <li...@roeck-us.net>
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-König
class nor bus attributes, so these are ruled out, too.
Uwe Kleine-König (4):
rtc: pcf2127: fix reading uninitialized value on RTC_READ_VL ioctl
rtc: pcf2127: remove useless driver version
rtc: pcf2127: implement reading battery status bits
rtc: pcf2127: implement access to nvram
drivers
The rtc features a 512 byte battery backed RAM. Make it available via
sysfs.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Notes:
This patch is broken in the same way as the previous one. Don't merge!
drivers/rtc/rtc-pcf2127.c
A driver version is only really sensible for oot drivers. Also the
dev_info about having found a chip only signals that allocating the
driver data succeeded and so isn't worth much.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
drivers/rtc/rtc-pcf2127.c | 5 -
The rtc features a battery switch-over function. Export battery status
and if a switch-over occured via sysfs.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Notes:
Note this patch is wrong, don't merge!
Calling sysfs_create_files in the driver's probe
benefit to also make a prosa representation of this (and other) values
appear in the kernel log so remove the calls to dev_info and the driver
data members to track their state.
Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
---
Notes:
While this is a fix I don't
Hallo Linus,
On Fri, Oct 02, 2015 at 03:18:41AM -0700, Linus Walleij wrote:
> Patch applied with Uwe's ACK.
if it's not too late already: $Subject ~= s/ned/need/
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | h
Hello Greg,
On Wed, Dec 02, 2015 at 08:53:38AM -0800, Greg Kroah-Hartman wrote:
> On Wed, Dec 02, 2015 at 09:21:47AM +0100, Uwe Kleine-König wrote:
> > > > These changes are complex enough they really shouldn't go into 4.4
> > > > unless absolutely necessary.
> >
_data made also code simplier.
>
> Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions
base/platform: assert that dev_pm_domain callbacks are
> called unconditionally")
> Signed-off-by: Martin Wilck <martin.wi...@ts.fujitsu.com>
> ---
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions
driver had since long another
release.
The fix is already available, just some minor nitpicking regarding the
commit log has still to be resolved.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.
he previous (4.3.0 and earlier) behavior of
> platform_drv_probe() in the case when the associated platform driver has
> no "probe" function.
>
> Fixes: b8b2c7d845d5 ("base/platform: assert that dev_pm_domain callbacks are
> called unconditionally")
> Signed-off-
h.
hmm, our autobuilder still fails on this one because there has been no
next release since some time. I hope the best for tomorrow's build :-)
Anyhow, it fixes the build for efm32_defconfig, so
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K
tpm_info.irq = pnp_irq(pnp_dev, 0);
> else
> - interrupts = false;
> + tpm_info.irq = -1;
It's definitly a nice improvement of this patch that the init functions
don't change the module parameter any more. (I didn't check if all
changes are gone now, bu
}
> @@ -992,6 +994,9 @@ static int tpm_tis_acpi_init(struct acpi_device *acpi_dev)
>
> acpi_dev_free_resource_list();
>
> + if (resource_size(_info.res) == 0)
> + return -ENODEV;
> +
Does this result in an error message from the upper layers?
Best reg
om>
> Signed-off-by: Jason Gunthorpe <jguntho...@obsidianresearch.com>
Best regards,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line
Hello Jason,
On Tue, Dec 01, 2015 at 12:44:19PM -0700, Jason Gunthorpe wrote:
> On Tue, Dec 01, 2015 at 08:22:40PM +0100, Uwe Kleine-König wrote:
> > > + if (resource_size(_info.res) == 0)
> > > + return -ENODEV;
> > > +
> >
> > Does this result
y), z)
. I thought min(x, y) has the same type as x anyhow?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linu
Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.h
On Tue, Jan 05, 2016 at 12:02:23PM +0200, Tero Roponen wrote:
>
> On Tue, 5 Jan 2016, Uwe Kleine-König wrote:
>
> > Hello,
> >
> > I think this is the same problem that another Martin found and fixed in
> >
> > http://mid.gmane.org/1449132704-9952-1-git
Hello Guenter,
On Tue, Nov 24, 2015 at 08:45:05AM -0800, Guenter Roeck wrote:
> On 11/24/2015 08:11 AM, Uwe Kleine-König wrote:
> >On Tue, Nov 24, 2015 at 07:03:13AM -0800, Guenter Roeck wrote:
> >>thanks a lot for the Ack. I have v6 in the works, which changes recording
>
this more clear?
> +static inline bool watchdog_running(struct watchdog_device *wdd)
> +{
> + return test_bit(WDOG_RUNNING, >status);
> +}
> +
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.peng
Hello Guenter,
On Mon, Nov 23, 2015 at 08:14:56AM -0800, Guenter Roeck wrote:
> On 11/22/2015 11:53 PM, Uwe Kleine-König wrote:
> >On Sun, Nov 22, 2015 at 07:20:58PM -0800, Guenter Roeck wrote:
> >>@@ -160,7 +176,11 @@ they are supported. These optional r
ks are called unconditionally")
> >
> > Signed-off-by: Martin Wilck <martin.wi...@ts.fujitsu.com>
>
> Acked-by: Jarkko Sakkinen <jarkko.sakki...@linux.intel.com>
While the patch is fine, the commit log is not. It blames b8b2c7d845d5
to be responsible for a panic
is change is to sample jiffies before .start is called as I suggested,
right? For that change keeping my ack is ok of course.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengu
head(>vendor.int_queue);
> - if (interrupts) {
> + if (interrupts && tpm_info->irq != -1) {
> if (tpm_info->irq) {
There is even a check for irq == 0 that could be reused maybe?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kl
rc = tpm_tis_init(>dev, _default_info, NULL);
> if (rc)
> - goto err_init;
> + goto out4;
> +
> return 0;
> -err_init:
> - platform_device_unregister(pdev);
> -err_dev:
> - platform_driver_unregister(_drv);
> +out4:
e still more things that break the
assumption.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe linux-kerne
dev_pm_domain_attach failed */
> + ret = 0;
An else that has a } should also have a {, according to
checkpatch and Documentation/CodingStyle. You can write it
alternatively as:
if (ret != -EPROBE_DEFER) {
if (drv->probe)
ret = drv->pr
l)) {
ret = PTR_ERR(i2c_imx->pinctrl);
goto errorhandling;
}
if (i2c_imx->pinctrl)
i2c_imx_init_recovery_info(i2c_imx, pdev);
else
dev_info(>dev, "can't get pinctrl, bus recovery feature
disabled\n");
right
Hello,
Cc += Linus Walleij, linux-gpio
On Wed, Nov 18, 2015 at 04:59:11PM -0600, Li Yang wrote:
> On Wed, Nov 18, 2015 at 1:24 AM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
> > On Tue, Nov 17, 2015 at 06:02:59PM -0600, Li Yang wrote:
> >> @@ -11
wdd->last_keepalive = jiffies;
> + watchdog_update_worker(wdd, true);
> + }
I think it's more correct to sample jiffies before calling .start.
Something like:
unsigned long started_at = jiffies;
err = wdd->ops->start(wdd);
if (err == 0
ced in this series it should be squashed accordingly.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send the line "unsubscribe li
k <li...@roeck-us.net>
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
--
To unsubscribe from this list: send
access the PMC using regmap")
> Reported-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de>
I played with the AT91 during my non-work time, so please use
u...@kleine-koenig.org as my email address.
> Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com>
&g
RL_DATA_PREFETCH |
> + L310_PREFETCH_CTRL_DBL_LINEFILL_INCR;
> writel_relaxed(val, l2x0_base + L310_PREFETCH_CTRL);
> }
>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
ethphy: ethernet-phy@7 {
...
reset-gpios = < 25 GPIO_ACTIVE_LOW>;
};
};
};
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Thu, May 26, 2016 at 11:00:55AM +0200, Linus Walleij wrote:
> On Thu, May 12, 2016 at 8:42 PM, Uwe Kleine-König
> <u.kleine-koe...@pengutronix.de> wrote:
>
> > [added Linus Walleij to Cc, there is a question for you/him below]
> (...)
> >> +void mdio_device_
imeout set via the I2C_TIMEOUT ioctl.
and not mention the resolution at all. After all your patch doesn't
"enable" that ioctl, just makes use of the value set by it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial
goto err_get_irq;
I would prefer to introduce another label "err_setup_irq" at the same
place as err_get_irq and use it here.
> + }
>
> return 0;
>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
On Fri, Jun 17, 2016 at 09:46:35AM +0800, Weifeng Voon wrote:
> This allows applications to set the transfer timeout in 10ms increments via
> ioctl I2C_TIMEOUT.
>
> Signed-off-by: Weifeng Voon <weifeng.v...@intel.com>
Acked-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.
pe.
>
> Proper error handling (rollback, errno value) will be changed later case
> by case, thus this change just return back an error or success in the init
> function.
>
> Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org>
Acked-by: Uwe Kleine-König <u
> }
>
> -static void __init mxs_timer_init(struct device_node *np)
> +static int __init mxs_timer_init(struct device_node *np)
> {
> struct clk *timer_clk;
> int irq;
I didn't try, but I expect that the "return;" a few lines below results
in at least a warning and the compiler also warns about a missing return
at the end of the function.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
ata og_io_desc[] = {
I would have expected that
+static struct map_desc og_io_desc[] __initdata = {
is the correct variant?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
Hello Arnd,
On Tue, Feb 09, 2016 at 12:14:15PM +0100, Arnd Bergmann wrote:
> On Tuesday 09 February 2016 10:00:30 Uwe Kleine-König wrote:
> > > diff --git a/arch/arm/mach-ks8695/board-og.c
> > > b/arch/arm/mach-ks8695/board-og.c
> > > index 1f4f2f4f25bb..fa1a7c2ca2
ff.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
401 - 500 of 2736 matches
Mail list logo
