hongbo.zh...@linaro.com
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Francesco Lavra francescolavra...@gmail.com
You can't add these lines, until somebody has replied you with them in
earlier mails.
They don't show that somebody has put effort in reviewing them, but that current
On 24 October 2012 17:28, hongbo.zhang hongbo.zh...@linaro.org wrote:
From: hongbo.zhang hongbo.zh...@linaro.com
This patch adds device tree properties for ST-Ericsson DB8500 thermal driver,
also adds the platform data to support the old fashion.
Signed-off-by: hongbo.zhang
show_bios_limit is mistakenly written as show_scaling_driver in a comment
describing purpose of show_bios_limit() routine.
Fix it.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
On 9 October 2012 21:26, Morten Rasmussen morten.rasmus...@arm.com wrote:
On Thu, Oct 04, 2012 at 07:02:03AM +0100, Viresh Kumar wrote:
On 22 September 2012 00:02, morten.rasmus...@arm.com wrote:
SCHED_HMP requires that the platform implements arch_get_hmp_domains()
which should set up
character.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 6 +++---
include/linux/cpufreq.h | 2 ++
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 021973b..db6e337 100644
On Wed, Oct 10, 2012 at 2:34 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Tue, 2012-10-02 at 14:41 +0300, Andy Shevchenko wrote:
From: Heikki Krogerus heikki.kroge...@linux.intel.com
Since v3.2 we have nice macro to define the platform driver's init and exit
calls. This
On 10 October 2012 14:51, Andy Shevchenko andy.shevche...@gmail.com wrote:
We have spi, i2c and hsuart devices connected to the DMA controller.
In case we would like to use DMA we have to have the dw_dmac loaded
before them. Currently we have spi driver on subsys_initcall level,
and Mika, who
On 10 October 2012 15:47, Morten Rasmussen morten.rasmus...@arm.com wrote:
On Thu, Oct 04, 2012 at 07:49:32AM +0100, Viresh Kumar wrote:
This patch is reuse of a patch by Jon Medhurst t...@linaro.org with a
few bits left out.
Then probably he must be the author of this commit? Also a SOB
Documentation style comments were missing for few fields in struct
dw_dma_platform_data. Add these.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/dw_dmac.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/dw_dmac.h b/include/linux/dw_dmac.h
index
This patch adds dw_dmac's platform data to DT node. It also creates slave info
node for SPEAr13xx, for the devices which were using dw_dmac.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
arch/arm/boot/dts/spear1340.dtsi | 19 ++
arch/arm/boot/dts/spear13xx.dtsi
, by the generic filter routine.
- Update binding document
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Documentation/devicetree/bindings/dma/snps-dma.txt | 44 ++
drivers/dma/dw_dmac.c | 147 +
drivers/dma/dw_dmac_regs.h
On Fri, Oct 12, 2012 at 11:14 AM, Viresh Kumar viresh.ku...@linaro.org wrote:
dw_dmac driver already supports device tree but it used to have its platform
data passed the non-DT way.
This patch does following changes:
- pass platform data via DT, non-DT way still takes precedence if both
On 12 October 2012 13:53, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
My few comments are below.
Most welcome :)
diff --git a/Documentation/devicetree/bindings/dma/snps-dma.txt
b/Documentation/devicetree/bindings/dma/snps
On 12 October 2012 14:55, Andy Shevchenko andy.shevche...@gmail.com wrote:
I understand your way of allocating memory, but what about using
linked list instead of array?
I gave it a thought. Overhead was 4 bytes more per slave structure +
more cycles in filter routine (arrays are more faster
On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
+ while (++i dw-sd_count) {
+ if (!strcmp(dw-sd[i].bus_id, param)) {
+ found = 1;
+ break
On 12 October 2012 16:10, Andy Shevchenko andy.shevche...@gmail.com wrote:
On Fri, Oct 12, 2012 at 1:36 PM, viresh kumar viresh.ku...@linaro.org wrote:
On Fri, Oct 12, 2012 at 1:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar
On 12 October 2012 16:10, Andy Shevchenko andy.shevche...@gmail.com wrote:
+ if (!found) {
+ last_dw = dw;
+ last_bus_id = param;
+ return false;
Because of return here you could eliminate 'found' flag at all.
Here is the stuff copied from you ;)
On 12 October 2012 16:55, Andy Shevchenko andy.shevche...@gmail.com wrote:
EXPORT_SYMBOL(dw_generic_filter);
Could we change a name to be more precise, like dw_dma_generic_filter ?
Sure.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
On 12 October 2012 18:58, Shevchenko, Andriy
andriy.shevche...@intel.com wrote:
On Fri, 2012-10-12 at 11:14 +0530, Viresh Kumar wrote:
+ if (!of_property_read_u32(np, chan_allocation_order,
+ val))
Fits one line?
yes.
+ pdata
Documentation style comments were missing for few fields in struct
dw_dma_platform_data. Add these.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux/dw_dmac.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/dw_dmac.h b/include/linux/dw_dmac.h
index
, by the generic filter routine.
- Update binding document
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V2:
--
- Optimized filter DT parsing routine
- Removed unnecessary casts from changes
- renamed filter function
- Fixed function prototype and return value of DT parsing routine
This patch adds dw_dmac's platform data to DT node. It also creates slave info
node for SPEAr13xx, for the devices which were using dw_dmac.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V2:
--
- renamed filter function
arch/arm/boot/dts/spear1340.dtsi | 19
On 12 October 2012 20:11, Shevchenko, Andriy
andriy.shevche...@intel.com wrote:
On Fri, 2012-10-12 at 19:36 +0530, Viresh Kumar wrote:
I meant is to use that constant instead of hard coding 4 everywhere.
It's a maximum value, not the SoC specific.
Can be done.
+ u32 val, arr[4];
what
On 12 October 2012 20:18, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
static struct of_dev_auxdata spear1310_auxdata_lookup[] __initdata = {
- OF_DEV_AUXDATA(arasan,cf-spear1340, MCIF_CF_BASE, NULL,
cf_dma_priv),
- OF_DEV_AUXDATA(snps,dma-spear1340, DMAC0_BASE,
On 12 October 2012 20:20, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 20:01 Fri 12 Oct , Viresh Kumar wrote:
dw_dmac driver already supports device tree but it used to have its platform
data passed the non-DT way.
This patch does following changes:
- pass platform
On 12 October 2012 20:28, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Fri, 2012-10-12 at 20:01 +0530, Viresh Kumar wrote:
+ if (last_dw) {
+ if ((last_bus_id == param) (last_dw == dw))
+ return false;
+ }
Just came to my mind.
dw
On 12 October 2012 21:23, Andy Shevchenko andy.shevche...@gmail.com wrote:
1. This is an equivalent of
if (last_dw (last_bus_id == ... ) (last_dw == dw))
return false;
2. In case dw is always non-NULL the last_dw == dw is false if last_dw is
NULL.
Where am I wrong?
Nowhere, I am drunk
On 12 October 2012 21:51, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
+ OF_DEV_AUXDATA(arasan,cf-spear1340, MCIF_CF_BASE, NULL, cf),
?/
Sorry. can't get it :(
what is the cf as paltfrom data
This is dma bus_id string, which matches with what is passed from dtb.
--
To
On 12 October 2012 21:50, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
- pass platform data via DT, non-DT way still takes precedence if both
are used.
why keep it all platform are DT
I would love to remove that, but not sure if somebody want's the non-DT
way too.
I
three
*_array() routines.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/of/base.c | 73 +++---
include/linux/of.h | 30 ++
2 files changed, 89 insertions(+), 14 deletions(-)
diff --git a/drivers/of/base.c b
On 13 October 2012 17:52, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 14:18 Sat 13 Oct , Viresh Kumar wrote:
On Oct 13, 2012 12:16 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 22:42 Fri 12 Oct , Viresh Kumar wrote:
On 12
On 13 October 2012 19:38, Viresh Kumar viresh.ku...@linaro.org wrote:
On 13 October 2012 17:52, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 14:18 Sat 13 Oct , Viresh Kumar wrote:
On Oct 13, 2012 12:16 PM, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com
manual, present at following[1] location.
1. http://www.st.com/internet/mcu/product/251211.jsp
Cc: Thierry Reding thierry.red...@avionic-design.de
Signed-off-by: Shiraz Hashim shiraz.has...@st.com
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Vipin Kumar vipin.ku...@st.com
in all driver files.
That's why this is an RFC.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index f552d5f..59264f1 100644
On 12 October 2012 23:31, Viresh Kumar viresh.ku...@linaro.org wrote:
This adds following helper routines:
- of_property_read_u8_array()
- of_property_read_u16_array()
- of_property_read_u8()
- of_property_read_u16()
First two actually share most of the code with of_property_read_u32_array
On 25 October 2012 13:56, Hongbo Zhang hongbo.zh...@linaro.org wrote:
While replying to mails, don't remove lines like above. They help
identifying who
wrote what.
[...]
+/* Callback to get temperature changing trend */
+static int db8500_sys_get_trend(struct thermal_zone_device *thermal,
On 25 October 2012 15:03, Hongbo Zhang hongbo.zh...@linaro.org wrote:
On 25 October 2012 16:41, Viresh Kumar viresh.ku...@linaro.org wrote:
Just paste my current pieces of codes here:
static struct db8500_thsens_platform_data*
db8500_thermal_parse_dt(struct platform_device
On 25 October 2012 15:26, Hongbo Zhang hongbo.zh...@linaro.org wrote:
Verish, see the codes in include/linux/interrupt.h:
s/verish/viresh :)
static inline int __must_check
devm_request_irq(struct device *dev, unsigned int irq, irq_handler_t handler,
unsigned long irqflags,
On 25 October 2012 15:34, Viresh Kumar viresh.ku...@linaro.org wrote:
On 25 October 2012 15:26, Hongbo Zhang hongbo.zh...@linaro.org wrote:
This is what your prcmu driver's routines are doing:
int db8500_prcmu_config_hotmon(u8 low, u8 high)
{
...
wait_for_completion(mb4_transfer.work
On 25 October 2012 18:49, Rob Herring robherri...@gmail.com wrote:
For some reason, this does not show up on the list either in my mail or
mail list archives, but it is in patchwork. Can you resend it please.
Strange. I kept you in --to field. I know people added in cc are
sometimes removed
by
On 26 October 2012 05:43, Rafael J. Wysocki r...@sisk.pl wrote:
I have applied this patch only because of the fixes on top of it. It broke
kernel compliation due to some missing EXPORT_SYMBOL_GPLs in
cpufreq_governor.c,
so I woulnd't have applied it otherwise.
Hi Rafael,
So sorry for
On 25 October 2012 19:48, Viresh Kumar viresh.ku...@linaro.org wrote:
The problem i see here is:
The data passed via DT comes as Little Endian in the kernel.
For a little endian system, byte zero will contain the data and so
(u8) val
look to be the correct thing.
For a big endian system
three
*_array() routines.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V2:
-
- Use typeof() in of_property_read_array() macro instead of passing type to it
drivers/of/base.c | 73 +++---
include/linux/of.h | 30
Hi Vinod,
On 16 October 2012 09:49, Viresh Kumar viresh.ku...@linaro.org wrote:
dw_dmac driver already supports device tree but it used to have its platform
data passed the non-DT way.
This patch does following changes:
- pass platform data via DT, non-DT way still takes precedence if both
Avoid calling cpufreq driver's target() routine if new frequency is same as
policies current frequency.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
__cpufreq_driver_target() must not pass target frequency beyond the limits of
current policy.
Today most of cpufreq platform drivers are doing this check in their target
routines. Why not move it to __cpufreq_driver_target().
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Hi Rafael
-by: Viresh Kumar viresh.ku...@linaro.org
---
net/dsa/slave.c | 4
1 file changed, 4 insertions(+)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index e32083d..5606fae 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -48,6 +48,8 @@ void dsa_slave_mii_bus_init(struct dsa_switch *ds
[-Wmaybe-uninitialized]
I could have used uninitialized_var() too, but didn't used it as the final else
part of map_word_load() is missing. So there is a chance that it might be passed
uninitialized. Better initialize to zero.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
include/linux
On 8 November 2012 22:08, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Thu, Nov 08, 2012 at 07:10:47PM +0530, Viresh Kumar wrote:
It also breaks the error unwinding/removal of the driver as it frees
input device while IRQ handler is still active.
I have heard of this argument before
On 9 November 2012 08:06, Viresh Kumar viresh.ku...@linaro.org wrote:
On 8 November 2012 22:08, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
There is devm_request_and_ioremap() which you can use here.
Should have been done in V1 only.
Hi Dmitry,
Please apply below fixup to original patch
On 8 November 2012 20:07, Viresh Kumar viresh.ku...@linaro.org wrote:
This patch frees rtc-spear driver from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar
On 9 November 2012 17:22, Axel Lin axel@ingics.com wrote:
spear_pwm_config() is not referenced outside of this file, make it static.
Signed-off-by: Axel Lin axel@ingics.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux
On 9 November 2012 17:28, Thierry Reding
thierry.red...@avionic-design.de wrote:
Applied, thanks.
Aah.. That's pretty fast :)
within 5 minutes of posting the patch you got ACK and got applied too :)
--
viresh
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
From: Shiraz Hashim shiraz.has...@st.com
dmatest erroneously terminated transfers in normal cases also leading to
test failures for multiple threads over a channel. Fix this and
terminate transfers only in case of errors.
Signed-off-by: Shiraz Hashim shiraz.has...@st.com
Signed-off-by: Deepak
This patch frees stmpe-keyboard driver from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/input/keyboard/stmpe-keypad.c
This patch frees stmpe-ts driver from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/input/touchscreen/stmpe-ts.c | 45
From: Vipul Kumar Samar vipulkumar.sa...@st.com
Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com
---
drivers/input/touchscreen/stmpe-ts.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/input/touchscreen/stmpe-ts.c
b/drivers/input/touchscreen/stmpe-ts.c
index
This patch frees stmpe driver from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/mfd/stmpe.c | 46
From: Vipul Kumar Samar vipulkumar.sa...@st.com
This patch adds support to probe stmpe devices via DT. Bindings are mentioned in
binding document.
Signed-off-by: Vipul Kumar Samar vipulkumar.sa...@st.com
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Documentation/devicetree/bindings
On 9 November 2012 22:15, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
If input device was alocated with devm_* interface it does not need be
explicitly unregistered/freed.
Thanks for pointing out:
Fixup:
commit 4bf57c85f49f16a139af80f8de76fa01eee77a5d
Author: Viresh Kumar viresh.ku
On 9 November 2012 20:57, Viresh Kumar viresh.ku...@linaro.org wrote:
This patch frees stmpe-ts driver from tension of freeing resources :)
devm_* derivatives of multiple routines are used while allocating resources,
which would be freed automatically by kernel.
Signed-off-by: Viresh Kumar
On 9 November 2012 11:03, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Fri, Nov 09, 2012 at 08:06:29AM +0530, Viresh Kumar wrote:
On 8 November 2012 22:08, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
On Thu, Nov 08, 2012 at 07:10:47PM +0530, Viresh Kumar wrote:
It also breaks
On Sat, Nov 10, 2012 at 2:27 AM, Jon Mason jon.ma...@intel.com wrote:
device_control is an optional and not implemented in all DMA drivers.
Any calls to these will result in a NULL pointer dereference. dmatest
makes two of these calls when completing the kernel thread and removing
the module.
again to verify what's playing with patches.
On this copy
i can see that this issue isn't there till now.
commit dda6d45808d65aaf8b0d4153e7a418b255365818
Author: Viresh Kumar viresh.ku...@linaro.org
Date: Fri Nov 9 22:28:26 2012 +0530
fixup! input: stmpe-ts: Use devm_*() routines
---
drivers
On 10 November 2012 13:33, Viresh Kumar viresh.ku...@linaro.org wrote:
On 10 November 2012 13:30, Dmitry Torokhov dmitry.torok...@gmail.com wrote:
Sometimes your mailer does wrap long lines, please make sure to turn it
off for patches.
I am using gmail for replying on mails and this fixup
spear_pinctrl_dt_free_map(struct pinctrl_dev *pctldev,
+ struct pinctrl_map *map,
+ unsigned num_maps)
{
kfree(map);
}
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux
Ping!!
On 7 November 2012 09:52, viresh kumar viresh.ku...@linaro.org wrote:
On Tue, Nov 6, 2012 at 7:48 PM, Rob Herring robherri...@gmail.com wrote:
+#define of_property_read_array(_np, _pname, _out, _sz)
\
+ while (_sz
On 11 November 2012 19:42, Rob Herring robherri...@gmail.com wrote:
On 11/06/2012 10:22 PM, viresh kumar wrote:
cluster0: cluster@0 {
+ data1 = 0x50 0x60 0x70;
+ data2 = 0x5000 0x6000 0x7000;
+ data3
On 12 November 2012 01:12, Rob Herring robherri...@gmail.com wrote:
On 11/11/2012 11:27 AM, Viresh Kumar wrote:
On 11 November 2012 19:42, Rob Herring robherri...@gmail.com wrote:
On 11/06/2012 10:22 PM, viresh kumar wrote:
cluster0: cluster@0 {
+ data1
On 12 November 2012 08:45, Stephen Rothwell s...@canb.auug.org.au wrote:
Hi Linus,
Today's linux-next merge of the pinctrl tree got a conflict in
arch/arm/boot/dts/spear1340.dtsi between commit b47394911c26 (ARM:
SPEAr13xx: Pass DW DMAC platform data from DT) from the slave-dma tree and
On 8 November 2012 19:10, Viresh Kumar viresh.ku...@linaro.org wrote:
From: Vipul Kumar Samar vipulkumar.sa...@st.com
clk_{un}prepare is mandatory for platforms using common clock framework.
Because
for SPEAr we don't do anything in clk_{un}prepare() calls, just call them ones
in probe
On Mon, Nov 12, 2012 at 4:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
static int __devinit dw_probe(struct platform_device *pdev)
{
struct dw_dma_platform_data *pdata;
@@ -1604,9 +1610,6 @@ static int
On 12 November 2012 19:28, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
On Mon, 2012-11-12 at 19:24 +0530, viresh kumar wrote:
Allocate it dynamically to support multiple controllers with different
configuration
in a SoC.
Like you did for device tree? No problem, but here
On Mon, Nov 12, 2012 at 4:53 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
+ if (!pdata autocfg)
+ pdata = dw_dma_pdata;
+
+ if (!pdata || pdata-nr_channels DW_DMA_MAX_NR_CHANNELS)
+ return -EINVAL;
+
Another thing: replace the
-device_control(chan, cmd, arg);
+ else
+ return -ENOSYS;
}
Reviewed-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
-by: Axel Lin axel@ingics.com
Acked-by: Viresh Kumar viresh.ku...@linaro.org
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
SPEAr SoC's don't do anything in clk_prepare() of plgpio driver, so there is no
need to call this routine multiple times. Just call it once at probe.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
Hi Linus,
This patch is rebased over https://lkml.org/lkml/2012/11/14/220
drivers
) but then waited for Andy to finish other
changes to the same module(3).
(1) https://patchwork.kernel.org/patch/608211
(2) https://lkml.org/lkml/2012/8/26/148
(3) https://lkml.org/lkml/2012/9/21/173
Signed-off-by: Hein Tibosch hein_tibo...@yahoo.es
Good.
Acked-by: Viresh Kumar viresh.ku
On 14 October 2012 15:31, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote:
On 19:40 Sat 13 Oct , Viresh Kumar wrote:
On 13 October 2012 19:38, Viresh Kumar viresh.ku...@linaro.org wrote:
On 13 October 2012 17:52, Jean-Christophe PLAGNIOL-VILLARD
plagn...@jcrosoft.com wrote
On 12 October 2012 20:28, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
+ if (last_dw) {
+ if ((last_bus_id == param) (last_dw == dw))
+ return false;
+ }
Just came to my mind.
dw can't be NULL, can't it?
Then
if (last_dw) {
...
}
is
On 27 September 2012 14:34, Viresh Kumar viresh.ku...@linaro.org wrote:
This is V2 of my sched_select_cpu() work.
In order to save power, it would be useful to schedule work onto non-IDLE cpus
instead of waking up an IDLE one.
To achieve this, we need scheduler to guide kernel frameworks
On 15 October 2012 13:26, Shevchenko, Andriy
andriy.shevche...@intel.com wrote:
On Fri, 2012-10-12 at 23:31 +0530, Viresh Kumar wrote:
+ while (_sz--) \
+ *_out++ = (_type)be32_to_cpup(_val++); \
How about
Multiple cpufreq governers have defined similar get_cpu_idle_time_***()
routines. These routines must be moved to some common place, so that all
governors can use them.
So moving them to tick-sched.c, which seems to be a better place for keeping
these routines.
Signed-off-by: Viresh Kumar
On 15 October 2012 14:05, Michal Hocko mho...@suse.cz wrote:
On Mon 15-10-12 13:41:20, Viresh Kumar wrote:
Multiple cpufreq governers have defined similar get_cpu_idle_time_***()
routines. These routines must be moved to some common place, so that all
governors can use them.
So moving them
Multiple cpufreq governers have defined similar get_cpu_idle_time_***()
routines. These routines must be moved to some common place, so that all
governors can use them.
So moving them to cpufreq_governor.c, which seems to be a better place for
keeping these routines.
Signed-off-by: Viresh Kumar
On 15 October 2012 23:21, Rafael J. Wysocki r...@sisk.pl wrote:
On Wednesday 10 of October 2012 10:12:11 Viresh Kumar wrote:
Arrays for governer and driver name are of size CPUFREQ_NAME_LEN or 16.
i.e. 15 bytes for name and 1 for trailing '\0'.
When cpufreq driver print these names (for sysfs
This patch adds dw_dmac's platform data to DT node. It also creates slave info
node for SPEAr13xx, for the devices which were using dw_dmac.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
V1-V3:
--
- renamed filter function
arch/arm/boot/dts/spear1340.dtsi | 19
, by the generic filter routine.
- Update binding document
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
V2-V3:
--
- Simplified an equation in filter routine
- renamed variable 'val' as 'tmp' in DT parsing routine
V1-V2
Documentation style comments were missing for few fields in struct
dw_dma_platform_data. Add these.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
Reviewed-by: Andy Shevchenko andriy.shevche...@linux.intel.com
---
include/linux/dw_dmac.h | 2 ++
1 file changed, 2 insertions(+)
diff --git
On Tue, Oct 16, 2012 at 2:15 PM, Andy Shevchenko
andriy.shevche...@linux.intel.com wrote:
The following error messages come if we have software LLP emulation enabled
and
enough threads running.
modprobe dmatest iterations=40
[ 168.048601] dmatest: Started 1 threads using dma0chan0
[
Hi Andy,
Adding blank lines before and after your replies makes it more readable.
On 16 October 2012 15:05, Andy Shevchenko andy.shevche...@gmail.com wrote:
On Tue, Oct 16, 2012 at 11:56 AM, viresh kumar viresh.ku...@linaro.org
wrote:
Can you try with a large timeout value for the module.
I
patch to fix SPEAr's issues
point out by Linus?
x---x
From: Viresh Kumar viresh.ku...@linaro.org
Date: Wed, 17 Oct 2012 08:58:08 +0530
Subject: [PATCH] ARM: SPEAr: Remove unused empty files
Few empty files (spear1310_misc_regs.h
]
Because
SET_SYSTEM_SLEEP_PM_OPS(suspend_fn, resume_fn)
Only references the callbacks on CONFIG_PM_SLEEP (instead of CONFIG_PM).
Cc: Jeff Garzik jgar...@pobox.com
Cc: Viresh Kumar viresh.li...@gmail.com
Cc: linux-...@vger.kernel.org
Signed-off-by: Yuanhan Liu yuanhan
With debug options on, it is difficult to locate cpufreq core's debug prints.
Fix this by prefixing debug prints with:
cpufreq:
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers/cpufreq/cpufreq.c | 2 ++
drivers/cpufreq/cpufreq_performance.c | 2 ++
drivers/cpufreq
This adds Kconfig options for DEBUG and VERBOSE_DEBUG to the cpufreq subsystem,
This is pretty useful for developers who want to debug cpufreq subsystem and
don't want to editing the Makefile manually each time they want to debug.
Signed-off-by: Viresh Kumar viresh.ku...@linaro.org
---
drivers
On 17 October 2012 11:09, Joe Perches j...@perches.com wrote:
On Wed, 2012-10-17 at 10:50 +0530, Viresh Kumar wrote:
With debug options on, it is difficult to locate cpufreq core's debug prints.
[]
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
@@ -15,6 +15,8
On 17 October 2012 11:34, Joe Perches j...@perches.com wrote:
I believe you are quoting KBUILD_MODNAME
Yes. :(
Far better output with this. Thanks.
@Rafael: Please consider below patch instead:
From: Viresh Kumar viresh.ku...@linaro.org
Date: Wed, 17 Oct 2012 10:38:31 +0530
Subject: [PATCH
---
From: Viresh Kumar viresh.ku...@linaro.org
Date: Wed, 17 Oct 2012 10:38:31 +0530
Subject: [PATCH] cpufreq: Improve debug prints
With debug options on, it is difficult to locate cpufreq core's debug prints.
Fix this by prefixing debug prints with KBUILD_MODNAME.
Signed-off-by: Viresh Kumar
On 17 October 2012 14:55, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
With CONFIG_DYNAMIC_DEBUG, you can control(enable/disable) debug
prints at different levels (file, module, line, function)
Quickly went through this :)
http://www.kernel.org/doc/ols/2009/ols2009-pages-39-46.pdf
On 17 October 2012 15:28, Sudeep KarkadaNagesha
sudeep.karkadanage...@arm.com wrote:
May be kernel/Documentation/dynamic-debug-howto.txt is more up-to-date.
yes.
My usecase is a bit different. I want to see all bootprints with
cpufreq pr_debug
prints. So, this prefixing will help there.
101 - 200 of 16408 matches
Mail list logo
