Re: [PATCHv2 3/4] dw_dmac: change {dev_}printk() to corresponding macros

2012-10-17 Thread viresh kumar
On Wed, Oct 17, 2012 at 4:01 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Acked-by: Viresh Kumar viresh.ku

Re: [PATCHv2 4/4] dw_dmac: don't call platform_get_drvdata twice

2012-10-17 Thread viresh kumar
On Wed, Oct 17, 2012 at 4:01 PM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/dma/dw_dmac.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Viresh Kumar viresh.ku...@linaro.org

Re: [PATCHv2 4/4] dw_dmac: don't call platform_get_drvdata twice

2012-10-17 Thread viresh kumar
On Wed, Oct 17, 2012 at 6:44 PM, Felipe Balbi ba...@ti.com wrote: On Wed, Oct 17, 2012 at 01:31:18PM +0300, Andy Shevchenko wrote: I would suggest adding a commit log, but if maintainer is fine without, I'm fine too :-p Should be there. But i am bored of giving this review comment now :) --

Re: [PATCH 2/5] Thermal: add indent for code alignment.

2012-10-17 Thread Viresh Kumar
( if (min != policy.cpuinfo.min_freq || max != policy.cpuinfo.max_freq) return ERR_PTR(-EINVAL); -} + } Apart from that: Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line

Re: [PATCH 3/5] Thermal: fix empty list checking method.

2012-10-17 Thread Viresh Kumar
-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/5] Thermal: make sure cpufreq cooling register after cpufreq driver

2012-10-17 Thread Viresh Kumar
On 16 October 2012 17:14, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com The cpufreq works as a cooling device, so the cooling layer should check and wait until the cpufreq driver is initialized. Idea is good. Signed-off-by: hongbo.zhang

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-17 Thread Viresh Kumar
On 16 October 2012 17:14, hongbo.zhang hongbo.zh...@linaro.org wrote: From: hongbo.zhang hongbo.zh...@linaro.com This diver is based on the thermal management framework in thermal_sys.c. A thermal zone device is created with the trip points to which cooling devices can be bound, the current

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-17 Thread Viresh Kumar
On 17 October 2012 22:28, Joe Perches j...@perches.com wrote: +#include linux/slab.h +#include linux/module.h +#include linux/platform_device.h +#include linux/cpufreq.h +#include linux/cpu_cooling.h +#include linux/err.h should be in alphabetical order There's no agreed kernel

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-18 Thread Viresh Kumar
On 18 October 2012 13:05, Hongbo Zhang hongbo.zh...@linaro.org wrote: On 17 October 2012 23:23, Viresh Kumar viresh.ku...@linaro.org wrote: On 16 October 2012 17:14, hongbo.zhang hongbo.zh...@linaro.org wrote: +static struct db8500_trip_point db8500_trips_table[] = { + [0

Re: [PATCHv3 0/6] dw_dmac: few cleanups to the driver

2012-10-18 Thread viresh kumar
Balbi) - add a description to patch 4/6 Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read

Re: [PATCH] pwm: add spear pwm driver support

2012-10-18 Thread viresh kumar
= of_match_ptr(spear_pwm_of_match), + }, + .probe = spear_pwm_probe, + .remove = __devexit_p(spear_pwm_remove), +}; + +module_platform_driver(spear_pwm_driver); + +MODULE_LICENSE(GPL); +MODULE_AUTHOR(Shiraz Hashim shiraz.has...@st.com); +MODULE_AUTHOR(Viresh Kumar viresh.ku

Re: [PATCH] pwm: add spear pwm driver support

2012-10-18 Thread viresh kumar
On Thu, Oct 18, 2012 at 6:59 PM, Shiraz Hashim shiraz.has...@st.com wrote: Is there a reason to make this conditional? It looks like SPEAr has moved to OF, so this will always be enabled anyway, won't it? Yes, I would remove it, SPEAr cannot boot without DT. Add a dependency on OF in the

Re: [PATCH 5/5] Thermal: Add ST-Ericsson db8500 thermal dirver.

2012-10-18 Thread viresh kumar
On Wed, Oct 17, 2012 at 8:53 PM, Viresh Kumar viresh.ku...@linaro.org wrote: On 16 October 2012 17:14, hongbo.zhang hongbo.zh...@linaro.org wrote: +static int __devinit db8500_cpufreq_cooling_probe(struct platform_device *pdev) +{ + struct db8500_cpufreq_cdev *cooling_devs; Hi Hongbo

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
It would be nice to keep spear-devel in cc, as this is the second platform that uses this driver. On Fri, Jul 13, 2012 at 9:09 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: The default values are filled to support at least mem-to-mem tests provided by dmatest module. It makes

Re: [PATCH 1/3] dw_dmac: mark dwc_dump_lli inline

2012-07-13 Thread viresh kumar
, struct dw_lli *lli) +static inline void dwc_dump_lli(struct dw_dma_chan *dwc, struct dw_lli *lli) { dev_printk(KERN_CRIT, chan2dev(dwc-chan), desc: s0x%llx d0x%llx l0x%llx c0x%x:%x\n, Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from

Re: [PATCH 2/3] dw_dmac: use 'u32' for LLI structure members, not dma_addr_t

2012-07-13 Thread viresh kumar
llp;/* chain to next lli */ + u32 sar; + u32 dar; + u32 llp;/* chain to next lli */ u32 ctllo; /* values that may get written back: */ u32 ctlhi; Acked-by: Viresh Kumar

Re: [PATCH] MIPS: BCM63XX: select HAVE_CLK

2012-07-13 Thread viresh kumar
for BCM63XX based boards Reviewed-by: Viresh Kumar viresh.ku...@linaro.org -- Viresh -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 09:45, Andy Shevchenko wrote: To understand it more, what does this mean? We will not support transfers with unaligned addresses/length to word size? The dmatest module uses those constants to get source, destination addresses and length of the test data aligned. On the other

Re: [PATCH 3/3] dw_dmac: set default alignment

2012-07-13 Thread viresh kumar
On 13/07/12 11:04, Andy Shevchenko wrote: On Fri, Jul 13, 2012 at 11:56 AM, viresh kumar viresh.kum...@arm.com wrote: I wanted to ask, will normal memcpy for anybody will work with unaligned addresses with this patch? I believe they will. Hmm... I just rechecked and it seems it works without

Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue

2013-04-15 Thread Viresh Kumar
] cpufreq: ARM big LITTLE: put DT nodes after using them DT nodes should be put using of_node_put() to balance their usage counts. This is not done properly in ARM's big LITTLE driver. Fix it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/arm_big_little_dt.c | 43

[PATCH 1/2] cpufreq: ARM big LITTLE: put DT nodes after using them

2013-04-15 Thread Viresh Kumar
DT nodes should be put using of_node_put() to balance their usage counts. This is not done properly in ARM's big LITTLE driver. Fix it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- Hi Rafael, These are fixes for 3.10 drivers/cpufreq/arm_big_little_dt.c | 43

[PATCH 2/2] cpufreq: ARM big LITTLE: Adapt to latest cpufreq updates

2013-04-15 Thread Viresh Kumar
This driver isn't updated to work with latest cpufreq core updates that happened recently. Fix them. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- As original patch breaks compilation, its best to merge this patch with original patch. drivers/cpufreq/arm_big_little.c | 10

[PATCH] cpufreq: cpu0: Put cpu parent node after using it

2013-04-15 Thread Viresh Kumar
Parent node must be put after using it to balance its usage count. This was missing in cpufreq-cpu0 driver. Fix it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq-cpu0.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-15 Thread Viresh Kumar
will probably be down for one more week and so not doing any reviews for now... I do check important mails sent directly to me though. x--x-- From: Viresh Kumar viresh.ku...@linaro.org Date: Mon, 15 Apr 2013 22:43:57 +0530 Subject: [PATCH] cpufreq

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-21 Thread Viresh Kumar
On 22 April 2013 05:00, Rafael J. Wysocki r...@sisk.pl wrote: Applied to linux-pm.git/linux-next, although please check the result, because the patchwork version of the patch wasn't quite applicable and I fixed it up manually. Yes it looks fine and that's why i have attached the patch with my

Re: [PATCH v2 06/15] powerpc/85xx: add support to JOG feature using cpufreq interface

2013-04-21 Thread Viresh Kumar
On Fri, Apr 19, 2013 at 4:17 PM, Zhao Chenhui chenhui.z...@freescale.com wrote: diff --git a/drivers/cpufreq/mpc85xx-cpufreq.c b/drivers/cpufreq/mpc85xx-cpufreq.c +#include linux/module.h +#include linux/cpufreq.h +#include linux/of_platform.h +#include linux/suspend.h +#include

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-22 Thread Viresh Kumar
On 10 April 2013 00:00, Tejun Heo t...@kernel.org wrote: On Tue, Apr 09, 2013 at 01:00:59PM +0530, Viresh Kumar wrote: +#ifdef CONFIG_WQ_POWER_EFFICIENT +static bool wq_power_efficient = 0; +module_param_named(power_efficient, wq_power_efficient, bool, 0444); +#endif I don't think we need

Re: [PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq

2013-04-22 Thread Viresh Kumar
On 9 April 2013 14:05, Viresh Kumar viresh.ku...@linaro.org wrote: On 5 April 2013 12:16, Viresh Kumar viresh.ku...@linaro.org wrote: On 4 April 2013 18:24, Viresh Kumar viresh.ku...@linaro.org wrote: This patch moves cpufreq driver of powerpc platform to drivers/cpufreq. Cc: Benjamin

Re: [PATCH v3 linux-next] cpufreq: ondemand: Calculate gradient of CPU load to early increase frequency

2013-04-03 Thread Viresh Kumar
Hi Stratos, On 4 April 2013 05:00, Stratos Karafotis strat...@semaphore.gr wrote: I tried to do some measurements simulating a CPU load with a loop that simply counts an integer. The first test simulates a CPU load that lasts 2 x sampling_rate = ~ 2us. The second ~4us and the third

Re: linux-next: manual merge of the imx-mxs tree with the pm tree

2013-04-03 Thread Viresh Kumar
On 4 April 2013 10:48, Stephen Rothwell s...@canb.auug.org.au wrote: Today's linux-next merge of the imx-mxs tree got a conflict in arch/arm/mach-imx/cpufreq.c between commits b43a7ffbf33b (cpufreq: Notify all policy-cpus in cpufreq_notify_transition()) and eb2f50ff93f0 (cpufreq: drivers:

Re: [PATCH 9/9] powerpc: cpufreq: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
On 3 April 2013 16:00, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Wed, 2013-04-03 at 15:00 +0530, Viresh Kumar wrote: On 31 March 2013 09:33, Viresh Kumar viresh.ku...@linaro.org wrote: Benjamin/Paul/Olof, Any comments on this? Ping!! I'm on vacation until end of April

Re: [PATCH v3 linux-next] cpufreq: ondemand: Calculate gradient of CPU load to early increase frequency

2013-04-04 Thread Viresh Kumar
On 4 April 2013 12:17, stratosk strat...@semaphore.gr wrote: Why do you suspect significant increased power? With ondemand the CPU will go down to lowest freq as soon as the load will decreased. And the measurement shows that the CPU load will decrease faster (because of faster

Re: [PATCH 5/9] cpufreq: integrator: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
Hi Linus, On 25 March 2013 15:41, Viresh Kumar viresh.ku...@linaro.org wrote: This patch moves cpufreq driver of ARM based integrator platform to drivers/cpufreq. Cc: Russell King li...@arm.linux.org.uk Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- arch/arm/Kconfig

Re: [PATCH 0/9] ARM: CPUFreq: Move drivers arch/arm/ - drivers/cpufreq

2013-04-04 Thread Viresh Kumar
On 4 April 2013 15:08, Arnd Bergmann arnd.bergm...@linaro.org wrote: Whole series Acked-by: Arnd Bergmann a...@arndb.de Thanks. but please post them another time with linux-arm-kernel on Cc. Yes, my fault. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

[PATCH 00/18] For-3.10: CPUFreq: Move drivers to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
earlier version: - Additional patch 18/18 Viresh Kumar (18): cpufreq: ARM: Arrange drivers in alphabetical order cpufreq: tegra: Move driver to drivers/cpufreq cpufreq: davinci: move cpufreq driver to drivers/cpufreq cpufreq: pxa3xx: move cpufreq driver to drivers/cpufreq cpufreq: pxa2xx: move

[PATCH 02/18] cpufreq: tegra: Move driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based tegra platform to drivers/cpufreq. Cc: Stephen Warren swar...@wwwdotorg.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren swar

[PATCH 03/18] cpufreq: davinci: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based davinci platform to drivers/cpufreq. Cc: Sekhar Nori nsek...@ti.com Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Sekhar Nori nsek...@ti.com

[PATCH 04/18] cpufreq: pxa3xx: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based pxa3xx platform to drivers/cpufreq. Cc: Eric Miao eric.y.m...@gmail.com Cc: Haojian Zhuang haojian.zhu...@gmail.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Eric Miao eric.y.m...@gmail.com

[PATCH 05/18] cpufreq: pxa2xx: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based pxa2xx platform to drivers/cpufreq. Cc: Eric Miao eric.y.m...@gmail.com Cc: Haojian Zhuang haojian.zhu...@gmail.com Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Eric Miao eric.y.m...@gmail.com

[PATCH 06/18] cpufreq: integrator: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based integrator platform to drivers/cpufreq. Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Linus Walleij linus.wall

[PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of Samsung's ARM based s3c24xx platform to drivers/cpufreq. Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Cc: linux-samsung-...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org

[PATCH 08/18] cpufreq: sa11x0: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of ARM based sa11x0 platform to drivers/cpufreq. Cc: Russell King li...@arm.linux.org.uk Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Arnd Bergmann a...@arndb.de --- arch/arm/Kconfig

[PATCH 09/18] cpufreq: AVR32: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of AVR32 based at32ap platform to drivers/cpufreq. Cc: hans-christian.egtv...@atmel.com Cc: Haavard Skinnemoen hskinnem...@gmail.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Hans-Christian Egtvedt egtv...@samfundet.no --- arch/avr32/Kconfig

[PATCH 12/18] cpufreq: ia64: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of IA64 architecture to drivers/cpufreq. Cc: Tony Luck tony.l...@intel.com Cc: Fenghua Yu fenghua...@intel.com Cc: linux-i...@vger.kernel.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Tony Luck tony.l...@intel.com --- arch/ia64/Kconfig

[PATCH 13/18] cpufreq: mips: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of MIPS architecture to drivers/cpufreq. Cc: Ralf Baechle r...@linux-mips.org Cc: linux-m...@linux-mips.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: John Crispin blo...@openwrt.org --- arch/mips/Kconfig | 9

[PATCH 14/18] cpufreq: sh: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. Cc: Paul Mundt let...@linux-sh.org Cc: linux...@vger.kernel.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Paul Mundt let...@linux-sh.org --- arch/sh/Kconfig| 18

[PATCH 15/18] cpufreq: unicore2: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of UNICORE-2 architecture to drivers/cpufreq. Cc: Guan Xuetao g...@mprc.pku.edu.cn Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- arch/unicore32/kernel/Makefile | 1

[PATCH 16/18] cpufreq: sparc: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of SPARC architecture to drivers/cpufreq. Cc: David S. Miller da...@davemloft.net Cc: sparcli...@vger.kernel.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: David S. Miller da...@davemloft.net --- arch/sparc/Kconfig

[PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of powerpc platform to drivers/cpufreq. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Olof Johansson o...@lixom.net Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- Compile

[PATCH 18/18] cpufreq: powerpc/platforms/cell: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of powerpc platforms/cell to drivers/cpufreq. Cc: Arnd Bergmann a...@arndb.de Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- Compile Tested only. arch/powerpc/platforms

[PATCH 11/18] cpufreq: cris: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq drivers of CRIS architecture to drivers/cpufreq. Cc: Jesper Nilsson jesper.nils...@axis.com Cc: Mikael Starvik star...@axis.com Cc: linux-cris-ker...@axis.com Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Jesper Nilsson jesper.nils...@axis.com --- arch

[PATCH 10/18] cpufreq: blackfin: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
This patch moves cpufreq driver of BLACKFIN architecture to drivers/cpufreq. Cc: Mike Frysinger vap...@gentoo.org Cc: uclinux-dist-de...@blackfin.uclinux.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Steven Miao real...@gmail.com --- arch/blackfin/mach-common/Makefile

[PATCH 01/18] cpufreq: ARM: Arrange drivers in alphabetical order

2013-04-04 Thread Viresh Kumar
Normally we keep drivers in alphabetical inside Kconfig and Makefile and over time this was broken for ARM cpufreq drivers. Fix it. Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Viresh Kumar viresh.ku...@linaro.org Acked-by: Stephen Warren swar...@nvidia.com Tested-by: Stephen Warren

Re: [PATCH 18/18] cpufreq: powerpc/platforms/cell: move cpufreq driver to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
On 4 April 2013 18:32, Arnd Bergmann a...@arndb.de wrote: Moving the files is good, but I don't see a reason to make the cbe_cpufreq.h header globally visible in include/linux/. Isn't it just used by as the interface between ppc_cbe_cpufreq_pmi.c and ppc_cbe_cpufreq.c? When i moved it

Re: [PATCH linux-next v8] cpufreq: convert the cpufreq_driver to use the rcu

2013-04-04 Thread Viresh Kumar
covert the cpufreq_data_lock to a rwlock v7: Rebase to use the already accepted half v8: Correct have_governor_per_policy Reviewed location of rcu_read_(un)lock in several spots Sorry for long delay or too many versions of this patch :) Acked-by: Viresh Kumar viresh.ku...@linaro.org

Re: [PATCH V4 1/2] cpufreq: ondemand: allow custom powersave_bias_target handler to be registered

2013-04-04 Thread Viresh Kumar
On 4 April 2013 21:49, Jacob Shin jacob.s...@amd.com wrote: diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c +static void od_set_powersave_bias(unsigned int powersave_bias) +{ + unsigned int cpu; + struct od_dbs_tuners *od_tuners; + +

Re: [PATCH 00/18] For-3.10: CPUFreq: Move drivers to drivers/cpufreq

2013-04-04 Thread Viresh Kumar
On 5 April 2013 04:06, Rafael J. Wysocki r...@sisk.pl wrote: On Thursday, April 04, 2013 06:24:08 PM Viresh Kumar wrote: Hi Rafael, These are all the remaining patches i have for 3.10. All of them have received Acks from their maintainers leaving powerpc ones. I have got an additional

Re: [PATCH V4 0/2] cpufreq: ondemand: add AMD specific powersave bias

2013-04-04 Thread Viresh Kumar
/amd_freq_sensitivity.c For the latest versions sent by you (including {get|put}_online_cpus()): Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 0/2] cpufreq/regulator: Handle regulators that defer probe with device tree bindings

2013-04-04 Thread Viresh Kumar
/core.c |4 ++-- 2 files changed, 16 insertions(+), 8 deletions(-) Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] cpufreq/intel_pstate: Set timer timeout correctly

2013-04-04 Thread Viresh Kumar
On Thu, Apr 4, 2013 at 11:05 PM, dirk.brande...@gmail.com wrote: From: Dirk Brandewie dirk.brande...@gmail.com The current calculation of the delay time is wrong and a cut and paste error from a previous experimental driver. This can result in the timeout being set to jiffies + 1 which

Re: [PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq

2013-04-05 Thread Viresh Kumar
On 4 April 2013 18:24, Viresh Kumar viresh.ku...@linaro.org wrote: This patch moves cpufreq driver of powerpc platform to drivers/cpufreq. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org Cc: Olof Johansson o...@lixom.net Cc: linuxppc

Re: [PATCH V4 0/2] cpufreq: ondemand: add AMD specific powersave bias

2013-04-05 Thread Viresh Kumar
On 5 April 2013 10:19, Viresh Kumar viresh.ku...@linaro.org wrote: For the latest versions sent by you (including {get|put}_online_cpus()): Acked-by: Viresh Kumar viresh.ku...@linaro.org Hi Rafael, I see that you have applied this patchset to bleeding-edge, but in wrong order. You have

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-05 Thread Viresh Kumar
On 5 April 2013 12:18, Kukjin Kim kgene@samsung.com wrote: Basically, this moving looks good to me, but should be re-worked based on for-next of samsung tree because this touches too many samsung stuff so this should be sent to upstream via samsung tree. Hmm... Its already applied in

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-05 Thread Viresh Kumar
On 4 April 2013 03:24, Tejun Heo t...@kernel.org wrote: Not a call, probably a module_param() so that it can be switched on/off during boot. You can make the param writable so that it can be flipped run-time but updating existing workqueues would be non-trivial and I don't think it's gonna be

Re: [PATCH] cpufreq: Raname index as data in cpufreq_frequency_table

2013-04-05 Thread Viresh Kumar
On 31 March 2013 09:16, Viresh Kumar viresh.ku...@linaro.org wrote: On 31 March 2013 07:16, Rafael J. Wysocki r...@sisk.pl wrote: On Sunday, March 31, 2013 07:03:04 AM Viresh Kumar wrote: On 31 March 2013 03:31, Rafael J. Wysocki r...@sisk.pl wrote: Sorry, I won't apply this. It changes too

Re: [PATCH] cpufreq: Raname index as data in cpufreq_frequency_table

2013-04-05 Thread Viresh Kumar
On 5 April 2013 16:15, Rafael J. Wysocki r...@sisk.pl wrote: OK Please resend it after v3.10-rc1 and I'll take it for v3.11. Surely, it can wait for that long. For sure. Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

[PATCH] sched: core: Fix spelling error inside comment

2013-04-05 Thread Viresh Kumar
sched_domains_numa_distance is written as sched_domains_nume_distance inside one of the comments. Fix it. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-07 Thread Viresh Kumar
On 5 April 2013 12:36, Viresh Kumar viresh.ku...@linaro.org wrote: On 5 April 2013 12:18, Kukjin Kim kgene@samsung.com wrote: Basically, this moving looks good to me, but should be re-worked based on for-next of samsung tree because this touches too many samsung stuff so this should

Re: [PATCH V6 1/4] cpufreq: exynos: Add cpufreq driver for exynos5440

2013-04-08 Thread Viresh Kumar
On 8 April 2013 13:47, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index f3f3b14..bce2195 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -42,6 +42,15 @@ config ARM_EXYNOS5250_CPUFREQ

Re: [PATCH V6 1/4] cpufreq: exynos: Add cpufreq driver for exynos5440

2013-04-08 Thread Viresh Kumar
On 8 April 2013 14:17, Viresh Kumar viresh.ku...@linaro.org wrote: On 8 April 2013 13:47, Amit Daniel Kachhap amit.dan...@samsung.com wrote: diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index f3f3b14..bce2195 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers

Re: [PATCH 07/18] cpufreq: s3c24xx: move cpufreq driver to drivers/cpufreq

2013-04-08 Thread Viresh Kumar
On 8 April 2013 14:45, Kukjin Kim kgene@samsung.com wrote: Rafael J. Wysocki wrote: Well, I'm dropping it. Please merge via the Samsung tree. OK, I will. I got patch file from Viresh, and there is a sign from Rafael, but it should be ack. So Rafael, let me use your ack on this patch

Re: [PATCH V6 0/4] cpufreq: exynos5440: support for cpufreq driver

2013-04-08 Thread Viresh Kumar
/cpufreq/cpufreq-exynos5440.txt create mode 100644 drivers/cpufreq/exynos5440-cpufreq.c With the resent of 1/4, Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 2/3] CLK: uninline clk_prepare_enable() and clk_disable_unprepare()

2013-04-08 Thread Viresh Kumar
On 17 December 2012 11:12, Dmitry Torokhov dmitry.torok...@gmail.com wrote: They do not _have_ to be non-inline, I think we should simply drop the first 2 patches and I will refresh and ressend the 3rd one. I haven't seen this patch since a long time? Any updates? -- To unsubscribe from this

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-08 Thread Viresh Kumar
On 5 April 2013 17:52, Tejun Heo t...@kernel.org wrote: On Fri, Apr 5, 2013 at 2:47 AM, Viresh Kumar viresh.ku...@linaro.org wrote: module_param()?? We can't compile kernel/workqueue.c as a module and hence i went with #define + a variable with functions to set/reset it... module_param works

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-08 Thread Viresh Kumar
On 4 April 2013 03:24, Tejun Heo t...@kernel.org wrote: Not a call, probably a module_param() so that it can be switched on/off during boot. You can make the param writable so that it can be flipped run-time but updating existing workqueues would be non-trivial and I don't think it's gonna be

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-08 Thread Viresh Kumar
On 8 April 2013 16:43, Jens Axboe ax...@kernel.dk wrote: And lets please have it off by default. The specialized configs / setups can turn it on, but we should default to better performance. Yes, we will. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH V4 1/4] workqueue: Add system wide system_freezable_unbound_wq

2013-04-08 Thread Viresh Kumar
On 8 April 2013 22:29, Steven Rostedt rost...@goodmis.org wrote: Looks like Amit was left off the patch 0, and missed the power savings explanation that you did there. Perhaps you should have included that in each patch change log. He isn't supposed to miss any of my emails, he is my manager

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-09 Thread Viresh Kumar
to get this done and want to get that a some review before touching other drivers and spamming LKML with other patches :) Here it is: From: Viresh Kumar viresh.ku...@linaro.org Date: Mon, 8 Apr 2013 16:45:40 +0530 Subject: [PATCH] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power

Re: [PATCH 17/18] cpufreq: powerpc: move cpufreq driver to drivers/cpufreq

2013-04-09 Thread Viresh Kumar
On 5 April 2013 12:16, Viresh Kumar viresh.ku...@linaro.org wrote: On 4 April 2013 18:24, Viresh Kumar viresh.ku...@linaro.org wrote: This patch moves cpufreq driver of powerpc platform to drivers/cpufreq. Cc: Benjamin Herrenschmidt b...@kernel.crashing.org Cc: Paul Mackerras pau...@samba.org

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-09 Thread Viresh Kumar
On 9 April 2013 14:48, Amit Kucheria amit.kuche...@linaro.org wrote: On Tue, Apr 9, 2013 at 1:00 PM, Viresh Kumar viresh.ku...@linaro.org wrote: diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig +config WQ_POWER_EFFICIENT + bool Workqueue allocated as UNBOUND for power efficiency

Re: [PATCH v4] cpufreq: powerpc: Add cpufreq driver for Freescale e500mc SoCs

2013-04-09 Thread Viresh Kumar
Mostly good now, V5 should be the final one. On 9 April 2013 14:02, yuantian.t...@freescale.com wrote: diff --git a/drivers/cpufreq/ppc-corenet-cpufreq.c b/drivers/cpufreq/ppc-corenet-cpufreq.c +static int corenet_cpufreq_target(struct cpufreq_policy *policy, + unsigned int

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-09 Thread Viresh Kumar
On 9 April 2013 15:23, Amit Kucheria amit.kuche...@linaro.org wrote: On Tue, Apr 9, 2013 at 1:00 PM, Viresh Kumar viresh.ku...@linaro.org wrote: Later one (Power oriented WQ) can be achieved if the workqueue is allocated with Rephrase as Power-efficient workqueues can be achieved... Ok

Re: [PATCH V4 3/4] block: queue work on unbound wq

2013-04-09 Thread Viresh Kumar
On 9 April 2013 15:28, Amit Kucheria amit.kuche...@linaro.org wrote: On Tue, Apr 9, 2013 at 3:25 PM, Viresh Kumar viresh.ku...@linaro.org wrote: But how will we know if the user of wq wants to save power or not? He must give some flag which is only used when power saving is enabled. We can't

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread Viresh Kumar
On 9 April 2013 16:07, Lukasz Majewski l.majew...@samsung.com wrote: On Mon, Apr 1, 2013 at 1:54 PM, Jonghwa Lee Our approach is a bit different than cpufreq_ondemand one. Ondemand takes the per CPU idle time, then on that basis calculates per cpu load. The next step is to choose the highest

Re: [PATCH 14/18] cpufreq: sh: move cpufreq driver to drivers/cpufreq

2013-04-09 Thread Viresh Kumar
On 9 April 2013 18:25, Simon Horman ho...@verge.net.au wrote: On Thu, Apr 04, 2013 at 06:24:22PM +0530, Viresh Kumar wrote: This patch moves cpufreq driver of SUPERH architecture to drivers/cpufreq. Why? I am missing the cover email where I assume the explanation lies. Hi Simon, The idea

Re: [PATCH V2 Resend 4/4] timer: Migrate running timer

2013-04-09 Thread Viresh Kumar
[Steven replied to a personal Ping!!, including everybody again] On 9 April 2013 19:25, Steven Rostedt rost...@goodmis.org wrote: On Tue, 2013-04-09 at 14:05 +0530, Viresh Kumar wrote: Ping!! Remind me again. What problem are you trying to solve? I was trying to migrate a running timer

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-09 Thread Viresh Kumar
On 9 April 2013 19:34, Sedat Dilek sedat.di...@gmail.com wrote: I have seen it on reboots. How to online/offline from sysfs? offline a cpu x with: echo 0 /sys/devices/system/cpu/cpux/online and online with echo 1 to same location. -- To unsubscribe from this list: send the line unsubscribe

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-09 Thread Viresh Kumar
On 9 April 2013 19:33, Rafael J. Wysocki r...@sisk.pl wrote: On Tuesday, April 09, 2013 02:47:39 PM Sedat Dilek wrote: On reboot I see hanging cpufreq with the help of kdb/kgdb? See screenshot. I have also a screenshot with next-20130326, so this issue seems not to be new. This is during

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-09 Thread Viresh Kumar
On 9 April 2013 21:38, Sedat Dilek sedat.di...@gmail.com wrote: With x=3 the system gets in an unuseable state. root# echo 0 /sys/devices/system/cpu/cpu3/online I could not write my reply and had to do a hard/cold reboot. The dmesg log I saw looked similiar to my digicam-shot. Few

Re: [PATCH 14/18] cpufreq: sh: move cpufreq driver to drivers/cpufreq

2013-04-09 Thread Viresh Kumar
On 10 April 2013 07:42, Simon Horman ho...@verge.net.au wrote: Thanks, I understand. I have no objections to this, but Paul should probably review it. It is already Acked by him and applied by Rafael. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH v3 linux-next] cpufreq: ondemand: Calculate gradient of CPU load to early increase frequency

2013-04-09 Thread Viresh Kumar
On 9 April 2013 22:26, Stratos Karafotis strat...@semaphore.gr wrote: On 04/05/2013 10:50 PM, Stratos Karafotis wrote: Hi Viresh, On 04/04/2013 07:54 AM, Viresh Kumar wrote: Hi Stratos, Yes, your results show some improvements. BUT if performance is the only thing we were looking

Re: [PATCH 9/9] powerpc: cpufreq: move cpufreq driver to drivers/cpufreq

2013-04-11 Thread Viresh Kumar
On 11 April 2013 12:29, Olof Johansson o...@lixom.net wrote: That's not very nice this late in the staging cycle. Give the powerpc guys a little more time than a single day to come back with test results, please. Yes we are waiting indefinitely for an Ack from powerpc guys.. If we can get a

[PATCH] cpufreq: Call __cpufreq_governor() with correct policy-cpus mask

2013-04-11 Thread Viresh Kumar
by policy. Signed-off-by: Viresh Kumar viresh.ku...@linaro.org --- drivers/cpufreq/cpufreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index fd97a62..3564947 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq

Re: linux-next: Tree for Apr 9 [cpufreq: NULL pointer deref]

2013-04-12 Thread Viresh Kumar
On 10 April 2013 11:44, Sedat Dilek sedat.di...@gmail.com wrote: I found this [RFC PATCH] kbuild: Build linux-tools package with 'make deb-pkg' from February 2012. Can't say what happened to it... Sedat, Sorry for being late. I am down with Fever and throat infection since few days. Still

Re: [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu

2013-03-28 Thread Viresh Kumar
On 28 March 2013 23:43, Tejun Heo t...@kernel.org wrote: Ping. Peter, Ingo? Thanks for your ping, even i was thinking of it since sometime :) Viresh, would it be difficult to make another measurement of the same workload with the said workqueues converted to unbound? I think that would at

Re: [PATCH V2 0/2] cpufreq: ondemand: add AMD specific powersave bias

2013-03-28 Thread Viresh Kumar
/cpufreq/amd_freq_sensitivity.c Acked-by: Viresh Kumar viresh.ku...@linaro.org -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH v3 2/7] USB: EHCI: make ehci-spear a separate driver

2013-03-28 Thread Viresh Kumar
/config options. Signed-off-by: Deepak Saxena dsax...@linaro.org Signed-off-by: Manjunath Goudar manjunath.gou...@linaro.org Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: Viresh Kumar viresh.li...@gmail.com This version has changed from what i Acked, but it still looks fine. Thanks

Re: [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu

2013-03-29 Thread Viresh Kumar
On 28 March 2013 23:43, Tejun Heo t...@kernel.org wrote: Viresh, would it be difficult to make another measurement of the same workload with the said workqueues converted to unbound? I think that would at least provide a nice reference point. My heart is shattered after getting the results :)

[PATCH] tools: cpufreq: Fix cpufreq-info print messages for affected[related]_cpus

2013-03-29 Thread Viresh Kumar
. Following are the new definitions of these variables: Related_cpus: All (Online Offline) CPUs that run at the same hardware frequency. Affected_cpus: Online CPUs that run at the same hardware frequency. Above definitions are more consistent with latest cpufreq core code. Signed-off-by: Viresh

Re: [PATCH V3 3/7] workqueue: Add helpers to schedule work on any cpu

2013-03-29 Thread Viresh Kumar
On 29 March 2013 23:10, Tejun Heo t...@kernel.org wrote: So the scheduler does know what it's doing after all, which is a nice news. Given the result, the best thing to do would be somehow marking these workqueues as unbound for powersaving? Yes. I am going to do it soon. -- To unsubscribe

<    1   2   3   4   5   6   7   8   9   10   >