As for i2c-core, let the SPI core handle the removal of the device's
drvdata, after a remove() or a probe() failure.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/spi/spi.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers
The Technologic Systems TS-5500 platform provides 3 digital I/O headers:
DIO1, DIO2, and the LCD port, that may be used as a DIO header.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
Signed-off-by: Jerome Oufella jerome.oufe...@savoirfairelinux.com
---
drivers/gpio/Kconfig
Hi,
I think the Kconfig patch is wrong, please do not consider this
patchset. I'll send a v2 very soon.
On Tue, 2012-09-25 at 20:42 -0400, Vivien Didelot wrote:
The Technologic Systems TS-5500 platform provides 3 digital I/O headers:
DIO1, DIO2, and the LCD port, that may be used as a DIO
Hi Guenter,
On Tue, 2012-10-02 at 22:07 -0700, Guenter Roeck wrote:
On Tue, Oct 02, 2012 at 11:33:27PM -0400, Vivien Didelot wrote:
From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com
The ADS7830 device is almost the same as the ADS7828,
except that it does 8-bit sampling
s/address_data/address_list/ in addition to c3813d6.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
include/linux/i2c.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/i2c.h b/include/linux/i2c.h
index 8e25a91..8d87329 100644
--- a/include
...@savoirfairelinux.com
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 11 +--
drivers/hwmon/Kconfig | 7 ---
drivers/hwmon/ads7828.c | 25 +++--
3 files changed, 32 insertions(+), 11 deletions(-)
diff --git
style issues,
avoiding function prototypes and using convenient macros such as
module_i2c_driver().
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 35 --
drivers/hwmon/ads7828.c | 228
Hi,
Grant, Linus, any feedback?
Thanks,
Vivien
On Wed, 2012-09-26 at 11:37 -0400, Vivien Didelot wrote:
+config GPIO_TS5500
+ tristate TS-5500 DIO Headers
+ depends on TS5500
+ help
+ This driver supports the 3 Digital I/O headers of the
Technologic
Hi Linus,
On Mon, 2012-10-08 at 12:38 +0200, Linus Walleij wrote:
On Wed, Sep 26, 2012 at 2:42 AM, Vivien Didelot
vivien.dide...@savoirfairelinux.com wrote:
The Technologic Systems TS-5500 platform provides 3 digital I/O headers:
DIO1, DIO2, and the LCD port, that may be used as a DIO
Hi Linus,
On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote:
Well that may also be a pretty big step if you just want to mux
one bank of GPIO. I'm a bit ambivalent. But if you want to tie
pin and gpio information together and name all pins, pinctrl
is what should suit you best.
In the
patch https://lkml.org/lkml/2012/11/1/314
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/spi/spi.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
index 84c2861..fe636fe 100644
--- a/drivers/spi
Hi Grant,
On Tue, 2012-12-04 at 14:56 +, Grant Likely wrote:
Instead of clearing the pointer only in the spi code, perhaps the
checks should be in really_probe() and __device_release_driver() so it
covers all bus types. Also, don't clear the pointer. Just use
dev_err() to report on the
Hi Ingo,
This patch still appears to have some problems with certain
(rare) LEDS .config variations:
arch/x86/built-in.o: In function `ts5500_init':
ts5500.c:(.init.text+0xdae6): undefined reference to
`led_classdev_register'
Config attached.
Please fix resend.
I think the
Hi Jiri,
hid-blink sounds too generic to me, taking into account that this is
not
'generic HID blinking' framework, but rather a specific device driver
for
a particular device.
So something like hid-thingm-blink sounds more reasonable to me.
Ok, I'll name the file hid-thingm-blink1.c
-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-driver-hid-blink1 | 23 ++
MAINTAINERS | 5 +
drivers/hid/Kconfig | 10 +
drivers/hid/Makefile | 1 +
drivers
Hi,
I wrote:
Should I keep the Kconfig macro CONFIG_BLINK1 or CONFIG_THINGM_BLINK1
sounds better?
CONFIG_HID_THINGM_BLINK1 is definitely more explicit. Here's a link to the v2:
https://lkml.org/lkml/2013/1/21/435
Thanks,
Vivien
--
To unsubscribe from this list: send the line unsubscribe
Hi Simon,
+++ b/Documentation/ABI/testing/sysfs-driver-hid-blink1
@@ -0,0 +1,23 @@
+What: /sys/class/leds/blink(1)::serial/rgb
+Date: January 2013
+Contact: Vivien Didelot vivien.dide...@savoirfairelinux.com
+Description: The ThingM blink(1) is an USB
Hi,
Shouldn't the name presented in the sys/class/leds directories
change
appropriately too?
The directory name for the device under /sys/class/leds is
blink(1)::serial,
where serial is the last 4 digits of the device serial number
(the first 4
digits are always the same:
The vendor's name is ThingM and the product's name is blink(1),
not blink.
Given that, would you prefer to keep blink(1)::1234, or would it
rather be
thingm-blink1::1234 (avoiding parenthesis)?
I ask the same question for the driver name, which is actually
blink(1).
Actually,
is version 3. It updates the name of the source file, the
driver and the led sysfs entry, according to comments from Jiri Kosina
and Simon Wood.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-driver-hid-thingm | 23 ++
MAINTAINERS
, and updates the impacted board-da8{3,5}0-evm.c, and
board-mityomapl138.c files accordingly. It also sets the SPI platform
data static, as it doesn't need to be exported.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
arch/arm/mach-davinci/board-da830-evm.c| 9 +++--
arch/arm
} to 2V, and {0,-4V} to 4V on the MAX199.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/max197 | 60 ++
drivers/hwmon/Kconfig| 9 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/max197.c | 378
Hi Guenter,
Thanks for your detailed comments. I'll send a new version soon.
About the following comment, I agree with you. However as there is no
convention for this case, for now I would prefer to stick with the model as
seen in drivers such as sht15.
In the future, I think we could add a
} to 2V, and {0,-4V} to 4V on the MAX199.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/max197 | 60 ++
drivers/hwmon/Kconfig| 9 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/max197.c | 377
I guess we're too fast!
I've just seen your reply, this is much cleaner, indeed.
I'll update the max197 driver, and fix the sht15 driver as soon as I can.
Thanks,
Vivien
- Mail original -
De: Guenter Roeck li...@roeck-us.net
À: Vivien Didelot vivien.dide...@savoirfairelinux.com
Cc: lm
} to 2V, and {0,-4V} to 4V on the MAX199.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/max197 | 60 ++
drivers/hwmon/Kconfig| 9 +
drivers/hwmon/Makefile | 1 +
drivers/hwmon/max197.c | 349
Declare an array of platform_device_id, instead of registering a driver
for each supported chip. This makes the code cleaner.
Also add a module description.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hwmon/sht15.c | 94
Yes, good to know that it exists. Thanks for spotting this and applying the
patches!
Regards,
Vivien
- Mail original -
De: Guenter Roeck li...@roeck-us.net
À: Jean Delvare kh...@linux-fr.org
Cc: Vivien Didelot vivien.dide...@savoirfairelinux.com,
lm-sens...@lm-sensors.org, linux-kernel
Hi,
On Tue, 2012-09-04 at 10:20 -0700, Guenter Roeck wrote:
Applied to -next.
Hm, now it's probably to late, but for this kind of general
purpose ADC the IIO
framework is in my opinion the better place to add support for
it.
Possibly. If someone writes an iio
The manufacturer datasheet can be found on the Micron website,
under the name n25q_256mb_3v_65nm.pdf:
http://www.micron.com/search?source=psq=n25q_256mb_3v_65nm
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/mtd/devices/m25p80.c | 3 +++
1 file changed, 3
Hi Linus,
I rewrote some parts according to your comments, but I still have some
concerns.
On Fri, 2012-10-12 at 22:53 +0200, Linus Walleij wrote:
(...)
+static int ts5500_gpio_to_irq(struct gpio_chip *chip, unsigned
offset)
+{
+ const struct ts5500_dio line =
#Digital_I.2FO
This driver is not limited to the TS-5500 blocks. It can be extended to
support similar boards pin blocks, such as on the TS-5600.
This patch is the V2 of the previous https://lkml.org/lkml/2012/9/25/671
with corrections suggested by Linus Walleij.
Signed-off-by: Vivien Didelot
Hi Sekhar,
On Wed, 2012-11-28 at 14:19 +0530, Sekhar Nori wrote:
Hi Vivien,
On 9/11/2012 5:59 AM, Vivien Didelot wrote:
Without this patch, da8xx_register_spi() registers the SPI board info,
the SPI controller, and sets its number of chipselect to the size of the
static spi_board_info
-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-driver-hid-blink1 | 25 ++
MAINTAINERS | 5 +
drivers/hid/Kconfig | 10 +
drivers/hid/Makefile | 1 +
drivers
Hi Grant,
Please take a look at either send me a follow-on patch to convert it
to use gpio-generic, or tell my why gpio-generic isn't appropriate here.
The gpio-generic driver is not appropriate here because Technologic Systems
x86-based platforms do not use a typical GPIO implementation.
To
on-board LED,
2 pin blocks (GPIO) and its analog/digital converter. It can be extended
to support other Technologic Systems products, such as the TS-5600.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-platform-ts5500 | 47
MAINTAINERS
by removing unused macros, and moving
the driver declaration to avoid some function prototypes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 12 +++-
drivers/hwmon/Kconfig | 7 ++-
drivers/hwmon/ads7828.c | 137
Oops, I used the wrong address for Guenter. Here we go.
Thanks,
Vivien
- Mail original -
De: Vivien Didelot vivien.dide...@savoirfairelinux.com
À: lm-sens...@lm-sensors.org
Cc: Guillaume Roguez guillaume.rog...@savoirfairelinux.com, Guenter Roeck
guenter.ro...@ericsson.com, Jean Delvare
On Mon, 2012-10-01 at 14:29 -0700, Guenter Roeck wrote:
One change per patch, please. Please handle the cleanup with a
separate patch.
Other than that, not sure if the changes warrant a copyright, and you
can not
add a copyright for a third person (or replace a Written by
statement with a
* Remove unused macros;
* Point to the documentation;
* Coding Style fixes (Kernel Doc, spacing);
* Move driver declaration to avoid adding function prototypes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hwmon/ads7828.c | 91
...@savoirfairelinux.com
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 12 --
drivers/hwmon/Kconfig | 7 +++---
drivers/hwmon/ads7828.c | 58 -
3 files changed, 55 insertions(+), 22 deletions(-)
diff
Hi Guenter,
On Mon, 2012-10-01 at 18:07 -0700, Guenter Roeck wrote:
On Mon, Oct 01, 2012 at 07:16:23PM -0400, Vivien Didelot wrote:
* Remove unused macros;
* Point to the documentation;
* Coding Style fixes (Kernel Doc, spacing);
* Move driver declaration to avoid adding function
Hi Guenter,
On Mon, 2012-10-01 at 18:20 -0700, Guenter Roeck wrote:
On Mon, Oct 01, 2012 at 07:16:24PM -0400, Vivien Didelot wrote:
From: Guillaume Roguez guillaume.rog...@savoirfairelinux.com
The ADS7830 device is almost the same as the ADS7828,
except that it does 8-bit sampling
* Remove module parameters, add a ads7828_platform_data;
* Move driver declaration to avoid adding function prototypes;
* Remove unused macros;
* Coding Style fixes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 31 +++--
drivers
...@savoirfairelinux.com
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 12 ++--
drivers/hwmon/Kconfig | 7 ---
drivers/hwmon/ads7828.c | 45 ++---
3 files changed, 48 insertions(+), 16 deletions(-)
diff
Hi Guenter,
Some of those changes weren't in the mainline tree a few days ago.
I'll cherry-pick them and send a update very soon :-)
Thanks for the tips,
Vivien
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
...@savoirfairelinux.com
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 12 ++--
drivers/hwmon/Kconfig | 7 ---
drivers/hwmon/ads7828.c | 45 ++---
3 files changed, 48 insertions(+), 16 deletions(-)
diff
* Remove module parameters, add a ads7828_platform_data;
* Move driver declaration to avoid adding function prototypes;
* Remove unused macros;
* Coding Style fixes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/hwmon/ads7828 | 31 +++--
drivers
Hi Mark, Grant,
On Mon, 14 Jan 2013 02:51:45 +, Mark Brown
broo...@opensource.wolfsonmicro.com wrote:
On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote:
As for i2c-core, let the SPI core handle the removal of the
device's
drvdata, after a remove() or a probe
(work_funct_t), we wake the queue up directly
without updating the data-state flag, to notice the waiter of the I/O
error.
The patch also makes minor cleanups: s/error_ret/unlock for some labels
and uses devm_gpio_request_one() for the clock line.
Signed-off-by: Vivien Didelot vivien.dide
.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hwmon/sht15.c | 43 ++-
1 file changed, 34 insertions(+), 9 deletions(-)
diff --git a/drivers/hwmon/sht15.c b/drivers/hwmon/sht15.c
index 9a594e6..10b078c 100644
--- a/drivers
This patch renames the supply_uV* variables to supply_uv* to avoid
CamelCase as warned by the checkpatch.pl script.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hwmon/sht15.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff
Hi Sekhar,
You wrote:
Why do you need to add these definitions? If it is for a new platform
you are working on, then it should be supported using DT, in which
case
we use the pinctrl-single driver and define the muxing needed in
.dts/.dtsi files.
Ok, good to know.
Thanks,
Vivien
--
To
*mac_addr = ethernet_pdata-mac_addr;$
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
MAINTAINERS| 2 +-
arch/arm/mach-at91/board-sam9260ek.c | 2 +-
arch/arm/mach-at91/board-sam9263ek.c | 2 +-
arch/arm/mach-davinci/board-da830-evm.c
Wolfram wrote:
On Fri, Aug 23, 2013 at 02:38:20PM -0400, Vivien Didelot wrote:
This patch moves the at24.h header from include/linux/i2c to
include/linux/platform_data and updates existing support
accordingly.
This message explains what the patch does but not why the change is
wanted
Hi,
Alexander wrote:
Can this file be additionally renamed to misc-at24.h to reflect
belongs to a particular subsystem?
I'm not sure about that. Having the subsystem name at the beginning of
the file doesn't seem to be a convention for all subsystems. For
instance, this is true for gpio, spi
Wolfram wrote:
IMHO it makes sense. Why wouldn't we want all platform_data in
include/linux/platform_data/?
For the same reason we don't want all driver source files in one
directory? It's a mess.
Well, that's different. Not all drivers expose platform data, but many
subsystems have
Hi Linus,
You wrote:
But:
drivers/gpio/gpio-pca953x.c | 2 +-
(...)
diff --git a/drivers/gpio/gpio-pca953x.c
b/drivers/gpio/gpio-pca953x.c
index 426c51d..8804aec 100644
--- a/drivers/gpio/gpio-pca953x.c
+++ b/drivers/gpio/gpio-pca953x.c
@@ -18,7 +18,7 @@
Without this patch, the values for ideality (register 0x4b) and ideality
selection mask (register 0x4c) are inverted.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hwmon/max6697.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers
This patch moves the pca953x.h header from include/linux/i2c to
include/linux/platform_data and updates existing support accordingly.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
arch/arm/mach-at91/board-snapper9260.c | 2 +-
arch/arm/mach-davinci/board-da850-evm.c
a MAX11603 on a ICH7 controller.
This patch also simplifies the max1363_write_basic_config() routine to
use the struct max1363_state fields directly.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/iio/adc/max1363.c | 76
filename.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/iio/adc/max1363.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/iio/adc/max1363.c b/drivers/iio/adc/max1363.c
index e283f2f..1228272 100644
--- a/drivers/iio/adc/max1363.c
Add include guard to include/linux/platform_data/sht15.h to prevent
multiple inclusion.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
include/linux/platform_data/sht15.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/platform_data/sht15.h
b
Add include guard to include/linux/platform_data/max197.h to prevent
multiple inclusion.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
include/linux/platform_data/max197.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/linux/platform_data/max197.h
b
As this patch mainly touches arch/arm/*, Olof/Kevin, would you mind
applying it?
The first message in thread is here: https://lkml.org/lkml/2013/7/31/552
Here are the previous ACKs:
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: H Hartley Sweeten hswee...@visionengravers.com
This patch moves the pca953x.h header from include/linux/i2c to
include/linux/platform_data and updates existing support accordingly.
Acked-by: Linus Walleij linus.wall...@linaro.org
Acked-by: H Hartley Sweeten hswee...@visionengravers.com
Signed-off-by: Vivien Didelot vivien.dide
Hi Wolfram,
Wolfram wrote:
IMHO it makes sense. Why wouldn't we want all platform_data in
include/linux/platform_data/?
For the same reason we don't want all driver source files in one
directory? It's a mess.
Well, that's different. Not all drivers expose platform data, but
*mac_addr = ethernet_pdata-mac_addr;$
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
MAINTAINERS | 2 +-
arch/arm/mach-at91/board-sam9260ek.c| 2 +-
arch/arm/mach-at91/board-sam9263ek.c| 2 +-
arch/arm/mach-davinci/board-da830-evm.c
This patch adds some pinmux definitions that we needed, such as SPI0,
SPI1 and some GPIO.
Note: I sent the patch as an RFC because I would like a confirmation for the
appropriate name for SPI*_SCS* and EMA_A_RW pinmuxes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
arch
-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-driver-hid-thingm | 8 -
drivers/hid/hid-thingm.c | 304 +++---
drivers/leds/Kconfig | 2 +
3 files changed, 209 insertions(+), 105 deletions
does not support setting a color for a
single RGB chip, so it was changed to 'c' (fade) with a timeout of 0.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hid/hid-thingm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid
As for the play sysfs attribute, remove this other non-standard
attribute, so the driver only implements what is required to switch the
LED on and off. Thus, a fade time won't be ideal for some fast-changing
triggers.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
to switch on and off the LED.
This feature is still easily accessible through hidraw.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-driver-hid-thingm | 7 -
drivers/hid/hid-thingm.c | 33 ---
2
This patchset introduces the support of the blink(1) mk2 device, after a
refactoring of the thingm driver. It removes non-standard sysfs attributes and
uses work queues to fix the usage of triggers with this device.
Vivien Didelot (4):
HID: (thingm) remove the play sysfs attribute
HID
Add a new name attribute to the ts5500 sysfs group, to clarify which
supported board model it is.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
Documentation/ABI/testing/sysfs-platform-ts5500 | 7 +++
arch/x86/platform/ts5500/ts5500.c | 23
This patchset extends the TS-5500 platform driver to support the very similar
Technologic Systems TS-5400 board (like the others from the TS-5x00 serie).
The TS-5400 also has 2 GPIO blocks, which will be declared in a future patch,
once the gpio-ts5500 driver will be modified accordingly.
Vivien
This patch extends the TS-5500 platform driver to support the similar
Technologic Systems TS-5400 Single Board Computer.
http://wiki.embeddedarm.com/wiki/TS-5400
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
arch/x86/platform/ts5500/ts5500.c | 21 +
1
Use the DEVICE_ATTR_RO helper macro to simplify the declaration of
read-only sysfs attributes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
arch/x86/platform/ts5500/ts5500.c | 50 +--
1 file changed, 22 insertions(+), 28 deletions
: 0x0330
mdio-gpio mdio-gpio.0: - addr: 0x1b reg: 0x09 val: 0x
This is convenient to dynamically debug operations through debugfs with:
echo file mv88e6xxx.c +p debugfs/dynamic_debug/control
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/net/dsa/mv88e6xxx.c
the redundant check for ret 0.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/net/dsa/mv88e6352.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c
index 258d9ef..e13adc7
Hi Guenter,
-#define MAX6369_WDSET (7 0)
-#define MAX6369_WDI(1 3)
Not really sure I understand why you remove those constants.
that is personal preference, not cleanup. Someone else might
submit another cleanup later on and re-introduce them.
Indeed, I should have
Hi Guenter,
For sysfs file attributes, only read and write permisssions make sense.
Minor typo, there's an extra 's' to permissions.
Mask provided attribute permissions accordingly and send a warning
to the console if invalid permission bits are set.
Cc: Vivien Didelot vivien.dide
There is no reason to set the range attribute executable to the user and
group, and writable to the group. Fix the permission to 0644.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hid/hid-lg4ff.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Use the DEVICE_ATTR_RW macro to reduce boiler plate and move the
attribute declaration to get rid of function signatures.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/hid/hid-lg4ff.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git
Hi Guenter,
@@ -55,6 +55,12 @@ static int create_files(struct kernfs_node *parent,
struct kobject *kobj,
if (!mode)
continue;
}
+
+WARN(mode ~(S_IRUGO | S_IWUGO |
Hi Corentin,
Use the attribute indexes and concise the if statements.
Why ? I really don't see that as an improvement.
The improvement is code clarity and maintainability. I'm not use we want
to keep multiple returns and this goto thing. I think per-attribute
if-statements are clearer.
Hi Guenter, Florian,
- ds-hwmon_dev = hwmon_device_register_with_groups(NULL,
+ ds-hwmon_dev = hwmon_device_register_with_groups(parent,
ds-hwmon_name, ds,
dsa_hwmon_groups);
if (IS_ERR(ds-hwmon_dev))
.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
net/dsa/slave.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 515569f..589aafd 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -46,6 +46,7 @@ void dsa_slave_mii_bus_init(struct
Set the dsa device as the parent of the hwmon device, in order to link
the hwmon subsystem under the corresponding /sys/devices/platform/dsa.X/
sysfs directory.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
net/dsa/dsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi Darren,
Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes
declarations.
It does a lot more than that, including a lot of seemingly
superfluous reformatting of function declarations and renaming.
What do you mean? DEVICE_ATTR_RW(foo) requires foo_show() and foo_store()
functions,
Hi Guenter, Greg,
This commit uses all the UGO bits returned by is_visible instead
of OR'ing them with the default attribute mode.
Concretely, this allows a driver to use macros like DEVICE_ATTR_RW
to set the attribute show and store functions and remove the
S_IWUSR permission in
macros like DEVICE_ATTR_RW to
set the attribute show and store functions and remove the S_IWUSR
permission in is_visible if the implementation doesn't provide a setter.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
fs/sysfs/group.c | 12 +++-
1 file changed, 7 insertions
Hi Greg,
On Fri, Jan 16, 2015 at 04:29:10PM -0500, Vivien Didelot wrote:
Using the optional is_visible function, it is actually possible to
either hide an attribute, or add a new permission, but not remove
one.
What code wants to remove attributes?
Sorry, I meant removing a permission
With a Lucid platform, asus_sysfs_is_visible() returns a boolean for
ls_switch and ls_level attributes. Fix that and also s/supported/ok/ and
s/asus-handle/handle/ to avoid lines wider than 80 chars.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/platform/x86/asus
Use DEVICE_ATTR_{RO,WO,RW} macros to simplify attributes declarations.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/platform/x86/asus-laptop.c | 95 ++
1 file changed, 46 insertions(+), 49 deletions(-)
diff --git a/drivers
With a Lucid platform, asus_sysfs_is_visible() returned a boolean for
ls_switch and ls_level attributes.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/platform/x86/asus-laptop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform
Use the attribute indexes and concise the if statements.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/platform/x86/asus-laptop.c | 98 --
1 file changed, 40 insertions(+), 58 deletions(-)
diff --git a/drivers/platform/x86/asus
Remove the ARM Kconfig dependency since the Maxim MAX63xx devices are
architecture independent.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/Kconfig b/drivers
over the platform setting. If not set, it will still
default to DEFAULT_HEARTBEAT.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/watchdog/max63xx_wdt.c| 8 ++--
include/linux/platform_data/max63xx_wdt.h | 2 ++
2 files changed, 8 insertions(+), 2
;
* constify timeouts;
* factorize the SET write operations;
* few typos and comments...
This will help introduce new features to the driver.
Signed-off-by: Vivien Didelot vivien.dide...@savoirfairelinux.com
---
drivers/watchdog/Kconfig | 7 +-
drivers/watchdog/max63xx_wdt.c | 207
1 - 100 of 3273 matches
Mail list logo
