From: Frank Rowand
Hi All,
This is version 2 of this email.
Changes from version 1:
- some rewording of the text
- removed new (theoretical) dtc directive "/connector/"
- added compatibility between mother board and daughter board
- added info on applying a
From: Frank Rowand
This patch has been compiled but has not been booted. It is likely
to contain bugs.
Problem: mother boards may contain multiple connectors that daughter
boards may be attached to. If two of the daughter boards can be
described by the same .dtsi
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 48 +---
1 file changed, 17 insertions(+), 31 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
From: Frank Rowand
Remove comments that state the obvious, to reduce clutter
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 31 ++-
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 4e6df385118b..664c97e1ecb4
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 51 ---
1 file changed, 32 insertions(+), 19 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 172 +-
1 file changed, 85 insertions(+), 87 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 708daca1d522..76c09cb57eae 100644
---
From: Frank Rowand
drivers/of/resolve.c is a bit difficult to read. Clean it up so
that review of future overlay related patches will be easier.
Most of the patches are intended to be reformatting, with no functional
change. Patches that are expected to have a
From: Frank Rowand
A small number of such comparisons remain where they provide more
clarity of the numeric nature of a variable.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 42 --
1 file
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 3d123b612789..0ce38aa0ed3c 100644
---
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 664c97e1ecb4..3f7cf569c7ea 100644
---
From: Frank Rowand
This unused variable is a reminder that symbols in overlays are
not available to subsequent overlays. If such a feature is
desired then there are several ways it could be implemented.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 28
1 file changed, 28 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index 4ff0220d7aa2..93a7ca0bf98c 100644
From: Frank Rowand
The single line blocks were created by previous patches in the series.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 25 -
1 file changed, 8 insertions(+), 17 deletions(-)
diff --git
From: Frank Rowand
drivers/of/resolve.c is a bit difficult to read. Clean it up so
that review of future overlay related patches will be easier.
Most of the patches are intended to be reformatting, with no functional
change. Patches that are expected to have a
From: Frank Rowand
Update comments to better explain what functions are doing.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 66 ---
1 file changed, 47 insertions(+), 19 deletions(-)
From: Frank Rowand
Rename variables to better reflect what their purpose is. As a side
effect, this reduces the need for some of the comments previously
removed in this series.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 172
From: Frank Rowand
Remove "__of_" prefix from local function names. The pattern of
a leading "__" is used in drivers/of/ to signify a function that
must be called with a lock held. These functions do not fit
that pattern.
Signed-off-by: Frank Rowand
From: Frank Rowand
Value of pointer was calculated in an earlier block than
where it was used. Move it down into the block where it
is used, immediately before where is is checked to be valid.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Add a single pr_err() to cover a range of errors that were reported
by several pr_err() that were removed earlier in this series.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 18 --
1 file
From: Frank Rowand
Remove unused pointer to node "__symbols__".
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index
From: Frank Rowand
Remove extra debug and error printks. A single pr_err() will
be added at the end of this series to replace many of these
error messages.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 53
From: Frank Rowand
Remove comments that report what is obvious from the code.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 31 ++-
1 file changed, 2 insertions(+), 29 deletions(-)
diff --git
From: Frank Rowand
Remove BUG_ON(), which is frowned upon and not needed here.
Restructure to remove some excessive complexity.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 48 +---
1
From: Frank Rowand
Some function names are misleading or do not provide a good
sense of what they do. Rename the functions to ne more
informative.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 22 +++---
1 file
From: Frank Rowand
Convert comparisons to zero or NULL to logical expressions. A
small number of such comparisons remain where they provide more
clarity of the numeric nature of a variable.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Remove a redundant check of buffer size.
Signed-off-by: Frank Rowand
---
drivers/of/resolver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c
index
From: Frank Rowand
Make pr_fmt() in fdt.c consistent with all other files in drivers/of/
Signed-off-by: Frank Rowand
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
From: Frank Rowand
of_device_make_bus_id() was changed to non-static by commit c66012253800
("of/device: Make of_device_make_bus_id() usable by other code") more than
6 years ago, but there are no users of it outside of platform.c. Make the
function static again.
From: Frank Rowand
of_device_make_bus_id() was changed to non-static by commit c66012253800
("of/device: Make of_device_make_bus_id() usable by other code") more than
6 years ago, but there are no users of it outside of platform.c. Make the
function static again.
From: Frank Rowand
Make pr_fmt() in fdt.c consistent with all other files in drivers/of/
Signed-off-by: Frank Rowand
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
From: Frank Rowand
of_dma_get_range() has workaround code to fixup a device tree that
incorrectly specified a mask instead of a size for property
dma-ranges. That device tree was fixed a year ago in v4.6, so
the workaround is no longer needed. Leave a data validation
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
From: Frank Rowand
When adjusting overlay phandles to apply to the live device tree, can
not modify the property value because it is type const.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to const
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files
From: Frank Rowand
When adjusting overlay phandles to apply to the live device tree, can
not modify the property value because it is type const.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up of
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Signed-off-by: Frank Rowand
---
There are checkpatch warnings. I have reviewed them and
From: Frank Rowand
The dtc compiler version that adds initial support was available
in 4.11-rc1. Add the ability to set the dtc compiler flags needed
by overlays.
Signed-off-by: Frank Rowand
---
scripts/Makefile.lib | 2 ++
1 file changed, 2
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Frank Rowand (2):
of: add support of dtc compiler flags for device tree overlays
of: Add unit tests for
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Changes from v1:
- Move overlay base dtb unflattening into unittest.c. Call from fdt.c.
- Clarify file and
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Signed-off-by: Frank Rowand
---
There are checkpatch warnings. I have reviewed them and
From: Frank Rowand
The dtc compiler version that adds initial support was available
in 4.11-rc1. Add the ability to set the dtc compiler flags needed
by overlays.
Signed-off-by: Frank Rowand
---
scripts/Makefile.lib | 2 ++
1 file changed, 2
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a
From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after the patch is applied.
Before this patch is applied:
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after the patch is applied.
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to
From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after the patch is applied.
Before this patch is applied:
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after the patch is applied.
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to
From: Frank Rowand
Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000
The error will occur if the configuration is set to:
CONFIG_OF_OVERLAY y
CONFIG_OF_UNITTEST y
CONFIG_OF_DYNAMIC y
From: Frank Rowand
Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error:
OF: ERROR: Bad of_node_put() on /soc/spmi@fc4cf000/pm8941@1/regulators
The error will occur if the configuration is set to:
CONFIG_OF_OVERLAY y
CONFIG_OF_UNITTEST y
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after this commit.
Before
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after this commit.
Before
From: Frank Rowand
Documentation/process/submitting-patches.rst contains a non-ascii
character. Change it to the ascii equivalent.
Signed-off-by: Frank Rowand
---
Documentation/process/submitting-patches.rst | 2 +-
1 file changed, 1
From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after this commit.
Before this commit:
Console error
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a
From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after this commit.
Before this commit:
Console error
From: Frank Rowand
Update the cpp include flags for compiling device tree dts files
to match the changes made to the kernel build process in
commit d5d332d3f7e8 ("devicetree: Move include prefixes from arch
to separate directory").
Cc: # 4.12
From: Frank Rowand
Rafael, can you please take patch 1?
Rob, can you please take patch 2?
Several maintainers are impacted by changes to fwnode.h, add a
file entry for those maintainers.
Frank Rowand (2):
MAINTAINERS: device property: acpi: add fwnode.h
MAINTAINERS:
From: Frank Rowand
Device tree is impacted by changes to fwnode.h, add a file entry
to OPEN FIRMWARE AND FLATTENED DEVICE TREE
Signed-off-by: Frank Rowand
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS
From: Frank Rowand
ACPI is impacted by changes to fwnode.h, add a file entry
to ACPI
Signed-off-by: Frank Rowand
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 205d3977ac46..c0ac362e850a 100644
From: Frank Rowand
Add ABI documentation for /sys/firmware/fdt
Change obsolete contact for /sys/firmware/devicetree/* to mail list
Signed-off-by: Frank Rowand
---
changes from v1:
- Remove obsolete email address as contact for
From: Frank Rowand
Add ABI documentation for /sys/firmware/fdt
Update contact email for /sys/firmware/devicetree/* and add mail list
Signed-off-by: Frank Rowand
---
changes from v2:
- ignore v2, v3 is based on v1
changes from v1:
- updated
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Signed-off-by: Frank Rowand
---
There are checkpatch warnings. I have reviewed them and
From: Frank Rowand
The dtc compiler version that adds initial support was available
in 4.11-rc1. Add the ability to set an additional dtc compiler
flag is needed by overlays.
Signed-off-by: Frank Rowand
---
scripts/Makefile.lib | 2 ++
1 file
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay code.
The new tests target the entire process of applying an overlay.
Changes from v3:
- make subject line of patch 1 more generic
Changes from v2:
- of_private.h: move
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Signed-off-by: Frank Rowand
---
There are checkpatch warnings. I have reviewed them and
From: Frank Rowand
The dtc compiler version that adds initial support was available
in 4.11-rc1. Add the ability to set the dtc compiler flags needed
by overlays.
Signed-off-by: Frank Rowand
---
scripts/Makefile.lib | 2 ++
1 file changed, 2
From: Frank Rowand
Existing overlay unit tests examine individual pieces of the overlay
code. The new tests target the entire process of applying an overlay.
Changes from v2:
- of_private.h: move __unflatten_device_tree() outside
#ifdef CONFIG_OF_UNITTEST
-
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value
From: Frank Rowand
Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
the internal device tree. The phandle will still be in the struct
device_node phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
the internal device tree. The phandle will still be in the struct
device_node phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
Fix problem reported in the linux-next build. last_sibling may be
unitialized in of_unittest() if the device tree is empty.
Signed-off-by: Frank Rowand
---
drivers/of/unittest.c | 2 +-
1 file changed, 1 insertion(+), 1
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
From: Frank Rowand
Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
the internal device tree. The phandle will still be in the struct
device_node phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value
From: Frank Rowand
Fix boot warning 'Trying to vfree() nonexistent vm area'
from arch_timer_mem_of_init().
Refactored code attempts to read and iounmap using address frame
instead of address ioremap(frame->cntbase).
Fixes: c389d701dfb70 ("clocksource: arm_arch_timer:
From: Frank Rowand
File dt-object-internal.txt does not exist. Remove a reference to it
and fix up tags for references to other files.
Reported-by: afaer...@suse.de
Signed-off-by: Frank Rowand
---
Documentation/devicetree/overlay-notes.txt | 8
From: Frank Rowand
Fix typo in header comment for of_address_to_resource()
Signed-off-by: Frank Rowand
---
drivers/of/address.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/address.c b/drivers/of/address.c
index
From: Frank Rowand
Convert non-ascii up and down arrows to '^' and 'v'
Signed-off-by: Frank Rowand
---
.../devicetree/bindings/display/panel/display-timing.txt | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git
1 - 100 of 523 matches
Mail list logo