Re: [RESEND PATCH v2 3/3] ASoC: rockchip: Init dapm routes dynamically

2017-09-19 Thread jeffy
Hi Mark, On 09/19/2017 08:28 PM, Mark Brown wrote: On Mon, Sep 18, 2017 at 07:18:01PM +0800, Jeffy Chen wrote: Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. This doesn't apply against current

Re: [RESEND PATCH v2 3/3] ASoC: rockchip: Init dapm routes dynamically

2017-09-19 Thread jeffy
Hi Mark, On 09/19/2017 08:28 PM, Mark Brown wrote: On Mon, Sep 18, 2017 at 07:18:01PM +0800, Jeffy Chen wrote: Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. This doesn't apply against current

Re: [RESEND PATCH v2 1/3] ASoC: rockchip: Add dapm route for HDMI

2017-09-19 Thread jeffy
Hi Mark, On 09/19/2017 08:19 PM, Mark Brown wrote: On Mon, Sep 18, 2017 at 07:17:59PM +0800, Jeffy Chen wrote: Add dapm route for DP codec. This is a resend of a patch you posted earlier in the same day? sorry, this is a resend of yesterday patches, to correct the wrong the wrong patch tag

Re: [RESEND PATCH v2 1/3] ASoC: rockchip: Add dapm route for HDMI

2017-09-19 Thread jeffy
Hi Mark, On 09/19/2017 08:19 PM, Mark Brown wrote: On Mon, Sep 18, 2017 at 07:17:59PM +0800, Jeffy Chen wrote: Add dapm route for DP codec. This is a resend of a patch you posted earlier in the same day? sorry, this is a resend of yesterday patches, to correct the wrong the wrong patch tag

Re: [PATCH v11 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread jeffy
Hi Matthias, On 09/19/2017 03:15 AM, Matthias Kaehlcke wrote: >+static int of_dev_node_match(struct device *dev, void *data) >+{ >+ return dev->of_node == data; >+} The same is done in different places, even with the same function name (drivers/i2c/i2c-core-of.c, drivers/mux/mux-core.c,

Re: [PATCH v11 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread jeffy
Hi Matthias, On 09/19/2017 03:15 AM, Matthias Kaehlcke wrote: >+static int of_dev_node_match(struct device *dev, void *data) >+{ >+ return dev->of_node == data; >+} The same is done in different places, even with the same function name (drivers/i2c/i2c-core-of.c, drivers/mux/mux-core.c,

[PATCH v12 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread Jeffy Chen
Currently rt5514 dsp and rt5514 codec are sharing the same compatible. Use bus_type to distinguish rt5514 dsp from rt5514 codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias Kaehlcke <m...@chromium.or

[PATCH v12 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread Jeffy Chen
Currently rt5514 dsp and rt5514 codec are sharing the same compatible. Use bus_type to distinguish rt5514 dsp from rt5514 codec. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v12: Fix device leak. Changes in v11: None Changes in v10

[PATCH v12 1/2] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-18 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v12: None Changes in v11: Use same compatible for rt5514-i2c & rt5514-spi. Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Ad

[PATCH v12 1/2] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-18 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Signed-off-by: Jeffy Chen --- Changes in v12: None Changes in v11: Use same compatible for rt5514-i2c & rt5514-spi. Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Address comments fr

Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-18 Thread jeffy
Hi Heiko, Thanks for your reply. On 09/18/2017 05:30 PM, Heiko Stuebner wrote: > >> > >>-- compatible : "realtek,rt5514". > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > > >There's no need for the -spi or -i2c compatibles. This is implied by > >being a

Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-18 Thread jeffy
Hi Heiko, Thanks for your reply. On 09/18/2017 05:30 PM, Heiko Stuebner wrote: > >> > >>-- compatible : "realtek,rt5514". > >>+- compatible : "realtek,rt5514" or "realtek,rt5514", "realtek,rt5514-i2c". > > > >There's no need for the -spi or -i2c compatibles. This is implied by > >being a

[RESEND PATCH v2 3/3] ASoC: rockchip: Init dapm routes dynamically

2017-09-18 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias

[RESEND PATCH v2 3/3] ASoC: rockchip: Init dapm routes dynamically

2017-09-18 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v2: Fix DMic typo. sound/soc/rockchip

[RESEND PATCH v2 2/3] ASoC: rockchip: Add dapm route for DMic

2017-09-18 Thread Jeffy Chen
Add dapm route for DMIC codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c

[RESEND PATCH v2 2/3] ASoC: rockchip: Add dapm route for DMic

2017-09-18 Thread Jeffy Chen
Add dapm route for DMIC codec. Signed-off-by: Jeffy Chen --- Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index b050510be65f..ad19e391c4a6 100644

[RESEND PATCH v2 1/3] ASoC: rockchip: Add dapm route for HDMI

2017-09-18 Thread Jeffy Chen
Add dapm route for DP codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: Separate HDMI/DMIC patches. sound/soc/rockchip/rk3399_gru_sound.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/ro

[RESEND PATCH v2 1/3] ASoC: rockchip: Add dapm route for HDMI

2017-09-18 Thread Jeffy Chen
Add dapm route for DP codec. Signed-off-by: Jeffy Chen --- Changes in v2: Separate HDMI/DMIC patches. sound/soc/rockchip/rk3399_gru_sound.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 0513fe480353

[PATCH v11 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread Jeffy Chen
Currently rt5514 dsp and rt5514 codec are sharing the same compatible. Use bus_type to distinguish rt5514 dsp from rt5514 codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v11: None Changes in v10: None Changes in v9: None sound/soc/rockchip/rk3399_gru_sound.

[PATCH v11 2/2] ASoC: rockchip: Use bus_type to distinguish rt5514 dsp from rt5514 codec

2017-09-18 Thread Jeffy Chen
Currently rt5514 dsp and rt5514 codec are sharing the same compatible. Use bus_type to distinguish rt5514 dsp from rt5514 codec. Signed-off-by: Jeffy Chen --- Changes in v11: None Changes in v10: None Changes in v9: None sound/soc/rockchip/rk3399_gru_sound.c | 57

[PATCH v11 1/2] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-18 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v11: Use same compatible for rt5514-i2c & rt5514-spi. Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Address comme

[PATCH v11 1/2] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-18 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Signed-off-by: Jeffy Chen --- Changes in v11: Use same compatible for rt5514-i2c & rt5514-spi. Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Address comments from Brian. Documentation/devicetree/

[PATCH v2 3/3] Asoc: rockchip: Init dapm routes dynamically

2017-09-17 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias

Re: [PATCH] Asoc: rockchip: Init dapm routes dynamically

2017-09-17 Thread jeffy
Hi Matthias, Thanks for your test and review. On 09/16/2017 08:54 AM, Matthias Kaehlcke wrote: -static const struct snd_soc_dapm_route rockchip_dapm_routes[] = { >- /* Input Lines */ >- {"MIC", NULL, "Headset Mic"}, >- {"DMIC1L", NULL, "Int Mic"}, >- {"DMIC1R", NULL, "Int Mic"}, >- >-

[PATCH v2 3/3] Asoc: rockchip: Init dapm routes dynamically

2017-09-17 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v2: Fix DMic typo. sound/soc/rockchip

Re: [PATCH] Asoc: rockchip: Init dapm routes dynamically

2017-09-17 Thread jeffy
Hi Matthias, Thanks for your test and review. On 09/16/2017 08:54 AM, Matthias Kaehlcke wrote: -static const struct snd_soc_dapm_route rockchip_dapm_routes[] = { >- /* Input Lines */ >- {"MIC", NULL, "Headset Mic"}, >- {"DMIC1L", NULL, "Int Mic"}, >- {"DMIC1R", NULL, "Int Mic"}, >- >-

[PATCH v2 1/3] Asoc: rockchip: Add dapm route for HDMI

2017-09-17 Thread Jeffy Chen
Add dapm route for DP codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: Separate HDMI/DMIC patches. sound/soc/rockchip/rk3399_gru_sound.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/ro

[PATCH v2 1/3] Asoc: rockchip: Add dapm route for HDMI

2017-09-17 Thread Jeffy Chen
Add dapm route for DP codec. Signed-off-by: Jeffy Chen --- Changes in v2: Separate HDMI/DMIC patches. sound/soc/rockchip/rk3399_gru_sound.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index 0513fe480353

[PATCH v2 2/3] Asoc: rockchip: Add dapm route for DMic

2017-09-17 Thread Jeffy Chen
Add dapm route for DMIC codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c

[PATCH v2 2/3] Asoc: rockchip: Add dapm route for DMic

2017-09-17 Thread Jeffy Chen
Add dapm route for DMIC codec. Signed-off-by: Jeffy Chen --- Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rk3399_gru_sound.c b/sound/soc/rockchip/rk3399_gru_sound.c index b050510be65f..ad19e391c4a6 100644

Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-17 Thread jeffy
Hi Rob, Thanks for your reply. On 09/14/2017 01:24 AM, Rob Herring wrote: On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt index 929ca6756b02..841a1159e234 100644

Re: [RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-17 Thread jeffy
Hi Rob, Thanks for your reply. On 09/14/2017 01:24 AM, Rob Herring wrote: On Wed, Sep 06, 2017 at 10:50:09AM +0800, Jeffy Chen wrote: diff --git a/Documentation/devicetree/bindings/sound/rt5514.txt b/Documentation/devicetree/bindings/sound/rt5514.txt index 929ca6756b02..841a1159e234 100644

[PATCH v10] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-17 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Addres

[PATCH v10] ASoC: rt5514: Add devicetree binding support for rt5514-spi

2017-09-17 Thread Jeffy Chen
Add devicetree binding support for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen --- Changes in v10: Put rt5514-i2c doc & rt5514-spi doc together. Changes in v9: Address comments from Brian. Documenta

[PATCH v5 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

2017-09-11 Thread Jeffy Chen
or handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannor...@chromium.com> Jeffy Chen (3): PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: Add definition of pcie wake irq arm64: dts: rockchip: Handle pcie wake in pcie driv

[PATCH v5 0/3] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

2017-09-11 Thread Jeffy Chen
or handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris Jeffy Chen (3): PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: Add definition of pcie wake irq arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru Documentation/dev

[PATCH v5 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

2017-09-11 Thread Jeffy Chen
Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: Use "wakeup" instead of "wake" Changes in v3: None Changes in v2: None arch/arm6

[PATCH v5 3/3] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

2017-09-11 Thread Jeffy Chen
Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v5: Use "wakeup" instead of "wake" Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/

[PATCH v5 2/3] dt-bindings: PCI: Add definition of pcie wake irq

2017-09-11 Thread Jeffy Chen
Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: Move to pci.txt Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/pci/pci.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documen

[PATCH v5 2/3] dt-bindings: PCI: Add definition of pcie wake irq

2017-09-11 Thread Jeffy Chen
Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen --- Changes in v5: Move to pci.txt Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/pci/pci.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/pci.txt

[PATCH v5 1/3] PCI: rockchip: Add support for pcie wake irq

2017-09-11 Thread Jeffy Chen
Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: Rebase Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannor...@chromium.com&g

[PATCH v5 1/3] PCI: rockchip: Add support for pcie wake irq

2017-09-11 Thread Jeffy Chen
Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v5: Rebase Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 19 +-- 1

[RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v9: Address comments from Brian. .../devicetree/bindings/sound/

[RESENT PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen --- Changes in v9: Address comments from Brian. .../devicetree/bindings/sound/rt5514-spi.txt | 29

[RESENT PATCH v9 2/2] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-05 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v9: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 +

[RESENT PATCH v9 2/2] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-05 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v9: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++-- 1 file changed, 2 insertions

Re: [PATCH v8 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread jeffy
Hi Brian, On 09/06/2017 01:55 AM, Brian Norris wrote: +This device supports SPI only. >+ >+Required properties: >+ >+- compatible : "realtek,rt5514". You list one string here, but there's 2 in the example. The point of this exercise was to document (not just in an Example) the strings you're

Re: [PATCH v8 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread jeffy
Hi Brian, On 09/06/2017 01:55 AM, Brian Norris wrote: +This device supports SPI only. >+ >+Required properties: >+ >+- compatible : "realtek,rt5514". You list one string here, but there's 2 in the example. The point of this exercise was to document (not just in an Example) the strings you're

[PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v9: Address comments from Brian. .../devicetree/bindings/sound/

[PATCH v9 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-05 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible to distinguish it from rt5514 spi. Signed-off-by: Jeffy Chen --- Changes in v9: Address comments from Brian. .../devicetree/bindings/sound/rt5514-spi.txt | 29

Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-04 Thread jeffy
Hi Heiko, On 09/05/2017 06:33 AM, Heiko Stübner wrote: Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: On 08/30/2017 09:30 PM, Heiko Stübner wrote: - compatible = "realtek,rt5514"; + compatible = "realtek,rt5514", "realtek,rt55

Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-04 Thread jeffy
Hi Heiko, On 09/05/2017 06:33 AM, Heiko Stübner wrote: Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: On 08/30/2017 09:30 PM, Heiko Stübner wrote: - compatible = "realtek,rt5514"; + compatible = "realtek,rt5514", "realtek,rt55

[PATCH v8 2/2] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-04 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v8: Add new compatible to rt5514 dt doc. arch/arm6

[PATCH v8 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-04 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v8: None .../devicetree/bindings/sound/rt5514-spi.txt | 32 ++ Documen

[PATCH v8 2/2] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-09-04 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v8: Add new compatible to rt5514 dt doc. arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi

[PATCH v8 1/2] ASoC: rt5514: Add devicetree bindings for rt5514-spi

2017-09-04 Thread Jeffy Chen
Add devicetree bindings documentation file for rt5514 spi dsp codec. Also update rt5514 i2c dt-binding's compatible. Signed-off-by: Jeffy Chen --- Changes in v8: None .../devicetree/bindings/sound/rt5514-spi.txt | 32 ++ Documentation/devicetree/bindings/sound

[PATCH] Asoc: rockchip: Init dapm routes dynamically

2017-09-04 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- sound/soc/rockchip/rk3399_gru_sound.c | 88 +--

[PATCH] Asoc: rockchip: Init dapm routes dynamically

2017-09-04 Thread Jeffy Chen
Currently we are using a fixed list of dapm routes. Init dapm routes dynamically when parsing dailinks, since we are supporting optional codecs. Signed-off-by: Jeffy Chen --- sound/soc/rockchip/rk3399_gru_sound.c | 88 +-- 1 file changed, 74 insertions(+), 14

Re: [PATCH] CHROMIUM: devfreq: rk3399: Clear edev->dev drvdata before enabling dfi

2017-09-01 Thread jeffy
hi brian, On 09/02/2017 08:47 AM, Brian Norris wrote: On Sat, Sep 02, 2017 at 07:52:37AM +0800, Jeffy Chen wrote: Currently we are using edev->dev drvdata to get rk3399-dmc data, but it would be inited to edev in devfreq_event_add_edev. So we need to clear the edev->dev drvdata before en

Re: [PATCH] CHROMIUM: devfreq: rk3399: Clear edev->dev drvdata before enabling dfi

2017-09-01 Thread jeffy
hi brian, On 09/02/2017 08:47 AM, Brian Norris wrote: On Sat, Sep 02, 2017 at 07:52:37AM +0800, Jeffy Chen wrote: Currently we are using edev->dev drvdata to get rk3399-dmc data, but it would be inited to edev in devfreq_event_add_edev. So we need to clear the edev->dev drvdata before en

[PATCH] CHROMIUM: devfreq: rk3399: Clear edev->dev drvdata before enabling dfi

2017-09-01 Thread Jeffy Chen
Currently we are using edev->dev drvdata to get rk3399-dmc data, but it would be inited to edev in devfreq_event_add_edev. So we need to clear the edev->dev drvdata before enabling dfi, to prevent dfi from getting the wrong rk3399-dmc data when the irq triggered too early. Signed-off-by:

[PATCH] CHROMIUM: devfreq: rk3399: Clear edev->dev drvdata before enabling dfi

2017-09-01 Thread Jeffy Chen
Currently we are using edev->dev drvdata to get rk3399-dmc data, but it would be inited to edev in devfreq_event_add_edev. So we need to clear the edev->dev drvdata before enabling dfi, to prevent dfi from getting the wrong rk3399-dmc data when the irq triggered too early. Signed-off-by:

Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-08-30 Thread jeffy
Hi Heiko, thanks for your reply. On 08/30/2017 09:30 PM, Heiko Stübner wrote: >- compatible = "realtek,rt5514"; >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; the rt5514-i2c and -spi compatibles should be documented in the binding-txt of the chip, but I haven't

Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-08-30 Thread jeffy
Hi Heiko, thanks for your reply. On 08/30/2017 09:30 PM, Heiko Stübner wrote: >- compatible = "realtek,rt5514"; >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; the rt5514-i2c and -spi compatibles should be documented in the binding-txt of the chip, but I haven't

[PATCH] ASoC: rockchip: constify snd_soc_ops structures

2017-08-30 Thread Jeffy Chen
Add const to dp/dmic snd_soc_ops. Fixes: 626d84db64d7 (ASoC: rockchip: Add support for DMIC codec) Fixes: 3313faf1053e (ASoC: rockchip: Add support for DP codec) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- sound/soc/rockchip/rk3399_gru_sound.c | 4 ++-- 1 file chan

[PATCH] ASoC: rockchip: constify snd_soc_ops structures

2017-08-30 Thread Jeffy Chen
Add const to dp/dmic snd_soc_ops. Fixes: 626d84db64d7 (ASoC: rockchip: Add support for DMIC codec) Fixes: 3313faf1053e (ASoC: rockchip: Add support for DP codec) Signed-off-by: Jeffy Chen --- sound/soc/rockchip/rk3399_gru_sound.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-27 Thread jeffy
hi Mark, On 08/27/2017 10:34 PM, Mark Brown wrote: On Sun, Aug 27, 2017 at 10:31:52PM +0800, Jeffy Chen wrote: This is a HTML only mail and I have a text only client... sorry, i was replying with my phone, didn't notice it would use html by default... i think you've applied the right

Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-27 Thread jeffy
hi Mark, On 08/27/2017 10:34 PM, Mark Brown wrote: On Sun, Aug 27, 2017 at 10:31:52PM +0800, Jeffy Chen wrote: This is a HTML only mail and I have a text only client... sorry, i was replying with my phone, didn't notice it would use html by default... i think you've applied the right

Re: [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

2017-08-24 Thread jeffy
Hi Bjorn, On 08/25/2017 12:55 AM, Bjorn Helgaas wrote: Looking for acks from Shawn and Rob... And I'm not sure about the DT wake IRQ description. That seems like it could potentially be generic than this Rockchip-specific proposal. it looks like shawn already take the error handling patch

Re: [PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

2017-08-24 Thread jeffy
Hi Bjorn, On 08/25/2017 12:55 AM, Bjorn Helgaas wrote: Looking for acks from Shawn and Rob... And I'm not sure about the DT wake IRQ description. That seems like it could potentially be generic than this Rockchip-specific proposal. it looks like shawn already take the error handling patch

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-24 Thread jeffy
hi Mark, On 08/24/2017 06:18 PM, Mark Brown wrote: On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote: and i was trying to do something like: if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) && (!dai->driver->name || strcmp(dai->driver-&g

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-24 Thread jeffy
hi Mark, On 08/24/2017 06:18 PM, Mark Brown wrote: On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote: and i was trying to do something like: if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) && (!dai->driver->name || strcmp(dai->driver-&g

[RESENT PATCH v7 5/7] ASoC: rockchip: Add support for DP codec

2017-08-23 Thread Jeffy Chen
Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.

[RESENT PATCH v7 5/7] ASoC: rockchip: Add support for DP codec

2017-08-23 Thread Jeffy Chen
Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 59 +-- 2 files changed

[RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

2017-08-23 Thread Jeffy Chen
Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/roc

[RESENT PATCH v7 4/7] ASoC: rockchip: Parse dai links from dts

2017-08-23 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v7: None Changes in v6:

[RESENT PATCH v7 7/7] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

2017-08-23 Thread Jeffy Chen
Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen Acked-by: Rob Herring --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 +- 1 file changed, 1

[RESENT PATCH v7 4/7] ASoC: rockchip: Parse dai links from dts

2017-08-23 Thread Jeffy Chen
Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v7: None Changes in v6: None Changes in v3: Use compatible to match audio codecs -- Suggested

[RESENT PATCH v7 0/7] ASoC: rockchip: Parse dai links from dts

2017-08-23 Thread Jeffy Chen
use we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (7): ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp arm64: dts: rockchip: Add rt5514 dsp for Gru arm64: dts: rockchip: Update rt5514 devices' compatible for Gru ASoC: rockchip: Par

[RESENT PATCH v7 6/7] ASoC: rockchip: Add support for DMIC codec

2017-08-23 Thread Jeffy Chen
Add support for optional dmic codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v7: None Changes in v6: Add dmic wakeup delay(not used for now). Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/ro

[RESENT PATCH v7 0/7] ASoC: rockchip: Parse dai links from dts

2017-08-23 Thread Jeffy Chen
supported codecs to the fixed dai link list in the driver. Jeffy Chen (7): ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp arm64: dts: rockchip: Add rt5514 dsp for Gru arm64: dts: rockchip: Update rt5514 devices' compatible for Gru ASoC: rockchip: Parse dai links from dts

[RESENT PATCH v7 6/7] ASoC: rockchip: Add support for DMIC codec

2017-08-23 Thread Jeffy Chen
Add support for optional dmic codec. Signed-off-by: Jeffy Chen --- Changes in v7: None Changes in v6: Add dmic wakeup delay(not used for now). Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 36

[RESENT PATCH v7 1/7] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

2017-08-23 Thread Jeffy Chen
Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v7: Rebase on the newest for-next Changes in v6: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.

[RESENT PATCH v7 1/7] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

2017-08-23 Thread Jeffy Chen
Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen --- Changes in v7: Rebase on the newest for-next Changes in v6: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 34

[RESENT PATCH v7 2/7] arm64: dts: rockchip: Add rt5514 dsp for Gru

2017-08-23 Thread Jeffy Chen
Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 de

[RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-08-23 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v7: None Changes in v6: None Changes in v3: None C

[RESENT PATCH v7 2/7] arm64: dts: rockchip: Add rt5514 dsp for Gru

2017-08-23 Thread Jeffy Chen
Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot

[RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

2017-08-23 Thread Jeffy Chen
Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v7: None Changes in v6: None Changes in v3: None Changes in v2: None arch/arm64/boot

Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread jeffy
Hi Dong, Thanks for noticing, will send new patch soon :) On 08/24/2017 11:46 AM, Donglin Peng wrote: On Thu, Aug 24, 2017 at 11:34 AM, Jeffy Chen <jeffy.c...@rock-chips.com> wrote: list_for_each_entry(dai, >dai_list, list) { if (dlc-

Re: [PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread jeffy
Hi Dong, Thanks for noticing, will send new patch soon :) On 08/24/2017 11:46 AM, Donglin Peng wrote: On Thu, Aug 24, 2017 at 11:34 AM, Jeffy Chen wrote: list_for_each_entry(dai, >dai_list, list) { if (dlc->dai_name && strcmp(dai->na

[PATCH v3] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread Jeffy Chen
The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reported-by: Donglin Peng <dolinux.p...@gmail.com> --- Changes in v3: Fix typo Changes in v2: Keep the oringinal check style. sound/soc/soc-core.c | 3

[PATCH v3] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread Jeffy Chen
The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen Reported-by: Donglin Peng --- Changes in v3: Fix typo Changes in v2: Keep the oringinal check style. sound/soc/soc-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread Jeffy Chen
The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reported-by: Donglin Peng <dolinux.p...@gmail.com> --- Changes in v2: Keep the oringinal check style. sound/soc/soc-core.c | 3 ++- 1 file changed,

[PATCH v2] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread Jeffy Chen
The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen Reported-by: Donglin Peng --- Changes in v2: Keep the oringinal check style. sound/soc/soc-core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/soc-core.c

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread jeffy
Hi Mark, On 08/23/2017 07:06 PM, Mark Brown wrote: On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote: >i think the original check is allowing NULL dlc dai_name to be a match... >so we basically did: >reject when dlc dai_name is valid, but not match the dai name So it is, but t

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread jeffy
Hi Mark, On 08/23/2017 07:06 PM, Mark Brown wrote: On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote: >i think the original check is allowing NULL dlc dai_name to be a match... >so we basically did: >reject when dlc dai_name is valid, but not match the dai name So it is, but t

Re: [v2] timers: Fix excessive granularity of new timers after a nohz idle

2017-08-23 Thread jeffy
Hi Thomas, On 08/23/2017 03:01 PM, Thomas Gleixner wrote: On Wed, 23 Aug 2017, jeffy wrote: Hi guys, I was testing a arm64 based device(chromebook bob), and the kernel hang a lot(during booting or suspending) on for-next(next-20170822) with this commit: 71acb768f5b3 (timers: Fix excessive

Re: [v2] timers: Fix excessive granularity of new timers after a nohz idle

2017-08-23 Thread jeffy
Hi Thomas, On 08/23/2017 03:01 PM, Thomas Gleixner wrote: On Wed, 23 Aug 2017, jeffy wrote: Hi guys, I was testing a arm64 based device(chromebook bob), and the kernel hang a lot(during booting or suspending) on for-next(next-20170822) with this commit: 71acb768f5b3 (timers: Fix excessive

Re: [v2] timers: Fix excessive granularity of new timers after a nohz idle

2017-08-22 Thread jeffy
Hi guys, I was testing a arm64 based device(chromebook bob), and the kernel hang a lot(during booting or suspending) on for-next(next-20170822) with this commit: 71acb768f5b3 (timers: Fix excessive granularity of new timers after a nohz idle) After revert it(or just add "!base->is_idle"

Re: [v2] timers: Fix excessive granularity of new timers after a nohz idle

2017-08-22 Thread jeffy
Hi guys, I was testing a arm64 based device(chromebook bob), and the kernel hang a lot(during booting or suspending) on for-next(next-20170822) with this commit: 71acb768f5b3 (timers: Fix excessive granularity of new timers after a nohz idle) After revert it(or just add "!base->is_idle"

<    3   4   5   6   7   8   9   10   11   12   >