Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/23/2017 09:57 AM, Brian Norris wrote: Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: and for eage irq, maybe we should enable it right after(or before) the driver activate wake function(for example activate WOWLAN or WOLAN), otherwise would

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/23/2017 09:57 AM, Brian Norris wrote: Hi Jeffy, On Wed, Aug 23, 2017 at 09:32:39AM +0800, Jeffy Chen wrote: and for eage irq, maybe we should enable it right after(or before) the driver activate wake function(for example activate WOWLAN or WOLAN), otherwise would

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Tony, On 08/23/2017 01:26 AM, Tony Lindgren wrote: OK, let's fix any wakeriq ordering issues to make it more usable. Sounds like in your case the wakeirq needs to be enabled late and disabled early, while in my test cases I can keep it enabled basically any time. yes, in my case it's a

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Tony, On 08/23/2017 01:26 AM, Tony Lindgren wrote: OK, let's fix any wakeriq ordering issues to make it more usable. Sounds like in your case the wakeirq needs to be enabled late and disabled early, while in my test cases I can keep it enabled basically any time. yes, in my case it's a

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

hi Mark, On 08/23/2017 12:17 AM, Mark Brown wrote: On Tue, Aug 22, 2017 at 10:45:12PM +0800, Jeffy Chen wrote: - return dai; + if (!dlc->dai_name) + return dai; + if (!strcmp(dai->nam

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

hi Mark, On 08/23/2017 12:17 AM, Mark Brown wrote: On Tue, Aug 22, 2017 at 10:45:12PM +0800, Jeffy Chen wrote: - return dai; + if (!dlc->dai_name) + return dai; + if (!strcmp(dai->nam

[RESENT PATCH v6 8/8] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/roc

[RESENT PATCH v6 8/8] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen Acked-by: Rob Herring --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 +- 1 file changed, 1

[RESENT PATCH v6 7/8] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: Add dmic wakeup delay(not used for now). Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/ro

[RESENT PATCH v6 7/8] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen --- Changes in v6: Add dmic wakeup delay(not used for now). Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 36

[RESENT PATCH v6 5/8] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v6: None Changes in v5:

[RESENT PATCH v6 5/8] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v6: None Changes in v5: None Changes in v3: Use compatible to match audio codecs -- Suggested

[RESENT PATCH v6 6/8] ASoC: rockchip: Add support for DP codec

Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.

[RESENT PATCH v6 6/8] ASoC: rockchip: Add support for DP codec

Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 59 +-- 2 files changed

[RESENT PATCH v6 4/8] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v3: None C

[RESENT PATCH v6 4/8] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None arch/arm64/boot

[RESENT PATCH v6 3/8] arm64: dts: rockchip: Add rt5514 dsp for Gru

Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 de

[RESENT PATCH v6 3/8] arm64: dts: rockchip: Add rt5514 dsp for Gru

Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot

[RESENT PATCH v6 2/8] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.

[RESENT PATCH v6 2/8] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 34 ++ 1 file changed, 2

[RESENT PATCH v6 1/8] ASoC: rockchip: Correct 'dmic-delay' property name

The 'dmic-delay' property name is different with the dt-binding. So correct it with 'dmic-wakeup-delay-ms'. Fixes: 3a6f9dce6116 (ASoC: rk3399_gru_sound: fix recording pop at first attempt) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5

[RESENT PATCH v6 0/8] ASoC: rockchip: Parse dai links from dts

tthias Kaehlcke <m...@chromium.org> Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (8): ASoC: rockchip: Correct 'dmic-delay' property name ASoC: rockchip: Use codec of_node

[RESENT PATCH v6 1/8] ASoC: rockchip: Correct 'dmic-delay' property name

The 'dmic-delay' property name is different with the dt-binding. So correct it with 'dmic-wakeup-delay-ms'. Fixes: 3a6f9dce6116 (ASoC: rk3399_gru_sound: fix recording pop at first attempt) Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: Keep the dmic-delay property

[RESENT PATCH v6 0/8] ASoC: rockchip: Parse dai links from dts

: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (8): ASoC: rockchip: Correct 'dmic-delay' property name ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp arm64: dts: rockchip: Add

[PATCH v6 2/8] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.

[PATCH v6 1/8] ASoC: rockchip: Correct 'dmic-delay' property name

The 'dmic-delay' property name is different with the dt-binding. So correct it with 'dmic-wakeup-delay-ms'. Fixes: 3a6f9dce6116 (ASoC: rk3399_gru_sound: fix recording pop at first attempt) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v6: None Changes in v5

[PATCH v6 2/8] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 34 ++ 1 file changed, 2

[PATCH v6 1/8] ASoC: rockchip: Correct 'dmic-delay' property name

The 'dmic-delay' property name is different with the dt-binding. So correct it with 'dmic-wakeup-delay-ms'. Fixes: 3a6f9dce6116 (ASoC: rk3399_gru_sound: fix recording pop at first attempt) Signed-off-by: Jeffy Chen --- Changes in v6: None Changes in v5: Keep the dmic-delay property

[PATCH v6 0/8] ASoC: rockchip: Parse dai links from dts

tthias Kaehlcke <m...@chromium.org> Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (8): ASoC: rockchip: Correct 'dmic-delay' property name ASoC: rockchip: Use codec of_node

[PATCH v6 0/8] ASoC: rockchip: Parse dai links from dts

: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (8): ASoC: rockchip: Correct 'dmic-delay' property name ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp arm64: dts: rockchip: Add

[PATCH] ASoC: Add a sanity check before using dai driver name

The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reported-by: Donglin Peng <dolinux.p...@gmail.com> --- sound/soc/soc-core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff -

[PATCH] ASoC: Add a sanity check before using dai driver name

The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen Reported-by: Donglin Peng --- sound/soc/soc-core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index

Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai

Hi guys, On 08/22/2017 10:26 PM, Takashi Iwai wrote: On Tue, 22 Aug 2017 16:21:11 +0200, Mark Brown wrote: On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote: On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown wrote: We should be already verifying that drivers

Re: [PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai

Hi guys, On 08/22/2017 10:26 PM, Takashi Iwai wrote: On Tue, 22 Aug 2017 16:21:11 +0200, Mark Brown wrote: On Tue, Aug 22, 2017 at 10:15:32PM +0800, Donglin Peng wrote: On Tue, Aug 22, 2017 at 10:02 PM, Mark Brown wrote: We should be already verifying that drivers have a name, we assume

Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay

Hi Mark, On 08/22/2017 06:32 PM, Mark Brown wrote: On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote: This property is no longer used. I would still rather keep the existing property documented (the binding does need to be fixed) than remove it. It's better practice and it's

Re: [PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay

Hi Mark, On 08/22/2017 06:32 PM, Mark Brown wrote: On Tue, Aug 22, 2017 at 03:57:20PM +0800, Jeffy Chen wrote: This property is no longer used. I would still rather keep the existing property documented (the binding does need to be fixed) than remove it. It's better practice and it's

Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

Hi Donglin, On 08/22/2017 05:08 PM, Donglin Peng wrote: > card->dev = >dev; > platform_set_drvdata(pdev, card); There is no need to call platform_set_drvdata, because devm_snd_soc_register_card will do it. right, will remove it in next version, thanks:)

Re: [PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

Hi Donglin, On 08/22/2017 05:08 PM, Donglin Peng wrote: > card->dev = >dev; > platform_set_drvdata(pdev, card); There is no need to call platform_set_drvdata, because devm_snd_soc_register_card will do it. right, will remove it in next version, thanks:)

[PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai

Currently we are searching dai name in snd_soc_find_dai, which could either be dai driver name or component device name(for legacy naming). Allow searching dai driver name in snd_soc_find_dai too, so that we can use dai driver name to find legacy naming dais. Signed-off-by: Jeffy Chen <jeff

[PATCH v5 2/9] ASoC: soc-core: Allow searching dai driver name in snd_soc_find_dai

Currently we are searching dai name in snd_soc_find_dai, which could either be dai driver name or component device name(for legacy naming). Allow searching dai driver name in snd_soc_find_dai too, so that we can use dai driver name to find legacy naming dais. Signed-off-by: Jeffy Chen

[PATCH v5 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/roc

[PATCH v5 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen Acked-by: Rob Herring --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 +- 1 file changed, 1

[PATCH v5 7/9] ASoC: rockchip: Add support for DP codec

Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.

[PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Reviewed-by: Matthias Kaehlcke <m...@chromium.org> Tested-by: Matthias Kaehlcke <m...@chromium.org> --- Changes in v5: None Changes in v4:

[PATCH v5 7/9] ASoC: rockchip: Add support for DP codec

Add support for optional cdn dp codec. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 59 +-- 2 files changed

[PATCH v5 6/9] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen Reviewed-by: Matthias Kaehlcke Tested-by: Matthias Kaehlcke --- Changes in v5: None Changes in v4: None Changes in v3: Use compatible to match audio codecs -- Suggested

[PATCH v5 5/9] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None C

[PATCH v5 5/9] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru

Currently the rt5514 i2c driver and rt5514 spi driver are using the same compatible string. Add additional unused compatible strings to identify them for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm64/boot

[PATCH v5 8/9] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.

[PATCH v5 4/9] arm64: dts: rockchip: Add rt5514 dsp for Gru

Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 de

[PATCH v5 8/9] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 33 + 2 files changed, 34

[PATCH v5 4/9] arm64: dts: rockchip: Add rt5514 dsp for Gru

Add rt5514 dsp of_node to codec list for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot

[PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay

This property is no longer used. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v5: None Changes in v4: Use non-zero drv id to avoid legacy dai naming instead of switching to snd_soc_register_codec. Changes in v3: None C

[PATCH v5 3/9] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.

[PATCH v5 1/9] ASoC: rockchip: Remove obsolete dmic-delay

This property is no longer used. Signed-off-by: Jeffy Chen Acked-by: Rob Herring --- Changes in v5: None Changes in v4: Use non-zero drv id to avoid legacy dai naming instead of switching to snd_soc_register_codec. Changes in v3: None Changes in v2: None .../bindings/sound/rockchip,rk3399

[PATCH v5 3/9] ASoC: rockchip: Use codec of_node and dai_name for rt5514 dsp

Currently we are using codec name for rt5514 dsp dai link, use codec of_node instead. Signed-off-by: Jeffy Chen --- Changes in v5: None Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/rk3399_gru_sound.c | 34 ++ 1 file changed, 2

[PATCH v5 0/9] ASoC: rockchip: Parse dai links from dts

audio codecs -- Suggested-by Matthias Kaehlcke <m...@chromium.org> Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (9): ASoC: rockchip: Remove obsolete dmic-delay ASo

[PATCH v5 0/9] ASoC: rockchip: Parse dai links from dts

audio codecs -- Suggested-by Matthias Kaehlcke Changes in v2: Let rockchip,codec-names be a required property, because we plan to add more supported codecs to the fixed dai link list in the driver. Jeffy Chen (9): ASoC: rockchip: Remove obsolete dmic-delay ASoC: soc-core: Allow searching

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

Hi Mark, thanks for your reply. On 08/22/2017 01:31 AM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: when using legacy dai naming, the dai->name for rt5514-spi would be the dev name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with upstr

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

Hi Mark, thanks for your reply. On 08/22/2017 01:31 AM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:03:46PM +0800, jeffy wrote: when using legacy dai naming, the dai->name for rt5514-spi would be the dev name, which is spi2.0 with my local 4.4 kernel, and would be spi32765.0 with upstr

[PATCH v4 4/4] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dts

[PATCH v4 4/4] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v4: None Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 15 +-- 1 file changed, 9

[PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/pci/rockchip-pcie.txt| 20 1 file changed, 12 insertions(+), 8 del

[PATCH v4 1/4] PCI: rockchip: Fix error handlings

Fix error handlings in probe & resume. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: Rebase on newest for-next branch, also fix error handling by: 1e7f570a1b86 PCI: rockchip: Idle inactive PHY(s) Changes in v3: None Changes in v2: None drivers/pci

[PATCH v4 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen --- Changes in v4: None Changes in v3: None Changes in v2: None .../devicetree/bindings/pci/rockchip-pcie.txt| 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation

[PATCH v4 1/4] PCI: rockchip: Fix error handlings

Fix error handlings in probe & resume. Signed-off-by: Jeffy Chen --- Changes in v4: Rebase on newest for-next branch, also fix error handling by: 1e7f570a1b86 PCI: rockchip: Idle inactive PHY(s) Changes in v3: None Changes in v2: None drivers/pci/host/pcie-rockchip.c |

[PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

inactive PHY(s) Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannor...@chromium.com> Jeffy Chen (4): PCI: rockchip: Fix error handlings PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: rockchi

[PATCH v4 2/4] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: None Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannor...@chromium.com>

[PATCH v4 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

inactive PHY(s) Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris Jeffy Chen (4): PCI: rockchip: Fix error handlings PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: rockchip: Add support for pcie wake irq

[PATCH v4 2/4] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v4: None Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 21 +++-- 1

[PATCH] serial: earlycon: Only try fdt when specify 'earlycon' exactly

earlycon early_param handling to serial) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- drivers/tty/serial/earlycon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index c3651540e1ba..335933e1822c

[PATCH] serial: earlycon: Only try fdt when specify 'earlycon' exactly

earlycon early_param handling to serial) Signed-off-by: Jeffy Chen --- drivers/tty/serial/earlycon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c index c3651540e1ba..335933e1822c 100644 --- a/drivers/tty/serial

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi guys, On 08/19/2017 02:14 AM, Tony Lindgren wrote: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) >{ > struct wake_irq *wirq = _wirq; > int res; > > /* Maybe abort suspend? */ > if (irqd_is_wakeup_set(irq_get_irq_data(irq))) { >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi guys, On 08/19/2017 02:14 AM, Tony Lindgren wrote: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) >{ > struct wake_irq *wirq = _wirq; > int res; > > /* Maybe abort suspend? */ > if (irqd_is_wakeup_set(irq_get_irq_data(irq))) { >

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/19/2017 01:01 AM, Brian Norris wrote: Did you test that this works out correctly as a level-triggered interrupt? IIUC, the dummy handler won't mask the interrupt, so it might keep firing. See: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) { struct

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Brian, On 08/19/2017 01:01 AM, Brian Norris wrote: Did you test that this works out correctly as a level-triggered interrupt? IIUC, the dummy handler won't mask the interrupt, so it might keep firing. See: static irqreturn_t handle_threaded_wake_irq(int irq, void *_wirq) { struct

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

Hi Mark, On 08/18/2017 07:45 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Why

Re: [PATCH v4 1/9] ASoC: rt5514: Avoid legacy dai naming

Hi Mark, On 08/18/2017 07:45 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 11:11:39AM +0800, Jeffy Chen wrote: Currently we are using devm_snd_soc_register_component, which would use legacy dai naming when dai drv id is zero. Set a non-zero dai drv id to use dai drv name for dai name. Why

[PATCH] arm64: dts: rockchip: Fix wrong rt5514 dmic delay property for Gru

According to rt5514 dt-binding, it should be "realtek,dmic-init-delay-ms". Fixes: 48f4d9796d99 (arm64: dts: rockchip: add Gru/Kevin DTS) Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +- 1 file changed, 1 insertio

[PATCH] arm64: dts: rockchip: Fix wrong rt5514 dmic delay property for Gru

According to rt5514 dt-binding, it should be "realtek,dmic-init-delay-ms". Fixes: 48f4d9796d99 (arm64: dts: rockchip: add Gru/Kevin DTS) Signed-off-by: Jeffy Chen --- arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

Re: [PATCH v3 2/9] ASoC: rockchip: Remove obsolete dmic-delay

Hi Mark, On 08/18/2017 07:52 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 09:41:54AM +0800, jeffy wrote: On 08/18/2017 01:11 AM, Mark Brown wrote: On Thu, Aug 17, 2017 at 12:44:10PM +0800, Jeffy Chen wrote: -Optional properties: -- dmic-wakeup-delay-ms : specify delay time (ms) for DMIC

Re: [PATCH v3 2/9] ASoC: rockchip: Remove obsolete dmic-delay

Hi Mark, On 08/18/2017 07:52 PM, Mark Brown wrote: On Fri, Aug 18, 2017 at 09:41:54AM +0800, jeffy wrote: On 08/18/2017 01:11 AM, Mark Brown wrote: On Thu, Aug 17, 2017 at 12:44:10PM +0800, Jeffy Chen wrote: -Optional properties: -- dmic-wakeup-delay-ms : specify delay time (ms) for DMIC

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = >dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); +dev_pm_clear_wake_irq(dev); +device_init_wakeup(dev,

Re: [RFC PATCH v2 1/3] PCI: rockchip: Add support for pcie wake irq

Hi Shawn, On 08/18/2017 03:23 PM, Shawn Lin wrote: @@ -1524,6 +1532,9 @@ static int rockchip_pcie_remove(struct platform_device *pdev) struct device *dev = >dev; struct rockchip_pcie *rockchip = dev_get_drvdata(dev); +dev_pm_clear_wake_irq(dev); +device_init_wakeup(dev,

[PATCH v3 4/4] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 15 +-- 1 file chan

[PATCH v3 4/4] arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru

Currently we are handling pcie wake irq in mrvl wifi driver. Move it to rockchip pcie driver for Gru boards. Signed-off-by: Jeffy Chen --- Changes in v3: None Changes in v2: None arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 15 +-- 1 file changed, 9 insertions(+), 6 deletions

[PATCH v3 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None .../devicetree/bindings/pci/rockchip-pcie.txt| 20 1 file changed, 12 insertions(+), 8 deletions(-) diff

[PATCH v3 3/4] dt-bindings: PCI: rockchip: Add support for pcie wake irq

Add an optional interrupt for PCIE_WAKE pin. Signed-off-by: Jeffy Chen --- Changes in v3: None Changes in v2: None .../devicetree/bindings/pci/rockchip-pcie.txt| 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v3 1/4] PCI: rockchip: Fix error handlings

Fix error handlings in probe & resume. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: None Changes in v2: None drivers/pci/host/pcie-rockchip.c | 103 ++- 1 file changed, 58 insertions(+), 45 deletions(-) diff --git a/d

[PATCH v3 2/4] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris <briannor...@chromium.com> drivers/pci/host/pci

[PATCH v3 1/4] PCI: rockchip: Fix error handlings

Fix error handlings in probe & resume. Signed-off-by: Jeffy Chen --- Changes in v3: None Changes in v2: None drivers/pci/host/pcie-rockchip.c | 103 ++- 1 file changed, 58 insertions(+), 45 deletions(-) diff --git a/drivers/pci/host/pcie-rockchip

[PATCH v3 2/4] PCI: rockchip: Add support for pcie wake irq

Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- Changes in v3: Fix error handling Changes in v2: Use dev_pm_set_dedicated_wake_irq -- Suggested by Brian Norris drivers/pci/host/pcie-rockchip.c | 21 ++--- 1 file changed, 18

[PATCH v3 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

Norris <briannor...@chromium.com> Jeffy Chen (4): PCI: rockchip: Fix error handlings PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: rockchip: Add support for pcie wake irq arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru .../devicetree/bindings/pci/ro

[PATCH v3 0/4] PCI: rockchip: Move PCIE_WAKE handling into rockchip pcie driver

Norris Jeffy Chen (4): PCI: rockchip: Fix error handlings PCI: rockchip: Add support for pcie wake irq dt-bindings: PCI: rockchip: Add support for pcie wake irq arm64: dts: rockchip: Handle pcie wake in pcie driver for Gru .../devicetree/bindings/pci/rockchip-pcie.txt | 20

[PATCH v4 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> Acked-by: Rob Herring <r...@kernel.org> --- Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-s

[PATCH v4 9/9] dt-bindings: ASoC: rockchip: Update description of rockchip,codec

Update description for newly added optional audio codecs. Signed-off-by: Jeffy Chen Acked-by: Rob Herring --- Changes in v4: None Changes in v3: None Changes in v2: None Documentation/devicetree/bindings/sound/rockchip,rk3399-gru-sound.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v4 8/9] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 33 + 2 files c

[PATCH v4 6/9] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> --- Changes in v4: None Changes in v3: Use compatible to match audio codecs -- Suggested-by Matthias Kaehlcke <m...@chromium.org> Change

[PATCH v4 8/9] ASoC: rockchip: Add support for DMIC codec

Add support for optional dmic codec. Signed-off-by: Jeffy Chen --- Changes in v4: None Changes in v3: None Changes in v2: None sound/soc/rockchip/Kconfig| 1 + sound/soc/rockchip/rk3399_gru_sound.c | 33 + 2 files changed, 34 insertions(+) diff

[PATCH v4 6/9] ASoC: rockchip: Parse dai links from dts

Refactor rockchip_sound_probe, parse dai links from dts instead of hard coding them. Signed-off-by: Jeffy Chen --- Changes in v4: None Changes in v3: Use compatible to match audio codecs -- Suggested-by Matthias Kaehlcke Changes in v2: Let rockchip,codec-names be a required property

<    4   5   6   7   8   9   10   11   12   13   >