Re: [PATCH] spmi: regmap: enable userspace writes

On 2016-09-29 23:30, Mark Brown wrote: On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: -#undef REGMAP_ALLOW_WRITE_DEBUGFS +#define REGMAP_ALLOW_WRITE_DEBUGFS This is completely inappropriate for upstream, if you need to do debugging on your platform you can enable this locally

Re: [PATCH] spmi: regmap: enable userspace writes

On 2016-10-04 02:33, Stephen Boyd wrote: On 09/30, kgu...@codeaurora.org wrote: On 2016-09-29 23:30, Mark Brown wrote: >On Thu, Sep 29, 2016 at 05:06:26PM +0530, Kiran Gunda wrote: > >>-#undef REGMAP_ALLOW_WRITE_DEBUGFS >>+#define REGMAP_ALLOW_WRITE_DEBUGFS > >This is completely inappropriate

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

On 2017-08-08 13:42, Zhang Rui wrote: On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: From: David Collins Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The GEN2 subtype defines an over temperature state with hysteresis instead of stage in the

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

On 2017-08-16 17:53, kgu...@codeaurora.org wrote: On 2017-08-08 13:42, Zhang Rui wrote: On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: From: David Collins Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The GEN2 subtype defines an over

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-17 13:11, Shawn Guo wrote: Hi Kiran, On Fri, Jul 28, 2017 at 12:40:46PM +0530, Kiran Gunda wrote: From: David Collins Add support for version 5 of the SPMI PMIC arbiter. It utilizes different offsets for registers than those found on version 3. Also, the

Re: [PATCH V1 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup

On 2017-07-06 12:19, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename

Re: [PATCH V3 3/4] spmi: pmic-arb: add support for HW version 5

On 2017-07-14 23:00, Stephen Boyd wrote: On 07/11, Kiran Gunda wrote: @@ -420,7 +440,8 @@ static int pmic_arb_write_cmd(struct spmi_controller *ctrl, u8 opc, u8 sid, Mostly style nitpicks! Will check and address in the next patch. /* Start the transaction */

Re: [PATCH V2 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup

On 2017-07-14 23:50, Stephen Boyd wrote: On 07/10, Kiran Gunda wrote: -static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pa, u16 ppid) +static u16 pmic_arb_find_apid(struct spmi_pmic_arb *pmic_arb, u16 ppid) { + struct apid_data *apid_info = _arb->apid_data[pmic_arb->last_apid];

Re: [PATCH V1 15/15] spmi: pmic-arb: instantiate spmi_devices at arch_initcall

On 2017-06-01 03:37, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: @@ -1384,7 +1384,12 @@ static int spmi_pmic_arb_remove(struct platform_device *pdev) .of_match_table = spmi_pmic_arb_match_table, }, }; -module_platform_driver(spmi_pmic_arb_driver); + +int __init

Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq

On 2017-06-13 07:40, Stephen Boyd wrote: On 06/06, kgu...@codeaurora.org wrote: On 2017-06-02 12:56, kgu...@codeaurora.org wrote: >On 2017-05-31 23:23, Stephen Boyd wrote: >>On 05/30, Kiran Gunda wrote: >>>From: Subbaraman Narayanamurthy >>> >>>Currently, cleanup_irq()

Re: [PATCH V3 2/5] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other code cleanup

On 2017-07-19 04:16, Stephen Boyd wrote: On 07/18, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename

Re: [PATCH V4 0/4]: spmi: pmic-arb: support for V5 HW and bug fixes

On 2017-07-19 03:47, Stephen Boyd wrote: On 07/18, Kiran Gunda wrote: v4: * spmi: pmic-arb: add support for HW version 5 Clean-up as per Stephen's comments v3: * spmi: pmic-arb: add support for HW version 5 Modified #define INVALID (-1) to #define INVALID_EE0xFF.

Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

On 2017-07-28 05:31, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Replace the writel_relaxed with __raw_writel to avoid byte swapping in pmic_arb_write_data() function. That way the code is independent of the CPU endianness. Signed-off-by: Kiran Gunda Reviewed-by:

Re: [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup

On 2017-07-28 05:30, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename

Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function

On 2017-07-28 06:48, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Clean up the pmic_arb_find_apid() by using the local variables to improve the code readability. Signed-off-by: Kiran Gunda --- Reviewed-by: Stephen Boyd One nit below:

Re: [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table

On 2017-07-28 05:19, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Allocate the correct memory size (max_pmic_peripherals) for the mapping_table that holds the apid to ppid mapping. Also use a local variable for mapping_table for better alignment of the code. Signed-off-by: Kiran Gunda

Re: [PATCH V1 3/4] spmi: pmic-arb: add support for HW version 5

On 2017-07-06 12:29, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: From: David Collins Add support for version 5 of the SPMI PMIC arbiter. It utilizes different offsets for registers than those found on version 3. Also, the procedure to determine if writing and

Re: [PATCH V1 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

On 2017-07-06 12:16, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 5285245..2d2e39c 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -621,6 +621,19 @@ static int

Re: [PATCH V1 4/4] spmi: pmic-arb: Remove checking opc value not less than 0

On 2017-07-06 12:23, Stephen Boyd wrote: On 07/03, Kiran Gunda wrote: From: Fenglin Wu The opc parameter in pmic_arb_write_cmd() function is defined with type u8 and it's always greater than or equal to 0. Checking that it's not less than 0 is redundant and it can

Re: [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes

On 2017-07-28 12:40, Kiran Gunda wrote: v2: * [PATCH V2 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Added Stephen's Reviewed-by tag. * [PATCH V2 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Added Fixes tag and Stephen's Reviewed-by tag. * [PATCH V2

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

On 2017-08-23 02:01, Stephen Boyd wrote: On 08/22, Shawn Guo wrote: On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-17 17:58, Shawn Guo wrote: On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote: The intention of this check is to avoid the access to the peripherals those are not owned by the current EE (APSS) and it is expected to return a failure if the peripheral that is not

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-18 16:43, kgu...@codeaurora.org wrote: On 2017-08-17 17:58, Shawn Guo wrote: On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote: The intention of this check is to avoid the access to the peripherals those are not owned by the current EE (APSS) and it is expected

Re: [PATCH V1 09/15] spmi: pmic-arb: check apid enabled before calling the handler

On 2017-06-17 02:41, Stephen Boyd wrote: On 06/14, kgu...@codeaurora.org wrote: On 2017-06-01 02:09, Stephen Boyd wrote: >On 05/30, Kiran Gunda wrote: >>From: Abhijeet Dharmapurikar >> >>The driver currently invokes the apid handler (periph_handler()) > >You mean

Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq

On 2017-05-31 23:23, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Subbaraman Narayanamurthy Currently, cleanup_irq() is invoked when a peripheral's interrupt fires and there is no mapping present in the interrupt domain of spmi interrupt controller. The

Re: [PATCH V1 12/15] spmi-pmic-arb: fix a possible null pointer dereference

On 2017-05-31 22:59, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 2afe359..412481d 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -1003,6 +1003,12 @@ static int

Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups

On 2017-05-31 07:14, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 7201611..6320f1f 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -164,6 +164,8 @@ struct spmi_pmic_arb { *

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

Thanks Stephen for reviewing the patches. Responses inline. Thanks, Kiran On 2017-05-31 06:16, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar Usually *_dev best used for structures that embed a struct device in them. spmi_pmic_arb_dev

Re: [PATCH V1 03/15] spmi: pmic-arb: fix inconsistent use of apid and chan

On 2017-05-31 07:01, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar The driver currently uses "apid" and "chan" to mean apid. Remove the use of chan and use only apid. I'm not so sure. It currently uses "chan" to mean the offset to add

Re: [PATCH V1 06/15] spmi: pmic-arb: fix missing interrupts

On 2017-05-31 07:30, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar irq_enable is called when the device resumes. Note that the irq_enable is called regardless of whether the interrupt was marked enabled/disabled in the descriptor or

Re: [PATCH V1 13/15] spmi: pmic-arb: add support for HW version 5

On 2017-06-01 11:38, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: diff --git a/drivers/spmi/spmi-pmic-arb.c b/drivers/spmi/spmi-pmic-arb.c index 412481d..b755c24 100644 --- a/drivers/spmi/spmi-pmic-arb.c +++ b/drivers/spmi/spmi-pmic-arb.c @@ -112,7 +123,8 @@ enum pmic_arb_cmd_op_code {

Re: [PATCH V1 11/15] spmi: spmi-pmic-arb: enable the SPMI interrupt as a wakeup source

On 2017-05-31 22:43, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: Currently the SPMI interrupt will not wake the device. Enable this interrupt as a wakeup source. Signed-off-by: Nicholas Troast Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 07/15] spmi: pmic-arb: clear the latched status of the interrupt

On 2017-06-01 03:33, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar PMIC interrupts each have an internal latched status bit which is not visible from any register. This status bit is set as soon as the conditions specified in the

Re: [PATCH V1 08/15] spmi: pmic_arb: use appropriate flow handler

On 2017-06-01 00:33, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar The current code uses handle_level_irq flow handler even if the trigger type of the interrupt is edge. This can lead to missing of an edge transition that happens when

Re: [PATCH V1 10/15] spmi: pmic_arb: add support for PMIC bus arbiter v3

On 2017-06-01 03:48, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: /* PMIC Arbiter channel registers offsets */ @@ -96,6 +97,17 @@ enum pmic_arb_cmd_op_code { /* interrupt enable bit */ #define SPMI_PIC_ACC_ENABLE_BITBIT(0) +#define HWIRQ(slave_id, periph_id, irq_id,

Re: [PATCH V1 02/15] spmi: pmic-arb: rename spmi_pmic_arb_dev to spmi_pmic_arb

On 2017-06-02 23:59, Stephen Boyd wrote: On 06/01, kgu...@codeaurora.org wrote: >>@@ -209,23 +210,24 @@ static void pa_read_data(struct >>spmi_pmic_arb_dev *dev, u8 *buf, u32 reg, u8 bc) >> * @buf: buffer to write. length must be bc + 1. >> */ >> static void >>-pa_write_data(struct

Re: [PATCH V1 04/15] spmi: pmic-arb: optimize table lookups

On 2017-06-03 00:01, Stephen Boyd wrote: On 06/01, kgu...@codeaurora.org wrote: On 2017-05-31 07:14, Stephen Boyd wrote: >On 05/30, Kiran Gunda wrote: >>diff --git a/drivers/spmi/spmi-pmic-arb.c >>b/drivers/spmi/spmi-pmic-arb.c >>index 7201611..6320f1f 100644 >>---

Re: [PATCH V1 09/15] spmi: pmic-arb: check apid enabled before calling the handler

On 2017-06-01 02:09, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar The driver currently invokes the apid handler (periph_handler()) You mean periph_interrupt()? Yes. once it sees that the summary status bit for that apid is set.

Re: [PATCH V1 05/15] spmi: pmic-arb: cleanup unrequested irqs

On 2017-06-13 07:41, Stephen Boyd wrote: On 06/06, kgu...@codeaurora.org wrote: On 2017-05-31 07:27, Stephen Boyd wrote: >On 05/30, Kiran Gunda wrote: >>From: Abhijeet Dharmapurikar >> >>We see a unmapped irqs trigger right around bootup. This could >>likely be because

Re: [PATCH V1 01/15] spmi: pmic_arb: block access of invalid read and writes

On 2017-06-13 07:39, Stephen Boyd wrote: On 06/12, kgu...@codeaurora.org wrote: On 2017-05-31 06:03, Stephen Boyd wrote: >On 05/30, Kiran Gunda wrote: >>From: Abhijeet Dharmapurikar >> >>The system crashes due to bad access when reading from an non >>configured

Re: [PATCH V1 01/15] spmi: pmic_arb: block access of invalid read and writes

On 2017-05-31 06:03, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar The system crashes due to bad access when reading from an non configured peripheral and when writing to peripheral which is not owned by current ee. This patch

Re: [PATCH V1 14/15] spmi: pmic-arb: do not ack and clear peripheral interrupts in cleanup_irq

On 2017-06-02 12:56, kgu...@codeaurora.org wrote: On 2017-05-31 23:23, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Subbaraman Narayanamurthy Currently, cleanup_irq() is invoked when a peripheral's interrupt fires and there is no mapping present in the

Re: [PATCH V1 05/15] spmi: pmic-arb: cleanup unrequested irqs

On 2017-05-31 07:27, Stephen Boyd wrote: On 05/30, Kiran Gunda wrote: From: Abhijeet Dharmapurikar We see a unmapped irqs trigger right around bootup. This could likely be because the bootloader exited leaving the interrupts in an unknown or unhandled state. Ack and

Re: [PATCH] spmi: pmic-arb: Always allocate ppid_to_apid table

On 2017-06-27 07:47, Stephen Boyd wrote: After commit 7f1d4e58dabb ("spmi: pmic-arb: optimize table lookups") we always need the ppid_to_apid table regardless of the version of pmic arbiter we have. Otherwise, we will try to deref the array when we don't allocate it on v2 hardware like the

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

On 2017-08-26 04:49, Stephen Boyd wrote: On 08/25, Zhang Rui wrote: On Thu, 2017-08-17 at 13:12 +0530, kgu...@codeaurora.org wrote: > On 2017-08-16 17:53, kgu...@codeaurora.org wrote: > > > > On 2017-08-08 13:42, Zhang Rui wrote: > > > > > > On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote:

Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver

On 2017-11-17 12:26, Bjorn Andersson wrote: On Thu 16 Nov 22:36 PST 2017, kgu...@codeaurora.org wrote: On 2017-11-16 22:25, Bjorn Andersson wrote: > On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: > > > WLED driver provides the interface to the display driver to > > adjust the brightness of

Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver

On 2017-11-17 14:03, Lee Jones wrote: On Thu, 16 Nov 2017, Bjorn Andersson wrote: On Thu 16 Nov 22:36 PST 2017, kgu...@codeaurora.org wrote: > On 2017-11-16 22:25, Bjorn Andersson wrote: > > On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: > > > > > WLED driver provides the interface to the

Re: [PATCH V1 2/4] qcom: spmi-wled: Add support for short circuit handling

On 2017-11-18 02:00, Rob Herring wrote: On Thu, Nov 16, 2017 at 05:48:35PM +0530, Kiran Gunda wrote: Handle the short circuit(SC) interrupt and check if the SC interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the SC event persists.

Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver

On 2017-11-16 22:25, Bjorn Andersson wrote: On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: WLED driver provides the interface to the display driver to adjust the brightness of the display backlight. Hi Kiran, This driver has a lot in common with the already upstream pm8941-wled.c,

Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver

On 2017-12-05 07:31, Bjorn Andersson wrote: On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: WLED driver provides the interface to the display driver to adjust the brightness of the display backlight. Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 3/4] qcom: spmi-wled: Add support for OVP interrupt handling

On 2017-12-05 10:15, Bjorn Andersson wrote: On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware configuration is

Re: [PATCH V1 2/4] qcom: spmi-wled: Add support for short circuit handling

On 2017-12-05 10:05, Bjorn Andersson wrote: On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: Handle the short circuit(SC) interrupt and check if the SC interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the SC event persists. Signed-off-by:

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: If you really want someone to review your patch, please add more detailed explanations. 1. Please add 0th patch. I have already added the 0th

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 13:36, Dan Carpenter wrote: Hi Kiran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on backlight/for-backlight-next] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-14 22:32, Bjorn Andersson wrote: On Wed 09 May 00:14 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 23:40, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: > > [..] > > + > > +#define WLED_AUTO_DETECT_OVP_COUNT 5 > > +#define

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-14 22:27, Pavel Machek wrote: Hi! WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-07 23:40, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] + +#define WLED_AUTO_DETECT_OVP_COUNT 5 +#define WLED_AUTO_DETECT_CNT_DLY_USHZ /* 1 second */ +static bool wled_auto_detection_required(struct wled *wled) So

Re: [PATCH V2 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 16:09, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:31PM +0530, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware

Re: [PATCH V2 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-08 16:05, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:30PM +0530, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int wled_module_enable(struct wled > > *wled, int val) >

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 22:47, Bjorn Andersson wrote: On Tue 08 May 03:25 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > +- qcom,ovp > > + Usage:optional > > + Value type: > > +

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-09 10:36, kgu...@codeaurora.org wrote: On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-07 22:10, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:28PM +0530, Kiran Gunda wrote: pm8941-wled.c driver is supporting the WLED peripheral on pm8941. Rename it to qcom-wled.c so that it can support WLED on multiple PMICs. Signed-off-by: Kiran Gunda ---

Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 22:15, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-08 14:06, Daniel Thompson wrote: On Mon, May 07, 2018 at 11:26:59AM +0530, kgu...@codeaurora.org wrote: Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: > On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: > > If you really want someone

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Several things are going on in this

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 22:36, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event persists.

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-07 22:51, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware configuration is

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-17 18:01, Rob Herring wrote: On Thu, May 17, 2018 at 4:47 AM, wrote: On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs

Re: [PATCH V1 4/4] qcom: spmi-wled: Add auto-calibration logic support

On 2017-12-05 11:10, Bjorn Andersson wrote: On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: The auto-calibration algorithm checks if the current WLED sink configuration is valid. It tries enabling every sink and checks if the OVP fault is observed. Based on this information it detects and

Re: [PATCH V1 4/4] qcom: spmi-wled: Add auto-calibration logic support

On 2018-04-19 21:28, Bjorn Andersson wrote: On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote: On 2017-12-05 11:10, Bjorn Andersson wrote: > On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: > > > The auto-calibration algorithm checks if the current WLED sink > > configuration is

Re: [PATCH V1 4/4] qcom: spmi-wled: Add auto-calibration logic support

On 2018-04-20 21:33, Bjorn Andersson wrote: On Thu 19 Apr 22:43 PDT 2018, kgu...@codeaurora.org wrote: On 2018-04-19 21:28, Bjorn Andersson wrote: > On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote: > > On 2017-12-05 11:10, Bjorn Andersson wrote: [..] > > > When is this feature

Re: [PATCH V1 4/4] qcom: spmi-wled: Add auto-calibration logic support

On 2018-04-20 11:13, kgu...@codeaurora.org wrote: On 2018-04-19 21:28, Bjorn Andersson wrote: On Thu 19 Apr 03:45 PDT 2018, kgu...@codeaurora.org wrote: On 2017-12-05 11:10, Bjorn Andersson wrote: > On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote: > > > The auto-calibration algorithm checks

Re: [PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

On 2018-06-20 11:17, Vinod wrote: On 19-06-18, 16:43, Kiran Gunda wrote: struct wled { const char *name; struct device *dev; struct regmap *regmap; + struct mutex lock; /* Lock to avoid race from ISR */ the comment is wrong as you avoid race with thread

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-14 22:32, Bjorn Andersson wrote: On Wed 09 May 00:14 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 23:40, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: > > [..] > > + > > +#define WLED_AUTO_DETECT_OVP_COUNT 5 > > +#define

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-14 22:27, Pavel Machek wrote: Hi! WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda --- .../bindings/leds/backlight/qcom-wled.txt | 172

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: If you really want someone to review your patch, please add more detailed explanations. 1. Please add 0th patch. I have already added the 0th

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 13:36, Dan Carpenter wrote: Hi Kiran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on backlight/for-backlight-next] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-17 18:01, Rob Herring wrote: On Thu, May 17, 2018 at 4:47 AM, wrote: On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-08 14:06, Daniel Thompson wrote: On Mon, May 07, 2018 at 11:26:59AM +0530, kgu...@codeaurora.org wrote: Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: > On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: > > If you really want someone

Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 22:15, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Several things are going on in this

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-07 22:10, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:28PM +0530, Kiran Gunda wrote: pm8941-wled.c driver is supporting the WLED peripheral on pm8941. Rename it to qcom-wled.c so that it can support WLED on multiple PMICs. Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 22:36, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event persists.

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-07 22:51, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware configuration is

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int wled_module_enable(struct wled > > *wled, int val) >

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 22:47, Bjorn Andersson wrote: On Tue 08 May 03:25 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > +- qcom,ovp > > + Usage:optional > > + Value type: > > +

Re: [PATCH V2 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 16:09, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:31PM +0530, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware

Re: [PATCH V2 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-08 16:05, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:30PM +0530, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-09 10:36, kgu...@codeaurora.org wrote: On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-07 23:40, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] + +#define WLED_AUTO_DETECT_OVP_COUNT 5 +#define WLED_AUTO_DETECT_CNT_DLY_USHZ /* 1 second */ +static bool wled_auto_detection_required(struct wled *wled) So

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

On 2017-08-16 17:53, kgu...@codeaurora.org wrote: On 2017-08-08 13:42, Zhang Rui wrote: On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote: From: David Collins Add support for the TEMP_ALARM GEN2 PMIC peripheral subtype.  The GEN2 subtype defines an over temperature state with hysteresis

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-17 13:11, Shawn Guo wrote: Hi Kiran, On Fri, Jul 28, 2017 at 12:40:46PM +0530, Kiran Gunda wrote: From: David Collins Add support for version 5 of the SPMI PMIC arbiter. It utilizes different offsets for registers than those found on version 3. Also, the procedure to determine if

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-17 17:58, Shawn Guo wrote: On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote: The intention of this check is to avoid the access to the peripherals those are not owned by the current EE (APSS) and it is expected to return a failure if the peripheral that is not

Re: [PATCH V2 11/12] spmi: pmic-arb: add support for HW version 5

On 2017-08-18 16:43, kgu...@codeaurora.org wrote: On 2017-08-17 17:58, Shawn Guo wrote: On Thu, Aug 17, 2017 at 03:38:30PM +0530, kgu...@codeaurora.org wrote: The intention of this check is to avoid the access to the peripherals those are not owned by the current EE (APSS) and it is expected

Re: [PATCH V2 00/12]: spmi: pmic-arb: Support for HW v5 and other fixes

On 2017-07-28 12:40, Kiran Gunda wrote: v2: * [PATCH V2 04/12] spmi: pmic-arb: optimize qpnpint_irq_set_type function Added Stephen's Reviewed-by tag. * [PATCH V2 05/12] spmi: pmic-arb: fix memory allocation for mapping_table Added Fixes tag and Stephen's Reviewed-by tag. * [PATCH V2

Re: [PATCH V1 2/4] qcom: spmi-wled: Add support for short circuit handling

On 2017-11-18 02:00, Rob Herring wrote: On Thu, Nov 16, 2017 at 05:48:35PM +0530, Kiran Gunda wrote: Handle the short circuit(SC) interrupt and check if the SC interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the SC event persists.

Re: [PATCH V1] thermal: qcom-spmi-temp-alarm: add support for GEN2 PMIC peripherals

On 2017-08-26 04:49, Stephen Boyd wrote: On 08/25, Zhang Rui wrote: On Thu, 2017-08-17 at 13:12 +0530, kgu...@codeaurora.org wrote: > On 2017-08-16 17:53, kgu...@codeaurora.org wrote: > > > > On 2017-08-08 13:42, Zhang Rui wrote: > > > > > > On Thu, 2017-07-13 at 17:39 +0530, Kiran Gunda wrote:

  1   2   >