NM
--- Matthew Dharm [EMAIL PROTECTED]
wrote:
No kidding... getting this once was funny enough on
this mailing list...
but twice in the same day? I am just rolling in the
asiles here...
Matt
On Sat, Jun 16, 2001 at 01:34:59AM +0200, Tobias
Ringstrom wrote:
On Fri, 15 Jun 2001,
Stelian Pop wrote:
After resyncing cogito to the latest version (which incorporates the
'pack' changes, which were causing the failure), it does indeed work
again, when using rsync.
I also found that using cogito-0.12 in my existing source directory
would not update properly. After some
On Mon, 21 Feb 2005, David Roundy wrote:
snip very technical discussion
I just scanned the comparison of various source-code management
schemes at
http://zooko.com/revision_control_quick_ref.html
and found myself wishing for a similar review of bk (which was
excluded, not being open-source).
Jeremy Fitzhardinge wrote:
Frederik Deweerdt wrote:
Same problems here with 2.6.20-rc1-mm1 (ie with the %gs-%fs patch).
It seems to me that the problem comes from the EFL_OFFSET no longer
beeing accurate.
The following patch fixes the problem for me.
Thanks Frederik; that's exactly the
Jens Axboe wrote:
On Fri, Jul 13 2007, Gabriel C wrote:
Hello ,
While doing some tests with 2.6.22-git2 ( at the time head
4eb6bf6bfb580afaf1e1a1d30cba17a078530cf4 ) all my webservers stopped
working.
I can't get any file using wget or whatever else , everything hangs
after 1% forever.
I
Ken Chen wrote:
On 5/21/07, Ken Chen [EMAIL PROTECTED] wrote:
...
tested, like this?
Ken, your patch below works for me. Are you going to send this
on to Linus?
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 5526ead..0ed5470 100644
--- a/drivers/block/loop.c
+++
Jeff Garzik wrote:
On Tue, Jun 05, 2007 at 11:31:46PM +0200, Mikael Pettersson wrote:
I can easily reproduce the problem in 2.6.22-rc4. There are no
sata_promise changes between rc3 and rc4, but Tejun's libata
polling SETXFER change was included in rc4. Reverting it makes
sata_promise work
Tejun Heo wrote:
... Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA
commands are issued using TF interface if ATA_TFLAG_POLLING is set.
This patch fixes detection failure introduced by polling SETXFERMODE.
Your patch works for me, thanks.
-
To unsubscribe from this list: send the line
On 01/09/2014 03:50 PM, Sarah Sharp wrote:
On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
The aftermarket usb3 adapter card and the usb3 outboard hard-drive docking
station are the only two usb3 devices I have.
I've wondered if my xhci problems might be caused by hardware quirks
On 01/09/2014 03:50 PM, Sarah Sharp wrote:
On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
I've wondered if my xhci problems might be caused by hardware quirks, and
wondering why I seem to be the only one who has this problem.
Maybe I could take one for the team by buying new hardware
On 01/14/2014 09:20 AM, Sarah Sharp wrote:
On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote:
Sarah, I just fixed my xhci bug for US$19.99 :)
#lspci | tail -1
04:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller
(rev 03)
This new NEC usb3 controller does
On 01/21/2014 01:51 AM, David Laight wrote:
From: Sarah Sharp
On Mon, Jan 20, 2014 at 11:21:14AM +, David Laight wrote:
...
A guess...
In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead
of xhci_td_remainder().
Why? Walt has a 0.96 xHCI host controller, and the format
. Either way, I'll have to look into it.
I'll let you know when I have some diagnostic patches ready.
Hi Walt,
I have a couple of patches for you to test.
Please only apply the first patch (which is diagnostic only), trigger
your issue, and send me the resulting dmesg. Then try applying
On 01/07/2014 05:58 AM, David Laight wrote:
The dmesg contains:
[ 538.728064] EXT4-fs warning (device dm-0): ext4_end_bio:316: I/O error
writing to inode 23330865 (offset 0 size 8388608 starting block 812628)
An 8MB transfer will need at least 128 ring entries (TRB) even if the request
Okay, I used log_buf_len to make dmesg bigger and now I think I have
the whole thing. It's attached.
dmesg2.gz
Description: application/gzip
On 01/03/2014 03:29 PM, Sarah Sharp wrote:
I'll let you know when I have some diagnostic patches ready.
Hi Sarah. I see today gregkh committed the patches you've already sent
me, so I assume someone (other than me) has tested those patches and
discovered some benefit from them?
I'm still
On 01/09/2014 02:05 AM, David Laight wrote:
From: walt
...
I'm still wondering if I'm suffering from hardware quirks. From the
first day I installed my usb3 adapter card and the usb3 disk docking
station I've noticed some quirky behavior.
Ah - this isn't an 'on chip' usb3 adapter.
Some
On 01/17/2014 06:34 AM, David Laight wrote:
From: walt
Oy, Sarah! ;) I put the ASMedia adapter in my older amd64 machine, and,
well,
the stupid thing Just Works(TM) with kernel 3.12.7! (Yes, with the same disk
docking station, too.)
I can't believe the adapter works perfectly
On 01/17/2014 06:34 AM, David Laight wrote:
Can you try the patch I posted that stops the ownership on LINK TRBs
being changed before that on the linked-to TRB?
Please disregard my earlier post about the patch not applying cleanly.
That was the usual html corruption, so I found the original on
On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
3.12-stable review patch. If anyone has any objections, please let me know.
--
From: David Laight david.lai...@aculab.com
commit 35773dac5f862cb1c82ea151eba3e2f6de51ec3e upstream.
Section 4.11.7.1 of rev 1.0 of the
On 01/02/2014 11:15 AM, Sarah Sharp wrote:
On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
3.12-stable review patch. If anyone has any objections, please let me know.
--
From: David Laight david.lai...@aculab.com
On 01/03/2014 11:54 AM, Sarah Sharp wrote:
On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote:
On 01/02/2014 11:15 AM, Sarah Sharp wrote:
On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
3.12-stable review patch. If anyone has any
Fixed three WARNING: Missing a blank line after declarations from
checkpatch.pl
Signed-off-by: Walt <waltfea...@gmail.com>
---
drivers/accessibility/braille/braille_console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/accessibility/braille/braille_console.c
b/d
Fixed one 48: ERROR: Use 4 digit octal (0777) not decimal permissions
per checkpatch.
Signed-off-by: Walt <waltfea...@gmail.com>
---
drivers/accessibility/braille/braille_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/braille/braille_con
NM
--- Matthew Dharm <[EMAIL PROTECTED]>
wrote:
> No kidding... getting this once was funny enough on
> this mailing list...
> but twice in the same day? I am just rolling in the
> asiles here...
>
> Matt
>
> On Sat, Jun 16, 2001 at 01:34:59AM +0200, Tobias
> Ringstrom wrote:
> > On Fri, 15
On Mon, 21 Feb 2005, David Roundy wrote:
I just scanned the comparison of various source-code management
schemes at
http://zooko.com/revision_control_quick_ref.html
and found myself wishing for a similar review of bk (which was
excluded, not being open-source).
Would you (or anyone else)
Stelian Pop wrote:
After resyncing cogito to the latest version (which incorporates the
'pack' changes, which were causing the failure), it does indeed work
again, when using rsync.
I also found that using cogito-0.12 in my existing source directory
would not update properly. After some
Jeremy Fitzhardinge wrote:
> Frederik Deweerdt wrote:
>> Same problems here with 2.6.20-rc1-mm1 (ie with the %gs->%fs patch).
>> It seems to me that the problem comes from the EFL_OFFSET no longer
>> beeing accurate.
>> The following patch fixes the problem for me.
>>
>
> Thanks Frederik;
Jeff Garzik wrote:
On Tue, Jun 05, 2007 at 11:31:46PM +0200, Mikael Pettersson wrote:
I can easily reproduce the problem in 2.6.22-rc4. There are no
sata_promise changes between rc3 and rc4, but Tejun's libata
polling SETXFER change was included in rc4. Reverting it makes
sata_promise work
Tejun Heo wrote:
... Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA
commands are issued using TF interface if ATA_TFLAG_POLLING is set.
This patch fixes detection failure introduced by polling SETXFERMODE.
Your patch works for me, thanks.
-
To unsubscribe from this list: send the line
Ken Chen wrote:
On 5/21/07, Ken Chen <[EMAIL PROTECTED]> wrote:
...
tested, like this?
Ken, your patch below works for me. Are you going to send this
on to Linus?
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 5526ead..0ed5470 100644
--- a/drivers/block/loop.c
+++
Jens Axboe wrote:
On Fri, Jul 13 2007, Gabriel C wrote:
Hello ,
While doing some tests with 2.6.22-git2 ( at the time head
4eb6bf6bfb580afaf1e1a1d30cba17a078530cf4 ) all my webservers stopped
working.
I can't get any file using wget or whatever else , everything hangs
after 1% forever.
I
e the link TRB.
>>
>> I suspect David's patch triggers a bug in the command cancellation code.
>> There's also the unlikely possibility that the no-op TRBs did indeed
>> cause the host to hang. Either way, I'll have to look into it.
>>
>> I'll let you know when I
On 01/07/2014 05:58 AM, David Laight wrote:
> The dmesg contains:
>
> [ 538.728064] EXT4-fs warning (device dm-0): ext4_end_bio:316: I/O error
> writing to inode 23330865 (offset 0 size 8388608 starting block 812628)
>
> An 8MB transfer will need at least 128 ring entries (TRB) even if the
Okay, I used log_buf_len to make dmesg bigger and now I think I have
the whole thing. It's attached.
dmesg2.gz
Description: application/gzip
On 01/03/2014 03:29 PM, Sarah Sharp wrote:
> I'll let you know when I have some diagnostic patches ready.
Hi Sarah. I see today gregkh committed the patches you've already sent
me, so I assume someone (other than me) has tested those patches and
discovered some benefit from them?
I'm still
On 01/09/2014 02:05 AM, David Laight wrote:
>> From: walt
> ...
>> I'm still wondering if I'm suffering from hardware quirks. From the
>> first day I installed my usb3 adapter card and the usb3 disk docking
>> station I've noticed some quirky behavior.
>
>
On 01/09/2014 03:50 PM, Sarah Sharp wrote:
>>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
>>
>> The aftermarket usb3 adapter card and the usb3 outboard hard-drive docking
>> station are the only two usb3 devices I have.
>>
>> I've wonde
On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
> 3.12-stable review patch. If anyone has any objections, please let me know.
>
> --
>
> From: David Laight
>
> commit 35773dac5f862cb1c82ea151eba3e2f6de51ec3e upstream.
>
> Section 4.11.7.1 of rev 1.0 of the xhci
On 01/02/2014 11:15 AM, Sarah Sharp wrote:
> On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
>> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
>>> 3.12-stable review patch. If anyone has any objections, please let me know.
>>>
>>> -
On 01/03/2014 11:54 AM, Sarah Sharp wrote:
> On Fri, Jan 03, 2014 at 07:40:33AM -0800, walt wrote:
>> On 01/02/2014 11:15 AM, Sarah Sharp wrote:
>>> On Tue, Dec 31, 2013 at 12:40:16PM -0800, walt wrote:
>>>> On 12/18/2013 01:11 PM, Greg Kroah-Hartman wrote:
On 01/09/2014 03:50 PM, Sarah Sharp wrote:
>>> On Tue, Jan 07, 2014 at 03:57:00PM -0800, walt wrote:
>>
>> I've wondered if my xhci problems might be caused by hardware quirks, and
>> wondering why I seem to be the only one who has this problem.
>>
>&g
On 01/14/2014 09:20 AM, Sarah Sharp wrote:
> On Mon, Jan 13, 2014 at 03:39:07PM -0800, walt wrote:
>> Sarah, I just fixed my xhci bug for US$19.99 :)
>>
>> #lspci | tail -1
>> 04:00.0 USB controller: NEC Corporation uPD720200 USB 3.0 Host Controller
>> (rev 03)
&
On 01/21/2014 01:51 AM, David Laight wrote:
> From: Sarah Sharp
>> On Mon, Jan 20, 2014 at 11:21:14AM +, David Laight wrote:
> ...
>>> A guess...
>>>
>>> In queue_bulk_sg_tx() try calling xhci_v1_0_td_remainder() instead
>>> of xhci_td_re
On 01/17/2014 06:34 AM, David Laight wrote:
> From: walt
>> Oy, Sarah! ;) I put the ASMedia adapter in my older amd64 machine, and,
>> well,
>> the stupid thing Just Works(TM) with kernel 3.12.7! (Yes, with the same disk
>> docking station, too.)
>>
>
On 01/17/2014 06:34 AM, David Laight wrote:
> Can you try the patch I posted that stops the ownership on LINK TRBs
> being changed before that on the linked-to TRB?
Please disregard my earlier post about the patch not applying cleanly.
That was the usual html corruption, so I found the original
Fixed three WARNING: Missing a blank line after declarations from
checkpatch.pl
Signed-off-by: Walt
---
drivers/accessibility/braille/braille_console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/accessibility/braille/braille_console.c
b/drivers/accessibility/braille
Fixed one 48: ERROR: Use 4 digit octal (0777) not decimal permissions
per checkpatch.
Signed-off-by: Walt
---
drivers/accessibility/braille/braille_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/accessibility/braille/braille_console.c
b/drivers
processor. But there is no guarantee that
the set of global ID's will be contiguous.
It's possible to have disjoint (non-contiguous) physical processor
ID's if a processor bus is not completely populated, or there is an
empty processor slot or odd processor numbering in firmware, or
whatever.
--Walt
-
To unsubs
it easier to support non-linear (NUMA) systems.
--Walt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
the hard
address of the cpu. I don't think this ever has to leak out to the
common kernel code, or am i missing something here.
No your not, I was. I completely misinterpreted your question.
Sorry about that.
Hubertus and Kanoj have provided the answer I should have given.
--Walt
-
To unsubscribe
,
wouldn't the inability of the balance to adjust it adversely affect
performance if the load changes at a later time? I'm used to my old SMP
box with 2 physical cores, so this is just something I've wondered about
on the new box. Thanks,
-Walt
-
To unsubscribe from this list: send the line
Made suggested modifications from checkpatch in reference
to ERROR: Use 4 digit octal (0777) not decimal permissions
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/accessibility/braille/braille_console.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
Made suggested modifications from checkpatch in reference
to WARNING: Missing a blank line after declarations
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/accessibility/braille/braille_console.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/accessibility/b
Made suggested modifications from checkpatch in reference
to: CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_spkout.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff
Modified block comment for alignment consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 54b2f39..2
Corrected a spelling mistake for control
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_cls.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.h b/drivers/staging/dgnc/dgnc_cls.h
index 2597e36..463ad30
Made suggested modifications from checkpatch in reference
to: CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_soft.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff
This reverts commit 0970517be9d3d3e3a2fd5aa5a9938318b375f2d0.
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 40d272c..ec1ee3e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11540,7 +11540,7 @@ F: drivers/staging/slicoss/
Made suggested modifications from checkpatch in reference
to: WARNING: Block comments should align the * on each line
Modified multiline comment to single
Removed blank line at end
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_txprt
Corrected spelling mistake for statements
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.h
b/drivers/staging/dgnc/dgnc_driver.h
index 8792026..5
Made suggested modifications from checkpatch in reference
to: CHECK: Please don't use multiple blank lines
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_soft.c | 2 --
1 file chan
Modified block comment for alignment consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c
index 54b2f39..8
Made suggested modifications from checkpatch in reference
to CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/s
Made suggested modifications from checkpatch in reference
to CHECK: spaces preferred around that '/,+,-'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/s
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/s
Made suggested modifications from checkpatch in reference
to CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/synth.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/speakup/syn
Modified block comment to multiline style
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/thread.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/thread.c b/drivers/staging/speakup/thread.c
index 90c383e..e4de7dc
Made suggested modifications from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/thread.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/th
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/s
Modified block comments for style consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/s
Modified email address to reflect current address
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/TODO | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO
index 3094799..993410c
Modified multiline comment to single
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_soft.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/speakup_soft.c
b/drivers/staging/speakup/speakup_soft.c
Made suggested modifications from checkpatch in reference
to: WARNING: Block comments should align the * on each line
Modified multiline text to single
Removed blankline at end
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_spkout.c | 8 +++--
Made suggested modifications from checkpatch in reference
to CHECK: spaces preferred around that '+'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/spk_priv_keyinfo.h | 44 +++---
1 file changed, 22 insertions(+), 22 deletions(-)
diff
Modified block comments for style consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc
Modified block comment to multiline style
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/varhandlers.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/varhandlers.c
b/drivers/staging/speakup/varhandlers.c
index 2
Made suggested modifications from checkpatch in reference
to CHECK: Blank lines aren't necessary before a close brace '}'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_dr
Made suggested modifications from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_soft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/s
Made suggested modifications from checkpatch in reference
to: CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_soft.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/d
Made suggested modifications from checkpatch in reference
to: CHECK: spaces preferred around that '|'
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/speakup_txprt.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/d
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/spk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/s
Modified email address per the TODO file in
speakup's email listing, also verified email
address from speakup's website
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index e
Made suggested modifications from checkpatch in reference
to CHECK: Please don't use multiple blank lines
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/skein/threefish_block.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/staging
Modified block comments for style consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc
Modified block comments for style consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 48 -
1 file changed, 23 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/s
Make suggested modification from checkpatch in reference
to: CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/s
Make suggested modification from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 37 -
1 file changed, 16 insertions(+), 21 del
Make suggested modification from checkpatch in reference
to: CHECK: No space is necessary after a cast
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/s
Make suggested modification from checkpatch in reference
to: CHECK: Logical continuations should be on the previous line
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 20 +---
1 file changed, 9 insertions(+), 11 deletions(-)
Make alignment changes to tabular data for consistency
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main.h | 52
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/staging/xgifb/XGI_main.h b/d
Make suggested modification from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 29 +
1 file changed, 13 insertions(+), 16 deletions(-)
diff
Make suggested modification from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/xgifb/XGI_main_26.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff
Made suggested modifications from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/i18n.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/speakup/i1
Made suggested modifications from checkpatch in reference
to WARNING: Block comments should align the * on each line
CHECK: Please use a blank line after function/struct/union/enum declarations
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/main.c | 3
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Additionally add space around operators
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/selection.c | 4 ++--
1 file changed, 2 insertions(+), 2 del
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/speakup/
Made suggested modifications from checkpatch in reference
to CHECK: Alignment should match open parenthesis
additionally moved operators to end of line
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/main.c | 40 ++---
Made suggested modifications from checkpatch in reference
to: CHECK: Alignment should match open parenthesis
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/keyhelp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/s
Made suggested modifications from checkpatch in reference
to: WARNING: Block comments should align the * on each line
Signed-off-by: Walt Feasel <waltfea...@gmail.com>
---
drivers/staging/speakup/i18n.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/d
1 - 100 of 486 matches
Mail list logo
