Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Asias He
Hello Christoffer, On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall wrote: > On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: >> On 07/24/2015 08:00 AM, Matt Ma wrote: >> > Hi all, >> > >> > Linaro has developed the foundation for the new Android Emulator code >> > base

Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Asias He
Hello Christoffer, On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall christoffer.d...@linaro.org wrote: On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: On 07/24/2015 08:00 AM, Matt Ma wrote: Hi all, Linaro has developed the foundation for the new Android Emulator

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-30 Thread Asias He
t; independent results. I'd love to run the test but I do not have fast devices around. It would be nice if Nick can give a try ;-) 1) Set .nr_hw_queues to 1 instead 4 for now. 2) Drop some more unused code in the other mail I sent Otherwise, feel free to add: Acked-by: Asias He > -- >

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-30 Thread Asias He
to have independent results. I'd love to run the test but I do not have fast devices around. It would be nice if Nick can give a try ;-) 1) Set .nr_hw_queues to 1 instead 4 for now. 2) Drop some more unused code in the other mail I sent Otherwise, feel free to add: Acked-by: Asias He as...@redhat.com

Re: [PATCH] vhost/scsi: Fix incorrect usage of get_user_pages_fast write parameter

2013-10-27 Thread Asias He
irtio-scsi DMA_TO_DEVICE -> WRITE payload case. > > This bug would manifest itself as random process segmentation faults on > KVM host after repeated vhost starts + stops and/or with lots of vhost > endpoints + LUNs. > > Cc: Stefan Hajnoczi > Cc: Michael S. Tsirkin

Re: [PATCH] vhost/scsi: Fix incorrect usage of get_user_pages_fast write parameter

2013-10-27 Thread Asias He
- WRITE payload case. This bug would manifest itself as random process segmentation faults on KVM host after repeated vhost starts + stops and/or with lots of vhost endpoints + LUNs. Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Asias He

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Asias He
On Fri, Oct 25, 2013 at 06:05:01AM -0700, Christoph Hellwig wrote: > Switch virtio-blk from the dual support for old-style requests and bios > to use the block-multiqueue. For now pretend to have 4 issue queues > as Jens pulled that out of his this hair and it worked. > > Signed-off-by: Jens

Re: [PATCH 2/2] virtio_blk: blk-mq support

2013-10-25 Thread Asias He
On Fri, Oct 25, 2013 at 06:05:01AM -0700, Christoph Hellwig wrote: Switch virtio-blk from the dual support for old-style requests and bios to use the block-multiqueue. For now pretend to have 4 issue queues as Jens pulled that out of his this hair and it worked. Signed-off-by: Jens Axboe

Re: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

2013-09-17 Thread Asias He
AT > to kzalloc() flags to do this fallback only when really needed. > > Reported-by: Dan Aloni > Signed-off-by: Michael S. Tsirkin Reviewed-by: Asias He > --- > > I put this on my vhost fixes branch, intend to merge for 3.12. > Dan, could you please confirm this works f

Re: [PATCH] vhost/scsi: use vmalloc for order-10 allocation

2013-09-17 Thread Asias He
to do this fallback only when really needed. Reported-by: Dan Aloni alo...@stratoscale.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Asias He as...@redhat.com --- I put this on my vhost fixes branch, intend to merge for 3.12. Dan, could you please confirm this works

Re: [PATCH-v5 2/6] target: Add transport_init_session_tags using per-cpu ida

2013-09-03 Thread Asias He
- Update to percpu-ida usage > > Cc: Kent Overstreet > Cc: Asias He > Cc: Michael S. Tsirkin > Signed-off-by: Nicholas Bellinger Reviewed-by: Asias He > --- > drivers/target/target_core_transport.c | 48 > > include/target/ta

Re: [PATCH-v5 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory

2013-09-03 Thread Asias He
_make_nexus() code. > > This includes sanity checks within vhost_scsi_map_to_sgl() > to reject I/O that exceeds these initial hardcoded values, and > the necessary cleanup in tcm_vhost_make_nexus() failure path + > tcm_vhost_drop_nexus(). > > v3 changes: > - Rebase to v3.11-rc5 code &

Re: [PATCH-v5 4/6] vhost/scsi: Add pre-allocation for tv_cmd SGL + upages memory

2013-09-03 Thread Asias He
...@redhat.com Cc: Asias He as...@redhat.com Cc: Kent Overstreet k...@daterainc.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Reviewed-by: Asias He as...@redhat.com --- drivers/vhost/scsi.c | 99 -- 1 files changed, 80 insertions(+), 19

Re: [PATCH-v5 2/6] target: Add transport_init_session_tags using per-cpu ida

2013-09-03 Thread Asias He
k...@daterainc.com Cc: Asias He as...@redhat.com Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Nicholas Bellinger n...@linux-iscsi.org Reviewed-by: Asias He as...@redhat.com --- drivers/target/target_core_transport.c | 48 include/target

Re: [PATCH 0/5] Enable Drivers for Intel MIC X100 Coprocessors.

2013-08-01 Thread Asias He
Hello Sudeep Dutt, On Wed, Jul 31, 2013 at 06:46:08PM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 24, 2013 at 08:31:31PM -0700, Sudeep Dutt wrote: > > An Intel MIC X100 device is a PCIe form factor add-in coprocessor > > card based on the Intel Many Integrated Core (MIC) architecture > > that

Re: [PATCH 0/5] Enable Drivers for Intel MIC X100 Coprocessors.

2013-08-01 Thread Asias He
Hello Sudeep Dutt, On Wed, Jul 31, 2013 at 06:46:08PM -0700, Greg Kroah-Hartman wrote: On Wed, Jul 24, 2013 at 08:31:31PM -0700, Sudeep Dutt wrote: An Intel MIC X100 device is a PCIe form factor add-in coprocessor card based on the Intel Many Integrated Core (MIC) architecture that runs a

Re: [PATCH 2/2] virtio_net: fix race in RX VQ processing

2013-07-09 Thread Asias He
l, causing us to lose RX events. > > > > To fix, call virtqueue_enable_cb_prepare with NAPI_STATE_SCHED > > set (under napi lock), later call virtqueue_poll with > > NAPI_STATE_SCHED clear (outside the lock). > > > > Reported-by: Jason Wang > > Signed-off

Re: [PATCH 1/2] virtio: support unlocked queue poll

2013-07-09 Thread Asias He
means we might be able to get rid of a > barrier here. Deferring this optimization until we do some > benchmarking. > > Signed-off-by: Michael S. Tsirkin Acked-by: Asias He > --- > drivers/virtio/virtio_ring.c | 56 > ++--

Re: [PATCH 1/2] virtio: support unlocked queue poll

2013-07-09 Thread Asias He
be able to get rid of a barrier here. Deferring this optimization until we do some benchmarking. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Asias He as...@redhat.com --- drivers/virtio/virtio_ring.c | 56 ++-- include/linux/virtio.h

Re: [PATCH 2/2] virtio_net: fix race in RX VQ processing

2013-07-09 Thread Asias He
napi lock), later call virtqueue_poll with NAPI_STATE_SCHED clear (outside the lock). Reported-by: Jason Wang jasow...@redhat.com Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Asias He as...@redhat.com --- Tested-by: Jason Wang jasow...@redhat.com Acked-by: Jason Wang

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Asias He
uling a refill work which can guarantee the > serialization of refill. > > Cc: Sasha Levin > Cc: Rusty Russell > Cc: Michael S. Tsirkin > Signed-off-by: Jason Wang Reviewed-by: Asias He > --- > drivers/net/virtio_net.c |5 + > 1 files changed, 1 insertio

Re: [PATCH net] virtio-net: fix the race between channels setting and refill

2013-07-03 Thread Asias He
the serialization of refill. Cc: Sasha Levin sasha.le...@oracle.com Cc: Rusty Russell ru...@rustcorp.com.au Cc: Michael S. Tsirkin m...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com Reviewed-by: Asias He as...@redhat.com --- drivers/net/virtio_net.c |5 + 1 files changed, 1

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

2013-06-21 Thread Asias He
fter passing it > to vhost_net_ubuf_put_and_wait, this results > in use after free. > To fix, don't free the argument in vhost_net_ubuf_put_and_wait, > add an new API for callers that want to free ubufs. > > Signed-off-by: Michael S. Tsirkin Acked-by: Asias He > --- > >

Re: [PATCH net] vhost-net: fix use-after-free in vhost_net_flush

2013-06-21 Thread Asias He
it to vhost_net_ubuf_put_and_wait, this results in use after free. To fix, don't free the argument in vhost_net_ubuf_put_and_wait, add an new API for callers that want to free ubufs. Signed-off-by: Michael S. Tsirkin m...@redhat.com Acked-by: Asias He as...@redhat.com --- Dave, this is needed for stable

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Asias He
On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: > Randy Dunlap writes: > > On 05/16/13 16:42, Rusty Russell wrote: > >> Joe Perches writes: > >>> On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: > >>>> Asias He writes: >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-19 Thread Asias He
On Fri, May 17, 2013 at 04:25:49PM +0930, Rusty Russell wrote: Randy Dunlap rdun...@infradead.org writes: On 05/16/13 16:42, Rusty Russell wrote: Joe Perches j...@perches.com writes: On Thu, 2013-05-16 at 13:04 +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: On Wed, May 15

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote: > Asias He writes: > > On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >> >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote: > "Nicholas A. Bellinger" writes: > > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > >> Asias He writes: > >> > scsi.c includes vhost.c which uses memcpy_fromiovec. > >

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: > Asias He writes: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Dunlap: > >''' > >on x86_64: > &

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: > > Asias He writes: > > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > > > This patch fixes this build failu

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 01:04:58PM +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: scsi.c includes vhost.c which uses memcpy_fromiovec. This patch fixes this build failure

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 03:37:30PM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: scsi.c includes vhost.c which uses memcpy_fromiovec. This patch fixes this build failure. From Randy Dunlap

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Wed, May 15, 2013 at 02:47:53PM +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: scsi.c includes vhost.c which uses memcpy_fromiovec. This patch fixes this build failure. From Randy Dunlap: ''' on x86_64: ERROR: memcpy_fromiovec [drivers/vhost

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-15 Thread Asias He
On Thu, May 16, 2013 at 09:05:38AM +0930, Rusty Russell wrote: Nicholas A. Bellinger n...@linux-iscsi.org writes: On Wed, 2013-05-15 at 14:47 +0930, Rusty Russell wrote: Asias He as...@redhat.com writes: scsi.c includes vhost.c which uses memcpy_fromiovec. This patch fixes this build

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote: > On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote: > > scsi.c includes vhost.c which uses memcpy_fromiovec. > > > > This patch fixes this build failure. > > > >From Randy Du

[PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
Reported-by: Randy Dunlap Signed-off-by: Asias He --- drivers/vhost/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 8b9226d..0403323 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kconfig @@ -12,7 +12,7 @@ config

[PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
-by: Randy Dunlap rdun...@infradead.org Signed-off-by: Asias He as...@redhat.com --- drivers/vhost/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/vhost/Kconfig b/drivers/vhost/Kconfig index 8b9226d..0403323 100644 --- a/drivers/vhost/Kconfig +++ b/drivers/vhost/Kconfig

Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec

2013-05-14 Thread Asias He
On Tue, May 14, 2013 at 08:10:20PM -0700, Nicholas A. Bellinger wrote: On Wed, 2013-05-15 at 08:59 +0800, Asias He wrote: scsi.c includes vhost.c which uses memcpy_fromiovec. This patch fixes this build failure. From Randy Dunlap: ''' on x86_64: ERROR

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: > There's no net specific code in vhost.c anymore, > don't include the virtio_net.h header. Did you push the it to your tree. I am not seeing it. > Signed-off-by: Michael S. Tsirkin > --- > > This is on top of Asias' patches,

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: > There's no net specific code in vhost.c anymore, > don't include the virtio_net.h header. > > Signed-off-by: Michael S. Tsirkin Reviewed-by: Asias He > --- > > This is on top of Asias' patches, already

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: There's no net specific code in vhost.c anymore, don't include the virtio_net.h header. Did you push the it to your tree. I am not seeing it. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- This is on top of Asias'

Re: [PATCH] vhost: drop virtio_net.h dependency

2013-05-06 Thread Asias He
On Mon, May 06, 2013 at 01:37:34PM +0300, Michael S. Tsirkin wrote: There's no net specific code in vhost.c anymore, don't include the virtio_net.h header. Signed-off-by: Michael S. Tsirkin m...@redhat.com Reviewed-by: Asias He as...@redhat.com --- This is on top of Asias' patches

Re: [PATCH 0/3] vhost-scsi: file renames

2013-05-01 Thread Asias He
Tsirkin Reviewed-by: Asias He > > Michael S. Tsirkin (3): > vhost: src file renames > tcm_vhost: header split up > vhost_scsi: module rename > > drivers/vhost/Kconfig | 10 ++- > drivers/vhost/Kconfig.tcm | 6 -- > drivers/vhos

Re: [PATCH 0/3] vhost-scsi: file renames

2013-05-01 Thread Asias He
Reviewed-by: Asias He as...@redhat.com Michael S. Tsirkin (3): vhost: src file renames tcm_vhost: header split up vhost_scsi: module rename drivers/vhost/Kconfig | 10 ++- drivers/vhost/Kconfig.tcm | 6 -- drivers/vhost/Makefile| 3

[PATCH] VSOCK: Fix misc device registration

2013-04-24 Thread Asias He
to MISC_DYNAMIC_MINOR before we register. Cc: "David S. Miller" Cc: Andy King Cc: Dmitry Torokhov Cc: Reilly Grant Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Asias He --- net/vmw_vsock/af_vsock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] VSOCK: Fix misc device registration

2013-04-24 Thread Asias He
to MISC_DYNAMIC_MINOR before we register. Cc: David S. Miller da...@davemloft.net Cc: Andy King ack...@vmware.com Cc: Dmitry Torokhov d...@vmware.com Cc: Reilly Grant gra...@vmware.com Cc: net...@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Asias He as...@redhat.com --- net

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-06 Thread Asias He
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote: > On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: > > On 03/28/2013 10:22 AM, Wanlong Gao wrote: > > > On 03/23/2013 07:28 PM, Wanlong Gao wrote: > > >> This series implements virtio-scsi queue steering, which gives > > >>

Re: [PATCH V7 0/5] virtio-scsi multiqueue

2013-04-06 Thread Asias He
On Sat, Apr 06, 2013 at 09:40:13AM +0100, James Bottomley wrote: On Fri, 2013-04-05 at 16:55 +0800, Wanlong Gao wrote: On 03/28/2013 10:22 AM, Wanlong Gao wrote: On 03/23/2013 07:28 PM, Wanlong Gao wrote: This series implements virtio-scsi queue steering, which gives performance

Re: [PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Asias He
nd no need to pass in the maximum target size as a parameter because > everything should now happen dynamically. > > Cc: James Bottomley > Cc: linux-s...@vger.kernel.org > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong Gao Reviewed-by:

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Asias He
On Wed, Mar 20, 2013 at 03:01:24PM +0800, Wanlong Gao wrote: > Add hot cpu notifier to reset the request virtqueue affinity > when doing cpu hotplug. > > Cc: linux-s...@vger.kernel.org > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong Gao > Reviewed-by: Asias He

Re: [PATCH V6 5/5] virtio-scsi: reset virtqueue affinity when doing cpu hotplug

2013-03-20 Thread Asias He
-by: Asias He as...@redhat.com --- drivers/scsi/virtio_scsi.c | 29 + 1 file changed, 29 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 13d7672..0ad9017 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi

Re: [PATCH V6 1/5] virtio-scsi: redo allocation of target data

2013-03-20 Thread Asias He
as a parameter because everything should now happen dynamically. Cc: James Bottomley james.bottom...@hansenpartnership.com Cc: linux-s...@vger.kernel.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com

Re: [PATCH V4 0/5] virtio-scsi multiqueue

2013-03-19 Thread Asias He
vq lock/unlock into virtscsi_vq_done > virtio-scsi: introduce multiqueue support > > Wanlong Gao (1): > virtio-scsi: reset virtqueue affinity when doing cpu hotplug > > drivers/scsi/virtio_scsi.c | 364 > - > 1 file changed, 2

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-19 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote: > From: Paolo Bonzini > > virtio_scsi_target_state is now empty, but we will find new uses > for it in the next few patches. However, dropping the sglist lets > us turn the array-of-pointers into a simple array, which simplifies > the

Re: [PATCH V4 1/5] virtio-scsi: redo allocation of target data

2013-03-19 Thread Asias He
On Mon, Mar 11, 2013 at 10:43:58AM +0800, Wanlong Gao wrote: From: Paolo Bonzini pbonz...@redhat.com virtio_scsi_target_state is now empty, but we will find new uses for it in the next few patches. However, dropping the sglist lets us turn the array-of-pointers into a simple array, which

Re: [PATCH V4 0/5] virtio-scsi multiqueue

2013-03-19 Thread Asias He
Wanlong Gao (1): virtio-scsi: reset virtqueue affinity when doing cpu hotplug drivers/scsi/virtio_scsi.c | 364 - 1 file changed, 291 insertions(+), 73 deletions(-) -- 1.8.2.rc2 Patch 2-5 Reviewed-by: Asias He as...@redhat.com -- Asias

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Asias He
On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: > On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: > > On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote: > > > On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: > > > > On

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-18 Thread Asias He
On Mon, Mar 18, 2013 at 11:30:47PM +, Ben Hutchings wrote: On Mon, 2013-03-18 at 14:00 -0700, Nicholas A. Bellinger wrote: On Mon, 2013-03-18 at 13:35 +0800, Asias He wrote: On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-17 Thread Asias He
On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: > On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: > > 3.0-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > >

Re: [ 04/21] target/pscsi: Fix page increment

2013-03-17 Thread Asias He
On Sat, Mar 16, 2013 at 02:10:22AM +, Ben Hutchings wrote: On Tue, 2013-03-12 at 15:44 -0700, Greg Kroah-Hartman wrote: 3.0-stable review patch. If anyone has any objections, please let me know. -- From: Asias He as...@redhat.com commit

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Asias He
isk(vblk->disk); >>> + kobject_uevent_env(_to_dev(vblk->disk)->kobj, KOBJ_CHANGE, envp); >>> done: >>> mutex_unlock(>config_lock); >>> } >>> >> >> I tried the following with your automatically resize udev rules. >> &

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Asias He
into it again. It works for me now and the udev event is seen. Tested-by: Asias He as...@redhat.com [root@host ~]# lvresize -f -L +100M /dev/vgguests/evd2 \ virsh blockresize resize vdb 1 \ lvresize -f -L +100M /dev/vgguests/evd2 \ virsh blockresize resize vdb 1 Rounding size to boundary between

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-24 Thread Asias He
On 02/22/2013 03:02 AM, Milos Vyletel wrote: > When virtio-blk device is resized from host (using block_resize from QEMU) > emit > KOBJ_CHANGE uevent to notify guest about such change. This allows user to have > custom udev rules which would take whatever action if such event occurs. As a > proof

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-24 Thread Asias He
On 02/22/2013 03:02 AM, Milos Vyletel wrote: When virtio-blk device is resized from host (using block_resize from QEMU) emit KOBJ_CHANGE uevent to notify guest about such change. This allows user to have custom udev rules which would take whatever action if such event occurs. As a proof of

Re: [PATCH 17/16 V2] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
ed-off-by: Wanlong Gao Reviewed-by: Asias He > --- > V1->V2: > add the lost comments (Asias) > > drivers/scsi/virtio_scsi.c | 91 > +- > 1 file changed, 34 insertions(+), 57 deletions(-) > > diff --git a/drivers

Re: [PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
On 02/20/2013 04:37 PM, Wanlong Gao wrote: > Using the new virtqueue_add_sgs function lets us simplify the queueing > path. In particular, all data protected by the tgt_lock is just gone > (multiqueue will find a new use for the lock). > > Signed-off-by: Paolo Bonzini > Signed-off-by: Wanlong

Re: [PATCH 06/16] virtio_blk: remove nents member.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: > It's simply a flag as to whether we have data now, so make it an > explicit function parameter rather than a member of struct > virtblk_req. > > Signed-off-by: Rusty Russell Reviewed-by: Asias He > --- > drivers/bloc

Re: [PATCH 05/16] virtio-blk: use virtqueue_add_sgs on req path

2013-02-20 Thread Asias He
i > Signed-off-by: Rusty Russell Reviewed-by: Asias He > --- > drivers/block/virtio_blk.c | 69 > +--- > 1 file changed, 33 insertions(+), 36 deletions(-) > > diff --git a/drivers/block/virtio_blk.c b/drivers/block/

Re: [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

2013-02-20 Thread Asias He
- if (bio->bi_rw & REQ_WRITE) { > + vbr->nents = blk_bio_map_sg(vblk->disk->queue, bio, vbr->sg); > + if (vbr->nents) { > + if (bio->bi_rw & REQ_WRITE) > vbr->out_hdr.type |= VIRTIO_BLK_T_OUT; > -

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: > virtio_scsi can really use this, to avoid the current hack of copying > the whole sg array. Some other things get slightly neater, too. > > Signed-off-by: Rusty Russell This simpler API makes more sense to me. Reviewed-

Re: [PATCH 02/16] virtio_ring: virtqueue_add_sgs, to add multiple sgs.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: virtio_scsi can really use this, to avoid the current hack of copying the whole sg array. Some other things get slightly neater, too. Signed-off-by: Rusty Russell ru...@rustcorp.com.au This simpler API makes more sense to me. Reviewed-by: Asias

Re: [PATCH 04/16] virtio-blk: use virtqueue_start_buf on bio path

2013-02-20 Thread Asias He
(struct work_struct *work) Reviewed-by: Asias He as...@redhat.com -- Asias -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 05/16] virtio-blk: use virtqueue_add_sgs on req path

2013-02-20 Thread Asias He
-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Asias He as...@redhat.com --- drivers/block/virtio_blk.c | 69 +--- 1 file changed, 33 insertions(+), 36 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index

Re: [PATCH 06/16] virtio_blk: remove nents member.

2013-02-20 Thread Asias He
On 02/19/2013 03:56 PM, Rusty Russell wrote: It's simply a flag as to whether we have data now, so make it an explicit function parameter rather than a member of struct virtblk_req. Signed-off-by: Rusty Russell ru...@rustcorp.com.au Reviewed-by: Asias He as...@redhat.com --- drivers

Re: [PATCH 17/16] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
On 02/20/2013 04:37 PM, Wanlong Gao wrote: Using the new virtqueue_add_sgs function lets us simplify the queueing path. In particular, all data protected by the tgt_lock is just gone (multiqueue will find a new use for the lock). Signed-off-by: Paolo Bonzini pbonz...@redhat.com

Re: [PATCH 17/16 V2] virtio-scsi: use virtqueue_add_sgs for command buffers

2013-02-20 Thread Asias He
-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Asias He as...@redhat.com --- V1-V2: add the lost comments (Asias) drivers/scsi/virtio_scsi.c | 91 +- 1 file changed, 34 insertions(+), 57 deletions(-) diff --git a/drivers/scsi

Re: [PATCH 3/9] virtio-blk: use virtqueue_start_buf on bio path

2013-02-16 Thread Asias He
rtqueue buffers. > > With this change, virtio-blk (with use_bio) is not relying anymore on > the virtio functions ignoring the end markers in a scatterlist. > The next patch will do the same for the other path. > > Signed-off-by: Paolo Bonzini Reviewed-by: Asias He > ---

Re: [PATCH 2/9] virtio-blk: reorganize virtblk_add_req

2013-02-16 Thread Asias He
gic directly in virtblk_add_req. > > Signed-off-by: Paolo Bonzini Reviewed-by: Asias He > --- > drivers/block/virtio_blk.c | 55 > > 1 files changed, 20 insertions(+), 35 deletions(-) > > diff --git a/drivers/block/virtio_blk.c

Re: [PATCH 4/9] virtio-blk: use virtqueue_start_buf on req path

2013-02-16 Thread Asias He
On 02/12/2013 08:23 PM, Paolo Bonzini wrote: > This is similar to the previous patch, but a bit more radical > because the bio and req paths now share the buffer construction > code. Because the req path doesn't use vbr->sg, however, we > need to add a couple of arguments to __virtblk_add_req. >

Re: [PATCH 4/9] virtio-blk: use virtqueue_start_buf on req path

2013-02-16 Thread Asias He
On 02/12/2013 08:23 PM, Paolo Bonzini wrote: This is similar to the previous patch, but a bit more radical because the bio and req paths now share the buffer construction code. Because the req path doesn't use vbr-sg, however, we need to add a couple of arguments to __virtblk_add_req. We

Re: [PATCH 2/9] virtio-blk: reorganize virtblk_add_req

2013-02-16 Thread Asias He
in virtblk_add_req. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Asias He as...@redhat.com --- drivers/block/virtio_blk.c | 55 1 files changed, 20 insertions(+), 35 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block

Re: [PATCH 3/9] virtio-blk: use virtqueue_start_buf on bio path

2013-02-16 Thread Asias He
, virtio-blk (with use_bio) is not relying anymore on the virtio functions ignoring the end markers in a scatterlist. The next patch will do the same for the other path. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Asias He as...@redhat.com --- drivers/block/virtio_blk.c | 74

Re: [PATCH] vhost-blk: Add vhost-blk support v6

2012-12-06 Thread Asias He
On 12/06/2012 09:00 PM, Michael S. Tsirkin wrote: > On Sun, Dec 02, 2012 at 09:33:53AM +0800, Asias He wrote: >> diff --git a/drivers/vhost/Kconfig.blk b/drivers/vhost/Kconfig.blk >> new file mode 100644 >> index 000..ff8ab76 >> --- /dev/null >> +++ b/drivers/v

Re: [PATCH] vhost-blk: Add vhost-blk support v6

2012-12-06 Thread Asias He
On 12/06/2012 09:00 PM, Michael S. Tsirkin wrote: On Sun, Dec 02, 2012 at 09:33:53AM +0800, Asias He wrote: diff --git a/drivers/vhost/Kconfig.blk b/drivers/vhost/Kconfig.blk new file mode 100644 index 000..ff8ab76 --- /dev/null +++ b/drivers/vhost/Kconfig.blk @@ -0,0 +1,10 @@ +config

[PATCH] vhost-blk: Add vhost-blk support v6

2012-12-01 Thread Asias He
bio instead of vfs_fsync, thanks Christoph! - Check file passed by user is a raw block device file Acked-by: David S. Miller Signed-off-by: Asias He --- drivers/vhost/Kconfig | 1 + drivers/vhost/Kconfig.blk | 10 + drivers/vhost/Makefile| 2 + drivers/vhost/blk.c |

[PATCH] vhost-blk: Add vhost-blk support v6

2012-12-01 Thread Asias He
instead of vfs_fsync, thanks Christoph! - Check file passed by user is a raw block device file Acked-by: David S. Miller da...@davemloft.net Signed-off-by: Asias He as...@redhat.com --- drivers/vhost/Kconfig | 1 + drivers/vhost/Kconfig.blk | 10 + drivers/vhost/Makefile| 2 + drivers

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-22 Thread Asias He
On 11/21/2012 07:57 PM, Michael S. Tsirkin wrote: > On Wed, Nov 21, 2012 at 12:24:55PM +0800, Asias He wrote: >> On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: >>> On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: >>>> On 11/20/2012 04:26 AM, Michael S. Ts

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-22 Thread Asias He
On 11/21/2012 07:57 PM, Michael S. Tsirkin wrote: On Wed, Nov 21, 2012 at 12:24:55PM +0800, Asias He wrote: On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: On Mon, Nov 19, 2012 at 04

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-20 Thread Asias He
On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: > On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: >> On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: >>> On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: >>>> vhost-blk is an in-kernel

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-20 Thread Asias He
On 11/20/2012 09:37 PM, Michael S. Tsirkin wrote: On Tue, Nov 20, 2012 at 02:39:40PM +0800, Asias He wrote: On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: vhost-blk is an in-kernel virito-blk device accelerator. Due to lack

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-19 Thread Asias He
On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: > On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: >> vhost-blk is an in-kernel virito-blk device accelerator. >> >> Due to lack of proper in-kernel AIO interface, this version converts >> guest's I/O reques

Re: [PATCH] vhost-blk: Add vhost-blk support v5

2012-11-19 Thread Asias He
On 11/20/2012 04:26 AM, Michael S. Tsirkin wrote: On Mon, Nov 19, 2012 at 04:53:42PM +0800, Asias He wrote: vhost-blk is an in-kernel virito-blk device accelerator. Due to lack of proper in-kernel AIO interface, this version converts guest's I/O request to bio and use submit_bio() to submit I

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Asias He
er.kernel.org > drivers/scsi/virtio_scsi.c | 43 +++ > 1 file changed, 23 insertions(+), 20 deletions(-) > > -- > 1.8.0 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message t

Re: [PATCH 0/5] virtio-scsi: create a separate workqueue

2012-11-07 Thread Asias He
+++ 1 file changed, 23 insertions(+), 20 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Asias He

Re: [BUG] lkvm crash on crashkernel boot

2012-10-27 Thread Asias He
> added it to my workqueue (unless someone deals with it first). > > Any reason I shouldn't apply Kirill's patch before someone find the time > to do that? Please apply it. -- Asias He -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [BUG] lkvm crash on crashkernel boot

2012-10-27 Thread Asias He
(unless someone deals with it first). Any reason I shouldn't apply Kirill's patch before someone find the time to do that? Please apply it. -- Asias He -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo

Re: [GIT PULL] Linux KVM tool for v3.7-rc0

2012-10-22 Thread Asias He
s we discussed replacing SLIRP with lkvm code for > userspace networking and decided (for reasons I do not remember) that it > lacks futures SLIRP has. Was it host port redirection? Yes. Currently, there is no host to guest port forward support in lkvm. However, it's faster than slirp. e.g. tcp band

Re: [GIT PULL] Linux KVM tool for v3.7-rc0

2012-10-22 Thread Asias He
. Currently, there is no host to guest port forward support in lkvm. However, it's faster than slirp. e.g. tcp bandwidth in a 100Mb/s environment lkvm's userspace networking ~90Mb/s v.s qemu's slirp ~10Mb/s -- Asias He -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [ 84/95] virtio_blk: fix config handler race

2012-09-09 Thread Asias He
On 09/10/2012 10:26 AM, Rusty Russell wrote: > Ben Hutchings writes: > >> 3.2-stable review patch. If anyone has any objections, please let me know. >> >> -- >> >> From: "Michael S. Tsirkin" >> >> commit 4678d6f970c2f7c0cbfefc0cc666432d153b321b upstream. >> >> Fix a theoretical

Re: [ 84/95] virtio_blk: fix config handler race

2012-09-09 Thread Asias He
On 09/10/2012 10:26 AM, Rusty Russell wrote: Ben Hutchings b...@decadent.org.uk writes: 3.2-stable review patch. If anyone has any objections, please let me know. -- From: Michael S. Tsirkin m...@redhat.com commit 4678d6f970c2f7c0cbfefc0cc666432d153b321b upstream. Fix

  1   2   3   >