forward MSC_TIMESTAMP")
Signed-off-by: Ben Chan
---
drivers/hid/hid-multitouch.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index dad2fbb0e3f8..161551aab496 100644
--- a/drivers/hid/hid-multitouch.c
+++
forward MSC_TIMESTAMP")
Signed-off-by: Ben Chan
---
drivers/hid/hid-multitouch.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index dad2fbb0e3f8..161551aab496 100644
--- a/drivers/hid/hid-multitouch.c
+++
From: Kroderia
Delete a useless white space line according to the coding style.
Signed-off-by: Ben Chan
---
drivers/staging/skein/skein_generic.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c
b/drivers/staging/skein/skein_generic.c
index 85bd7d0
From: Kroderia krode...@gmail.com
Delete a useless white space line according to the coding style.
Signed-off-by: Ben Chan krode...@gmail.com
---
drivers/staging/skein/skein_generic.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/skein/skein_generic.c
b/drivers/staging
The descriptions are provided by GCT Semiconductor, Inc.
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/Kconfig | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index dd8a391..5836503
The descriptions are provided by GCT Semiconductor, Inc.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/Kconfig | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas wrote:
> Signed-off-by: Michalis Pappas
> ---
> drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
> drivers/staging/gdm72xx/hci.h | 6 ++
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git
annotations.
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_qos.c | 4 +--
drivers/staging/gdm72xx/gdm_sdio.c | 5 +--
drivers/staging/gdm72xx/gdm_usb.c | 12 +++
drivers/staging/gdm72xx/gdm_wimax.c | 64 +++--
drivers/staging/gdm72xx/gdm_wimax.h | 10
annotations.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_qos.c | 4 +--
drivers/staging/gdm72xx/gdm_sdio.c | 5 +--
drivers/staging/gdm72xx/gdm_usb.c | 12 +++
drivers/staging/gdm72xx/gdm_wimax.c | 64 +++--
drivers/staging
On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas mpap...@fastmail.fm wrote:
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 7 deletions(-)
diff
Signed-off-by: Ben Chan
---
I forgot to add the Signed-off-by stanza in the original patch.
drivers/staging/gdm72xx/gdm_qos.h | 6 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 6 +++---
drivers/staging/gdm72xx/gdm_usb.h | 6 +++---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers
---
drivers/staging/gdm72xx/gdm_qos.h | 6 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 6 +++---
drivers/staging/gdm72xx/gdm_usb.h | 6 +++---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/hci.h | 6 +++---
drivers/staging/gdm72xx/netlink_k.h | 7 ---
---
drivers/staging/gdm72xx/gdm_qos.h | 6 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 6 +++---
drivers/staging/gdm72xx/gdm_usb.h | 6 +++---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/hci.h | 6 +++---
drivers/staging/gdm72xx/netlink_k.h | 7 ---
Signed-off-by: Ben Chan benc...@chromium.org
---
I forgot to add the Signed-off-by stanza in the original patch.
drivers/staging/gdm72xx/gdm_qos.h | 6 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 6 +++---
drivers/staging/gdm72xx/gdm_usb.h | 6 +++---
drivers/staging/gdm72xx/gdm_wimax.h | 6
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_qos.c | 38 +++---
drivers/staging/gdm72xx/gdm_qos.h | 2 +-
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index
This patch addresses the following issues:
- Use int instead of u32 whenever makes sense
- Turn extract_qos_list() in gdm_qos.c, which previously always returned
0, into a void function.
Reported-by: Dan Carpenter
Reported-by: Michalis Pappas
Signed-off-by: Ben Chan
---
drivers/staging
This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead
of calling BUG_ON if an invalid data length is passed to the functions.
Reported-by: Dan Carpenter
Reported-by: Michalis Pappas
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_sdio.c | 3 ++-
drivers
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_qos.c | 10 +-
drivers/staging/gdm72xx/gdm_qos.h | 4 +---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index df6f000..732f009 100644
-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_qos.c | 15 +++
drivers/staging/gdm72xx/gdm_qos.h | 6 +++---
2 files changed, 10 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 732f009
This patch changes gdm_usb_send() and gdm_sdio_send() to return -EINVAL instead
of calling BUG_ON if an invalid data length is passed to the functions.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Reported-by: Michalis Pappas mpap...@fastmail.fm
Signed-off-by: Ben Chan benc...@chromium.org
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_qos.c | 10 +-
drivers/staging/gdm72xx/gdm_qos.h | 4 +---
2 files changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index df6f000
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_qos.c | 38 +++---
drivers/staging/gdm72xx/gdm_qos.h | 2 +-
2 files changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_wimax.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index e5e5115..3081fd4 100644
--- a/drivers/staging/gdm72xx/gdm_wimax.c
+++ b
This patch implements the stack protector code in MIPS compressed boot
phase based on the same code added to arm in commit
8779657d29c0ebcc0c94ede4df2f497baf1b563f "stackprotector: Introduce
CONFIG_CC_STACKPROTECTOR_STRONG" by Kees Cook
Signed-off-by: Ben Chan
Cc: Kees Cook
Cc: Olof
WARNING: networking block comments put the trailing */ on a separate line
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_sdio.c | 7 ++-
drivers/staging/gdm72xx/gdm_usb.c | 6 ++
drivers/staging/gdm72xx/gdm_wimax.c | 5 +++--
drivers/staging/gdm72xx/hci.h | 4 +---
4
This patch fixes the following checkpatch warning:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers/staging/gdm72xx
This patch fixes the following checkpatch warning:
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_usb.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers
WARNING: networking block comments put the trailing */ on a separate line
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_sdio.c | 7 ++-
drivers/staging/gdm72xx/gdm_usb.c | 6 ++
drivers/staging/gdm72xx/gdm_wimax.c | 5 +++--
drivers/staging/gdm72xx/hci.h
This patch implements the stack protector code in MIPS compressed boot
phase based on the same code added to arm in commit
8779657d29c0ebcc0c94ede4df2f497baf1b563f stackprotector: Introduce
CONFIG_CC_STACKPROTECTOR_STRONG by Kees Cook keesc...@chromium.org
Signed-off-by: Ben Chan benc
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_wimax.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index e5e5115..3081fd4 100644
--- a/drivers/staging/gdm72xx
h modifies cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan
---
drivers/net/usb/cdc_ncm.c | 17 +
include
patch 1/2 as suggested by
David Miller
v4: No code changes. Resubmitted as suggested by David Miller:
- Added a summary of the patch set
- Carried the ACK from Greg Kroah-Hartman
- Added a specified the tree (net-next) to apply the patch set to
Ben Chan (2):
USB: cdc: add MBI
This patch adds the MBIM extended functional descriptor structure
defined in "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF.
Signed-off-by: Ben Chan
Acked-by: Greg Kroah-Hartman
--
This patch adds the MBIM extended functional descriptor structure
defined in Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1 published by USB-IF.
Signed-off-by: Ben Chan benc...@chromium.org
Acked-by: Greg Kroah-Hartman
set to
Ben Chan (2):
USB: cdc: add MBIM extended functional descriptor structure
net: cdc_ncm: respect operator preferred MTU reported by MBIM
drivers/net/usb/cdc_ncm.c| 17 +
include/linux/usb/cdc_ncm.h | 1 +
include/uapi/linux/usb/cdc.h | 12
3 files
cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/net/usb/cdc_ncm.c | 17
On Mon, Mar 17, 2014 at 6:41 PM, David Miller wrote:
> From: Ben Chan
> Date: Mon, 17 Mar 2014 17:46:27 -0700
>
>> Thanks again for the review and tip. I've submitted patch v2 to
>> address the le16_to_cpu conversion.
>
> When you update a patch from a series, y
This patch adds the MBIM extended functional descriptor structure
defined in "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF.
Signed-off-by: Ben Chan
---
No changes from patch v1.
in
h modifies cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan
---
Patch v3 (which is same as v2) adds the le16_to_cpu convers
On Mon, Mar 17, 2014 at 2:27 PM, Bjørn Mork wrote:
>
> This sounds all reasonable to me. Thanks for taking the time to explain
> it in such detail. I did know that some vendors set wMaxSegmentSize too
> low, but had no idea that vendors were using the extended descriptor
> instead of
h modifies cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan
---
Patch v2 adds the le16_to_cpu conversion on ctx->mbim_extend
On Mon, Mar 17, 2014 at 2:42 AM, Bjørn Mork wrote:
> Is this *really* driver material, or should we just leave the IP MTU
> hint handling up to the userspace management application?
>
> There are no less than 3(!) different ways for a device to specify the
> MBIM MTU:
>
> 1) wMaxSegmentSize
On Mon, Mar 17, 2014 at 2:42 AM, Bjørn Mork bj...@mork.no wrote:
Is this *really* driver material, or should we just leave the IP MTU
hint handling up to the userspace management application?
There are no less than 3(!) different ways for a device to specify the
MBIM MTU:
1)
cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan benc...@chromium.org
---
Patch v2 adds the le16_to_cpu conversion on ctx
On Mon, Mar 17, 2014 at 2:27 PM, Bjørn Mork bj...@mork.no wrote:
This sounds all reasonable to me. Thanks for taking the time to explain
it in such detail. I did know that some vendors set wMaxSegmentSize too
low, but had no idea that vendors were using the extended descriptor
instead of
This patch adds the MBIM extended functional descriptor structure
defined in Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1 published by USB-IF.
Signed-off-by: Ben Chan benc...@chromium.org
---
No changes from patch v1
cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan benc...@chromium.org
---
Patch v3 (which is same as v2) adds the le16_to_cpu
On Mon, Mar 17, 2014 at 6:41 PM, David Miller da...@davemloft.net wrote:
From: Ben Chan benc...@chromium.org
Date: Mon, 17 Mar 2014 17:46:27 -0700
Thanks again for the review and tip. I've submitted patch v2 to
address the le16_to_cpu conversion.
When you update a patch from a series, you
This patch adds the MBIM extended functional descriptor structure
defined in "Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1" published by USB-IF.
Signed-off-by: Ben Chan
---
include/uapi/linux/usb/
h modifies cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan
---
drivers/net/usb/cdc_ncm.c | 15 +++
include
cdc_ncm_setup to ensure that the MTU value set on
the usbnet device does not exceed the operator preferred MTU indicated
by wMTU if the MBIM device exposes a MBIM extended functional
descriptor.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/net/usb/cdc_ncm.c | 15
This patch adds the MBIM extended functional descriptor structure
defined in Universal Serial Bus Communications Class Subclass
Specification for Mobile Broadband Interface Model, Revision 1.0,
Errata-1 published by USB-IF.
Signed-off-by: Ben Chan benc...@chromium.org
---
include/uapi/linux/usb
Signed-off-by: Ben Chan
Cc: Sage Ahn
---
drivers/staging/gdm72xx/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index dd47bd1..dd8a391 100644
--- a/drivers/staging/gdm72xx/Kconfig
+++ b/drivers
interface, either USB or MMC, is built as a module. This patch enforces
that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency.
Reported-by: Alan Stern
Signed-off-by: Ben Chan
Cc: Sage Ahn
---
drivers/staging/gdm72xx/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
No worries. I've attached a revised patch to the original email
thread, which includes Alan.
Thanks again,
Ben
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Nope... I didn't resend the patch but replied to the thread.
Ben
On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan wrote:
> Sorry, I meant to send the revised patch but got the wrong file.
>
> I'll add the Reported-by field.
>
> Thanks,
> Ben
>
--
To unsubscribe from thi
Sorry, I meant to send the revised patch but got the wrong file.
I'll add the Reported-by field.
Thanks,
Ben
On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman
wrote:
> On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
>> The gdm72xx driver needs to have either the US
The gdm72xx driver needs to have either the USB or SDIO implementation
enabled to provide useful functionalities, so the driver should depend
on either USB or MMC.
Signed-off-by: Ben Chan
Cc: Sage Ahn
---
drivers/staging/gdm72xx/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion
No worries. I've attached a revised patch to the original email
thread, which includes Alan.
Thanks again,
Ben
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Signed-off-by: Ben Chan benc...@chromium.org
Cc: Sage Ahn sy...@gctsemi.com
---
drivers/staging/gdm72xx/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/Kconfig b/drivers/staging/gdm72xx/Kconfig
index dd47bd1..dd8a391 100644
--- a/drivers
interface, either USB or MMC, is built as a module. This patch enforces
that in the WIMAX_GDM72XX_USB and WIMAX_GDM72XX_SDIO dependency.
Reported-by: Alan Stern st...@rowland.harvard.edu
Signed-off-by: Ben Chan benc...@chromium.org
Cc: Sage Ahn sy...@gctsemi.com
---
drivers/staging/gdm72xx/Kconfig | 6
The gdm72xx driver needs to have either the USB or SDIO implementation
enabled to provide useful functionalities, so the driver should depend
on either USB or MMC.
Signed-off-by: Ben Chan benc...@chromium.org
Cc: Sage Ahn sy...@gctsemi.com
---
drivers/staging/gdm72xx/Kconfig | 2 +-
1 file
Sorry, I meant to send the revised patch but got the wrong file.
I'll add the Reported-by field.
Thanks,
Ben
On Mon, Jun 3, 2013 at 10:48 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Mon, Jun 03, 2013 at 10:23:45AM -0700, Ben Chan wrote:
The gdm72xx driver needs to have either
Nope... I didn't resend the patch but replied to the thread.
Ben
On Mon, Jun 3, 2013 at 11:18 AM, Ben Chan benc...@chromium.org wrote:
Sorry, I meant to send the revised patch but got the wrong file.
I'll add the Reported-by field.
Thanks,
Ben
--
To unsubscribe from this list: send
This patch fixes an unused variable warning in gdm_usb_send
(when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in
commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging:
gdm72xx: protect access of rx / tx structs).
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_usb.c |5
This patch fixes an unused variable warning in gdm_usb_send
(when CONFIG_WIMAX_GDM72XX_K_MODE=n), which was introduced in
commit 1a276b80466bbd195cf94ec7178f68f2ab351467 (staging:
gdm72xx: protect access of rx / tx structs).
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging
om [<8004a43c>]
(kthread+0x9c/0xa8)
<5>[ 4996.815270] [<8004a43c>] (kthread+0x9c/0xa8) from [<8000f160>]
(kernel_thread_exit+0x0/0x8)
<0>[ 4996.815295] Code: e92d4000 e8bd4000 e2800020 eb4ab9a1 (e5905000)
Signed-off-by: Ben Chan
Signed-off-by: Sameer Nanda
---
drivers/stag
(e5905000)
Signed-off-by: Ben Chan benc...@chromium.org
Signed-off-by: Sameer Nanda sna...@chromium.org
---
drivers/staging/gdm72xx/gdm_usb.c | 52 -
1 files changed, 45 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers/staging
FYI, a similar patch has already been applied: "staging: gdm72xx:
simplify alloc_tx_struct and alloc_rx_struct (commit
129575f2a8958a1e90780b0d5b80702bb45b5aac)"
Thanks,
Ben
On Mon, Sep 17, 2012 at 6:45 AM, Peter Senna Tschudin
wrote:
> Replace kmalloc+memset for kzalloc and cleanup related
FYI, a similar patch has already been applied: staging: gdm72xx:
simplify alloc_tx_struct and alloc_rx_struct (commit
129575f2a8958a1e90780b0d5b80702bb45b5aac)
Thanks,
Ben
On Mon, Sep 17, 2012 at 6:45 AM, Peter Senna Tschudin
peter.se...@gmail.com wrote:
Replace kmalloc+memset for kzalloc and
This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c
and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing
the code.
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_sdio.c | 30
drivers/staging/gdm72xx/gdm_usb.c | 44
This patch simplifies alloc_tx_struct and alloc_rx_struct in gdm_sdio.c
and gdm_usb.c by replacing kmalloc+memset with kzalloc and reorganizing
the code.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_sdio.c | 30
drivers/staging/gdm72xx
Hi Dan,
I manually walked through the driver code and spotted the issue. But
this morning I was able to get an extra module to verify my patch on
hardware.
I tested the following patterns using two identical modules, and
checked the creation/destruction/ref_cnt of wm_event:
- insert module A,
Hi Dan,
I manually walked through the driver code and spotted the issue. But
this morning I was able to get an extra module to verify my patch on
hardware.
I tested the following patterns using two identical modules, and
checked the creation/destruction/ref_cnt of wm_event:
- insert module A,
Hi,
Does patch v2 make sense?
Thanks,
Ben
On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan wrote:
> Hi Devendra,
>
> Thanks for cleaning up the driver. If I understand the code
> correctly, the original author wanted to initialize wm_event once and
> reuse it for multiple devices, and
Hi,
Does patch v2 make sense?
Thanks,
Ben
On Wed, Jul 25, 2012 at 6:53 AM, Ben Chan benc...@chromium.org wrote:
Hi Devendra,
Thanks for cleaning up the driver. If I understand the code
correctly, the original author wanted to initialize wm_event once and
reuse it for multiple devices
could be
disposed even when there is an active device).
Thanks,
Ben
On Tue, Jul 24, 2012 at 9:50 PM, devendra.aaru wrote:
> On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan wrote:
>> This patch fixes the commit "staging/gdm72xx: cleanup little at
>>
could be
disposed even when there is an active device).
Thanks,
Ben
On Tue, Jul 24, 2012 at 9:50 PM, devendra.aaru devendra.a...@gmail.com wrote:
On Tue, Jul 24, 2012 at 8:34 PM, Ben Chan benc...@chromium.org wrote:
This patch fixes the commit staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv
This patch fixes the commit "staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv" (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan
---
Fixed the commit message as suggested by Dan Carpenter.
drivers/stagi
This patch fixes the commit staging/gdm72xx: cleanup little at
gdm_wimax_event_rcv (8df858ea76b76dde9a39d4edd9aaded983582cfe),
which mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan benc...@chromium.org
---
Fixed the commit message as suggested by Dan Carpenter.
drivers
This patch fixes commit 8df858ea76b76dde9a39d4edd9aaded983582cfe, which
mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan
---
drivers/staging/gdm72xx/gdm_wimax.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/gdm72xx
This patch fixes commit 8df858ea76b76dde9a39d4edd9aaded983582cfe, which
mishandles the reference counting of wm_event.
Signed-off-by: Ben Chan benc...@chromium.org
---
drivers/staging/gdm72xx/gdm_wimax.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git
82 matches
Mail list logo
