Re: [PATCH] dt-bindings: net: mediatek: support MT7621 SoC

Ilya Lipnitskiy writes: > Add missing binding documentation for SoC support that has been in place > since v5.1 > > Fixes: 889bcbdeee57 ("net: ethernet: mediatek: support MT7621 SoC ethernet > hardware") > Cc: Bjørn Mork > Signed-off-by: Ilya Lipnitskiy &g

Re: [PATCH] MIPS: vmlinux.lds.S: Fix appended dtb not properly aligned

Paul Cercueil writes: > Commit 6654111c893f ("MIPS: vmlinux.lds.S: align raw appended dtb to 8 > bytes") changed the alignment from STRUCT_ALIGNMENT bytes to 8 bytes. Ouch. That was not my intention. I see that there was a mixup with my initial patch. My last version used STRUCT_ALIGNMENT,

Re: [PATCH net,stable] net: cdc_ncm: correct overhead in delayed_ndp_size

fixup this rather messy piece of code. Reviewed-by: Bjørn Mork

Re: [PATCH] net: usb: qmi_wwan: Set DTR quirk for MR400

05c6, 0x9026, 3)}, > {QMI_FIXED_INTF(0x05c6, 0x902e, 5)}, > {QMI_FIXED_INTF(0x05c6, 0x9031, 5)}, Acked-by: Bjørn Mork This fix should probably go to net+stable. Thanks, Bjørn

Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

Jakub Kicinski writes: > I'm guessing that I'm supposed to take this patch into the networking > tree, correct? Correct. > Is this net or net-next candidate? Bjørn? Sorry, should have made that explicit. This is for net + stable Thanks. Bjørn

Re: [PATCH v2 1/2] net: usb: qmi_wwan: add Cellient MPL200 card

MI_GOBI1K_DEVICE(0x05c6, 0x9212)},/* Acer Gobi Modem Device */ Thanks. Looks nice now. Acked-by: Bjørn Mork

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

Wilken Gottwalt writes: > Oh sorry, looks like I got it mixed up a bit. It was my first attempt to > submit > a patch set. Which is the best way to resubmit an update if the other part of > the patch set gets accepted? The documentation about re-/submitting patch sets > is a bit thin. I see

Re: [PATCH 1/2] usb: serial: qmi_wwan: add Cellient MPL200 card

Wilken Gottwalt writes: > Add usb ids of the Cellient MPL200 card. > > Signed-off-by: Wilken Gottwalt > --- > drivers/net/usb/qmi_wwan.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 07c42c0719f5..0bf2b19d5d54 100644 >

Re: [PATCH] net: usb: qmi_wwan: Fix for packets being rejected in the ring buffer used by the xHCI controller.

Kristian Evensen writes: > Hi all, > > I was able to trigger the same issue as reported by Paul, and came > across this patch (+ Daniele's other patch and thread on the libqmi > mailing list). Applying Paul's fix solved the problem for me, changing > the MTU of the QMI interface now works fine.

Re: [PATCH] net: cdc_ncm: Fix build error

YueHaibing writes: > If USB_NET_CDC_NCM is y and USB_NET_CDCETHER is m, build fails: > > drivers/net/usb/cdc_ncm.o:(.rodata+0x1d8): undefined reference to > `usbnet_cdc_update_filter' > > Select USB_NET_CDCETHER for USB_NET_CDC_NCM to fix this. Ouch. For some reason I assumed that was always

Re: [PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

TF(0x2c7c, 0x0296, 4)},/* Quectel BG96 */ > {QMI_QUIRK_SET_DTR(0x2cb7, 0x0104, 4)}, /* Fibocom NL678 series */ > {QMI_FIXED_INTF(0x0489, 0xe0b4, 0)},/* Foxconn T77W968 LTE */ Acked-by: Bjørn Mork

Re: [PATCH] net: usb: qmi_wwan: remove redundant assignment to variable status

Fixes for documentation only, not as a stable hint. This is cleanup only and not suitable for stable IMHO. Acked-by: Bjørn Mork Fixes: 8492ed45aa5d ("qmi-wwan: use common parser")

Re: [PATCH] net: usb: qmi_wwan: add support for DW5816e

,/* Dell Wireless 5821e */ > {QMI_FIXED_INTF(0x413c, 0x81d7, 1)},/* Dell Wireless 5821e > preproduction config */ > {QMI_FIXED_INTF(0x413c, 0x81e0, 0)},/* Dell Wireless 5821e with > eSIM support*/ Looks fine to me. Please add to the stable queue as well, Thanks. Acked-by: Bjørn Mork

Re: divide error in cdc_ncm_update_rxtx_max

syzbot writes: > syzbot has tested the proposed patch but the reproducer still > triggered crash: > divide error in usbnet_update_max_qlen > > cdc_ncm 5-1:1.0: setting tx_max = 16384 > divide error: [#1] SMP KASAN > CPU: 1 PID: 1737 Comm: kworker/1:2 Not tainted 5.3.0-rc7+ #0 > Hardware

Re: divide error in cdc_ncm_update_rxtx_max

nel/workqueue.c:2415 kthread+0x318/0x420 kernel/kthread.c:255 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 Modules linked in: ---[ end trace ab75cc10e099d8e9 ]--- Reported-by: syzbot+ce366e2b8296e25d8...@syzkaller.appspotmail.com Signed-off-by: Bjørn Mork --- drivers/net/usb/cdc_ncm.c

Re: KASAN: global-out-of-bounds Read in qmi_wwan_probe

Hillf Danton writes: > and wonder if the following works. > > - info = (void *)>driver_info; > + info = (void *)id->driver_info; Doh! Right you are. Thanks to both you and Andrey for quick and good help. We obviously have some bad code patterns here, since this apparently worked for

Re: KASAN: global-out-of-bounds Read in qmi_wwan_probe

syzbot writes: > Hello, > > syzbot found the following crash on: > > HEAD commit:9939f56e usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=1615a669a0 > kernel config:

Re: [PATCH] qmi_wwan: apply SET_DTR quirk to Sierra WP7607

like it's time to consider applying this unconditionally to all devices. Feel free to propose something like that the next time this issue comes up. Acked-by: Bjørn Mork

Re: [PATCH AUTOSEL 3.18 04/98] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem

Johan Hovold writes: > Note that the stable tag above lacks a version comment (e.g. "# 4.19"), > but I can see how that may be too subtle to convey this (and not all > maintainers use those). Perhaps an explicit comment should just be added > in such cases. I have always thought that the

Re: [PATCH AUTOSEL 3.18 04/98] USB: qcserial: Fix support for HP lt4112 LTE/HSPA+ Gobi 4G Modem

Johan Hovold writes: > Note that the stable tag above lacks a version comment (e.g. "# 4.19"), > but I can see how that may be too subtle to convey this (and not all > maintainers use those). Perhaps an explicit comment should just be added > in such cases. I have always thought that the

Re: [PATCH] net: qmi_wwan: Add Netgear Aircard 779S

Josh Hill <j...@joshuajhill.com> writes: > Add support for Netgear Aircard 779S > > Signed-off-by: Josh Hill <j...@joshuajhill.com> Acked-by: Bjørn Mork <bj...@mork.no> Please queue this for stable too. Thanks. Bjørn

Re: [PATCH] net: qmi_wwan: Add Netgear Aircard 779S

Josh Hill writes: > Add support for Netgear Aircard 779S > > Signed-off-by: Josh Hill Acked-by: Bjørn Mork Please queue this for stable too. Thanks. Bjørn

Re: [PATCH] USB: serial: option: adding support for ublox R410M

Johan Hovold writes: > On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote: >> On 4/26/2018 14:09, Johan Hovold wrote: >> > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: >> >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option >> >>

Re: [PATCH] USB: serial: option: adding support for ublox R410M

Johan Hovold writes: > On Thu, Apr 26, 2018 at 02:48:54PM +0700, Lars Melin wrote: >> On 4/26/2018 14:09, Johan Hovold wrote: >> > On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: >> >> This patch adds support for ublox R410M PID 0x90b2 USB modem to option >> >> driver, this module

Re: [PATCH] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2

"SZ Lin (林上智)" <sz@moxa.com> writes: > This patch adds support for PID 0x90b2 of ublox R410M. Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] NET: usb: qmi_wwan: add support for ublox R410M PID 0x90b2

"SZ Lin (林上智)" writes: > This patch adds support for PID 0x90b2 of ublox R410M. Acked-by: Bjørn Mork

Re: [PATCH] net: qmi_wwan: add Wistron Neweb D19Q1

or.) Sub=06 Prot=50 Driver=(none) > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us > > Tested on openwrt distribution > > Signed-off-by: Pawel Dembicki <paweldembi...@gmail.com> Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] net: qmi_wwan: add Wistron Neweb D19Q1

one) > E: Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms > E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=125us > > Tested on openwrt distribution > > Signed-off-by: Pawel Dembicki Acked-by: Bjørn Mork

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Bassem Boubaker writes: > +#define GEMALTO_VENDOR_ID0x1e2d This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. I have no idea which defintion is most correct, but I believe the macros should be kept identical whatever you decide. Anything else

Re: [PATCH] cdc_ether: flag the Cinterion PLS8 modem by gemalto as WWAN

Bassem Boubaker writes: > +#define GEMALTO_VENDOR_ID0x1e2d This is defined as CINTERION_VENDOR_ID in drivers/usb/serial/option.c. I have no idea which defintion is most correct, but I believe the macros should be kept identical whatever you decide. Anything else is just unnecessarily

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

{QMI_FIXED_INTF(0x05c6, 0x920d, 5)}, > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */ > {QMI_FIXED_INTF(0x0846, 0x68a2, 8)}, > {QMI_FIXED_INTF(0x12d1, 0x140c, 1)},/* Huawei E173 */ > {QMI_FIXED_INTF(0x12d1, 0x14ac, 1)},/* Huawei E1820 */ Perfect. Thanks Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH] NET: usb: qmi_wwan: add support for YUGA CLM920-NC5 PID 0x9625

, 5)}, > + {QMI_QUIRK_SET_DTR(0x05c6, 0x9625, 4)}, /* YUGA CLM920-NC5 */ > {QMI_FIXED_INTF(0x0846, 0x68a2, 8)}, > {QMI_FIXED_INTF(0x12d1, 0x140c, 1)},/* Huawei E173 */ > {QMI_FIXED_INTF(0x12d1, 0x14ac, 1)},/* Huawei E1820 */ Perfect. Thanks Acked-by: Bjørn Mork

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

"SZ Lin (林上智)" writes: >> Johan Hovold writes: >> >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; >> > >> > Do you really need to blacklist the first interface? >> >> Good

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

"SZ Lin (林上智)" writes: >> Johan Hovold writes: >> >> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> >> + .reserved = BIT(0) | BIT(1) | BIT(4), }; >> > >> > Do you really need to blacklist the first interface? >> >> Good question. Interface #0 does look a lot

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

Johan Hovold writes: >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> +.reserved = BIT(0) | BIT(1) | BIT(4), >> +}; > > Do you really need to blacklist the first interface? Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG

Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

Johan Hovold writes: >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = { >> +.reserved = BIT(0) | BIT(1) | BIT(4), >> +}; > > Do you really need to blacklist the first interface? Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based on

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

Telekom Speedstick LTE II > (Alcatel One Touch L100V LTE) */ > {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},/* Alcatel L800MA */ > {QMI_FIXED_INTF(0x2357, 0x0201, 4)},/* TP-LINK HSUPA Modem MA180 */ Looks good except for the duplicate 'From' line. Drop that and you can add Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH net,stable] net: qmi_wwan: add Sierra EM7565 1199:9091

100V LTE) */ > {QMI_FIXED_INTF(0x1bbb, 0x0203, 2)},/* Alcatel L800MA */ > {QMI_FIXED_INTF(0x2357, 0x0201, 4)},/* TP-LINK HSUPA Modem MA180 */ Looks good except for the duplicate 'From' line. Drop that and you can add Acked-by: Bjørn Mork

Re: [PATCH v6 01/11] intel_sgx: updated MAINTAINERS

Joe Perches writes: > On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -14932,6 +14932,11 @@ L: linux...@kvack.org >> S: Maintained >> F: mm/zswap.c >> >> +INTEL SGX >> +M: Jarkko Sakkinen

Re: [PATCH v6 01/11] intel_sgx: updated MAINTAINERS

Joe Perches writes: > On Sat, 2017-11-25 at 21:29 +0200, Jarkko Sakkinen wrote: >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -14932,6 +14932,11 @@ L: linux...@kvack.org >> S: Maintained >> F: mm/zswap.c >> >> +INTEL SGX >> +M: Jarkko Sakkinen >> +L:

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

e BG96. > > Signed-off-by: Sebastian Sjoholm <ssjoh...@mac.com> Perfect. Thanks. Acked-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

-off-by: Sebastian Sjoholm Perfect. Thanks. Acked-by: Bjørn Mork

Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

Shrirang Bagul writes: > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > series modems which will by default boot with vid 0x413c and pid's > 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support > qmi_wwan on the usb

Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

Shrirang Bagul writes: > Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 > series modems which will by default boot with vid 0x413c and pid's > 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support > qmi_wwan on the usb interface #12. NAK, Interace #12 is

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

On November 20, 2017 5:19:21 AM GMT+01:00, ssjoh...@mac.com wrote: >From: ssjoholm > >Signed-off-by: ssjoholm > >Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both >CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel >development

Re: [PATCH net,stable] net: qmi_wwan: add Quectel BG96 2c7c:0296

On November 20, 2017 5:19:21 AM GMT+01:00, ssjoh...@mac.com wrote: >From: ssjoholm > >Signed-off-by: ssjoholm > >Quectel BG96 is an Qualcomm MDM9206 based IoT modem, supporting both >CAT-M and NB-IoT. Tested hardware is BG96 mounted on Quectel >development board (EVB). >The USB id is added to

Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE

Marcel Holtmann writes: >> +{ USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK }, >> + > > I prefer to have /sys/kernel/debug/usb/devices for the device included in the > commit message. ...and 0x1185c is a typp Bjørn

Re: [PATCH] bluetooth: btusb: Add device ID for RTL8822BE

Marcel Holtmann writes: >> +{ USB_DEVICE(0x0b05, 0x1185c), .driver_info = BTUSB_REALTEK }, >> + > > I prefer to have /sys/kernel/debug/usb/devices for the device included in the > commit message. ...and 0x1185c is a typp Bjørn

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

ve > no MAC header and the interface is configured as-such, it seems certain > parts of the network stack expects a "good" value in skb->mac_header. Thanks. Yes, I see that the tun driver also does this. Acked-by: Bjørn Mork <bj...@mork.no> And his should probably go to stable

Re: [PATCH net] qmi_wwan: Add missing skb_reset_mac_header-call

e is configured as-such, it seems certain > parts of the network stack expects a "good" value in skb->mac_header. Thanks. Yes, I see that the tun driver also does this. Acked-by: Bjørn Mork And his should probably go to stable as well? with a Fixes: 32f7adf633b9 ("net: qmi_wwan: support "raw IP" mode")

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

Andrey Konovalov writes: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thanks. It would have helped a lot of you said *what* you were fuzzing, though But based on where the bug is, I assume it is USB descriptors? > On commit

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

Andrey Konovalov writes: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thanks. It would have helped a lot of you said *what* you were fuzzing, though But based on where the bug is, I assume it is USB descriptors? > On commit

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "...drop on through" > comments with a proper "fall through" comment on its

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "...drop on through" > comments with a proper "fall through" comment on its own line, which > is what

Re: [PATCH 00/10] staging/irda/net: Adjustments for several function implementations

Did you read drivers/staging/irda/TODO ? There is no need to answer that. You already have. Thanks a lot for your ever lasting invaluable contributions to /dev/null. Please continue. Bjørn

Re: [PATCH 00/10] staging/irda/net: Adjustments for several function implementations

Did you read drivers/staging/irda/TODO ? There is no need to answer that. You already have. Thanks a lot for your ever lasting invaluable contributions to /dev/null. Please continue. Bjørn

Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819

Shrirang Bagul writes: > On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote: > >> Don't you want to add these to qmi_wwan as well? > > I haven't tested these devices with qmi_wwan. Perhaps a separate patch once > it's > verified. Please do, if you can. I

Re: [PATCH] USB: serial: qcserial: add Dell DW5818, DW5819

Shrirang Bagul writes: > On Tue, 2017-10-03 at 15:37 +0200, Johan Hovold wrote: > >> Don't you want to add these to qmi_wwan as well? > > I haven't tested these devices with qmi_wwan. Perhaps a separate patch once > it's > verified. Please do, if you can. I realize that QMI isn't a default

Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

Douglas Anderson writes: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly useful. I agree, FWIW. These

Re: [RFC PATCH 1/3] usbnet: Get rid of spammy usbnet "kevent X may have been dropped"

Douglas Anderson writes: > Every once in a while when my system is under a bit of stress I see > some spammy messages show up in my logs that say: > > kevent X may have been dropped > > As far as I can tell these messages aren't terribly useful. I agree, FWIW. These messages just confuse

Re: [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

Douglas Anderson writes: > If rx_submit() returns an error code then nobody calls usb_free_urb(). > That means it's leaked. Nope. rx_submit() will call usb_free_urb() before returning an error: static int rx_submit (struct usbnet *dev, struct urb *urb, gfp_t flags) ..

Re: [RFC PATCH 3/3] usbnet: Fix memory leak when rx_submit() fails

Douglas Anderson writes: > If rx_submit() returns an error code then nobody calls usb_free_urb(). > That means it's leaked. Nope. rx_submit() will call usb_free_urb() before returning an error: static int rx_submit (struct usbnet *dev, struct urb *urb, gfp_t flags) .. if (!skb) {

Re: [PATCH v2] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

Allen Pais writes: > Signed-off-by: Allen Pais > --- > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c >

Re: [PATCH v2] drivers:platform/x86:Use ARRAY_SIZE() for the size calculation of the array.

Allen Pais writes: > Signed-off-by: Allen Pais > --- > drivers/platform/x86/intel_telemetry_debugfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel_telemetry_debugfs.c > b/drivers/platform/x86/intel_telemetry_debugfs.c > index

Re: [PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer base. > >

Re: [PATCH 24/25] net/cdc_ncm: Replace tasklet with softirq hrtimer

Anna-Maria Gleixner writes: > From: Thomas Gleixner > > The bh tasklet is used in invoke the hrtimer (cdc_ncm_tx_timer_cb) in > softirq context. This can be also achieved without the tasklet but with > CLOCK_MONOTONIC_SOFT as hrtimer base. > > Signed-off-by: Thomas Gleixner > Signed-off-by:

[PATCH] USB: serial: option: simplify 3 D-Link device entries

=0ms E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms Signed-off-by: Bjørn Mork <bj...@mork.no> --- Johan Hovold <jo...@kernel.org> writes: > Do you want to submit a patch or should I do it? Well, I can save you that job if this is fine with you. Feel free to add a stable

[PATCH] USB: serial: option: simplify 3 D-Link device entries

=0ms E: Ad=06(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms Signed-off-by: Bjørn Mork --- Johan Hovold writes: > Do you want to submit a patch or should I do it? Well, I can save you that job if this is fine with you. Feel free to add a stable cc if you think it is appropriate. I am not sure... Bj

Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1

Johan Hovold writes: > On Mon, Aug 28, 2017 at 04:32:53PM +0200, Maciej S. Szmigiero wrote: > >> Also, three other D-Link modems few lines above are using the same >> USB_DEVICE_AND_INTERFACE_INFO() selectors. > > Yeah, I noticed those, and I'm not sure why they're not using >

Re: [PATCH] USB: serial: option: add support for D-Link DWM-157 C1

Johan Hovold writes: > On Mon, Aug 28, 2017 at 04:32:53PM +0200, Maciej S. Szmigiero wrote: > >> Also, three other D-Link modems few lines above are using the same >> USB_DEVICE_AND_INTERFACE_INFO() selectors. > > Yeah, I noticed those, and I'm not sure why they're not using > class-matching only

Re: [PATCH 0/6] In-kernel QMI handling

Bjorn Andersson writes: > This series starts by moving the common definitions of the QMUX protocol to > the > uapi header, as they are shared with clients - both in kernel and userspace. > > This series then introduces in-kernel helper functions for aiding the

Re: [PATCH 0/6] In-kernel QMI handling

Bjorn Andersson writes: > This series starts by moving the common definitions of the QMUX protocol to > the > uapi header, as they are shared with clients - both in kernel and userspace. > > This series then introduces in-kernel helper functions for aiding the handling > of QMI encoded messages

Re: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1 Toughbook

Johan Hovold writes: > On Mon, Aug 07, 2017 at 04:22:27PM +0200, Oleg Kokorin wrote: >> From 336f8adb0292a25ea41f0515a80850031f814b9b Mon Sep 17 00:00:00 2001 >> From: Oleg Kokorin >> Date: Mon, 7 Aug 2017 15:35:53 +0200 >> Subject: [PATCH] append Qualcomm

Re: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1 Toughbook

Johan Hovold writes: > On Mon, Aug 07, 2017 at 04:22:27PM +0200, Oleg Kokorin wrote: >> From 336f8adb0292a25ea41f0515a80850031f814b9b Mon Sep 17 00:00:00 2001 >> From: Oleg Kokorin >> Date: Mon, 7 Aug 2017 15:35:53 +0200 >> Subject: [PATCH] append Qualcomm GOBI 2K chipset ID for Panasonic CF-U1

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

Johan Hovold writes: > On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > >> For devices with connected EEPROM some modes (including UART) are >> configurable in the EEPROM. For devices without EEPROM the default >> mode is always UART, but FIFO-, Bitbang- and

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

Johan Hovold writes: > On Tue, Jul 11, 2017 at 08:52:37AM +0200, Anatolij Gustschin wrote: > >> For devices with connected EEPROM some modes (including UART) are >> configurable in the EEPROM. For devices without EEPROM the default >> mode is always UART, but FIFO-, Bitbang- and MPSSE-mode can be

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

[adding Johan on the CC list] Anatolij Gustschin writes: > +static struct usb_device_id ftdi_mfd_table[] = { > + { USB_DEVICE(0x0403, 0x6014) }, > + {} > +}; > +MODULE_DEVICE_TABLE(usb, ftdi_mfd_table); This device ID is currently handled by the ftdi_sio driver, so I

Re: [PATCH 1/3] mfd: Add support for FTDI FT232H devices

[adding Johan on the CC list] Anatolij Gustschin writes: > +static struct usb_device_id ftdi_mfd_table[] = { > + { USB_DEVICE(0x0403, 0x6014) }, > + {} > +}; > +MODULE_DEVICE_TABLE(usb, ftdi_mfd_table); This device ID is currently handled by the ftdi_sio driver, so I believe you at

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

"Baxter, Jim" writes: > I tested this with printk's to show when the low memory code was triggered > and the value of ctx->tx_low_mem_val and ctx->tx_low_mem_max_cnt. > I created a workqueue that slowly used up the atomic memory until the > code is triggered. > > I could

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

"Baxter, Jim" writes: > I tested this with printk's to show when the low memory code was triggered > and the value of ctx->tx_low_mem_val and ctx->tx_low_mem_max_cnt. > I created a workqueue that slowly used up the atomic memory until the > code is triggered. > > I could add debug prints, though

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

ld tell the user that the initial buffer allocation has failed. Maybe add some sort of debug helper(s) in a followup patch? How did you verify the patch operation while testing it? Anyway, that's no show stopper of course. So FWIW: Reviewed-by: Bjørn Mork <bj...@mork.no>

Re: [PATCH V2 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Maybe add some sort of debug helper(s) in a followup patch? How did you verify the patch operation while testing it? Anyway, that's no show stopper of course. So FWIW: Reviewed-by: Bjørn Mork

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

Jay Vosburgh writes: > Michael J Dilmore wrote: > >>if (WARN_ON(!new_active_slave) { >>netdev_dbg("Can't add new active slave - pointer null"); >>return ERROR_CODE >>} > > In general, yes, but in this case, the condition

Re: [PATCH] Convert BUG_ON to WARN_ON in bond_options.c

Jay Vosburgh writes: > Michael J Dilmore wrote: > >>if (WARN_ON(!new_active_slave) { >>netdev_dbg("Can't add new active slave - pointer null"); >>return ERROR_CODE >>} > > In general, yes, but in this case, the condition should be > impossible to hit, so BUG_ON seems appropriate.

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

David Laight writes: > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter >> Sent: 16 May 2017 18:41 >> >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

David Laight writes: > From: linux-usb-ow...@vger.kernel.org > [mailto:linux-usb-ow...@vger.kernel.org] On Behalf Of Jim Baxter >> Sent: 16 May 2017 18:41 >> >> The CDC-NCM driver can require large amounts of memory to create >> skb's and this can be a problem when the memory becomes

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Jim Baxter writes: > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of

Re: [RFC V1 1/1] net: cdc_ncm: Reduce memory use when kernel memory low

Jim Baxter writes: > The CDC-NCM driver can require large amounts of memory to create > skb's and this can be a problem when the memory becomes fragmented. > > This especially affects embedded systems that have constrained > resources but wish to maximise the throughput of CDC-NCM with 16KiB >

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

"Baxter, Jim" <jim_bax...@mentor.com> writes: > Bjørn Mork <bj...@mork.no> writes: >> >> Ouch! Thanks for finding this. This should go to the stable queue as >> well. >> >> Reviewed-by: Bjørn Mork <bj...@mork.no> >>

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

"Baxter, Jim" writes: > Bjørn Mork writes: >> >> Ouch! Thanks for finding this. This should go to the stable queue as >> well. >> >> Reviewed-by: Bjørn Mork >> > > Do I need to submit this to the stable queue myself? No, davem w

Re: [PATCH] usb: cdc-wdm: use memdup_user

Geliang Tang writes: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/usb/class/cdc-wdm.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git

Re: [PATCH] usb: cdc-wdm: use memdup_user

Geliang Tang writes: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/usb/class/cdc-wdm.c | 15 +++ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/drivers/usb/class/cdc-wdm.c

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

gt;tx_max - skb_out->len) == 0. > > I have resolved this by storing the size of > the memory to be zeroed before the skb_put > and using this in the memset call. > > Signed-off-by: Jim Baxter <jim_bax...@mentor.com> Ouch! Thanks for finding this. This should go

Re: [PATCH V1 1/1] net: cdc_ncm: Fix TX zero padding

) == 0. > > I have resolved this by storing the size of > the memory to be zeroed before the skb_put > and using this in the memset call. > > Signed-off-by: Jim Baxter Ouch! Thanks for finding this. This should go to the stable queue as well. Reviewed-by: Bjørn Mork

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

Bjørn Mork <bj...@mork.no> writes: > "Brown, Aaron F" <aaron.f.br...@intel.com> writes: >>> From: Bjørn Mork [mailto:bj...@mork.no] >>> >>> Already did that a week ago: >>> https://www.spinics.net/lists/netdev/msg423379.html >>>

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

Bjørn Mork writes: > "Brown, Aaron F" writes: >>> From: Bjørn Mork [mailto:bj...@mork.no] >>> >>> Already did that a week ago: >>> https://www.spinics.net/lists/netdev/msg423379.html >>> >>> Haven't heard anything back

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

"Brown, Aaron F" <aaron.f.br...@intel.com> writes: >> From: Bjørn Mork [mailto:bj...@mork.no] >> >> Already did that a week ago: >> https://www.spinics.net/lists/netdev/msg423379.html >> >> Haven't heard anything back yet. Wondering if they

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

"Brown, Aaron F" writes: >> From: Bjørn Mork [mailto:bj...@mork.no] >> >> Already did that a week ago: >> https://www.spinics.net/lists/netdev/msg423379.html >> >> Haven't heard anything back yet. Wondering if they are waiting for >> some

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

Borislav Petkov writes: > On Sun, Mar 12, 2017 at 03:55:08PM +0200, Andy Shevchenko wrote: > >> The only change that IMHO matters happened between v4.10 and v4.11-rc1 is >> this: >> >> @@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev) >> /*

Re: [BUG] 4.11.0-rc1 panic on shutdown X61s

Borislav Petkov writes: > On Sun, Mar 12, 2017 at 03:55:08PM +0200, Andy Shevchenko wrote: > >> The only change that IMHO matters happened between v4.10 and v4.11-rc1 is >> this: >> >> @@ -6276,8 +6274,8 @@ static int e1000e_pm_freeze(struct device *dev) >> /* Quiesce the device

  1   2   3   4   5   6   7   >