Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-10 Thread DebBarma, Tarun Kanti
On Thu, Aug 9, 2012 at 8:28 PM, Kevin Hilman wrote: > "DebBarma, Tarun Kanti" writes: > >> On Wed, Aug 8, 2012 at 10:40 PM, Kevin Hilman wrote: >>> Tarun Kanti DebBarma writes: >>> >>>> Add *remove* callback so that necessary cleanup opera

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-10 Thread DebBarma, Tarun Kanti
On Thu, Aug 9, 2012 at 8:28 PM, Kevin Hilman khil...@ti.com wrote: DebBarma, Tarun Kanti tarun.ka...@ti.com writes: On Wed, Aug 8, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: Add *remove* callback so that necessary cleanup operations

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-08 Thread DebBarma, Tarun Kanti
On Wed, Aug 8, 2012 at 10:40 PM, Kevin Hilman wrote: > Tarun Kanti DebBarma writes: > >> Add *remove* callback so that necessary cleanup operations are >> performed when device is unregistered. The device is deleted >> from the list and associated clock handle is released by >> calling clk_put()

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-08 Thread DebBarma, Tarun Kanti
On Wed, Aug 8, 2012 at 7:33 PM, Shilimkar, Santosh wrote: > On Wed, Aug 8, 2012 at 7:28 PM, Tarun Kanti DebBarma > wrote: >> Add *remove* callback so that necessary cleanup operations are >> performed when device is unregistered. The device is deleted >> from the list and associated clock

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-08 Thread DebBarma, Tarun Kanti
On Wed, Aug 8, 2012 at 7:33 PM, Shilimkar, Santosh santosh.shilim...@ti.com wrote: On Wed, Aug 8, 2012 at 7:28 PM, Tarun Kanti DebBarma tarun.ka...@ti.com wrote: Add *remove* callback so that necessary cleanup operations are performed when device is unregistered. The device is deleted from

Re: [PATCH v2] gpio/omap: add *remove* callback in platform_driver

2012-08-08 Thread DebBarma, Tarun Kanti
On Wed, Aug 8, 2012 at 10:40 PM, Kevin Hilman khil...@ti.com wrote: Tarun Kanti DebBarma tarun.ka...@ti.com writes: Add *remove* callback so that necessary cleanup operations are performed when device is unregistered. The device is deleted from the list and associated clock handle is released

Re: [GPIO] Crashed when not using

2012-07-30 Thread DebBarma, Tarun Kanti
Sourav, On Mon, Jul 30, 2012 at 2:13 PM, Poddar, Sourav wrote: > Hi All, > > I tried using gpio as an interrupt line for my driver > (drivers/staging/iio/light/tsl2x7x_core.c) for omap5. > The interrupt line number was directly passed to the driver using > device tree. But what I observed > is

Re: [GPIO] Crashed when not using

2012-07-30 Thread DebBarma, Tarun Kanti
Sourav, On Mon, Jul 30, 2012 at 2:13 PM, Poddar, Sourav sourav.pod...@ti.com wrote: Hi All, I tried using gpio as an interrupt line for my driver (drivers/staging/iio/light/tsl2x7x_core.c) for omap5. The interrupt line number was directly passed to the driver using device tree. But what I

Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread DebBarma, Tarun Kanti
On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley wrote: > On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: > >> Since the bank->dbck initialization in a one time operation there >> is no need to keep this within gpio_debounce(). Therefore, moving >> clk_get(bank->dbck) to omap_gpio_mod_init().

Re: [PATCH 1/2] gpio/omap: move bank-dbck initialization to omap_gpio_mod_init()

2012-07-11 Thread DebBarma, Tarun Kanti
On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley p...@pwsan.com wrote: On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: Since the bank-dbck initialization in a one time operation there is no need to keep this within gpio_debounce(). Therefore, moving clk_get(bank-dbck) to omap_gpio_mod_init().