Re: [PATCH 0/6] x86: reduce paravirtualized spinlock overhead

2015-05-05 Thread Jeremy Fitzhardinge
On 05/03/2015 10:55 PM, Juergen Gross wrote: > I did a small measurement of the pure locking functions on bare metal > without and with my patches. > > spin_lock() for the first time (lock and code not in cache) dropped from > about 600 to 500 cycles. > > spin_unlock() for first time dropped from

Re: [PATCH 0/6] x86: reduce paravirtualized spinlock overhead

2015-05-05 Thread Jeremy Fitzhardinge
On 05/03/2015 10:55 PM, Juergen Gross wrote: I did a small measurement of the pure locking functions on bare metal without and with my patches. spin_lock() for the first time (lock and code not in cache) dropped from about 600 to 500 cycles. spin_unlock() for first time dropped from 145 to

Re: [PATCH 0/6] x86: reduce paravirtualized spinlock overhead

2015-04-30 Thread Jeremy Fitzhardinge
On 04/30/2015 03:53 AM, Juergen Gross wrote: > Paravirtualized spinlocks produce some overhead even if the kernel is > running on bare metal. The main reason are the more complex locking > and unlocking functions. Especially unlocking is no longer just one > instruction but so complex that it is

Re: [PATCH 0/6] x86: reduce paravirtualized spinlock overhead

2015-04-30 Thread Jeremy Fitzhardinge
On 04/30/2015 03:53 AM, Juergen Gross wrote: Paravirtualized spinlocks produce some overhead even if the kernel is running on bare metal. The main reason are the more complex locking and unlocking functions. Especially unlocking is no longer just one instruction but so complex that it is no

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-11 Thread Jeremy Fitzhardinge
On 02/11/2015 09:24 AM, Oleg Nesterov wrote: > I agree, and I have to admit I am not sure I fully understand why > unlock uses the locked add. Except we need a barrier to avoid the race > with the enter_slowpath() users, of course. Perhaps this is the only > reason? Right now it needs to be a

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-11 Thread Jeremy Fitzhardinge
On 02/11/2015 09:24 AM, Oleg Nesterov wrote: I agree, and I have to admit I am not sure I fully understand why unlock uses the locked add. Except we need a barrier to avoid the race with the enter_slowpath() users, of course. Perhaps this is the only reason? Right now it needs to be a locked

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Jeremy Fitzhardinge
On 02/10/2015 05:26 AM, Oleg Nesterov wrote: > On 02/10, Raghavendra K T wrote: >> On 02/10/2015 06:23 AM, Linus Torvalds wrote: >> >>> add_smp(>tickets.head, TICKET_LOCK_INC); >>> if (READ_ONCE(lock->tickets.tail) & TICKET_SLOWPATH_FLAG) .. >>> >>> into something like >>> >>>

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-10 Thread Jeremy Fitzhardinge
On 02/10/2015 05:26 AM, Oleg Nesterov wrote: On 02/10, Raghavendra K T wrote: On 02/10/2015 06:23 AM, Linus Torvalds wrote: add_smp(lock-tickets.head, TICKET_LOCK_INC); if (READ_ONCE(lock-tickets.tail) TICKET_SLOWPATH_FLAG) .. into something like val =

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-08 Thread Jeremy Fitzhardinge
On 02/06/2015 06:49 AM, Raghavendra K T wrote: > Paravirt spinlock clears slowpath flag after doing unlock. > As explained by Linus currently it does: > prev = *lock; > add_smp(>tickets.head, TICKET_LOCK_INC); > > /* add_smp() is a full mb() */ > >

Re: [PATCH] x86 spinlock: Fix memory corruption on completing completions

2015-02-08 Thread Jeremy Fitzhardinge
On 02/06/2015 06:49 AM, Raghavendra K T wrote: Paravirt spinlock clears slowpath flag after doing unlock. As explained by Linus currently it does: prev = *lock; add_smp(lock-tickets.head, TICKET_LOCK_INC); /* add_smp() is a full mb() */

Re: [PATCH 1/3] MAINTAINERS: Remove Jeremy from the Xen subsystem.

2013-08-13 Thread Jeremy Fitzhardinge
On 08/05/2013 11:05 AM, Konrad Rzeszutek Wilk wrote: > Jeremy has been a key person in making Linux work with Xen. > He has been enjoying the last year working on something > different so reflect that in the maintainers file. Ack. J > > CC: Jeremy Fitzhardinge > Sig

Re: [PATCH delta V13 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-13 Thread Jeremy Fitzhardinge
On 08/13/2013 01:02 PM, Raghavendra K T wrote: > * Ingo Molnar [2013-08-13 18:55:52]: > >> Would be nice to have a delta fix patch against tip:x86/spinlocks, which >> I'll then backmerge into that series via rebasing it. >> > There was a namespace collision of PER_CPU lock_waiting variable when

Re: [PATCH delta V13 14/14] kvm : Paravirtual ticketlocks support for linux guests running on KVM hypervisor

2013-08-13 Thread Jeremy Fitzhardinge
On 08/13/2013 01:02 PM, Raghavendra K T wrote: * Ingo Molnar mi...@kernel.org [2013-08-13 18:55:52]: Would be nice to have a delta fix patch against tip:x86/spinlocks, which I'll then backmerge into that series via rebasing it. There was a namespace collision of PER_CPU lock_waiting

Re: [PATCH 1/3] MAINTAINERS: Remove Jeremy from the Xen subsystem.

2013-08-13 Thread Jeremy Fitzhardinge
On 08/05/2013 11:05 AM, Konrad Rzeszutek Wilk wrote: Jeremy has been a key person in making Linux work with Xen. He has been enjoying the last year working on something different so reflect that in the maintainers file. Ack. J CC: Jeremy Fitzhardinge jer...@goop.org Signed-off

[tip:x86/spinlocks] x86, spinlock: Replace pv spinlocks with pv ticketlocks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 545ac13892ab391049a92108cf59a0d05de7e28c Gitweb: http://git.kernel.org/tip/545ac13892ab391049a92108cf59a0d05de7e28c Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:49 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:05 -0700 x86, spinlock

[tip:x86/spinlocks] x86, pvticketlock: When paravirtualizing ticket locks, increment by 2

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 4a1ed4ca681e7df38ed1b609a11aab38cbc515b3 Gitweb: http://git.kernel.org/tip/4a1ed4ca681e7df38ed1b609a11aab38cbc515b3 Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:56 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:50 -0700 x86, pvticketlock

[tip:x86/spinlocks] xen: Defer spinlock setup until boot CPU setup

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: bf7aab3ad4b4364a293421d628a912a2153ee1ee Gitweb: http://git.kernel.org/tip/bf7aab3ad4b4364a293421d628a912a2153ee1ee Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:52 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:18 -0700 xen: Defer

[tip:x86/spinlocks] xen, pvticketlock: Allow interrupts to be enabled while blocking

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 1ed7bf5f5227169b661c619636f754b98001ec30 Gitweb: http://git.kernel.org/tip/1ed7bf5f5227169b661c619636f754b98001ec30 Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:59 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:54:03 -0700 xen, pvticketlock

[tip:x86/spinlocks] xen, pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: b8fa70b51aa76737bdb6b493901ef7376977489c Gitweb: http://git.kernel.org/tip/b8fa70b51aa76737bdb6b493901ef7376977489c Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:54 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:37 -0700 xen, pvticketlocks

[tip:x86/spinlocks] x86, pvticketlock: Use callee-save for lock_spinning

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 354714dd2607778692db53947ab93b74956494e5 Gitweb: http://git.kernel.org/tip/354714dd2607778692db53947ab93b74956494e5 Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:55 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:44 -0700 x86, pvticketlock

[tip:x86/spinlocks] xen, pvticketlock: Xen implementation for PV ticket locks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 80bd58fef495d000a02fc5b55ca76d423400e748 Gitweb: http://git.kernel.org/tip/80bd58fef495d000a02fc5b55ca76d423400e748 Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:53 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:23 -0700 xen, pvticketlock

[tip:x86/spinlocks] x86, ticketlock: Add slowpath logic

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 96f853eaa889c7a22718d275b0df7bebdbd6780e Gitweb: http://git.kernel.org/tip/96f853eaa889c7a22718d275b0df7bebdbd6780e Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:58 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:54:00 -0700 x86, ticketlock

[tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: b798df09f919c52823110a74bd568c6a4e98e6b2 Gitweb: http://git.kernel.org/tip/b798df09f919c52823110a74bd568c6a4e98e6b2 Author: Jeremy Fitzhardinge AuthorDate: Fri, 9 Aug 2013 19:51:51 +0530 Committer: H. Peter Anvin CommitDate: Fri, 9 Aug 2013 07:53:14 -0700 x86, ticketlock

[tip:x86/spinlocks] xen, pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: b8fa70b51aa76737bdb6b493901ef7376977489c Gitweb: http://git.kernel.org/tip/b8fa70b51aa76737bdb6b493901ef7376977489c Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:54 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] x86, pvticketlock: Use callee-save for lock_spinning

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 354714dd2607778692db53947ab93b74956494e5 Gitweb: http://git.kernel.org/tip/354714dd2607778692db53947ab93b74956494e5 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:55 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] xen, pvticketlock: Xen implementation for PV ticket locks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 80bd58fef495d000a02fc5b55ca76d423400e748 Gitweb: http://git.kernel.org/tip/80bd58fef495d000a02fc5b55ca76d423400e748 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:53 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] x86, ticketlock: Add slowpath logic

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 96f853eaa889c7a22718d275b0df7bebdbd6780e Gitweb: http://git.kernel.org/tip/96f853eaa889c7a22718d275b0df7bebdbd6780e Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:58 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: b798df09f919c52823110a74bd568c6a4e98e6b2 Gitweb: http://git.kernel.org/tip/b798df09f919c52823110a74bd568c6a4e98e6b2 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:51 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] xen, pvticketlock: Allow interrupts to be enabled while blocking

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 1ed7bf5f5227169b661c619636f754b98001ec30 Gitweb: http://git.kernel.org/tip/1ed7bf5f5227169b661c619636f754b98001ec30 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:59 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] x86, pvticketlock: When paravirtualizing ticket locks, increment by 2

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 4a1ed4ca681e7df38ed1b609a11aab38cbc515b3 Gitweb: http://git.kernel.org/tip/4a1ed4ca681e7df38ed1b609a11aab38cbc515b3 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:56 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] xen: Defer spinlock setup until boot CPU setup

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: bf7aab3ad4b4364a293421d628a912a2153ee1ee Gitweb: http://git.kernel.org/tip/bf7aab3ad4b4364a293421d628a912a2153ee1ee Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:52 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] x86, spinlock: Replace pv spinlocks with pv ticketlocks

2013-08-10 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 545ac13892ab391049a92108cf59a0d05de7e28c Gitweb: http://git.kernel.org/tip/545ac13892ab391049a92108cf59a0d05de7e28c Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Fri, 9 Aug 2013 19:51:49 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Fri, 9 Aug 2013

[tip:x86/spinlocks] xen, pvticketlock: Allow interrupts to be enabled while blocking

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 38eddb85894561ab32c1de4171e1c1582f0efa78 Gitweb: http://git.kernel.org/tip/38eddb85894561ab32c1de4171e1c1582f0efa78 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:14:12 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:07:01 -0700 xen, pvticketlock

[tip:x86/spinlocks] x86, ticketlock: Add slowpath logic

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: faf5f87c305fc58464bf8c47d0a5d148ceee2e32 Gitweb: http://git.kernel.org/tip/faf5f87c305fc58464bf8c47d0a5d148ceee2e32 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:13:52 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:58 -0700 x86, ticketlock

[tip:x86/spinlocks] x86, pvticketlock: When paravirtualizing ticket locks, increment by 2

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 00de643f44ed84156e18f8b9afa8613d3b37a298 Gitweb: http://git.kernel.org/tip/00de643f44ed84156e18f8b9afa8613d3b37a298 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:13:13 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:50 -0700 x86, pvticketlock

[tip:x86/spinlocks] xen: Defer spinlock setup until boot CPU setup

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 26dca1a3262c451846537d8c1f3f56290718b7d4 Gitweb: http://git.kernel.org/tip/26dca1a3262c451846537d8c1f3f56290718b7d4 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:11:45 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:34 -0700 xen: Defer

[tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: c1230bf0bf6c93ff2db93ba0b66839068f498e8b Gitweb: http://git.kernel.org/tip/c1230bf0bf6c93ff2db93ba0b66839068f498e8b Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:11:20 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:30 -0700 x86, ticketlock

[tip:x86/spinlocks] xen, pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 9f091fd2047dc4f9cc512e88f818786274fa646f Gitweb: http://git.kernel.org/tip/9f091fd2047dc4f9cc512e88f818786274fa646f Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:12:24 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:42 -0700 xen, pvticketlocks

[tip:x86/spinlocks] x86, pvticketlock: Use callee-save for lock_spinning

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 80aefe73ea1611bb064f4dcfe49b1aa9648922b3 Gitweb: http://git.kernel.org/tip/80aefe73ea1611bb064f4dcfe49b1aa9648922b3 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:12:44 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:46 -0700 x86, pvticketlock

[tip:x86/spinlocks] xen, pvticketlock: Xen implementation for PV ticket locks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 82a5c77805c1824da74912f986f6dab241589ac7 Gitweb: http://git.kernel.org/tip/82a5c77805c1824da74912f986f6dab241589ac7 Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:12:04 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:38 -0700 xen, pvticketlock

[tip:x86/spinlocks] x86, spinlock: Replace pv spinlocks with pv ticketlocks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: ee120b6a347e3ce6526bd2380fdf5858d5a8550d Gitweb: http://git.kernel.org/tip/ee120b6a347e3ce6526bd2380fdf5858d5a8550d Author: Jeremy Fitzhardinge AuthorDate: Tue, 6 Aug 2013 17:10:40 +0530 Committer: H. Peter Anvin CommitDate: Thu, 8 Aug 2013 16:06:23 -0700 x86, spinlock

[tip:x86/spinlocks] x86, spinlock: Replace pv spinlocks with pv ticketlocks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: ee120b6a347e3ce6526bd2380fdf5858d5a8550d Gitweb: http://git.kernel.org/tip/ee120b6a347e3ce6526bd2380fdf5858d5a8550d Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:10:40 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] xen, pvticketlock: Xen implementation for PV ticket locks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 82a5c77805c1824da74912f986f6dab241589ac7 Gitweb: http://git.kernel.org/tip/82a5c77805c1824da74912f986f6dab241589ac7 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:12:04 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] x86, pvticketlock: Use callee-save for lock_spinning

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 80aefe73ea1611bb064f4dcfe49b1aa9648922b3 Gitweb: http://git.kernel.org/tip/80aefe73ea1611bb064f4dcfe49b1aa9648922b3 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:12:44 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] xen, pvticketlocks: Add xen_nopvspin parameter to disable xen pv ticketlocks

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 9f091fd2047dc4f9cc512e88f818786274fa646f Gitweb: http://git.kernel.org/tip/9f091fd2047dc4f9cc512e88f818786274fa646f Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:12:24 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] xen: Defer spinlock setup until boot CPU setup

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 26dca1a3262c451846537d8c1f3f56290718b7d4 Gitweb: http://git.kernel.org/tip/26dca1a3262c451846537d8c1f3f56290718b7d4 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:11:45 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] x86, ticketlock: Collapse a layer of functions

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: c1230bf0bf6c93ff2db93ba0b66839068f498e8b Gitweb: http://git.kernel.org/tip/c1230bf0bf6c93ff2db93ba0b66839068f498e8b Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:11:20 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] x86, ticketlock: Add slowpath logic

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: faf5f87c305fc58464bf8c47d0a5d148ceee2e32 Gitweb: http://git.kernel.org/tip/faf5f87c305fc58464bf8c47d0a5d148ceee2e32 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:13:52 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] x86, pvticketlock: When paravirtualizing ticket locks, increment by 2

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 00de643f44ed84156e18f8b9afa8613d3b37a298 Gitweb: http://git.kernel.org/tip/00de643f44ed84156e18f8b9afa8613d3b37a298 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:13:13 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

[tip:x86/spinlocks] xen, pvticketlock: Allow interrupts to be enabled while blocking

2013-08-08 Thread tip-bot for Jeremy Fitzhardinge
Commit-ID: 38eddb85894561ab32c1de4171e1c1582f0efa78 Gitweb: http://git.kernel.org/tip/38eddb85894561ab32c1de4171e1c1582f0efa78 Author: Jeremy Fitzhardinge jer...@goop.org AuthorDate: Tue, 6 Aug 2013 17:14:12 +0530 Committer: H. Peter Anvin h...@linux.intel.com CommitDate: Thu, 8 Aug 2013

Re: Replace in linux-next the xen, xen-two, xen-arm with xen/tip.git tree instead.

2013-07-30 Thread Jeremy Fitzhardinge
On 07/30/2013 12:53 PM, Konrad Rzeszutek Wilk wrote: > Hey, > > I was wondering if it would be possible to remove from linux-next > the three xen trees and instead use a combined tree, similar to the > x86 tip (so the various maintainers share it)? > > The ones that would be removed are: > > xen

Re: Replace in linux-next the xen, xen-two, xen-arm with xen/tip.git tree instead.

2013-07-30 Thread Jeremy Fitzhardinge
On 07/30/2013 12:53 PM, Konrad Rzeszutek Wilk wrote: Hey, I was wondering if it would be possible to remove from linux-next the three xen trees and instead use a combined tree, similar to the x86 tip (so the various maintainers share it)? The ones that would be removed are: xen

Re: [LLVMdev] [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
On 07/14/2013 12:30 PM, Tim Northover wrote: >> And that is why I think you should just consider "bt $x,y" to be >> trivially the same thing and not at all ambiguous. Because there is >> ABSOLUTELY ZERO ambiguity when people write >> >>bt $63, mem >> >> Zero. Nada. None. The semantics are

Re: [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
rations because it makes a real semantic difference, but overly strict for bit operations. J > [1]: http://docs.oracle.com/cd/E19253-01/817-5477/817-5477.pdf > > Cc: Jeremy Fitzhardinge > Cc: Andi Kleen > Cc: Linus Torvalds > Cc: Ingo Molnar > Cc: Thomas Gleixner > C

Re: [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
(Resent without HTML) On 07/14/2013 10:19 AM, Linus Torvalds wrote: > Now, there are possible cases where you want to make the size explicit > because you are mixing memory operand sizes and there can be nasty > performance implications of doing a 32-bit write and then doing a > 64-bit read of

Re: [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
]: http://docs.oracle.com/cd/E19253-01/817-5477/817-5477.pdf Cc: Jeremy Fitzhardinge jer...@goop.org Cc: Andi Kleen a...@linux.intel.com Cc: Linus Torvalds torva...@linux-foundation.org Cc: Ingo Molnar mi...@kernel.org Cc: Thomas Gleixner t...@linutronix.de Cc: Eli Friedman eli.fried...@gmail.com

Re: [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
(Resent without HTML) On 07/14/2013 10:19 AM, Linus Torvalds wrote: Now, there are possible cases where you want to make the size explicit because you are mixing memory operand sizes and there can be nasty performance implications of doing a 32-bit write and then doing a 64-bit read of the

Re: [LLVMdev] [PATCH] x86/asm: avoid mnemonics without type suffix

2013-07-14 Thread Jeremy Fitzhardinge
On 07/14/2013 12:30 PM, Tim Northover wrote: And that is why I think you should just consider bt $x,y to be trivially the same thing and not at all ambiguous. Because there is ABSOLUTELY ZERO ambiguity when people write bt $63, mem Zero. Nada. None. The semantics are *exactly* the same

Re: [PATCH RFC V9 1/19] x86/spinlock: Replace pv spinlocks with pv ticketlocks

2013-06-01 Thread Jeremy Fitzhardinge
On 06/01/2013 12:21 PM, Raghavendra K T wrote: > x86/spinlock: Replace pv spinlocks with pv ticketlocks > > From: Jeremy Fitzhardinge I'm not sure what the etiquette is here; I did the work while at Citrix, but jer...@goop.org is my canonical email address. The Citrix address is dead an

Re: [PATCH RFC V9 0/19] Paravirtualized ticket spinlocks

2013-06-01 Thread Jeremy Fitzhardinge
On 06/01/2013 01:14 PM, Andi Kleen wrote: > FWIW I use the paravirt spinlock ops for adding lock elision > to the spinlocks. Does lock elision still use the ticketlock algorithm/structure, or are they different? If they're still basically ticketlocks, then it seems to me that they're

Re: [PATCH RFC V9 0/19] Paravirtualized ticket spinlocks

2013-06-01 Thread Jeremy Fitzhardinge
On 06/01/2013 01:14 PM, Andi Kleen wrote: FWIW I use the paravirt spinlock ops for adding lock elision to the spinlocks. Does lock elision still use the ticketlock algorithm/structure, or are they different? If they're still basically ticketlocks, then it seems to me that they're complimentary

Re: [PATCH RFC V9 1/19] x86/spinlock: Replace pv spinlocks with pv ticketlocks

2013-06-01 Thread Jeremy Fitzhardinge
On 06/01/2013 12:21 PM, Raghavendra K T wrote: x86/spinlock: Replace pv spinlocks with pv ticketlocks From: Jeremy Fitzhardinge jeremy.fitzhardi...@citrix.com I'm not sure what the etiquette is here; I did the work while at Citrix, but jer...@goop.org is my canonical email address. The Citrix

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Jeremy Fitzhardinge
On 10/09/2012 06:14 PM, Andrew Morton wrote: > On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan wrote: > + if (!pg) { + *alloc_error = true; + return i * alloc_unit; + } + + totalram_pages -= alloc_unit;

Re: [PATCH 2/2] Drivers: hv: Add Hyper-V balloon driver

2012-10-10 Thread Jeremy Fitzhardinge
On 10/09/2012 06:14 PM, Andrew Morton wrote: On Wed, 10 Oct 2012 00:09:12 + KY Srinivasan k...@microsoft.com wrote: + if (!pg) { + *alloc_error = true; + return i * alloc_unit; + } + + totalram_pages -= alloc_unit; Well, I'd

Re: [PATCH 53/74] x86, lto, paravirt: Make paravirt thunks global

2012-08-19 Thread Jeremy Fitzhardinge
On 08/18/2012 07:56 PM, Andi Kleen wrote: > From: Andi Kleen > > The paravirt thunks use a hack of using a static reference to a static > function to reference that function from the top level statement. > > This assumes that gcc always generates static function names in a specific > format,

Re: [PATCH 52/74] x86, lto, paravirt: Don't rely on local assembler labels

2012-08-19 Thread Jeremy Fitzhardinge
On 08/18/2012 07:56 PM, Andi Kleen wrote: > From: Andi Kleen > > The paravirt patching code assumes that it can reference a > local assembler label between two different top level assembler > statements. This does not work with some experimental gcc builds, > where the assembler code may end up

Re: [PATCH 52/74] x86, lto, paravirt: Don't rely on local assembler labels

2012-08-19 Thread Jeremy Fitzhardinge
On 08/18/2012 07:56 PM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com The paravirt patching code assumes that it can reference a local assembler label between two different top level assembler statements. This does not work with some experimental gcc builds, where the assembler

Re: [PATCH 53/74] x86, lto, paravirt: Make paravirt thunks global

2012-08-19 Thread Jeremy Fitzhardinge
On 08/18/2012 07:56 PM, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com The paravirt thunks use a hack of using a static reference to a static function to reference that function from the top level statement. This assumes that gcc always generates static function names in a specific

Re: [PATCH] netvm: check for page == NULL when propogating the skb->pfmemalloc flag

2012-08-13 Thread Jeremy Fitzhardinge
On 08/13/2012 03:47 AM, Mel Gorman wrote: > Resending to correct Jeremy's address. > > On Wed, Aug 08, 2012 at 03:50:46PM -0700, David Miller wrote: >> From: Mel Gorman >> Date: Tue, 7 Aug 2012 09:55:55 +0100 >> >>> Commit [c48a11c7: netvm: propagate page->pfmemalloc to skb] is responsible >>>

Re: [PATCH] netvm: check for page == NULL when propogating the skb-pfmemalloc flag

2012-08-13 Thread Jeremy Fitzhardinge
On 08/13/2012 03:47 AM, Mel Gorman wrote: Resending to correct Jeremy's address. On Wed, Aug 08, 2012 at 03:50:46PM -0700, David Miller wrote: From: Mel Gorman mgor...@suse.de Date: Tue, 7 Aug 2012 09:55:55 +0100 Commit [c48a11c7: netvm: propagate page-pfmemalloc to skb] is responsible for

Re: [PATCH] x86/mm: stop allocating pmd page if failed

2012-07-25 Thread Jeremy Fitzhardinge
On 07/24/2012 06:15 AM, Yuanhan Liu wrote: > The old code would call __get_free_page() even though previous > allocation fail met. This is not needed. Yeah, I guess, but its hardly worth changing. J > > Signed-off-by: Yuanhan Liu > Cc: Jeremy Fitzhardinge > Cc: Tho

Re: [PATCH] x86/mm: stop allocating pmd page if failed

2012-07-25 Thread Jeremy Fitzhardinge
On 07/24/2012 06:15 AM, Yuanhan Liu wrote: The old code would call __get_free_page() even though previous allocation fail met. This is not needed. Yeah, I guess, but its hardly worth changing. J Signed-off-by: Yuanhan Liu yliu.n...@gmail.com Cc: Jeremy Fitzhardinge jer...@goop.org Cc

Re: 2.6.25-rc1 xen pvops regression

2008-02-26 Thread Jeremy Fitzhardinge
Mark McLoughlin wrote: @@ -371,6 +372,9 @@ void __init dmi_scan_machine(void) } } else { + if (e820_all_mapped(0xF, 0xF+0x1, E820_RAM)) + goto out; One issue with using the e820 map for this is that a

Re: 2.6.25-rc1 xen pvops regression

2008-02-26 Thread Jeremy Fitzhardinge
Mark McLoughlin wrote: @@ -371,6 +372,9 @@ void __init dmi_scan_machine(void) } } else { + if (e820_all_mapped(0xF, 0xF+0x1, E820_RAM)) + goto out; One issue with using the e820 map for this is that a

Re: compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: Jeremy, you might want to start tracking x86.git#testing: http://people.redhat.com/mingo/x86.git/README if you want to follow the latest & greatest x86.git code. Right, will do. J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: * Vegard Nossum <[EMAIL PROTECTED]> wrote: asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for kmemcheck" should have added the file. Hm. This is x86#testing, no? I don't think there's

compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
CC arch/x86/kernel/traps_32.o /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 "x86: add hooks for

compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
CC arch/x86/kernel/traps_32.o /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/traps_32.c:59:27: error: asm/kmemcheck.h: No such file or directory asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 x86: add hooks for kmemcheck

Re: compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: * Vegard Nossum [EMAIL PROTECTED] wrote: asm-x86/kmemcheck.h does seem to be completely missing. Looks like 8db0acefb3025795abe3f37669354677a03de680 x86: add hooks for kmemcheck should have added the file. Hm. This is x86#testing, no? I don't think there's any

Re: compile problem in current x86.git

2008-02-25 Thread Jeremy Fitzhardinge
Ingo Molnar wrote: Jeremy, you might want to start tracking x86.git#testing: http://people.redhat.com/mingo/x86.git/README if you want to follow the latest greatest x86.git code. Right, will do. J -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver

2008-02-22 Thread Jeremy Fitzhardinge
Markus Armbruster wrote: Jeremy Fitzhardinge <[EMAIL PROTECTED]> writes: Markus Armbruster wrote: This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: Jeremy Fitzhardinge wrote: Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: This isn't a problem with things like "Signed-off-by:" etc tags, because they have no automated meaning and don't really change the commit itself, but the "From:"/"Date:"/"Subject:" markers at the head of the message really do have real meaning, and get removed from the

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity, and it only gets tested rarely. Chris Wright did spend some time on it

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: As paravirtualized xen guests won't work with !X86_PAE, change the Kconfig accordingly. !PAE is supposed to work, but it is a rarely used configuration. How does it fail? J -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: As paravirtualized xen guests won't work with !X86_PAE, change the Kconfig accordingly. !PAE is supposed to work, but it is a rarely used configuration. How does it fail? J -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity, and it only gets tested rarely. Chris Wright did spend some time on it

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-22 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: This isn't a problem with things like Signed-off-by: etc tags, because they have no automated meaning and don't really change the commit itself, but the From:/Date:/Subject: markers at the head of the message really do have real meaning, and get removed from the commit

Re: [Xen-devel] [PATCH] let XEN depend on PAE

2008-02-22 Thread Jeremy Fitzhardinge
Arnd Hannemann wrote: Jeremy Fitzhardinge wrote: Arnd Hannemann wrote: This is with 2.6.24.2, but latest-git looks the same: I also tried with 2.6.23 which crashes instantly, without any output of the guest. I'm not too surprised. Non-PAE Xen is a bit of a rarity

Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver

2008-02-22 Thread Jeremy Fitzhardinge
Markus Armbruster wrote: Jeremy Fitzhardinge [EMAIL PROTECTED] writes: Markus Armbruster wrote: This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and mouse. Unless

Re: 2.6.25-rc1 xen pvops regression

2008-02-21 Thread Jeremy Fitzhardinge
H. Peter Anvin wrote: Jeremy Fitzhardinge wrote: It seems to me that those pages are being handed out as heap pages by the early allocator. In the Xen case this is OK because there's nothing magic about them. But if real hardware doesn't reserve these pages in the E820 map

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: OK. Have you fixed it, or shall I resend? I'll fix it, but I want people to know so that I don't have to fix things like this in the future (*). Linus (*) I keed, I keed. Of *course

Re: 2.6.25-rc1 xen pvops regression

2008-02-21 Thread Jeremy Fitzhardinge
H. Peter Anvin wrote: Still curious about why a pagetable page is ending up in that range though. Seems like it shouldn't be possible, since we shouldn't be allowed to allocate from those pages, at least until the DMI probe has happened... Unless the early allocator is only excluded from

Re: 2.6.25-rc1 xen pvops regression

2008-02-21 Thread Jeremy Fitzhardinge
Ian Campbell wrote: I'll see if I can track down where the page is getting used and have a go at getting in there first. It must be pretty early to be allocated already when dmi_scan_machine gets called. It's possible that the domain builder might have already allocated a PT at this address. I

Re: [PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
Linus Torvalds wrote: On Thu, 21 Feb 2008, Jeremy Fitzhardinge wrote: Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> From: Ian Campbell <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> This is just wrong. The From: goes at the

[PATCH] xen: Implement getgeo for Xen virtual block device.

2008-02-21 Thread Jeremy Fitzhardinge
around the place. Signed-off-by: Ian Campbell <[EMAIL PROTECTED]> From: Ian Campbell <[EMAIL PROTECTED]> Signed-off-by: Jeremy Fitzhardinge <[EMAIL PROTECTED]> --- drivers/block/xen-blkfront.c | 18 ++ 1 file chan

Re: [PATCH 2/2] xen pvfb: Para-virtual framebuffer, keyboard and pointer driver

2008-02-21 Thread Jeremy Fitzhardinge
Markus Armbruster wrote: This is a pair of Xen para-virtual frontend device drivers: drivers/video/xen-fbfront.c provides a framebuffer, and drivers/input/xen-kbdfront provides keyboard and mouse. Unless they're actually inter-dependent, could you post this as two separate patches? I

Re: [PATCH 0/2] xen pvfb: Para-virtual framebuffer, keyboard and pointer

2008-02-21 Thread Jeremy Fitzhardinge
Markus Armbruster wrote: Forgot to mention: This patch depends on Subject: [PATCH] xen: Make xen-blkfront write its protocol ABI to xenstore From: Markus Armbruster <> Date: Thu, 06 Dec 2007 14:45:53 +0100 http://lkml.org/lkml/2007/12/6/132 Sorry! Sorry, I haven't pushed this

Re: [PATCH 03/11] xen: add missing definitions for xen grant table which ia64/xen needs.

2008-02-21 Thread Jeremy Fitzhardinge
[EMAIL PROTECTED] wrote: Yep. We removed the guest handle stuff for the initial upstreaming, since it isn't necessary on x86 and it quietened some of the reviewer noise. But I expected we'd need to reintroduce it at some stage. J -- To unsubscribe from this list: send the line

Re: [PATCH 06/11] xen: move arch/x86/xen/events.c undedr drivers/xen and split out arch specific part.

2008-02-21 Thread Jeremy Fitzhardinge
[EMAIL PROTECTED] wrote: diff --git a/arch/x86/xen/events.c b/drivers/xen/events.c similarity index 95% rename from arch/x86/xen/events.c rename to drivers/xen/events.c index dcf613e..7474739 100644 --- a/arch/x86/xen/events.c +++ b/drivers/xen/events.c @@ -37,7 +37,9 @@ #include #include

  1   2   3   4   5   6   7   8   9   10   >