Re: [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference

2015-11-24 Thread Josh Wu
Hi, Corentin On 11/24/2015 9:12 PM, LABBE Corentin wrote: On Fri, Nov 20, 2015 at 04:33:14PM +0800, Josh Wu wrote: Hi, Corentin Thanks for the patch. It looks fine to me, just one nitpick in below: On 11/20/2015 3:45 PM, LABBE Corentin wrote: of_match_device could return NULL, and so cause

Re: [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference

2015-11-24 Thread Josh Wu
Hi, Corentin On 11/24/2015 9:12 PM, LABBE Corentin wrote: On Fri, Nov 20, 2015 at 04:33:14PM +0800, Josh Wu wrote: Hi, Corentin Thanks for the patch. It looks fine to me, just one nitpick in below: On 11/20/2015 3:45 PM, LABBE Corentin wrote: of_match_device could return NULL, and so cause

Re: [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference

2015-11-20 Thread Josh Wu
if (!host->caps) + return 1; it's better to use -EINVAL here. Best Regards, Josh Wu if (of_property_read_u32(np, "atmel,nand-addr-offset", ) == 0) { if (val >= 32) { -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps structures

2015-11-20 Thread Josh Wu
Hi, Corentin Thanks for the patch. On 11/20/2015 3:45 PM, LABBE Corentin wrote: All atmel_nand_caps are never modified, consitify them. Signed-off-by: LABBE Corentin Acked-by: Josh Wu Best Regards, Josh Wu --- drivers/mtd/nand/atmel_nand.c | 6 +++--- 1 file changed, 3 insertions

Re: [PATCH v2 1/2] mtd: nand: atmel_nand: constify atmel_nand_caps structures

2015-11-20 Thread Josh Wu
Hi, Corentin Thanks for the patch. On 11/20/2015 3:45 PM, LABBE Corentin wrote: All atmel_nand_caps are never modified, consitify them. Signed-off-by: LABBE Corentin <clabbe.montj...@gmail.com> Acked-by: Josh Wu <josh...@atmel.com> Best Regards, Josh Wu --- drivers/mtd/nand/

Re: [PATCH v2 2/2] mtd: nand: atmel_nand: fix a possible NULL dereference

2015-11-20 Thread Josh Wu
_match_data(host->dev); + if (!host->caps) + return 1; it's better to use -EINVAL here. Best Regards, Josh Wu if (of_property_read_u32(np, "atmel,nand-addr-offset", ) == 0) { if (val >= 32) { -- To unsubscribe from this list: send the lin

[PATCH v2 2/5] media: atmel-isi: prepare for the support of preview path

2015-11-02 Thread Josh Wu
Atmel ISI support a preview path which can output RGB data. So this patch introduces a bool variable to choose which path is enabled currently. And also we need setup corresponding path registers. By default the preview path is disabled. We only use Codec path. Signed-off-by: Josh Wu

[PATCH v2 0/5] media: atmel-isi: enable preview path to output RGB565 format

2015-11-02 Thread Josh Wu
() function which only used once. Also move the code into the for loop. Josh Wu (5): media: atmel-isi: correct yuv swap according to different sensor outputs media: atmel-isi: prepare for the support of preview path media: atmel-isi: add code to setup correct resolution for preview path

[PATCH v2 3/5] media: atmel-isi: add code to setup correct resolution for preview path

2015-11-02 Thread Josh Wu
Not like codec path, preview path can do downsampling, so we should setup a extra preview width, height for it. This patch add preview resolution setup without down sampling. So currently preview path will output same size as sensor output size. Signed-off-by: Josh Wu --- Changes in v2: None

[PATCH v2 5/5] media: atmel-isi: support RGB565 output when sensor output YUV formats

2015-11-02 Thread Josh Wu
This patch enable Atmel ISI preview path to convert the YUV to RGB format. Signed-off-by: Josh Wu --- Changes in v2: - According to Guennadi's suggestion, remove the is_output_rgb() function which only used once. Also move the code into the for loop. drivers/media/platform/soc_camera/atmel

[PATCH v2 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs

2015-11-02 Thread Josh Wu
output a pass-through formats, which means no swap. Just setup YCC_SWAP as default with no swap. Signed-off-by: Josh Wu --- Changes in v2: - remove the duplicated variable: cfg2_yuv_swap. drivers/media/platform/soc_camera/atmel-isi.c | 39 --- 1 file changed, 29

[PATCH v2 4/5] media: atmel-isi: setup YCC_SWAP correctly when using preview path

2015-11-02 Thread Josh Wu
The preview path only can convert UYVY format to RGB data. To make preview path work correctly, we need to set up YCC_SWAP according to sensor output and convert them to UYVY. Signed-off-by: Josh Wu --- Changes in v2: - remove cfg2_yuv_swap for rgb format - correct the comment style drivers

[PATCH v2 1/5] media: atmel-isi: correct yuv swap according to different sensor outputs

2015-11-02 Thread Josh Wu
output a pass-through formats, which means no swap. Just setup YCC_SWAP as default with no swap. Signed-off-by: Josh Wu <josh...@atmel.com> --- Changes in v2: - remove the duplicated variable: cfg2_yuv_swap. drivers/media/platform/soc_camera/atmel-isi.c | 39

[PATCH v2 3/5] media: atmel-isi: add code to setup correct resolution for preview path

2015-11-02 Thread Josh Wu
Not like codec path, preview path can do downsampling, so we should setup a extra preview width, height for it. This patch add preview resolution setup without down sampling. So currently preview path will output same size as sensor output size. Signed-off-by: Josh Wu <josh...@atmel.

[PATCH v2 4/5] media: atmel-isi: setup YCC_SWAP correctly when using preview path

2015-11-02 Thread Josh Wu
The preview path only can convert UYVY format to RGB data. To make preview path work correctly, we need to set up YCC_SWAP according to sensor output and convert them to UYVY. Signed-off-by: Josh Wu <josh...@atmel.com> --- Changes in v2: - remove cfg2_yuv_swap for rgb format - c

[PATCH v2 5/5] media: atmel-isi: support RGB565 output when sensor output YUV formats

2015-11-02 Thread Josh Wu
This patch enable Atmel ISI preview path to convert the YUV to RGB format. Signed-off-by: Josh Wu <josh...@atmel.com> --- Changes in v2: - According to Guennadi's suggestion, remove the is_output_rgb() function which only used once. Also move the code into the for loop. drivers

[PATCH v2 2/5] media: atmel-isi: prepare for the support of preview path

2015-11-02 Thread Josh Wu
Atmel ISI support a preview path which can output RGB data. So this patch introduces a bool variable to choose which path is enabled currently. And also we need setup corresponding path registers. By default the preview path is disabled. We only use Codec path. Signed-off-by: Josh Wu <j

[PATCH v2 0/5] media: atmel-isi: enable preview path to output RGB565 format

2015-11-02 Thread Josh Wu
() function which only used once. Also move the code into the for loop. Josh Wu (5): media: atmel-isi: correct yuv swap according to different sensor outputs media: atmel-isi: prepare for the support of preview path media: atmel-isi: add code to setup correct resolution for preview path

[PATCH 2/4] v4l2-clk: add new macro for v4l2_clk_name_of()

2015-10-28 Thread Josh Wu
This macro is used to generate a OF string for a v4l2 clock. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/soc_camera.c | 4 ++-- include/media/v4l2-clk.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH 4/4] v4l2-clk: v4l2_clk_get() also need to find the of_fullname clock

2015-10-28 Thread Josh Wu
-0030". This patch will search the clock with OF string name if fail to find the clock with I2C string name. Signed-off-by: Josh Wu --- drivers/media/v4l2-core/v4l2-clk.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-clk.c b/drivers/media/v4l2-core/

[PATCH 3/4] v4l2-clk: add new definition: V4L2_CLK_NAME_SIZE

2015-10-28 Thread Josh Wu
Make all v4l2-clk's clock name use V4L2_CLK_NAME_SIZE definition. In future, if the string increased we just need to change the V4L2_CLK_NAME_SIZE once. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/soc_camera.c | 6 +++--- drivers/media/usb/em28xx/em28xx-camera.c | 2

[PATCH 1/4] soc_camera: get the clock name by using macro: v4l2_clk_name_i2c()

2015-10-28 Thread Josh Wu
Since v4l2_clk_name_i2c() is defined, so just reuse it. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/soc_camera.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform

[PATCH 0/4] soc-camera: fix the bug which will fail to search the registered v4l2-clk

2015-10-28 Thread Josh Wu
This patch set will fix a bug in soc-camera, which will fail to search the v4l2-clk if the i2c sensor is probed later than soc-camera host. It also add some clean up for v4l2-clk code and usage. Josh Wu (4): soc_camera: get the clock name by using macro: v4l2_clk_name_i2c() v4l2-clk: add

[PATCH 0/4] soc-camera: fix the bug which will fail to search the registered v4l2-clk

2015-10-28 Thread Josh Wu
This patch set will fix a bug in soc-camera, which will fail to search the v4l2-clk if the i2c sensor is probed later than soc-camera host. It also add some clean up for v4l2-clk code and usage. Josh Wu (4): soc_camera: get the clock name by using macro: v4l2_clk_name_i2c() v4l2-clk: add

[PATCH 1/4] soc_camera: get the clock name by using macro: v4l2_clk_name_i2c()

2015-10-28 Thread Josh Wu
Since v4l2_clk_name_i2c() is defined, so just reuse it. Signed-off-by: Josh Wu <josh...@atmel.com> --- drivers/media/platform/soc_camera/soc_camera.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers

[PATCH 4/4] v4l2-clk: v4l2_clk_get() also need to find the of_fullname clock

2015-10-28 Thread Josh Wu
-0030". This patch will search the clock with OF string name if fail to find the clock with I2C string name. Signed-off-by: Josh Wu <josh...@atmel.com> --- drivers/media/v4l2-core/v4l2-clk.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-clk.c b/dr

[PATCH 2/4] v4l2-clk: add new macro for v4l2_clk_name_of()

2015-10-28 Thread Josh Wu
This macro is used to generate a OF string for a v4l2 clock. Signed-off-by: Josh Wu <josh...@atmel.com> --- drivers/media/platform/soc_camera/soc_camera.c | 4 ++-- include/media/v4l2-clk.h | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 3/4] v4l2-clk: add new definition: V4L2_CLK_NAME_SIZE

2015-10-28 Thread Josh Wu
Make all v4l2-clk's clock name use V4L2_CLK_NAME_SIZE definition. In future, if the string increased we just need to change the V4L2_CLK_NAME_SIZE once. Signed-off-by: Josh Wu <josh...@atmel.com> --- drivers/media/platform/soc_camera/soc_camera.c | 6 +++--- drivers/media/usb/em28xx/

Re: [PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property

2015-09-20 Thread Josh Wu
Hi, Nicolas On 9/18/2015 10:09 PM, Nicolas Ferre wrote: Le 18/09/2015 13:28, Josh Wu a écrit : On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel connection for ov2640. So we must set the hsync/vsync property (1 means active high). Otherwise, the connection would be seen

Re: [PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property

2015-09-20 Thread Josh Wu
Hi, Nicolas On 9/18/2015 10:09 PM, Nicolas Ferre wrote: Le 18/09/2015 13:28, Josh Wu a écrit : On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel connection for ov2640. So we must set the hsync/vsync property (1 means active high). Otherwise, the connection would be seen

[PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property

2015-09-18 Thread Josh Wu
On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel connection for ov2640. So we must set the hsync/vsync property (1 means active high). Otherwise, the connection would be seen as BT.656 or BT.1120. Signed-off-by: Josh Wu --- arch/arm/boot/dts/at91sam9m10g45ek.dts | 2

Re: [PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-09-18 Thread Josh Wu
. Best Regards, Josh Wu Thanks Guennadi On Tue, 4 Aug 2015, Josh Wu wrote: Since in soc_of_bind() it may use the of node's full name as the clk_name, and this full name may be longer than 32 characters, take at91 i2c sensor as an example, length is 34 bytes: /ahb/apb/i2c@f8028000/camera

[PATCH] ARM: at91/dt: ov2640: add hsync/vsync-active property

2015-09-18 Thread Josh Wu
On at91sam9x5ek/at91sam9m10g45ek/sama5d3xek boards, we use the parallel connection for ov2640. So we must set the hsync/vsync property (1 means active high). Otherwise, the connection would be seen as BT.656 or BT.1120. Signed-off-by: Josh Wu <josh...@atmel.com> --- arch/arm/bo

Re: [PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-09-18 Thread Josh Wu
. Best Regards, Josh Wu Thanks Guennadi On Tue, 4 Aug 2015, Josh Wu wrote: Since in soc_of_bind() it may use the of node's full name as the clk_name, and this full name may be longer than 32 characters, take at91 i2c sensor as an example, length is 34 bytes: /ahb/apb/i2c@f8028000/camera

Re: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning

2015-09-06 Thread Josh Wu
: ‘atmel_isi_runtime_resume’ defined but not used Protect the unused functions by #ifdef CONFIG_PM to fix this. Signed-off-by: Geert Uytterhoeven Acked-by: Josh Wu Best Regards, Josh Wu --- Resend with correct suject --- drivers/media/platform/soc_camera/atmel-isi.c | 2 ++ 1 file changed, 2

Re: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning

2015-09-06 Thread Josh Wu
: ‘atmel_isi_runtime_resume’ defined but not used Protect the unused functions by #ifdef CONFIG_PM to fix this. Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> Acked-by: Josh Wu <josh...@atmel.com> Best Regards, Josh Wu --- Resend with correct suject --- drivers/me

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-31 Thread Josh Wu
Hi, Guennadi Thanks for the review. On 8/30/2015 4:48 PM, Guennadi Liakhovetski wrote: Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-31 Thread Josh Wu
Hi, Guennadi Thanks for the review. On 8/30/2015 4:48 PM, Guennadi Liakhovetski wrote: Hi Josh, On Wed, 17 Jun 2015, Josh Wu wrote: In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register

Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-24 Thread Josh Wu
Hi, Laurent On 8/22/2015 2:22 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type

Re: [PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-24 Thread Josh Wu
Hi, Laurent On 8/22/2015 2:22 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Friday 21 August 2015 16:08:14 Josh Wu wrote: After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type

[PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Josh Wu
After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Changes in v3: - check the whether format is supported, if no then return a default format. - misc changes

[PATCH v3 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-21 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu Reviewed

[PATCH v3 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-21 Thread Josh Wu
. Signed-off-by: Josh Wu Reviewed-by: Laurent Pinchart --- Changes in v3: None Changes in v2: - add Laurent's reviewed-by tag. drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera

[PATCH v3 3/3] media: atmel-isi: add sanity check for supported formats in try/set_fmt()

2015-08-21 Thread Josh Wu
After adding the format check in try_fmt()/set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu josh...@atmel.com --- Changes in v3: - check the whether format is supported, if no then return a default format

[PATCH v3 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-21 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu josh

[PATCH v3 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-21 Thread Josh Wu
. Signed-off-by: Josh Wu josh...@atmel.com Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Changes in v3: None Changes in v2: - add Laurent's reviewed-by tag. drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Thanks for the review. On 8/21/2015 2:30 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Wednesday 05 August 2015 11:26:29 Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Could you have time to review this patch? so that I can send a pull request with your reviewed-by tags. Best Regards, Josh Wu On 8/5/2015 11:26 AM, Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Could you have time to review this patch? so that I can send a pull request with your reviewed-by tags. Best Regards, Josh Wu On 8/5/2015 11:26 AM, Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make

Re: [PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-20 Thread Josh Wu
Hi, Laurent Thanks for the review. On 8/21/2015 2:30 AM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Wednesday 05 August 2015 11:26:29 Josh Wu wrote: After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make

[PATCH v2 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-04 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu Reviewed

[PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-04 Thread Josh Wu
After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu --- Changes in v2: - new added patch drivers/media/platform/soc_camera/atmel-isi.c | 39 +-- 1 file

[PATCH v2 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-04 Thread Josh Wu
. Signed-off-by: Josh Wu Reviewed-by: Laurent Pinchart --- Changes in v2: - add Laurent's reviewed-by tag. drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b

[PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-08-04 Thread Josh Wu
so far. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/soc_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c index d708df4..fcf3e97 100644 --- a/drivers/media

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-04 Thread Josh Wu
Hi, Laurent On 8/3/2015 9:27 PM, Laurent Pinchart wrote: Hi Josh, On Monday 03 August 2015 11:56:01 Josh Wu wrote: On 7/31/2015 10:37 PM, Laurent Pinchart wrote: On Wednesday 17 June 2015 18:39:39 Josh Wu wrote: As in set_fmt() function we only need to know which format is been set, we

[PATCH] media: soc-camera: increase the length of clk_name on soc_of_bind()

2015-08-04 Thread Josh Wu
so far. Signed-off-by: Josh Wu josh...@atmel.com --- drivers/media/platform/soc_camera/soc_camera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/soc_camera/soc_camera.c b/drivers/media/platform/soc_camera/soc_camera.c index d708df4..fcf3e97 100644

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-04 Thread Josh Wu
Hi, Laurent On 8/3/2015 9:27 PM, Laurent Pinchart wrote: Hi Josh, On Monday 03 August 2015 11:56:01 Josh Wu wrote: On 7/31/2015 10:37 PM, Laurent Pinchart wrote: On Wednesday 17 June 2015 18:39:39 Josh Wu wrote: As in set_fmt() function we only need to know which format is been set, we

[PATCH v2 2/3] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-04 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu josh

[PATCH v2 3/3] media: atmel-isi: add sanity check for supported formats in set_fmt()

2015-08-04 Thread Josh Wu
After adding the format check in set_fmt(), we don't need any format check in configure_geometry(). So make configure_geometry() as void type. Signed-off-by: Josh Wu josh...@atmel.com --- Changes in v2: - new added patch drivers/media/platform/soc_camera/atmel-isi.c | 39

[PATCH v2 1/3] media: atmel-isi: setup the ISI_CFG2 register directly

2015-08-04 Thread Josh Wu
. Signed-off-by: Josh Wu josh...@atmel.com Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Changes in v2: - add Laurent's reviewed-by tag. drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git

Re: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux

2015-08-03 Thread Josh Wu
(PIN_PB24, 6, 3) As sama5d2 use ISC, so It's better to run s/ISI_/ISC_/ in this file, which is consistent with the datasheet. Best Regards, Josh Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [RFC PATCH 2/3] ARM: at91/dt: add sama5d2 pinmux

2015-08-03 Thread Josh Wu
PIN_PB24__ISI_D10 PINMUX_PIN(PIN_PB24, 6, 3) As sama5d2 use ISC, so It's better to run s/ISI_/ISC_/ in this file, which is consistent with the datasheet. Best Regards, Josh Wu -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-02 Thread Josh Wu
HI, Laurent On 7/31/2015 10:37 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Wednesday 17 June 2015 18:39:39 Josh Wu wrote: As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move

Re: [PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-08-02 Thread Josh Wu
HI, Laurent On 7/31/2015 10:37 PM, Laurent Pinchart wrote: Hi Josh, Thank you for the patch. On Wednesday 17 June 2015 18:39:39 Josh Wu wrote: As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-07-30 Thread Josh Wu
Hi, list Ping..., any feedback for this series? Best Regards, Josh Wu On 6/17/2015 6:39 PM, Josh Wu wrote: In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register and just set part of it. So

Re: [PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-07-30 Thread Josh Wu
Hi, list Ping..., any feedback for this series? Best Regards, Josh Wu On 6/17/2015 6:39 PM, Josh Wu wrote: In the function configure_geometry(), we will setup the ISI CFG2 according to the sensor output format. It make no sense to just read back the CFG2 register and just set part of it. So

Re: [PATCH v2 2/2] ARM: at91: at91_dt_defconfig: enable ISI and ov2640 support

2015-07-28 Thread Josh Wu
On 7/28/2015 3:37 PM, Nicolas Ferre wrote: Le 16/06/2015 12:08, Josh Wu a écrit : Add Atmel-isi and ov2640 driver in defconfig Signed-off-by: Josh Wu --- Changes in v2: None arch/arm/configs/at91_dt_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm/configs

Re: [PATCH v2 2/2] ARM: at91: at91_dt_defconfig: enable ISI and ov2640 support

2015-07-28 Thread Josh Wu
On 7/28/2015 3:37 PM, Nicolas Ferre wrote: Le 16/06/2015 12:08, Josh Wu a écrit : Add Atmel-isi and ov2640 driver in defconfig Signed-off-by: Josh Wu josh...@atmel.com --- Changes in v2: None arch/arm/configs/at91_dt_defconfig | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch

[PATCH v2 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string

2015-07-20 Thread Josh Wu
They'll use "atmel,sama5d3-rstc" for reset function. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu --- Changes in v2: None arch/arm/boot/dts/sama5d3.dtsi | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/ar

[PATCH v2 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
al driving the bus, but since sama5d3 and later chips there is no such a conflict. So in this patch: 1. the sama5d3 reset function only need to write the rstc register and return. 2. we can remove the code related with sama5d3 DDR controller as we don't use it at all. Signed-off-by: Josh

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:44 PM, Josh Wu wrote: On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200

[PATCH v2 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
the bus, but since sama5d3 and later chips there is no such a conflict. So in this patch: 1. the sama5d3 reset function only need to write the rstc register and return. 2. we can remove the code related with sama5d3 DDR controller as we don't use it at all. Signed-off-by: Josh Wu josh

[PATCH v2 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string

2015-07-20 Thread Josh Wu
They'll use atmel,sama5d3-rstc for reset function. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu josh...@atmel.com --- Changes in v2: None arch/arm/boot/dts/sama5d3.dtsi | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
On 7/20/2015 4:44 PM, Josh Wu wrote: On 7/20/2015 4:35 PM, Josh Wu wrote: Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-20 Thread Josh Wu
Hi, Maxime On 7/20/2015 3:52 PM, Maxime Ripard wrote: Hi Josh, On Mon, Jul 13, 2015 at 11:21:44AM +0800, Josh Wu wrote: On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-12 Thread Josh Wu
On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : I would agree with Maxime. Currently all latest chip reset function is compatible

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-12 Thread Josh Wu
On 7/11/2015 12:12 AM, Nicolas Ferre wrote: Le 10/07/2015 14:31, Maxime Ripard a écrit : On Fri, Jul 10, 2015 at 02:09:07PM +0200, Alexandre Belloni wrote: Hi, On 10/07/2015 at 15:56:52 +0800, Josh Wu wrote : I would agree with Maxime. Currently all latest chip reset function is compatible

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
On 7/10/2015 2:54 PM, Maxime Ripard wrote: On Fri, Jul 10, 2015 at 11:06:52AM +0800, Josh Wu wrote: Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
Hi, Alexandre On 7/10/2015 2:03 PM, Alexandre Belloni wrote: Hi, On 09/07/2015 at 18:15:46 +0800, Josh Wu wrote : As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
Hi, Alexandre On 7/10/2015 2:03 PM, Alexandre Belloni wrote: Hi, On 09/07/2015 at 18:15:46 +0800, Josh Wu wrote : As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-10 Thread Josh Wu
On 7/10/2015 2:54 PM, Maxime Ripard wrote: On Fri, Jul 10, 2015 at 11:06:52AM +0800, Josh Wu wrote: Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 11:14 AM, Guenter Roeck wrote: On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote: Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't

[PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't use sama5d3 ddr controller, so remove it as well. Signed-off-by: Josh Wu Acked-by: Nicolas Ferre --- drivers

[PATCH 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string

2015-07-09 Thread Josh Wu
They'll use "atmel,sama5d3-rstc" for reset function. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu --- arch/arm/boot/dts/sama5d3.dtsi | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sama5d3.dtsi

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Maxime On 7/9/2015 8:03 PM, Maxime Ripard wrote: Hi, On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we

Re: [PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
Hi, Guenter On 7/10/2015 11:14 AM, Guenter Roeck wrote: On Fri, Jul 10, 2015 at 09:59:53AM +0800, Josh Wu wrote: Hi, Guenter On 7/10/2015 1:37 AM, Guenter Roeck wrote: On Thu, Jul 09, 2015 at 06:15:46PM +0800, Josh Wu wrote: As since sama5d3, to reset the chip, we don't need to shutdown

[PATCH 2/2] ARM: at91: sama5/dt: update rstc to correct compatible string

2015-07-09 Thread Josh Wu
They'll use atmel,sama5d3-rstc for reset function. Cc: devicet...@vger.kernel.org Signed-off-by: Josh Wu josh...@atmel.com --- arch/arm/boot/dts/sama5d3.dtsi | 2 +- arch/arm/boot/dts/sama5d4.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/sama5d3

[PATCH 1/2] power: reset: at91: add sama5d3 reset function

2015-07-09 Thread Josh Wu
As since sama5d3, to reset the chip, we don't need to shutdown the ddr controller. So add a new compatible string and new restart function for sama5d3 and later chips. As we don't use sama5d3 ddr controller, so remove it as well. Signed-off-by: Josh Wu josh...@atmel.com Acked-by: Nicolas Ferre

[PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-06-17 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu --- drivers

[PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-06-17 Thread Josh Wu
. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 9070172..8bc40ca 100644

[PATCH] media: atmel-isi: increase timeout to disable/enable isi

2015-06-17 Thread Josh Wu
If ISI is working on a 1024x768 or higher resolution, it needs longer time to disable ISI. So this patch will increase timeout to 500ms. Signed-off-by: Josh Wu --- drivers/media/platform/soc_camera/atmel-isi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media

[PATCH 1/2] media: atmel-isi: setup the ISI_CFG2 register directly

2015-06-17 Thread Josh Wu
. Signed-off-by: Josh Wu josh...@atmel.com --- drivers/media/platform/soc_camera/atmel-isi.c | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 9070172

[PATCH] media: atmel-isi: increase timeout to disable/enable isi

2015-06-17 Thread Josh Wu
If ISI is working on a 1024x768 or higher resolution, it needs longer time to disable ISI. So this patch will increase timeout to 500ms. Signed-off-by: Josh Wu josh...@atmel.com --- drivers/media/platform/soc_camera/atmel-isi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 2/2] media: atmel-isi: move configure_geometry() to start_streaming()

2015-06-17 Thread Josh Wu
As in set_fmt() function we only need to know which format is been set, we don't need to access the ISI hardware in this moment. So move the configure_geometry(), which access the ISI hardware, to start_streaming() will make code more consistent and simpler. Signed-off-by: Josh Wu josh

  1   2   3   >