We no longer clear kn->priv in cgroup_rmdir(), so we don't need
to get an extra refcnt.
Signed-off-by: Zefan Li
---
kernel/cgroup.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 0ce9d9e..26b8cb9 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
Currently we use a global work to schedule release agent on removable
cgroups. We can change to reuse css->destroy_work to do this, which
saves a few lines of code.
Signed-off-by: Zefan Li
---
include/linux/cgroup.h | 7
kernel/cgroup.c| 108
We never grab cgroup mutex in fork and exit paths no matter whether
notify_on_release is set or not.
Signed-off-by: Zefan Li
---
kernel/cgroup.c | 8
1 file changed, 8 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 26b8cb9..1abb554 100644
--- a/kernel/cgroup.c
+++
Signed-off-by: Zefan Li
---
include/linux/cgroup.h | 1 -
kernel/cgroup.c| 2 --
2 files changed, 3 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b5223c5..f7898e0 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -27,7 +27,6 @@
On 2014/9/17 13:29, Li Zefan wrote:
> On 2014/9/17 7:56, Cong Wang wrote:
>> Hi, Tejun
>>
>>
>> We saw some kernel null pointer dereference in
>> cgroup_pidlist_destroy_work_fn(), more precisely at
>> __mutex_lock_slowpath(), on 3.14. I can show you the full
On 2014/9/17 13:29, Li Zefan wrote:
On 2014/9/17 7:56, Cong Wang wrote:
Hi, Tejun
We saw some kernel null pointer dereference in
cgroup_pidlist_destroy_work_fn(), more precisely at
__mutex_lock_slowpath(), on 3.14. I can show you the full stack trace
on request.
Yes, please.
Looking
Signed-off-by: Zefan Li lize...@huawei.com
---
include/linux/cgroup.h | 1 -
kernel/cgroup.c| 2 --
2 files changed, 3 deletions(-)
diff --git a/include/linux/cgroup.h b/include/linux/cgroup.h
index b5223c5..f7898e0 100644
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@
We never grab cgroup mutex in fork and exit paths no matter whether
notify_on_release is set or not.
Signed-off-by: Zefan Li lize...@huawei.com
---
kernel/cgroup.c | 8
1 file changed, 8 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 26b8cb9..1abb554 100644
---
We no longer clear kn-priv in cgroup_rmdir(), so we don't need
to get an extra refcnt.
Signed-off-by: Zefan Li lize...@huawei.com
---
kernel/cgroup.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 0ce9d9e..26b8cb9 100644
--- a/kernel/cgroup.c
+++
Currently we use a global work to schedule release agent on removable
cgroups. We can change to reuse css-destroy_work to do this, which
saves a few lines of code.
Signed-off-by: Zefan Li lize...@huawei.com
---
include/linux/cgroup.h | 7
kernel/cgroup.c| 108
On 2014/9/17 7:56, Cong Wang wrote:
> Hi, Tejun
>
>
> We saw some kernel null pointer dereference in
> cgroup_pidlist_destroy_work_fn(), more precisely at
> __mutex_lock_slowpath(), on 3.14. I can show you the full stack trace
> on request.
>
Yes, please.
> Looking at the code, it seems
On 2014/9/17 7:56, Cong Wang wrote:
Hi, Tejun
We saw some kernel null pointer dereference in
cgroup_pidlist_destroy_work_fn(), more precisely at
__mutex_lock_slowpath(), on 3.14. I can show you the full stack trace
on request.
Yes, please.
Looking at the code, it seems
I think this is the same bug as the one you reported recently, which
has been fixed in mainline.
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a4189487da1b4f8260c6006b9dc47c3c4107a5ae
On 2014/9/13 0:19, Toralf Förster wrote:
> Today I observed within a 32 bit KVM
I think this is the same bug as the one you reported recently, which
has been fixed in mainline.
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a4189487da1b4f8260c6006b9dc47c3c4107a5ae
On 2014/9/13 0:19, Toralf Förster wrote:
Today I observed within a 32 bit KVM
On 2014/9/5 21:58, Guenter Roeck wrote:
> On 09/05/2014 12:55 AM, Li Zefan wrote:
>>>>> Li,
>>>>>
>>>>> it would be great if you can send me information about your -stable queue,
>>>>> ie how you maintain it and where it is located.
On 2014/9/5 21:58, Guenter Roeck wrote:
On 09/05/2014 12:55 AM, Li Zefan wrote:
Li,
it would be great if you can send me information about your -stable queue,
ie how you maintain it and where it is located. This will enable me to
continue testing the stable queue for the 3.4 kernel
>>> Li,
>>>
>>> it would be great if you can send me information about your -stable queue,
>>> ie how you maintain it and where it is located. This will enable me to
>>> continue testing the stable queue for the 3.4 kernel.
>>>
>>
>> Thanks for testing LTS kernels!
>>
>> This is my 3.4.y git tree:
Li,
it would be great if you can send me information about your -stable queue,
ie how you maintain it and where it is located. This will enable me to
continue testing the stable queue for the 3.4 kernel.
Thanks for testing LTS kernels!
This is my 3.4.y git tree:
Hi Guenter,
Sorry for my late reply.
On 2014/8/27 12:59, Guenter Roeck wrote:
> On Tue, Aug 26, 2014 at 04:08:58PM -0700, Greg KH wrote:
>> Li has agreed to continue to support the 3.4 stable kernel tree until
>> September 2016. Update the releases.html page on kernel.org to reflect
>> this.
>>
When cgroup_kn_lock_live() is called through some kernfs operation and
another thread is calling cgroup_rmdir(), we'll trigger the warning in
cgroup_get().
[ cut here ]
WARNING: CPU: 1 PID: 1228 at kernel/cgroup.c:1034 cgroup_get+0x89/0xa0()
...
Call Trace:
[]
Run these two scripts concurrently:
for ((; ;))
{
mkdir /cgroup/sub
rmdir /cgroup/sub
}
for ((; ;))
{
echo $$ > /cgroup/sub/cgroup.procs
echo $$ > /cgroup/cgroup.procs
}
A kernel bug will be triggered:
BUG: unable to handle kernel NULL
When cgroup_kn_lock_live() is called through some kernfs operation and
another thread is calling cgroup_rmdir(), we'll trigger the warning in
cgroup_get().
[ cut here ]
WARNING: CPU: 1 PID: 1228 at kernel/cgroup.c:1034 cgroup_get+0x89/0xa0()
...
Call Trace:
[c16ee73d]
Run these two scripts concurrently:
for ((; ;))
{
mkdir /cgroup/sub
rmdir /cgroup/sub
}
for ((; ;))
{
echo $$ /cgroup/sub/cgroup.procs
echo $$ /cgroup/cgroup.procs
}
A kernel bug will be triggered:
BUG: unable to handle kernel NULL
Hi Guenter,
Sorry for my late reply.
On 2014/8/27 12:59, Guenter Roeck wrote:
On Tue, Aug 26, 2014 at 04:08:58PM -0700, Greg KH wrote:
Li has agreed to continue to support the 3.4 stable kernel tree until
September 2016. Update the releases.html page on kernel.org to reflect
this.
Li,
于 2014/9/2 23:33, Tejun Heo 写道:
> Hello, Li.
>
> On Tue, Sep 02, 2014 at 06:56:58PM +0800, Li Zefan wrote:
>> for ((; ;))
>> {
>> echo $$ > /cgroup/sub/cgroup.procs
>> ech $$ > /cgce 6f2e0c38c2108a74 ]---
> ^^^
于 2014/9/2 23:33, Tejun Heo 写道:
Hello, Li.
On Tue, Sep 02, 2014 at 06:56:58PM +0800, Li Zefan wrote:
for ((; ;))
{
echo $$ /cgroup/sub/cgroup.procs
ech $$ /cgce 6f2e0c38c2108a74 ]---
copy paste error
/0x1e0
[] SyS_write+0x4d/0xa0
[] sysenter_do_call+0x12/0x12
---[ end trace 6f2e0c38c2108a74 ]---
Fix this by calling css_tryget() instead of cgroup_get().
Reported-by: Toralf Förster
Signed-off-by: Li Zefan
---
kernel/cgroup.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff
e to the cgroup and no one can gain a new
reference to access it.
Reported-by: Toralf Förster
Signed-off-by: Li Zefan
---
Toralf, Thanks for reporting the bug. I'm not able to repy to your email,
because I was kicked out of the cgroup mailing list so didn't receive
emails from mailing
to css_release_work_fn(). At that time
no one is holding reference to the cgroup and no one can gain a new
reference to access it.
Reported-by: Toralf Förster toralf.foers...@gmx.de
Signed-off-by: Li Zefan lize...@huawei.com
---
Toralf, Thanks for reporting the bug. I'm not able to repy to your email
...@gmx.de
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cgroup.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index e03fc62..c8d07e5 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1025,6 +1025,11 @@ static umode_t
On 2014/8/25 23:00, Dongsheng Yang wrote:
> On Mon, Aug 25, 2014 at 10:47 PM, Tejun Heo wrote:
>> On Mon, Aug 25, 2014 at 10:46:03PM +0800, Dongsheng Yang wrote:
>>> My point here is that attaching and detaching are a pair of operations.
>>
>> There is no detaching from a cgroup. A task is
On 2014/8/25 23:00, Dongsheng Yang wrote:
On Mon, Aug 25, 2014 at 10:47 PM, Tejun Heo t...@kernel.org wrote:
On Mon, Aug 25, 2014 at 10:46:03PM +0800, Dongsheng Yang wrote:
My point here is that attaching and detaching are a pair of operations.
There is no detaching from a cgroup. A task is
On 2014/8/12 5:05, David Rientjes wrote:
> On Mon, 11 Aug 2014, Vladimir Davydov wrote:
>
>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>>> --- a/mm/page_alloc.c
>>> +++ b/mm/page_alloc.c
>>> @@ -1963,7 +1963,7 @@ zonelist_scan:
>>>
>>> /*
>>> * Scan zonelist, looking for a zone
On 2014/8/12 5:05, David Rientjes wrote:
On Mon, 11 Aug 2014, Vladimir Davydov wrote:
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1963,7 +1963,7 @@ zonelist_scan:
/*
* Scan zonelist, looking for a zone with enough free.
-
The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.
Reported-by: Mike Qiu
Tested-by: Mike Qiu
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel
The WARN_ON() is used to check if we break the legal hierarchy, on
which the effective mems should be equal to configured mems.
Reported-by: Mike Qiu qiud...@linux.vnet.ibm.com
Tested-by: Mike Qiu qiud...@linux.vnet.ibm.com
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 2 +-
1
On 2014/7/29 3:20, Tejun Heo wrote:
> On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote:
>> On 2014/7/23 23:12, Tejun Heo wrote:
>>> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
>>>> commit 734d45130cb ("cpuset: update cs->effective
On 2014/7/29 3:20, Tejun Heo wrote:
On Thu, Jul 24, 2014 at 08:27:40AM +0800, Li Zefan wrote:
On 2014/7/23 23:12, Tejun Heo wrote:
On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config
changes) introduce the below
On 2014/7/23 23:12, Tejun Heo wrote:
> On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
>> commit 734d45130cb ("cpuset: update cs->effective_{cpus, mems} when config
>> changes") introduce the below warning in my server.
>>
>> [ 35.652137] [ cut here ]
>> [
On 2014/7/23 23:12, Tejun Heo wrote:
On Wed, Jul 23, 2014 at 10:50:29AM +0800, Mike Qiu wrote:
commit 734d45130cb (cpuset: update cs-effective_{cpus, mems} when config
changes) introduce the below warning in my server.
[ 35.652137] [ cut here ]
[ 35.652141]
2
> kernel/sched/cpuacct.c |2
> mm/hugetlb_cgroup.c |5
> mm/memcontrol.c |6 -
> net/core/netclassid_cgroup.c|2
> net/core/netprio_cgroup.c |2
> ne
net/core/netprio_cgroup.c |2
net/ipv4/tcp_memcontrol.c |2
security/device_cgroup.c|2
14 files changed, 160 insertions(+), 67 deletions(-)
Acked-by: Li Zefan lize...@huawei.com
--
To unsubscribe from this list: send
> @@ -3085,8 +3091,37 @@ static int cgroup_add_cftypes(struct cgroup_subsys
> *ss, struct cftype *cfts)
> return ret;
> }
>
> +/**
> + * cgroup_add_dfl_cftypes - add an array of cftypes for default hierarchy
> + * @ss: target cgroup subsystem
> + * @cfts: zero-length name terminated
@@ -3085,8 +3091,37 @@ static int cgroup_add_cftypes(struct cgroup_subsys
*ss, struct cftype *cfts)
return ret;
}
+/**
+ * cgroup_add_dfl_cftypes - add an array of cftypes for default hierarchy
+ * @ss: target cgroup subsystem
+ * @cfts: zero-length name terminated array of
We mix the handling for both default hierarchy and legacy hierarchy in
the same function, and it's quite messy, so split into two functions.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 121 ++--
1 file changed, 66 insertions(+), 55 deletions
erarchy
won't be affected.
v2:
- make refactoring of cpuset_hotplug_update_tasks() as seperate patch,
suggested by Tejun.
- make hotplug_update_tasks_insane() use @new_cpus and @new_mems as
hotplug_update_tasks_sane() does.
Signed-off-by: Li Zefan
---
kernel/
cpuset.cpus and cpuset.mems are the configured masks, and we need
to export effective masks to userspace, so users know the real
cpus_allowed and mems_allowed that apply to the tasks in a cpuset.
v2:
- export those masks unconditionally, suggested by Tejun.
Signed-off-by: Li Zefan
---
kernel
gument
Note the checks don't need to be gated by cgroup_on_dfl, because we've
initialized top_cpuset.{cpus,mems}_allowed accordingly in cpuset_bind().
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cp
he same with user-configured
masks.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 83 ++---
1 file changed, 14 insertions(+), 69 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index e4c31e6..820870a 100644
--- a/kernel/cpuset.c
+++ b
its parent's masks.
This ia a behavior change, but won't take effect unless mount with
sane_behavior.
v2:
- Add comments to explain the differences between configured masks and
effective masks.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 35 +--
1 file changed,
functions.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 88 +++--
1 file changed, 54 insertions(+), 34 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 94f651d..da766c3 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -855,
/cpuset.cpus
0-15
On legacy hierarchy:
# mount -t cgroup xxx /cpuset
# cat /cpuset/cpuset.cpus
0,2-15
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 37 -
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git a/kernel/cpuset.c b
config change
- take on ancestor's mask when the effective mask is empty
The last item is done here.
This won't introduce behavior change.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/kernel/cpuset.c b/kernel/cpuset.
on't introduce behavior change.
v2:
- Add a comment for the call of rebuild_sched_domains(), suggested
by Tejun.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index f83
asks, and a child cpuset inherits its parent's effective masks.
This won't introduce behavior change.
v2:
- s/real_{mems,cpus}_allowed/effective_{mems,cpus}, suggested by Tejun.
- don't init effective masks in cpuset_css_online() if !cgroup_on_dfl.
Signed-off-by: Li Zefan
---
kernel/cpuset.c
config change
- take on ancestor's mask when the effective mask is empty
The first item is done here.
This won't introduce behavior change.
Signed-off-by: Li Zefan
---
kernel/cpuset.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index ef0974c..
puset.effective_{cpus,mems} unconditionally
Li Zefan (12):
cpuset: add cs->effective_cpus and cs->effective_mems
cpuset: update cpuset->effective_{cpus,mems} at hotplug
cpuset: update cs->effective_{cpus,mems} when config changes
cpuset: inherit ancestor's masks if effective_{cpus,mems} bec
---
> kernel/cpuset.c | 33 +---
> mm/memcontrol.c|7 +-
> 5 files changed, 117 insertions(+), 153 deletions(-)
>
Acked-by: Li Zefan
I'm rebasing my cpuset patchset against this.
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
Li Zefan (12):
cpuset: add cs-effective_cpus and cs-effective_mems
cpuset: update cpuset-effective_{cpus,mems} at hotplug
cpuset: update cs-effective_{cpus,mems} when config changes
cpuset: inherit ancestor's masks if effective_{cpus,mems} becomes
empty
cpuset: use effective cpumask
, and a child cpuset inherits its parent's effective masks.
This won't introduce behavior change.
v2:
- s/real_{mems,cpus}_allowed/effective_{mems,cpus}, suggested by Tejun.
- don't init effective masks in cpuset_css_online() if !cgroup_on_dfl.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel
change
- take on ancestor's mask when the effective mask is empty
The first item is done here.
This won't introduce behavior change.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index
/cpuset.cpus
0-15
On legacy hierarchy:
# mount -t cgroup xxx /cpuset
# cat /cpuset/cpuset.cpus
0,2-15
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 37 -
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git
change
- take on ancestor's mask when the effective mask is empty
The last item is done here.
This won't introduce behavior change.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/kernel/cpuset.c b/kernel
introduce behavior change.
v2:
- Add a comment for the call of rebuild_sched_domains(), suggested
by Tejun.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 88 +++--
1 file changed, 54 insertions(+), 34 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index 94f651d..da766c3 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
parent's masks.
This ia a behavior change, but won't take effect unless mount with
sane_behavior.
v2:
- Add comments to explain the differences between configured masks and
effective masks.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 35 +--
1
with user-configured
masks.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 83 ++---
1 file changed, 14 insertions(+), 69 deletions(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index e4c31e6..820870a 100644
--- a/kernel/cpuset.c
cpuset.cpus and cpuset.mems are the configured masks, and we need
to export effective masks to userspace, so users know the real
cpus_allowed and mems_allowed that apply to the tasks in a cpuset.
v2:
- export those masks unconditionally, suggested by Tejun.
Signed-off-by: Li Zefan lize
the checks don't need to be gated by cgroup_on_dfl, because we've
initialized top_cpuset.{cpus,mems}_allowed accordingly in cpuset_bind().
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/kernel/cpuset.c b/kernel
be affected.
v2:
- make refactoring of cpuset_hotplug_update_tasks() as seperate patch,
suggested by Tejun.
- make hotplug_update_tasks_insane() use @new_cpus and @new_mems as
hotplug_update_tasks_sane() does.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 65
We mix the handling for both default hierarchy and legacy hierarchy in
the same function, and it's quite messy, so split into two functions.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cpuset.c | 121 ++--
1 file changed, 66
| 128
-
kernel/cgroup.c| 96 +++-
kernel/cpuset.c| 33 +---
mm/memcontrol.c|7 +-
5 files changed, 117 insertions(+), 153 deletions(-)
Acked-by: Li Zefan lize
On 2014/7/8 9:10, xiaofeng.yan wrote:
> On 2014/7/7 16:41, Peter Zijlstra wrote:
>> On Fri, Jul 04, 2014 at 12:02:21PM +, xiaofeng.yan wrote:
>>> It could be wrong for the precision of runtime and deadline
>>> when the precision is within microsecond level. For example:
>>> Task runtime
On 2014/7/8 9:10, xiaofeng.yan wrote:
On 2014/7/7 16:41, Peter Zijlstra wrote:
On Fri, Jul 04, 2014 at 12:02:21PM +, xiaofeng.yan wrote:
It could be wrong for the precision of runtime and deadline
when the precision is within microsecond level. For example:
Task runtime deadline period
On 2014/7/4 15:11, xuwei wrote:
>
> Introduce a new mach-hisi that will support Hisilicon SoCs based on ARMv7
> and I am taking maintainership for it.
>
> Signed-off-by: Wei Xu
> ---
> MAINTAINERS | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
>
01
> ++--
> mm/memcontrol.c | 24 +++
> 6 files changed, 243 insertions(+), 46 deletions(-)
>
Acked-by: Li Zefan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
/cgroup.h | 20 ++
kernel/cgroup.c | 201
++--
mm/memcontrol.c | 24 +++
6 files changed, 243 insertions(+), 46 deletions(-)
Acked-by: Li Zefan lize...@huawei.com
--
To unsubscribe from
On 2014/7/4 15:11, xuwei wrote:
Introduce a new mach-hisi that will support Hisilicon SoCs based on ARMv7
and I am taking maintainership for it.
Signed-off-by: Wei Xu xuw...@hisilicon.com
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS
On 2014/7/1 3:47, Tejun Heo wrote:
> Hey, Li.
>
> Can you please test this patch and ack it?
>
...
> Signed-off-by: Tejun Heo
> Reported-by: Li Zefan
Tested-by: Li Zefan
Thanks!
> ---
> kernel/cpuset.c | 12
> 1 file changed, 12 insertions
On 2014/7/1 3:47, Tejun Heo wrote:
Hey, Li.
Can you please test this patch and ack it?
...
Signed-off-by: Tejun Heo t...@kernel.org
Reported-by: Li Zefan lize...@huawei.com
Tested-by: Li Zefan lize...@huawei.com
Thanks!
---
kernel/cpuset.c | 12
1 file changed, 12
have no superblock assosiated with it.
- adjust/add comments.
Cc: # 3.15
Signed-off-by: Li Zefan
---
kernel/cgroup.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index d3662ac..11e40cf 100644
--- a/kernel
kernfs_pin_sb() tries to get a refcnt of the superblock.
This will be used by cgroupfs.
v2:
- make kernfs_pin_sb() return the superblock.
- drop kernfs_drop_sb().
[ This is a prerequisite for a bugfix. ]
Cc: # 3.15
Acked-by: Greg Kroah-Hartman
Signed-off-by: Li Zefan
---
fs/kernfs/mount.c
: # 3.15
Signed-off-by: Li Zefan
---
kernel/cgroup.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1c65f24..d3662ac 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1648,10 +1648,12 @@ static struct dentry *cgroup_mount(struct
Hi Tejun,
In this lockdep warning kernfs and workqueue are involved, so I'm not sure
what's
happening here.
This was triggered when tasks were being moved to parent cpuset due to hotplug.
The kernel is 3.16-rc1, with no modification.
localhost:/ # mount -t cgroup -o cpuset xxx /cpuset
On 2014/6/28 19:58, Tejun Heo wrote:
> Hello, Li.
>
> On Fri, Jun 27, 2014 at 05:13:12PM +0800, Li Zefan wrote:
>> +for_each_subsys(ss, i) {
>> +if (!(opts.subsys_mask & (1 << i)) ||
>> +ss->root == _df
On 2014/6/28 19:58, Tejun Heo wrote:
Hello, Li.
On Fri, Jun 27, 2014 at 05:13:12PM +0800, Li Zefan wrote:
+for_each_subsys(ss, i) {
+if (!(opts.subsys_mask (1 i)) ||
+ss-root == cgrp_dfl_root)
+continue
Hi Tejun,
In this lockdep warning kernfs and workqueue are involved, so I'm not sure
what's
happening here.
This was triggered when tasks were being moved to parent cpuset due to hotplug.
The kernel is 3.16-rc1, with no modification.
localhost:/ # mount -t cgroup -o cpuset xxx /cpuset
...@vger.kernel.org # 3.15
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cgroup.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index 1c65f24..d3662ac 100644
--- a/kernel/cgroup.c
+++ b/kernel/cgroup.c
@@ -1648,10 +1648,12
Signed-off-by: Li Zefan lize...@huawei.com
---
fs/kernfs/mount.c | 27 +++
include/linux/kernfs.h | 1 +
2 files changed, 28 insertions(+)
diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index f25a7c0..616c5c4 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
have no superblock assosiated with it.
- adjust/add comments.
Cc: sta...@vger.kernel.org # 3.15
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cgroup.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index
Made a mistake again.. :(
==
From: Li Zefan
Subject: [PATCH 1/3] cgroup: fix mount failure in a corner case
# cat test.sh
#! /bin/bash
mount -t cgroup -o cpu xxx /cgroup
umount /cgroup
mount -t cgroup -o cpu,cpuacct xxx /cgroup
umount /cgroup
# ./test.sh
mount
Oh sorry the cut was incomplete. Here's the complete one:
From: Li Zefan
Date: Thu, 12 Jun 2014 09:11:00 +0800
Subject: [PATCH v2 1/3] cgroup: fix mount failure in a corner case
# cat test.sh
#! /bin/bash
mount -t cgroup -o cpu xxx /cgroup
umount /cgroup
mount -t
kernfs_pin_sb() tries to get a refcnt of the superblock.
This will be used by cgroupfs.
v2:
- make kernfs_pin_sb() return pointer to the superblock.
- drop kernfs_drop_sb().
Signed-off-by: Li Zefan
---
fs/kernfs/mount.c | 27 +++
include/linux/kernfs.h | 1 +
2
have no superblock assosiated with it.
- adjust/add comments.
Signed-off-by: Li Zefan
---
kernel/cgroup.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index ae2b382..111b7c3 100644
--- a/kernel/cgroup.c
+++ b
of the first mount was under destruction
asynchronously.
Fix this by delaying and then retrying mount for this case.
v2:
- use percpu_ref_tryget_live() rather that introducing
percpu_ref_alive(). (Tejun)
- adjust comment.
Signed-off-by: Li Zefan
---
kernel/cgroup.c | 27
On 2014/6/25 23:00, Tejun Heo wrote:
> Hey,
>
> On Wed, Jun 25, 2014 at 09:56:31AM +0800, Li Zefan wrote:
>>> Hmmm? Why does that matter? The only region in cgroup_mount() which
>>> needs to be put inside such mutex would be root lookup, no?
>>
>> unfortun
On 2014/6/25 23:00, Tejun Heo wrote:
Hey,
On Wed, Jun 25, 2014 at 09:56:31AM +0800, Li Zefan wrote:
Hmmm? Why does that matter? The only region in cgroup_mount() which
needs to be put inside such mutex would be root lookup, no?
unfortunately that won't help. I think what you suggest
of the first mount was under destruction
asynchronously.
Fix this by delaying and then retrying mount for this case.
v2:
- use percpu_ref_tryget_live() rather that introducing
percpu_ref_alive(). (Tejun)
- adjust comment.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cgroup.c | 27
have no superblock assosiated with it.
- adjust/add comments.
Signed-off-by: Li Zefan lize...@huawei.com
---
kernel/cgroup.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/kernel/cgroup.c b/kernel/cgroup.c
index ae2b382..111b7c3 100644
kernfs_pin_sb() tries to get a refcnt of the superblock.
This will be used by cgroupfs.
v2:
- make kernfs_pin_sb() return pointer to the superblock.
- drop kernfs_drop_sb().
Signed-off-by: Li Zefan lize...@huawei.com
---
fs/kernfs/mount.c | 27 +++
include/linux
1 - 100 of 1870 matches
Mail list logo
