Re: [PATCH 0/5] nbd improvements

Hi Jens, On 2016 M09 8, Thu 14:13:46 CEST Jens Axboe wrote: > On 09/08/2016 01:33 PM, Josef Bacik wrote: > > This is a patch series aimed at bringing NBD into 2016. The two big > > components of this series is converting nbd over to using blkmq and > > then allowing us to provide more than one

Re: [PATCH 0/5] nbd improvements

Hi Jens, On 2016 M09 8, Thu 14:13:46 CEST Jens Axboe wrote: > On 09/08/2016 01:33 PM, Josef Bacik wrote: > > This is a patch series aimed at bringing NBD into 2016. The two big > > components of this series is converting nbd over to using blkmq and > > then allowing us to provide more than one

Re: [PATCH v5 3/4] make nbd device wait for its users

Hi, On Saturday 16 July 2016 16:06:36 Pranay Kr Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruptly killing nbd block device > wait for its users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't

Re: [PATCH v5 3/4] make nbd device wait for its users

Hi, On Saturday 16 July 2016 16:06:36 Pranay Kr Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruptly killing nbd block device > wait for its users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

On Sunday 10 July 2016 21:32:07 Pranay Srivastava wrote: > On Sun, Jul 10, 2016 at 6:32 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: > >> When a timeout occurs or a recv fails, then > >> inst

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

On Sunday 10 July 2016 21:32:07 Pranay Srivastava wrote: > On Sun, Jul 10, 2016 at 6:32 PM, Markus Pargmann wrote: > > On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: > >> When a timeout occurs or a recv fails, then > >> instead of abruplty killing

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

On Sunday 10 July 2016 21:03:05 Pranay Srivastava wrote: > On Sunday, July 10, 2016, Markus Pargmann <m...@pengutronix.de> wrote: > > Hi, > > > > On 2016 M06 30, Thu 14:02:02 CEST Pranay Kr. Srivastava wrote: > >> spinlocked ranges should be small and not conta

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

On Sunday 10 July 2016 21:03:05 Pranay Srivastava wrote: > On Sunday, July 10, 2016, Markus Pargmann wrote: > > Hi, > > > > On 2016 M06 30, Thu 14:02:02 CEST Pranay Kr. Srivastava wrote: > >> spinlocked ranges should be small and not contain calls into huge >

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for its users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v4 3/5]nbd: make nbd device wait for its users

On 2016 M06 30, Thu 14:02:03 CEST Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for its users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

s Patocka <miku...@twibright.com> > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > > Changelog: > Pranay Kr. Srivastava<pran...@gmail.com>: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually tri

Re: [PATCH v4 2/5]nbd: fix might_sleep warning on socket shutdown

Mikulas Patocka > Signed-off-by: Markus Pargmann > > Changelog: > Pranay Kr. Srivastava: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigger the shutdown of > socket. This solves the issue when kernel_sendmsg is

Re: [PATCH v3 1/3]nbd: fix might_sleep warning on socket shutdown

s Patocka <miku...@twibright.com> > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > > Changelog: > Pranay Kr. Srivastava<pran...@gmail.com>: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigge

Re: [PATCH v3 1/3]nbd: fix might_sleep warning on socket shutdown

a > Signed-off-by: Markus Pargmann > > Changelog: > Pranay Kr. Srivastava: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigger the shutdown of >socket. This solves the issue when kernel_sendmsg is cur

Re: [PATCH 3/3]nbd: make nbd device wait for its users

Hi, On Friday 24 June 2016 13:09:36 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH 3/3]nbd: make nbd device wait for its users

Hi, On Friday 24 June 2016 13:09:36 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH 1/2] nbd: make nbd device wait for its users

Hi, On Saturday 25 June 2016 23:22:06 Pranay Srivastava wrote: > On Fri, Jun 24, 2016 at 2:59 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > From: "Pranay Kr. Srivastava" <pran...@gmail.com> > > > > When a timeout occurs or a recv fails, then inste

Re: [PATCH 1/2] nbd: make nbd device wait for its users

Hi, On Saturday 25 June 2016 23:22:06 Pranay Srivastava wrote: > On Fri, Jun 24, 2016 at 2:59 PM, Markus Pargmann wrote: > > From: "Pranay Kr. Srivastava" > > > > When a timeout occurs or a recv fails, then instead of abruplty killing > > nbd block

[PATCH 2/2] nbd: Disallow ioctls on disconnected block device

/writing from a different backend device. For timeouts it is still possible to setup a new socket so that the connection may be refreshed without creating problems for all users. Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 30 --

[PATCH 1/2] nbd: make nbd device wait for its users

: Keep the blockdevice open until all users left] Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- Hi, I used your patch and changed it a bit based on my ideas. The general difference is that this keeps the block device open. After all users left, the device is reset. The followup

[PATCH 2/2] nbd: Disallow ioctls on disconnected block device

/writing from a different backend device. For timeouts it is still possible to setup a new socket so that the connection may be refreshed without creating problems for all users. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 30 -- 1 file changed, 24

[PATCH 1/2] nbd: make nbd device wait for its users

Signed-off-by: Markus Pargmann --- Hi, I used your patch and changed it a bit based on my ideas. The general difference is that this keeps the block device open. After all users left, the device is reset. The followup patch then restricts access to ioctls after a disconnect. I wanted to avoid that a

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

Hi Pranay, On Tuesday 14 June 2016 15:03:40 Pranay Srivastava wrote: > Hi Markus, > > On Tue, Jun 14, 2016 at 2:29 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > > > On Thursday 02 June 2016 13:25:00 Pranay Kr. Srivastava wrote: > > > W

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

Hi Pranay, On Tuesday 14 June 2016 15:03:40 Pranay Srivastava wrote: > Hi Markus, > > On Tue, Jun 14, 2016 at 2:29 PM, Markus Pargmann wrote: > > > > On Thursday 02 June 2016 13:25:00 Pranay Kr. Srivastava wrote: > > > When a timeout occurs or a recv fails,

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

On Thursday 02 June 2016 13:25:00 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v2 4/5]nbd: make nbd device wait for its users.

On Thursday 02 June 2016 13:25:00 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

s Patocka <miku...@twibright.com> > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > > Changelog: > Pranay Kr. Srivastava<pran...@gmail.com>: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigge

Re: [PATCH v2 1/5] nbd: fix might_sleep warning on socket shutdown.

Mikulas Patocka > Signed-off-by: Markus Pargmann > > Changelog: > Pranay Kr. Srivastava: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigger the shutdown of >socket. This solves the issue when kernel_sendmsg

Re: [PATCH] nbd: fix race in ioctl

.h > > It would seem that the race was introduced in the process of moving nbd > from BKL to unlocked ioctls. > > By setting nbd->task_recv while the mutex is held, we can prevent other > processes from running concurrently (since nbd->task_recv is also checked > while t

Re: [PATCH] nbd: fix race in ioctl

.h > > It would seem that the race was introduced in the process of moving nbd > from BKL to unlocked ioctls. > > By setting nbd->task_recv while the mutex is held, we can prevent other > processes from running concurrently (since nbd->task_recv is also checked > while the

Re: [PATCH 0/4]nbd: fixes for nbd

Hi, On Tuesday 24 May 2016 14:26:24 Pranay Kr. Srivastava wrote: > This patch series fixes the following > > 1) fix might_sleep warning on socket shutdown: >Fix sock_shutdown to avoid calling kernel_sock_shutdown >while holding spin_lock. > > 2)fix various coding standard warnings >

Re: [PATCH 0/4]nbd: fixes for nbd

Hi, On Tuesday 24 May 2016 14:26:24 Pranay Kr. Srivastava wrote: > This patch series fixes the following > > 1) fix might_sleep warning on socket shutdown: >Fix sock_shutdown to avoid calling kernel_sock_shutdown >while holding spin_lock. > > 2)fix various coding standard warnings >

Re: [PATCH 1/4] fix might_sleep warning on socket shutdown.

s Patocka <miku...@twibright.com> > Signed-off-by: Markus Pargmann <m...@pengutronix.de> > > Changelog: > Pranay Kr. Srivastava<pran...@gmail.com>: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigge

Re: [PATCH 1/4] fix might_sleep warning on socket shutdown.

tocka > Signed-off-by: Markus Pargmann > > Changelog: > Pranay Kr. Srivastava: > > 1) Use spin_lock instead of irq version for sock_shutdown. > > 2) Use system work queue to actually trigger the shutdown of >socket. This solves the issue when kernel_sendmsg is cur

Re: [PATCH 3/4] make nbd device wait for its users.

Hi, sorry I couldn't fit the review into last week. On Tuesday 24 May 2016 14:26:27 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2

Re: [PATCH 3/4] make nbd device wait for its users.

Hi, sorry I couldn't fit the review into last week. On Tuesday 24 May 2016 14:26:27 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

On Friday 20 May 2016 02:05:36 Pranay Srivastava wrote: > On Thu, May 19, 2016 at 11:52 AM, Markus Pargmann <m...@pengutronix.de> wrote: > > Hi, > > > > On Wed, May 11, 2016 at 11:18:29AM +0300, Pranay Kr. Srivastava wrote: > >> This patch fixes the war

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

On Friday 20 May 2016 02:05:36 Pranay Srivastava wrote: > On Thu, May 19, 2016 at 11:52 AM, Markus Pargmann wrote: > > Hi, > > > > On Wed, May 11, 2016 at 11:18:29AM +0300, Pranay Kr. Srivastava wrote: > >> This patch fixes the warning generated when a time

Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout

Hi, On Thu, May 12, 2016 at 08:49:00PM +0530, Pranay Srivastava wrote: > On Thu, May 12, 2016 at 2:49 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > Hi, > > > > On Wednesday 11 May 2016 11:18:46 Pranay Kr. Srivastava wrote: > >> When a timeout occur

Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout

Hi, On Thu, May 12, 2016 at 08:49:00PM +0530, Pranay Srivastava wrote: > On Thu, May 12, 2016 at 2:49 PM, Markus Pargmann wrote: > > Hi, > > > > On Wednesday 11 May 2016 11:18:46 Pranay Kr. Srivastava wrote: > >> When a timeout occurs or a recv fails, then > &

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi Wouter, On Sun, May 15, 2016 at 02:55:39PM +0200, Wouter Verhelst wrote: > Hi Markus, > > On Thu, May 12, 2016 at 11:53:01AM +0200, Markus Pargmann wrote: > > On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > > > However, at some point I agreed with Paul (you

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi Wouter, On Sun, May 15, 2016 at 02:55:39PM +0200, Wouter Verhelst wrote: > Hi Markus, > > On Thu, May 12, 2016 at 11:53:01AM +0200, Markus Pargmann wrote: > > On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > > > However, at some point I agreed with Paul (you

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

Hi, On Wed, May 11, 2016 at 11:18:29AM +0300, Pranay Kr. Srivastava wrote: > This patch fixes the warning generated when a timeout occurs > on the request and socket is closed from a non-sleep context > by > > 1. Moving the socket closing on a timeout to nbd_thread_send What happens if a send

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

Hi, On Wed, May 11, 2016 at 11:18:29AM +0300, Pranay Kr. Srivastava wrote: > This patch fixes the warning generated when a timeout occurs > on the request and socket is closed from a non-sleep context > by > > 1. Moving the socket closing on a timeout to nbd_thread_send What happens if a send

Re: [PATCH] nbd: Move socket shutdown out of spinlock

Hi, On Thursday 12 May 2016 16:42:31 Pranay Srivastava wrote: > Hi Markus, > > > On Thu, May 12, 2016 at 3:13 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > spinlocked ranges should be small and not contain calls into huge > > subfunctions. Fix my mi

Re: [PATCH] nbd: Move socket shutdown out of spinlock

Hi, On Thursday 12 May 2016 16:42:31 Pranay Srivastava wrote: > Hi Markus, > > > On Thu, May 12, 2016 at 3:13 PM, Markus Pargmann wrote: > > spinlocked ranges should be small and not contain calls into huge > > subfunctions. Fix my mistake and just get the pointer t

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi, On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: > > Hi, > > > > On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: > > > Thanks for the review. > > > > > > Atl

Re: [Nbd] [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi, On Thursday 28 April 2016 18:27:34 Wouter Verhelst wrote: > On Thu, Apr 28, 2016 at 11:00:20AM +0200, Markus Pargmann wrote: > > Hi, > > > > On Saturday 23 April 2016 07:47:21 Ratna Manoj wrote: > > > Thanks for the review. > > > > > > Atl

[PATCH] nbd: Move socket shutdown out of spinlock

spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka <miku...@twibright.com> Signed-off-by: Markus Pargmann <m...@pengu

[PATCH] nbd: Move socket shutdown out of spinlock

spinlocked ranges should be small and not contain calls into huge subfunctions. Fix my mistake and just get the pointer to the socket instead of doing everything with spinlock held. Reported-by: Mikulas Patocka Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 18 ++ 1

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

Hi, On Wednesday 11 May 2016 11:18:29 Pranay Kr. Srivastava wrote: > This patch fixes the warning generated when a timeout occurs > on the request and socket is closed from a non-sleep context > by > > 1. Moving the socket closing on a timeout to nbd_thread_send > > 2. Make sock lock to be a

Re: [PATCH v4 01/18] nbd: Fix might_sleep warning on xmit timeout

Hi, On Wednesday 11 May 2016 11:18:29 Pranay Kr. Srivastava wrote: > This patch fixes the warning generated when a timeout occurs > on the request and socket is closed from a non-sleep context > by > > 1. Moving the socket closing on a timeout to nbd_thread_send > > 2. Make sock lock to be a

Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning.

Hi, On Wednesday 11 May 2016 07:46:25 Eric Blake wrote: > On 05/11/2016 03:38 AM, Pranay Srivastava wrote: > > > > > The series contained some checkpatch changes so I had included you as well. > > > >> know why you are sending them to me), but I know I do not accept patches > >> without any

Re: [Nbd] Fwd: [PATCH v4 02/18] nbd: fix checkpatch trailing space warning.

Hi, On Wednesday 11 May 2016 07:46:25 Eric Blake wrote: > On 05/11/2016 03:38 AM, Pranay Srivastava wrote: > > > > > The series contained some checkpatch changes so I had included you as well. > > > >> know why you are sending them to me), but I know I do not accept patches > >> without any

Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout

Hi, On Wednesday 11 May 2016 11:18:46 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v4 18/18] make nbd device wait for its users in case of timeout

Hi, On Wednesday 11 May 2016 11:18:46 Pranay Kr. Srivastava wrote: > When a timeout occurs or a recv fails, then > instead of abruplty killing nbd block device > wait for it's users to finish. > > This is more required when filesystem(s) like > ext2 or ext3 don't expect their buffer heads to >

Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning.

Hi, On Wednesday 11 May 2016 11:18:35 Pranay Kr. Srivastava wrote: > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/block/nbd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index 6a4dc3a..7a5b8ef

Re: [PATCH v4 07/18] nbd: fix checkpatch split string warning.

Hi, On Wednesday 11 May 2016 11:18:35 Pranay Kr. Srivastava wrote: > Signed-off-by: Pranay Kr. Srivastava > --- > drivers/block/nbd.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c > index 6a4dc3a..7a5b8ef 100644 > ---

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

ockdevice users are gone. This would avoid any issues with writing/reading data to a wrong server. Best Regards, Markus > > Ratna. > > > On Wed, Apr 20, 2016 at 4:36 PM, Markus Pargmann <m...@pengutronix.de> wrote: > > > Hi, > > >

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

ockdevice users are gone. This would avoid any issues with writing/reading data to a wrong server. Best Regards, Markus > > Ratna. > > > On Wed, Apr 20, 2016 at 4:36 PM, Markus Pargmann wrote: > > > Hi, > > > > On Thursday 24 March 2016 07:04:

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi, On Thursday 24 March 2016 07:04:10 Ratna Manoj wrote: > From: Ratna Manoj Bolla > > When a filesystem is mounted on a nbd device and on a disconnect, because > of kill_bdev(), and resetting bdev size to zero, buffer_head mappings are > getting destroyed under mounted

Re: [PATCH] NBD: replace kill_bdev() with __invalidate_device()

Hi, On Thursday 24 March 2016 07:04:10 Ratna Manoj wrote: > From: Ratna Manoj Bolla > > When a filesystem is mounted on a nbd device and on a disconnect, because > of kill_bdev(), and resetting bdev size to zero, buffer_head mappings are > getting destroyed under mounted filesystem. > >

Re: Warning when unloading network block device

Hi, On Friday 15 April 2016 18:30:32 Mikulas Patocka wrote: > Hi > > The patch 23272a6754b81ff6503e09c743bb4ceeeab39997 (nbd: Remove signal > usage) triggers a warning in nbd when the network block device is unloaded > - WARN_ON_ONCE(in_irq() || irqs_disabled()) in the function >

Re: Warning when unloading network block device

Hi, On Friday 15 April 2016 18:30:32 Mikulas Patocka wrote: > Hi > > The patch 23272a6754b81ff6503e09c743bb4ceeeab39997 (nbd: Remove signal > usage) triggers a warning in nbd when the network block device is unloaded > - WARN_ON_ONCE(in_irq() || irqs_disabled()) in the function >

Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

Hi, On Monday 28 March 2016 20:15:46 Irina Tirdea wrote: > When reading gyroscope axes using iio buffers, the values > returned are always 0. In the interrupt handler, the return > value of the read operation is returned to the user instead > of the value read. Return the value read to the user.

Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

Hi, On Monday 28 March 2016 20:15:46 Irina Tirdea wrote: > When reading gyroscope axes using iio buffers, the values > returned are always 0. In the interrupt handler, the return > value of the read operation is returned to the user instead > of the value read. Return the value read to the user.

Re: [PATCH 4/5] gpio: of: Add support to have multiple gpios in gpio-hog

On Thursday 10 March 2016 12:37:32 Laxman Dewangan wrote: > > On Wednesday 09 March 2016 10:47 PM, Stephen Warren wrote: > > On 03/09/2016 06:20 AM, Laxman Dewangan wrote: > >> > >> On Wednesday 09 March 2016 11:58 AM, Markus Pargmann wrote: > >>> * P

Re: [PATCH 4/5] gpio: of: Add support to have multiple gpios in gpio-hog

On Thursday 10 March 2016 12:37:32 Laxman Dewangan wrote: > > On Wednesday 09 March 2016 10:47 PM, Stephen Warren wrote: > > On 03/09/2016 06:20 AM, Laxman Dewangan wrote: > >> > >> On Wednesday 09 March 2016 11:58 AM, Markus Pargmann wrote: > >>> * P

Re: [PATCH 4/5] gpio: of: Add support to have multiple gpios in gpio-hog

Hi, On Tue, Mar 08, 2016 at 05:32:07PM +0530, Laxman Dewangan wrote: > The child node for gpio hogs under gpio controller's node > provide the mechanism to automatic GPIO request and > configuration as part of the gpio-controller's driver > probe function. > > Currently, property "gpio" takes

Re: [PATCH 4/5] gpio: of: Add support to have multiple gpios in gpio-hog

Hi, On Tue, Mar 08, 2016 at 05:32:07PM +0530, Laxman Dewangan wrote: > The child node for gpio hogs under gpio controller's node > provide the mechanism to automatic GPIO request and > configuration as part of the gpio-controller's driver > probe function. > > Currently, property "gpio" takes

Re: [PATCH] iio: adc: imx25-gcq: fix do_div

Hi, On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote: > On 03/03/16 12:51, Sudip Mukherjee wrote: > > We are getting build failure with tilepro allmodconfig with the error: > > > > drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div' > >

Re: [PATCH] iio: adc: imx25-gcq: fix do_div

Hi, On Saturday 05 March 2016 18:43:11 Jonathan Cameron wrote: > On 03/03/16 12:51, Sudip Mukherjee wrote: > > We are getting build failure with tilepro allmodconfig with the error: > > > > drivers/iio/adc/fsl-imx25-gcq.c:236:4: note: in expansion of macro 'do_div' > >

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

On Wednesday 02 March 2016 10:03:27 Rob Herring wrote: > Reviving this thread... > > On Tue, Dec 15, 2015 at 3:09 AM, Markus Pargmann <m...@pengutronix.de> wrote: > > Hi, > > > > On Monday 14 December 2015 09:45:48 Rob Herring wrote: > >> On Mon, Dec 14,

Re: [PATCH 1/3] Device tree binding documentation for gpio-switch

On Wednesday 02 March 2016 10:03:27 Rob Herring wrote: > Reviving this thread... > > On Tue, Dec 15, 2015 at 3:09 AM, Markus Pargmann wrote: > > Hi, > > > > On Monday 14 December 2015 09:45:48 Rob Herring wrote: > >> On Mon, Dec 14, 2015 at 8:28 AM, Linus Wall

Re: [PULL] NBD for 4.6

Hi, On Thursday, March 03, 2016 06:53:28 AM Jens Axboe wrote: > On 03/03/2016 12:48 AM, Markus Pargmann wrote: > > Hi Jens, > > > > On Sunday, February 21, 2016 03:01:20 PM Markus Pargmann wrote: > >> Hi Jens, > >> > >> This pull request contains

Re: [PULL] NBD for 4.6

Hi, On Thursday, March 03, 2016 06:53:28 AM Jens Axboe wrote: > On 03/03/2016 12:48 AM, Markus Pargmann wrote: > > Hi Jens, > > > > On Sunday, February 21, 2016 03:01:20 PM Markus Pargmann wrote: > >> Hi Jens, > >> > >> This pull request contains

Re: [PULL] NBD for 4.6

Hi Jens, On Sunday, February 21, 2016 03:01:20 PM Markus Pargmann wrote: > Hi Jens, > > This pull request contains 7 patches for 4.6. any news on this pull request? Best Regards, Markus > > Patch 1 fixes some unnecessarily complicated code I introduced some versions &g

Re: [PULL] NBD for 4.6

Hi Jens, On Sunday, February 21, 2016 03:01:20 PM Markus Pargmann wrote: > Hi Jens, > > This pull request contains 7 patches for 4.6. any news on this pull request? Best Regards, Markus > > Patch 1 fixes some unnecessarily complicated code I introduced some versions &g

Re: [Nbd] [PATCH] nbd: ratelimit error messages from disconnected devices

Hi, On Tuesday 16 February 2016 14:33:01 Dmitry Monakhov wrote: > ndb can be explicitly disconnected via NBD_DISCONNECT while > active user still exists this result in massive spam to logs. > Let's ratelimits such messages. > > Signed-off-by: Dmitry Monakhov > --- >

Re: [Nbd] [PATCH] nbd: ratelimit error messages from disconnected devices

Hi, On Tuesday 16 February 2016 14:33:01 Dmitry Monakhov wrote: > ndb can be explicitly disconnected via NBD_DISCONNECT while > active user still exists this result in massive spam to logs. > Let's ratelimits such messages. > > Signed-off-by: Dmitry Monakhov > --- > drivers/block/nbd.c | 6

Re: [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN

on-declaration] > > This adds a 'select IRQ_DOMAIN' code, like we have it in all other > drivers with this requirement. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: e2fccf5c1515 ("mfd: fsl-imx25-tsadc: Register touchscreen ADC driver") Thanks,

Re: [PATCH] mfd: fsl-imx25-tsadc: select IRQ_DOMAIN

on-declaration] > > This adds a 'select IRQ_DOMAIN' code, like we have it in all other > drivers with this requirement. > > Signed-off-by: Arnd Bergmann > Fixes: e2fccf5c1515 ("mfd: fsl-imx25-tsadc: Register touchscreen ADC driver") Thanks, Reviewed-by: Markus Parg

[PATCH 2/7] nbd: Remove signal usage

threads. Cc: Oleg Nesterov <o...@redhat.com> Cc: Christoph Hellwig <h...@infradead.org> Signed-off-by: Markus Pargmann <m...@pengutronix.de> Reviewed-by: Christoph Hellwig <h...@lst.de> --- drivers/block/nbd.c | 126

[PATCH 2/7] nbd: Remove signal usage

threads. Cc: Oleg Nesterov Cc: Christoph Hellwig Signed-off-by: Markus Pargmann Reviewed-by: Christoph Hellwig --- drivers/block/nbd.c | 126 1 file changed, 48 insertions(+), 78 deletions(-) diff --git a/drivers/block/nbd.c b/drivers

[PATCH 3/7] nbd: Timeouts are not user requested disconnects

It may be useful to know in the client that a connection timed out. The current code returns success for a timeout. This patch reports the error code -ETIMEDOUT for a timeout. Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 9 ++--- 1 file chan

[PATCH 1/7] nbd: Fix debugfs error handling

to debugfs files in wrong places. Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 55 ++--- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index e4c5cc

[PATCH 3/7] nbd: Timeouts are not user requested disconnects

It may be useful to know in the client that a connection timed out. The current code returns success for a timeout. This patch reports the error code -ETIMEDOUT for a timeout. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions

[PATCH 1/7] nbd: Fix debugfs error handling

to debugfs files in wrong places. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 55 ++--- 1 file changed, 14 insertions(+), 41 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index e4c5cc107934..d61a04155d99 100644

[PATCH 5/7] nbd: Move flag parsing to a function

nbd changes properties of the blockdevice depending on flags that were received. This patch moves this flag parsing into a separate function nbd_parse_flags(). Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 22 +- 1 file changed, 13 inse

[PATCH 5/7] nbd: Move flag parsing to a function

nbd changes properties of the blockdevice depending on flags that were received. This patch moves this flag parsing into a separate function nbd_parse_flags(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions

[PATCH 7/7] nbd: Create size change events for userspace

. Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 79 +++-- 1 file changed, 58 insertions(+), 21 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4c5d94146aa3..f6b51d76e578 100644 --- a/drivers

[PATCH 7/7] nbd: Create size change events for userspace

. Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 79 +++-- 1 file changed, 58 insertions(+), 21 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index 4c5d94146aa3..f6b51d76e578 100644 --- a/drivers/block/nbd.c +++ b/drivers

[PATCH 6/7] nbd: ratelimit error msgs after socket close

hich overwhelmed it. Fixes: 4d48a542b427 ("nbd: fix I/O hang on disconnected nbds") Signed-off-by: Dan Streetman <dan.street...@canonical.com> Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

[PATCH 6/7] nbd: ratelimit error msgs after socket close

b427 ("nbd: fix I/O hang on disconnected nbds") Signed-off-by: Dan Streetman Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index b67500d5b338..4c5d94146aa3 100644

[PULL] NBD for 4.6

) NBD for 4.6 Dan Streetman (1): nbd: ratelimit error msgs after socket close Markus Pargmann (6): nbd: Fix debugfs error handling nbd: Remove signal usage nbd

[PATCH 4/7] nbd: Cleanup reset of nbd and bdev after a disconnect

Group all variables that are reset after a disconnect into reset functions. This patch adds two of these functions, nbd_reset() and nbd_bdev_reset(). Signed-off-by: Markus Pargmann <m...@pengutronix.de> --- drivers/block/nbd.c | 40 +--- 1 file chang

[PULL] NBD for 4.6

) NBD for 4.6 Dan Streetman (1): nbd: ratelimit error msgs after socket close Markus Pargmann (6): nbd: Fix debugfs error handling nbd: Remove signal usage nbd

[PATCH 4/7] nbd: Cleanup reset of nbd and bdev after a disconnect

Group all variables that are reset after a disconnect into reset functions. This patch adds two of these functions, nbd_reset() and nbd_bdev_reset(). Signed-off-by: Markus Pargmann --- drivers/block/nbd.c | 40 +--- 1 file changed, 29 insertions(+), 11

Re: [PATCH] iio: adc/imx25-gcq: move incorrect do_div

: Add imx25-gcq ADC driver") Thanks for fixing this. Reviewed-by: Markus Pargmann <m...@pengutronix.de> Best Regards, Markus > --- > drivers/iio/adc/fsl-imx25-gcq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/

Re: [PATCH] iio: adc/imx25-gcq: move incorrect do_div

iver") Thanks for fixing this. Reviewed-by: Markus Pargmann Best Regards, Markus > --- > drivers/iio/adc/fsl-imx25-gcq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c > index 2fd

  1   2   3   4   5   6   7   8   9   >