[PATCH] staging: init: main: fix sparse warning Fix sparse warning "should it be static"

Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- init/main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index e8ae1fe..25cc270 100644 --- a/init/main.c +++ b/init/main.c @@ -160,7 +160,8 @@ static int __init set_reset_devices

[PATCH] staging: init: main: fix sparse warning Fix sparse warning should it be static

Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- init/main.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/init/main.c b/init/main.c index e8ae1fe..25cc270 100644 --- a/init/main.c +++ b/init/main.c @@ -160,7 +160,8

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc

Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Ok. Sorry. ᐧ On Tue, Apr 8, 2014 at 11:20 PM, Joe Perches wrote: > On Tue, 2014-04-08 at 23:18 +0300, Matei Oprea wrote: >> It's easier to use kcalloc for allocating arrays. While at it >> also remove useless casting value. > > Don't send a patch against your bad patc

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Ok. Sorry. ᐧ On Tue, Apr 8, 2014 at 11:20 PM, Joe Perches j...@perches.com wrote: On Tue, 2014-04-08 at 23:18 +0300, Matei Oprea wrote: It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Don't send a patch against your bad patch. Send a new

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions

Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

Sorry, I thought that it's out. ᐧ On Mon, Apr 7, 2014 at 5:14 PM, Greg KH wrote: > On Mon, Apr 07, 2014 at 03:38:27PM +0300, Matei Oprea wrote: >> Any comments on this ? > > You got an email from me about this, on the 23rd, saying that I can't do > anything with it unt

Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

Any comments on this ? ᐧ On Sun, Mar 23, 2014 at 2:13 PM, Matei Oprea wrote: > This patch fixes "incorrect type in argument 1" warning from sparse. > > Signed-off-by: Matei Oprea > Cc: ROSEdu Kernel Community > --- > drivers/staging/cxt1e1/hwprobe.c |

Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Any comments on this ? ᐧ On Tue, Mar 18, 2014 at 10:51 PM, Matei Oprea wrote: > It's easier to use kcalloc for allocating arrays. While at it > also remove useless casting value. > > Signed-off-by: Matei Oprea > Cc: ROSEdu Kernel Community > --- > drivers/scsi/lp

Re: [PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

Any comments on this ? ᐧ On Tue, Mar 18, 2014 at 10:51 PM, Matei Oprea e...@opreamatei.ro wrote: It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org

Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

Any comments on this ? ᐧ On Sun, Mar 23, 2014 at 2:13 PM, Matei Oprea e...@opreamatei.ro wrote: This patch fixes incorrect type in argument 1 warning from sparse. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/staging/cxt1e1

Re: [PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

Sorry, I thought that it's out. ᐧ On Mon, Apr 7, 2014 at 5:14 PM, Greg KH gre...@linuxfoundation.org wrote: On Mon, Apr 07, 2014 at 03:38:27PM +0300, Matei Oprea wrote: Any comments on this ? You got an email from me about this, on the 23rd, saying that I can't do anything with it until

[PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

This patch fixes "incorrect type in argument 1" warning from sparse. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/staging/cxt1e1/hwprobe.c |6 +++--- drivers/staging/cxt1e1/pmcc4_private.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-)

[PATCH] staging: cxt1e1: hwprobe: fix incorrect type in assignment

This patch fixes incorrect type in argument 1 warning from sparse. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/staging/cxt1e1/hwprobe.c |6 +++--- drivers/staging/cxt1e1/pmcc4_private.h |2 +- 2 files changed, 4

[PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings

Fix sparse "should be static" warnings. Those structures are only referenced in file scope so they can be marked as static. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/staging/rtl8192u/r8192U_wx.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces

Fix different address spaces when unmapping IO. hi->addr_mapped[0] and hi->addr_mapped[1] should be tagged __iomem. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/staging/cxt1e1/hwprobe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

I did it against your master branch of staging.git. I guess that's why doesn't apply at all. I switched branches to staging-next after your e-mail. Thanks and sorry ! On Wed, Mar 19, 2014 at 1:14 AM, Greg KH wrote: > On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea wrote: >> T

Re: [PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

I did it against your master branch of staging.git. I guess that's why doesn't apply at all. I switched branches to staging-next after your e-mail. Thanks and sorry ! On Wed, Mar 19, 2014 at 1:14 AM, Greg KH gre...@linuxfoundation.org wrote: On Wed, Mar 19, 2014 at 12:33:19AM +0200, Matei Oprea

[PATCH] drivers: staging: cxt1e1: hwprobe Fix different address spaces

Fix different address spaces when unmapping IO. hi-addr_mapped[0] and hi-addr_mapped[1] should be tagged __iomem. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/staging/cxt1e1/hwprobe.c |4 ++-- 1 file changed, 2 insertions

[PATCH] staging: rtl8192u: r8192U_wx: Fix sparse warnings

Fix sparse should be static warnings. Those structures are only referenced in file scope so they can be marked as static. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/staging/rtl8192u/r8192U_wx.c |6 +++--- 1 file changed, 3

[PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

? * drivers/staging/cxt1e1/hwprobe.c:195:1: warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1: * warning: symbol 'c4hw_attach_all' was not declared. Should it be static? Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b

[PATCH] scsi: lpfc: lpfc_init: use kcalloc for allocating memory

It's easier to use kcalloc for allocating arrays. While at it also remove useless casting value. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] staging: cxt1e1: hwprobe: Fix sparse warning

? * drivers/staging/cxt1e1/hwprobe.c:195:1: warning: symbol 'cleanup_devs' was not declared. Should it be static? drivers/staging/cxt1e1/hwprobe.c:293:1: * warning: symbol 'c4hw_attach_all' was not declared. Should it be static? Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel

[PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

Remove useless casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *). Found using coccinelle Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Community --- drivers/scsi/lpfc/lpfc_init.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH] Scsi: lpfc: lpfc_init: Remove useless casting value

Remove useless casting value returned by k[cmz]alloc to (struct lpfc_sli_ring *). Found using coccinelle Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Community fire...@lists.rosedu.org --- drivers/scsi/lpfc/lpfc_init.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions

[PATCH] Staging: comedi: ni_daq_dio24: fix a line over 80 characters

Fix a coding style issue. Signed-off-by: Matei Oprea Cc: ROSEdu Kernel Commmunity --- drivers/staging/comedi/drivers/ni_daq_dio24.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c b/drivers/staging/comedi/drivers

[PATCH] Staging: comedi: ni_daq_dio24: fix a line over 80 characters

Fix a coding style issue. Signed-off-by: Matei Oprea e...@opreamatei.ro Cc: ROSEdu Kernel Commmunity fire...@lists.rosedu.org --- drivers/staging/comedi/drivers/ni_daq_dio24.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_daq_dio24.c