-is are not
upstreamable. There are some open questions on my side (see mail referenced
above).
> These were the changes to report the stack frame RIP/RSP in the PEBS
> handler and use it for unwinding in perf.
Yes, I was looking at something different. I've no experience with brstackinsn
Commit-ID: 9add8fe8e6f63db47e40e65173530dcb68cd7a07
Gitweb: https://git.kernel.org/tip/9add8fe8e6f63db47e40e65173530dcb68cd7a07
Author: Milian Wolff
AuthorDate: Wed, 7 Nov 2018 23:34:37 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 21 Nov 2018 12:00:32 -0300
perf script
Commit-ID: 9add8fe8e6f63db47e40e65173530dcb68cd7a07
Gitweb: https://git.kernel.org/tip/9add8fe8e6f63db47e40e65173530dcb68cd7a07
Author: Milian Wolff
AuthorDate: Wed, 7 Nov 2018 23:34:37 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 21 Nov 2018 12:00:32 -0300
perf script
Commit-ID: b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Gitweb: https://git.kernel.org/tip/b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Author: Milian Wolff
AuthorDate: Wed, 7 Nov 2018 10:37:05 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 21 Nov 2018 12:00:31 -0300
perf script
Commit-ID: b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Gitweb: https://git.kernel.org/tip/b07d16f7e9e4cf2562f61b5f68a4b0831fe5ef14
Author: Milian Wolff
AuthorDate: Wed, 7 Nov 2018 10:37:05 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 21 Nov 2018 12:00:31 -0300
perf script
On Donnerstag, 15. November 2018 03:05:32 CET Travis Downs wrote:
> On Wed, Nov 14, 2018 at 8:20 AM Milian Wolff wrote:
> > 3) I suggest we always keep the first frame and sample IP from the user
> > regs, i.e. the accurate PEBS/IBS IP. Then we add the following frames
>
On Donnerstag, 15. November 2018 03:05:32 CET Travis Downs wrote:
> On Wed, Nov 14, 2018 at 8:20 AM Milian Wolff wrote:
> > 3) I suggest we always keep the first frame and sample IP from the user
> > regs, i.e. the accurate PEBS/IBS IP. Then we add the following frames
>
mp/cpp-inlining)
7fc104096222 __libc_start_main+0xf2 (/usr/lib/libc-2.28.so)
5622c74521ed _start+0x2d (/tmp/cpp-inlining)
```
Here, we are missing the hypotf32x call inbetween __hypot_finite and main.
Do we want to introduce some heuristic on how handle these scenarios? I.e.
mp/cpp-inlining)
7fc104096222 __libc_start_main+0xf2 (/usr/lib/libc-2.28.so)
5622c74521ed _start+0x2d (/tmp/cpp-inlining)
```
Here, we are missing the hypotf32x call inbetween __hypot_finite and main.
Do we want to introduce some heuristic on how handle these scenarios? I.e.
On Mittwoch, 7. November 2018 23:41:31 CET Milian Wolff wrote:
> On Dienstag, 6. November 2018 21:24:11 CET Andi Kleen wrote:
> > > Where would I look for the source to change here? So far, I only
> > > concentrated on the userspace side of perf in tools/perf.
>
On Mittwoch, 7. November 2018 23:41:31 CET Milian Wolff wrote:
> On Dienstag, 6. November 2018 21:24:11 CET Andi Kleen wrote:
> > > Where would I look for the source to change here? So far, I only
> > > concentrated on the userspace side of perf in tools/perf.
>
IP than stored in uregs in the perf.data file,
then we could use that as a fallback for unwinding, when it fails the first
time. Or should we always unwind from that IP? How do we mark the "actual"
frame/IP then, if that differs?
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engine
IP than stored in uregs in the perf.data file,
then we could use that as a fallback for unwinding, when it fails the first
time. Or should we always unwind from that IP? How do we mark the "actual"
frame/IP then, if that differs?
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engine
] 1343.354363: 1 cycles:ppp:
...
```
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 40 -
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf
] 1343.354363: 1 cycles:ppp:
...
```
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 40 -
1 file changed, 17 insertions(+), 23 deletions(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf
:
77c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
...
ABI:2AX:0x40d440c7BX:0x40d440c7CX:0x4d45e5da...
```
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf
:
77c96696 __hypot_finite+0x36 (/usr/lib/libm-2.28.so)
...
ABI:2AX:0x40d440c7BX:0x40d440c7CX:0x4d45e5da...
```
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/perf
e PMI's exception frame on the stack.
> >
> > Probably would need to modify perf to report those too in addition
> > to the PEBS registers.
>
> ok, should not be that hard
Where would I look for the source to change here? So far, I only concentrated
on the userspace side of p
e PMI's exception frame on the stack.
> >
> > Probably would need to modify perf to report those too in addition
> > to the PEBS registers.
>
> ok, should not be that hard
Where would I look for the source to change here? So far, I only concentrated
on the userspace side of p
On Montag, 5. November 2018 21:51:19 CET Jiri Olsa wrote:
> On Fri, Nov 02, 2018 at 06:56:50PM +0100, Milian Wolff wrote:
>
> SNIP
>
> > > > Note how precise levels 0 and 1 do not produce any samples where
> > > > unwinding
> > > > fails. But pr
On Montag, 5. November 2018 21:51:19 CET Jiri Olsa wrote:
> On Fri, Nov 02, 2018 at 06:56:50PM +0100, Milian Wolff wrote:
>
> SNIP
>
> > > > Note how precise levels 0 and 1 do not produce any samples where
> > > > unwinding
> > > > fails. But pr
On Freitag, 2. November 2018 12:26:35 CET Jiri Olsa wrote:
> On Thu, Nov 01, 2018 at 11:08:18PM +0100, Milian Wolff wrote:
> > On Dienstag, 30. Oktober 2018 23:34:35 CET Milian Wolff wrote:
> > > On Mittwoch, 24. Oktober 2018 16:48:18 CET Andi Kleen wrote:
> > > >
On Freitag, 2. November 2018 12:26:35 CET Jiri Olsa wrote:
> On Thu, Nov 01, 2018 at 11:08:18PM +0100, Milian Wolff wrote:
> > On Dienstag, 30. Oktober 2018 23:34:35 CET Milian Wolff wrote:
> > > On Mittwoch, 24. Oktober 2018 16:48:18 CET Andi Kleen wrote:
> > > >
On Dienstag, 30. Oktober 2018 23:34:35 CET Milian Wolff wrote:
> On Mittwoch, 24. Oktober 2018 16:48:18 CET Andi Kleen wrote:
> > > Can someone at least confirm whether unwinding from a function prologue
> > > via
> > > .eh_frame (but without .debug_frame) should actu
On Dienstag, 30. Oktober 2018 23:34:35 CET Milian Wolff wrote:
> On Mittwoch, 24. Oktober 2018 16:48:18 CET Andi Kleen wrote:
> > > Can someone at least confirm whether unwinding from a function prologue
> > > via
> > > .eh_frame (but without .debug_frame) should actu
Commit-ID: 1fe627da30331024f453faef04d500079b901107
Gitweb: https://git.kernel.org/tip/1fe627da30331024f453faef04d500079b901107
Author: Milian Wolff
AuthorDate: Mon, 29 Oct 2018 15:16:44 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 31 Oct 2018 09:57:50 -0300
perf unwind
Commit-ID: 1fe627da30331024f453faef04d500079b901107
Gitweb: https://git.kernel.org/tip/1fe627da30331024f453faef04d500079b901107
Author: Milian Wolff
AuthorDate: Mon, 29 Oct 2018 15:16:44 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 31 Oct 2018 09:57:50 -0300
perf unwind
70 27 1e fd 7f 00 00 f9 da 5b 34 91 7f 00 00 pp'...[4
. 0100: e4 b5 45 22 72 85 d8 c0 c0 1d 16 84 43 30 bb c0 ..E"r...C0..
.
```
We can find `7f91345bdaf8+1 = 7f91345bdaf9" at offset 16 (search for "f9 da 5b
34 91 7f"). Using that address makes unwinding wo
70 27 1e fd 7f 00 00 f9 da 5b 34 91 7f 00 00 pp'...[4
. 0100: e4 b5 45 22 72 85 d8 c0 c0 1d 16 84 43 30 bb c0 ..E"r...C0..
.
```
We can find `7f91345bdaf8+1 = 7f91345bdaf9" at offset 16 (search for "f9 da 5b
34 91 7f"). Using that address makes unwinding wo
On Montag, 29. Oktober 2018 18:40:14 CET Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 29, 2018 at 04:26:27PM +0100, Milian Wolff escreveu:
> > On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote:
> > > Libdwfl parses an ELF file itself and creates mappings for th
On Montag, 29. Oktober 2018 18:40:14 CET Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 29, 2018 at 04:26:27PM +0100, Milian Wolff escreveu:
> > On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote:
> > > Libdwfl parses an ELF file itself and creates mappings for th
On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote:
> Libdwfl parses an ELF file itself and creates mappings for the
> individual sections. Perf on the other hand sees raw mmap events which
> represent individual sections. When we encounter an address pointing
> in
On Monday, October 29, 2018 3:16:44 PM CET Milian Wolff wrote:
> Libdwfl parses an ELF file itself and creates mappings for the
> individual sections. Perf on the other hand sees raw mmap events which
> represent individual sections. When we encounter an address pointing
> in
M_insert(double)+0x90 (/usr/lib/libstdc++.so.6.0.25)
563b9cb502f7 std::ostream::operator<<(double)+0xb7 (inlined)
563b9cb502f7 worker()+0xb7
(/ssd/milian/projects/kdab/rnd/hotspot/build/tests/test-clients/cpp-locking/cpp-locking)
6eab825c1ee3e4ff [unknown] ([u
M_insert(double)+0x90 (/usr/lib/libstdc++.so.6.0.25)
563b9cb502f7 std::ostream::operator<<(double)+0xb7 (inlined)
563b9cb502f7 worker()+0xb7
(/ssd/milian/projects/kdab/rnd/hotspot/build/tests/test-clients/cpp-locking/cpp-locking)
6eab825c1ee3e4ff [unknown] ([u
Commit-ID: 7ee40678af935fb489b0c6cf0f75808175214cd7
Gitweb: https://git.kernel.org/tip/7ee40678af935fb489b0c6cf0f75808175214cd7
Author: Milian Wolff
AuthorDate: Sun, 21 Oct 2018 21:14:24 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 22 Oct 2018 14:27:11 -0300
perf script
Commit-ID: 7ee40678af935fb489b0c6cf0f75808175214cd7
Gitweb: https://git.kernel.org/tip/7ee40678af935fb489b0c6cf0f75808175214cd7
Author: Milian Wolff
AuthorDate: Sun, 21 Oct 2018 21:14:24 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 22 Oct 2018 14:27:11 -0300
perf script
Commit-ID: c1c9b9695cc8868048f45c7e2559f65bc0be7382
Gitweb: https://git.kernel.org/tip/c1c9b9695cc8868048f45c7e2559f65bc0be7382
Author: Milian Wolff
AuthorDate: Sun, 21 Oct 2018 21:14:23 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 22 Oct 2018 12:37:53 -0300
perf script
Commit-ID: c1c9b9695cc8868048f45c7e2559f65bc0be7382
Gitweb: https://git.kernel.org/tip/c1c9b9695cc8868048f45c7e2559f65bc0be7382
Author: Milian Wolff
AuthorDate: Sun, 21 Oct 2018 21:14:23 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 22 Oct 2018 12:37:53 -0300
perf script
that the broken sample frame points at
0x00029688 <+40>:sub$0x28,%rsp
Can someone at least confirm whether unwinding from a function prologue via
.eh_frame (but without .debug_frame) should actually be possible?
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior S
that the broken sample frame points at
0x00029688 <+40>:sub$0x28,%rsp
Can someone at least confirm whether unwinding from a function prologue via
.eh_frame (but without .debug_frame) should actually be possible?
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior S
On Montag, 22. Oktober 2018 15:58:17 CEST Andi Kleen wrote:
> Milian Wolff writes:
> > After more digging, it turns out that I've apparently chased a red
> > herring.
> > I'm running archlinux which isn't shipping debug symbols for libm.
>
> 64bit executables norma
On Montag, 22. Oktober 2018 15:58:17 CEST Andi Kleen wrote:
> Milian Wolff writes:
> > After more digging, it turns out that I've apparently chased a red
> > herring.
> > I'm running archlinux which isn't shipping debug symbols for libm.
>
> 64bit executables norma
On Montag, 22. Oktober 2018 12:35:39 CEST Milian Wolff wrote:
> On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> > Hey all,
> >
> > I'm on the quest to figure out why perf regularly fails to unwind (some)
> > samples. I am seeing very strange behavior
On Montag, 22. Oktober 2018 12:35:39 CEST Milian Wolff wrote:
> On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> > Hey all,
> >
> > I'm on the quest to figure out why perf regularly fails to unwind (some)
> > samples. I am seeing very strange behavior
On Montag, 22. Oktober 2018 12:16:18 CEST Jiri Olsa wrote:
> On Mon, Oct 22, 2018 at 12:09:22PM +0200, Milian Wolff wrote:
> > On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote:
> > > On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote:
> > > &g
On Montag, 22. Oktober 2018 12:16:18 CEST Jiri Olsa wrote:
> On Mon, Oct 22, 2018 at 12:09:22PM +0200, Milian Wolff wrote:
> > On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote:
> > > On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote:
> > > &g
On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> Hey all,
>
> I'm on the quest to figure out why perf regularly fails to unwind (some)
> samples. I am seeing very strange behavior, where an apparently wrong stack
> pointer value is read from the register - see
On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> Hey all,
>
> I'm on the quest to figure out why perf regularly fails to unwind (some)
> samples. I am seeing very strange behavior, where an apparently wrong stack
> pointer value is read from the register - see
On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote:
> On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote:
> > When the perf script output is written to a terminal stream,
> > the normal output of `perf script` would get buffered, but its
> > debug output woul
On Montag, 22. Oktober 2018 11:43:17 CEST Jiri Olsa wrote:
> On Sun, Oct 21, 2018 at 09:14:24PM +0200, Milian Wolff wrote:
> > When the perf script output is written to a terminal stream,
> > the normal output of `perf script` would get buffered, but its
> > debug output woul
On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> Hey all,
>
> I'm on the quest to figure out why perf regularly fails to unwind (some)
> samples. I am seeing very strange behavior, where an apparently wrong stack
> pointer value is read from the register - see
On Sonntag, 21. Oktober 2018 00:39:51 CEST Milian Wolff wrote:
> Hey all,
>
> I'm on the quest to figure out why perf regularly fails to unwind (some)
> samples. I am seeing very strange behavior, where an apparently wrong stack
> pointer value is read from the register - see
(0x2000)
cpp-inlining 24617 90229.122043974: 1 cycles:uppp:
7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
...
```
This new output format makes it much easier to use perf script
output for debugging purposes, e.g. to investigate broken dwarf
unwinding.
Signed-off-by: Milian
the extended
debug information now in perf script as expected.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 4da5e32b9e03
(0x2000)
cpp-inlining 24617 90229.122043974: 1 cycles:uppp:
7faf7dfdc000 _start+0x0 (/usr/lib/ld-2.28.so)
...
```
This new output format makes it much easier to use perf script
output for debugging purposes, e.g. to investigate broken dwarf
unwinding.
Signed-off-by: Milian
the extended
debug information now in perf script as expected.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
---
tools/perf/builtin-script.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 4da5e32b9e03
xed somehow during record time?
Can we detect this scenario at analysis time and correct the stack pointer
address automatically somehow? Should the first frame always try to read from
offset 72 maybe?
Any help would be greatly appreciated, many thanks
--
Milian Wolff
m...@milianw.de
xed somehow during record time?
Can we detect this scenario at analysis time and correct the stack pointer
address automatically somehow? Should the first frame always try to read from
offset 72 maybe?
Any help would be greatly appreciated, many thanks
--
Milian Wolff
m...@milianw.de
Commit-ID: d4046e8e17b9f378cb861982ef71c63911b5dff3
Gitweb: https://git.kernel.org/tip/d4046e8e17b9f378cb861982ef71c63911b5dff3
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:07 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 16 Oct 2018 14:52:21 -0300
perf report
Commit-ID: d4046e8e17b9f378cb861982ef71c63911b5dff3
Gitweb: https://git.kernel.org/tip/d4046e8e17b9f378cb861982ef71c63911b5dff3
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:07 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Tue, 16 Oct 2018 14:52:21 -0300
perf report
On Dienstag, 16. Oktober 2018 19:52:04 CEST Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 16, 2018 at 02:49:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Oct 15, 2018 at 10:51:36PM +0200, Milian Wolff escreveu:
> > > On Donnerstag, 11. Oktober 2018 21:39:20 CEST A
On Dienstag, 16. Oktober 2018 19:52:04 CEST Arnaldo Carvalho de Melo wrote:
> Em Tue, Oct 16, 2018 at 02:49:23PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Mon, Oct 15, 2018 at 10:51:36PM +0200, Milian Wolff escreveu:
> > > On Donnerstag, 11. Oktober 2018 21:39:20 CEST A
On Donnerstag, 11. Oktober 2018 21:39:20 CEST Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 11, 2018 at 08:23:31PM +0200, Milian Wolff escreveu:
> > On Donnerstag, 27. September 2018 21:10:37 CEST Arnaldo Carvalho de Melo
> >
> > wrote:
> > > Em Wed, Sep 26, 2018 at
On Donnerstag, 11. Oktober 2018 21:39:20 CEST Arnaldo Carvalho de Melo wrote:
> Em Thu, Oct 11, 2018 at 08:23:31PM +0200, Milian Wolff escreveu:
> > On Donnerstag, 27. September 2018 21:10:37 CEST Arnaldo Carvalho de Melo
> >
> > wrote:
> > > Em Wed, Sep 26, 2018 at
On Donnerstag, 27. September 2018 21:10:37 CEST Arnaldo Carvalho de Melo
wrote:
> Em Wed, Sep 26, 2018 at 03:52:07PM +0200, Milian Wolff escreveu:
> > When the function name for an inline frame is invalid, we must
> > not try to demangle this symbol, otherwise we crash wi
On Donnerstag, 27. September 2018 21:10:37 CEST Arnaldo Carvalho de Melo
wrote:
> Em Wed, Sep 26, 2018 at 03:52:07PM +0200, Milian Wolff escreveu:
> > When the function name for an inline frame is invalid, we must
> > not try to demangle this symbol, otherwise we crash wi
> log message for the patch this patch fixes, and combined the two into
> just one patch so that we don't pollute the bisect history, since this
> hasn't made it yet to tip, and I also added Ravi's Tested-by, since this
> tests both.
Thanks a lot for the cleanup work Arnaldo.
Cheers
-
> log message for the patch this patch fixes, and combined the two into
> just one patch so that we don't pollute the bisect history, since this
> hasn't made it yet to tip, and I also added Ravi's Tested-by, since this
> tests both.
Thanks a lot for the cleanup work Arnaldo.
Cheers
-
Commit-ID: 7a8a8fcf7b860e4b2d4edc787c844d41cad9dfcf
Gitweb: https://git.kernel.org/tip/7a8a8fcf7b860e4b2d4edc787c844d41cad9dfcf
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:06 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 5 Oct 2018 11:18:09 -0300
perf record
Commit-ID: 7a8a8fcf7b860e4b2d4edc787c844d41cad9dfcf
Gitweb: https://git.kernel.org/tip/7a8a8fcf7b860e4b2d4edc787c844d41cad9dfcf
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:06 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Fri, 5 Oct 2018 11:18:09 -0300
perf record
Commit-ID: ff4ce2885af8f9e8e99864d78dbeb4673f089c76
Gitweb: https://git.kernel.org/tip/ff4ce2885af8f9e8e99864d78dbeb4673f089c76
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:05 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 27 Sep 2018 16:05:43 -0300
perf report
Commit-ID: ff4ce2885af8f9e8e99864d78dbeb4673f089c76
Gitweb: https://git.kernel.org/tip/ff4ce2885af8f9e8e99864d78dbeb4673f089c76
Author: Milian Wolff
AuthorDate: Wed, 26 Sep 2018 15:52:05 +0200
Committer: Arnaldo Carvalho de Melo
CommitDate: Thu, 27 Sep 2018 16:05:43 -0300
perf report
shows that we desperately need
an automated test for inline frame resolution. I'll try to
come up with something for the various regressions in the future.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
Reported-by: Ravi Bangoria
# Tested-by:
# Reviewed-by:
# Suggested-b:
Fixes
shows that we desperately need
an automated test for inline frame resolution. I'll try to
come up with something for the various regressions in the future.
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
Reported-by: Ravi Bangoria
# Tested-by:
# Reviewed-by:
# Suggested-b:
Fixes
imilar for some time.
Hey Jiri,
what happened to this patch series? I also believe it's super useful, even
when it's not yet perfect.
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt, C++ and OpenGL Experts
smime.p7s
Description: S/MIME cryptographic signature
imilar for some time.
Hey Jiri,
what happened to this patch series? I also believe it's super useful, even
when it's not yet perfect.
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt, C++ and OpenGL Experts
smime.p7s
Description: S/MIME cryptographic signature
On Wednesday, September 26, 2018 4:18:19 PM CEST Arnaldo Carvalho de Melo
wrote:
> Em Wed, Sep 26, 2018 at 03:52:05PM +0200, Milian Wolff escreveu:
> > Fixes a crash when the report encounters an address that
>
> > could not be associated with an mmaped region:
> Milian, ca
On Wednesday, September 26, 2018 4:18:19 PM CEST Arnaldo Carvalho de Melo
wrote:
> Em Wed, Sep 26, 2018 at 03:52:05PM +0200, Milian Wolff escreveu:
> > Fixes a crash when the report encounters an address that
>
> > could not be associated with an mmaped region:
> Milian, ca
@entry=0x7fff97b8, evsel=, al=al@entry=0x7fff9750,
max_stack=) at util/callchain.c:1085
Signed-off-by: Milian Wolff
Cc: Sandipan Das
Cc: Arnaldo Carvalho de Melo
---
tools/perf/util/machine.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util
@entry=0x7fff97b8, evsel=, al=al@entry=0x7fff9750,
max_stack=) at util/callchain.c:1085
Signed-off-by: Milian Wolff
Cc: Sandipan Das
Cc: Arnaldo Carvalho de Melo
---
tools/perf/util/machine.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util
eed to use the same corrected address also when
trying to find inline frames.
This is another follow-up to commit 19610184693c ("perf script: Show
virtual addresses instead of offsets").
Signed-off-by: Milian Wolff
Cc: Sandipan Das
Cc: Arnaldo Carvalho de Melo
---
tools/perf/util/machine.
rceware.org/bugzilla/show_bug.cgi?id=23715
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
Reported-by: Hadrien Grasland
---
tools/perf/util/srcline.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 09d6746e6ec8..e767c4a9d4d2 100
eed to use the same corrected address also when
trying to find inline frames.
This is another follow-up to commit 19610184693c ("perf script: Show
virtual addresses instead of offsets").
Signed-off-by: Milian Wolff
Cc: Sandipan Das
Cc: Arnaldo Carvalho de Melo
---
tools/perf/util/machine.
rceware.org/bugzilla/show_bug.cgi?id=23715
Signed-off-by: Milian Wolff
Cc: Arnaldo Carvalho de Melo
Reported-by: Hadrien Grasland
---
tools/perf/util/srcline.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c
index 09d6746e6ec8..e767c4a9d4d2 100
es") Signed-off-by: Sandipan Das
>
> looks good to me, Milian?
>
> Acked-by: Jiri Olsa
Sorry for the delay, I was on vacation.
The above looks somewhat strange to me - why is there no `(inlined)` suffix
visible anymore?
Also, I can't test this patch locally, since - even without
es") Signed-off-by: Sandipan Das
>
> looks good to me, Milian?
>
> Acked-by: Jiri Olsa
Sorry for the delay, I was on vacation.
The above looks somewhat strange to me - why is there no `(inlined)` suffix
visible anymore?
Also, I can't test this patch locally, since - even without
s would be welcome to add more aspects of the file format there, even if
it's generated by the kernel? That helps for thirdparty tools that parse the
perf.data files (like perfparser used by QtCreator and hotspot).
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
K
s would be welcome to add more aspects of the file format there, even if
it's generated by the kernel? That helps for thirdparty tools that parse the
perf.data files (like perfparser used by QtCreator and hotspot).
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
K
documentation Documentation/perf.data-file-format.txt, but I
just noticed that not even PERF_RECORD_SWITCH is documented there...
Otherwise I also think that this would be a very nice feature addition!
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a
documentation Documentation/perf.data-file-format.txt, but I
just noticed that not even PERF_RECORD_SWITCH is documented there...
Otherwise I also think that this would be a very nice feature addition!
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH, a
tal-period | grep "Event count"
..
# Event count (approx.): 8000845488
$ nproc
8
```
The sleep-record script is available at:
https://github.com/milianw/shell-helpers/blob/master/perf-sleep-record
I believe your patch also fixes the sched_stat_* tracepoints to be only
emitted once per CPU
tal-period | grep "Event count"
..
# Event count (approx.): 8000845488
$ nproc
8
```
The sleep-record script is available at:
https://github.com/milianw/shell-helpers/blob/master/perf-sleep-record
I believe your patch also fixes the sched_stat_* tracepoints to be only
emitted once per CPU
On Wednesday, November 22, 2017 11:25:40 PM CET alexander.le...@verizon.com
wrote:
> From: Milian Wolff <milian.wo...@kdab.com>
>
> [ Upstream commit 9856240ad3269f2fdab0b2fa4400ef8aab792061 ]
Hello Alexander,
this is the first time I encounter AUTOSEL. I just want to check: T
On Wednesday, November 22, 2017 11:25:40 PM CET alexander.le...@verizon.com
wrote:
> From: Milian Wolff
>
> [ Upstream commit 9856240ad3269f2fdab0b2fa4400ef8aab792061 ]
Hello Alexander,
this is the first time I encounter AUTOSEL. I just want to check: The patch
below depends
ad -n 5
206aad x86_pmu_enable
380591 ctx_resched
380b46 __perf_event_enable
378716 event_function
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
ad -n 5
206aad x86_pmu_enable
380591 ctx_resched
380b46 __perf_event_enable
378716 event_function
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
ed to this area,
> but lets make some progress and merge this kit,
Thanks a lot for everyone involved in reviewing this series. Much appreciated!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
ed to this area,
> but lets make some progress and merge this kit,
Thanks a lot for everyone involved in reviewing this series. Much appreciated!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
Commit-ID: d8a88dd243a170a226aba33e7c53704db2f82aa6
Gitweb: https://git.kernel.org/tip/d8a88dd243a170a226aba33e7c53704db2f82aa6
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Thu, 19 Oct 2017 13:38:36 +0200
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
1 - 100 of 571 matches
Mail list logo
