Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-05-26 Thread Steven Toth
ikely get a better technical discussion going on. Send me a detailed picture of the PCB and I can probably help spot the I2C bus for you, if you have a low cost bus analyzer and a soldering iron. -- Steven Toth - Kernel Labs http://www.kernellabs.com

Re: [PATCH 1/3] [media] si2157: get chip id during probing

2017-05-26 Thread Steven Toth
ikely get a better technical discussion going on. Send me a detailed picture of the PCB and I can probably help spot the I2C bus for you, if you have a low cost bus analyzer and a soldering iron. -- Steven Toth - Kernel Labs http://www.kernellabs.com

Re: [PATCH v1 2/5] saa7164: convert to seq_hex_dump()

2014-07-09 Thread Steven Toth
On Wed, Jul 9, 2014 at 11:24 AM, Andy Shevchenko wrote: > Instead of custom approach let's use recently added seq_hex_dump() helper. > > Signed-off-by: Andy Shevchenko ack Reviewed-by: Steven Toth -- Steven Toth - Kernel Labs http://www.kernellabs.com -- To unsubscribe from this l

Re: [PATCH v1 2/5] saa7164: convert to seq_hex_dump()

2014-07-09 Thread Steven Toth
On Wed, Jul 9, 2014 at 11:24 AM, Andy Shevchenko andriy.shevche...@linux.intel.com wrote: Instead of custom approach let's use recently added seq_hex_dump() helper. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com ack Reviewed-by: Steven Toth st...@kernellabs.com -- Steven

Re: [v4l-dvb-maintainer] [2.6 patch] dvb/frontends/xc5000.c: make a struct static

2008-01-28 Thread Steven Toth
Adrian Bunk wrote: struct XC5000_Standard[] can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Reviewed-by: Steven Toth <[EMAIL PROTECTED]> Thanks Adrian. Mauro, please merge. - Steve --- e1f9c8304c807ecce026156ee2185925295fe835 diff --git a/drivers/media/d

Re: [v4l-dvb-maintainer] [2.6 patch] dvb/frontends/xc5000.c: make a struct static

2008-01-28 Thread Steven Toth
Adrian Bunk wrote: struct XC5000_Standard[] can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Reviewed-by: Steven Toth [EMAIL PROTECTED] Thanks Adrian. Mauro, please merge. - Steve --- e1f9c8304c807ecce026156ee2185925295fe835 diff --git a/drivers/media/dvb/frontends

Re: [v4l-dvb-maintainer] [2.6 patch] media/video/cx23885/: cleanups

2007-11-05 Thread Steven Toth
unsigned int bpl, u32 risc); - /* --- */ /* cx23885-cards.c*/ ___ v4l-dvb-maintainer mailing list [EMAIL PROTECTED] http://www.linuxtv.org/cgi-bin/mailman/listinfo

Re: [v4l-dvb-maintainer] [2.6 patch] media/video/cx23885/: cleanups

2007-11-05 Thread Steven Toth
*/ ___ v4l-dvb-maintainer mailing list [EMAIL PROTECTED] http://www.linuxtv.org/cgi-bin/mailman/listinfo/v4l-dvb-maintainer Thanks Adrian. Signed-off-by: Steven Toth ([EMAIL PROTECTED]) - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] Double-free in cx23885_initdev [sls][spam-bayes]

2007-10-13 Thread Steven Toth
Thanks for the patch, much appreciated. - Steve Florin Malita wrote: Both cx23885_initdev and cx23885_dev_setup free the device in their error path so a failure in the latter causes a double-free. Since cx23885_dev_setup is only called from cx23885_initdev, it should be safe to remove its

Re: [PATCH] Double-free in cx23885_initdev [sls][spam-bayes]

2007-10-13 Thread Steven Toth
Thanks for the patch, much appreciated. - Steve Florin Malita wrote: Both cx23885_initdev and cx23885_dev_setup free the device in their error path so a failure in the latter causes a double-free. Since cx23885_dev_setup is only called from cx23885_initdev, it should be safe to remove its

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-15 Thread Steven Toth
Johannes Stezenbach wrote: On Sat, Sep 15, 2007, Markus Rechberger wrote: The main discussion in this thread was about drivers in userspace are bad because the API will allow binary drivers. The guy who works for Hauppauge (again I also have good contacts at Hauppauge Europe) writes it's bad

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-15 Thread Steven Toth
Johannes Stezenbach wrote: On Sat, Sep 15, 2007, Markus Rechberger wrote: The main discussion in this thread was about drivers in userspace are bad because the API will allow binary drivers. The guy who works for Hauppauge (again I also have good contacts at Hauppauge Europe) writes it's bad

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-13 Thread Steven Toth
Markus Rechberger wrote: On 9/13/07, Steven Toth <[EMAIL PROTECTED]> wrote: Also there is to consider a non technical aspect, whether vendors will misuse this interface for binary only, undermining the efforts put in for OSS drivers. What holds companies for using the c

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-13 Thread Steven Toth
Also there is to consider a non technical aspect, whether vendors will misuse this interface for binary only, undermining the efforts put in for OSS drivers. What holds companies for using the current available code putting it into an rpm or deb package and releasing such code now?

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-13 Thread Steven Toth
Also there is to consider a non technical aspect, whether vendors will misuse this interface for binary only, undermining the efforts put in for OSS drivers. What holds companies for using the current available code putting it into an rpm or deb package and releasing such code now?

Re: [linux-dvb] [PATCH] Userspace tuner

2007-09-13 Thread Steven Toth
Markus Rechberger wrote: On 9/13/07, Steven Toth [EMAIL PROTECTED] wrote: Also there is to consider a non technical aspect, whether vendors will misuse this interface for binary only, undermining the efforts put in for OSS drivers. What holds companies for using the current

Re: [linux-dvb] SAA7160/2

2007-08-01 Thread Steven Toth
Manu Abraham wrote: Hi All, After a bit of talks with NXP, they stated that if shown enough of a user base (future business forecast) for the SAA7160 / SAA7162 PCIe chipset, they would take into consideration, an investment into support, such that the chips can be better supported. ie, i need

Re: [linux-dvb] SAA7160/2

2007-08-01 Thread Steven Toth
Manu Abraham wrote: Hi All, After a bit of talks with NXP, they stated that if shown enough of a user base (future business forecast) for the SAA7160 / SAA7162 PCIe chipset, they would take into consideration, an investment into support, such that the chips can be better supported. ie, i need