Re: linux-next: Fixes tags need some work in the tip tree

On 10/22/19 10:17 PM, Stephen Rothwell wrote: > Hi all, > > n commit > > 6fee2a0be0ec ("x86/cpu/vmware: Fix platform detection VMWARE_PORT macro") > > Fixes tag > > Fixes: b4dd4f6e3648 ("Add a header file for hypercall definitions") The cited subject is missing a leading "x86/vmware:". Ingo,

[tip: x86/urgent] x86/cpu/vmware: Fix platform detection VMWARE_PORT macro

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 6fee2a0be0ecae939d4b6cd8297d88b5cbb61654 Gitweb: https://git.kernel.org/tip/6fee2a0be0ecae939d4b6cd8297d88b5cbb61654 Author:Thomas Hellstrom AuthorDate:Mon, 21 Oct 2019 19:24:03 +02:00

[tip: x86/urgent] x86/cpu/vmware: Use the full form of INL in VMWARE_HYPERCALL, for clang/llvm

The following commit has been merged into the x86/urgent branch of tip: Commit-ID: db633a4e0e6eda69b6065e3e106f9ea13a0676c3 Gitweb: https://git.kernel.org/tip/db633a4e0e6eda69b6065e3e106f9ea13a0676c3 Author:Thomas Hellstrom AuthorDate:Mon, 21 Oct 2019 19:24:02 +02:00

Re: [PATCH v6 0/8] Emulated coherent graphics memory take 2

On 10/14/19 3:22 PM, Thomas Hellström (VMware) wrote: > From: Thomas Hellström > > Graphics APIs like OpenGL 4.4 and Vulkan require the graphics driver > to provide coherent graphics memory, meaning that the GPU sees any > content written to the coherent memory on the next GPU operation that >

Re: [PATCH v4 3/9] mm: pagewalk: Don't split transhuge pmds when a pmd_entry is present

Hi, On 10/9/19 7:17 PM, Linus Torvalds wrote: > On Wed, Oct 9, 2019 at 10:03 AM Thomas Hellström (VMware) > wrote: >> Nope, it handles the hugepages by ignoring them, since they should be >> read-only, but if pmd_entry() was called with something else than a >> hugepage, then it requests the

Re: [PATCH v4 5/9] mm: Add write-protect and clean utilities for address space ranges

On 10/8/19 7:07 PM, Linus Torvalds wrote: > On Tue, Oct 8, 2019 at 2:15 AM Thomas Hellström (VMware) > wrote: >> Add two utilities to 1) write-protect and 2) clean all ptes pointing into >> a range of an address space. > The code looks much simpler and easier to understand now, I think, but >

Re: [PATCH] x86/cpu/vmware: use the full form of inl in VMWARE_PORT

; LLVM ERROR: Error parsing inline asm > > Use the full form of the instruction to fix the build. > > Signed-off-by: Sami Tolvanen Acked-by: Thomas Hellstrom > --- > arch/x86/kernel/cpu/vmware.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v3 3/7] mm: Add write-protect and clean utilities for address space ranges

On 10/2/19 10:28 PM, Linus Torvalds wrote: > On Wed, Oct 2, 2019 at 12:09 PM Thomas Hellström (VMware) > wrote: >> Yes I typically tend towards using a "namespace_object_operation" naming >> scheme, with "as_dirty" being the namespace here, > We discourage that kind of mindless namespacing for

Re: [PATCH v3 1/2] x86: Don't let pgprot_modify() change the page encryption bit

Hi, On 9/18/19 7:57 PM, Dave Hansen wrote: > On 9/17/19 6:01 AM, Thomas Hellström (VMware) wrote: >> diff --git a/arch/x86/include/asm/pgtable_types.h >> b/arch/x86/include/asm/pgtable_types.h >> index b5e49e6bac63..8267dd426b15 100644 >> --- a/arch/x86/include/asm/pgtable_types.h >> +++

Re: [PATCH 7/8] drm/vmwgfx: switch to own vma manager

On Thu, 2019-09-05 at 09:05 +0200, Gerd Hoffmann wrote: > Add struct drm_vma_offset_manager to vma_private, initialize it and > pass it to ttm_bo_device_init(). > > With this in place the last user of ttm's embedded vma offset manager > is gone and we can remove it (in a separate patch). > >

[tip: x86/vmware] x86/vmware: Add a header file for hypercall definitions

The following commit has been merged into the x86/vmware branch of tip: Commit-ID: b4dd4f6e3648dfd66576515fd885a9a765c0 Gitweb: https://git.kernel.org/tip/b4dd4f6e3648dfd66576515fd885a9a765c0 Author:Thomas Hellstrom AuthorDate:Wed, 28 Aug 2019 10:03:51 +02:00

[tip: x86/vmware] x86/vmware: Update platform detection code for VMCALL/VMMCALL hypercalls

The following commit has been merged into the x86/vmware branch of tip: Commit-ID: bac7b4e843232a3a49a042410cf743341eb0887e Gitweb: https://git.kernel.org/tip/bac7b4e843232a3a49a042410cf743341eb0887e Author:Thomas Hellstrom AuthorDate:Wed, 28 Aug 2019 10:03:50 +02:00

[tip: x86/vmware] drm/vmwgfx: Update the backdoor call with support for new instructions

The following commit has been merged into the x86/vmware branch of tip: Commit-ID: 6abe3778cf5abd59b23b9037796f3eab8b7f1d98 Gitweb: https://git.kernel.org/tip/6abe3778cf5abd59b23b9037796f3eab8b7f1d98 Author:Thomas Hellstrom AuthorDate:Wed, 28 Aug 2019 10:03:52 +02:00

[tip: x86/vmware] input/vmmouse: Update the backdoor call with support for new instructions

The following commit has been merged into the x86/vmware branch of tip: Commit-ID: f7b15c74cffd760ec9959078982d8268a38456c4 Gitweb: https://git.kernel.org/tip/f7b15c74cffd760ec9959078982d8268a38456c4 Author:Thomas Hellstrom AuthorDate:Wed, 28 Aug 2019 10:03:53 +02:00

Re: cleanup the walk_page_range interface

On 8/8/19 11:56 PM, Christoph Hellwig wrote: On Thu, Aug 08, 2019 at 10:50:37AM -0700, Linus Torvalds wrote: Note that both Thomas and Steven have series touching this area pending, and there are a couple consumer in flux too - the hmm tree already conflicts with this series, and I have

Re: [PATCH 2/3] pagewalk: seperate function pointers from iterator data

on patch from Linus Torvalds. Signed-off-by: Christoph Hellwig --- Typo: For the patch title s/seperate/separate/ Otherwise for the series Reviewed-by: Thomas Hellstrom /Thomas

[tip:x86/urgent] MAINTAINERS: Update PARAVIRT_OPS_INTERFACE and VMWARE_HYPERVISOR_INTERFACE

Commit-ID: 406de552c2be6ded524c75d14a73cf7f027f587e Gitweb: https://git.kernel.org/tip/406de552c2be6ded524c75d14a73cf7f027f587e Author: Thomas Hellstrom AuthorDate: Thu, 28 Mar 2019 12:06:37 + Committer: Thomas Gleixner CommitDate: Wed, 17 Jul 2019 00:42:27 +0200 MAINTAINERS

[tip:x86/urgent] MAINTAINERS: Update PARAVIRT_OPS_INTERFACE and VMWARE_HYPERVISOR_INTERFACE

Commit-ID: 907cb11da7a725445dccc6c2ca2d428739f6cd71 Gitweb: https://git.kernel.org/tip/907cb11da7a725445dccc6c2ca2d428739f6cd71 Author: Thomas Hellstrom AuthorDate: Thu, 28 Mar 2019 12:06:37 + Committer: Thomas Gleixner CommitDate: Tue, 16 Jul 2019 23:13:50 +0200 MAINTAINERS

Re: [PATCH] drm/vmwgfx: integer underflow in vmw_cmd_dx_set_shader() leading to an invalid read

Thanks, Murray, I'll include in the next vmwgfx-fixes pull request. On Mon, 2019-05-20 at 21:57 +1200, Murray McAllister wrote: > If SVGA_3D_CMD_DX_SET_SHADER is called with a shader ID > of SVGA3D_INVALID_ID, and a shader type of > SVGA3D_SHADERTYPE_INVALID, the calculated binding.shader_slot >

[PATCH 9/9] drm/vmwgfx: Add surface dirty-tracking callbacks

Add the callbacks necessary to implement emulated coherent memory for surfaces. Add a flag to the gb_surface_create ioctl to indicate that surface memory should be coherent. Also bump the drm minor version to signal the availability of coherent surfaces. Signed-off-by: Thomas Hellstrom

Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

a_address() works as expected with all sglists. > > A new iterator type is introduced to provide compile-time safety > against > wrongly mixing accessors and iterators. > > Acked-by: Christoph Hellwig (for scatterlist) > Signed-off-by: Jason Gunthorpe > For the vmwgfx

Re: [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs v2

On Mon, 2019-02-04 at 13:11 +0100, Thomas Hellström wrote: > On Mon, 2019-02-04 at 09:19 +0100, Christoph Hellwig wrote: > > On Fri, Jan 25, 2019 at 09:12:13AM +0100, Thomas Hellstrom wrote: > > > -#if !defined(CONFIG_SWIOTLB) && !defined(CONFIG_INTEL_IOMMU) > > &g

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

On Thu, 2019-01-17 at 10:30 +0100, h...@lst.de wrote: > On Wed, Jan 16, 2019 at 10:24:36AM -0700, Jason Gunthorpe wrote: > > The fact is there is 0 industry interest in using RDMA on platforms > > that can't do HW DMA cache coherency - the kernel syscalls required > > to > > do the cache flushing

Re: [PATCH v4 2/3] locking: Implement an algorithm choice for Wound-Wait mutexes

s >  ~/src/linux   master  git log --pretty=format:%H > drivers/gpu/drm/drm_modeset_lock.c | grep > 08295b3b5beec9aac0f7a9db86f0fc3792039da3 >  ~/src/linux   master  1  > > > BR, > -R > > > On Tue, Jun 19, 2018 at 4:29 AM Thomas Hellstrom < > thellst...@vmware

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

On Tue, 2019-01-15 at 21:58 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 07:13:11PM +, Koenig, Christian wrote: > > Thomas is correct that the interface you propose here doesn't work > > at > > all for GPUs. > > > > The kernel driver is not informed of flush/sync, but rather just > >

Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'srf'

Yue, Thanks, Reviewed-by: Thomas Hellstrom Will include in the next -next pull. /Thomas On Wed, 2019-01-16 at 01:55 +, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/vmwgfx/vmwgfx_surface.c: In function > 'vmw_hw_surface_destroy': >

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

On Tue, 2019-01-15 at 16:20 +0100, h...@lst.de wrote: > On Tue, Jan 15, 2019 at 03:24:55PM +0100, Christian König wrote: > > Yeah, indeed. Bounce buffers are an absolute no-go for GPUs. > > > > If the DMA API finds that a piece of memory is not directly > > accessible by > > the GPU we need to

Re: [PATCH] lib/scatterlist: Provide a DMA page iterator

Hi, Christoph, On Mon, 2019-01-14 at 10:48 +0100, Christoph Hellwig wrote: > On Thu, Jan 10, 2019 at 04:42:18PM -0700, Jason Gunthorpe wrote: > > > Changes since the RFC: > > > - Rework vmwgfx too [CH] > > > - Use a distinct type for the DMA page iterator [CH] > > > - Do not have a #ifdef [CH] >

Re: fix DMA ops layering violations in vmwgfx

On Tue, 2019-01-08 at 14:12 +0100, h...@lst.de wrote: > On Tue, Jan 08, 2019 at 09:51:45AM +0000, Thomas Hellstrom wrote: > > Hi, Christoph, > > > > On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: > > > Hi Thomas, > > > > > > vmwgfx

Re: [PATCH 4/4] drm/vmwgfx: unwind spaghetti code in vmw_dma_select_mode

On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: > Just use a simple if/else chain to select the DMA mode. > > Signed-off-by: Christoph Hellwig Reviewed-by: Thomas Hellstrom > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 25 ++--- > 1 file cha

Re: [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs

Hi, On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: ... > intel_iommu_enabled is defined as always false for > !CONFIG_INTEL_IOMMU, > so remove the ifdefs around it. > > Signed-off-by: Christoph Hellwig > --- > > -#if !defined(CONFIG_SWIOTLB) && !defined(CONFIG_INTEL_IOMMU) > -

Re: [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs

Reviewed-by: Thomas Hellstrom On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: > intel_iommu_enabled is defined as always false for > !CONFIG_INTEL_IOMMU, > so remove the ifdefs around it. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/vmw

Re: fix DMA ops layering violations in vmwgfx

Hi, Christoph, On Sat, 2019-01-05 at 09:01 +0100, Christoph Hellwig wrote: > Hi Thomas, > > vmwgfx has been doing some odd checks based on DMA ops which rely > on deep DMA mapping layer internals, and I think the changes in > Linux 4.21 finally broke most of these implicit assumptions. Thanks.

Re: [PATCH][drm-next] drm/selftest: fix spelling mistake "dimention" -> "dimenstion"

On Mon, 2018-12-10 at 09:26 +, Colin King wrote: Reviewed-by: Thomas Hellstrom I'll take this in the next pull request unless I'm told otherwise. /Thomas > From: Colin Ian King > > There is a spelling mistake in a pr_err message, fix this. > > Signed-off-by:

[tip:locking/core] locking/mutex: Fix mutex debug call and ww_mutex documentation

Commit-ID: e13e2366d8415e029fe96a62502955083e272cef Gitweb: https://git.kernel.org/tip/e13e2366d8415e029fe96a62502955083e272cef Author: Thomas Hellstrom AuthorDate: Mon, 3 Sep 2018 16:07:08 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 10:05:10 +0200 locking/mutex: Fix

[tip:locking/core] locking/mutex: Fix mutex debug call and ww_mutex documentation

Commit-ID: e13e2366d8415e029fe96a62502955083e272cef Gitweb: https://git.kernel.org/tip/e13e2366d8415e029fe96a62502955083e272cef Author: Thomas Hellstrom AuthorDate: Mon, 3 Sep 2018 16:07:08 +0200 Committer: Ingo Molnar CommitDate: Mon, 10 Sep 2018 10:05:10 +0200 locking/mutex: Fix

Re: [PATCH v4 0/4] locking,drm: Fix ww mutex naming / algorithm inconsistency

On 06/19/2018 11:45 AM, Peter Zijlstra wrote: I suspect you want this through the DRM tree? Ingo are you OK with that? Yes, I can ask Dave to pull this. Ingo? Thanks, Thomas

Re: [PATCH v4 0/4] locking,drm: Fix ww mutex naming / algorithm inconsistency

On 06/19/2018 11:45 AM, Peter Zijlstra wrote: I suspect you want this through the DRM tree? Ingo are you OK with that? Yes, I can ask Dave to pull this. Ingo? Thanks, Thomas

Re: [PATCH 1/3] locking: WW mutex cleanup

On 06/19/2018 11:44 AM, Peter Zijlstra wrote: On Tue, Jun 19, 2018 at 10:24:43AM +0200, Thomas Hellstrom wrote: From: Peter Ziljstra Make the WW mutex code more readable by adding comments, splitting up functions and pointing out that we're actually using the Wait-Die algorithm. Cc: Ingo

Re: [PATCH 1/3] locking: WW mutex cleanup

On 06/19/2018 11:44 AM, Peter Zijlstra wrote: On Tue, Jun 19, 2018 at 10:24:43AM +0200, Thomas Hellstrom wrote: From: Peter Ziljstra Make the WW mutex code more readable by adding comments, splitting up functions and pointing out that we're actually using the Wait-Die algorithm. Cc: Ingo

Re: [PATCH v2 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

On 06/14/2018 03:29 PM, Matthew Wilcox wrote: On Thu, Jun 14, 2018 at 01:54:15PM +0200, Thomas Hellstrom wrote: On 06/14/2018 01:36 PM, Peter Zijlstra wrote: Currently you don't allow mixing WD and WW contexts (which is not immediately obvious from the above code), and the above hard relies

Re: [PATCH v2 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

On 06/14/2018 03:29 PM, Matthew Wilcox wrote: On Thu, Jun 14, 2018 at 01:54:15PM +0200, Thomas Hellstrom wrote: On 06/14/2018 01:36 PM, Peter Zijlstra wrote: Currently you don't allow mixing WD and WW contexts (which is not immediately obvious from the above code), and the above hard relies

[PATCH 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

h Triplett Cc: Thomas Gleixner Cc: Kate Stewart Cc: Philippe Ombredanne Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Thomas Hellstrom --- Documentation/locking/ww-mutex-design.txt | 57 ++ d

[PATCH 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

h Triplett Cc: Thomas Gleixner Cc: Kate Stewart Cc: Philippe Ombredanne Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Thomas Hellstrom --- Documentation/locking/ww-mutex-design.txt | 57 ++ d

[PATCH RFC 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

of simultaneous contending transactions is small. As the number of simultaneous contending threads increases, Wait-Wound becomes inferior to Wait-Die, probably due to the larger number of held locks of sleeping transactions. Update documentation and callers. Signed-off-by: Thomas Hellstrom <thel

[PATCH RFC 1/2] locking: Implement an algorithm choice for Wound-Wait mutexes

of simultaneous contending transactions is small. As the number of simultaneous contending threads increases, Wait-Wound becomes inferior to Wait-Die, probably due to the larger number of held locks of sleeping transactions. Update documentation and callers. Signed-off-by: Thomas Hellstrom

[PATCH RFC 0/2] locking: Fix ww_mutex algorithm inconsistency.

The algorithm used for linux Wound/Wait mutexes, is actually not Wound/Wait but Wait/Die. See for example http://www.mathcs.emory.edu/~cheung/Courses/554/Syllabus/8-recv+serial/deadlock-compare.html Rather than renaming them across the tree to something like Wait/Die mutexes or Deadlock

[PATCH RFC 2/2] drm: Change deadlock-avoidance algorithm for the modeset locks.

For modeset locks we don't expect a high number of contending transactions so change algorithm from Wait-Die to Wound-Wait. Signed-off-by: Thomas Hellstrom <thellst...@vmware.com> --- drivers/gpu/drm/drm_modeset_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH RFC 0/2] locking: Fix ww_mutex algorithm inconsistency.

The algorithm used for linux Wound/Wait mutexes, is actually not Wound/Wait but Wait/Die. See for example http://www.mathcs.emory.edu/~cheung/Courses/554/Syllabus/8-recv+serial/deadlock-compare.html Rather than renaming them across the tree to something like Wait/Die mutexes or Deadlock

[PATCH RFC 2/2] drm: Change deadlock-avoidance algorithm for the modeset locks.

For modeset locks we don't expect a high number of contending transactions so change algorithm from Wait-Die to Wound-Wait. Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/drm_modeset_lock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm

Re: [PATCH] drm/vmwgfx: Fix scatterlist unmapping

On 04/27/2018 06:56 PM, Robin Murphy wrote: Hi Thomas, On 25/04/18 14:21, Thomas Hellstrom wrote: Hi, Robin, Thanks for the patch. It was some time since I put together that code, but I remember hitting something similar to https://urldefense.proofpoint.com/v2/url?u=https

Re: [PATCH] drm/vmwgfx: Fix scatterlist unmapping

On 04/27/2018 06:56 PM, Robin Murphy wrote: Hi Thomas, On 25/04/18 14:21, Thomas Hellstrom wrote: Hi, Robin, Thanks for the patch. It was some time since I put together that code, but I remember hitting something similar to https://urldefense.proofpoint.com/v2/url?u=https

Re: [PATCH] drm/vmwgfx: Fix scatterlist unmapping

Hi, Robin, Thanks for the patch. It was some time since I put together that code, but I remember hitting something similar to https://www.linuxquestions.org/questions/linux-kernel-70/%27nents%27-argument-of-dma_unmap_sg-4175621964/ Even if it's clear from the documentation that orig_nents

Re: [PATCH] drm/vmwgfx: Fix scatterlist unmapping

Hi, Robin, Thanks for the patch. It was some time since I put together that code, but I remember hitting something similar to https://www.linuxquestions.org/questions/linux-kernel-70/%27nents%27-argument-of-dma_unmap_sg-4175621964/ Even if it's clear from the documentation that orig_nents

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 03:47 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 01:35:25PM +0200, Thomas Hellstrom wrote: On 04/05/2018 12:03 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 11:00:15AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 03:47 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 01:35:25PM +0200, Thomas Hellstrom wrote: On 04/05/2018 12:03 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 11:00:15AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 12:10 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 10:49:09AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:52 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:07PM -0700, Deepak Rawat wrote: With damage property in drm_plane_state, this patch adds helper iterator

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 12:10 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 10:49:09AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:52 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:07PM -0700, Deepak Rawat wrote: With damage property in drm_plane_state, this patch adds helper iterator

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 12:03 PM, Daniel Vetter wrote: On the topic of input validation: Should the kernel check in shared code that all the clip rects are sensible, i.e. within the dimensions of the fb? Relying on drivers for that seems like a bad idea. I guess we could do that. There seems to be

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 12:03 PM, Daniel Vetter wrote: On the topic of input validation: Should the kernel check in shared code that all the clip rects are sensible, i.e. within the dimensions of the fb? Relying on drivers for that seems like a bad idea. I guess we could do that. There seems to be

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 12:03 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 11:00:15AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:06PM -0700, Deepak Rawat wrote: From: Lukasz Spintzyk <lukasz.spint...@displaylink.com> Optional

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 12:03 PM, Daniel Vetter wrote: On Thu, Apr 05, 2018 at 11:00:15AM +0200, Thomas Hellstrom wrote: On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:06PM -0700, Deepak Rawat wrote: From: Lukasz Spintzyk Optional plane property to mark damaged regions

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:06PM -0700, Deepak Rawat wrote: From: Lukasz Spintzyk Optional plane property to mark damaged regions on the plane in framebuffer coordinates of the framebuffer attached to the plane.

Re: [RFC 1/3] drm: Add DAMAGE_CLIPS property to plane

On 04/05/2018 09:35 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:06PM -0700, Deepak Rawat wrote: From: Lukasz Spintzyk Optional plane property to mark damaged regions on the plane in framebuffer coordinates of the framebuffer attached to the plane. The layout of blob data is simply

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 09:52 AM, Daniel Vetter wrote: TYPE_PLANE I have no idea who needs that. I suggest we just drop it. I'm assuming CRTC plane coordinates here. They are used for uploading contents of hardware planes. Like, in the simplest case, cursor images. /Thomas

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 09:52 AM, Daniel Vetter wrote: TYPE_PLANE I have no idea who needs that. I suggest we just drop it. I'm assuming CRTC plane coordinates here. They are used for uploading contents of hardware planes. Like, in the simplest case, cursor images. /Thomas

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 09:52 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:07PM -0700, Deepak Rawat wrote: With damage property in drm_plane_state, this patch adds helper iterator to traverse the damage clips. Iterator will return the damage rectangles in framebuffer, plane or crtc coordinates

Re: [RFC 2/3] drm: Add helper iterator functions to iterate over plane damage.

On 04/05/2018 09:52 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 04:49:07PM -0700, Deepak Rawat wrote: With damage property in drm_plane_state, this patch adds helper iterator to traverse the damage clips. Iterator will return the damage rectangles in framebuffer, plane or crtc coordinates

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 12:28 PM, Thomas Hellstrom wrote: On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 12:28 PM, Thomas Hellstrom wrote: On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 11:56 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 11:10:08AM +0200, Thomas Hellstrom wrote: On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark <robdcl...@gmail.com> wrote: Add an atomic helper to implement dirtyfb s

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

On 04/04/2018 10:43 AM, Daniel Vetter wrote: On Wed, Apr 04, 2018 at 10:22:21AM +0200, Thomas Hellstrom wrote: Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is needed to support DSI

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

Hi, On 04/04/2018 08:58 AM, Daniel Vetter wrote: On Wed, Apr 4, 2018 at 12:42 AM, Rob Clark wrote: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a flush to the panel).

Re: Signal handling in a page fault handler

On 04/03/2018 02:33 PM, Chris Wilson wrote: Quoting Matthew Wilcox (2018-04-02 15:10:58) Souptick and I have been auditing the various page fault handler routines and we've noticed that graphics drivers assume that a signal should be able to interrupt a page fault. In contrast, the page cache

Re: Signal handling in a page fault handler

On 04/03/2018 02:33 PM, Chris Wilson wrote: Quoting Matthew Wilcox (2018-04-02 15:10:58) Souptick and I have been auditing the various page fault handler routines and we've noticed that graphics drivers assume that a signal should be able to interrupt a page fault. In contrast, the page cache

Re: [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled

On 01/19/2018 01:02 AM, Gustavo A. R. Silva wrote: Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Thomas Hellström

Re: [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled

On 01/19/2018 01:02 AM, Gustavo A. R. Silva wrote: Return statements in functions returning bool should use true/false instead of 1/0. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva Reviewed-by: Thomas Hellström I'll queue this for 4.17. Thanks,

Re: linux-next: Signed-off-by missing for commit in the drm-misc-fixes tree

Hi, Stephen, That would be me. I've historically only added my signed-off-by:s on commits I've (co-) authored myself, as the committer info is already registered, But I take it that's not the correct approach? /Thomas On 01/18/2018 09:23 PM, Stephen Rothwell wrote: Hi all, Commit

Re: linux-next: Signed-off-by missing for commit in the drm-misc-fixes tree

Hi, Stephen, That would be me. I've historically only added my signed-off-by:s on commits I've (co-) authored myself, as the committer info is already registered, But I take it that's not the correct approach? /Thomas On 01/18/2018 09:23 PM, Stephen Rothwell wrote: Hi all, Commit

Re: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

nector state block and all sorts of fun memory corruption related crashes. Fixes: d7721ca71126 "drm/vmwgfx: Connector atomic state" Cc: <sta...@vger.kernel.org> Signed-off-by: Rob Clark <rcl...@redhat.com> Reviewed-by: Thomas Hellstrom <thellst...@vmware.com> Thanks, Rob!

Re: [PATCH] drm/vmwgfx: fix memory corruption with legacy/sou connectors

sorts of fun memory corruption related crashes. Fixes: d7721ca71126 "drm/vmwgfx: Connector atomic state" Cc: Signed-off-by: Rob Clark Reviewed-by: Thomas Hellstrom Thanks, Rob! /Thomas --- drivers/gpu/drm/vmwgfx/vmwgfx_ldu.c | 4 ++-- drivers/gpu/drm/vmwgfx/vmwgfx_scrn.c |

Re: drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

On 01/17/2018 07:33 AM, Thomas Hellstrom wrote: Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This look

Re: drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

On 01/17/2018 07:33 AM, Thomas Hellstrom wrote: Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This look

drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This looks okay to me. Since this is a core DRM patch I think

drm: fix vmwgfx boot warning WAS Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

Hi, Woody, On 01/16/2018 10:39 PM, Woody Suwalski wrote: Thomas, the same way my DRM patch has disappeared: Date Tue, 19 Dec 2017 11:50:57 -0800 From Sinclair Yeh <> Subject Re: [PATCH v.2] 4.15 vmgfx boot warning This looks okay to me. Since this is a core DRM patch I think

Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

Hi, Arnd, Sinclair's on paternal leave and I thought this patch was already in drm-next. My bad. Dave, is it too late to pull this in for the next merge window? /Thomas On 01/16/2018 06:18 PM, Arnd Bergmann wrote: DRM_VMW_EVENT_FENCE_SIGNALED (struct drm_vmw_event_fence) and

Re: [PATCH] [RESEND] vmwgfx: use monotonic event timestamps

Hi, Arnd, Sinclair's on paternal leave and I thought this patch was already in drm-next. My bad. Dave, is it too late to pull this in for the next merge window? /Thomas On 01/16/2018 06:18 PM, Arnd Bergmann wrote: DRM_VMW_EVENT_FENCE_SIGNALED (struct drm_vmw_event_fence) and

Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

Hi, Colin, On 09/12/2017 07:35 PM, Colin King wrote: From: Colin Ian King mmap'ing the device multiple times will spam the kernel log with the DRM_ERROR message about illegal mmap'ing the old fifo space. How are you hitting this? Multiple mappings should be fine as

Re: [PATCH] drm/vmwgfx: remove DRM_ERROR message, stops log spamming

Hi, Colin, On 09/12/2017 07:35 PM, Colin King wrote: From: Colin Ian King mmap'ing the device multiple times will spam the kernel log with the DRM_ERROR message about illegal mmap'ing the old fifo space. How are you hitting this? Multiple mappings should be fine as long as mapping offsets

Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops

On 08/30/2017 10:30 AM, Daniel Vetter wrote: On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote: On 08/30/2017 07:47 AM, Arvind Yadav wrote: vmw_fence_ops are not supposed to change at runtime. Functions "dma_fence_init" working with const vmw_fence_ops provided by

Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops

On 08/30/2017 10:30 AM, Daniel Vetter wrote: On Wed, Aug 30, 2017 at 08:21:46AM +0200, Thomas Hellstrom wrote: On 08/30/2017 07:47 AM, Arvind Yadav wrote: vmw_fence_ops are not supposed to change at runtime. Functions "dma_fence_init" working with const vmw_fence_ops provided by

Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops

et_timeline_name = vmw_fence_get_timeline_name, .enable_signaling = vmw_fence_enable_signaling, Reviewed-by: Thomas Hellstrom <thellst...@vmware.com>

Re: [PATCH] drm: vmwgfx: constify vmw_fence_ops

eline_name, .enable_signaling = vmw_fence_enable_signaling, Reviewed-by: Thomas Hellstrom

Re: [PATCH 28/29] drm/vmwgfx: switch to drm_*{get,put} helpers

adback_ioctl(struct drm_device *dev, void *data, ttm_read_unlock(_priv->reservation_sem); out_no_ttm_lock: - drm_framebuffer_unreference(fb); + drm_framebuffer_put(fb); out_no_fb: drm_modeset_unlock_all(dev); out_no_copy: Apart from the above, Reviewed-by: T

Re: [PATCH 28/29] drm/vmwgfx: switch to drm_*{get,put} helpers

device *dev, void *data, ttm_read_unlock(_priv->reservation_sem); out_no_ttm_lock: - drm_framebuffer_unreference(fb); + drm_framebuffer_put(fb); out_no_fb: drm_modeset_unlock_all(dev); out_no_copy: Apart from the above, Reviewed-by: Thomas Hellstrom (Assuming

  1   2   3   4   >