Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 11:58:48 PM Rafael J. Wysocki wrote: > On Friday, October 11, 2013 10:21:35 AM Linus Torvalds wrote: > > On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki > > wrote: [...] > > Or am I misreading the code? It's more readable, and no longer makes > > me homicidal,

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 10:21:35 AM Linus Torvalds wrote: > On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki wrote: > > +/** > > + * slot_should_be_exposed - Check whether or not to expose a slot to > > userland. > > + * @bridge: ACPIPHP bridge the slot belongs to. > > + * @handle: ACPI

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Linus Torvalds
On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki wrote: > +/** > + * slot_should_be_exposed - Check whether or not to expose a slot to > userland. > + * @bridge: ACPIPHP bridge the slot belongs to. > + * @handle: ACPI handle of a device in the slot. > + */ > +static inline bool

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Bjorn Helgaas
On Fri, Oct 11, 2013 at 7:01 AM, Steven Rostedt wrote: > On Fri, 11 Oct 2013 13:13:47 +0200 > "Rafael J. Wysocki" wrote: >> >> From: Rafael J. Wysocki >> Subject: ACPI / hotplug / PCI: Accept coexistence with native PCIe hotplug >> >> Allow ACPIPHP (ACPI-based PCI hotplug) to handle event

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Jonathan Corbet
On Thu, 10 Oct 2013 18:00:48 -0700 Linus Torvalds wrote: > File a bug on Claws, and if the developers brush it off as your own > problem, just stop using the PoS. They acknowledge the bug - it was already known to them, actually. With luck we'll see a fix soon. jon -- To unsubscribe from this

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 13:13:47 +0200 "Rafael J. Wysocki" wrote: > > From: Rafael J. Wysocki > Subject: ACPI / hotplug / PCI: Accept coexistence with native PCIe hotplug > > Allow ACPIPHP (ACPI-based PCI hotplug) to handle event signaling for > devices that have already been claimed by the native

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 06:42:56 PM Linus Torvalds wrote: > On Thu, Oct 10, 2013 at 6:45 PM, Rafael J. Wysocki wrote: > > > > /* Register slots for ejectable funtions only. */ > > - if (acpi_pci_check_ejectable(pbus, handle) || > > is_dock_device(handle)) { > > + if

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 06:42:56 PM Linus Torvalds wrote: On Thu, Oct 10, 2013 at 6:45 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: /* Register slots for ejectable funtions only. */ - if (acpi_pci_check_ejectable(pbus, handle) || is_dock_device(handle)) { +

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Steven Rostedt
On Fri, 11 Oct 2013 13:13:47 +0200 Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: ACPI / hotplug / PCI: Accept coexistence with native PCIe hotplug Allow ACPIPHP (ACPI-based PCI hotplug) to handle event signaling for devices that

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Jonathan Corbet
On Thu, 10 Oct 2013 18:00:48 -0700 Linus Torvalds torva...@linux-foundation.org wrote: File a bug on Claws, and if the developers brush it off as your own problem, just stop using the PoS. They acknowledge the bug - it was already known to them, actually. With luck we'll see a fix soon. jon

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Bjorn Helgaas
On Fri, Oct 11, 2013 at 7:01 AM, Steven Rostedt rost...@goodmis.org wrote: On Fri, 11 Oct 2013 13:13:47 +0200 Rafael J. Wysocki r...@rjwysocki.net wrote: From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: ACPI / hotplug / PCI: Accept coexistence with native PCIe hotplug Allow

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Linus Torvalds
On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: +/** + * slot_should_be_exposed - Check whether or not to expose a slot to userland. + * @bridge: ACPIPHP bridge the slot belongs to. + * @handle: ACPI handle of a device in the slot. + */ +static inline bool

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 10:21:35 AM Linus Torvalds wrote: On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: +/** + * slot_should_be_exposed - Check whether or not to expose a slot to userland. + * @bridge: ACPIPHP bridge the slot belongs to. + * @handle:

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 11:58:48 PM Rafael J. Wysocki wrote: On Friday, October 11, 2013 10:21:35 AM Linus Torvalds wrote: On Fri, Oct 11, 2013 at 4:13 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: [...] Or am I misreading the code? It's more readable, and no longer makes me

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 6:45 PM, Rafael J. Wysocki wrote: > > /* Register slots for ejectable funtions only. */ > - if (acpi_pci_check_ejectable(pbus, handle) || > is_dock_device(handle)) { > + if ((acpi_pci_check_ejectable(pbus, handle) || is_dock_device(handle)) > +

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Friday, October 11, 2013 01:09:33 AM Rafael J. Wysocki wrote: > On Thursday, October 10, 2013 02:37:15 PM Linus Torvalds wrote: > > On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki > > wrote: > > > > > > Well, I must have overlooked the original report. Is it available > > > anywhere > >

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Joe Perches
On Thu, 2013-10-10 at 18:00 -0700, Linus Torvalds wrote: > the first step is to realize you have a problem. Says the guy that can only send patches to the list as attachments not plain text because he uses gmail. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 6:06 PM, Joe Perches wrote: > On Thu, 2013-10-10 at 18:00 -0700, Linus Torvalds wrote: >> the first step is to realize you have a problem. > > Says the guy that can only send patches to the list > as attachments not plain text because he uses gmail. Yeah. I fire up pine

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 5:19 PM, Steven Rostedt wrote: > > This may have been my fault, as I cut and pasted Rafael's email from > the git log, and did not add the quotes myself. Well, it is your fault, but only because you use a buggy mailer from hell. > Perhaps claws should force names with

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Steven Rostedt
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds wrote: > On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki wrote: > > > > Well, I must have overlooked the original report. Is it available anywhere > > I can find it? > > I think Steven has some buggered email system, he has other emails >

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 02:37:15 PM Linus Torvalds wrote: > On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki wrote: > > > > Well, I must have overlooked the original report. Is it available anywhere > > I can find it? > > I think Steven has some buggered email system, he has other

Re: Claws (was [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c)

2013-10-10 Thread Jonathan Corbet
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds wrote: > Steven, I'd suggest just jettisoning that mailer. FWIW, I've used claws for years and never run into an issue like that. This email comes from claws; the quoting looks right in the compose window now, I assume it will go out in good

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki wrote: > > Well, I must have overlooked the original report. Is it available anywhere > I can find it? I think Steven has some buggered email system, he has other emails being eaten by lkml too, and apparently other mail gateways (because you

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 02:17:58 PM Linus Torvalds wrote: > On Thu, Oct 10, 2013 at 1:59 PM, Steven Rostedt wrote: > > > > Unfortunately it's not a single commit. I tried to bisect it better, > > but it really is the merge. I'm thinking a chance in one merge caused > > the WARN_ON() to

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 1:59 PM, Steven Rostedt wrote: > > Unfortunately it's not a single commit. I tried to bisect it better, > but it really is the merge. I'm thinking a chance in one merge caused > the WARN_ON() to trigger that was added in a later merge. That looks a bit unlikely. The whole

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 1:59 PM, Steven Rostedt rost...@goodmis.org wrote: Unfortunately it's not a single commit. I tried to bisect it better, but it really is the merge. I'm thinking a chance in one merge caused the WARN_ON() to trigger that was added in a later merge. That looks a bit

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 02:17:58 PM Linus Torvalds wrote: On Thu, Oct 10, 2013 at 1:59 PM, Steven Rostedt rost...@goodmis.org wrote: Unfortunately it's not a single commit. I tried to bisect it better, but it really is the merge. I'm thinking a chance in one merge caused the

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Well, I must have overlooked the original report. Is it available anywhere I can find it? I think Steven has some buggered email system, he has other emails being eaten by lkml too, and apparently other mail gateways

Re: Claws (was [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c)

2013-10-10 Thread Jonathan Corbet
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds torva...@linux-foundation.org wrote: Steven, I'd suggest just jettisoning that mailer. FWIW, I've used claws for years and never run into an issue like that. This email comes from claws; the quoting looks right in the compose window now, I

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Thursday, October 10, 2013 02:37:15 PM Linus Torvalds wrote: On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Well, I must have overlooked the original report. Is it available anywhere I can find it? I think Steven has some buggered email system, he has

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Steven Rostedt
On Thu, 10 Oct 2013 14:37:15 -0700 Linus Torvalds torva...@linux-foundation.org wrote: On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Well, I must have overlooked the original report. Is it available anywhere I can find it? I think Steven has some buggered

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 5:19 PM, Steven Rostedt rost...@goodmis.org wrote: This may have been my fault, as I cut and pasted Rafael's email from the git log, and did not add the quotes myself. Well, it is your fault, but only because you use a buggy mailer from hell. Perhaps claws should

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 6:06 PM, Joe Perches j...@perches.com wrote: On Thu, 2013-10-10 at 18:00 -0700, Linus Torvalds wrote: the first step is to realize you have a problem. Says the guy that can only send patches to the list as attachments not plain text because he uses gmail. Yeah. I fire

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Joe Perches
On Thu, 2013-10-10 at 18:00 -0700, Linus Torvalds wrote: the first step is to realize you have a problem. Says the guy that can only send patches to the list as attachments not plain text because he uses gmail. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Rafael J. Wysocki
On Friday, October 11, 2013 01:09:33 AM Rafael J. Wysocki wrote: On Thursday, October 10, 2013 02:37:15 PM Linus Torvalds wrote: On Thu, Oct 10, 2013 at 2:35 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: Well, I must have overlooked the original report. Is it available anywhere

Re: [BUG] WARN_ON(!context) in drivers/pci/hotplug/acpiphp_glue.c

2013-10-10 Thread Linus Torvalds
On Thu, Oct 10, 2013 at 6:45 PM, Rafael J. Wysocki r...@rjwysocki.net wrote: /* Register slots for ejectable funtions only. */ - if (acpi_pci_check_ejectable(pbus, handle) || is_dock_device(handle)) { + if ((acpi_pci_check_ejectable(pbus, handle) ||