Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-13 Thread Andi Kleen
Thomas Gleixner wrote: > On Tue, 12 Feb 2008, Andi Kleen wrote: > >> On Tuesday 12 February 2008 21:04:06 Thomas Gleixner wrote: >> >>> And you just copied the real bug in that logic as well: >>> >>> set_memory_uc(md->virt_addr, size); >> Oops you're right. I wanted to fix that, but

Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2008, Andi Kleen wrote: > On Tuesday 12 February 2008 21:04:06 Thomas Gleixner wrote: > > > > > And you just copied the real bug in that logic as well: > > > > set_memory_uc(md->virt_addr, size); > > Oops you're right. I wanted to fix that, but didn't. Ok I'll put up

Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-12 Thread Andi Kleen
On Tuesday 12 February 2008 21:04:06 Thomas Gleixner wrote: > > And you just copied the real bug in that logic as well: > > set_memory_uc(md->virt_addr, size); Oops you're right. I wanted to fix that, but didn't. Ok I'll put up my brown paper back tonight when I go out. >

Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-12 Thread Thomas Gleixner
On Mon, 11 Feb 2008, Andi Kleen wrote: > >From code review the EFI memory map handling has a couple of problems: > > - The test for _WB memory was reversed so it would set cache able memory > to uncached > - It would always set a wrong uninitialized zero address to uncached > (so I suspect it

Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-12 Thread Thomas Gleixner
On Tue, 12 Feb 2008, Andi Kleen wrote: On Tuesday 12 February 2008 21:04:06 Thomas Gleixner wrote: And you just copied the real bug in that logic as well: set_memory_uc(md-virt_addr, size); Oops you're right. I wanted to fix that, but didn't. Ok I'll put up my brown

Re: [PATCH] [8/8] RFC: Fix some EFI problems

2008-02-12 Thread Thomas Gleixner
On Mon, 11 Feb 2008, Andi Kleen wrote: From code review the EFI memory map handling has a couple of problems: - The test for _WB memory was reversed so it would set cache able memory to uncached - It would always set a wrong uninitialized zero address to uncached (so I suspect it always

[PATCH] [8/8] RFC: Fix some EFI problems

2008-02-11 Thread Andi Kleen
>From code review the EFI memory map handling has a couple of problems: - The test for _WB memory was reversed so it would set cache able memory to uncached - It would always set a wrong uninitialized zero address to uncached (so I suspect it always set the first few pages in phys memory to

[PATCH] [8/8] RFC: Fix some EFI problems

2008-02-11 Thread Andi Kleen
From code review the EFI memory map handling has a couple of problems: - The test for _WB memory was reversed so it would set cache able memory to uncached - It would always set a wrong uninitialized zero address to uncached (so I suspect it always set the first few pages in phys memory to