Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-24 Thread Nicolin Chen
On Fri, Mar 24, 2017 at 09:37:00AM +0200, Daniel Baluta wrote: > On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen wrote: > > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: > >> From: Nicolin Chen > >> > >> WM8962 needs its MCLK when

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-24 Thread Nicolin Chen
On Fri, Mar 24, 2017 at 09:37:00AM +0200, Daniel Baluta wrote: > On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen wrote: > > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: > >> From: Nicolin Chen > >> > >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better > >>

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-24 Thread Daniel Baluta
On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen wrote: > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: >> From: Nicolin Chen >> >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better >> to control the MCLK in codec

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-24 Thread Daniel Baluta
On Fri, Mar 24, 2017 at 6:58 AM, Nicolin Chen wrote: > On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: >> From: Nicolin Chen >> >> WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better >> to control the MCLK in codec driver. Thus remove the clock enable in >>

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Nicolin Chen
On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: > From: Nicolin Chen > > WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better > to control the MCLK in codec driver. Thus remove the clock enable in > machine dirver accordingly. > > While at

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Nicolin Chen
On Thu, Mar 23, 2017 at 02:01:50PM +0200, Daniel Baluta wrote: > From: Nicolin Chen > > WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better > to control the MCLK in codec driver. Thus remove the clock enable in > machine dirver accordingly. > > While at it, get rid of

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Nicolin Chen
Hi, Could you please revise the subject a bit? I forgot what's the original one I submitted (internally) years ago. But the patch is for imx-wm8962 instead of WM8962. So please use ASoC: fsl: imx-wm8962: or at least ASoC: imx-wm8962: The change itself looks fine though. Thanks Nic

Re: [PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Nicolin Chen
Hi, Could you please revise the subject a bit? I forgot what's the original one I submitted (internally) years ago. But the patch is for imx-wm8962 instead of WM8962. So please use ASoC: fsl: imx-wm8962: or at least ASoC: imx-wm8962: The change itself looks fine though. Thanks Nic

[PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Daniel Baluta
From: Nicolin Chen WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine dirver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty.

[PATCH] ASoC: WM8962: Let codec driver enable/disable its MCLK

2017-03-23 Thread Daniel Baluta
From: Nicolin Chen WM8962 needs its MCLK when powerup in wm8962_resume(). Thus it's better to control the MCLK in codec driver. Thus remove the clock enable in machine dirver accordingly. While at it, get rid of imx_wm8962_remove function since it is now empty. Signed-off-by: Nicolin Chen