Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Mike Frysinger
On 9/14/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On Fri, 2007-09-14 at 02:44 -0400, Mike Frysinger wrote: > > On 9/14/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > > On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: > > > > Bryan Wu wrote: > > > > >>> but mremap doesn't -- there's even an

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Bryan Wu
On Fri, 2007-09-14 at 02:44 -0400, Mike Frysinger wrote: > On 9/14/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: > > > Bryan Wu wrote: > > > >>> but mremap doesn't -- there's even an implementation in mm/nommu.c. > > > >>> Could you check the

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Mike Frysinger
On 9/14/07, Bryan Wu <[EMAIL PROTECTED]> wrote: > On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: > > Bryan Wu wrote: > > >>> but mremap doesn't -- there's even an implementation in mm/nommu.c. > > >>> Could you check the rest of these over to see if they truly don't need > > >>> to be

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Mike Frysinger
On 9/14/07, Bryan Wu [EMAIL PROTECTED] wrote: On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: Bryan Wu wrote: but mremap doesn't -- there's even an implementation in mm/nommu.c. Could you check the rest of these over to see if they truly don't need to be implemented for no-mmu?

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Bryan Wu
On Fri, 2007-09-14 at 02:44 -0400, Mike Frysinger wrote: On 9/14/07, Bryan Wu [EMAIL PROTECTED] wrote: On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: Bryan Wu wrote: but mremap doesn't -- there's even an implementation in mm/nommu.c. Could you check the rest of these over to

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-14 Thread Mike Frysinger
On 9/14/07, Bryan Wu [EMAIL PROTECTED] wrote: On Fri, 2007-09-14 at 02:44 -0400, Mike Frysinger wrote: On 9/14/07, Bryan Wu [EMAIL PROTECTED] wrote: On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: Bryan Wu wrote: but mremap doesn't -- there's even an implementation in

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: > Bryan Wu wrote: > >>> but mremap doesn't -- there's even an implementation in mm/nommu.c. > >>> Could you check the rest of these over to see if they truly don't need > >>> to be implemented for no-mmu? > >> you're right we want mremap, my

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bernd Schmidt
Bryan Wu wrote: but mremap doesn't -- there's even an implementation in mm/nommu.c. Could you check the rest of these over to see if they truly don't need to be implemented for no-mmu? you're right we want mremap, my fault Yes, I do think so, both sys_mremap and sys_munmap are implemented in

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
On Thu, 2007-09-13 at 04:37 -0400, Mike Frysinger wrote: > On 9/13/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > > > +/* Not relevant on no-mmu */ > > > > I thought this list seemed a little long, so I investigated a couple > > of

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 02:18:52AM -0600, Matthew Wilcox wrote: > On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > > +/* Not relevant on no-mmu */ > > I thought this list seemed a little long, so I investigated a couple > of them. mbind makes sense (it's only implemented for NUMA ...

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Mike Frysinger
On 9/13/07, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > > +/* Not relevant on no-mmu */ > > I thought this list seemed a little long, so I investigated a couple > of them. mbind makes sense (it's only implemented for NUMA ... a NUMA >

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Matthew Wilcox
On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > +/* Not relevant on no-mmu */ I thought this list seemed a little long, so I investigated a couple of them. mbind makes sense (it's only implemented for NUMA ... a NUMA embedded platform? not the kind which runs applications that use

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 05:07:01PM +0900, Paul Mundt wrote: > On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > > +#define __NR_syscall 354 > > #define NR_syscalls__NR_syscall > > > Err, why did you change __NR_syscall? This is going to break the ABI for

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: > @@ -352,9 +353,54 @@ > #define __NR_shmdt 340 > #define __NR_shmget 341 > > -#define __NR_syscall 342 > +#define __NR_splice 342 > +#define __NR_sync_file_range 343 > +#define __NR_tee

[PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
When compiling the Blackfin kernel, checksyscalls.pl will report lots of missing syscalls warnings. This patch will add some missing syscalls which make sense on Blackfin arch. Also add ignored syscall list to kill remaining warnings. After appling this patch, toolchain should be rebuilt. Then

[PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
When compiling the Blackfin kernel, checksyscalls.pl will report lots of missing syscalls warnings. This patch will add some missing syscalls which make sense on Blackfin arch. Also add ignored syscall list to kill remaining warnings. After appling this patch, toolchain should be rebuilt. Then

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: @@ -352,9 +353,54 @@ #define __NR_shmdt 340 #define __NR_shmget 341 -#define __NR_syscall 342 +#define __NR_splice 342 +#define __NR_sync_file_range 343 +#define __NR_tee 344

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 05:07:01PM +0900, Paul Mundt wrote: On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: +#define __NR_syscall 354 #define NR_syscalls__NR_syscall Err, why did you change __NR_syscall? This is going to break the ABI for

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Matthew Wilcox
On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: +/* Not relevant on no-mmu */ I thought this list seemed a little long, so I investigated a couple of them. mbind makes sense (it's only implemented for NUMA ... a NUMA embedded platform? not the kind which runs applications that use

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Mike Frysinger
On 9/13/07, Matthew Wilcox [EMAIL PROTECTED] wrote: On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: +/* Not relevant on no-mmu */ I thought this list seemed a little long, so I investigated a couple of them. mbind makes sense (it's only implemented for NUMA ... a NUMA embedded

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Paul Mundt
On Thu, Sep 13, 2007 at 02:18:52AM -0600, Matthew Wilcox wrote: On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: +/* Not relevant on no-mmu */ I thought this list seemed a little long, so I investigated a couple of them. mbind makes sense (it's only implemented for NUMA ... a NUMA

Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
On Thu, 2007-09-13 at 04:37 -0400, Mike Frysinger wrote: On 9/13/07, Matthew Wilcox [EMAIL PROTECTED] wrote: On Thu, Sep 13, 2007 at 03:56:43PM +0800, Bryan Wu wrote: +/* Not relevant on no-mmu */ I thought this list seemed a little long, so I investigated a couple of them. mbind

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bernd Schmidt
Bryan Wu wrote: but mremap doesn't -- there's even an implementation in mm/nommu.c. Could you check the rest of these over to see if they truly don't need to be implemented for no-mmu? you're right we want mremap, my fault Yes, I do think so, both sys_mremap and sys_munmap are implemented in

Re: [Uclinux-dist-devel] Re: [PATCH] Blackfin arch: add some missing syscall

2007-09-13 Thread Bryan Wu
On Thu, 2007-09-13 at 13:03 +0200, Bernd Schmidt wrote: Bryan Wu wrote: but mremap doesn't -- there's even an implementation in mm/nommu.c. Could you check the rest of these over to see if they truly don't need to be implemented for no-mmu? you're right we want mremap, my fault