[PATCH] LZ4: compression/decompression signedness mismatch (v2)

2013-07-19 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require "(const) unsigned char *". v2: minor coding style fix. Signed-off-by: Sergey Senozhatsky

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-19 Thread Sergey Senozhatsky
On (07/19/13 17:27), Kyungsik Lee wrote: > > >> On (07/12/13 11:28), Yann Collet wrote: > > >> >The reference implementation, hosted at :� > > >> >[1]https://code.google.com/p/lz4/ > > >> >only proposes char* (signed) types as part of the interface > > >> > contract. > > >> >I

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-19 Thread Kyungsik Lee
On Thu, Jul 18, 2013 at 11:29:57PM +0200, Geert Uytterhoeven wrote: > On Thu, Jul 18, 2013 at 11:18 PM, Sergey Senozhatsky > wrote: > > On (07/12/13 12:48), Sergey Senozhatsky wrote: > >> On (07/12/13 11:28), Yann Collet wrote: > >> >The reference implementation, hosted at :� > >> >

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-19 Thread Kyungsik Lee
On Thu, Jul 18, 2013 at 11:29:57PM +0200, Geert Uytterhoeven wrote: On Thu, Jul 18, 2013 at 11:18 PM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: On (07/12/13 12:48), Sergey Senozhatsky wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :�

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-19 Thread Sergey Senozhatsky
On (07/19/13 17:27), Kyungsik Lee wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed) types as part of the interface contract. I would recommend to keep it that

[PATCH] LZ4: compression/decompression signedness mismatch (v2)

2013-07-19 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require (const) unsigned char *. v2: minor coding style fix. Signed-off-by: Sergey Senozhatsky

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 11:18 PM, Sergey Senozhatsky wrote: > On (07/12/13 12:48), Sergey Senozhatsky wrote: >> On (07/12/13 11:28), Yann Collet wrote: >> >The reference implementation, hosted at :� >> >[1]https://code.google.com/p/lz4/ >> >only proposes char* (signed) types as part

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-18 Thread Sergey Senozhatsky
Hello, On (07/12/13 12:48), Sergey Senozhatsky wrote: > On (07/12/13 11:28), Yann Collet wrote: > >The reference implementation, hosted at :� > >[1]https://code.google.com/p/lz4/ > >only proposes char* (signed) types as part of the interface contract. > >I would recommend to keep

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-18 Thread Sergey Senozhatsky
Hello, On (07/12/13 12:48), Sergey Senozhatsky wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed) types as part of the interface contract. I would recommend to keep it that

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-18 Thread Geert Uytterhoeven
On Thu, Jul 18, 2013 at 11:18 PM, Sergey Senozhatsky sergey.senozhat...@gmail.com wrote: On (07/12/13 12:48), Sergey Senozhatsky wrote: On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed)

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
On (07/12/13 11:28), Yann Collet wrote: >The reference implementation, hosted at :� >[1]https://code.google.com/p/lz4/ >only proposes char* (signed) types as part of the interface contract. >I would recommend to keep it that way, to remain consistent. >Regards Crypto lz4

[PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require unsigned char. Signed-off-by: Sergey Senozhatsky --- include/linux/lz4.h | 8

[PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
LZ4 compression and decompression functions require different in signedness input/output parameters: unsigned char for compression and signed char for decompression. Change decompression API to require unsigned char. Signed-off-by: Sergey Senozhatsky sergey.senozhat...@gmail.com ---

Re: [PATCH] LZ4: compression/decompression signedness mismatch

2013-07-12 Thread Sergey Senozhatsky
On (07/12/13 11:28), Yann Collet wrote: The reference implementation, hosted at :� [1]https://code.google.com/p/lz4/ only proposes char* (signed) types as part of the interface contract. I would recommend to keep it that way, to remain consistent. Regards Crypto lz4 accepts u8