Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-02 Thread Jens Axboe
On 2/2/21 7:36 PM, Lin Feng wrote: > Hi all, > > On 2/2/21 22:20, Jens Axboe wrote: >> On 2/2/21 5:28 AM, Jan Kara wrote: >>> Hello! >>> >>> On Fri 29-01-21 19:18:08, Lin Feng wrote: This reverts commit 6d4d273588378c65915acaf7b2ee74e9dd9c130a. bfq.limit_depth passes word_depths[]

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-02 Thread Lin Feng
Hi all, On 2/2/21 22:20, Jens Axboe wrote: On 2/2/21 5:28 AM, Jan Kara wrote: Hello! On Fri 29-01-21 19:18:08, Lin Feng wrote: This reverts commit 6d4d273588378c65915acaf7b2ee74e9dd9c130a. bfq.limit_depth passes word_depths[] as shallow_depth down to sbitmap core sbitmap_get_shallow, which

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-02 Thread Jens Axboe
On 2/2/21 5:28 AM, Jan Kara wrote: > Hello! > > On Fri 29-01-21 19:18:08, Lin Feng wrote: >> This reverts commit 6d4d273588378c65915acaf7b2ee74e9dd9c130a. >> >> bfq.limit_depth passes word_depths[] as shallow_depth down to sbitmap core >> sbitmap_get_shallow, which uses just the number to limit

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-02 Thread Jan Kara
Hello! On Fri 29-01-21 19:18:08, Lin Feng wrote: > This reverts commit 6d4d273588378c65915acaf7b2ee74e9dd9c130a. > > bfq.limit_depth passes word_depths[] as shallow_depth down to sbitmap core > sbitmap_get_shallow, which uses just the number to limit the scan depth of > each bitmap word,

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-01 Thread Paolo Valente
> Il giorno 1 feb 2021, alle ore 08:32, Lin Feng ha scritto: > > Hi, it seems that this patch was blocked by linux mailist servers, so ping > again. > > Based on > https://patchwork.kernel.org/project/linux-block/patch/20201210094433.25491-1-j...@suse.cz/, > it looks like we have made a

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-02-01 Thread Paolo Valente
> Il giorno 29 gen 2021, alle ore 12:18, Lin Feng ha scritto: > > This reverts commit 6d4d273588378c65915acaf7b2ee74e9dd9c130a. > > bfq.limit_depth passes word_depths[] as shallow_depth down to sbitmap core > sbitmap_get_shallow, which uses just the number to limit the scan depth of > each

Re: [PATCH] Revert "bfq: Fix computation of shallow depth"

2021-01-31 Thread Lin Feng
Hi, it seems that this patch was blocked by linux mailist servers, so ping again. Based on https://patchwork.kernel.org/project/linux-block/patch/20201210094433.25491-1-j...@suse.cz/, it looks like we have made a consensus about bfqd->word_depths[2][2]'s changing, so now the computation codes