Re: [PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR.

2021-01-13 Thread Theodore Ts'o
On Wed, Jan 06, 2021 at 02:02:11PM +0100, Jan Kara wrote: > On Wed 30-12-20 11:38:27, Yi Li wrote: > > 1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR > > instead of IS_ERR_OR_NULL to fix this. > > > > 2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR. > > and go to

Re: [PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR.

2021-01-06 Thread Jan Kara
On Wed 30-12-20 11:38:27, Yi Li wrote: > 1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR > instead of IS_ERR_OR_NULL to fix this. > > 2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR. > and go to call iput properly. > > Signed-off-by: Yi Li Thanks for the patch! It

[PATCH] Use IS_ERR instead of IS_ERR_OR_NULL and set inode null when IS_ERR.

2020-12-29 Thread Yi Li
1: ext4_iget/ext4_find_extent never returns NULL, use IS_ERR instead of IS_ERR_OR_NULL to fix this. 2: ext4_fc_replay_inode should set the inode to NULL when IS_ERR. and go to call iput properly. Signed-off-by: Yi Li --- fs/ext4/fast_commit.c | 23 --- 1 file changed, 12