Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-19 Thread Maxime Ripard
On Wed, Jan 18, 2017 at 06:48:35PM +0100, Ondřej Jirman wrote: > Dne 18.1.2017 v 17:56 Maxime Ripard napsal(a): > >>> What's your current plan to fix that? I guess the easiest (and most > >>> likely to be reusable) would be to allow for clock tables, instead of > >>> using the generic approach. We

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-19 Thread Maxime Ripard
On Wed, Jan 18, 2017 at 06:48:35PM +0100, Ondřej Jirman wrote: > Dne 18.1.2017 v 17:56 Maxime Ripard napsal(a): > >>> What's your current plan to fix that? I guess the easiest (and most > >>> likely to be reusable) would be to allow for clock tables, instead of > >>> using the generic approach. We

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-18 Thread Ondřej Jirman
Dne 18.1.2017 v 17:56 Maxime Ripard napsal(a): >>> What's your current plan to fix that? I guess the easiest (and most >>> likely to be reusable) would be to allow for clock tables, instead of >>> using the generic approach. We might have some other clocks (like >>> audio or video) that would need

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-18 Thread Ondřej Jirman
Dne 18.1.2017 v 17:56 Maxime Ripard napsal(a): >>> What's your current plan to fix that? I guess the easiest (and most >>> likely to be reusable) would be to allow for clock tables, instead of >>> using the generic approach. We might have some other clocks (like >>> audio or video) that would need

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-18 Thread Maxime Ripard
Hi, On Mon, Jan 16, 2017 at 05:51:30PM +0100, Ondřej Jirman wrote: > Hi Maxime, > > Dne 16.1.2017 v 17:43 Maxime Ripard napsal(a): > >> It does lock up quickly with mainline ccu_nkmp_find_best algorithm > >> for finding factors. > >> > >> Even with linux kernel, it breaks. It's just more

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-18 Thread Maxime Ripard
Hi, On Mon, Jan 16, 2017 at 05:51:30PM +0100, Ondřej Jirman wrote: > Hi Maxime, > > Dne 16.1.2017 v 17:43 Maxime Ripard napsal(a): > >> It does lock up quickly with mainline ccu_nkmp_find_best algorithm > >> for finding factors. > >> > >> Even with linux kernel, it breaks. It's just more

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-16 Thread Ondřej Jirman
Hi Maxime, Dne 16.1.2017 v 17:43 Maxime Ripard napsal(a): >> It does lock up quickly with mainline ccu_nkmp_find_best algorithm >> for finding factors. >> >> Even with linux kernel, it breaks. It's just more difficult to hit the >> right conditions. I got oops only right after boot when running

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-16 Thread Ondřej Jirman
Hi Maxime, Dne 16.1.2017 v 17:43 Maxime Ripard napsal(a): >> It does lock up quickly with mainline ccu_nkmp_find_best algorithm >> for finding factors. >> >> Even with linux kernel, it breaks. It's just more difficult to hit the >> right conditions. I got oops only right after boot when running

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-16 Thread Maxime Ripard
Hi Ondrej, Sorry for the late reply, On Mon, Jan 09, 2017 at 03:50:42PM +0100, Ondřej Jirman wrote: > Dne 9.1.2017 v 10:59 Maxime Ripard napsal(a): > > On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: > >> Maxime, > >> > >> Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > >>>

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-16 Thread Maxime Ripard
Hi Ondrej, Sorry for the late reply, On Mon, Jan 09, 2017 at 03:50:42PM +0100, Ondřej Jirman wrote: > Dne 9.1.2017 v 10:59 Maxime Ripard napsal(a): > > On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: > >> Maxime, > >> > >> Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > >>>

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-09 Thread Ondřej Jirman
Dne 9.1.2017 v 10:59 Maxime Ripard napsal(a): > On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: >> Maxime, >> >> Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): >>> From: Ondrej Jirman >>> >>> When adjusting PLL_CPUX on H3, the PLL is temporarily driven >>>

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-09 Thread Ondřej Jirman
Dne 9.1.2017 v 10:59 Maxime Ripard napsal(a): > On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: >> Maxime, >> >> Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): >>> From: Ondrej Jirman >>> >>> When adjusting PLL_CPUX on H3, the PLL is temporarily driven >>> too high, and the

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-09 Thread Maxime Ripard
On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: > Maxime, > > Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > > From: Ondrej Jirman > > > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > > too high, and the system becomes unstable (oopses

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-09 Thread Maxime Ripard
On Sat, Jan 07, 2017 at 04:49:18PM +0100, Ondřej Jirman wrote: > Maxime, > > Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > > From: Ondrej Jirman > > > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > > too high, and the system becomes unstable (oopses or hangs). > > > >

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-07 Thread Ondřej Jirman
Maxime, Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2017-01-07 Thread Ondřej Jirman
Maxime, Dne 25.11.2016 v 01:28 meg...@megous.com napsal(a): > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily switching > to a known

Re: [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread Maxime Ripard
On Fri, Nov 25, 2016 at 01:28:47AM +0100, meg...@megous.com wrote: > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily

Re: [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread Maxime Ripard
On Fri, Nov 25, 2016 at 01:28:47AM +0100, meg...@megous.com wrote: > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily switching > to a

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread Chen-Yu Tsai
On Fri, Nov 25, 2016 at 8:28 AM, wrote: > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily switching

Re: [linux-sunxi] [PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread Chen-Yu Tsai
On Fri, Nov 25, 2016 at 8:28 AM, wrote: > From: Ondrej Jirman > > When adjusting PLL_CPUX on H3, the PLL is temporarily driven > too high, and the system becomes unstable (oopses or hangs). > > Add a notifier to avoid this situation by temporarily switching > to a known stable 24 MHz

[PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread megous
From: Ondrej Jirman When adjusting PLL_CPUX on H3, the PLL is temporarily driven too high, and the system becomes unstable (oopses or hangs). Add a notifier to avoid this situation by temporarily switching to a known stable 24 MHz oscillator. Signed-off-by: Ondrej Jirman

[PATCH] clk: sunxi-ng: fix PLL_CPUX adjusting on H3

2016-11-24 Thread megous
From: Ondrej Jirman When adjusting PLL_CPUX on H3, the PLL is temporarily driven too high, and the system becomes unstable (oopses or hangs). Add a notifier to avoid this situation by temporarily switching to a known stable 24 MHz oscillator. Signed-off-by: Ondrej Jirman Tested-by: Lutz