Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Tue, 19 Jun 2007 12:33:16 -0700 > Only x86_64 and ia64 are fixed. Would it be correct to assume that the > other CONFIG_COMPAT architectures also need to be fixed? Only platforms which compat to "i386" have the issue wrt. the alignment of "u64"

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Mikael Pettersson
Andrew Morton writes: > On Mon, 18 Jun 2007 12:21:47 +0400 > Vasily Tarasov <[EMAIL PROTECTED]> wrote: > > > From: Vasily Tarasov <[EMAIL PROTECTED]> > > > > This patch should be applied after Arnd Bergmann's patch, > > that intoduces new compat types: > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 12:21:47 +0400 Vasily Tarasov <[EMAIL PROTECTED]> wrote: > From: Vasily Tarasov <[EMAIL PROTECTED]> > > This patch should be applied after Arnd Bergmann's patch, > that intoduces new compat types: > http://lkml.org/lkml/2007/6/15/98 > > OpenVZ Linux kernel team has

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 12:21:47 +0400 Vasily Tarasov [EMAIL PROTECTED] wrote: From: Vasily Tarasov [EMAIL PROTECTED] This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ Linux kernel team has discovered the

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread Mikael Pettersson
Andrew Morton writes: On Mon, 18 Jun 2007 12:21:47 +0400 Vasily Tarasov [EMAIL PROTECTED] wrote: From: Vasily Tarasov [EMAIL PROTECTED] This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-19 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Tue, 19 Jun 2007 12:33:16 -0700 Only x86_64 and ia64 are fixed. Would it be correct to assume that the other CONFIG_COMPAT architectures also need to be fixed? Only platforms which compat to i386 have the issue wrt. the alignment of u64 types, which

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
On Fri, 2007-06-15 at 17:24 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Vasily Tarasov wrote: > > I just noticed that we can not avoid the addition of packed attribute. > > Look, for example: > > > > struct if_dqblk { > > __u64 dqb_bhardlimit; > > __u64 dqb_bsoftlimit;

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
On Fri, 2007-06-15 at 17:24 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Vasily Tarasov wrote: I just noticed that we can not avoid the addition of packed attribute. Look, for example: struct if_dqblk { __u64 dqb_bhardlimit; __u64 dqb_bsoftlimit;

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Arnd Bergmann
On Friday 15 June 2007, Vasily Tarasov wrote: > I just noticed that we can not avoid the addition of packed attribute. > Look, for example: > > struct if_dqblk { >         __u64 dqb_bhardlimit; >         __u64 dqb_bsoftlimit; >         __u64 dqb_curspace; >         __u64 dqb_ihardlimit; >        

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 > > > 15:55:26.0 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 > > ... > > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Mikael Pettersson
On Fri, 15 Jun 2007 12:43:01 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig=A0=A0=A0=A02007-06-14 15:55:= > 26.0 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c=A02007-06-14 19:50:13.0 += > 0400 > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 > > > 15:55:26.0 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 > > ... > > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Arnd Bergmann
On Friday 15 June 2007, Mikael Pettersson wrote: > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 > > +0400 > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 > ... > > +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64) > > +/* > > + *

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
You can find a half-year back discussions of this patch: First attempt: http://lkml.org/lkml/2006/10/19/123 Second attempt: http://lkml.org/lkml/2006/10/25/57 I think they will answer your questions. Thank you, Vasily On Fri, 2007-06-15 at 12:03 +0200, Mikael Pettersson wrote: > On Fri, 15

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Mikael Pettersson
On Fri, 15 Jun 2007 13:01:48 +0400, Vasily Tarasov wrote: > OpenVZ Linux kernel team has discovered the problem > with 32bit quota tools working on 64bit architectures. > In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with > the comment "sys_quotactl seems to be

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment "sys_quotactl seems to be 32/64bit clean, enable it for

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment "sys_quotactl seems to be 32/64bit clean, enable it for

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit clean, enable it for

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit clean, enable it for

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Mikael Pettersson
On Fri, 15 Jun 2007 13:01:48 +0400, Vasily Tarasov wrote: OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
You can find a half-year back discussions of this patch: First attempt: http://lkml.org/lkml/2006/10/19/123 Second attempt: http://lkml.org/lkml/2006/10/25/57 I think they will answer your questions. Thank you, Vasily On Fri, 2007-06-15 at 12:03 +0200, Mikael Pettersson wrote: On Fri, 15 Jun

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Arnd Bergmann
On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 ... +#if defined(CONFIG_X86_64) || defined(CONFIG_IA64) +/* + * This code works

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 ... +#if

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Mikael Pettersson
On Fri, 15 Jun 2007 12:43:01 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig=A0=A0=A0=A02007-06-14 15:55:= 26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c=A02007-06-14 19:50:13.0 += 0400 ... +#if

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 ... +#if

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Arnd Bergmann
On Friday 15 June 2007, Vasily Tarasov wrote: I just noticed that we can not avoid the addition of packed attribute. Look, for example: struct if_dqblk {         __u64 dqb_bhardlimit;         __u64 dqb_bsoftlimit;         __u64 dqb_curspace;         __u64 dqb_ihardlimit;         __u64