Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-30 Thread Chao Yu
On 2018/1/31 9:39, Jaegeuk Kim wrote: > On 01/29, Chao Yu wrote: >> On 2018/1/29 16:31, Yunlong Song wrote: >>> The old commit allocates hot data & nodes in the beginning of partition >>> both for heap and >>> noheap mode. But from the commit message, the heap mode should be like >>> before,

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-30 Thread Chao Yu
On 2018/1/31 9:39, Jaegeuk Kim wrote: > On 01/29, Chao Yu wrote: >> On 2018/1/29 16:31, Yunlong Song wrote: >>> The old commit allocates hot data & nodes in the beginning of partition >>> both for heap and >>> noheap mode. But from the commit message, the heap mode should be like >>> before,

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-30 Thread Jaegeuk Kim
On 01/29, Chao Yu wrote: > On 2018/1/29 16:31, Yunlong Song wrote: > > The old commit allocates hot data & nodes in the beginning of partition > > both for heap and > > noheap mode. But from the commit message, the heap mode should be like > > before, i.e., > > allocate hot data & nodes from

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-30 Thread Jaegeuk Kim
On 01/29, Chao Yu wrote: > On 2018/1/29 16:31, Yunlong Song wrote: > > The old commit allocates hot data & nodes in the beginning of partition > > both for heap and > > noheap mode. But from the commit message, the heap mode should be like > > before, i.e., > > allocate hot data & nodes from

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Chao Yu
On 2018/1/29 16:31, Yunlong Song wrote: > The old commit allocates hot data & nodes in the beginning of partition > both for heap and > noheap mode. But from the commit message, the heap mode should be like > before, i.e., > allocate hot data & nodes from curseg to left. Let's ping Jaegeuk to

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Chao Yu
On 2018/1/29 16:31, Yunlong Song wrote: > The old commit allocates hot data & nodes in the beginning of partition > both for heap and > noheap mode. But from the commit message, the heap mode should be like > before, i.e., > allocate hot data & nodes from curseg to left. Let's ping Jaegeuk to

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Yunlong Song
The old commit allocates hot data & nodes in the beginning of partition both for heap and noheap mode. But from the commit message, the heap mode should be like before, i.e., allocate hot data & nodes from curseg to left. On 2018/1/29 16:12, Chao Yu wrote: Hi Yunlong, On 2018/1/29 11:37,

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Yunlong Song
The old commit allocates hot data & nodes in the beginning of partition both for heap and noheap mode. But from the commit message, the heap mode should be like before, i.e., allocate hot data & nodes from curseg to left. On 2018/1/29 16:12, Chao Yu wrote: Hi Yunlong, On 2018/1/29 11:37,

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Chao Yu
Hi Yunlong, On 2018/1/29 11:37, Yunlong Song wrote: > Commit 7a20b8a61eff81bdb7097a578752a74860e9d142 ("f2fs: allocate node > and hot data in the beginning of partition") introduces another mount > option, heap, to reset it back. But it does not do anything for heap > mode, so fix it. I think

Re: [PATCH] f2fs: fix heap mode to reset it back

2018-01-29 Thread Chao Yu
Hi Yunlong, On 2018/1/29 11:37, Yunlong Song wrote: > Commit 7a20b8a61eff81bdb7097a578752a74860e9d142 ("f2fs: allocate node > and hot data in the beginning of partition") introduces another mount > option, heap, to reset it back. But it does not do anything for heap > mode, so fix it. I think

[PATCH] f2fs: fix heap mode to reset it back

2018-01-28 Thread Yunlong Song
Commit 7a20b8a61eff81bdb7097a578752a74860e9d142 ("f2fs: allocate node and hot data in the beginning of partition") introduces another mount option, heap, to reset it back. But it does not do anything for heap mode, so fix it. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c

[PATCH] f2fs: fix heap mode to reset it back

2018-01-28 Thread Yunlong Song
Commit 7a20b8a61eff81bdb7097a578752a74860e9d142 ("f2fs: allocate node and hot data in the beginning of partition") introduces another mount option, heap, to reset it back. But it does not do anything for heap mode, so fix it. Signed-off-by: Yunlong Song --- fs/f2fs/gc.c | 5 +++--