Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-13 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:46:30PM +0100, Jarek Poplawski wrote: > On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: > ... > > It seems the above version of this macro uses the barrier for 0, but > > if I miss something, or for these other: documenting reasons, > > ...or

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-13 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:46:30PM +0100, Jarek Poplawski wrote: On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: ... It seems the above version of this macro uses the barrier for 0, but if I miss something, or for these other: documenting reasons, ...or

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: ... > It seems the above version of this macro uses the barrier for 0, but > if I miss something, or for these other: documenting reasons, ...or __builtin_constants could be used for indexing (?!), > then of > course you are right.

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 08:07:29AM -0800, Paul E. McKenney wrote: ... > "All programmers are blind, especially me." Hmm... I got it my way: you - superheroes - sometimes seem to be just like us - common people... (Probably early in the morning, before dressing your funny costumes?) > You are

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:57:14AM +, Jarek Poplawski wrote: > On 12-02-2008 02:16, David Miller wrote: > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > Date: Mon, 11 Feb 2008 16:59:54 -0800 > > > > linux-kernel added to CC:, any change to generic kernel infrastructure > > should be posted

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On 12-02-2008 02:16, David Miller wrote: > From: Stephen Hemminger <[EMAIL PROTECTED]> > Date: Mon, 11 Feb 2008 16:59:54 -0800 > > linux-kernel added to CC:, any change to generic kernel infrastructure > should be posted there > >> Eliminate warnings when rcu_assign_pointer is used with unsigned

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On 12-02-2008 02:16, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there Eliminate warnings when rcu_assign_pointer is used with unsigned long. It

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Jarek Poplawski
On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: ... It seems the above version of this macro uses the barrier for 0, but if I miss something, or for these other: documenting reasons, ...or __builtin_constants could be used for indexing (?!), then of course you are right.

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-12 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:57:14AM +, Jarek Poplawski wrote: On 12-02-2008 02:16, David Miller wrote: From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: "Paul E. McKenney" <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 17:27:41 -0800 > On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: > > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > > It is reasonable to use RCU with non-pointer values so allow it

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there > Eliminate warnings when rcu_assign_pointer is used with unsigned long. > It is reasonable to use RCU with non-pointer

[PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread Stephen Hemminger
Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer values so allow it for general use. Add a comment to explain the if test. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- include/linux/rcupdate.h | 13 +++-- 1

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Paul E. McKenney [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 17:27:41 -0800 On Mon, Feb 11, 2008 at 04:59:54PM -0800, Stephen Hemminger wrote: Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer values so allow it for general

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 11 Feb 2008 16:59:54 -0800 linux-kernel added to CC:, any change to generic kernel infrastructure should be posted there Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer

[PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-11 Thread Stephen Hemminger
Eliminate warnings when rcu_assign_pointer is used with unsigned long. It is reasonable to use RCU with non-pointer values so allow it for general use. Add a comment to explain the if test. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- include/linux/rcupdate.h | 13 +++-- 1