Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-10-07 Thread Chen Gang
In futex_lock_pi(), after rt_mutex_timed_lock() fails, the followed fixup_owner() still may return 0 to express "success, lock not taken" (may printk kernel error in it). When it happens, 'res' is zero, 'ret' is still none-zero, and "rt_mutex_owner(_state->pi_mutex) == current", it will call

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-10-07 Thread Chen Gang
In futex_lock_pi(), after rt_mutex_timed_lock() fails, the followed fixup_owner() still may return 0 to express success, lock not taken (may printk kernel error in it). When it happens, 'res' is zero, 'ret' is still none-zero, and rt_mutex_owner(q.pi_state-pi_mutex) == current, it will call

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-10-06 Thread Chen Gang
After read the code again, I have addtional opinion for discussing, please check thanks. The related contents are at bottom. On 09/13/2013 09:52 AM, Chen Gang wrote: > On 09/13/2013 07:36 AM, Thomas Gleixner wrote: >> That crusade does not involve any failure analysis or test cases. It's >>

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-10-06 Thread Chen Gang
After read the code again, I have addtional opinion for discussing, please check thanks. The related contents are at bottom. On 09/13/2013 09:52 AM, Chen Gang wrote: On 09/13/2013 07:36 AM, Thomas Gleixner wrote: That crusade does not involve any failure analysis or test cases. It's just

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Chen Gang
Firstly, I am glad to see that you did not redirect all my mails to "/dev/null". ;-) On 09/13/2013 07:36 AM, Thomas Gleixner wrote: > On Thu, 12 Sep 2013, Darren Hart wrote: >> On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: >>> On Tue, 20 Aug 2013, Chen Gang wrote: >>>

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Chen Gang
On 09/13/2013 06:37 AM, Darren Hart wrote: > On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: >> On Tue, 20 Aug 2013, Chen Gang wrote: >> >>> rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, >>> -ETIMEDOUT). >>> >>> Original implementation has already noticed about it,

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Thomas Gleixner
On Thu, 12 Sep 2013, Darren Hart wrote: > On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: > > On Tue, 20 Aug 2013, Chen Gang wrote: > > > > > rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, > > > -ETIMEDOUT). > > > > > > Original implementation has already noticed

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Darren Hart
On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: > On Tue, 20 Aug 2013, Chen Gang wrote: > > > rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, > > -ETIMEDOUT). > > > > Original implementation has already noticed about it, but not check it > > before next work. > > >

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Thomas Gleixner
On Tue, 20 Aug 2013, Chen Gang wrote: > rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, > -ETIMEDOUT). > > Original implementation has already noticed about it, but not check it > before next work. > > Also let coments within 80 columns to pass "./scripts/checkpatch.pl". > >

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Thomas Gleixner
On Tue, 20 Aug 2013, Chen Gang wrote: rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let coments within 80 columns to pass ./scripts/checkpatch.pl.

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Darren Hart
On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: On Tue, 20 Aug 2013, Chen Gang wrote: rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Thomas Gleixner
On Thu, 12 Sep 2013, Darren Hart wrote: On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: On Tue, 20 Aug 2013, Chen Gang wrote: rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Chen Gang
On 09/13/2013 06:37 AM, Darren Hart wrote: On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: On Tue, 20 Aug 2013, Chen Gang wrote: rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-12 Thread Chen Gang
Firstly, I am glad to see that you did not redirect all my mails to /dev/null. ;-) On 09/13/2013 07:36 AM, Thomas Gleixner wrote: On Thu, 12 Sep 2013, Darren Hart wrote: On Thu, 2013-09-12 at 16:32 +0200, Thomas Gleixner wrote: On Tue, 20 Aug 2013, Chen Gang wrote:

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-02 Thread Chen Gang
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 08/21/2013 11:48 AM, Chen Gang wrote: > On 08/21/2013 12:19 AM, Darren Hart wrote: >> HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: >> >> >> Hi Chen, >> >>> rt_mutex_finish_proxy_lock() can return

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-09-02 Thread Chen Gang
Hello Maintainers: Please help check this patch, when you have time. Thanks. On 08/21/2013 11:48 AM, Chen Gang wrote: On 08/21/2013 12:19 AM, Darren Hart wrote: HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: Hi Chen, rt_mutex_finish_proxy_lock() can return failure code (e.g.

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-20 Thread Chen Gang
On 08/21/2013 12:19 AM, Darren Hart wrote: > HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: > > > Hi Chen, > >> rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, >> -ETIMEDOUT). >> >> Original implementation has already noticed about it, but not check it >> before

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-20 Thread Darren Hart
HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: Hi Chen, > rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, > -ETIMEDOUT). > > Original implementation has already noticed about it, but not check it > before next work. > > Also let coments within 80 columns to pass

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-20 Thread Darren Hart
HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: Hi Chen, rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let coments within 80 columns to pass

Re: [PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-20 Thread Chen Gang
On 08/21/2013 12:19 AM, Darren Hart wrote: HopingOn Tue, 2013-08-20 at 11:07 +0800, Chen Gang wrote: Hi Chen, rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also

[PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-19 Thread Chen Gang
rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let coments within 80 columns to pass "./scripts/checkpatch.pl". Signed-off-by: Chen Gang --- kernel/futex.c | 30

[PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-19 Thread Chen Gang
rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let coments within 80 columns to pass ./scripts/checkpatch.pl. Signed-off-by: Chen Gang gang.c...@asianux.com ---