Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-11 Thread Milian Wolff
On Donnerstag, 6. Dezember 2018 23:52:07 CET Andi Kleen wrote: > On Thu, Dec 06, 2018 at 06:29:20PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu: > > > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > > Em

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-07 Thread Adrian Hunter
On 6/12/18 7:01 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: >> From: Andi Kleen >> >> This is a fix for another instance of the skid problem Milian >> recently found [1] > > Milian, have you tested this? > > Adrian, can I have your

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-07 Thread Adrian Hunter
On 6/12/18 7:01 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: >> From: Andi Kleen >> >> This is a fix for another instance of the skid problem Milian >> recently found [1] > > Milian, have you tested this? > > Adrian, can I have your

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Andi Kleen
On Thu, Dec 06, 2018 at 06:29:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu: > > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > > >

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Andi Kleen
On Thu, Dec 06, 2018 at 06:29:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu: > > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > > >

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu: > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > > From: Andi Kleen > > > > > > This is a fix for another instance of the skid problem

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 06, 2018 at 12:51:48PM -0800, Andi Kleen escreveu: > On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > > From: Andi Kleen > > > > > > This is a fix for another instance of the skid problem

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Andi Kleen
On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > From: Andi Kleen > > > > This is a fix for another instance of the skid problem Milian > > recently found [1] > > Milian, have you tested this? It

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Andi Kleen
On Thu, Dec 06, 2018 at 02:01:40PM -0300, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > > From: Andi Kleen > > > > This is a fix for another instance of the skid problem Milian > > recently found [1] > > Milian, have you tested this? It

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > From: Andi Kleen > > This is a fix for another instance of the skid problem Milian > recently found [1] Milian, have you tested this? Adrian, can I have your Reviewed-by or Acked-by? Thanks, - Arnaldo > The LBRs don't freeze

Re: [PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-12-06 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 19, 2018 at 09:06:17PM -0800, Andi Kleen escreveu: > From: Andi Kleen > > This is a fix for another instance of the skid problem Milian > recently found [1] Milian, have you tested this? Adrian, can I have your Reviewed-by or Acked-by? Thanks, - Arnaldo > The LBRs don't freeze

[PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-11-19 Thread Andi Kleen
From: Andi Kleen This is a fix for another instance of the skid problem Milian recently found [1] The LBRs don't freeze at the exact same time as the PMI is triggered. The perf script brstackinsn code that dumps LBR assembler assumes that the last branch in the LBR leads to the sample point.

[PATCH] perf script: Fix LBR skid dump problems in brstackinsn

2018-11-19 Thread Andi Kleen
From: Andi Kleen This is a fix for another instance of the skid problem Milian recently found [1] The LBRs don't freeze at the exact same time as the PMI is triggered. The perf script brstackinsn code that dumps LBR assembler assumes that the last branch in the LBR leads to the sample point.