Re: [PATCH] perf script: share code and output format for uregs and iregs output

2018-11-11 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 09, 2018 at 09:19:45AM +0100, Jiri Olsa escreveu: > On Wed, Nov 07, 2018 at 11:34:37PM +0100, Milian Wolff wrote: > > The iregs output was missing the newline at end as well as the leading > > ABI output. This made it hard to compare the iregs and uregs values. > > Instead, use a

Re: [PATCH] perf script: share code and output format for uregs and iregs output

2018-11-11 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 09, 2018 at 09:19:45AM +0100, Jiri Olsa escreveu: > On Wed, Nov 07, 2018 at 11:34:37PM +0100, Milian Wolff wrote: > > The iregs output was missing the newline at end as well as the leading > > ABI output. This made it hard to compare the iregs and uregs values. > > Instead, use a

Re: [PATCH] perf script: share code and output format for uregs and iregs output

2018-11-09 Thread Jiri Olsa
On Wed, Nov 07, 2018 at 11:34:37PM +0100, Milian Wolff wrote: > The iregs output was missing the newline at end as well as the leading > ABI output. This made it hard to compare the iregs and uregs values. > Instead, use a single function to output the register values and use > it for both, iregs

Re: [PATCH] perf script: share code and output format for uregs and iregs output

2018-11-09 Thread Jiri Olsa
On Wed, Nov 07, 2018 at 11:34:37PM +0100, Milian Wolff wrote: > The iregs output was missing the newline at end as well as the leading > ABI output. This made it hard to compare the iregs and uregs values. > Instead, use a single function to output the register values and use > it for both, iregs

[PATCH] perf script: share code and output format for uregs and iregs output

2018-11-07 Thread Milian Wolff
The iregs output was missing the newline at end as well as the leading ABI output. This made it hard to compare the iregs and uregs values. Instead, use a single function to output the register values and use it for both, iregs and uregs, to ensure the output is consistent. Before: ``` perf

[PATCH] perf script: share code and output format for uregs and iregs output

2018-11-07 Thread Milian Wolff
The iregs output was missing the newline at end as well as the leading ABI output. This made it hard to compare the iregs and uregs values. Instead, use a single function to output the register values and use it for both, iregs and uregs, to ensure the output is consistent. Before: ``` perf