Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-29 Thread Paul Moore
On Thu, Mar 23, 2017 at 1:34 PM, Grant Grundler wrote: > On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote: >> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler >> wrote: >>> Ping? Any feedback on this patch? >> >> It's on my

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-29 Thread Paul Moore
On Thu, Mar 23, 2017 at 1:34 PM, Grant Grundler wrote: > On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote: >> On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler >> wrote: >>> Ping? Any feedback on this patch? >> >> It's on my list of patches to review, patience please. > > No problem! Thank you!

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-23 Thread Grant Grundler
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote: > On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: >> Ping? Any feedback on this patch? > > It's on my list of patches to review, patience please. No problem! Thank you! just wanted

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-23 Thread Grant Grundler
On Thu, Mar 23, 2017 at 5:08 AM, Paul Moore wrote: > On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: >> Ping? Any feedback on this patch? > > It's on my list of patches to review, patience please. No problem! Thank you! just wanted confirmation it wasn't overlooked. cheers, grant > >>

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-23 Thread Paul Moore
On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: > Ping? Any feedback on this patch? It's on my list of patches to review, patience please. > On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: >> >> 'perms' will never be NULL since it

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-23 Thread Paul Moore
On Wed, Mar 22, 2017 at 8:28 PM, Grant Grundler wrote: > Ping? Any feedback on this patch? It's on my list of patches to review, patience please. > On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: >> >> 'perms' will never be NULL since it isn't a plain pointer but an array >> of u32

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-22 Thread Grant Grundler
[resending as plain text only - sorry] Ping? Any feedback on this patch? LGTM. cheers, grant On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: > 'perms' will never be NULL since it isn't a plain pointer but an array > of u32 values. > > This fixes the following

Re: [PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-22 Thread Grant Grundler
[resending as plain text only - sorry] Ping? Any feedback on this patch? LGTM. cheers, grant On Thu, Mar 16, 2017 at 3:26 PM, Matthias Kaehlcke wrote: > 'perms' will never be NULL since it isn't a plain pointer but an array > of u32 values. > > This fixes the following warning when building

[PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-16 Thread Matthias Kaehlcke
'perms' will never be NULL since it isn't a plain pointer but an array of u32 values. This fixes the following warning when building with clang: security/selinux/ss/services.c:158:16: error: address of array 'p_in->perms' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]

[PATCH] selinux: Remove unnecessary check of array base in selinux_set_mapping()

2017-03-16 Thread Matthias Kaehlcke
'perms' will never be NULL since it isn't a plain pointer but an array of u32 values. This fixes the following warning when building with clang: security/selinux/ss/services.c:158:16: error: address of array 'p_in->perms' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]