Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-20 Thread Dan Carpenter
On Fri, Jun 20, 2014 at 12:46:33PM +0200, Rickard Strandqvist wrote: > Hi > > It's a bit confusing with this, I have received a lot of complaints > that I have not had a cover letter. > When should I include it? In an obvious patching. But where there's a > need to explain anything further should

Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-20 Thread Rickard Strandqvist
Hi It's a bit confusing with this, I have received a lot of complaints that I have not had a cover letter. When should I include it? In an obvious patching. But where there's a need to explain anything further should have a cover letter. In this case, I suspected that there is a missed special

Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-20 Thread Rickard Strandqvist
Hi It's a bit confusing with this, I have received a lot of complaints that I have not had a cover letter. When should I include it? In an obvious patching. But where there's a need to explain anything further should have a cover letter. In this case, I suspected that there is a missed special

Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-20 Thread Dan Carpenter
On Fri, Jun 20, 2014 at 12:46:33PM +0200, Rickard Strandqvist wrote: Hi It's a bit confusing with this, I have received a lot of complaints that I have not had a cover letter. When should I include it? In an obvious patching. But where there's a need to explain anything further should have

Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-16 Thread Dan Carpenter
On Sun, Jun 15, 2014 at 07:20:57PM +0200, Rickard Strandqvist wrote: > The same code regardless of the outcome of the if statement. This may of > course be a miss and there should be a difference in the code. > And clean up another duplicate line of code. > > This was partly found using a static

Re: [PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-16 Thread Dan Carpenter
On Sun, Jun 15, 2014 at 07:20:57PM +0200, Rickard Strandqvist wrote: The same code regardless of the outcome of the if statement. This may of course be a miss and there should be a difference in the code. And clean up another duplicate line of code. This was partly found using a static code

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-15 Thread Rickard Strandqvist
The same code regardless of the outcome of the if statement. And clean up another duplicate line of code. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-15 Thread Rickard Strandqvist
The same code regardless of the outcome of the if statement. This may of course be a miss and there should be a difference in the code. And clean up another duplicate line of code. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): staging:

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-15 Thread Rickard Strandqvist
The same code regardless of the outcome of the if statement. And clean up another duplicate line of code. Signed-off-by: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se --- drivers/staging/rtl8712/rtl871x_ioctl_linux.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions(-)

[PATCH] staging: rtl8712: rtl871x_ioctl_linux.c: Cleaning up useless if statement

2014-06-15 Thread Rickard Strandqvist
The same code regardless of the outcome of the if statement. This may of course be a miss and there should be a difference in the code. And clean up another duplicate line of code. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): staging: