Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Jeremiah Mahler
Xunlei, On Tue, Dec 02, 2014 at 11:00:26PM +0800, Xunlei Pang wrote: > On 2 December 2014 at 17:32, Jeremiah Mahler wrote: > > John, > > > > On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: > >> In commit 6067dc5a8c2b ("time: Avoid possible NTP adjustment mult > >> @@ -1330,7 +1330,7

Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Xunlei Pang
On 2 December 2014 at 17:32, Jeremiah Mahler wrote: > John, > > On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: >> In commit 6067dc5a8c2b ("time: Avoid possible NTP adjustment mult >> overflow") a new check was added to watch for adjustments that could >> cause a mult overflow. >> >>

Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Jeremiah Mahler
John, On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: > In commit 6067dc5a8c2b ("time: Avoid possible NTP adjustment mult > overflow") a new check was added to watch for adjustments that could > cause a mult overflow. > > Unfortunately the check compares a signed with unsigned value

Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Jeremiah Mahler
John, On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: In commit 6067dc5a8c2b (time: Avoid possible NTP adjustment mult overflow) a new check was added to watch for adjustments that could cause a mult overflow. Unfortunately the check compares a signed with unsigned value and

Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Xunlei Pang
On 2 December 2014 at 17:32, Jeremiah Mahler jmmah...@gmail.com wrote: John, On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: In commit 6067dc5a8c2b (time: Avoid possible NTP adjustment mult overflow) a new check was added to watch for adjustments that could cause a mult

Re: [PATCH] time: Fix sign bug in ntp mult overflow warning

2014-12-02 Thread Jeremiah Mahler
Xunlei, On Tue, Dec 02, 2014 at 11:00:26PM +0800, Xunlei Pang wrote: On 2 December 2014 at 17:32, Jeremiah Mahler jmmah...@gmail.com wrote: John, On Mon, Nov 24, 2014 at 08:35:45PM -0800, John Stultz wrote: In commit 6067dc5a8c2b (time: Avoid possible NTP adjustment mult @@ -1330,7

[PATCH] time: Fix sign bug in ntp mult overflow warning

2014-11-24 Thread John Stultz
In commit 6067dc5a8c2b ("time: Avoid possible NTP adjustment mult overflow") a new check was added to watch for adjustments that could cause a mult overflow. Unfortunately the check compares a signed with unsigned value and ignored the case where the adjustment was negative, which causes spurious

[PATCH] time: Fix sign bug in ntp mult overflow warning

2014-11-24 Thread John Stultz
In commit 6067dc5a8c2b (time: Avoid possible NTP adjustment mult overflow) a new check was added to watch for adjustments that could cause a mult overflow. Unfortunately the check compares a signed with unsigned value and ignored the case where the adjustment was negative, which causes spurious