Re: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts

2019-09-07 Thread Jarkko Sakkinen
On Fri, 2019-09-06 at 14:37 +0200, Jan Lübbe wrote: > This is due to the SPI accesses performed by tis_int_handler (which > will sleep). Switching to devm_request_threaded_irq fixes this and > leads to a successful IRQ probe. Aah, right through tpm_tis_read32/write32(). This is definitely a new

Re: [PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts

2019-09-06 Thread Jan Lübbe
On Thu, 2019-08-29 at 20:09 -0400, Stefan Berger wrote: > From: Stefan Berger > > The tpm_tis_core has to set the TPM_CHIP_FLAG_IRQ before probing for > interrupts since there is no other place in the code that would set > it. Thanks for this patch! I tested it to fix a [ 13.198129] tpm

[PATCH] tpm_tis_core: Set TPM_CHIP_FLAG_IRQ before probing for interrupts

2019-08-29 Thread Stefan Berger
From: Stefan Berger The tpm_tis_core has to set the TPM_CHIP_FLAG_IRQ before probing for interrupts since there is no other place in the code that would set it. Cc: linux-sta...@vger.kernel.org Fixes: 570a36097f30 ("tpm: drop 'irq' from struct tpm_vendor_specific") Signed-off-by: Stefan Berger