Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Alan Hourihane
On Fri, 2007-04-20 at 21:51 +0800, Antonino A. Daplas wrote: > On Fri, 2007-04-20 at 10:04 +0100, Alan Hourihane wrote: > > I've updated the Vermilion Range (LE80578) patch against linus' tree. > > > > Hopefully this rectifies all of the issues noted previously. > > > > Let me know again if

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Antonino A. Daplas
On Fri, 2007-04-20 at 10:04 +0100, Alan Hourihane wrote: > I've updated the Vermilion Range (LE80578) patch against linus' tree. > > Hopefully this rectifies all of the issues noted previously. > > Let me know again if there's more updates needed. > > Thanks to all who responded with the

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Alan Hourihane
I've updated the Vermilion Range (LE80578) patch against linus' tree. Hopefully this rectifies all of the issues noted previously. Let me know again if there's more updates needed. Thanks to all who responded with the feedback, it was appreciated. Alan. diff --git a/drivers/video/Kconfig

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Alan Hourihane
I've updated the Vermilion Range (LE80578) patch against linus' tree. Hopefully this rectifies all of the issues noted previously. Let me know again if there's more updates needed. Thanks to all who responded with the feedback, it was appreciated. Alan. diff --git a/drivers/video/Kconfig

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Antonino A. Daplas
On Fri, 2007-04-20 at 10:04 +0100, Alan Hourihane wrote: I've updated the Vermilion Range (LE80578) patch against linus' tree. Hopefully this rectifies all of the issues noted previously. Let me know again if there's more updates needed. Thanks to all who responded with the feedback, it

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-20 Thread Alan Hourihane
On Fri, 2007-04-20 at 21:51 +0800, Antonino A. Daplas wrote: On Fri, 2007-04-20 at 10:04 +0100, Alan Hourihane wrote: I've updated the Vermilion Range (LE80578) patch against linus' tree. Hopefully this rectifies all of the issues noted previously. Let me know again if there's more

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-10 Thread Pavel Machek
Hi! > +struct cr_sys { > + struct vml_sys sys; > + struct pci_dev *mch_dev; > + struct pci_dev *lpc_dev; > + __u32 mch_bar; > + __u8 *mch_regs_base; > + __u32 gpio_bar; > + __u32 saved_panel_state; > + __u32 saved_clock; u32/u8 is right type to use here. >

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-10 Thread Pavel Machek
Hi! +struct cr_sys { + struct vml_sys sys; + struct pci_dev *mch_dev; + struct pci_dev *lpc_dev; + __u32 mch_bar; + __u8 *mch_regs_base; + __u32 gpio_bar; + __u32 saved_panel_state; + __u32 saved_clock; u32/u8 is right type to use here. +static struct

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-06 Thread Alan Hourihane
On Fri, 2007-04-06 at 08:09 +0800, Antonino A. Daplas wrote: > On Thu, 2007-04-05 at 11:44 +0100, Alan Hourihane wrote: > > Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion > > Range support. > > > > Intel funded Tungsten Graphics to do this work. > > > > If there's any

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-06 Thread Alan Hourihane
On Fri, 2007-04-06 at 08:09 +0800, Antonino A. Daplas wrote: On Thu, 2007-04-05 at 11:44 +0100, Alan Hourihane wrote: Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion Range support. Intel funded Tungsten Graphics to do this work. If there's any problems or

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Antonino A. Daplas
On Thu, 2007-04-05 at 11:44 +0100, Alan Hourihane wrote: > Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion > Range support. > > Intel funded Tungsten Graphics to do this work. > > If there's any problems or updates needed to be done to get accepted, > please let me know. >

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Antonino A. Daplas
On Thu, 2007-04-05 at 22:42 +0100, Alan Hourihane wrote: > On Thu, 2007-04-05 at 21:38 +0200, Arnd Bergmann wrote: > > On Thursday 05 April 2007, Alan Hourihane wrote: > > > @@ -0,0 +1,405 @@ > > > +/* > > > + * Copyright (c) Intel Corp. 2007. > > > + * All Rights Reserved. > > > + * > > > >

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Arnd Bergmann
On Thursday 05 April 2007, Alan Hourihane wrote: > As for the above, I've noticed that drivers/video/epson1355fb.c also has > this wording and is under the GPL. Yes, many files have it, but that doesn't make it right ;-) Arnd <>< - To unsubscribe from this list: send the line

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Alan Hourihane
On Thu, 2007-04-05 at 21:38 +0200, Arnd Bergmann wrote: > On Thursday 05 April 2007, Alan Hourihane wrote: > > @@ -0,0 +1,405 @@ > > +/* > > + * Copyright (c) Intel Corp. 2007. > > + * All Rights Reserved. > > + * > > Saying 'All Rights Reserved' is usually considered the opposite of >

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Alan Hourihane
On Thu, 2007-04-05 at 13:38 -0400, [EMAIL PROTECTED] wrote: > On Thu, 05 Apr 2007 11:44:46 BST, Alan Hourihane said: > > > Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion > > Range support. > > One non-technical question here... > > > +config FB_VERMILION > > + tristate

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread James Simmons
> One non-technical question here... > > > +config FB_VERMILION > > + tristate "Vermilion support" > > + depends on FB && PCI && X86 > > + select FB_MODE_HELPERS > > + select FB_CFB_FILLRECT > > + select FB_CFB_COPYAREA > > + select FB_CFB_IMAGEBLIT > > + help > > + This driver

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Valdis . Kletnieks
On Thu, 05 Apr 2007 11:44:46 BST, Alan Hourihane said: > Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion > Range support. One non-technical question here... > +config FB_VERMILION > + tristate "Vermilion support" > + depends on FB && PCI && X86 > + select

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread James Simmons
One non-technical question here... +config FB_VERMILION + tristate Vermilion support + depends on FB PCI X86 + select FB_MODE_HELPERS + select FB_CFB_FILLRECT + select FB_CFB_COPYAREA + select FB_CFB_IMAGEBLIT + help + This driver supports the Vermilion

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Alan Hourihane
On Thu, 2007-04-05 at 13:38 -0400, [EMAIL PROTECTED] wrote: On Thu, 05 Apr 2007 11:44:46 BST, Alan Hourihane said: Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion Range support. One non-technical question here... +config FB_VERMILION + tristate Vermilion

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Alan Hourihane
On Thu, 2007-04-05 at 21:38 +0200, Arnd Bergmann wrote: On Thursday 05 April 2007, Alan Hourihane wrote: @@ -0,0 +1,405 @@ +/* + * Copyright (c) Intel Corp. 2007. + * All Rights Reserved. + * Saying 'All Rights Reserved' is usually considered the opposite of licensing your code as

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Arnd Bergmann
On Thursday 05 April 2007, Alan Hourihane wrote: As for the above, I've noticed that drivers/video/epson1355fb.c also has this wording and is under the GPL. Yes, many files have it, but that doesn't make it right ;-) Arnd - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Antonino A. Daplas
On Thu, 2007-04-05 at 22:42 +0100, Alan Hourihane wrote: On Thu, 2007-04-05 at 21:38 +0200, Arnd Bergmann wrote: On Thursday 05 April 2007, Alan Hourihane wrote: @@ -0,0 +1,405 @@ +/* + * Copyright (c) Intel Corp. 2007. + * All Rights Reserved. + * Saying 'All Rights

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Antonino A. Daplas
On Thu, 2007-04-05 at 11:44 +0100, Alan Hourihane wrote: Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion Range support. Intel funded Tungsten Graphics to do this work. If there's any problems or updates needed to be done to get accepted, please let me know.

Re: [PATCH 01/01] New FBDev driver for Intel Vermilion Range

2007-04-05 Thread Valdis . Kletnieks
On Thu, 05 Apr 2007 11:44:46 BST, Alan Hourihane said: Attached is a patch against 2.6.21-rc5 which adds the Intel Vermilion Range support. One non-technical question here... +config FB_VERMILION + tristate Vermilion support + depends on FB PCI X86 + select FB_MODE_HELPERS