Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Mark Brown
On Thu, Sep 17, 2015 at 10:46:16AM +0200, Julia Lawall wrote: > The discussion was about introducing a temporary variable to simplify the > code. But that makes a lot of changes, so I think it would be better to > just apply the original bug fixing patch as is, and then the cleanup could > be

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Julia Lawall
Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; @@ if (IS_ERR(x) || ...) { ... when any when != IS_ERR(...) ( PTR_ERR(x) | * PTR_ERR(y) ) ... when any } //

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Julia Lawall
On Mon, 14 Sep 2015, Mark Brown wrote: > On Sun, Aug 30, 2015 at 08:05:10PM +0200, Julia Lawall wrote: > > Apply PTR_ERR to the value that was recently assigned. > > > > The semantic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > I have no idea what's going on

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Julia Lawall
On Mon, 14 Sep 2015, Mark Brown wrote: > On Sun, Aug 30, 2015 at 08:05:10PM +0200, Julia Lawall wrote: > > Apply PTR_ERR to the value that was recently assigned. > > > > The semantic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > I have no idea what's going on

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Mark Brown
On Thu, Sep 17, 2015 at 10:46:16AM +0200, Julia Lawall wrote: > The discussion was about introducing a temporary variable to simplify the > code. But that makes a lot of changes, so I think it would be better to > just apply the original bug fixing patch as is, and then the cleanup could > be

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-17 Thread Julia Lawall
Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; @@ if (IS_ERR(x) || ...) { ... when any when != IS_ERR(...) ( PTR_ERR(x) | * PTR_ERR(y) ) ... when any } //

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-14 Thread Mark Brown
On Sun, Aug 30, 2015 at 08:05:10PM +0200, Julia Lawall wrote: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) I have no idea what's going on with this stuff without spending more time than it

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-14 Thread Mark Brown
On Sun, Aug 30, 2015 at 08:05:10PM +0200, Julia Lawall wrote: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) I have no idea what's going on with this stuff without spending more time than it

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 12:54:15PM -0700, Julia Lawall wrote: > On Sun, 30 Aug 2015, walter harms wrote: > > Am 30.08.2015 20:05, schrieb Julia Lawall: > > > if (IS_ERR(drvdata->mi2s_bit_clk[dai_id])) { > > > dev_err(>dev, > > > "%s() error

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 11:54:33AM -0700, walter harms wrote: > Am 30.08.2015 20:05, schrieb Julia Lawall: > > if (IS_ERR(drvdata->mi2s_bit_clk[dai_id])) { > > dev_err(>dev, > > "%s() error getting mi2s-bit-clk: %ld\n", > > -

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 11:05:10AM -0700, Julia Lawall wrote: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any >

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 11:54:33AM -0700, walter harms wrote: > Am 30.08.2015 20:05, schrieb Julia Lawall: > > if (IS_ERR(drvdata->mi2s_bit_clk[dai_id])) { > > dev_err(>dev, > > "%s() error getting mi2s-bit-clk: %ld\n", > > -

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 11:05:10AM -0700, Julia Lawall wrote: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any >

Re: [alsa-devel] [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-09-03 Thread Kenneth Westfield
On Sun, Aug 30, 2015 at 12:54:15PM -0700, Julia Lawall wrote: > On Sun, 30 Aug 2015, walter harms wrote: > > Am 30.08.2015 20:05, schrieb Julia Lawall: > > > if (IS_ERR(drvdata->mi2s_bit_clk[dai_id])) { > > > dev_err(>dev, > > > "%s() error

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread Julia Lawall
On Sun, 30 Aug 2015, walter harms wrote: > > > Am 30.08.2015 20:05, schrieb Julia Lawall: > > Apply PTR_ERR to the value that was recently assigned. > > > > The semantic match that finds this problem is as follows: > > (http://coccinelle.lip6.fr/) > > > > // > > @@ > > expression x,y; > >

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread walter harms
Am 30.08.2015 20:05, schrieb Julia Lawall: > Apply PTR_ERR to the value that was recently assigned. > > The semantic match that finds this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression x,y; > @@ > > if (IS_ERR(x) || ...) { > ... when any > when !=

[PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread Julia Lawall
Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; @@ if (IS_ERR(x) || ...) { ... when any when != IS_ERR(...) ( PTR_ERR(x) | * PTR_ERR(y) ) ... when any } //

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread Julia Lawall
On Sun, 30 Aug 2015, walter harms wrote: Am 30.08.2015 20:05, schrieb Julia Lawall: Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression x,y; @@ if

[PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread Julia Lawall
Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression x,y; @@ if (IS_ERR(x) || ...) { ... when any when != IS_ERR(...) ( PTR_ERR(x) | * PTR_ERR(y) ) ... when any } //

Re: [PATCH 1/2] ASoC: qcom: change PTR_ERR argument

2015-08-30 Thread walter harms
Am 30.08.2015 20:05, schrieb Julia Lawall: Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression x,y; @@ if (IS_ERR(x) || ...) { ... when any when != IS_ERR(...)