Re: [PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-04 Thread Vladimir Murzin
On 3/4/21 5:42 AM, dillon min wrote: > Okay, got it. after adding msp/psp switch code in RTOS, now the kernel > can be loaded normally > without any modification. Yay! > > So, just drop the changes in proc-v7m.S. Glad to see they are not strictly necessary :) Thanks Vladimir

Re: [PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-03 Thread dillon min
On Wed, Mar 3, 2021 at 10:19 PM Vladimir Murzin wrote: > > On 3/3/21 1:35 PM, dillon min wrote: > > Hi Vladimir, > > > > Thanks for the review. > > > > On Wed, Mar 3, 2021 at 5:52 PM Vladimir Murzin > > wrote: > >> > >> On 3/3/21 8:05 AM, dillon.min...@gmail.com wrote: > >>> From: dillon min >

Re: [PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-03 Thread Vladimir Murzin
On 3/3/21 1:35 PM, dillon min wrote: > Hi Vladimir, > > Thanks for the review. > > On Wed, Mar 3, 2021 at 5:52 PM Vladimir Murzin > wrote: >> >> On 3/3/21 8:05 AM, dillon.min...@gmail.com wrote: >>> From: dillon min >>> >>> For some case, kernel not boot by u-boot(single thread), >>> but by

Re: [PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-03 Thread dillon min
Hi Vladimir, Thanks for the review. On Wed, Mar 3, 2021 at 5:52 PM Vladimir Murzin wrote: > > On 3/3/21 8:05 AM, dillon.min...@gmail.com wrote: > > From: dillon min > > > > For some case, kernel not boot by u-boot(single thread), > > but by rtos , as most rtos use pendsv to do context switch.

Re: [PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-03 Thread Vladimir Murzin
On 3/3/21 8:05 AM, dillon.min...@gmail.com wrote: > From: dillon min > > For some case, kernel not boot by u-boot(single thread), > but by rtos , as most rtos use pendsv to do context switch. Hmm, does it mean that it starts kernel from process context? I'd assume that it is not only kernel

[PATCH 1/8] ARM: ARMv7-M: Fix register restore corrupt after svc call

2021-03-03 Thread dillon . minfei
From: dillon min For some case, kernel not boot by u-boot(single thread), but by rtos , as most rtos use pendsv to do context switch. So, we need add an lr check after svc call, to find out should use psp or msp. else register restore after svc call might be corrupted. Fixes: b70cd406d7fe